GNU bug report logs - #73034
[PATCH] gnu: git: Fix perl search-paths of wrapped programs.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#73034: closed ([PATCH] gnu: git: Fix perl search-paths of
 wrapped programs.)
Date: Sun, 08 Sep 2024 12:13:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 08 Sep 2024 21:10:52 +0900
with message-id <874j6qfir7.fsf <at> gmail.com>
and subject line Re: [bug#73034] [PATCH v3 0/3] Fix annoyances of Git and update to 2.46.0
has caused the debbugs.gnu.org bug report #73034,
regarding [PATCH] gnu: git: Fix perl search-paths of wrapped programs.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
73034: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=73034
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Simon Tournier <zimon.toutoune <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Simon Tournier <zimon.toutoune <at> gmail.com>
Subject: [PATCH] gnu: git: Fix perl search-paths of wrapped programs.
Date: Thu,  5 Sep 2024 03:55:26 +0200

Fixes a regression introduced in f288604428e9c8f096ec9e0eccf207e079806271,
where the git-send-email and gitweb.cgi wrap-programs had translated into the
"new style" using G-exps.  See <https://issues.guix.gnu.org/73030>.

* gnu/packages/version-control.scm (git)[arguments]<phases>: Restore the
complete list of propagated inputs by modifying the functional composition
order.

Change-Id: Idfa33d9e5519aa9303b10138a166391244636ede
---
 gnu/packages/version-control.scm | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)

Hi,

Since there is no team, I guess, let CC people who submitted and reviewed the
initial patch. ;-)

Well, is this patch allowed to go to directly to master?  Because it triggers
888 rebuilds:

    $ ./pre-inst-env guix refresh -l git | cut -f1 -d':'
    Building the following 411 packages would ensure 888 dependent packages are rebuilt

Cheers,
simon

PS: Sent using this fix. ;-)  But an annoyance remains about Need MIME::Base64
and Authen::SASL; it requires perl-authen-sasl.


diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 1db783b731..d43382368b 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -55,6 +55,7 @@
 ;;; Copyright © 2024 Hilton Chain <hako <at> ultrarare.space>
 ;;; Copyright © 2023 Zheng Junjie <873216071 <at> qq.com>
 ;;; Copyright © 2024 Suhail Singh <suhail <at> bayesians.ca>
+;;; Copyright © 2024 Simon Tournier <zimon.toutoune <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -657,21 +658,24 @@ (define-public git
                       ,(search-path-as-list
                         '("lib/perl5/site_perl")
                         '#$(delete-duplicates
-                            (append-map
-                             (compose last package-transitive-propagated-inputs)
-                             (list (this-package-input "perl-authen-sasl")
-                                   (this-package-input "perl-net-smtp-ssl")
-                                   (this-package-input
-                                    "perl-io-socket-ssl")))))))
+                            (map last
+                                 (append-map
+                                  package-transitive-propagated-inputs
+                                  (list (this-package-input "perl-authen-sasl")
+                                        (this-package-input "perl-net-smtp-ssl")
+                                        (this-package-input
+                                         "perl-io-socket-ssl"))))))))
+
                   ;; Tell 'gitweb.cgi' where perl modules are.
                   (wrap-program (string-append out "/share/gitweb/gitweb.cgi")
                     `("PERL5LIB" ":" prefix
                       ,(search-path-as-list
                         '("lib/perl5/site_perl")
                         '#$(delete-duplicates
-                            (append-map
-                             (compose last package-transitive-propagated-inputs)
-                             (list (this-package-input "perl-cgi")))))))
+                            (map last
+                                 (append-map
+                                  package-transitive-propagated-inputs
+                                  (list (this-package-input "perl-cgi"))))))))
 
                   ;; Tell 'git-submodule' where Perl is.
                   (wrap-program git-sm

base-commit: ed95ddeb1e58c314f2e22b4cd35986042f3e2f21
-- 
2.45.2

[Message part 3 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Simon Tournier <zimon.toutoune <at> gmail.com>
Cc: ludo <at> gnu.org, 73034-done <at> debbugs.gnu.org, liliana.prikler <at> gmail.com
Subject: Re: [bug#73034] [PATCH v3 0/3] Fix annoyances of Git and update to
 2.46.0
Date: Sun, 08 Sep 2024 21:10:52 +0900

Hi Simon,

Simon Tournier <zimon.toutoune <at> gmail.com> writes:

> Re,
>
> On Fri, 06 Sep 2024 at 12:31, Simon Tournier <zimon.toutoune <at> gmail.com> wrote:
>
>>> I believe your argument 1. is going to affect any label-free package
>>> definitions needing additional origins copied in, so the issue is bigger
>>> than just this commit, in my opinion.
>
> [...]
>
>>                                        from my understanding, it changes
>> the scope of the work being reviewed but let take the opportunity to
>> discuss. :-)
>
> See submission #73073 <https://issues.guix.gnu.org/73073>.

Thanks for following up with concrete ideas.  It seems the discussion
still has some ways to go before we reach consensus there, but at least
it seems clear we do not want to go back to reintroducing labels, so
I've applied 1/3 and 3/3 but left out 2/3.

Thank you for fixing my botched wrapped-program phase translation :-).
We can now use 'git send-email' and friends easily again.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.