GNU bug report logs - #73034
[PATCH] gnu: git: Fix perl search-paths of wrapped programs.

Previous Next

Full log

View this message in rfc822 format

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Simon Tournier <zimon.toutoune <at> gmail.com>
Cc: ludo <at> gnu.org, 73034 <at> debbugs.gnu.org, liliana.prikler <at> gmail.com
Subject: [bug#73034] [PATCH v3 0/3] Fix annoyances of Git and update to 2.46.0
Date: Fri, 06 Sep 2024 13:17:33 +0900

Hi,

Simon Tournier <zimon.toutoune <at> gmail.com> writes:

> Hi,
>
> Since changes to the package Git imply large rebuilds, this series integrates
> submission #72413.
>
> Change since v2: Restore the ’origin’ of git-manpages under native-inputs.
>
> Commit f288604428e9c8f096ec9e0eccf207e079806271 moved the origin inside the phase.
>
> +          (add-after 'split 'install-man-pages
> +            (lambda _
> +              (let ((man (string-append #$output "/share/man")))
> +                (mkdir-p man)
> +                (with-directory-excursion man
> +                  (invoke
> +                   "tar" "xvf"
> +                   #$(origin
> +                       (method url-fetch)
> +                       (uri (string-append
> +                             "mirror://kernel.org/software/scm/git/"
> +                             "git-manpages-" version ".tar.xz"))
> +                       (sha256
> +                        (base32
> +                         "0xsqakgy0s60zpa13ilj6zj420kdh8pf4v3nrp1nziwj8ja4qymw"))))))))
>
> And this appears to me a bad idea, because 1. it makes harder to know what are
> the inputs and more importantly 2. it is hidden from procedure
> ’package-direct-sources’, which means it will not be archived.

I believe your argument 1. is going to affect any label-free package
definitions needing additional origins copied in, so the issue is bigger
than just this commit, in my opinion.

About 2; perhaps it'd be preferable to build the doc from source, if
that doesn't introduce cycles or too large of a native inputs graph.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.