From unknown Sun Aug 10 16:50:30 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#73034 <73034@debbugs.gnu.org> To: bug#73034 <73034@debbugs.gnu.org> Subject: Status: [PATCH] gnu: git: Fix perl search-paths of wrapped programs. Reply-To: bug#73034 <73034@debbugs.gnu.org> Date: Sun, 10 Aug 2025 23:50:30 +0000 retitle 73034 [PATCH] gnu: git: Fix perl search-paths of wrapped programs. reassign 73034 guix-patches submitter 73034 Simon Tournier severity 73034 normal tag 73034 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 04 21:56:43 2024 Received: (at submit) by debbugs.gnu.org; 5 Sep 2024 01:56:43 +0000 Received: from localhost ([127.0.0.1]:35793 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sm1jn-0006rw-1h for submit@debbugs.gnu.org; Wed, 04 Sep 2024 21:56:43 -0400 Received: from lists.gnu.org ([209.51.188.17]:40268) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sm1jk-0006rY-6V for submit@debbugs.gnu.org; Wed, 04 Sep 2024 21:56:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sm1ih-0002Wi-G9 for guix-patches@gnu.org; Wed, 04 Sep 2024 21:55:35 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sm1if-00018u-S6 for guix-patches@gnu.org; Wed, 04 Sep 2024 21:55:35 -0400 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-42bbe908380so1299625e9.2 for ; Wed, 04 Sep 2024 18:55:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725501332; x=1726106132; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Y2WANPo5CNllAp/7B65uY62eJ3nqRmupX00XPlbt3Bg=; b=U8zbhKvRkj7gs/T2gQIsC6gXfIEwp/OzYIxzW2Ol4BmMdww9YqEyWmorYMp+Ua3NNp oG0DwsHDi32FHc8bS4OsjBvPDuU2G3IRwLpMnQD/pc70mXhS1cYyxnV9Vl/aQNpHEr3Y Qwfb3h/JaACb/lf9gjWtuBReXljPRQoA/JX30VfMWOasDgFzE5ZQ/m4bKqNBs6B2z7cE u5Zt1zC4ltC4w7FEj0MwN+ZBfPTwKGBsNs+m3dw5xJxSh8gjM1nu4WRmadFfxBP2Rt0Z 1wBsx6q/yeNn1vJtP6gY4Js6bVhGXaug45TDbmnwjFljlXMZnr7SvCMcMkd6HVN2o6TP A2qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725501332; x=1726106132; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Y2WANPo5CNllAp/7B65uY62eJ3nqRmupX00XPlbt3Bg=; b=uViqNLKTyFY4PsEQe+h1TqXFApBQy4IIAZvhCD9bRwjZ2Ks8SWqB10468K0nW3smR9 ZoDrIxeTBfIKEss2D2rqQIgHEwKHuTAIuRd2ki7WLmye8eB9qs1kzZHF/rgeRyr+A8Zl gsTZSUNmkuL3VP1Qq1OVkic6BdBmMfmspZl5J35tu6Hz1YLpFu2nbXvnFSwtva4B43FQ ATHxF6oj/LCAmrbomct4jt3dAlXkhGGtXwL5UxA6pFELWzvN0ODl11SnD0TGVjAsjg4j AfXCvBVRbRUGRbq1vAmth/ZIboG3qhzYlDgMLwcCxSCSL7SQ6Cf82xT8Fx6f4ppt1k26 PSIA== X-Gm-Message-State: AOJu0Yz+6ih9LlOTCfTESX+dauTH7wguxzpFWoidmju/L1eRvTj/i2RM cR1UVwY0hJhyj01TmC/vVyIG/mECA9eqPI9qUbdE93kdNafbizjIKGwNbg== X-Google-Smtp-Source: AGHT+IGVJxTzzrxLZnPC1JLrlBICZ4W5fQqZc0pK0s/mJ411KwyasRVErwIYzsmMjGQh2vi3AU5e+g== X-Received: by 2002:a05:600c:1ca7:b0:427:d8fd:42a9 with SMTP id 5b1f17b1804b1-42bdc6375e2mr123183085e9.22.1725501331480; Wed, 04 Sep 2024 18:55:31 -0700 (PDT) Received: from lili.. ([2a01:e0a:59b:9120:b32f:9ceb:a68d:c5bf]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42bb6deb43esm219706775e9.7.2024.09.04.18.55.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Sep 2024 18:55:30 -0700 (PDT) From: Simon Tournier To: guix-patches@gnu.org Subject: [PATCH] gnu: git: Fix perl search-paths of wrapped programs. Date: Thu, 5 Sep 2024 03:55:26 +0200 Message-ID: <15bfd834d58da9d8910b0945689aa8cd4e8ff48c.1725498442.git.zimon.toutoune@gmail.com> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=zimon.toutoune@gmail.com; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Simon Tournier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Fixes a regression introduced in f288604428e9c8f096ec9e0eccf207e079806271, where the git-send-email and gitweb.cgi wrap-programs had translated into the "new style" using G-exps. See . * gnu/packages/version-control.scm (git)[arguments]: Restore the complete list of propagated inputs by modifying the functional composition order. Change-Id: Idfa33d9e5519aa9303b10138a166391244636ede --- gnu/packages/version-control.scm | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) Hi, Since there is no team, I guess, let CC people who submitted and reviewed the initial patch. ;-) Well, is this patch allowed to go to directly to master? Because it triggers 888 rebuilds: $ ./pre-inst-env guix refresh -l git | cut -f1 -d':' Building the following 411 packages would ensure 888 dependent packages are rebuilt Cheers, simon PS: Sent using this fix. ;-) But an annoyance remains about Need MIME::Base64 and Authen::SASL; it requires perl-authen-sasl. diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm index 1db783b731..d43382368b 100644 --- a/gnu/packages/version-control.scm +++ b/gnu/packages/version-control.scm @@ -55,6 +55,7 @@ ;;; Copyright © 2024 Hilton Chain ;;; Copyright © 2023 Zheng Junjie <873216071@qq.com> ;;; Copyright © 2024 Suhail Singh +;;; Copyright © 2024 Simon Tournier ;;; ;;; This file is part of GNU Guix. ;;; @@ -657,21 +658,24 @@ (define-public git ,(search-path-as-list '("lib/perl5/site_perl") '#$(delete-duplicates - (append-map - (compose last package-transitive-propagated-inputs) - (list (this-package-input "perl-authen-sasl") - (this-package-input "perl-net-smtp-ssl") - (this-package-input - "perl-io-socket-ssl"))))))) + (map last + (append-map + package-transitive-propagated-inputs + (list (this-package-input "perl-authen-sasl") + (this-package-input "perl-net-smtp-ssl") + (this-package-input + "perl-io-socket-ssl")))))))) + ;; Tell 'gitweb.cgi' where perl modules are. (wrap-program (string-append out "/share/gitweb/gitweb.cgi") `("PERL5LIB" ":" prefix ,(search-path-as-list '("lib/perl5/site_perl") '#$(delete-duplicates - (append-map - (compose last package-transitive-propagated-inputs) - (list (this-package-input "perl-cgi"))))))) + (map last + (append-map + package-transitive-propagated-inputs + (list (this-package-input "perl-cgi")))))))) ;; Tell 'git-submodule' where Perl is. (wrap-program git-sm base-commit: ed95ddeb1e58c314f2e22b4cd35986042f3e2f21 -- 2.45.2 From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 04 22:40:14 2024 Received: (at 73034) by debbugs.gnu.org; 5 Sep 2024 02:40:14 +0000 Received: from localhost ([127.0.0.1]:35815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sm2Pt-0001ZQ-W1 for submit@debbugs.gnu.org; Wed, 04 Sep 2024 22:40:14 -0400 Received: from mail-wr1-f44.google.com ([209.85.221.44]:46114) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sm2Pp-0001Yc-V7 for 73034@debbugs.gnu.org; Wed, 04 Sep 2024 22:40:13 -0400 Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-371ba7e46easo135758f8f.0 for <73034@debbugs.gnu.org>; Wed, 04 Sep 2024 19:39:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725503879; x=1726108679; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=mRW+rRV+eD0WvBRF3tyk2hzdbcQqpWiT8kgN+ZQEUAE=; b=S4Ugjd+w9WwW5UJiZFw0w6YJLd0XNKQvvVArBM69jm8vzW/CjziwU8M86oda+MCGEw YIOmWDxZoqXDvh34bVR2/1+wOUkluHHPHE30XWAauu444w0hVCW52OQrOVTFZzBC9AaY 6pzgraQQkciq90IFaLS4omL9ZsMs5MBiEaobefTrKndk2+L+sAQjKjSqvzftb1Ojf4zr aWnqLeK4L5RwhzUtkQU7YlqrIxCBBmjdlVrmlwA2DZCpyNv+u3vdvYV7cc+LhbXfD+f+ QlOEDymEWJPynhgWUbuM67q2iuCI1jw+N4IDP6uZFyD6hdXpZXlBNpOKyYp7HOii8pNQ U8mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725503879; x=1726108679; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mRW+rRV+eD0WvBRF3tyk2hzdbcQqpWiT8kgN+ZQEUAE=; b=aAOhIFJbU26xqvnLCdpF2X/Su4UY9DzDo5Nsfb+iL3f7Ewfaw4tU4yTjNgefFW5Uxv Y7a231izmA2gwXjGzwD/uCIRzfQ+5nt7c+hN318YEFbBNxpDnSwyg1/+fhJ9FA5SpZ4d 9gIB8Q0nhO8ZumzsqRc6xgKNtPt3YL1VIO6FUs+gdHKww4eaClniqNvOLLZlZ4M7bqob tI1pqZcTjA5GPc3/hSZh527seowcJdeR7StxM4TEI787vF76Wu856Tx1u6vUKjuxmMV9 40sQ33FKoPtC+0nY6Kt8nDJxUHXyWCd5JJv2+UvocSqDUtMmgNimbTtNiLfmzcs5jWO/ PpPA== X-Gm-Message-State: AOJu0YybPFv602Av35Z01ol5kFea9OlwLsZND7nLZeojUUDwn7RgC3VD 5q+ub9Aj2sCRAdFCARJWQ9UdZTyUhc5NtJdLe8ANtRt1vvxyd7blOaToUA== X-Google-Smtp-Source: AGHT+IGCEWxvs6fDAlF42B5Uv0jOffRk49O/RfJ3uQyvTC/WacMh8ly6l3y6Sl0AajwMSdE0ECB6Ig== X-Received: by 2002:a5d:630f:0:b0:371:9362:c286 with SMTP id ffacd0b85a97d-374bce98712mr11110227f8f.4.1725503879235; Wed, 04 Sep 2024 19:37:59 -0700 (PDT) Received: from lili.. ([2a01:e0a:59b:9120:b32f:9ceb:a68d:c5bf]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3749ee4ac81sm18115236f8f.14.2024.09.04.19.37.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Sep 2024 19:37:58 -0700 (PDT) From: Simon Tournier To: 73034@debbugs.gnu.org Subject: [PATCH v2] gnu: git: Fix perl search-paths of wrapped programs. Date: Thu, 5 Sep 2024 04:37:53 +0200 Message-ID: <8c204cfb8764c7f284775b68ee55998dbc32d17e.1725503559.git.zimon.toutoune@gmail.com> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 X-Debbugs-CC: maxim.cournoyer@gmail.com, liliana.prikler@gmail.com, ludo@gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73034 Cc: Simon Tournier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Fixes a regression introduced in f288604428e9c8f096ec9e0eccf207e079806271, where the git-send-email and gitweb.cgi wrap-programs had translated into the "new style" using G-exps. See . * gnu/packages/version-control.scm (git)[arguments]: Restore the complete list of propagated inputs by modifying the functional composition order. Change-Id: Ia4e5feeae6418a9f098464556b74bc871e761be1 --- gnu/packages/version-control.scm | 29 ++++++++++++++++++++--------- 1 file changed, 20 insertions(+), 9 deletions(-) Hi, Change since v1: 'package-transitive-propagated-inputs' does not return the package itself, so let manually add it. Cheers, simon diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm index 1db783b731..b8192035c2 100644 --- a/gnu/packages/version-control.scm +++ b/gnu/packages/version-control.scm @@ -55,6 +55,7 @@ ;;; Copyright © 2024 Hilton Chain ;;; Copyright © 2023 Zheng Junjie <873216071@qq.com> ;;; Copyright © 2024 Suhail Singh +;;; Copyright © 2024 Simon Tournier ;;; ;;; This file is part of GNU Guix. ;;; @@ -657,21 +658,31 @@ (define-public git ,(search-path-as-list '("lib/perl5/site_perl") '#$(delete-duplicates - (append-map - (compose last package-transitive-propagated-inputs) - (list (this-package-input "perl-authen-sasl") - (this-package-input "perl-net-smtp-ssl") - (this-package-input - "perl-io-socket-ssl"))))))) + (let ((these-inputs + (list (this-package-input "perl-authen-sasl") + (this-package-input "perl-net-smtp-ssl") + (this-package-input "perl-io-socket-ssl")))) + (append + these-inputs + (map last + (append-map + package-transitive-propagated-inputs + these-inputs)))))))) + ;; Tell 'gitweb.cgi' where perl modules are. (wrap-program (string-append out "/share/gitweb/gitweb.cgi") `("PERL5LIB" ":" prefix ,(search-path-as-list '("lib/perl5/site_perl") '#$(delete-duplicates - (append-map - (compose last package-transitive-propagated-inputs) - (list (this-package-input "perl-cgi"))))))) + (let ((these-inputs + (list (this-package-input "perl-cgi")))) + (append + these-inputs + (map last + (append-map + package-transitive-propagated-inputs + these-inputs)))))))) ;; Tell 'git-submodule' where Perl is. (wrap-program git-sm base-commit: ed95ddeb1e58c314f2e22b4cd35986042f3e2f21 -- 2.45.2 From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 05 08:48:43 2024 Received: (at 73034) by debbugs.gnu.org; 5 Sep 2024 12:48:43 +0000 Received: from localhost ([127.0.0.1]:36375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smBul-0006Ho-4B for submit@debbugs.gnu.org; Thu, 05 Sep 2024 08:48:43 -0400 Received: from anamika.lostca.se ([65.21.75.227]:41812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smBuj-0006HB-74 for 73034@debbugs.gnu.org; Thu, 05 Sep 2024 08:48:41 -0400 Received: from localhost (unknown [103.55.60.118]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: abbe) by anamika.lostca.se (Postfix) with ESMTPSA id 549B7279F0; Thu, 5 Sep 2024 12:47:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lostca.se; s=anamika; t=1725540449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to; bh=ybw/2p7PLKzBO/xF40Lwbdoe6WXpLfQmvMJmbBlZB0U=; b=pkHgXKRqhri4HS/CSTC0C2eCVfnvEn2nzT0zipiWIXQk8VAN6Mj+CaG7DFsKwq2EfSxxgm STwoC6yLsb83+SWDWN04tJGjmgqg6G0RBNSkSS9zX1WraBZXn7ZTaCJkPTTp/1FcpSGc4v a95uFO/4YD+eJxxDCYuCjSaHLVZtzk4= Mime-Version: 1.0 Content-Type: multipart/signed; boundary=183f2eae05d4375ec851ffbfba7cf7a341cbf75bb39e6f2f6950e8162adb; micalg=pgp-sha512; protocol="application/pgp-signature" Date: Thu, 05 Sep 2024 18:17:27 +0530 Message-Id: From: "Ashish SHUKLA" To: <73034@debbugs.gnu.org> In-Reply-To: 15bfd834d58da9d8910b0945689aa8cd4e8ff48c.1725498442.git.zimon.toutoune@gmail.com Subject: Re: [PATCH] gnu: git: Fix perl search-paths of wrapped programs. X-Mailer: aerc 0.18.2 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73034 Cc: Simon Tournier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --183f2eae05d4375ec851ffbfba7cf7a341cbf75bb39e6f2f6950e8162adb Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8; format=Flowed Hi, If we're going to apply this patch which would trigger so many rebuilds, I suggest combining it with git 2.46.0 update, I sent in issue #72413[0] Also, this patch fixed, git-send-email for me. [0] https://issues.guix.gnu.org/72413 Thanks! -- Ashish --183f2eae05d4375ec851ffbfba7cf7a341cbf75bb39e6f2f6950e8162adb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKoBAABCgCSFiEE9oLNzDncD+rhFiC2x0bPqedPpLAFAmbZqF9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY2 ODJDRENDMzlEQzBGRUFFMTE2MjBCNkM3NDZDRkE5RTc0RkE0QjAUHGFzaGlzaC5p c0Bsb3N0Y2Euc2UACgkQx0bPqedPpLBGhxAAjx2rFJApF/vy57BzxJReHZQE5efi cc3gpNl+L1He14cGByaVvmJa7ZQ7NNsjfV1f1wTIxFP7jXaXV70bScBEcL61zFJh 7cjvtcUltlJAl5ykwY411MUzKkHP6h18jepnkRmxJgpflyzevwEdJDdvTN6LGOpW nSXGvFYOyjM2WiLA17ylr8b9XfIFiknCbdtzdiT7bbMmVy++u2RuUTqpNEHCp2t7 rR3B/UtQOJyQlivJOodZOBTVZNyYXYacy5C8ydWAhJsoqFFF0qyj4/YNZJMEECSs 9FktXb2i0RezNAWjyTB0C2AsD3FkNBTi0h28leEYeWl6yhTBXyEZAcn9yJQKHRK4 Y/Cc7Wm+fM11A6B1LqwyzxjEMl6fVj/eJqpCSuaXQRZZsm4/E73pZtpadaKo/4R1 QX3GtQHAHMYRXBayRJLtQC8g39HG4yDDv1UKVPxsPG2U0OvKzLkm4wKx/mTpDFz2 QjBycgMs2o+nxplPNKlHZTf6hA6yWXymkemk/dA2aS7hcEa5B/SAS1ZBrbUg+u7L e6Wq6ntgpD96HRCWUt2gd86FDQ4Pi/XtYYBb7PtQ+fFxQ0REzMlIZfHH+caxYZ43 9FxYnJnMVsGJ65ei04Lf+TLp0KcsjNojEHyF+kQZ/Q62Cy+q//idRlHfGKa3b9tL wDPm3OZqARYF02s= =NRNy -----END PGP SIGNATURE----- --183f2eae05d4375ec851ffbfba7cf7a341cbf75bb39e6f2f6950e8162adb-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 05 11:43:28 2024 Received: (at 73034) by debbugs.gnu.org; 5 Sep 2024 15:43:28 +0000 Received: from localhost ([127.0.0.1]:37909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smEdr-000367-NF for submit@debbugs.gnu.org; Thu, 05 Sep 2024 11:43:28 -0400 Received: from mail-lj1-f170.google.com ([209.85.208.170]:48284) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smEdp-00035g-5a for 73034@debbugs.gnu.org; Thu, 05 Sep 2024 11:43:26 -0400 Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2f64e82aeacso11754251fa.0 for <73034@debbugs.gnu.org>; Thu, 05 Sep 2024 08:42:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725550874; x=1726155674; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IrWkk8yCaQl0kbRotydQwhkflcjpHcV75mjI1VbrUN0=; b=Fb3ITHWt6QHQbxxALcDyNA13ZR3fFpFNkiiwKDyatjPpDo3c9bxctHDOk4i9yNy2Eu lRh1TF6VvSqhuJaCI5etg6LPmBiMi/3M564wb/VPjAFztNdyb9QkPNjTV0FTMqVPGpVq fknDPb8pIWPCjEsYx20LKAjnauyHajEKNoiM4W9flgcuri5mXGa0Tc28oB9jC8mT0fVw lsbY3uwdfAV7vAzjoBXmOy5d7I2NBmTDyrQD35KaaEBsgMldfvnCywiRONUyIbe1IA2T 4VFpGeMAkvR4sNjlWl7W0D3lRwUDHwckVOfzcXs94FMoU4nVpK8bnFcwonBNutaGqmvo zGHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725550874; x=1726155674; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IrWkk8yCaQl0kbRotydQwhkflcjpHcV75mjI1VbrUN0=; b=oDaPg1oBfyQD5Pfl8UomTBX0JPuKt2k7AKTDBpNceUx1Wc0k3t63i4IfBhKjzeW1Vc XFZ7VO8X7XbbmlYwQdwSL9dg1ytwBvL9Nn6C0KuH/WdQKu9IsTNfZetL+noKY2KUKOf9 Y0i0y3YpkYy5ecoLmx8DwWnwujy2uMD+s0jRM9x/ECT7PPkVRUoU11EoOAQjZ1r14QC2 Qn5egEsROwekZdTKmyUTcHZ6BhQOnr5wEXQbR79t1bLu4d11slUttw4Pq3+U+4n5mD2y BdvhvTaD13SvwsuYX5CVDpzE7YIVjNy5s7nc7AZ0gmDBZhWDBE3e2WPaI6CHeoLJwCmV e7yQ== X-Gm-Message-State: AOJu0YwZsrAo0m3kiUkDBOtAWW7b+smz0I9TMIaIztaswc4kwbunHjep +pZxoSZTncLeSfg7YRauriS/X4OqbephmhHlg5alj0AsPQvFNTFpWOjNXA== X-Google-Smtp-Source: AGHT+IF5y2M/fnXcu9pouQbnLxFrrQmmeeIyzL/HlxNjTfPV5mrjJuXH/xmzs3aVbfbAgABKF6AiWQ== X-Received: by 2002:a05:600c:3c82:b0:42b:b016:94a3 with SMTP id 5b1f17b1804b1-42c88108590mr86990905e9.31.1725550511736; Thu, 05 Sep 2024 08:35:11 -0700 (PDT) Received: from lili.. ([2a01:e0a:59b:9120:4d6d:a7b0:20be:6231]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42c9bb7d3a4sm19365875e9.1.2024.09.05.08.35.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Sep 2024 08:35:11 -0700 (PDT) From: Simon Tournier To: 73034@debbugs.gnu.org Subject: [PATCH v3 1/3] gnu: git: Fix perl search-paths of wrapped programs. Date: Thu, 5 Sep 2024 17:34:48 +0200 Message-ID: <96af57a183e3829bef3da8586b7d255ce52c4cc1.1725550253.git.zimon.toutoune@gmail.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73034 Cc: Simon Tournier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Fixes a regression introduced in f288604428e9c8f096ec9e0eccf207e079806271, where the git-send-email and gitweb.cgi wrap-programs had translated into the "new style" using G-exps. See . * gnu/packages/version-control.scm (git)[arguments]: Restore the complete list of propagated inputs by modifying the functional composition order. Change-Id: Ia4e5feeae6418a9f098464556b74bc871e761be1 --- gnu/packages/version-control.scm | 29 ++++++++++++++++++++--------- 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm index 1db783b731..b8192035c2 100644 --- a/gnu/packages/version-control.scm +++ b/gnu/packages/version-control.scm @@ -55,6 +55,7 @@ ;;; Copyright © 2024 Hilton Chain ;;; Copyright © 2023 Zheng Junjie <873216071@qq.com> ;;; Copyright © 2024 Suhail Singh +;;; Copyright © 2024 Simon Tournier ;;; ;;; This file is part of GNU Guix. ;;; @@ -657,21 +658,31 @@ (define-public git ,(search-path-as-list '("lib/perl5/site_perl") '#$(delete-duplicates - (append-map - (compose last package-transitive-propagated-inputs) - (list (this-package-input "perl-authen-sasl") - (this-package-input "perl-net-smtp-ssl") - (this-package-input - "perl-io-socket-ssl"))))))) + (let ((these-inputs + (list (this-package-input "perl-authen-sasl") + (this-package-input "perl-net-smtp-ssl") + (this-package-input "perl-io-socket-ssl")))) + (append + these-inputs + (map last + (append-map + package-transitive-propagated-inputs + these-inputs)))))))) + ;; Tell 'gitweb.cgi' where perl modules are. (wrap-program (string-append out "/share/gitweb/gitweb.cgi") `("PERL5LIB" ":" prefix ,(search-path-as-list '("lib/perl5/site_perl") '#$(delete-duplicates - (append-map - (compose last package-transitive-propagated-inputs) - (list (this-package-input "perl-cgi"))))))) + (let ((these-inputs + (list (this-package-input "perl-cgi")))) + (append + these-inputs + (map last + (append-map + package-transitive-propagated-inputs + these-inputs)))))))) ;; Tell 'git-submodule' where Perl is. (wrap-program git-sm -- 2.45.2 From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 05 11:55:11 2024 Received: (at 73034) by debbugs.gnu.org; 5 Sep 2024 15:55:11 +0000 Received: from localhost ([127.0.0.1]:37916 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smEpC-0003uR-QI for submit@debbugs.gnu.org; Thu, 05 Sep 2024 11:55:11 -0400 Received: from mail-wm1-f50.google.com ([209.85.128.50]:55481) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smEXy-0002fU-4M for 73034@debbugs.gnu.org; Thu, 05 Sep 2024 11:37:22 -0400 Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-42bbd16fcf2so7928545e9.2 for <73034@debbugs.gnu.org>; Thu, 05 Sep 2024 08:36:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725550511; x=1726155311; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=yJK5xMo4qJ3K0PwRWAm6ksq0BMDBa/CwfPpqMHgr5nw=; b=GraFS9EGPd/MqACHYpQV7TNpl8iu/VJh0G/ozzqQuV4T2NxW2pmpa0AU1TDRGFPyTH 3xxfeU2hOTPvNmhCFGCA5KP5wKl3vs/REcsvoyJFYhbH2lwqy+DrqeXfjU4c2RzLZCY9 U3BIZwtNSmMfbqX6kFAYmFz9/RlO8Q7ZXwcyaL+vdGbOqjWrTAwHkupEJfMPFOps3Ma/ QWbzk+NuhDHsiiXe1w/nuuI55na5xD9lzMWJWOvxv3Ue0YvuOSpGt7oAfZ+HCwp3B+rl ImRwP/YyAtOChs22C5vJonuogFdu+lF6l6OBGIZs0NrUGhoGoJMN8EdM/cylaPohQkxw /iHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725550511; x=1726155311; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yJK5xMo4qJ3K0PwRWAm6ksq0BMDBa/CwfPpqMHgr5nw=; b=Bn3OGnKxa4WaTXCbQqO2/dtd5EyD6qg2ha9fR3tRKCbqLXVmD9WpMedPY7DD4XKVq4 RYequp0COczPok6NiJQk+4JaFrlZWduatEtuV99TLIss37cSF3Hec8+tOsHPxYs7BMAc cmtIUVqZMsNrkl1pZlAKXXtq4FGKA150uimK7cSqqC3quzpjCi+spW9CvmdzELPpQ3Ni doHy8mer7nwAfsluTaxbBfdQyJ+n1sEYmdulWI7oEoecCbcdWKHTZTQgOU74GyW4DC4d VPAldxve72O7JqwlS13clVKOHtAO8FzfCDdue3fpSXKIt/wOBoLQca+LVWsxHJYx6php ybYw== X-Gm-Message-State: AOJu0Yz+GEKZKzg00/phbzVtg13jAp8DQcjVFMz+AXRGxpFxgX2iXCDh UwhVGAbeiLTCnerR6PKj2ZV+2xTELXO5v2DFL8F1bRmkZTsa4bQ1EJbqDA== X-Google-Smtp-Source: AGHT+IGUOSJjyM7Y5m+wP31OiHzKn3urgRXixpjxqRFVjzxXCX0D1CRQv8vVh7TOKpiXE9XNGqdzUQ== X-Received: by 2002:a05:600c:3549:b0:426:6379:3b4f with SMTP id 5b1f17b1804b1-42bb01fb8d4mr177229895e9.31.1725550510455; Thu, 05 Sep 2024 08:35:10 -0700 (PDT) Received: from lili.. ([2a01:e0a:59b:9120:4d6d:a7b0:20be:6231]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42c9bb7d3a4sm19365875e9.1.2024.09.05.08.35.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Sep 2024 08:35:09 -0700 (PDT) From: Simon Tournier To: 73034@debbugs.gnu.org Subject: [PATCH v3 0/3] Fix annoyances of Git and update to 2.46.0 Date: Thu, 5 Sep 2024 17:34:47 +0200 Message-ID: X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 X-Debbugs-CC: maxim.cournoyer@gmail.com, liliana.prikler@gmail.com, ludo@gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73034 Cc: Simon Tournier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Since changes to the package Git imply large rebuilds, this series integrates submission #72413. Change since v2: Restore the ’origin’ of git-manpages under native-inputs. Commit f288604428e9c8f096ec9e0eccf207e079806271 moved the origin inside the phase. --8<---------------cut here---------------start------------->8--- + (add-after 'split 'install-man-pages + (lambda _ + (let ((man (string-append #$output "/share/man"))) + (mkdir-p man) + (with-directory-excursion man + (invoke + "tar" "xvf" + #$(origin + (method url-fetch) + (uri (string-append + "mirror://kernel.org/software/scm/git/" + "git-manpages-" version ".tar.xz")) + (sha256 + (base32 + "0xsqakgy0s60zpa13ilj6zj420kdh8pf4v3nrp1nziwj8ja4qymw")))))))) --8<---------------cut here---------------end--------------->8--- And this appears to me a bad idea, because 1. it makes harder to know what are the inputs and more importantly 2. it is hidden from procedure ’package-direct-sources’, which means it will not be archived. Cheers, simon 1: https://issues.guix.gnu.org/72413 Ashish SHUKLA (1): gnu: git: Update to 2.46.0 Simon Tournier (2): gnu: git: Fix perl search-paths of wrapped programs. gnu: git: Move git-manpages origin from phases to native-inputs. gnu/packages/version-control.scm | 77 +++++++++++++++++++------------- 1 file changed, 47 insertions(+), 30 deletions(-) base-commit: 7d2ced8d6d9c38327592d312376d59a8c37fc160 -- 2.45.2 From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 05 11:55:11 2024 Received: (at 73034) by debbugs.gnu.org; 5 Sep 2024 15:55:11 +0000 Received: from localhost ([127.0.0.1]:37918 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smEpD-0003uZ-9z for submit@debbugs.gnu.org; Thu, 05 Sep 2024 11:55:11 -0400 Received: from mail-wm1-f41.google.com ([209.85.128.41]:50216) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smEY1-0002fj-CJ for 73034@debbugs.gnu.org; Thu, 05 Sep 2024 11:37:25 -0400 Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-42c94eb9822so7734045e9.0 for <73034@debbugs.gnu.org>; Thu, 05 Sep 2024 08:36:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725550514; x=1726155314; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RFXM8mKWiMDbU6hQRB/KR+LBIL5icqVRKU+526Ayvrk=; b=SRB1DDOagE3M8hgN2jyJUvpM/ugiYqDkJF2ma7iGbqsBHKWAtcnfou9T9/naOnOkoP 54SzD1i4IvBbLy3wgTU3Xe6qyYTqzJp5VIi6k2qmU5kD+JBYlR0IAOCc1mtc1vV0UwJ/ sSyUbpUCcSpDIMDsjnsPTY4Wkg42dDs+6U+a3yMwq6/mWEJ1gueWC8uWSOIXVE2BXN1v cu90m170DsOpeMK31zqT0jqxX9jmkeh+r0sSmdPAHZz7noK/WQqM2NZzB1g2FUYrymKs mVsmvMivmnWNCRnc+mVgbHA7bLR+mP80yqhSdMb8msRc5yEzld1GQ8/DwZ85FYL7ZwTy s4bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725550514; x=1726155314; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RFXM8mKWiMDbU6hQRB/KR+LBIL5icqVRKU+526Ayvrk=; b=O8Wx+bomortH+nQK28MKKLlWGGi3Dpq0Jp4bx5poVpfkuT8zyCGLtw5eW04lONclbT QKrTWihYnbovQP9iF1uZx1Hl9YnuHPbOclYubA8MVfPLmA5jyNwt1t22Pld43jROFHk9 ZaLYbmlewdwH3es+AhqbqsJkVqjd7+OmmjBJ+xYwJGGUKwlwfDapGHj4Hb7HPBMMUBzp yODoe2ROs9Ul43pY4wpQt49vfSi80vzc2VvJzbpG9yx9jxB3WE3PWJtYODECIWFM+Dkc /XzCMjWUyf+m1UA2imLyjasfPV9xPPOVNd9+eoG0rdUIjn1NdtdI/7Xs7+LpXAyzNHn+ TLMQ== X-Gm-Message-State: AOJu0YzPjXDRTXOjYauvrsFUpTUbaYOxagd14rdLSWSWz+Fki+XwnBxW RqsPWSmB3qSJcrPvM+LHv1JSOq/og6EC/SBH5/QGaLCrTjFw2chCHKpRxg== X-Google-Smtp-Source: AGHT+IFFsxnYTnjam3oIzVldxBKXzP3MDrsFY1nmv5dZ3IHbBaEOs2q0Derh/46ZHQ6aZ9XdZj937Q== X-Received: by 2002:a05:600c:3d18:b0:426:5c9b:dee6 with SMTP id 5b1f17b1804b1-42c7b5d8f7fmr109516335e9.26.1725550514390; Thu, 05 Sep 2024 08:35:14 -0700 (PDT) Received: from lili.. ([2a01:e0a:59b:9120:4d6d:a7b0:20be:6231]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42c9bb7d3a4sm19365875e9.1.2024.09.05.08.35.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Sep 2024 08:35:14 -0700 (PDT) From: Simon Tournier To: 73034@debbugs.gnu.org Subject: [PATCH v3 3/3] gnu: git: Move git-manpages origin from phases to native-inputs. Date: Thu, 5 Sep 2024 17:34:50 +0200 Message-ID: <3a6d3ee8f2768bef9f17196b82c47c99c2ea09f5.1725550253.git.zimon.toutoune@gmail.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73034 Cc: Simon Tournier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) The move from native-inputs to the install-man-pages phase had been done by f288604428e9c8f096ec9e0eccf207e079806271. * gnu/packages/version-control.scm (git)[arguments]: Move git-manpages origin from here... [native-inputs]: ...to here. Change-Id: I9fa543f7410bce6eb8a82d275eab81a1ea86ecc0 --- gnu/packages/version-control.scm | 44 ++++++++++++++++++-------------- 1 file changed, 25 insertions(+), 19 deletions(-) diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm index 9a4c2fdbdc..3e8f042d18 100644 --- a/gnu/packages/version-control.scm +++ b/gnu/packages/version-control.scm @@ -695,26 +695,32 @@ (define-public git (with-directory-excursion man (invoke "tar" "xvf" - #$(origin - (method url-fetch) - (uri (string-append - "mirror://kernel.org/software/scm/git/" - "git-manpages-" (package-version this-package) - ".tar.xz")) - (sha256 - (base32 - "1lvvhzypllbyd8j6m0p9qgd3gqg10gch9s7lqif8vr9n80fqn4fw")))))))))))) + #$(this-package-native-input "git-manpages")))))))))) (native-inputs - (modify-inputs (package-native-inputs git-minimal) - ;; For subtree documentation. - (append asciidoc - docbook2x - docbook-xml-4.5 - docbook-xsl - libxslt - pkg-config - texinfo - xmlto))) + (cons + ;; To build the man pages from the git sources, we would need a dependency + ;; on a full XML tool chain, and building it actually takes ages. So we + ;; use this lazy approach and use released tarball. + `("git-manpages" + ,(origin + (method url-fetch) + (uri (string-append + "mirror://kernel.org/software/scm/git/git-manpages-" + (package-version this-package) ".tar.xz")) + (sha256 + (base32 + "1lvvhzypllbyd8j6m0p9qgd3gqg10gch9s7lqif8vr9n80fqn4fw")))) + + (modify-inputs (package-native-inputs git-minimal) + ;; For subtree documentation. + (append asciidoc + docbook2x + docbook-xml-4.5 + docbook-xsl + libxslt + pkg-config + texinfo + xmlto)))) (inputs (modify-inputs (package-inputs git-minimal) (append bash-minimal ;for wrap-program -- 2.45.2 From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 05 13:28:46 2024 Received: (at 73034) by debbugs.gnu.org; 5 Sep 2024 17:28:46 +0000 Received: from localhost ([127.0.0.1]:38157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smGHm-0002p8-BS for submit@debbugs.gnu.org; Thu, 05 Sep 2024 13:28:46 -0400 Received: from mail-ed1-f48.google.com ([209.85.208.48]:54577) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smGHk-0002oX-8L for 73034@debbugs.gnu.org; Thu, 05 Sep 2024 13:28:44 -0400 Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-5becfd14353so1022942a12.1 for <73034@debbugs.gnu.org>; Thu, 05 Sep 2024 10:27:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725557193; x=1726161993; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9qswz4///odazH792uGQ/R48915t+eIg2mWpqF2k2fs=; b=Id2PkbDvqETnAPn3YQMGBZIAIGMGS7+PKZ3ZsKZX64hUzkpWgZiD4hqcZG9YxKjMzL j8PwMjzy90hn9USmFHsJgF1YDrS4TB3VpPPmE8Sva/pxj43Yc5qRXfJAU1fQ2ZFVEpcu MbhxhOaa2AC/q+HzwxZ43FrGSo3IcICpzZhuadupqcd4fHRZEvsZJvEo6N+hgBW4SC+7 Jyi0nbQiDxVJaYNk1xls8kjUGyBjW35Y7A5ah7MJGt7bbpfHuyubpTigJu8XIQFJBb0M W0gORS0CVgMOtfRO/S9xuRjDyemw8GS1MTC4V6/1wXrftkQWfVXHJxnVk7tqfXv2fmXC eAJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725557193; x=1726161993; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9qswz4///odazH792uGQ/R48915t+eIg2mWpqF2k2fs=; b=mBYxcfu3UCkBxcevoqwd6V4rqIBI4cyqSqh8TM/ldwENXqsdkfAyFMFTxvrIxJRBsP Q5+QLGFrZOK2M729arEtKhGmRm7TAzYCem0Y4ho998E7bTi15XQiq9+ZmZuhda2wNeAd /fwvP8fQoSUt0oeohoA3Tr/lCd4chgYl0lysfhclNI5fTlGxRN4c1CSFBj4vXDlys0PL 9oOEe1tfH8N/Cx5zmoWM4If+Fh3EOnvHXFCh14cawC6Sp7MTsyYPOFDEo1rX5xijS+pB I/6o65cRfCkd2WMutZfEsCLeXb4vk7R8nhqVbRsoY27hJhJCD5wucjKA5n7eogjuCh2X 3o7A== X-Gm-Message-State: AOJu0YxVPHh74/A25vljS5SPobLX7/zuoIk0nFqMrcCFub8XK3BkrDAQ rjkWrBgWMfG7KWfGC0LpNaWZzdTeA6OzaFa68J696y3TZ5h8yspMwYDhfQ== X-Google-Smtp-Source: AGHT+IEuQswf1/J524W79JT2rfjUzPSPKFJ5Q7lvsCfaRcIsB3+6OqLEEBcUnPYDXWklY0sEnmDMyA== X-Received: by 2002:a05:600c:46c5:b0:429:c771:f32f with SMTP id 5b1f17b1804b1-42bb01fd939mr153352475e9.36.1725550513084; Thu, 05 Sep 2024 08:35:13 -0700 (PDT) Received: from lili.. ([2a01:e0a:59b:9120:4d6d:a7b0:20be:6231]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42c9bb7d3a4sm19365875e9.1.2024.09.05.08.35.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Sep 2024 08:35:12 -0700 (PDT) From: Simon Tournier To: 73034@debbugs.gnu.org Subject: [PATCH v3 2/3] gnu: git: Update to 2.46.0 Date: Thu, 5 Sep 2024 17:34:49 +0200 Message-ID: X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73034 Cc: Ashish SHUKLA X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: Ashish SHUKLA * gnu/packages/version-control.scm (git-minimal): Update to 2.46.0. (git)[arguments]{install-man-pages} Update hash for the git-manpages. Change-Id: I686825ffba828e88e37ff156fab23fd43155d210 --- gnu/packages/version-control.scm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm index b8192035c2..9a4c2fdbdc 100644 --- a/gnu/packages/version-control.scm +++ b/gnu/packages/version-control.scm @@ -249,14 +249,14 @@ (define git-cross-configure-flags (define-public git-minimal (package (name "git-minimal") - (version "2.45.2") + (version "2.46.0") (source (origin (method url-fetch) (uri (string-append "mirror://kernel.org/software/scm/git/git-" version ".tar.xz")) (sha256 (base32 - "1nws1vjgj54sv32wxl1h3n1jkcpabqv7a605hhafsby0n5zfigsi")))) + "15bzq9m6c033qiz5q5gw1nqw4m452vvqax30wbms6z4bl9i384kz")))) (build-system gnu-build-system) (arguments (list @@ -703,7 +703,7 @@ (define-public git ".tar.xz")) (sha256 (base32 - "1pqrp46kwbxycqld39027ph1cvkq9am156y3sswn6w2khsg30f09")))))))))))) + "1lvvhzypllbyd8j6m0p9qgd3gqg10gch9s7lqif8vr9n80fqn4fw")))))))))))) (native-inputs (modify-inputs (package-native-inputs git-minimal) ;; For subtree documentation. -- 2.45.2 From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 06 00:20:02 2024 Received: (at 73034) by debbugs.gnu.org; 6 Sep 2024 04:20:02 +0000 Received: from localhost ([127.0.0.1]:38758 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smQRw-0003aG-OQ for submit@debbugs.gnu.org; Fri, 06 Sep 2024 00:20:02 -0400 Received: from mail-pl1-f177.google.com ([209.85.214.177]:58653) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smQRp-0003Zm-8V for 73034@debbugs.gnu.org; Fri, 06 Sep 2024 00:19:55 -0400 Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-206aee4073cso15426335ad.1 for <73034@debbugs.gnu.org>; Thu, 05 Sep 2024 21:18:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725596257; x=1726201057; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lESmGN5OdH40AnuYV9vkrMSL1XF+a7QkXr/qGG5VLlE=; b=KPr7lvtNCyf8LVd2mCEm1hwFY2oeM8LGfkFIaDVlRtcMnPV8ABRjManq09uGdXHtvJ UVpvrlM0d9gTulCW1fAwKVf4z7NSiKw5AQVTv+6h3pQ4W6UxkVEAp+5W/+DyCSJ0naTN zwmNpmCyQWJrYurgn5GSqSFVrxRbdFqaud5JK+RIFIfk+W75BaG9I6LxkpUTn9BPYsHe mnyMRPdp8eFe3bWjKHUQmRQgiLjA53y+n05yYkysP4yLg2raTm3O2Uhu3W5f3H2lLYF3 HyR8Dks0c0iqg+4Rd7aGEW1+qVJYWpatFN4AFlr6tH2KwM6k1JFvLUFzcm5mdullLzju KH5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725596257; x=1726201057; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lESmGN5OdH40AnuYV9vkrMSL1XF+a7QkXr/qGG5VLlE=; b=T+aPMqT/hCU3up4g7A8EKDvA+UpuzsfsBnncoy2+J3WSbDEBZIECz3obH0d9l5lY+V I5OIiIWcWDVg5gI2bLsHQfAL3UUs2qpm55QanLFb1z09g9pi2MjRP66/H1skoyORSJA+ JqIETQJ8ev8ZEt2OKn0StSpoSUUdbtq+AYyCupZHhOGia6sdGUAc9hCtpecsNag4rQBI aIwWoo7hM+v14+GaFU10ntUKg0D6K6UVwq0cr9p2gHhqYRpDgiNi2NQaQNPklhR8JmzA 0R2IkhcWrevby/xI4xHx9vUua49ZbaMCq0LuS2e621K8uaD1kldpxLAgHI+GLyn1RmAL RCJQ== X-Gm-Message-State: AOJu0Yxz1EVT/ZKfNj4qynf16hMeg1mAP7oD3x2Gi41mzTL267sYmTD/ yLQAitnMH8dtsUFzsr+qr9r3k71W3HxmU4ClpvIYELDgIjtHsQaz X-Google-Smtp-Source: AGHT+IHo3XD8AKgcLfyHGs+Ovv9z2hzJD6TKJYAcC6PiasKPCSETUhIlnT23azQgwwBznvWk83+xoA== X-Received: by 2002:a17:902:f709:b0:206:cc5b:ad0c with SMTP id d9443c01a7336-206f053479amr15313495ad.28.1725596256887; Thu, 05 Sep 2024 21:17:36 -0700 (PDT) Received: from hurd ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-206aea3866dsm35668685ad.153.2024.09.05.21.17.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Sep 2024 21:17:36 -0700 (PDT) From: Maxim Cournoyer To: Simon Tournier Subject: Re: [bug#73034] [PATCH v3 0/3] Fix annoyances of Git and update to 2.46.0 In-Reply-To: (Simon Tournier's message of "Thu, 5 Sep 2024 17:34:47 +0200") References: <15bfd834d58da9d8910b0945689aa8cd4e8ff48c.1725498442.git.zimon.toutoune@gmail.com> Date: Fri, 06 Sep 2024 13:17:33 +0900 Message-ID: <87msklct5u.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73034 Cc: ludo@gnu.org, 73034@debbugs.gnu.org, liliana.prikler@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Simon Tournier writes: > Hi, > > Since changes to the package Git imply large rebuilds, this series integr= ates > submission #72413. > > Change since v2: Restore the =E2=80=99origin=E2=80=99 of git-manpages und= er native-inputs. > > Commit f288604428e9c8f096ec9e0eccf207e079806271 moved the origin inside t= he phase. > > + (add-after 'split 'install-man-pages > + (lambda _ > + (let ((man (string-append #$output "/share/man"))) > + (mkdir-p man) > + (with-directory-excursion man > + (invoke > + "tar" "xvf" > + #$(origin > + (method url-fetch) > + (uri (string-append > + "mirror://kernel.org/software/scm/git/" > + "git-manpages-" version ".tar.xz")) > + (sha256 > + (base32 > + "0xsqakgy0s60zpa13ilj6zj420kdh8pf4v3nrp1nziwj8j= a4qymw")))))))) > > And this appears to me a bad idea, because 1. it makes harder to know wha= t are > the inputs and more importantly 2. it is hidden from procedure > =E2=80=99package-direct-sources=E2=80=99, which means it will not be arch= ived. I believe your argument 1. is going to affect any label-free package definitions needing additional origins copied in, so the issue is bigger than just this commit, in my opinion. About 2; perhaps it'd be preferable to build the doc from source, if that doesn't introduce cycles or too large of a native inputs graph. --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 06 07:29:24 2024 Received: (at 73034) by debbugs.gnu.org; 6 Sep 2024 11:29:24 +0000 Received: from localhost ([127.0.0.1]:52235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smX9X-0000Ti-Pg for submit@debbugs.gnu.org; Fri, 06 Sep 2024 07:29:24 -0400 Received: from mail-ed1-f50.google.com ([209.85.208.50]:45558) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smX9U-0000TN-FZ for 73034@debbugs.gnu.org; Fri, 06 Sep 2024 07:29:21 -0400 Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-5c26311c6f0so2439567a12.3 for <73034@debbugs.gnu.org>; Fri, 06 Sep 2024 04:29:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725622095; x=1726226895; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=i7YZcbXa1ZeyNYNtV66kjUOdhdYFbxqm5ZC2mqCZjqg=; b=cqVuaJnKP4PhNAUEmr/uJb50sjBPfunskoViEA6LXg44qZaP46bQFSiih7C1prNjMO vQy7d5Pd6Et5Xyje6fyrZzj3bwCHGr/ikStTF8fH3oraVOQsHFlldUXDuCDDDcuwMXo2 DyOGZLMp4zAomvcYIcGHkg75wKFsKkMlBmY5DBWJcsZ4LQbBhhRE8fK5gyGPQngcoXlz tjXNoQQ5HeM6c4YHGFWiK3GcstwgrPRB7ssLDBygBxLpoiqAkyErgGxBfVmCdDRRVy9h BtEny2Y1pxqPzjclGIqNK9s+6SFAfkoVZzs161yRu7OQUgjl1g1Zrd3sB/u/aiLCAN7+ LWEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725622095; x=1726226895; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i7YZcbXa1ZeyNYNtV66kjUOdhdYFbxqm5ZC2mqCZjqg=; b=dX188vF1lD0XXElphNezLK+7FTDUH2+NIdnVXW/80ZYIb/+cF0EO6hfXGtXEaUPWpL pyY7BNYGImlGX1vjdkKXBfkTkoo55xy3VUlXnbjqC1mMhmYXLTN72O2n5zz5S3xFnGLP AgkgsE+dY+WkXVCGBdcpwEVoWTSTVjpNuiN2rK64fHZm8GyRUPt3Awl3PjMgZYqbyVO5 kfMbOIUlp1eoHB4c00q6kctYVae4vcfYdLMK4zTbQzuJNGc+i0Qr20GZlq8EY/KwR4+s Mnb/SRtLirMAyOzTO7GSKaCSd7xya6cPB3h46vBNl2Sx0157LAheNcoqwA8lv0ti95bf bXTg== X-Forwarded-Encrypted: i=1; AJvYcCWHiDv2eonLcd0h9msEqmSSDdNYbWDUDFgsJ8a/5QBHaWI7OF2vvQfr3qxD4orkaE2eG+Gusg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwOuUMhc6GbI9RW2osKPxGdfLZxaWiGeNWAf1pffmzYpw0f7Kyt QXF5p2sEoTF4SgxhLwa4k08bDf2DysumZpSqNNNtzYWwk30UpemvsbuTtg== X-Google-Smtp-Source: AGHT+IF9iqsKJ2MiEX3xLC/IrFHVX0OURUPnBI7tpqBmwdmqML/McqIOwBQcdn2ZJI2/ctCIcOHoBg== X-Received: by 2002:a5d:4a88:0:b0:374:baeb:2ec with SMTP id ffacd0b85a97d-378895ca351mr1556795f8f.19.1725618694880; Fri, 06 Sep 2024 03:31:34 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:34c8:9fc9:674c:115f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-374c231e907sm15759297f8f.86.2024.09.06.03.31.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Sep 2024 03:31:34 -0700 (PDT) From: Simon Tournier To: Maxim Cournoyer Subject: Re: [bug#73034] [PATCH v3 0/3] Fix annoyances of Git and update to 2.46.0 In-Reply-To: <87msklct5u.fsf@gmail.com> References: <15bfd834d58da9d8910b0945689aa8cd4e8ff48c.1725498442.git.zimon.toutoune@gmail.com> <87msklct5u.fsf@gmail.com> Date: Fri, 06 Sep 2024 12:31:21 +0200 Message-ID: <87le05hy4m.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73034 Cc: ludo@gnu.org, 73034@debbugs.gnu.org, liliana.prikler@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Maxim, On Fri, 06 Sep 2024 at 13:17, Maxim Cournoyer w= rote: >> And this appears to me a bad idea, because 1. it makes harder to know wh= at are >> the inputs and more importantly 2. it is hidden from procedure >> =E2=80=99package-direct-sources=E2=80=99, which means it will not be arc= hived. > > I believe your argument 1. is going to affect any label-free package > definitions needing additional origins copied in, so the issue is bigger > than just this commit, in my opinion. Well, is it not changing the scope of the work being reviewed? If not, sorry, I do not understand what you mean. Could you explain more? In my views, what comes from the outside should be listed under inputs, native-inputs or propagated-inputs. I mean, that=E2=80=99s somehow the principle from functional paradigm. Putting an =E2=80=99origin=E2=80=99 in= side an arguments is somehow a way to get around that principle, IMHO. For instance, packages farstream, gnulib-checkout, smithforth, gnome-recipes and dmd-bootstrap should also be fixed. If you mean that it=E2=80=99s not easy to fix, from my understanding, it ch= anges the scope of the work being reviewed but let take the opportunity to discuss. :-) Currently it=E2=80=99s not possible to write something like: --8<---------------cut here---------------start------------->8--- (native-inputs (append (list `("foo" ,(origin (method git-fetch) (uri (git-reference (url "https://somewhere.org/plop") (commit (string-append "v" version)))) (file-name (git-file-name "plip" version)) (sha256 (base32 "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx= xxxxxx"))))) (list bar baz and other))) --8<---------------cut here---------------end--------------->8--- It appears to me that something is lacking: inputs-append. ;-) We could have a macro or a procedure that does the dance, allowing to mix both =E2=80=9Cstyles=E2=80=9D. > About 2; perhaps it'd be preferable to build the doc from source, if > that doesn't introduce cycles or too large of a native inputs graph. This is out of the scope, IMHO. Yes, I agree: it might be preferable but while waiting, it appears to me even more preferable to not have a package that hides all its sources. ;-) Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 06 11:55:09 2024 Received: (at 73034) by debbugs.gnu.org; 6 Sep 2024 15:55:09 +0000 Received: from localhost ([127.0.0.1]:53930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smbIi-0007kk-Jw for submit@debbugs.gnu.org; Fri, 06 Sep 2024 11:55:09 -0400 Received: from mail-wm1-f47.google.com ([209.85.128.47]:46273) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smbIg-0007fC-Vp for 73034@debbugs.gnu.org; Fri, 06 Sep 2024 11:55:07 -0400 Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-42c7a384b18so17832265e9.0 for <73034@debbugs.gnu.org>; Fri, 06 Sep 2024 08:55:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725638041; x=1726242841; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=MY7BJJ3x76L4oPRkaD3hchwbyfCsYBqgnI7MsIHt3ME=; b=hM/ge+alGOIaMdGoJbFtPxOsKlKO/449cGKalgSkqRxheVXJubhzoDaddxEuetpzpY Fjk3PMR9SPnoeQUsrGY9NigUabGC7few6Ibqc353YYfLpd+ZFrJ4greqlMhTnSgNnpzD 80VLWhrLvD5gvpkOOGyV0tacHg29mdKlYkKP46RsLPA/aLSGjCXDLZJc8jBIrAGC24Nx zPoZ4p567xSImn01pSc5NYHg83Z6M59Rqrp3T9dzKrtupwnaQXYxNMsSHcRFknj4p+Sz fXHDBPlddFfSInuhT65rOpGEN1KSbgdeFrMe9pIoQeXoCBE1oLJimnk480DW7U0HLMAi os3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725638041; x=1726242841; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MY7BJJ3x76L4oPRkaD3hchwbyfCsYBqgnI7MsIHt3ME=; b=qY371ILA2k/wai+FQ6Uj7UI2pxxuKVJFZ3dAoVeDoGlFzKh9O7DOBgxHw1EsmfgZuj TzcmsLxJ2OlgR4itBCZ3vzvsQejsj7FhYOanJUbVtnU88FuVT1yhLIpKCpgco0pdKqkx JQ0CBpKUAcELZIg3qvTPBOuJhqONH2x7seEOLfnoljDDTceWY3UEicM+49mziHFOZVG8 ecmcucBeY1KBfjK8SqP5cfSHHHo41Sx3ItahCtgXVN/HatxFTC865R/FSVGW9MYSfkFi z/JfwEPRROJsosW1ejEGwYYE8YoA3tuOrHOtH3WSUN0rnMuuVOs2Np6BdQVsQ3jS1lEX n5pA== X-Forwarded-Encrypted: i=1; AJvYcCXaL/0SBsyMpI6VLWYXuHGP1BktnVgWrGXH7Q7n7+2pdy4HEECMNRLadWkNEvKj+R9TRCQU4A==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwS0pmrC1SDa9bg0UilPHJ3uYDslqTgahQjjX/nd5MK4oU80WVc dKYGr4tWjUYCHRCYjzLo0qgwWL9pzRYLDM6MD9dDmBpio7qKoMim X-Google-Smtp-Source: AGHT+IEQKQ2ykhckV1Qfs5Vm9jjhdqOMz3spFAYRAEwBCd9IQtQ/Yz1LADLsr9XIIlXoNZC4uyLJ6g== X-Received: by 2002:a05:600c:3b9f:b0:428:151b:e8e with SMTP id 5b1f17b1804b1-42c9f9848damr23035555e9.10.1725638041366; Fri, 06 Sep 2024 08:54:01 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:34c8:9fc9:674c:115f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42ca0606e9dsm24841655e9.45.2024.09.06.08.54.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Sep 2024 08:54:00 -0700 (PDT) From: Simon Tournier To: Maxim Cournoyer Subject: Re: [bug#73034] [PATCH v3 0/3] Fix annoyances of Git and update to 2.46.0 In-Reply-To: <87le05hy4m.fsf@gmail.com> References: <15bfd834d58da9d8910b0945689aa8cd4e8ff48c.1725498442.git.zimon.toutoune@gmail.com> <87msklct5u.fsf@gmail.com> <87le05hy4m.fsf@gmail.com> Date: Fri, 06 Sep 2024 17:53:53 +0200 Message-ID: <87a5gkixri.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73034 Cc: ludo@gnu.org, 73034@debbugs.gnu.org, liliana.prikler@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Re, On Fri, 06 Sep 2024 at 12:31, Simon Tournier wrote: >> I believe your argument 1. is going to affect any label-free package >> definitions needing additional origins copied in, so the issue is bigger >> than just this commit, in my opinion. [...] > from my understanding, it changes > the scope of the work being reviewed but let take the opportunity to > discuss. :-) See submission #73073 . Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 08 08:12:12 2024 Received: (at 73034-done) by debbugs.gnu.org; 8 Sep 2024 12:12:12 +0000 Received: from localhost ([127.0.0.1]:58121 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1snGm3-0000eX-QY for submit@debbugs.gnu.org; Sun, 08 Sep 2024 08:12:12 -0400 Received: from mail-pj1-f54.google.com ([209.85.216.54]:46551) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1snGm1-0000eK-Kz for 73034-done@debbugs.gnu.org; Sun, 08 Sep 2024 08:12:10 -0400 Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-2daaa9706a9so2714452a91.1 for <73034-done@debbugs.gnu.org>; Sun, 08 Sep 2024 05:12:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725797461; x=1726402261; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=VNbgeKgldEgfyD5owOSgI7JvdYDHkdAVFEYXRFuQmMg=; b=GnuuBV4DSLDKwrRmMiQBh+vtdqzZkvH7x5+1w0dEZkTx/nBF9E0bXv8ErnLiMy6xc3 HWRb1HxJeAkAIAKGj4Uh7o+bywKJXJww+3cTvJQGl7KA/fgUPy64JNN/R1WkkeVMtMHu mkzd6rvr9BfyJqcrSxV0rPFQbPgUyPyVCcgJ7zlV0oG3LRYBgwH5lWLBtQs4YRH3eHT5 dR03kjMbPQYNjMCTizBsqIHbL471tpV6HO8wVpZcMAjS54hWuEKoCTFcTiZazd9070Gj KvpQVAh8vjfoNC46qfKOZ7wO+A3yAs6tF9uK0lMWbsZvZ63ZDTNHR9Xp1IcEIU2HigjM swMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725797461; x=1726402261; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VNbgeKgldEgfyD5owOSgI7JvdYDHkdAVFEYXRFuQmMg=; b=s3ajrG9XPlYZrAxxg/QuaU9/V8i3pKsZGKn8hQsRY1oSjAsrJos4jI6H845DBlC1dy 3Yd69TVgXtB+Whz5WCinPCHQIIeTUEmgMYUkpXsh3x7QR9Qy+nWUHNeyavtInXbtTKae uWoY6BSvJzOU+Ji93DvT6nwbqrXvBXk0HqtHjCDioNqJLk13S3Y3XbSqO0cEEZZC9AEL /9FtmYUKkQxZKbZknCu/k/XlKLEYGkOxEAnLlmyBmWx26upRuDTLszEi0PE0AfdI/HSe o9D9FbzKxH9MeI+Tb1Zb6XN0cGMhyIoUvdQ3zSdUP2mcmL1U0sceiuoB2lIkEH3AH/Bw SeGw== X-Forwarded-Encrypted: i=1; AJvYcCVEABP7F7TF/sdtLogbrEcJ1e5jwZ63mUEn+8Hym9KDw/EXs8mDhkaUS3iL9i9/vpCK4vkmS+T6tTbd@debbugs.gnu.org X-Gm-Message-State: AOJu0YxPoJM5hpzNRPkBRJl6j/Y7GrtV1L1EvhvtC6UujyMqKnbq7a9i TZAvCGYH+vWLXP2z4XjduAt7mb4C1BWCXGh3Nyg+vxX88nZ589lf X-Google-Smtp-Source: AGHT+IGw842+edBbTbaoKRZSmOeEtwQHysDT95JiD9WZWm4XgakObyfrev+oswLV1elXhvZqfnP8jA== X-Received: by 2002:a17:90b:1c0a:b0:2da:d766:1925 with SMTP id 98e67ed59e1d1-2dad7661a42mr7608425a91.37.1725797461112; Sun, 08 Sep 2024 05:11:01 -0700 (PDT) Received: from hurd (vps-6234970c.vps.ovh.ca. [51.222.13.224]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2dadc040397sm4708199a91.25.2024.09.08.05.10.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Sep 2024 05:11:00 -0700 (PDT) From: Maxim Cournoyer To: Simon Tournier Subject: Re: [bug#73034] [PATCH v3 0/3] Fix annoyances of Git and update to 2.46.0 In-Reply-To: <87a5gkixri.fsf@gmail.com> (Simon Tournier's message of "Fri, 06 Sep 2024 17:53:53 +0200") References: <15bfd834d58da9d8910b0945689aa8cd4e8ff48c.1725498442.git.zimon.toutoune@gmail.com> <87msklct5u.fsf@gmail.com> <87le05hy4m.fsf@gmail.com> <87a5gkixri.fsf@gmail.com> Date: Sun, 08 Sep 2024 21:10:52 +0900 Message-ID: <874j6qfir7.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73034-done Cc: ludo@gnu.org, 73034-done@debbugs.gnu.org, liliana.prikler@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Simon, Simon Tournier writes: > Re, > > On Fri, 06 Sep 2024 at 12:31, Simon Tournier wrote: > >>> I believe your argument 1. is going to affect any label-free package >>> definitions needing additional origins copied in, so the issue is bigger >>> than just this commit, in my opinion. > > [...] > >> from my understanding, it changes >> the scope of the work being reviewed but let take the opportunity to >> discuss. :-) > > See submission #73073 . Thanks for following up with concrete ideas. It seems the discussion still has some ways to go before we reach consensus there, but at least it seems clear we do not want to go back to reintroducing labels, so I've applied 1/3 and 3/3 but left out 2/3. Thank you for fixing my botched wrapped-program phase translation :-). We can now use 'git send-email' and friends easily again. -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 09 15:06:20 2024 Received: (at 73034-done) by debbugs.gnu.org; 9 Sep 2024 19:06:20 +0000 Received: from localhost ([127.0.0.1]:34193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1snjiO-0007D6-DI for submit@debbugs.gnu.org; Mon, 09 Sep 2024 15:06:20 -0400 Received: from mail-wm1-f52.google.com ([209.85.128.52]:45566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1snjiK-0007Cd-3u for 73034-done@debbugs.gnu.org; Mon, 09 Sep 2024 15:06:16 -0400 Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-42ca573fd5aso30433005e9.3 for <73034-done@debbugs.gnu.org>; Mon, 09 Sep 2024 12:06:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725908706; x=1726513506; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=RREQ5C4TK1Gieq7pQg0fRzHYc9JrsQOHr+dUtzwsJAU=; b=BZNi+4Fy/pxrMo7J5yRrg/eLHTaVGYYr2bez7nmboUGB/8h+dtPTnuGKR8HQ0lNPHQ oMA8xe4fLrxB4Eq9xoAnST9FmGHzksufHLvJQI8AAliy8qNbd+Xi9B3dcYiPrluxXG21 1HC7OVa1I6xGhBJOybL2SGKh9DXDTjVMCMrQCnrRvdRoCm/W2cL2scCESuOKf/ghAhJZ rxnPQY7d/eLNtx4/+e3CfK6FSproHy78DnLIXmnjJt7I6lYa7LHTSUPIujZAj8Q5idBQ dxgwWAwsDFvP76MROVkbSbMzrWUIZu9GAZg7gSiexwl1rs1K/ckYvfMt3MyxGvTbRevf xCAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725908706; x=1726513506; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RREQ5C4TK1Gieq7pQg0fRzHYc9JrsQOHr+dUtzwsJAU=; b=b85f3DU6GHRu7Ty8Fib8CcICgvsL9i4KmNMbJEvpfeQf5r2DW3u8ghOOTR2ybfcj+I B5kWqBIniFRV+ULCBNm1nNvwODC6Fk4bhN2KylzQ9fj43FgxWMQIVhuC48+3mITrtoLa yNe7JiI+BSLpXwU3JV61jn1UMrnghnQjK55/4ddKNEx3ZZgRuemEsCfwABfBtIMz94lP AY61MYVO4Bn42LgVroJ2D8tbUJwK3ArTGqFNreWHTOleqlkSh4EC4VsJ6yZRBs557MeO Uz+ZEvDYC1vMoe0jajRGJNBgZ8CJYOiRn7PPuZ26qw/dLPCcdaESe4WC5VC1a3YLgo/m 48wQ== X-Forwarded-Encrypted: i=1; AJvYcCW1KRRQzYQ+FywF3MBigi2Yc4XuxWmZok76VFV/FCtDAy+kuZGQRoBwejJnbkzvw+5uiCtZBOKICX6L@debbugs.gnu.org X-Gm-Message-State: AOJu0YxzsboCp/Zn7DWxUuaQ4vPqeyRowXn/M8J+M9vqo5jeF8XNp0qy yFII6W3lzZAG0pA4/JStZWm9NaOtPTN2AVt6enG/oKDylAls32L1 X-Google-Smtp-Source: AGHT+IEwL6SGR762TDAdN9e5S0vymt3R2e+1nshjqOBfNJW5voyQyzFoc1/OF1gyou6XvSTjwJt36Q== X-Received: by 2002:a05:600c:3b29:b0:42c:bae0:f059 with SMTP id 5b1f17b1804b1-42cbae0f243mr18974335e9.5.1725908706284; Mon, 09 Sep 2024 12:05:06 -0700 (PDT) Received: from lili (roam-nat-fw-prg-194-254-61-45.net.univ-paris-diderot.fr. [194.254.61.45]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42cb5ba4532sm55991605e9.38.2024.09.09.12.05.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Sep 2024 12:05:05 -0700 (PDT) From: Simon Tournier To: Maxim Cournoyer Subject: Re: bug#73034: [PATCH v3 0/3] Fix annoyances of Git and update to 2.46.0 In-Reply-To: <874j6qfir7.fsf@gmail.com> References: <15bfd834d58da9d8910b0945689aa8cd4e8ff48c.1725498442.git.zimon.toutoune@gmail.com> <87msklct5u.fsf@gmail.com> <87le05hy4m.fsf@gmail.com> <87a5gkixri.fsf@gmail.com> <874j6qfir7.fsf@gmail.com> Date: Mon, 09 Sep 2024 19:50:47 +0200 Message-ID: <87zfogra14.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73034-done Cc: ludo@gnu.org, 73034-done@debbugs.gnu.org, liliana.prikler@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Maxim, On Sun, 08 Sep 2024 at 21:10, Maxim Cournoyer wrote: > We can now use 'git send-email' and friends easily again. Cool! Thank you. Cheers, simon From unknown Sun Aug 10 16:50:30 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 08 Oct 2024 11:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator