GNU bug report logs - #73028
[PATCH] doc: Document usage of #:out-of-source? for meson-build-system.

Previous Next

Full log

Message #11 received at 73028 <at> debbugs.gnu.org (full text, mbox):

From: Dariqq <dariqq <at> posteo.net>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 73028 <at> debbugs.gnu.org,
 Florian Pelz <pelzflorian <at> pelzflorian.de>
Subject: Re: [bug#73028] [PATCH] doc: Document usage of #:out-of-source? for
 meson-build-system.
Date: Wed, 11 Sep 2024 15:18:34 +0000

Hi Maxim,


On 11.09.24 08:09, Maxim Cournoyer wrote:
> Hi Dariqq,
> 
> Dariqq <dariqq <at> posteo.net> writes:
> 
> 
> That strikes me as odd; is it useful in practice?  Otherwise I'd rather
> we keep it undocumented, so that it can be removed without notice in a
> future cleanup (in a 'private API' way).
> 

Ludovic asked me to document the new parameter, so I added something for 
the current behaviour.

Because I don't think the message arrived at the original issue, i 
copied below. I hope this is ok:

> On 04.09.24 16:02, Ludovic Courtès wrote:
> AFAICS these changes are not sufficient because ‘configure’ in
> meson-build-system.scm does not honor #:out-of-source? (unlike
> ‘configure’ in gnu-build-system.scm).
> 
> So if I’m not mistaken, you’ll need to change ‘configure’ as well.
> 
> You can also update doc/guix.texi under “Build Systems” to mention this
> parameter.
> 
> Last: ‘guix refresh -l meson’ shows that this is almost a world-rebuild
> change (23K dependents), so we’ll need to have this change in a separate
> branch.
> 
> Could you send an updated patch?
> 
> Thanks,
> Ludo’.

I have sent this patch for the documentation part but am still unsure 
what is meant by *sufficient* because meson cannot do in source builds.

Maybe it should not be an option at all and instead be #t 
unconditionally in 'install-license-files phase in meson-build-system?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.