From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 04 12:27:41 2024 Received: (at submit) by debbugs.gnu.org; 4 Sep 2024 16:27:41 +0000 Received: from localhost ([127.0.0.1]:35204 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slsr7-0006in-1w for submit@debbugs.gnu.org; Wed, 04 Sep 2024 12:27:41 -0400 Received: from lists.gnu.org ([209.51.188.17]:38912) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slsr4-0006id-QW for submit@debbugs.gnu.org; Wed, 04 Sep 2024 12:27:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1slsq2-0000SW-Nk for guix-patches@gnu.org; Wed, 04 Sep 2024 12:26:34 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1slsq0-0006pO-Lq for guix-patches@gnu.org; Wed, 04 Sep 2024 12:26:34 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 9D139240028 for ; Wed, 4 Sep 2024 18:26:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1725467189; bh=8iuTgqpgGfCAPUXcjLvb+Y+r5N1WLR8ukM7IodSlThs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=ITV9sEFXUqYottwmowobQkMbDIY5okFhW4KLNefmMmw03+4Cm9sA0+vZOjmxHcdFC LM0PbWFG611c274AQfC1zT0Y6YXXRNgnb9tH9+zYAV3WmynG3yhVZ7E1d1DuEQAO54 fClXn/6kKSVPh29A/SvX6+WwpWHU+UbaD6nbUikhnV56imcYoQi1ypPGliH3AuzS9o +5whY8i43VlgtMBuNizyujSpJxqiNUgXd4v6HI0u59BofjljRza3M3CQRBXZE7BjWW parHu1c+Y5rSEQq7lWzPUds8k1hx30Fg59iJQuk2WoKirTvn5CtCAI+chT2ao1KXXA 9xl/I1tsY7i/w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4WzSYJ4RyNz9rxG; Wed, 4 Sep 2024 18:26:28 +0200 (CEST) From: Dariqq To: guix-patches@gnu.org Subject: [PATCH] doc: Document usage of #:out-of-source? for meson-build-system. Date: Wed, 4 Sep 2024 16:26:00 +0000 Message-ID: MIME-Version: 1.0 X-Debbugs-Cc: Florian Pelz , Ludovic Courtès , Maxim Cournoyer Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=185.67.36.65; envelope-from=dariqq@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Dariqq X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Followup to 220546810830422f8ec3e6a4145fec85429914a1. * doc/guix.texi (meson-build-system): Document #:out-of-source? parameter. Change-Id: I730e1aef15010006a68710f8e46ce75dc50e6c67 --- doc/guix.texi | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/doc/guix.texi b/doc/guix.texi index 16c697586a..2302e0f15c 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -10146,6 +10146,10 @@ Build Systems of inputs, and they can be changed with the parameters @code{#:meson} and @code{#:ninja} if needed. +As Meson only supports out-of-source builds the @code{#:out-of-source?} +parameter specifies whether to search for license files in the source +or build directory. + This build system is an extension of @code{gnu-build-system}, but with the following phases changed to some specific for Meson: base-commit: 9a03ab25ba889be27b34d5cebea05d5ac3b0a033 -- 2.45.2 From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 11 02:10:28 2024 Received: (at 73028) by debbugs.gnu.org; 11 Sep 2024 06:10:28 +0000 Received: from localhost ([127.0.0.1]:37542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1soGYe-0005LL-3Z for submit@debbugs.gnu.org; Wed, 11 Sep 2024 02:10:28 -0400 Received: from mail-oi1-f178.google.com ([209.85.167.178]:45156) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1soGYb-0005L7-On for 73028@debbugs.gnu.org; Wed, 11 Sep 2024 02:10:26 -0400 Received: by mail-oi1-f178.google.com with SMTP id 5614622812f47-3e03e9d1f8dso2013179b6e.2 for <73028@debbugs.gnu.org>; Tue, 10 Sep 2024 23:10:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726034954; x=1726639754; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=LMHDtAluX1Hkp8vG6gXLoDHsaRwtjHpf+8Ttc/UeWos=; b=lIZKN7rTAVf0myzRSXUSuAx7pGvOSZU6rIObSAkJQZ+o7yj6Xakrh+5lloMg6ianFU z7pxqXt9xmdqfrn5EBTJMIue+9BR7/N292VPJEYMOBWrLpVZz8s1As2q3UPH8a9RxSLY 5mgmXYla0gbFYziQgV+WuCN62k1PVRVo22njN2BfYxaDT0tCOQsh3cCx0s2HJNbldMI5 81NrmuLnGkCxC39eh2Pq/DpPFX3e6xvnmljXGENkKDeOo4XTslj0Jw2TqQVDlmuXP+Aj 92GxFuZOE5jytfI3brjvrpVDLLXhcLuZk07w2XPVsLOjGAXu7hBZGtKXyAJ1+mO0QpdI NGMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726034954; x=1726639754; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LMHDtAluX1Hkp8vG6gXLoDHsaRwtjHpf+8Ttc/UeWos=; b=aXs2guLuzah9NnlnZLIktaST2MGY7LjkVu9N1auNs0Ums1Bdw0YwKw4DnWInB12kl3 +Ye/JxESU2vt/Wp9IDOhmxi2JHmbL/fBD+j0yH2Qd/y/n3A6hCFqG0mhEs7ruzQ8dWo/ KT5mn3X+npFk8vRGTsBXAQBM5p/6St4QlEgoZV2QGVHqpVbhqQe9121E2SubmDGZWtnr NeiHf9qENIZa10bGtwJx8Fkad/CE6hl7JUN9kucixjqMfGM+NopZuzm+B5pvZXMLhn8N ocTOSDSBaaMmtit3C+hnEk/VBS4gc6lh0+v4uy3C42inQpvp6FRAXbKUXOOLqX83/C+d B4Ag== X-Gm-Message-State: AOJu0Yz4I8Sso1htYPqvKheSzKj/PkAOOUSFBYgwe4Kn6XlhbDT3NnKv 31rSqgIHGTt7+flq+gR7sLEqQMFJe3TULZ30LZx+vQiLz2o3gOVD X-Google-Smtp-Source: AGHT+IE+z7ez9TUoM4i9El3ellercoolw3paKwaR4gxMCM21/45AhhnlYhseUXHJ0/GI2McWOA0GYA== X-Received: by 2002:a05:6808:13d5:b0:3e0:5143:df87 with SMTP id 5614622812f47-3e05143e1admr3944038b6e.18.1726034953996; Tue, 10 Sep 2024 23:09:13 -0700 (PDT) Received: from hurd ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7d823cf3a2esm5632551a12.24.2024.09.10.23.09.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Sep 2024 23:09:13 -0700 (PDT) From: Maxim Cournoyer To: Dariqq Subject: Re: [bug#73028] [PATCH] doc: Document usage of #:out-of-source? for meson-build-system. In-Reply-To: (dariqq@posteo.net's message of "Wed, 4 Sep 2024 16:26:00 +0000") References: Date: Wed, 11 Sep 2024 15:09:10 +0900 Message-ID: <878qvy3ent.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73028 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 73028@debbugs.gnu.org, Florian Pelz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Dariqq, Dariqq writes: > Followup to 220546810830422f8ec3e6a4145fec85429914a1. > > * doc/guix.texi (meson-build-system): Document #:out-of-source? parameter. > > Change-Id: I730e1aef15010006a68710f8e46ce75dc50e6c67 > --- > doc/guix.texi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/doc/guix.texi b/doc/guix.texi > index 16c697586a..2302e0f15c 100644 > --- a/doc/guix.texi > +++ b/doc/guix.texi > @@ -10146,6 +10146,10 @@ Build Systems > of inputs, and they can be changed with the parameters @code{#:meson} > and @code{#:ninja} if needed. > > +As Meson only supports out-of-source builds the @code{#:out-of-source?} > +parameter specifies whether to search for license files in the source > +or build directory. > + That strikes me as odd; is it useful in practice? Otherwise I'd rather we keep it undocumented, so that it can be removed without notice in a future cleanup (in a 'private API' way). -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 11 11:18:57 2024 Received: (at 73028) by debbugs.gnu.org; 11 Sep 2024 15:18:58 +0000 Received: from localhost ([127.0.0.1]:39412 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1soP7R-0008Cd-Js for submit@debbugs.gnu.org; Wed, 11 Sep 2024 11:18:57 -0400 Received: from mout01.posteo.de ([185.67.36.65]:37949) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1soP7N-0008CL-5B for 73028@debbugs.gnu.org; Wed, 11 Sep 2024 11:18:55 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 55481240028 for <73028@debbugs.gnu.org>; Wed, 11 Sep 2024 17:18:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1726067920; bh=/7GCl+hWu4b5V6FKAi3CWb/gC5hKHty+TqYmX8jYSXY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:Content-Type: Content-Transfer-Encoding:From; b=h5U5wriFbIkC1jySV6APM84ZQdVck/Q1PREy23ThKNtfyNqt+t9g3AyYjOnV/4xom e3g9bATOtslnuXzWcRpP+1gYsA9siKOf/IzM781W7JBm5hd+LJn86rWKR++pfZ7eJf qK9YyBgmfGTxT8drLHtNipLWYcp3siPeAAe8GAikk/22EnTcJYO/cgi59nu0r+Cwuh 5p+x2ovqjD9Dx085FGcgYzeDQrwbKDma83X2KggQphGxCXhA88Re4gY33ibRJ6MrAh JzwS6b8X8eMI5KpYGT/kgZC/M5iHOVt1PAI4TnSfpd8Qbcv84OkxvmR4Tv3RGL58QE BKdSbxhRQibdw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4X3kjp4Wk5z9rxM; Wed, 11 Sep 2024 17:18:38 +0200 (CEST) Message-ID: <97aa51a8-a945-44f4-8a61-e9bbc3eddba4@posteo.net> Date: Wed, 11 Sep 2024 15:18:34 +0000 MIME-Version: 1.0 Subject: Re: [bug#73028] [PATCH] doc: Document usage of #:out-of-source? for meson-build-system. To: Maxim Cournoyer References: <878qvy3ent.fsf@gmail.com> Content-Language: en-US From: Dariqq In-Reply-To: <878qvy3ent.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73028 Cc: =?UTF-8?Q?Ludovic_Court=C3=A8s?= , 73028@debbugs.gnu.org, Florian Pelz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Maxim, On 11.09.24 08:09, Maxim Cournoyer wrote: > Hi Dariqq, > > Dariqq writes: > > > That strikes me as odd; is it useful in practice? Otherwise I'd rather > we keep it undocumented, so that it can be removed without notice in a > future cleanup (in a 'private API' way). > Ludovic asked me to document the new parameter, so I added something for the current behaviour. Because I don't think the message arrived at the original issue, i copied below. I hope this is ok: > On 04.09.24 16:02, Ludovic Courtès wrote: > AFAICS these changes are not sufficient because ‘configure’ in > meson-build-system.scm does not honor #:out-of-source? (unlike > ‘configure’ in gnu-build-system.scm). > > So if I’m not mistaken, you’ll need to change ‘configure’ as well. > > You can also update doc/guix.texi under “Build Systems” to mention this > parameter. > > Last: ‘guix refresh -l meson’ shows that this is almost a world-rebuild > change (23K dependents), so we’ll need to have this change in a separate > branch. > > Could you send an updated patch? > > Thanks, > Ludo’. I have sent this patch for the documentation part but am still unsure what is meant by *sufficient* because meson cannot do in source builds. Maybe it should not be an option at all and instead be #t unconditionally in 'install-license-files phase in meson-build-system? From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 11 20:57:40 2024 Received: (at 73028) by debbugs.gnu.org; 12 Sep 2024 00:57:40 +0000 Received: from localhost ([127.0.0.1]:39770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1soY9U-0004U9-10 for submit@debbugs.gnu.org; Wed, 11 Sep 2024 20:57:40 -0400 Received: from mail-pg1-f172.google.com ([209.85.215.172]:61573) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1soY9R-0004Tu-PN for 73028@debbugs.gnu.org; Wed, 11 Sep 2024 20:57:38 -0400 Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-7d4fa972cbeso342850a12.2 for <73028@debbugs.gnu.org>; Wed, 11 Sep 2024 17:57:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726102585; x=1726707385; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Sh1ezHGlx/2iWW57mOOFriZb6NNunJ0Ixh3D3G5nggs=; b=nV4gSMxDTeUEGvkSgIJxQys1mTzXV+VQ6qIqu/czJkfK1ADviZoghXWjszDbP3J426 k00FJ8RiR+cHqWsZx1A2xN8yRJ8FUJ4urez627aS/2eSMjTDVXui47KooBgMpI5sOzkL Eh6V2Hl8bB6GzufPiUiqETqtbB3pY3YAOoHWO7CVjsAEoAlV6+S1cTFKlB20pVXiJwve ztCtXmZPAKOSwd2eZTe+9WZN1OvxRLIJpV+gZ3sQZrTxG0lqbUKaYN74BzoqOKRnCKW9 VO/JZc9PJB1TA99i404CLlb5aQFDVGJGW1nII3a1F3wlWjSeurPBYtcY3Lr5cI1x3h4h tiTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726102585; x=1726707385; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Sh1ezHGlx/2iWW57mOOFriZb6NNunJ0Ixh3D3G5nggs=; b=V1X/zApcLuijR6uziSWqJ+Od4BScImIG3r6moBcBhGGOgOucGQt+Esq/U+ImM903y6 alht/N/9RFAVixmpJHq4mPn1z8exOoHWR9r9/TtpEtEgYAl8VxzM8XmYKVHqya5QhTAo gk2riLUUtTWGYi5yi95QlO++Q4ZndAfAR8KAaTQSYhDB5ftMYOy42p3w4XU2431entWK GYiQzGhoceXXodVCBhXsUfzd/ZL0QiJvMLJ+YKofqnViRYzFuTtYcDbKuEmWmwvatM54 qoCpPpABFpBFv47asZ6NhfmGkozNdE/oNuGhran/76AvgINy05n6NS+YFRhxoRWd90DQ Fj/g== X-Gm-Message-State: AOJu0YzWfGawoE3Wn4BBaTObRQKWUMiCqBr33sbFVWV0ElUvq+lqc56e BaabKIxRGSKwdpX98NVRk8yJVcyQM/PNZJblDc4faQS3mmhaq+54 X-Google-Smtp-Source: AGHT+IGlxM2ESIt4723563ySwTyKM6EkofxkdGXURsC9hspHOjtWV02cPNHMOGfiAAau1YMo31AuRg== X-Received: by 2002:a05:6a20:c79a:b0:1cf:2aaa:9199 with SMTP id adf61e73a8af0-1cf75eaeaccmr1188855637.15.1726102584832; Wed, 11 Sep 2024 17:56:24 -0700 (PDT) Received: from hurd ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-719090d11e6sm3517959b3a.205.2024.09.11.17.56.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Sep 2024 17:56:24 -0700 (PDT) From: Maxim Cournoyer To: Dariqq Subject: Re: [bug#73028] [PATCH] doc: Document usage of #:out-of-source? for meson-build-system. In-Reply-To: <97aa51a8-a945-44f4-8a61-e9bbc3eddba4@posteo.net> (dariqq@posteo.net's message of "Wed, 11 Sep 2024 15:18:34 +0000") References: <878qvy3ent.fsf@gmail.com> <97aa51a8-a945-44f4-8a61-e9bbc3eddba4@posteo.net> Date: Thu, 12 Sep 2024 09:56:20 +0900 Message-ID: <87jzfhy9jf.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73028 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 73028@debbugs.gnu.org, Florian Pelz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Dariqq, Dariqq writes: > Hi Maxim, > > > On 11.09.24 08:09, Maxim Cournoyer wrote: >> Hi Dariqq, >> Dariqq writes: >> That strikes me as odd; is it useful in practice? Otherwise I'd >> rather >> we keep it undocumented, so that it can be removed without notice in a >> future cleanup (in a 'private API' way). >>=20 > > Ludovic asked me to document the new parameter, so I added something > for the current behaviour. > > Because I don't think the message arrived at the original issue, i > copied below. I hope this is ok: > >> On 04.09.24 16:02, Ludovic Court=C3=A8s wrote: >> AFAICS these changes are not sufficient because =E2=80=98configure=E2=80= =99 in >> meson-build-system.scm does not honor #:out-of-source? (unlike >> =E2=80=98configure=E2=80=99 in gnu-build-system.scm). >> So if I=E2=80=99m not mistaken, you=E2=80=99ll need to change =E2=80=98c= onfigure=E2=80=99 as well. >> You can also update doc/guix.texi under =E2=80=9CBuild Systems=E2=80=9D = to mention >> this >> parameter. >> Last: =E2=80=98guix refresh -l meson=E2=80=99 shows that this is almost a >> world-rebuild >> change (23K dependents), so we=E2=80=99ll need to have this change in a = separate >> branch. >> Could you send an updated patch? >> Thanks, >> Ludo=E2=80=99. > > I have sent this patch for the documentation part but am still unsure > what is meant by *sufficient* because meson cannot do in source > builds. I'm still out of context; is there an original bug number to refer to to better understand what was the root problem being addressed? > Maybe it should not be an option at all and instead be #t > unconditionally in 'install-license-files phase in meson-build-system? Given most build phases of the gnu-build-system, which support #:out-of-source? are reused in the meson-build-system, this argument needs to be set to #t (which it currently is). But perhaps there's a way to hide it from the users, perhaps via the 'private-keywords' variable defined in the 'lower' procedure of the (guix build-system meson) module (I haven't tested). --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 12 03:13:04 2024 Received: (at 73028) by debbugs.gnu.org; 12 Sep 2024 07:13:04 +0000 Received: from localhost ([127.0.0.1]:40036 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1soe0m-00079i-77 for submit@debbugs.gnu.org; Thu, 12 Sep 2024 03:13:04 -0400 Received: from mout01.posteo.de ([185.67.36.65]:54151) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1soe0j-00078t-Qy for 73028@debbugs.gnu.org; Thu, 12 Sep 2024 03:13:03 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id A8611240027 for <73028@debbugs.gnu.org>; Thu, 12 Sep 2024 09:12:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1726125146; bh=Tak51PLoahwYSNCNr9RQhbJ1oh1KAxCk6HHig5a+vSU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:Content-Type: Content-Transfer-Encoding:From; b=k8chMGZWOBl2hBcn/XwoSEbfByJy9J5iY3i6POU5mCLDsquCxk+0OWOXwEBbIMVRr z7uRFhATF3n3HWNbWFZoRj9lc+KA7T5FLM17EtdHmbGf9Cf/6Ar1VckI61gc/Ogra4 vxqxDrT7t8HoVwR2VgzhcVlS5TW+FScetvuWFB/Rm/z7pfB4XJEeZwK8YKkrHRuFXr fDS89RlbFKrqgbx3TUB0NEiK1FlY3FJiPUQuZEY6gTo94apbnUoh4opQcXFS78xsai MApGpbGUC8MrhB5h9WXCF++xYYR8yDtEdZPHIAYTr86XbzXj5aFB/iAvRAqgycMrpR gxsrNcPCJeC+w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4X47tK67GGz9rxK; Thu, 12 Sep 2024 09:12:25 +0200 (CEST) Message-ID: Date: Thu, 12 Sep 2024 07:12:22 +0000 MIME-Version: 1.0 Subject: Re: [bug#73028] [PATCH] doc: Document usage of #:out-of-source? for meson-build-system. To: Maxim Cournoyer References: <878qvy3ent.fsf@gmail.com> <97aa51a8-a945-44f4-8a61-e9bbc3eddba4@posteo.net> <87jzfhy9jf.fsf@gmail.com> Content-Language: en-US From: Dariqq In-Reply-To: <87jzfhy9jf.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73028 Cc: =?UTF-8?Q?Ludovic_Court=C3=A8s?= , 73028@debbugs.gnu.org, Florian Pelz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, On 12.09.24 02:56, Maxim Cournoyer wrote: > Hi Dariqq, > > Dariqq writes: > >> Hi Maxim, >> >> >> On 11.09.24 08:09, Maxim Cournoyer wrote: >>> Hi Dariqq, >>> Dariqq writes: >>> That strikes me as odd; is it useful in practice? Otherwise I'd >>> rather >>> we keep it undocumented, so that it can be removed without notice in a >>> future cleanup (in a 'private API' way). >>> >> >> Ludovic asked me to document the new parameter, so I added something >> for the current behaviour. >> >> Because I don't think the message arrived at the original issue, i >> copied below. I hope this is ok: >> >>> On 04.09.24 16:02, Ludovic Courtès wrote: >>> AFAICS these changes are not sufficient because ‘configure’ in >>> meson-build-system.scm does not honor #:out-of-source? (unlike >>> ‘configure’ in gnu-build-system.scm). >>> So if I’m not mistaken, you’ll need to change ‘configure’ as well. >>> You can also update doc/guix.texi under “Build Systems” to mention >>> this >>> parameter. >>> Last: ‘guix refresh -l meson’ shows that this is almost a >>> world-rebuild >>> change (23K dependents), so we’ll need to have this change in a separate >>> branch. >>> Could you send an updated patch? >>> Thanks, >>> Ludo’. >> >> I have sent this patch for the documentation part but am still unsure >> what is meant by *sufficient* because meson cannot do in source >> builds. > > I'm still out of context; is there an original bug number to refer to to > better understand what was the root problem being addressed? > Sorry I should have added that. The problem I was trying to solve is https://issues.guix.gnu.org/70999. TLDR is that meson-build-system was failing to find and install license files for many packages because it would search for licenses in the build directory rather than the source directory. (which might be against the terms of the license) >> Maybe it should not be an option at all and instead be #t >> unconditionally in 'install-license-files phase in meson-build-system? > > Given most build phases of the gnu-build-system, which support > #:out-of-source? are reused in the meson-build-system, this argument > needs to be set to #t (which it currently is). But perhaps there's a > way to hide it from the users, perhaps via the 'private-keywords' > variable defined in the 'lower' procedure of the (guix build-system > meson) module (I haven't tested). > Something like that might be a better solution. I am not sure how these 'private-keywords' work: It looks like #:meson is one but you can definitly override the default meson being used. Also the private-arguments seem to get stripped from the arguments in the bag (not sure what that is exactly) so they might not be passed to the build phases Would such a change require rebuilding (basically) everything given that currently all packages are already built with #:out-of-source? set to the default value #t? From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 12 08:03:38 2024 Received: (at 73028) by debbugs.gnu.org; 12 Sep 2024 12:03:38 +0000 Received: from localhost ([127.0.0.1]:40350 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1soiXx-0005at-Rd for submit@debbugs.gnu.org; Thu, 12 Sep 2024 08:03:38 -0400 Received: from mail-pl1-f169.google.com ([209.85.214.169]:51397) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1soiXw-0005ah-2s for 73028@debbugs.gnu.org; Thu, 12 Sep 2024 08:03:36 -0400 Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-20536dcc6e9so6532785ad.2 for <73028@debbugs.gnu.org>; Thu, 12 Sep 2024 05:03:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726142543; x=1726747343; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=as23pRzQqXKG+qD312zABP7nHRv1MWlkupvu6DFESpU=; b=Gmt9pIMFwXAupE8nwe9G1//WscH/I51oOL6EjQ+Rfn6rZGcUaXESBhftos3gkU2pfw RwfsXXDdfUQCvcOZmWCWhUdcFBz+b41bhNGJpYHJhfWzDHwzlE/nDgcrUmtsBmXCtTEq KiM8ACYip3ha8kNNj3zSI8UfxYXb0Mvzomw0gIljlwDO4Xv271TWrPnyYjugkkBGtcbn 3uvxC9+MhWGI3zii6QWrhT/e/6JESKyfpOLE13PTLtcHkGrJWZNchP2aaKWC7c7UV1+V 37MCUtoGjwdehL7OjJV02uoAJS5SbXS163409lmTpKlGfKm/Ds4THR2X99YPdj8/KIlj E//g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726142543; x=1726747343; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=as23pRzQqXKG+qD312zABP7nHRv1MWlkupvu6DFESpU=; b=nfuzPqz+uphfSo2HtX6dh89gzeGXh6nHxYGw0UaCbT5guja73CgaK6ZRXEyDJ4YewS BHa5o7HssJhn4AmDQKNWx1qB2houaBPodMKtjvBsZtAJSUkHD4iYM7SZa9Sjm4nORbxU qLYDKEn5RGEUF2/BvUwc6lVIc0FnkBbWCKzz6nWbgSS8XPgNsfLGvItJdImGM9+6v8j1 2W1B9c2eqqrP6UZvKGTGNkhGeL4bGguEuFGWP43IpTXhRBc5ZQrMW4/YiU00kJp+y93d otL+bM70Uui/plD3bLuH6BglFOIFiwEBoszNj8KBMXtpesXYLo956vZyILHY8cEca9jO O6vA== X-Gm-Message-State: AOJu0YydrWfDBjKM3WjqXmm5qCmZJ1kxjk4RLx8UO1oRjQzZJ1Dh6nLe MhA3RJB15yeVkypSzfWWH/7HaD7m78mnFCsi/ouBwJxTMP+t0FKxYMKtvCNTEy0= X-Google-Smtp-Source: AGHT+IFX5UQgzLiDkH4MboRf4EybkVnuyoWRrTaoA5gQaZUR/FRE5XFJTVnstGNAxmMa9QigDa340g== X-Received: by 2002:a17:902:d2ce:b0:1fd:672f:2b34 with SMTP id d9443c01a7336-2076e392a1cmr39298705ad.33.1726142542484; Thu, 12 Sep 2024 05:02:22 -0700 (PDT) Received: from hurd ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2076af2566dsm13237895ad.59.2024.09.12.05.02.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 05:02:21 -0700 (PDT) From: Maxim Cournoyer To: Dariqq Subject: Re: [bug#73028] [PATCH] doc: Document usage of #:out-of-source? for meson-build-system. In-Reply-To: (dariqq@posteo.net's message of "Thu, 12 Sep 2024 07:12:22 +0000") References: <878qvy3ent.fsf@gmail.com> <97aa51a8-a945-44f4-8a61-e9bbc3eddba4@posteo.net> <87jzfhy9jf.fsf@gmail.com> Date: Thu, 12 Sep 2024 21:02:19 +0900 Message-ID: <877cbhw050.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73028 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 73028@debbugs.gnu.org, Florian Pelz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Dariqq, Dariqq writes: [...] >>> Maybe it should not be an option at all and instead be #t >>> unconditionally in 'install-license-files phase in meson-build-system? >> Given most build phases of the gnu-build-system, which support >> #:out-of-source? are reused in the meson-build-system, this argument >> needs to be set to #t (which it currently is). But perhaps there's a >> way to hide it from the users, perhaps via the 'private-keywords' >> variable defined in the 'lower' procedure of the (guix build-system >> meson) module (I haven't tested). >> > > Something like that might be a better solution. I am not sure how > these 'private-keywords' work: It looks like #:meson is one but you > can definitly override the default meson being used. Also the > private-arguments seem to get stripped from the arguments in the bag > (not sure what that is exactly) so they might not be passed to the > build phases I think your understanding is correct. The private options are accepted on the build system, but not propagated to the lower build strata (applied to phases). So what we'd like here is to *not* expose an #:out-of-source argument at the build system level, and enforce #:out-of-source #t for the lower build code. I guess the static #t argument could be added to the bag arguments. > > Would such a change require rebuilding (basically) everything given > that currently all packages are already built with #:out-of-source? > set to the default value #t? Yes. To test this kind of change without having to wait for the world to rebuild first, I sometimes make a copy of the build system files and suffix them with -v2 or something. It's a bit of a pain, but faster than waiting for 20k packages to be built. -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 12 15:19:24 2024 Received: (at 73028) by debbugs.gnu.org; 12 Sep 2024 19:19:24 +0000 Received: from localhost ([127.0.0.1]:41966 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sopLg-0004Ly-6F for submit@debbugs.gnu.org; Thu, 12 Sep 2024 15:19:24 -0400 Received: from mout02.posteo.de ([185.67.36.66]:58053) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sopLe-0004Lj-6F for 73028@debbugs.gnu.org; Thu, 12 Sep 2024 15:19:22 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id A31D5240101 for <73028@debbugs.gnu.org>; Thu, 12 Sep 2024 21:19:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1726168747; bh=j5e3B+pPETIm5iCk54ze/NDvgxagJN8J6K13UPNkyp0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:Content-Type: Content-Transfer-Encoding:From; b=osqjukBVMrHWaWKrqBFCHAnA2g8fvn+Kmyy48dvpnmkHH64VJKLsOp0uCz9WuJFhI VwzIQrb247J9xzthpGqTYoc2KJx+pOYJDvI+lNeyfNAvLplMuZl790+RpPrKUP88Sg wUzftcR+8R8jHlZ4LP9UNT+cMNz6WgndesN3XoljXAJcCw92+/f7HszwofTk1iGY55 sAVIUIwdZYzHblWhWWEE201QFiM2JVB/V105VaIejX6A8W+m+6oH1iOEFMalxRKT37 TzqY/w1hlGkKkHKJQTo2zAXhVt1TBxwPkOS0a2YHGu7Dyi7dfkiRbMuqy024D9IME3 5oZ/vtpfV/bfw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4X4S0p0mJDz6tvq; Thu, 12 Sep 2024 21:19:06 +0200 (CEST) Message-ID: <8a62a876-58e8-401f-9716-9b661bd008f5@posteo.net> Date: Thu, 12 Sep 2024 19:19:02 +0000 MIME-Version: 1.0 Subject: Re: [bug#73028] [PATCH] doc: Document usage of #:out-of-source? for meson-build-system. To: Maxim Cournoyer References: <878qvy3ent.fsf@gmail.com> <97aa51a8-a945-44f4-8a61-e9bbc3eddba4@posteo.net> <87jzfhy9jf.fsf@gmail.com> <877cbhw050.fsf@gmail.com> Content-Language: en-US From: Dariqq In-Reply-To: <877cbhw050.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73028 Cc: =?UTF-8?Q?Ludovic_Court=C3=A8s?= , 73028@debbugs.gnu.org, Florian Pelz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 12.09.24 14:02, Maxim Cournoyer wrote: > Hi Dariqq, > > Dariqq writes: > > [...] > >>>> Maybe it should not be an option at all and instead be #t >>>> unconditionally in 'install-license-files phase in meson-build-system? >>> Given most build phases of the gnu-build-system, which support >>> #:out-of-source? are reused in the meson-build-system, this argument >>> needs to be set to #t (which it currently is). But perhaps there's a >>> way to hide it from the users, perhaps via the 'private-keywords' >>> variable defined in the 'lower' procedure of the (guix build-system >>> meson) module (I haven't tested). >>> >> >> Something like that might be a better solution. I am not sure how >> these 'private-keywords' work: It looks like #:meson is one but you >> can definitly override the default meson being used. Also the >> private-arguments seem to get stripped from the arguments in the bag >> (not sure what that is exactly) so they might not be passed to the >> build phases > > I think your understanding is correct. The private options are accepted > on the build system, but not propagated to the lower build strata > (applied to phases). So what we'd like here is to *not* expose an > #:out-of-source argument at the build system level, and enforce > #:out-of-source #t for the lower build code. I guess the static #t > argument could be added to the bag arguments. > This does not work. I tried adding that to the arguments in the bag (and reverting the previous patch) but get an error: Unrecognized keyword: #:out-of-source? I guess this is because meson-(cross-)build now get a keyword they don't know. Maybe we could replace the install-license-files function with a version that has #:out-of-source? set to #t?. Not sure if there is an elegant way to do this? >> >> Would such a change require rebuilding (basically) everything given >> that currently all packages are already built with #:out-of-source? >> set to the default value #t? > > Yes. To test this kind of change without having to wait for the world > to rebuild first, I sometimes make a copy of the build system files and > suffix them with -v2 or something. It's a bit of a pain, but faster than > waiting for 20k packages to be built. > Previously i have been using the tio package for testing because it had no other dependencies depending on meson. However since it got upgraded it now depends on glib ... From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 14 09:42:39 2024 Received: (at 73028) by debbugs.gnu.org; 14 Sep 2024 13:42:39 +0000 Received: from localhost ([127.0.0.1]:45146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1spT2t-0006yW-9X for submit@debbugs.gnu.org; Sat, 14 Sep 2024 09:42:39 -0400 Received: from mail-pf1-f179.google.com ([209.85.210.179]:42149) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1spT2r-0006yG-1C for 73028@debbugs.gnu.org; Sat, 14 Sep 2024 09:42:37 -0400 Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-71798661a52so2309484b3a.0 for <73028@debbugs.gnu.org>; Sat, 14 Sep 2024 06:42:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726321281; x=1726926081; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=vkYT/uY9Ecni793gH1rJ6ABT0uP4iRIifIIZlgCzosg=; b=JCC+VEl28FOVHTCHIdc/NdPTc+3QCoPXvS4q7sg6+xgz7VGN0IXeKaW4ZY7W6jiX4n 7u3mg3H3l0k4wVoqQpRR8LZopzYV+hCfx3uJJTophyYSfp/HxXv4pTRbjoDLvt0FIjoD Wc3joulUAeHbNSVLT2m9ipPRvpcTOd0wOI8TD10rswXppuSEORGUlKVTFbck5wNE8rhy kcDFviwEiWG3ZKBufPyUmrfU95ZuqkSDXVx3ZWcUz1zEeCW0kF/jajOmzWatIoUGnast WGSDZmqYLMJGfc1fU9fbJFvrrJOvyDScvfz5C1o9BeyHXH+FP+UbZAu6hDzHzfuqtFQI LdLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726321281; x=1726926081; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vkYT/uY9Ecni793gH1rJ6ABT0uP4iRIifIIZlgCzosg=; b=i0K5S5DxJtCzN3+PFpybBKd88TclW0TD/P2UBRKrY6IfxMGxQsSU7t39mx29GdlD6/ a+HL65PmKPnntqZ7aAlsaJfjWlrw0o0JLrdn91hgINMn2/RGNdeXqexbtkqGnAVui+oV UMDuVG22K3uK98YZSsmyJGZ5oGxseN6gEN+f9ObNCBfXrvkE4HsJ55Py1peYNRB+GkwU w5orbQSbhH0wKcpGwZzVt3mEFHR1dk+oVWAU/5vN/OiWFSwlP886e0geMeXox+0MY2gq HcLbFiEW3HnpWcsXNXIJTjDdCziMffbIGegY1vlqCvzwxsBfEIjwru3iqYkNojjj+3wm hJSQ== X-Gm-Message-State: AOJu0YxlUs90RBBkeCnY3L/mNYFNEuEZXKVOtiqo+BE52Wse9qCXp6C+ 01t54E44BapH5ho4KJvjbPdD0sjZIlKOMUAktyo1o3BsPqWOHxBJ X-Google-Smtp-Source: AGHT+IHy/aHQ6TFwPDBsY6mo21ISFbS1VqIg3pyTa+A4uRB1/FG/rbNKczyMX21u9JklVwGtHBly+w== X-Received: by 2002:a05:6a00:18a3:b0:717:9896:fb03 with SMTP id d2e1a72fcca58-719263cbe2emr15062334b3a.6.1726321280587; Sat, 14 Sep 2024 06:41:20 -0700 (PDT) Received: from hurd ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bca0b7sm996309b3a.215.2024.09.14.06.41.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Sep 2024 06:41:19 -0700 (PDT) From: Maxim Cournoyer To: Dariqq Subject: Re: [bug#73028] [PATCH] doc: Document usage of #:out-of-source? for meson-build-system. In-Reply-To: <8a62a876-58e8-401f-9716-9b661bd008f5@posteo.net> (dariqq@posteo.net's message of "Thu, 12 Sep 2024 19:19:02 +0000") References: <878qvy3ent.fsf@gmail.com> <97aa51a8-a945-44f4-8a61-e9bbc3eddba4@posteo.net> <87jzfhy9jf.fsf@gmail.com> <877cbhw050.fsf@gmail.com> <8a62a876-58e8-401f-9716-9b661bd008f5@posteo.net> Date: Sat, 14 Sep 2024 22:41:16 +0900 Message-ID: <87plp6s683.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73028 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 73028@debbugs.gnu.org, Florian Pelz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Dariqq, Dariqq writes: > On 12.09.24 14:02, Maxim Cournoyer wrote: >> Hi Dariqq, >> Dariqq writes: >> [...] >> >>>>> Maybe it should not be an option at all and instead be #t >>>>> unconditionally in 'install-license-files phase in meson-build-system? >>>> Given most build phases of the gnu-build-system, which support >>>> #:out-of-source? are reused in the meson-build-system, this argument >>>> needs to be set to #t (which it currently is). But perhaps there's a >>>> way to hide it from the users, perhaps via the 'private-keywords' >>>> variable defined in the 'lower' procedure of the (guix build-system >>>> meson) module (I haven't tested). >>>> >>> >>> Something like that might be a better solution. I am not sure how >>> these 'private-keywords' work: It looks like #:meson is one but you >>> can definitly override the default meson being used. Also the >>> private-arguments seem to get stripped from the arguments in the bag >>> (not sure what that is exactly) so they might not be passed to the >>> build phases >> I think your understanding is correct. The private options are >> accepted >> on the build system, but not propagated to the lower build strata >> (applied to phases). So what we'd like here is to *not* expose an >> #:out-of-source argument at the build system level, and enforce >> #:out-of-source #t for the lower build code. I guess the static #t >> argument could be added to the bag arguments. >> > > This does not work. I tried adding that to the arguments in the bag > (and reverting the previous patch) but get an error: > > Unrecognized keyword: #:out-of-source? > > I guess this is because meson-(cross-)build now get a keyword they > don't know. Hm. Thanks for trying it out. > Maybe we could replace the install-license-files function with a > version that has #:out-of-source? set to #t?. Not sure if there is an > elegant way to do this? Is this really the only reused phase from gnu-build-system that makes use of #:out-of-source? I'd expect the 'configure' to be one, also. And in general it'd be a bit more risky; new gnu-build-system phases that would make use of #:out-of-source could start breaking in the future until thye are specially handled. -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 19 10:08:14 2024 Received: (at 73028) by debbugs.gnu.org; 19 Sep 2024 14:08:14 +0000 Received: from localhost ([127.0.0.1]:33182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srHpN-0001Hw-O0 for submit@debbugs.gnu.org; Thu, 19 Sep 2024 10:08:14 -0400 Received: from mout01.posteo.de ([185.67.36.65]:34017) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srHpI-0001Hb-NY for 73028@debbugs.gnu.org; Thu, 19 Sep 2024 10:08:12 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 7E171240027 for <73028@debbugs.gnu.org>; Thu, 19 Sep 2024 16:07:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1726754864; bh=xfiNwFovoyD/a8iANUZSjjFjF2oJFJy8PnVTAJgiBag=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:Content-Type: Content-Transfer-Encoding:From; b=fK6wR9HVZWAW4yd56j01sCTS5hXxh3PSK0ZbV9me9833Vo6joIsrs5ZQDlZLWgwDO TaWhxq+OPYN/w65o/4AR36WNTQMKYN/vCJnVMRICW31ZC61s6nqnyoJDVRBZmKNYcE R1nzGyN8j/Av1b+SVAhuQlgx4M8LD46UK99LzMNNSAXmdghwNgwBu5YaV0bE458hUl BuANn/RZ76AEh0iHTrG4bQvz4uYs0vfDwfzdY7KkyervfbDHjedqUwjBlPEzWaJoit URfGL8fchww4BNgHUH3YfwFqeUU4DqxHOnRUgRYsB8B+v7hBLugpTClKqjGik/sORT qsYGI8I5juvnw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4X8cmG6jtkz9rxD; Thu, 19 Sep 2024 16:07:42 +0200 (CEST) Message-ID: <86f53b3e-976c-4757-9dcb-d41dce7263b9@posteo.net> Date: Thu, 19 Sep 2024 14:07:10 +0000 MIME-Version: 1.0 Subject: Re: [bug#73028] [PATCH] doc: Document usage of #:out-of-source? for meson-build-system. To: Maxim Cournoyer References: <878qvy3ent.fsf@gmail.com> <97aa51a8-a945-44f4-8a61-e9bbc3eddba4@posteo.net> <87jzfhy9jf.fsf@gmail.com> <877cbhw050.fsf@gmail.com> <8a62a876-58e8-401f-9716-9b661bd008f5@posteo.net> <87plp6s683.fsf@gmail.com> Content-Language: en-US From: Dariqq In-Reply-To: <87plp6s683.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73028 Cc: =?UTF-8?Q?Ludovic_Court=C3=A8s?= , 73028@debbugs.gnu.org, Florian Pelz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 14.09.24 15:41, Maxim Cournoyer wrote: > Hi Dariqq, > > Dariqq writes: > >> >> This does not work. I tried adding that to the arguments in the bag >> (and reverting the previous patch) but get an error: >> >> Unrecognized keyword: #:out-of-source? >> >> I guess this is because meson-(cross-)build now get a keyword they >> don't know. > > Hm. Thanks for trying it out. > Not an expert on how this works but it looks like when a phase has a keyword that is not being passed in by the build-system it is treated as #f even if there is no default parameter specified in install-license-files function itself. If there is no easy other way what about leaving the parameter undocumented as is? Maybe Ludo can elaborate on what the original concern was? >> Maybe we could replace the install-license-files function with a >> version that has #:out-of-source? set to #t?. Not sure if there is an >> elegant way to do this? > > Is this really the only reused phase from gnu-build-system that makes > use of #:out-of-source? I'd expect the 'configure' to be one, also. > And in general it'd be a bit more risky; new gnu-build-system phases > that would make use of #:out-of-source could start breaking in the > future until thye are specially handled. > As far as I can see only the configure phase and the install-license-phase in gnu-build-system use that parameter. As meson overwrites configure with its own it only the install-license-files phase uses it. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 22 01:59:33 2024 Received: (at 73028) by debbugs.gnu.org; 22 Sep 2024 05:59:33 +0000 Received: from localhost ([127.0.0.1]:40665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ssFd6-0003Jq-QX for submit@debbugs.gnu.org; Sun, 22 Sep 2024 01:59:33 -0400 Received: from mail-pj1-f51.google.com ([209.85.216.51]:58575) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ssFd5-0003Ja-9n for 73028@debbugs.gnu.org; Sun, 22 Sep 2024 01:59:32 -0400 Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-2dee71e47c5so438575a91.0 for <73028@debbugs.gnu.org>; Sat, 21 Sep 2024 22:59:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726984684; x=1727589484; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=8L2ysxis/nRj8ZOK/Wr5CrYBVt9gPcWfuQz1yihjF4s=; b=QdUNXuD6/K+o1Xwv2hYkMhUYnBTGXtnwboldA2wIVx8umbTXdeHQNxUp/TdwujuQE3 e0cWetm9Alt/DFPfHXUor6U9CHygwTLsXtUHDv985h9X3CZLublnOwTvek7N3hwN6Lfa EL7SnWfh7XjhU3ecTo4Qw8eP6txxZgkTBOCDah1q76iB/uCATN4A1A4FLM3zmNCwqpSD PRMqLCJgKXZEc2KGuw1cfHU5JWkWoFjycYOZMPo+u20twJ9tqOl2KhNw1ZLBICD5PVuT 8yYrAgPcvjVUoneWU7OBMPjht3mClQ4xaG/kkCTfqS/6jyBOIopeycZBEScVLUPLTVyX gpSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726984684; x=1727589484; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8L2ysxis/nRj8ZOK/Wr5CrYBVt9gPcWfuQz1yihjF4s=; b=M3KjzpHi+gbGkKNTEPanPQSEoFhuMXufPo/NXJdUXrsT7tXUTVerELu0yfI9eg0k63 B0BASMjuj55/cCLsozctPkddZeLZT4kSKZyIil5w8rqOmogILMow9yPbTYNe6dmsFSCU PrcO/uPqSPvrOsqdkGWKJuQYlWXtpeVl3q2YOHDrn4YkEOMWXdL/eBC/OSkX//aHwlB1 RA+IrZ9IL+qejtBwLfNp3VWgFLGgWyrzwUM1Vy4jhOUBDP/vvng8ucV7Lp2AcNxZ9Z6x 45pYKKJ/+EVlhU7n2ByekvCMfLEmaugSsgG6zcRoHO81ljECaXf8HI1+Kif5mamShVBy OcAA== X-Gm-Message-State: AOJu0Yz2aUpvBlVFecq3M6XegUwuDpvH5qCB+XIWScZIYeGFK8GIs/XG zvihEGijwRySGNA0mKCu91iFzWYIkA57NGP51rYTGwGcp5i9aE6X X-Google-Smtp-Source: AGHT+IERn1oHEaNdfU6pAI4EMQI0s1QGSq4cUpz4VyYUXluUEynxRVYoSR5/ngYfQG+kkodGt8dRtw== X-Received: by 2002:a17:90a:4bcc:b0:2d8:9506:5dfd with SMTP id 98e67ed59e1d1-2dd80cd7351mr9943425a91.35.1726984684160; Sat, 21 Sep 2024 22:58:04 -0700 (PDT) Received: from hurd ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2dd6ee7f5ffsm7084400a91.12.2024.09.21.22.58.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Sep 2024 22:58:02 -0700 (PDT) From: Maxim Cournoyer To: Dariqq Subject: Re: [bug#73028] [PATCH] doc: Document usage of #:out-of-source? for meson-build-system. In-Reply-To: <86f53b3e-976c-4757-9dcb-d41dce7263b9@posteo.net> (dariqq@posteo.net's message of "Thu, 19 Sep 2024 14:07:10 +0000") References: <878qvy3ent.fsf@gmail.com> <97aa51a8-a945-44f4-8a61-e9bbc3eddba4@posteo.net> <87jzfhy9jf.fsf@gmail.com> <877cbhw050.fsf@gmail.com> <8a62a876-58e8-401f-9716-9b661bd008f5@posteo.net> <87plp6s683.fsf@gmail.com> <86f53b3e-976c-4757-9dcb-d41dce7263b9@posteo.net> Date: Sun, 22 Sep 2024 14:57:58 +0900 Message-ID: <87jzf4kz6h.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73028 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 73028@debbugs.gnu.org, Florian Pelz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Dariqq, Dariqq writes: > On 14.09.24 15:41, Maxim Cournoyer wrote: >> Hi Dariqq, >> Dariqq writes: >> >>> >>> This does not work. I tried adding that to the arguments in the bag >>> (and reverting the previous patch) but get an error: >>> >>> Unrecognized keyword: #:out-of-source? >>> >>> I guess this is because meson-(cross-)build now get a keyword they >>> don't know. >> Hm. Thanks for trying it out. >> > Not an expert on how this works but it looks like when a phase has a > keyword that is not being passed in by the build-system it is treated > as #f even if there is no default parameter specified in > install-license-files function itself. > > If there is no easy other way what about leaving the parameter > undocumented as is? Maybe Ludo can elaborate on what the original > concern was? Unless someone is able to explain what the use case is for its behavior, I think that's what I would do. It's easy and we don't have to commit to preserving that behavior forever if it doesn't have an actual use. -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 16 03:31:55 2025 Received: (at control) by debbugs.gnu.org; 16 Jan 2025 08:31:55 +0000 Received: from localhost ([127.0.0.1]:59935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tYLIA-0001lL-Sy for submit@debbugs.gnu.org; Thu, 16 Jan 2025 03:31:55 -0500 Received: from mout02.posteo.de ([185.67.36.66]:45827) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tYLI5-0001kx-Ef for control@debbugs.gnu.org; Thu, 16 Jan 2025 03:31:53 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 72886240101 for ; Thu, 16 Jan 2025 09:31:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1737016302; bh=DThctxlzUBy1Oqp29s1aUL01ucxrAY0hRBOSPJZM5nY=; h=Message-ID:Date:MIME-Version:To:Subject:From:Content-Type: Content-Transfer-Encoding:From; b=mnf7wMCuT4B2NEad0OXpdxBaH/7VbjhQPwNWxjHbhvBntJhVuBpPvgIq2nIfgVE1B CQwT9MZsugWFUp6GYiZmTiUjlwol4FRbFKirxmyWZZhlTEOhVEqyRVJvt1QhQKLZ14 qXk4zsZHpQFbNXqjnImdY74hSB5x9CDiJOlaQZFFmwKOd+CK3dZ+8NdUyejzb9Itb3 iiI+MgQrnk2gJdJuigm1NSAzMbiN+MMmgt0mEXdxV/EwghYag7+E86SuG8i7Mf7y4M 0eJlf1es3qHd5rS4W0s1mDbwQae98CkU4z10TsvQCigXGgZfo1yEFDp008JLvjd3bV 1xKtErD8+cqIA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4YYbgc4Ypqz9rxG for ; Thu, 16 Jan 2025 09:31:40 +0100 (CET) Message-ID: Date: Thu, 16 Jan 2025 08:31:28 +0000 MIME-Version: 1.0 To: control@debbugs.gnu.org Subject: control message for bug #73028 Content-Language: en-US From: Dariqq Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 73028 quit From unknown Tue Aug 19 02:50:27 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 13 Feb 2025 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator