Subject: Re: [PATCH v5 1/3] gnu: Add libpqmarble.

From: Liliana Marie Prikler <[email-masked]>
Date: Thu, 20 Feb 2025 21:54:09 +0100

Am Sonntag, dem 08.09.2024 um 01:01 +0530 schrieb Ashvith Shetty:
> * gnu/packages/gnome-xyz.scm (libpqmarble-2.0.0): New public
> variable.
New variable suffices.  Same for the other patches.
> 
> Change-Id: I15889e5e17eb533d8486322d6db48eb31ee557fc
> ---
>  gnu/packages/gnome-xyz.scm | 36 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
> 
> diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
> index a09c0befb0..c5abcbb14d 100644
> --- a/gnu/packages/gnome-xyz.scm
> +++ b/gnu/packages/gnome-xyz.scm
> @@ -20,6 +20,7 @@
>  ;;; Copyright © 2022 Sughosha <[email-masked]>
>  ;;; Copyright © 2022 Denis 'GNUtoo' Carikli
> <[email-masked]>
>  ;;; Copyright © 2023 Eidvilas Markevičius
> <[email-masked]>
> +;;; Copyright © 2024 Ashvith Shetty <[email-masked]>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -1759,3 +1760,38 @@ (define-public tiramisu
>  notifications to STDOUT in order to allow the user to process
> notifications any
>  way they prefer.")
>      (license license:expat)))
> +
> +(define-public libpqmarble
> +  (package
> +    (name "libpqmarble")
> +    (version "2.0.0")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://gitlab.gnome.org/raggesilver/marble")
> +             ;; Tag for v2.0.0 is currently missing, so use commit
> instead
> +             (commit "f240b2ec7d5cdacb8fdcc553703420dc5101ffdb")))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> "0jx53yadqkcsfk9khkqmapznd8g9xg98wkgkigh964dj6gpp7fx1"))))
> +    (build-system meson-build-system)
> +    (arguments
> +     `(#:glib-or-gtk? #t
> +       #:phases (modify-phases %standard-phases
> +                  (add-after 'unpack 'fix-gtk4-update-icon-cache
> +                    (lambda _
> +                      (substitute* "build-aux/meson/postinstall.py"
> +                        (("gtk-update-icon-cache")
> +                         "gtk4-update-icon-cache")))))))
You save yourself a native input if you replace it with "true".  We
tend to disable the icon builder, because we have a profile hook
anyway.
> +    (native-inputs (list pkg-config
> +                         vala
> +                         `(,gtk "bin") ;gtk4-update-icon-cache
> +                         `(,glib "bin") ;for glib-compile-schemas,
> etc.
> +                         desktop-file-utils ;for update-desktop-
> database
> +                         gobject-introspection))
> +    (inputs (list gtk))
> +    (home-page "https://gitlab.gnome.org/raggesilver/marble")
> +    (synopsis "Utility library for GNOME apps")
> +    (description "Utility library for GNOME apps.")
Descriptions should be full sentences.  
> +    (license license:gpl3)))
Should be gpl3+.  (Note the "or any later version" in the source files)

Cheers