GNU bug report logs - #72993
31.0.50; 4f521fa14c18f57e5207bffd68e9f79454dccc79 breaks binding mode hooks in use-package

Previous Next

Full log

Message #8 received at 72993 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Steven Allen <steven <at> stebalien.com>, John Wiegley <johnw <at> gnu.org>
Cc: 72993 <at> debbugs.gnu.org
Subject: Re: bug#72993: 31.0.50;
 4f521fa14c18f57e5207bffd68e9f79454dccc79 breaks binding mode hooks in
 use-package
Date: Tue, 03 Sep 2024 05:34:39 +0300

> Date: Mon, 02 Sep 2024 19:01:31 -0700
> From:  Steven Allen via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> 
> 
> In GNU Emacs 31.0.50 (build 1, x86_64-pc-linux-gnu, cairo version
>  1.18.0) of 2024-09-01 built on Laptop
> Repository revision: 92ea393a16e5c99a8860dab368c6ca3ca6abc3c5
> Repository branch: master
> Windowing system distributor 'The X.Org Foundation', version 11.0.12101013
> System Description: Arch Linux
> 
> To reproduce:
> 
>     (use-package foo
>         :hook (eshell-mode . some-function))
> 
> Previously, `use-package' always appended `-hook' to the hook variable name.
> After 4f521fa14c18f57e5207bffd68e9f79454dccc79, `use-package' only does
> so if the passed variable name isn't bound. Unfortunately, this breaks
> binding mode hooks, e.g.:
> 
>     :hook (some-mode . some-function)
> 
> Because `some-mode' is usually bound.

John, any comments or suggestions?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.