From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 02 22:02:48 2024 Received: (at submit) by debbugs.gnu.org; 3 Sep 2024 02:02:48 +0000 Received: from localhost ([127.0.0.1]:55832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slIsY-0007rG-Pw for submit@debbugs.gnu.org; Mon, 02 Sep 2024 22:02:47 -0400 Received: from lists.gnu.org ([209.51.188.17]:52858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slIsR-0007qw-AC for submit@debbugs.gnu.org; Mon, 02 Sep 2024 22:02:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1slIrR-0007r6-At for bug-gnu-emacs@gnu.org; Mon, 02 Sep 2024 22:01:37 -0400 Received: from fhigh2-smtp.messagingengine.com ([103.168.172.153]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1slIrO-0004Ez-Dd for bug-gnu-emacs@gnu.org; Mon, 02 Sep 2024 22:01:37 -0400 Received: from phl-compute-01.internal (phl-compute-01.nyi.internal [10.202.2.41]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 69B2D1140165 for ; Mon, 2 Sep 2024 22:01:33 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-01.internal (MEProxy); Mon, 02 Sep 2024 22:01:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com; h=cc:content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:subject:subject:to:to; s=fm3; t=1725328893; x=1725415293; bh=9X0M2TVseGs7TPTAOq59RXhPeefFeRT+ ZX5oino4FNw=; b=rkbN1deQDp8ZvLwJAWqwjj66V9ZIVdnNIhd78s2rebu5CL8T 0W+Q8j0IpSj8F08RedDSerNtbSdGUuGXVnS8sDcS2DEsuIKh5kvQkJYOQiCjQB0J EaxdEE8bptINdOq1LrcOm9KafG5y4XRvVErdeocn7zy+rhh2hduPTgibMCtALLK/ rpRQl4Z33BQo66fP80gE9PCLBeIsIH8LVDHMVyZ6OIZlpr4na7saZ3WGj0pxhRlq JoxyCe170gAR7TKEJvWnO1AtIPT67UmhXXMbNk6danRWEwlb+fbAVtax1diVsk2k 9UUfZU2rr3cLmU/mFM1MNfqRmTQdoEzQ5P8+ug== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1725328893; x=1725415293; bh=9X0M2TVseGs7TPTAOq59RXhPeefFeRT+ZX5 oino4FNw=; b=XN2BtuydzDHs91Kk4rhY3hUctGBOQcF+t0h9lThKqEWko6YCLMm mPEPw1j/jrEvClAc5/Shb1XfTtEseBCA/KdIFFA/75z38SVyFRV2UCO6W3hUZqKW gBohK3BLmaLFaAw6YvtFoinADhfoTOzY1P6MAG5KuVKEsdr44A1/4+dAJ80XUiud WTQkkrdv/GP8w4rl2MW+HwF26cjGpoSprfR5CqIKYdEUM6hYCk6nyLS5j6MKN2bS ZP0oXThtKvgGidaMJNC4iUdKCaqFyrg730ClRXE9wDhB5pV/4CyXrMSX/dooM/py JTp1BrUcAahvZVjAVUzrLQzCIdmgoPGBY0g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudehgedgheehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvffuff fkgggtsehttdertddttddtnecuhfhrohhmpefuthgvvhgvnhcutehllhgvnhcuoehsthgv vhgvnhesshhtvggsrghlihgvnhdrtghomheqnecuggftrfgrthhtvghrnhepfeektddutd ethfegkeettdeggeejgedvudethefhtefhveelfeevhefhhfdvffejnecuvehluhhsthgv rhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshhtvghvvghnsehsthgvsg grlhhivghnrdgtohhmpdhnsggprhgtphhtthhopedupdhmohguvgepshhmthhpohhuthdp rhgtphhtthhopegsuhhgqdhgnhhuqdgvmhgrtghssehgnhhurdhorhhg X-ME-Proxy: Feedback-ID: ie8a146a7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Mon, 2 Sep 2024 22:01:32 -0400 (EDT) From: Steven Allen To: bug-gnu-emacs@gnu.org Subject: 31.0.50; 4f521fa14c18f57e5207bffd68e9f79454dccc79 breaks binding mode hooks in use-package X-Debbugs-Cc: Date: Mon, 02 Sep 2024 19:01:31 -0700 Message-ID: <87mskpo5qc.fsf@stebalien.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=103.168.172.153; envelope-from=steven@stebalien.com; helo=fhigh2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) In GNU Emacs 31.0.50 (build 1, x86_64-pc-linux-gnu, cairo version 1.18.0) of 2024-09-01 built on Laptop Repository revision: 92ea393a16e5c99a8860dab368c6ca3ca6abc3c5 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101013 System Description: Arch Linux To reproduce: (use-package foo :hook (eshell-mode . some-function)) Previously, `use-package' always appended `-hook' to the hook variable name. After 4f521fa14c18f57e5207bffd68e9f79454dccc79, `use-package' only does so if the passed variable name isn't bound. Unfortunately, this breaks binding mode hooks, e.g.: :hook (some-mode . some-function) Because `some-mode' is usually bound. Configured using: 'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/var --mandir=/usr/share/man --with-gameuser=:games --with-modules --without-m17n-flt --without-selinux --without-pop --without-gconf --enable-link-time-optimization --with-native-compilation=yes --with-xinput2 --with-x-toolkit=no --without-toolkit-scroll-bars --without-xft --without-xaw3d --without-gsettings --with-cairo-xcb --with-sound=no --with-tree-sitter --without-gpm --without-compress-install '--program-transform-name=s/\([ec]tags\)/\1.emacs/' 'CFLAGS=-march=native -mtune=native -O3 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -flto=auto' 'LDFLAGS=-Wl,-O1 -Wl,--sort-common -Wl,--as-needed -Wl,-z,relro -Wl,-z,now -Wl,-z,pack-relative-relocs -flto=auto'' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS HARFBUZZ JPEG LCMS2 LIBOTF LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY OLDXMENU PDUMPER PNG RSVG SECCOMP SQLITE3 THREADS TIFF TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Eshell Minor modes in effect: eshell-syntax-highlighting-mode: t notmuch-bookmarks-mode: t windmove-mode: t global-atomic-chrome-edit-mode: t i3bar-mode: t ednc-mode: t exwm-xsettings-mode: t exwm-background-mode: t exwm-systemtray-mode: t exwm-randr-mode: t auto-compile-on-load-mode: t auto-compile-on-save-mode: t save-place-mode: t savehist-mode: t openwith-mode: t org-super-agenda-mode: t global-org-modern-mode: t goto-address-mode: t eshell-prompt-mode: t eshell-hist-mode: t eshell-pred-mode: t eat-eshell-mode: t eat--eshell-local-mode: t eshell-proc-mode: t eshell-arg-mode: t magit-todos-mode: t global-git-commit-mode: t magit-auto-revert-mode: t server-mode: t recentf-mode: t global-treesit-auto-mode: t editorconfig-mode: t yas-global-mode: t yas-minor-mode: t async-bytecomp-package-mode: t sudo-edit-indicator-mode: t global-auto-revert-mode: t vertico-mode: t corfu-popupinfo-mode: t global-corfu-mode: t corfu-mode: t isearch-mb-mode: t pixel-scroll-precision-mode: t global-hl-todo-mode: t all-the-icons-completion-mode: t marginalia-mode: t global-form-feed-st-mode: t global-anzu-mode: t anzu-mode: t global-jinx-mode: t evil-goggles-mode: t global-evil-surround-mode: t evil-surround-mode: t global-evil-collection-unimpaired-mode: t evil-collection-unimpaired-mode: t evil-mode: t evil-local-mode: t desktop-environment-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tab-bar-history-mode: t tab-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t window-divider-mode: t minibuffer-regexp-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/steb/.cache/emacs/elpa/protobuf-mode-20240823.1417/protobuf-mode hides /usr/share/emacs/site-lisp/protobuf-mode /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch hides /usr/share/emacs/site-lisp/notmuch /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch-wash hides /usr/share/emacs/site-lisp/notmuch-wash /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch-tree hides /usr/share/emacs/site-lisp/notmuch-tree /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch-tag hides /usr/share/emacs/site-lisp/notmuch-tag /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch-show hides /usr/share/emacs/site-lisp/notmuch-show /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch-query hides /usr/share/emacs/site-lisp/notmuch-query /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch-print hides /usr/share/emacs/site-lisp/notmuch-print /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch-parser hides /usr/share/emacs/site-lisp/notmuch-parser /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch-mua hides /usr/share/emacs/site-lisp/notmuch-mua /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch-message hides /usr/share/emacs/site-lisp/notmuch-message /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch-maildir-fcc hides /usr/share/emacs/site-lisp/notmuch-maildir-fcc /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch-lib hides /usr/share/emacs/site-lisp/notmuch-lib /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch-jump hides /usr/share/emacs/site-lisp/notmuch-jump /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch-hello hides /usr/share/emacs/site-lisp/notmuch-hello /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch-draft hides /usr/share/emacs/site-lisp/notmuch-draft /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch-crypto hides /usr/share/emacs/site-lisp/notmuch-crypto /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch-compat hides /usr/share/emacs/site-lisp/notmuch-compat /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch-company hides /usr/share/emacs/site-lisp/notmuch-company /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch-address hides /usr/share/emacs/site-lisp/notmuch-address /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/coolj hides /usr/share/emacs/site-lisp/coolj /home/steb/.cache/emacs/elpa/filechooser-0.2.1/filechooser hides /usr/share/emacs/site-lisp/filechooser /home/steb/.cache/emacs/elpa/filechooser-0.2.1/filechooser-autoloads hides /usr/share/emacs/site-lisp/filechooser-autoloads /home/steb/.cache/emacs/elpa/transient-20240831.2233/transient hides /usr/share/emacs/31.0.50/lisp/transient /home/steb/.cache/emacs/elpa/modus-themes-4.5.0/theme-loaddefs hides /usr/share/emacs/31.0.50/lisp/theme-loaddefs Features: (shadow sort mail-extr hippie-exp emacsbug emacsql-sqlite-builtin sqlite use-package-ensure use-package-core info-colors evil-collection-helpful helpful cc-langs trace cl-print evil-collection-edebug edebug info-look evil-collection-elisp-refs elisp-refs misearch multi-isearch evil-collection-eglot eglot external-completion jsonrpc evil-collection-ert ert ewoc evil-collection-debug debug backtrace rainbow-mode rainbow-delimiters evil-collection-flymake flymake eshell-syntax-highlighting help-fns radix-tree tramp-cmds bash-completion app-launcher evil-collection-vc-git vc-git vc-dispatcher evil-collection-consult consult magit-bookmark org-bookmark-heading notmuch-bookmarks evil-collection-bookmark bookmark textsec uni-scripts idna-mapping ucs-normalize uni-confusable textsec-check shr pixel-fill kinsoku url-file windmove mule-util image-file image-converter evil-collection-view view help-macro vertico-repeat systemctl em-elecslash em-glob em-extpipe em-basic em-alias pinentry evil-collection-atomic-chrome atomic-chrome websocket bindat i3bar ednc filechooser dbus exwm-xsettings xcb-xsettings exwm-background exwm-systemtray xcb-systemtray xcb-xembed exwm-randr xcb-randr exwm exwm-input xcb-keysyms xcb-xkb exwm-manage exwm-floating xcb-cursor xcb-render exwm-layout exwm-workspace exwm-core xcb-ewmh xcb-icccm xcb xcb-xproto xcb-types xcb-debug cus-start posframe visual-wrap face-remap visual-fill-column ligature evil-org corg org-appear ws-butler oc-basic bibtex ol-man ol-info ol-docview evil-collection-doc-view doc-view jka-compr evil-collection-image image-mode exif auto-compile saveplace tramp-cache time-stamp savehist openwith org-super-agenda ts ht org-habit org-crypt org-protocol ob-http ob-http-mode org-modern ob-dot ob-latex ob-python evil-collection-python python ob-gnuplot ox-odt rng-loc rng-uri rng-parse rng-match rng-dt rng-util rng-pttrn nxml-parse nxml-ns nxml-enc xmltok nxml-util ox-latex ox-icalendar evil-org-agenda org-agenda ox-html table ox-ascii ox-publish ox org-attach org-element org-persist org-id org-refile org-element-ast inline avl-tree ob-calc calc-store calc-trail calc-ext evil-collection-calc calc calc-loaddefs calc-macs ob-shell evil-collection-org org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro evil-collection-xref xref org-src evil-collection-sh-script sh-script smie executable ob-comint org-pcomplete org-list org-footnote org-faces org-entities ob-emacs-lisp ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys oc org-loaddefs org-compat org-version org-macs notmuch-addr evil-collection-notmuch notmuch notmuch-tree notmuch-jump notmuch-hello notmuch-show notmuch-print notmuch-crypto notmuch-mua notmuch-message notmuch-draft notmuch-maildir-fcc notmuch-address notmuch-company notmuch-parser notmuch-wash coolj goto-addr icalendar diary-lib diary-loaddefs evil-collection-calendar cal-menu calendar cal-loaddefs notmuch-tag notmuch-lib notmuch-compat mm-view mml-smime smime dig eshell-prompt-extras em-dirs em-ls em-prompt em-hist em-unix em-pred esh-mode esh-var evil-collection-eat eat evil-collection-term term disp-table ehelp eshell esh-cmd generator esh-ext esh-proc esh-opt esh-io esh-arg esh-module esh-module-loaddefs esh-util evil-collection-forge forge-repos forge-tablist hl-line forge-topics forge-commands forge-semi forge-bitbucket buck forge-gogs gogs forge-gitea gtea forge-gitlab glab forge-github ghub-graphql treepy gsexp ghub url-http url-gw nsm url-auth gnutls forge-notify forge-revnote forge-pullreq forge-issue forge-topic yaml eieio-custom bug-reference forge-post let-alist evil-collection-markdown-mode markdown-mode edit-indirect evil-collection-outline noutline outline forge-repo forge forge-core forge-db closql emacsql-sqlite-common emacsql emacsql-compiler eieio-base evil-collection-magit-todos magit-todos pcre2el rxt re-builder evil-collection-grep grep evil-collection-compile compile evil-collection-magit magit-submodule magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit evil-collection-magit-repos magit-repos magit-apply magit-wip magit-log which-func evil-collection-imenu imenu magit-diff smerge-mode diff diff-mode track-changes git-commit evil-collection-log-edit log-edit message sendmail yank-media puny evil-collection-dired dired dired-loaddefs rfc822 mml mml-sec evil-collection-epa epa derived epg rfc6068 epg-config gnus-util text-property-search mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log magit-core magit-autorevert magit-margin magit-transient magit-process with-editor server magit-mode transient benchmark magit-git magit-base evil-collection-magit-section magit-section cursor-sensor crm tramp-sh recentf tree-widget treesit-auto editorconfig editorconfig-core editorconfig-core-handle editorconfig-fnmatch yasnippet async-bytecomp async sudo-edit easy-mmode tramp trampver tramp-integration files-x tramp-message tramp-compat shell pcomplete evil-collection-comint comint ansi-osc parse-time iso8601 time-date format-spec ansi-color tramp-loaddefs autorevert filenotify project vertico corfu-popupinfo evil-collection-corfu corfu orderless isearch-mb pixel-scroll cua-base hl-todo all-the-icons-completion all-the-icons all-the-icons-faces all-the-icons-data-material-icons all-the-icons-data-fluentui-system-icons all-the-icons-data-fontawesome-4 all-the-icons-data-weather-icons all-the-icons-data-vscode-codicons all-the-icons-data-octicons all-the-icons-data-mfixx all-the-icons-data-file-icons all-the-icons-data-devopicons all-the-icons-data-alltheicons svg dom xml marginalia form-feed-st anzu modus-vivendi-theme modus-themes jinx evil-goggles pulse color evil-textobj-tree-sitter evil-textobj-tree-sitter-thing-at-point evil-textobj-tree-sitter-core treesit evil-args evil-surround evil-collection-unimpaired evil-collection-tabulated-list evil-collection-tab-bar evil-collection-simple evil-collection-replace evil-collection-process-menu evil-collection-package-menu evil-collection-kmacro evil-collection-info evil-collection-indent evil-collection-help evil-collection-elisp-mode evil-collection-eldoc evil-collection-custom evil-collection-buff-menu evil-collection annalist evil evil-integration evil-maps evil-commands evil-digraphs pcase reveal evil-jumps evil-command-window evil-types evil-search evil-ex evil-macros evil-repeat evil-states evil-core comp-run advice evil-common thingatpt rect evil-vars ring edmacro kmacro general f dash s mode-local find-func no-littering compat finder-inf notmuch-version info all-the-icons-completion-autoloads all-the-icons-dired-autoloads all-the-icons-ibuffer-autoloads all-the-icons-autoloads app-launcher-autoloads aria2-autoloads atomic-chrome-autoloads auto-compile-autoloads bash-completion-autoloads bluetooth-autoloads buffer-move-autoloads calibre-autoloads cape-autoloads casual-calc-autoloads casual-dired-autoloads casual-ibuffer-autoloads casual-info-autoloads casual-lib-autoloads clojure-mode-autoloads comint-mime-autoloads consult-eglot-autoloads consult-project-extra-autoloads corfu-autoloads corg-autoloads csv-mode-autoloads dape-autoloads devdocs-autoloads dired-filter-autoloads dired-hacks-utils-autoloads dired-k-autoloads discomfort-autoloads debase-autoloads disk-usage-autoloads eat-autoloads edit-indirect-autoloads ednc-autoloads eff-autoloads ellama-autoloads embark-consult-autoloads consult-autoloads embark-autoloads ement-autoloads eshell-prompt-extras-autoloads eshell-syntax-highlighting-autoloads evil-anzu-autoloads anzu-autoloads evil-args-autoloads evil-collection-autoloads annalist-autoloads evil-goggles-autoloads evil-nerd-commenter-autoloads evil-org-autoloads evil-surround-autoloads evil-textobj-tree-sitter-autoloads evm-mode-autoloads expand-region-autoloads exwm-autoloads filechooser-autoloads flymake-ruff-autoloads form-feed-st-autoloads general-autoloads git-link-autoloads git-modes-autoloads gnuplot-autoloads graphviz-dot-mode-autoloads helpful-autoloads elisp-refs-autoloads htmlize-autoloads i3bar-autoloads igist-autoloads info-colors-autoloads isearch-mb-autoloads iwindow-autoloads jinx-autoloads journalctl-autoloads kotlin-mode-autoloads kubernetes-evil-autoloads evil-autoloads goto-chg-autoloads kubernetes-autoloads ligature-autoloads link-hint-autoloads avy-autoloads llm-autoloads magit-popup-autoloads magit-todos-autoloads hl-todo-autoloads f-autoloads marginalia-autoloads mastodon-autoloads microdata-autoloads modus-themes-autoloads named-pipe-autoloads nftables-mode-autoloads no-littering-autoloads notmuch-addr-autoloads notmuch-transient-autoloads nov-autoloads esxml-autoloads kv-autoloads ob-http-autoloads ol-notmuch-autoloads notmuch-autoloads openwith-autoloads orderless-autoloads org-appear-autoloads org-bookmark-heading-autoloads org-download-autoloads async-autoloads org-modern-autoloads org-super-agenda-autoloads orgit-forge-autoloads orgit-autoloads forge-autoloads markdown-mode-autoloads magit-autoloads ghub-autoloads closql-autoloads emacsql-autoloads ox-pandoc-autoloads ht-autoloads package-lint-flymake-autoloads package-lint-autoloads password-store-autoloads pcre2el-autoloads pdf-tools-autoloads persist-autoloads pinentry-autoloads pkgbuild-mode-autoloads playerctl-autoloads plz-autoloads posframe-autoloads proced-narrow-autoloads protobuf-mode-autoloads pulseaudio-control-autoloads qrencode-autoloads rainbow-delimiters-autoloads rainbow-mode-autoloads request-autoloads rg-autoloads rmsbolt-autoloads rust-playground-autoloads solidity-mode-autoloads spinner-autoloads ssh-config-mode-autoloads sudo-edit-autoloads svg-lib-autoloads syncthing-autoloads systemctl-autoloads systemd-autoloads tablist-autoloads taxy-magit-section-autoloads taxy-autoloads magit-section-autoloads tmr-autoloads transient-autoloads treepy-autoloads treesit-auto-autoloads ts-autoloads s-autoloads dash-autoloads tzc-autoloads udev-mode-autoloads vala-mode-autoloads cc-styles cc-align cc-engine cc-vars cc-defs vertico-autoloads vimrc-mode-autoloads visual-fill-column-autoloads vundo-autoloads wat-ts-mode-autoloads watch-autoloads web-mode-autoloads websocket-autoloads wgrep-autoloads whisper-autoloads with-editor-autoloads wordnut-autoloads ws-butler-autoloads xelb-autoloads yaml-autoloads yasnippet-autoloads comp comp-cstr cl-extra help-mode comp-common warnings rx xdg package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cus-edit pp cus-load icons wid-edit cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting font-render-setting cairo xinput2 x multi-tty move-toolbar make-network-process native-compile emacs) Memory information: ((conses 16 1549386 918104) (symbols 48 75074 27) (strings 32 368173 78940) (string-bytes 1 11687125) (vectors 16 172279) (vector-slots 8 2736571 946452) (floats 8 831 5037) (intervals 56 25767 10683) (buffers 992 47)) From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 02 22:35:52 2024 Received: (at 72993) by debbugs.gnu.org; 3 Sep 2024 02:35:52 +0000 Received: from localhost ([127.0.0.1]:56055 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slJOZ-0000P7-P0 for submit@debbugs.gnu.org; Mon, 02 Sep 2024 22:35:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slJOW-0000Oo-Ge for 72993@debbugs.gnu.org; Mon, 02 Sep 2024 22:35:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1slJNR-0007QH-Cz; Mon, 02 Sep 2024 22:34:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=4uz8Txy390CsjMT1eV8fu1iQWG52aqTHkNRxBwIt3iM=; b=gEvawCQtIbPq 19vKM6buoqTD45KsiO2y+PvNVwwtumffY3svVoZCmp1ShBuzYH1i3YLkSWRyTgcENq4MgjDygTW9W glrtEVBSC/OLX+qE1MFK/AgTxHrT4p0hnzOwOnl+eefyN+B37XVs1O7nDbnAASc/Nk/rkLfss00Ri SXvhnBLRNhJRqnWNSCJNScjMA9TjIKDGZdzD8Q+MjkuJFpLqQOWHOIXCBrw/nAQAKKtzdNMiwXXq1 XLp0fFVwpzCtmcD0GPTieiIMOaULsciGbduDvL2pVfRFyPT+Z8Zn3iboubIgPOYcza2XUW+a7DDQp 0Uq5e2/vGImKzs0d7tdVhA==; Date: Tue, 03 Sep 2024 05:34:39 +0300 Message-Id: <86v7zd79ds.fsf@gnu.org> From: Eli Zaretskii To: Steven Allen , John Wiegley In-Reply-To: <87mskpo5qc.fsf@stebalien.com> (bug-gnu-emacs@gnu.org) Subject: Re: bug#72993: 31.0.50; 4f521fa14c18f57e5207bffd68e9f79454dccc79 breaks binding mode hooks in use-package References: <87mskpo5qc.fsf@stebalien.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72993 Cc: 72993@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 02 Sep 2024 19:01:31 -0700 > From: Steven Allen via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > > > In GNU Emacs 31.0.50 (build 1, x86_64-pc-linux-gnu, cairo version > 1.18.0) of 2024-09-01 built on Laptop > Repository revision: 92ea393a16e5c99a8860dab368c6ca3ca6abc3c5 > Repository branch: master > Windowing system distributor 'The X.Org Foundation', version 11.0.12101013 > System Description: Arch Linux > > To reproduce: > > (use-package foo > :hook (eshell-mode . some-function)) > > Previously, `use-package' always appended `-hook' to the hook variable name. > After 4f521fa14c18f57e5207bffd68e9f79454dccc79, `use-package' only does > so if the passed variable name isn't bound. Unfortunately, this breaks > binding mode hooks, e.g.: > > :hook (some-mode . some-function) > > Because `some-mode' is usually bound. John, any comments or suggestions? From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 03 00:39:09 2024 Received: (at 72993) by debbugs.gnu.org; 3 Sep 2024 04:39:09 +0000 Received: from localhost ([127.0.0.1]:56231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slLJt-00040u-BI for submit@debbugs.gnu.org; Tue, 03 Sep 2024 00:39:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51290) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slLJq-00040S-TL for 72993@debbugs.gnu.org; Tue, 03 Sep 2024 00:39:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1slLIl-0001mx-PO; Tue, 03 Sep 2024 00:37:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=8uUYusxcofstZWgqF5xK7P3ckQuuIZf7eHyxzYU+rEQ=; b=EEP9J62tNUzoT/or80Zn uZus9nxuSAgfGop0Ov39bUZ7jxyvUkYIdPqHhRweCcij7ujhgNkM+OFXM/ZqRN1MY4xnfZjXKdgXS tcdiJWicQr04iM0Zyz4Fs/0CrJ2epHrBJcDrHT4oLv1Mi0Tw9618T1nek++kcWJoJM9azoKPP86eB xMjslncXGX2pa1vdVughfWkBe/OacaukVFN3ce9NwmOi6u4Qz/Rc0CXI7qM+X7RPGvJSajBTMt3K8 R54IXn9axiqKxTgI31xE5Z+MeWr9W8DnETWMeKfl1BvOcRMvXXEwLGtGZ2q5GnOo40B6bo0jB+uRJ bLQZlMRwgTioUw==; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudehgedgkeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefujghffffkfgggtgfgsehtqhertddtreej necuhfhrohhmpeflohhhnhcuhghivghglhgvhicuoehjohhhnhifsehgnhhurdhorhhgqe enucggtffrrghtthgvrhhnpeeiffdthedviedvtdfffeffffevkeeludejieeltddufeeh fefhhfefgeejteefgeenucffohhmrghinhepnhgvfigrrhhtihhsrghnshdrtghomhenuc evlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjohhhnhif odhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdeikeejkedtleeggedqudejje ehfeekudeiqdhjohhhnhifpeepghhnuhdrohhrghesnhgvfigrrhhtihhsrghnshdrtgho mhdpnhgspghrtghpthhtohepfedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepje dvleelfeesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopehsthgvvhgvnhes shhtvggsrghlihgvnhdrtghomhdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrgh X-ME-Proxy: Feedback-ID: ib64945b7:Fastmail From: John Wiegley To: Eli Zaretskii Subject: Re: bug#72993: 31.0.50; 4f521fa14c18f57e5207bffd68e9f79454dccc79 breaks binding mode hooks in use-package In-Reply-To: <86v7zd79ds.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 03 Sep 2024 05:34:39 +0300") References: <87mskpo5qc.fsf@stebalien.com> <86v7zd79ds.fsf@gnu.org> Date: Mon, 02 Sep 2024 21:37:54 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72993 Cc: 72993@debbugs.gnu.org, Steven Allen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >>>>> Eli Zaretskii writes: >> To reproduce: >>=20 >> (use-package foo >> :hook (eshell-mode . some-function)) >>=20 >> Previously, `use-package' always appended `-hook' to the hook variable n= ame. >> After 4f521fa14c18f57e5207bffd68e9f79454dccc79, `use-package' only does >> so if the passed variable name isn't bound. Unfortunately, this breaks >> binding mode hooks, e.g.: >>=20 >> :hook (some-mode . some-function) >>=20 >> Because `some-mode' is usually bound. > John, any comments or suggestions? Sigh, I should have thought of this. There will be many such collisions, in fact. Perhaps we should avoid auto -hook=E2=80=99ifying the variable name only if= the name does not already end in =E2=80=98-functions=E2=80=99? What do you think, Eli? --=20 John Wiegley GPG fingerprint =3D 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 03 08:39:41 2024 Received: (at 72993) by debbugs.gnu.org; 3 Sep 2024 12:39:41 +0000 Received: from localhost ([127.0.0.1]:59378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slSov-0002Tn-6J for submit@debbugs.gnu.org; Tue, 03 Sep 2024 08:39:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slSos-0002TV-S2 for 72993@debbugs.gnu.org; Tue, 03 Sep 2024 08:39:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1slSnn-0006wD-2Y; Tue, 03 Sep 2024 08:38:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=/aWphhVhmzoVqMMexzbuZAvpU95YFDyBwK1Z7na8pVY=; b=D18g1m0i6lOCTxW12off QuoCO2ngDNJRs0W2RBMMQN/tm3ArIf6ne9PMkGjQxokUwj9ecI4SmcKTzJRYhtiBPBhed3dTS8MkD 2gixqRwGi5YWv2JR6LtI7MFt+vLOUHOK2xkF3l78KquPpSgj5DXGnK9TdybqvalyLiaSZHfNUV+Nt m0RTKX8Gx9OmQgI+yAcW2/lOzIHVx/Dh5ku1FzGChxZqbY8eH+wEBHSXvyKDp7s/0xDs5Un053taa IAyLWZ0NDaekbASenOhhnrYsr+zpMJSoN7wkJvAFww/8bnoa/3mBEnUJuCfIxAcPzej7Cg/V8i6bx jPNYH5K0v+QpBQ==; Date: Tue, 03 Sep 2024 15:38:26 +0300 Message-Id: <86msko7vzx.fsf@gnu.org> From: Eli Zaretskii To: John Wiegley In-Reply-To: (message from John Wiegley on Mon, 02 Sep 2024 21:37:54 -0700) Subject: Re: bug#72993: 31.0.50; 4f521fa14c18f57e5207bffd68e9f79454dccc79 breaks binding mode hooks in use-package References: <87mskpo5qc.fsf@stebalien.com> <86v7zd79ds.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72993 Cc: 72993@debbugs.gnu.org, steven@stebalien.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: John Wiegley > Cc: Steven Allen , 72993@debbugs.gnu.org > Date: Mon, 02 Sep 2024 21:37:54 -0700 > > >>>>> Eli Zaretskii writes: > > >> To reproduce: > >> > >> (use-package foo > >> :hook (eshell-mode . some-function)) > >> > >> Previously, `use-package' always appended `-hook' to the hook variable name. > >> After 4f521fa14c18f57e5207bffd68e9f79454dccc79, `use-package' only does > >> so if the passed variable name isn't bound. Unfortunately, this breaks > >> binding mode hooks, e.g.: > >> > >> :hook (some-mode . some-function) > >> > >> Because `some-mode' is usually bound. > > > John, any comments or suggestions? > > Sigh, I should have thought of this. There will be many such collisions, in > fact. > > Perhaps we should avoid auto -hook’ifying the variable name only if the name > does not already end in ‘-functions’? Either that, or maybe exempt FOO-mode from the boundp test. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 03 18:39:14 2024 Received: (at 72993) by debbugs.gnu.org; 3 Sep 2024 22:39:14 +0000 Received: from localhost ([127.0.0.1]:32975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slcB8-0002I2-3B for submit@debbugs.gnu.org; Tue, 03 Sep 2024 18:39:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slcB6-0002Hq-6p for 72993@debbugs.gnu.org; Tue, 03 Sep 2024 18:39:13 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1slc7s-0003zE-Mg; Tue, 03 Sep 2024 18:35:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=yL0f5qLZ8ZayWphbOFEWvA2cwc4bzffpYj2nUNNJHwY=; b=fvcKXKe1WuFi8GgCCPJL xmcOlvr1vnzAqRO9uDL95An3DjboJaVcbG2KKMIv6/pDLhSzxqTJRoq049o7FztDfJmOE21BIvDID AaKWtZDjihr4QtrqNbh6B97hzKMOIhkGA65qh4xOB1dWdWVPNy2Xjbrf9CVtJnjy+hCqWN6Jw5n/C pMRLIGIhukhoheTsuCL01OYumNlSAagt0cBw6NMqFZpnnURACnK0HOsLhG3XhTdjgrO0o9T/VU1zO skz3rUH5I8eMAi+FoGroJs/lOEFaznOYADO7rYNsGOx5KL7UpU0AELIlZcwn05PReWxwGz9Uctgeb wFUZL2cE9MMA1w==; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudehiedgudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefujghffffkfgggtgfgsehtqhertddtreej necuhfhrohhmpeflohhhnhcuhghivghglhgvhicuoehjohhhnhifsehgnhhurdhorhhgqe enucggtffrrghtthgvrhhnpeeiffdthedviedvtdfffeffffevkeeludejieeltddufeeh fefhhfefgeejteefgeenucffohhmrghinhepnhgvfigrrhhtihhsrghnshdrtghomhenuc evlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjohhhnhif odhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdeikeejkedtleeggedqudejje ehfeekudeiqdhjohhhnhifpeepghhnuhdrohhrghesnhgvfigrrhhtihhsrghnshdrtgho mhdpnhgspghrtghpthhtohepfedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepje dvleelfeesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopehsthgvvhgvnhes shhtvggsrghlihgvnhdrtghomhdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrgh X-ME-Proxy: Feedback-ID: ib64945b7:Fastmail From: John Wiegley To: Eli Zaretskii Subject: Re: bug#72993: 31.0.50; 4f521fa14c18f57e5207bffd68e9f79454dccc79 breaks binding mode hooks in use-package In-Reply-To: <86msko7vzx.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 03 Sep 2024 15:38:26 +0300") References: <87mskpo5qc.fsf@stebalien.com> <86v7zd79ds.fsf@gnu.org> <86msko7vzx.fsf@gnu.org> Date: Tue, 03 Sep 2024 15:35:48 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >>>>> Eli Zaretskii writes: >> Perhaps we should avoid auto -hook’ifying the variable name only if the name >> does not already end in ‘-functions’? > Either that, or maybe exempt FOO-mode from the boundp test. Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.92 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [209.51.188.92 listed in zen.spamhaus.org] X-Debbugs-Envelope-To: 72993 Cc: 72993@debbugs.gnu.org, steven@stebalien.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >>>>> Eli Zaretskii writes: >> Perhaps we should avoid auto -hook=E2=80=99ifying the variable name only= if the name >> does not already end in =E2=80=98-functions=E2=80=99? > Either that, or maybe exempt FOO-mode from the boundp test. This sounds likely to be even better. --=20 John Wiegley GPG fingerprint =3D 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 04 07:32:43 2024 Received: (at 72993) by debbugs.gnu.org; 4 Sep 2024 11:32:43 +0000 Received: from localhost ([127.0.0.1]:33701 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sloFe-0006WZ-QV for submit@debbugs.gnu.org; Wed, 04 Sep 2024 07:32:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sloFc-0006WE-2x for 72993@debbugs.gnu.org; Wed, 04 Sep 2024 07:32:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sloEU-00089A-Sb; Wed, 04 Sep 2024 07:31:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=nDvs4ocXzdQo/b6KnA5TgtkqUGcymZH+gTNZ09Jb8jw=; b=izXMM4EwzZ5K7KhNAZIr tXgukKvndaFQ8QAMbN2hEs3fZ3l0+mISwb1d/Cwe3kMhLxLoCoAwQ2ZfVPmOHlg8kzVHCk82DiV9L +jj8J4Nr2FB7boX1VnPQ1lkotInx03eVwuz15lYcP2+h1YPrvN8FHvWf4Xy196VPLTNUQCbM90xfY pAkzkP65Y4lfJewIWkt7enYJ7KY6rogiXdXs15GVyzEaCZEbRiZvZI7d+k6ULJ9Fcev9A68LntiUj 4FVKpS3J3awGFFCSL7iPtrX3THEAnQneCKeF82+koCEE+nEsoicVYs3ty1Bn+6a+o0J5xmouzK86o Kdp3Q1UgZVAoKQ==; Date: Wed, 04 Sep 2024 14:31:27 +0300 Message-Id: <86v7zb64fk.fsf@gnu.org> From: Eli Zaretskii To: John Wiegley In-Reply-To: (message from John Wiegley on Tue, 03 Sep 2024 15:35:48 -0700) Subject: Re: bug#72993: 31.0.50; 4f521fa14c18f57e5207bffd68e9f79454dccc79 breaks binding mode hooks in use-package References: <87mskpo5qc.fsf@stebalien.com> <86v7zd79ds.fsf@gnu.org> <86msko7vzx.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > From: John Wiegley > Cc: steven@stebalien.com, 72993@debbugs.gnu.org > Date: Tue, 03 Sep 2024 15:35:48 -0700 > > >>>>> Eli Zaretskii writes: > > >> Perhaps we should a [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.92 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [209.51.188.92 listed in zen.spamhaus.org] X-Debbugs-Envelope-To: 72993 Cc: 72993@debbugs.gnu.org, steven@stebalien.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > From: John Wiegley > Cc: steven@stebalien.com, 72993@debbugs.gnu.org > Date: Tue, 03 Sep 2024 15:35:48 -0700 > > >>>>> Eli Zaretskii writes: > > >> Perhaps we should avoid auto -hook’ifying the variable name only if the name > >> does not already end in ‘-functions’? > > > Either that, or maybe exempt FOO-mode from the boundp test. > > This sounds likely to be even better. Like the below? diff --git a/lisp/use-package/use-package-core.el b/lisp/use-package/use-package-core.el index 2c5fc56..6c3d350 100644 --- a/lisp/use-package/use-package-core.el +++ b/lisp/use-package/use-package-core.el @@ -1376,13 +1376,16 @@ use-package-handler/:hook (when fun (mapcar #'(lambda (sym) - (if (boundp sym) - `(add-hook (quote ,sym) (function ,fun)) - `(add-hook - (quote ,(intern - (concat (symbol-name sym) - use-package-hook-name-suffix))) - (function ,fun)))) + (let ((symname (symbol-name sym))) + (if (and (boundp sym) + ;; Mode variables are usually bound, but + ;; their hooks are named FOO-mode-hook. + (not (string-suffix-p "-mode" symname))) + `(add-hook (quote ,sym) (function ,fun)) + `(add-hook + (quote ,(intern + (concat symname use-package-hook-name-suffix))) + (function ,fun))))) (use-package-hook-handler-normalize-mode-symbols syms))))) (use-package-normalize-commands args)))) From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 04 13:31:53 2024 Received: (at 72993) by debbugs.gnu.org; 4 Sep 2024 17:31:53 +0000 Received: from localhost ([127.0.0.1]:35319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sltrF-00009B-HB for submit@debbugs.gnu.org; Wed, 04 Sep 2024 13:31:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sltrC-00008m-KN for 72993@debbugs.gnu.org; Wed, 04 Sep 2024 13:31:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sltq5-0001kS-6f; Wed, 04 Sep 2024 13:30:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=IEp0J2JMiu0BZHHDpP6kniwwLXnuXiIiqeeMm/SyGdw=; b=kU5w32Lw/8LSy2mGKyHJ bF5/xZNNxcLbGBhb/XmXegCpT8V9kNErwfEKlf7cYKr27fsQA6pYCO/7T1wPbsQ6JPuaG7Hulfy3e hVLim9FJZtEaAlkBXERU86nA+UiCf7Hp93DvNLMetrVMi7spUDd4tdRxAPYY5BpdElxBiVWLdNXVB PLyCBjCu1EFBirRGINbFusoq+s91gGpdVSABeU2bOZcnX978g5dpzWZncffFruH71I7XL7PI7mSP0 YxrO/7q0JLhFDL64C8BGAp3CXTqkLXY2WShGM8wWhSC2uqSy2LsAPNqxvnBkB/9bPDsdcRZ7tf0gO Sjbz03l/+V1W6A==; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudehjedgudduvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhffkfgfgggtsehttdertddtredt necuhfhrohhmpeflohhhnhcuhghivghglhgvhicuoehjohhhnhifsehgnhhurdhorhhgqe enucggtffrrghtthgvrhhnpeefhfdvvdetteeufeejtddvgfevuedvhfehhedtvedufeeu veejlefgudetleefkeenucffohhmrghinhepnhgvfigrrhhtihhsrghnshdrtghomhenuc evlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjohhhnhif odhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdeikeejkedtleeggedqudejje ehfeekudeiqdhjohhhnhifpeepghhnuhdrohhrghesnhgvfigrrhhtihhsrghnshdrtgho mhdpnhgspghrtghpthhtohepfedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepje dvleelfeesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopehsthgvvhgvnhes shhtvggsrghlihgvnhdrtghomhdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrgh X-ME-Proxy: Feedback-ID: ib64945b7:Fastmail From: John Wiegley To: Eli Zaretskii Subject: Re: bug#72993: 31.0.50; 4f521fa14c18f57e5207bffd68e9f79454dccc79 breaks binding mode hooks in use-package In-Reply-To: <86v7zb64fk.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 04 Sep 2024 14:31:27 +0300") References: <87mskpo5qc.fsf@stebalien.com> <86v7zd79ds.fsf@gnu.org> <86msko7vzx.fsf@gnu.org> <86v7zb64fk.fsf@gnu.org> Date: Wed, 04 Sep 2024 10:30:21 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72993 Cc: 72993@debbugs.gnu.org, steven@stebalien.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >>>>> Eli Zaretskii writes: > Like the below? Yes, looks good! Thank you, Eli. -- John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 04 13:45:51 2024 Received: (at 72993-done) by debbugs.gnu.org; 4 Sep 2024 17:45:51 +0000 Received: from localhost ([127.0.0.1]:35339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slu4l-0000WU-2H for submit@debbugs.gnu.org; Wed, 04 Sep 2024 13:45:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slu4i-0000WD-UL for 72993-done@debbugs.gnu.org; Wed, 04 Sep 2024 13:45:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1slu3b-0000CL-Ap; Wed, 04 Sep 2024 13:44:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=d655iBCANGlGkHi972fy8u2ZcYF8EY8MIbfV3crvhrg=; b=SV2V8BenTcZq PxC/KbgwZhElb0+LKRFfGbN7kYrZUvXPy6qU6WRabmdvCjJyjmTfrexCSBlwPsVuelj3o9bKYa5a9 jv+KWwRon1sG3qrtKpff5Lh3KCiXS/vDHU/4eRZOGsQndj8sNtR55fxnq4eEsBqCtGynVormQTR99 q+CvsNn/dTc+Qh3/YhoxuxSTxBbdRcuG2KhHYqG2PRKx0qlMqkOU3s6PnVkgA05nwsDgNh9GClYpj jywDTjK6BbpkZUAN8/GOhA6kmppT7uCp51KV6wYx8S5PI7TiE4VoEfh6LrgqywpnqgznRZ1ve99ka l4nS3ugZdg5qS/WiSkabxQ==; Date: Wed, 04 Sep 2024 20:44:26 +0300 Message-Id: <8634mf5n5x.fsf@gnu.org> From: Eli Zaretskii To: John Wiegley In-Reply-To: (message from John Wiegley on Wed, 04 Sep 2024 10:30:21 -0700) Subject: Re: bug#72993: 31.0.50; 4f521fa14c18f57e5207bffd68e9f79454dccc79 breaks binding mode hooks in use-package References: <87mskpo5qc.fsf@stebalien.com> <86v7zd79ds.fsf@gnu.org> <86msko7vzx.fsf@gnu.org> <86v7zb64fk.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72993-done Cc: steven@stebalien.com, 72993-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: John Wiegley > Cc: steven@stebalien.com, 72993@debbugs.gnu.org > Date: Wed, 04 Sep 2024 10:30:21 -0700 > > >>>>> Eli Zaretskii writes: > > > Like the below? > > Yes, looks good! Thank you, Eli. Thanks, installed on the emacs-30 branch, and closing the bug. From unknown Thu Jun 19 14:03:15 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 03 Oct 2024 11:24:16 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator