GNU bug report logs - #72992
29.4; towards xoauth2 support in Emacs

Previous Next

Full log

Message #71 received at 72992 <at> debbugs.gnu.org (full text, mbox):

From: Xiyue Deng <manphiz <at> gmail.com>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: 72992 <at> debbugs.gnu.org
Subject: Re: bug#72992: 29.4; towards xoauth2 support in Emacs
Date: Sun, 22 Sep 2024 23:39:59 -0700

Philip Kaludercic <philipk <at> posteo.net> writes:

> Xiyue Deng <manphiz <at> gmail.com> writes:
>
>
> [...]
>
>>> diff --git a/auth-source-xoauth2-plugin.el b/auth-source-xoauth2-plugin.el
>>> index cdcc9e7..caf5baf 100644
>>> --- a/auth-source-xoauth2-plugin.el
>>> +++ b/auth-source-xoauth2-plugin.el
>>> @@ -41,7 +41,7 @@
>>>  ;; or with use-package:
>>>  
>>>  ;;     (use-package auth-source-xoauth2-plugin
>>> -;;       :config
>>> +;;       :custom
>>>  ;;       (auth-source-xoauth2-plugin-mode t))
>>>
>>
>> Quick question: I wonder whether customizing the minor mode variable is
>> preferred over toggling through the minor mode function?  (I assume both
>> will run the minor mode body.)
>
> You are right, it doesn't matter.  I changed this when adding the
> autoload cookie, and somehow I had convinced myself that this would only
> work as a user option, which of course is not the case.

Thanks for confirming!  I have incorporated your suggestions and pushed
to my repo.  Thanks again for your review!

>
> [...]
>
>
> -- 
> 	Philip Kaludercic on siskin

-- 
Xiyue Deng

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.