Subject: Re: [bug#72987] [PATCH v3 2/5] gnu: bootloader: Add nanopi-r4s-rk3399 bootloader.

From: Vagrant Cascadian <[email-masked]>
Date: Tue, 04 Mar 2025 14:48:56 -0800

On 2024-12-13, Herman Rimm wrote:
> * gnu/bootloader/u-boot.scm (u-boot-nanopi-r4s-rk3399-bootloader): Add.
> * gnu/packages/bootloaders.scm (u-boot-nanopi-r4s-rk3399): Add variable.
>
> Change-Id: I6d4cb098727fe4027aea33a39c59d34000dfc4db

I was tempted to just push this patch, but depending on weather we want
one or two variants, am waiting till we have more clarity on that.

live well,
  vagrant

> ---
>  gnu/bootloader/u-boot.scm    | 6 ++++++
>  gnu/packages/bootloaders.scm | 3 +++
>  2 files changed, 9 insertions(+)
>
> diff --git a/gnu/bootloader/u-boot.scm b/gnu/bootloader/u-boot.scm
> index 5d5fc1bff2..9c7df3b40f 100644
> --- a/gnu/bootloader/u-boot.scm
> +++ b/gnu/bootloader/u-boot.scm
> @@ -38,6 +38,7 @@ (define-module (gnu bootloader u-boot)
>              u-boot-cubietruck-bootloader
>              u-boot-firefly-rk3399-bootloader
>              u-boot-mx6cuboxi-bootloader
> +            u-boot-nanopi-r4s-rk3399-bootloader
>              u-boot-nintendo-nes-classic-edition-bootloader
>              u-boot-novena-bootloader
>              u-boot-orangepi-r1-plus-lts-rk3328-bootloader
> @@ -220,6 +221,11 @@ (define u-boot-novena-bootloader
>     (inherit u-boot-imx-bootloader)
>     (package u-boot-novena)))
>  
> +(define u-boot-nanopi-r4s-rk3399-bootloader
> +  (bootloader
> +   (inherit u-boot-rockchip-bootloader)
> +   (package u-boot-nanopi-r4s-rk3399)))
> +
>  (define u-boot-orangepi-r1-plus-lts-rk3328-bootloader
>    (bootloader
>     (inherit u-boot-rockchip-bootloader)
> diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm
> index 478385fb18..1a464655b6 100644
> --- a/gnu/packages/bootloaders.scm
> +++ b/gnu/packages/bootloaders.scm
> @@ -1274,6 +1274,9 @@ (define-public u-boot-novena
>  version, contrary to Novena upstream, does not load u-boot.img from the first
>  partition."))
>  
> +(define-public u-boot-nanopi-r4s-rk3399
> +  (make-u-boot-rockchip-package "nanopi-r4s" 'rk3399))
> +
>  (define-public u-boot-orangepi-r1-plus-lts-rk3328
>    (make-u-boot-rockchip-package "orangepi-r1-plus-lts" 'rk3328))
>  
> -- 
> 2.45.2