GNU bug report logs - #72986
Disabling menu-bar-mode changes size of new frames

Previous Next

Package: emacs;

Reported by: Reuben Thomas <rrt <at> sc3d.org>

Date: Mon, 2 Sep 2024 18:52:01 UTC

Severity: normal

Full log


Message #152 received at 72986 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Reuben Thomas <rrt <at> sc3d.org>
Cc: Po Lu <luangruo <at> yahoo.com>, Eli Zaretskii <eliz <at> gnu.org>,
 72986 <at> debbugs.gnu.org
Subject: Re: bug#72986: Disabling menu-bar-mode changes size of new frames
Date: Wed, 2 Oct 2024 10:53:25 +0200
[Message part 1 (text/plain, inline)]
> First frame with menu bar:

Whatever it is, I can't figure out what's going on.  It's basically the
same issue that's harassing me all the time.  In a frame with menu bar
we request an initial frame of size 644x696 here:

> xg_frame_set_char_size, visible, PS=1328x1260, XS=1328x1260, DS=1328x1260
>   +values, PS=200x195, XS=664x696

The 696 come from (/ (+ 1260 50 82) 2) where the 1260 is the native
pixel height of the frame calculated as (* 36 35) where 36 is our number
of lines and 35 is your frame character height.  50 is the height of the
menu bar, 92 the height of the tool bar and 2 is the scaling factor.  I
cannot spot any rounding problem here.

> ConfigureNotify, PS=1328x1260, XS=1328x1258, DS=1328x1260
> xg_frame_resized, rejected, PS=1328x1260, XS=1328x1258, DS=664x696

Now we get a ConfigureNotify event that instead of giving us a native
pixel height of 1260 gives us a height of 1258 and we reject it.  Where
did those two pixels go to?  I suppose I'll never find out.

The next two things I'd ask you to do are:

- Apply the patch gtkutil-reject-2024-10-02.diff which adds a tolerance
  of two pixels in order to avoid rejecting the ConfigureNotify and post
  the four histories as before.

- Apply the patch gtkutil-reject-2024-10-02(25).diff (from a pristine
  Emacs).  This is like the previous patch but makes the initial frame
  only 25 lines high.  Again please post the histories for all four
  cases.

Thanks, martin
[gtkutil-reject-2024-10-02.diff (text/x-patch, attachment)]
[gtkutil-reject-2024-10-02(25).diff (text/x-patch, attachment)]

This bug report was last modified 182 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.