From unknown Sun Aug 17 04:15:00 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#72968 <72968@debbugs.gnu.org> To: bug#72968 <72968@debbugs.gnu.org> Subject: Status: [PATCH] gnu: php: Fix build. Reply-To: bug#72968 <72968@debbugs.gnu.org> Date: Sun, 17 Aug 2025 11:15:00 +0000 retitle 72968 [PATCH] gnu: php: Fix build. reassign 72968 guix submitter 72968 No=C3=A9 Lopez severity 72968 normal tag 72968 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 02 10:42:39 2024 Received: (at submit) by debbugs.gnu.org; 2 Sep 2024 14:42:39 +0000 Received: from localhost ([127.0.0.1]:49901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sl8GN-0008El-BT for submit@debbugs.gnu.org; Mon, 02 Sep 2024 10:42:39 -0400 Received: from lists.gnu.org ([209.51.188.17]:42512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sl8GK-0008Ea-N1 for submit@debbugs.gnu.org; Mon, 02 Sep 2024 10:42:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sl8FL-0004Ge-Fr for bug-guix@gnu.org; Mon, 02 Sep 2024 10:41:35 -0400 Received: from smtp.domeneshop.no ([2a01:5b40:0:3006::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sl8FJ-0006oD-Hj for bug-guix@gnu.org; Mon, 02 Sep 2024 10:41:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xn--no-cja.eu; s=ds202402; h=Content-Type:MIME-Version:Message-ID:Date: Subject:To:From:From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=pVVn8ZvZnrsDE0a/4dDt7+8HRmEf/PIp4fwlGlDDmOw=; b=Amh4+hdvDvCTfS2GJE0WrnrWNo CHv4YOYgY0YtUbr0tJbQxAePdfy0GvQfCix906KGR5yyNMcoVgXc/FdxWzREYCYqGGlOUHNkeVWuZ YLyA6Q4RSjO1somTjNIKmu1Od2LiWatmrwwGovJC115HajQNrRRX2VC+ie962kLobR/M3S6zDuOGx skTTAMvr+B0sL7YUqGvYVAf3iEPZHyl2rhio0L7uq5mOi2OGlG60ad9Ii5vA67dJP3pqhyuTOng32 qSpuGsZoSf5+NX+MJ+s1XMLLAJ93ul0c0Wp/uBW8k8HyeF1eJq8Ebav9Iizc9uozU35WlGvCOYvmp AkBp1pNA==; Received: from [163.5.23.109] (port=25427 helo=lignux) by smtp.domeneshop.no with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sl8FB-005w8o-Mz for bug-guix@gnu.org; Mon, 02 Sep 2024 16:41:25 +0200 From: =?utf-8?Q?No=C3=A9_Lopez?= To: bug-guix@gnu.org Subject: [PATCH] gnu: php: Fix build. Date: Mon, 02 Sep 2024 16:42:05 +0200 Message-ID: <87a5gq2k3m.fsf@xn--no-cja.eu> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a01:5b40:0:3006::1; envelope-from=noe@xn--no-cja.eu; helo=smtp.domeneshop.no X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Here is a patch to fix the PHP build. Have a good day, No=C3=A9 Lopez --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-php-Fix-build.patch >From 225bbd80ed6d67f4c9157ad31a344bae42ffb998 Mon Sep 17 00:00:00 2001 Message-ID: <225bbd80ed6d67f4c9157ad31a344bae42ffb998.1725287764.git.noelopez@free.fr> From: =?UTF-8?q?No=C3=A9=20Lopez?= Date: Mon, 2 Sep 2024 15:54:29 +0200 Subject: [PATCH] gnu: php: Fix build. * gnu/packages/php.scm (php): Add missing dependencies and disable failing tests. Change-Id: I3ddc47e5ad121a8177e3a12c5dfe154a8d6029b6 --- gnu/packages/php.scm | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/gnu/packages/php.scm b/gnu/packages/php.scm index 8f879dbdca..2f031ecd3d 100644 --- a/gnu/packages/php.scm +++ b/gnu/packages/php.scm @@ -252,6 +252,10 @@ (define-public php "ext/gd/tests/bug72339.phpt" ;; AVIF support disabled "ext/gd/tests/imagecreatefromstring_avif.phpt" + ;; No idea why + "ext/gd/tests/bug79676.phpt" + "ext/gd/tests/imageinterpolation_basic.phpt" + "ext/gd/tests/imagescale_preserve_ratio.phpt" ;; XXX: These test failures appear legitimate, needs investigation. ;; open_basedir() restriction failure. @@ -306,6 +310,10 @@ (define-public php ("bzip2" ,bzip2) ("curl" ,curl) ("cyrus-sasl" ,cyrus-sasl) + ("freetype" ,freetype) + ("fontconfig" ,fontconfig) + ("libjpeg-turbo" ,libjpeg-turbo) + ("libpng" ,libpng) ("gd" ,gd) ("gdbm" ,gdbm) ("gmp" ,gmp) base-commit: e1c92c98f7afff13fb7060199ba0dd4d9c5c2c53 -- 2.45.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 02 17:55:35 2024 Received: (at 72968) by debbugs.gnu.org; 2 Sep 2024 21:55:36 +0000 Received: from localhost ([127.0.0.1]:52802 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slF1K-0007oy-4A for submit@debbugs.gnu.org; Mon, 02 Sep 2024 17:55:35 -0400 Received: from mail-40134.protonmail.ch ([185.70.40.134]:11025) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slALL-0005OA-Ba for 72968@debbugs.gnu.org; Mon, 02 Sep 2024 12:55:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1725296087; x=1725555287; bh=+9uToFRTy+zc/BrRE+6sZOqiCLcwG+g38aFoqupuc6s=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=W0ZIsUiMEYjUodW27oR5Zb/0kOiitabAuImCb2uhxzoX2J3CH1oWugrNWdEMjwJoS S6+8rtaHxWnqmT1WUhNSYQijwx74uiWBe0thbf5DhtRuxPcjtKaT3lab39mZIoAuNH hZr4Yp8gj9LvVnRBh4h/BQ2oLBeKGhG/O5Fg7dzh0RUUQ/4PGC1FBHCu83MZ7xQuvU S0ucjqkQkDXZ0tErw7g7ba/JRVh4do662L1MArSuHkO4beMnEpArYxfljsd6744u2o QedS4xMgi+iYfHgtS2N5Yg2kQgfImm7RX9aSsN+2WmEdyJsJ408nXu3mzbZLraSBTz 4KjN+fJKF06Lw== Date: Mon, 02 Sep 2024 16:54:42 +0000 To: 72968@debbugs.gnu.org From: Rutherther Subject: Re: [PATCH] gnu: php: Fix build. Message-ID: <87seui2dys.fsf@protonmail.com> Feedback-ID: 8107604:user:proton X-Pm-Message-ID: 3b582a2e75824336c528a1c7ed0386ea84534260 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72968 X-Mailman-Approved-At: Mon, 02 Sep 2024 17:55:32 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello No=C3=A9, thanks for your patch. Unfortunately, I don't think this is the way to go. The issue here is that gd package has these in Requires.private in the pkg-config file. That means every package that wants libgd also has to get these inputs. Not only php. So gd has to be fixed here. See issue #72943 where I sent a patch to make gd propagated inputs and Carlo Zancanaro proposed returning code that was mistakenly removed as part of core-updates. The other part are the tests, where I think we should look into why they are failing, and figure out if there is any issue in Guix or not rather than removing them without investigating the cause. Regards, Ruther From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 05 16:43:13 2024 Received: (at 72968-done) by debbugs.gnu.org; 5 Sep 2024 20:43:13 +0000 Received: from localhost ([127.0.0.1]:38326 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smJJx-0000Hu-0q for submit@debbugs.gnu.org; Thu, 05 Sep 2024 16:43:13 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:34952) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smJJu-0000HV-Ba; Thu, 05 Sep 2024 16:43:10 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 7CB1F125D; Thu, 5 Sep 2024 22:41:58 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zDcUd8auvfuP; Thu, 5 Sep 2024 22:41:58 +0200 (CEST) Received: from jurong (unknown [IPv6:2001:861:c4:f2f0::c64]) by hera.aquilenet.fr (Postfix) with ESMTPSA id C8F5DA3B; Thu, 5 Sep 2024 22:41:57 +0200 (CEST) Date: Thu, 5 Sep 2024 22:41:56 +0200 From: Andreas Enge To: 72968-done@debbugs.gnu.org, 72943@debbugs.gnu.org Subject: Patches applied Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 72968-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, I have applied Carlos's second patch of https://issues.guix.gnu.org/72943 which gives an explanation why we skip the tests, and Noé's patch of https://issues.guix.gnu.org/72968 adding the missing inputs. As php currently does not build after the core-updates merge and this issue has been turning up regularly over the past few days, I have taken the liberty to push the commits directly without going through QA; I have tested that the package builds and works with one of my local php projects. I am closing the second issue, which is thus handled. And I am leaving the first issue open; while the immediate php problem is (hopefully) solved, it remains to be discussed whether we should propagate the gd inputs in the longer term. My understanding is that given the pkg-config file, we normally would propagate the inputs. On the other hand, propagated inputs tend to create problems (for instance, when two different packages propagate two different versions of the same input library); and I do not quite understand why with over 5000 packages depending on gd, most of them do not seem to be affected. Maybe these do not use pkg-config to check for gd? So it may be a better option to only patch the affected packages (if any are left) and leave gd as it is. Andreas From unknown Sun Aug 17 04:15:00 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 04 Oct 2024 11:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator