GNU bug report logs - #72968
[PATCH] gnu: php: Fix build.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72968 in the body.
You can then email your comments to 72968 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Noé Lopez <noe <at> xn--no-cja.eu>
To: bug-guix <at> gnu.org
Subject: [PATCH] gnu: php: Fix build.
Date: Mon, 02 Sep 2024 16:42:05 +0200

[Message part 1 (text/plain, inline)]

Hi,

Here is a patch to fix the PHP build.

Have a good day,
Noé Lopez

[0001-gnu-php-Fix-build.patch (text/x-patch, inline)]

From 225bbd80ed6d67f4c9157ad31a344bae42ffb998 Mon Sep 17 00:00:00 2001
Message-ID: <225bbd80ed6d67f4c9157ad31a344bae42ffb998.1725287764.git.noelopez <at> free.fr>
From: =?UTF-8?q?No=C3=A9=20Lopez?= <noelopez <at> free.fr>
Date: Mon, 2 Sep 2024 15:54:29 +0200
Subject: [PATCH] gnu: php: Fix build.

* gnu/packages/php.scm (php): Add missing dependencies and
disable failing tests.

Change-Id: I3ddc47e5ad121a8177e3a12c5dfe154a8d6029b6
---
 gnu/packages/php.scm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/gnu/packages/php.scm b/gnu/packages/php.scm
index 8f879dbdca..2f031ecd3d 100644
--- a/gnu/packages/php.scm
+++ b/gnu/packages/php.scm
@@ -252,6 +252,10 @@ (define-public php
                          "ext/gd/tests/bug72339.phpt"
                          ;; AVIF support disabled
                          "ext/gd/tests/imagecreatefromstring_avif.phpt"
+                         ;; No idea why
+                         "ext/gd/tests/bug79676.phpt"
+                         "ext/gd/tests/imageinterpolation_basic.phpt"
+                         "ext/gd/tests/imagescale_preserve_ratio.phpt"
 
                          ;; XXX: These test failures appear legitimate, needs investigation.
                          ;; open_basedir() restriction failure.
@@ -306,6 +310,10 @@ (define-public php
        ("bzip2" ,bzip2)
        ("curl" ,curl)
        ("cyrus-sasl" ,cyrus-sasl)
+       ("freetype" ,freetype)
+       ("fontconfig" ,fontconfig)
+       ("libjpeg-turbo" ,libjpeg-turbo)
+       ("libpng" ,libpng)
        ("gd" ,gd)
        ("gdbm" ,gdbm)
        ("gmp" ,gmp)

base-commit: e1c92c98f7afff13fb7060199ba0dd4d9c5c2c53
-- 
2.45.2

Message #8 received at 72968 <at> debbugs.gnu.org (full text, mbox):

From: Rutherther <rutherther <at> protonmail.com>
To: 72968 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: php: Fix build.
Date: Mon, 02 Sep 2024 16:54:42 +0000

Hello Noé,

thanks for your patch. Unfortunately, I don't think this is the
way to go. The issue here is that gd package has these in Requires.private
in the pkg-config file. That means every package that wants libgd
also has to get these inputs. Not only php. So gd has to be fixed here.
See issue #72943 where I sent a patch to make gd propagated inputs
and Carlo Zancanaro proposed returning code that was mistakenly
removed as part of core-updates.

The other part are the tests, where I think we should look into why they
are failing, and figure out if there is any issue in Guix or not
rather than removing them without investigating the cause.

Regards,
Ruther

Message #13 received at 72968-done <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: 72968-done <at> debbugs.gnu.org, 72943 <at> debbugs.gnu.org
Subject: Patches applied
Date: Thu, 5 Sep 2024 22:41:56 +0200

Hello,

I have applied Carlos's second patch of
   https://issues.guix.gnu.org/72943
which gives an explanation why we skip the tests,
and Noé's patch of
   https://issues.guix.gnu.org/72968
adding the missing inputs.

As php currently does not build after the core-updates merge and this issue
has been turning up regularly over the past few days, I have taken the
liberty to push the commits directly without going through QA; I have
tested that the package builds and works with one of my local php projects.

I am closing the second issue, which is thus handled.
And I am leaving the first issue open; while the immediate php problem is
(hopefully) solved, it remains to be discussed whether we should propagate
the gd inputs in the longer term.

My understanding is that given the pkg-config file, we normally would
propagate the inputs. On the other hand, propagated inputs tend to create
problems (for instance, when two different packages propagate two different
versions of the same input library); and I do not quite understand why
with over 5000 packages depending on gd, most of them do not seem to be
affected. Maybe these do not use pkg-config to check for gd?
So it may be a better option to only patch the affected packages (if any
are left) and leave gd as it is.

Andreas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.