GNU bug report logs - #72957
[PATCH] gnu: Add bin-graph.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72957 in the body.
You can then email your comments to 72957 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Subject: [PATCH] gnu: Add bin-graph.
Date: Mon,  2 Sep 2024 12:57:27 +0300

* gnu/packages/linux.scm (bin-graph): New variable.

Change-Id: I7405cbc00e038d024d035fb100473352c9a7b59d
---
 gnu/packages/linux.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 318c6ccf13..38f3d6fc2f 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -1776,6 +1776,43 @@ (define-public bbswitch-module
 graphics card on Optimus laptops.")
       (license license:gpl2))))
 
+(define-public bin-graph
+  ;; XXX: The upstream does not have tags yet.
+  (let ((commit "1dd42e3e8e123e993d6c287967502c8d4b36f9ba")
+        (revision "0"))
+    (package
+      (name "bin-graph")
+      (version (git-version "0.0.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/8dcc/bin-graph")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "1wjkl789r7iys3nnyk813gsdxwwy2ryxgxirx5xw02lzk790dywl"))))
+      (arguments
+       (list #:tests? #f                ; no tests
+             #:make-flags
+             #~(list (string-append "CC=" #$(cc-for-target))
+                     (string-append "PREFIX=" #$output))
+             #:phases
+             #~(modify-phases %standard-phases
+                 (delete 'configure)
+                 (replace 'install
+                   (lambda _
+                     (install-file "bin-graph"
+                                   (string-append #$output "/bin")))))))
+      (build-system gnu-build-system)
+      (inputs (list libpng))
+      (home-page "https://github.com/8dcc/bin-graph")
+      (synopsis "Visualize binary files")
+      (description
+       "@code{bin-graph} provides a simple way of visualizing the different regions
+of a binary file.")
+      (license license:gpl3))))
+
 (define-public ddcci-driver-linux
   (package
     (name "ddcci-driver-linux")

base-commit: a977900d76b7585c401222a3ce8bbb82e5f6da45
-- 
2.45.2

Message #8 received at 72957 <at> debbugs.gnu.org (full text, mbox):

From: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
To: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Cc: Wilko Meyer <w <at> wmeyer.eu>, 72957 <at> debbugs.gnu.org,
 Leo Famulari <leo <at> famulari.name>
Subject: Re: [bug#72957] [PATCH] gnu: Add bin-graph.
Date: Wed, 04 Sep 2024 10:43:52 +0800

[Message part 1 (text/plain, inline)]

"Artyom V. Poptsov" <poptsov.artyom <at> gmail.com> writes:


maybe gnu/packages/graph.scm better here

> * gnu/packages/linux.scm (bin-graph): New variable.
>
> Change-Id: I7405cbc00e038d024d035fb100473352c9a7b59d
> ---
>  gnu/packages/linux.scm | 37 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
>
> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> index 318c6ccf13..38f3d6fc2f 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -1776,6 +1776,43 @@ (define-public bbswitch-module
>  graphics card on Optimus laptops.")
>        (license license:gpl2))))
>  
> +(define-public bin-graph
> +  ;; XXX: The upstream does not have tags yet.
> +  (let ((commit "1dd42e3e8e123e993d6c287967502c8d4b36f9ba")
> +        (revision "0"))
> +    (package
> +      (name "bin-graph")
> +      (version (git-version "0.0.0" revision commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/8dcc/bin-graph")
> +               (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32 "1wjkl789r7iys3nnyk813gsdxwwy2ryxgxirx5xw02lzk790dywl"))))
> +      (arguments
> +       (list #:tests? #f                ; no tests
> +             #:make-flags
> +             #~(list (string-append "CC=" #$(cc-for-target))
> +                     (string-append "PREFIX=" #$output))

see https://github.com/8dcc/bin-graph/blob/f5c53c427248d3fe10c1c921ea134f4592fbe8b7/Makefile#L10C1-L10C12

when use (string-append "INSTALL_DIR=" #$output "/bin") , not need to
replace install phase.

> +             #:phases
> +             #~(modify-phases %standard-phases
> +                 (delete 'configure)

please add a comment, ; no configure script

> +                 (replace 'install
> +                   (lambda _
> +                     (install-file "bin-graph"
> +                                   (string-append #$output "/bin")))))))
> +      (build-system gnu-build-system)
> +      (inputs (list libpng))
> +      (home-page "https://github.com/8dcc/bin-graph")
> +      (synopsis "Visualize binary files")
> +      (description
> +       "@code{bin-graph} provides a simple way of visualizing the different regions
> +of a binary file.")
> +      (license license:gpl3))))
> +
>  (define-public ddcci-driver-linux
>    (package
>      (name "ddcci-driver-linux")
>
> base-commit: a977900d76b7585c401222a3ce8bbb82e5f6da45

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 72957 <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: 72957 <at> debbugs.gnu.org
Cc: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Subject: [PATCH v2] gnu: Add bin-graph.
Date: Wed,  4 Sep 2024 10:40:43 +0300

* gnu/packages/linux.scm (bin-graph): New variable.

Change-Id: I7405cbc00e038d024d035fb100473352c9a7b59d
---
 gnu/packages/linux.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index a3b63a6f62..76de4be816 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -1776,6 +1776,40 @@ (define-public bbswitch-module
 graphics card on Optimus laptops.")
       (license license:gpl2))))
 
+(define-public bin-graph
+  ;; XXX: The upstream does not have tags yet.
+  (let ((commit "1dd42e3e8e123e993d6c287967502c8d4b36f9ba")
+        (revision "0"))
+    (package
+      (name "bin-graph")
+      (version (git-version "0.0.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/8dcc/bin-graph")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "1wjkl789r7iys3nnyk813gsdxwwy2ryxgxirx5xw02lzk790dywl"))))
+      (arguments
+       (list #:tests? #f                ; no tests
+             #:make-flags
+             #~(list (string-append "CC=" #$(cc-for-target))
+                     (string-append "PREFIX=" #$output)
+                     (string-append "INSTALL_DIR=" #$output "/bin"))
+             #:phases
+             #~(modify-phases %standard-phases
+                 (delete 'configure))))    ; no configure script
+      (build-system gnu-build-system)
+      (inputs (list libpng))
+      (home-page "https://github.com/8dcc/bin-graph")
+      (synopsis "Visualize binary files")
+      (description
+       "@code{bin-graph} provides a simple way of visualizing the different regions
+of a binary file.")
+      (license license:gpl3))))
+
 (define-public ddcci-driver-linux
   (package
     (name "ddcci-driver-linux")

base-commit: 7fa9df431e9423e2b79c8c520de1d0ef7aed910d
-- 
2.45.2

Message #14 received at 72957 <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
Cc: Wilko Meyer <w <at> wmeyer.eu>, 72957 <at> debbugs.gnu.org,
 Leo Famulari <leo <at> famulari.name>
Subject: Re: [bug#72957] [PATCH] gnu: Add bin-graph.
Date: Wed, 04 Sep 2024 10:46:44 +0300

[Message part 1 (text/plain, inline)]

Hello, Zheng Junjie!

Thank you for the patch review!  I fixed most of the issues that you
mentioned.

> maybe gnu/packages/graph.scm better here

I don't think that "graph.scm" is a good place for "bin-graph" as this
is not a tool for working with images only but more like a tool for
visualizing the insides of binaries.  It's closer to reverse-engineering
realm than to image processing realm.

- avp

-- 
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 72957 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: 72957 <at> debbugs.gnu.org
Subject: Looks good
Date: Wed, 18 Sep 2024 10:53:05 +0200

Hello Artyom,

it looks good and passes QA.

I think you have commit rights now and can push it yourself and close
the issue? If not, please come back to me.

Andreas

Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: 72957-done <at> debbugs.gnu.org
Cc: Andreas Enge <andreas <at> enge.fr>, Zheng Junjie <zhengjunjie <at> iscas.ac.cn>,
 guix-patches <at> gnu.org
Subject: Re: [PATCH] gnu: Add bin-graph.
Date: Sun, 13 Oct 2024 13:17:25 +0300

[Message part 1 (text/plain, inline)]

Pushed to the "master" as e4f5eb6c01727ef143e533019e74830e00d6f5d2.

- avp

-- 
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.