GNU bug report logs - #72939
guix import crate produce broken package definition

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72939 in the body.
You can then email your comments to 72939 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Aleksandr Vityazev <avityazev <at> disroot.org>
To: bug-guix <at> gnu.org
Subject: guix import crate produce broken package definition
Date: Sun, 01 Sep 2024 23:08:23 +0300

[Message part 1 (text/plain, inline)]

Hi,

guix import crate sanakirja-core

Restult:

(define-public rust-sanakirja-core-1
  (package
    (name "rust-sanakirja-core")
    (version "1.4.1")
    (source
     (origin
       (method url-fetch)
       (uri (crate-uri "sanakirja-core" version))
       (file-name (string-append name "-" version ".tar.gz"))
       (sha256
        (base32 "1xcb4d9gaxp61na4dyz9iiq3n1shhiivqs0iv5xnxb1ymqsdnxl3"))))
    (build-system cargo-build-system)
    (arguments
     `(#:cargo-inputs ,(list ("rust-crc32fast" ,rust-crc32fast-1)
                             ("rust-ed25519-zebra" ,rust-ed25519-zebra-2)
                             ("rust-sha2" ,rust-sha2-0.10)
                             ("rust-uuid" ,rust-uuid-1))))
    (home-page "https://nest.pijul.com/pijul/sanakirja")
    (synopsis
     "Copy-on-write datastructures, storable on disk (or elsewhere) with a stable format")
    (description
     "This package provides Copy-on-write datastructures, storable on disk (or elsewhere) with a stable
format.")
    (license (list license:expat license:asl2.0))))

quasiquote and unquote in arguments are unbalanced. Probably introduced
in b8af6694b9bbea96e8b0d1c9aea64b7f8e690812.


-- 
Best regards,
Aleksandr Vityazev

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 72939 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Aleksandr Vityazev <avityazev <at> disroot.org>
Cc: Dariqq <dariqq <at> posteo.net>, 72939 <at> debbugs.gnu.org,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Sarah Morgensen <iskarian <at> mgsn.dev>
Subject: Re: bug#72939: guix import crate produce broken package definition
Date: Thu, 19 Sep 2024 15:04:07 +0200

Hi Aleksandr,

(Cc’ing potentially interested parties.)

Aleksandr Vityazev <avityazev <at> disroot.org> skribis:

> guix import crate sanakirja-core

[...]

>     (arguments
>      `(#:cargo-inputs ,(list ("rust-crc32fast" ,rust-crc32fast-1)
>                              ("rust-ed25519-zebra" ,rust-ed25519-zebra-2)
>                              ("rust-sha2" ,rust-sha2-0.10)
>                              ("rust-uuid" ,rust-uuid-1))))

[...]

> quasiquote and unquote in arguments are unbalanced. Probably introduced
> in b8af6694b9bbea96e8b0d1c9aea64b7f8e690812.

Indeed.  Fixed in 89413a11625dd6c548827dd0078ebe0191086597 by reverting
that commit.

Commit b8af6694b9bbea96e8b0d1c9aea64b7f8e690812 originates from
<https://issues.guix.gnu.org/49531>, which included more work, such as a
‘guix style’ feature to update Rust packages to this new style.  I don’t
think the part about Rust packages reached consensus though.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.