GNU bug report logs - #72925
Adding JPM package for Janet

Previous Next

Package: guix-patches;

Reported by: Omar Bassam <omar.bassam88 <at> gmail.com>

Date: Sun, 1 Sep 2024 09:06:01 UTC

Severity: normal

Done: jgart <jgart <at> dismail.de>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Suhail Singh <suhailsingh247 <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Sharlatan Hellseher <sharlatanus <at> gmail.com>, 72925 <at> debbugs.gnu.org, Munyoki Kilyungi <me <at> bonfacemunyoki.com>, Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>, Guillaume Le Vaillant <glv <at> posteo.net>, jgart <jgart <at> dismail.de>, Suhail Singh <suhailsingh247 <at> gmail.com>
Subject: [bug#72925] Adding JPM package for Janet
Date: Sat, 12 Oct 2024 16:17:27 -0400
Ludovic Courtès <ludo <at> gnu.org> writes:

>> +                         (("\"curl\"")
>> +                          (string-append "\""
>> +                                         #$curl "/bin/curl" "\"")))
>> +                       (substitute* "jpm/shutil.janet"
>> +                         (("cp")
>> +                          (string-append #$coreutils "/bin/cp")))
>
> Please add ‘git-minimal/pinned’, ‘curl’, and ‘coreutils-minimal’ to the
> ‘inputs’ field.  Then you can fix the stanzas above to things like:
>
>   (string-append "\"" (search-input-file inputs "/bin/curl") "\"")

Happy to make the requested changes.

Could you please, however, elaborate on the guiding principle here?
I.e., what's the "lesson" here?  It seems that the preference is for
search-input-file over gexps such as #$curl, but it's not clear what
makes it the preferred approach.

-- 
Suhail




This bug report was last modified 137 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.