From unknown Sat Jun 21 02:42:53 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#72925 <72925@debbugs.gnu.org> To: bug#72925 <72925@debbugs.gnu.org> Subject: Status: Adding JPM package for Janet Reply-To: bug#72925 <72925@debbugs.gnu.org> Date: Sat, 21 Jun 2025 09:42:53 +0000 retitle 72925 Adding JPM package for Janet reassign 72925 guix-patches submitter 72925 Omar Bassam severity 72925 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 01 05:05:49 2024 Received: (at submit) by debbugs.gnu.org; 1 Sep 2024 09:05:49 +0000 Received: from localhost ([127.0.0.1]:33357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1skgWq-0000Hk-1d for submit@debbugs.gnu.org; Sun, 01 Sep 2024 05:05:49 -0400 Received: from lists.gnu.org ([209.51.188.17]:40788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1skg0z-0007nq-Ef for submit@debbugs.gnu.org; Sun, 01 Sep 2024 04:32:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1skg01-0002wj-8l for guix-patches@gnu.org; Sun, 01 Sep 2024 04:31:53 -0400 Received: from mail-oo1-xc2a.google.com ([2607:f8b0:4864:20::c2a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1skfzz-0000fi-Bm for guix-patches@gnu.org; Sun, 01 Sep 2024 04:31:53 -0400 Received: by mail-oo1-xc2a.google.com with SMTP id 006d021491bc7-5d5c7f24372so2052555eaf.0 for ; Sun, 01 Sep 2024 01:31:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725179508; x=1725784308; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=BKexfbURPaysXI6M/Xx1H6AT4gVwpxoqhqGoUHD3gIY=; b=Gfsp93f5QgBnPQ6UR4LB4/nZ/e6Pyv0ow2adE8CD1TUPaocfEFuYPv9//6rF9YOFzc Yegg8unFULnjNuVe1yLYZNEuVXKqzb+xSkYAXxMPnSwrcwMRAAaI1pKbEbv0Uv8+i1Ry C1y1W26KPKC8H0kPbC4MoirgQtc0EPAiWA4NCWQ2dNxnniKLmr11ZtMrioDVoaY/F0Ex 3vBKQMQyZB5RJm7ZmfGF2huF2x7MAygnaA8jvYw+WF32irygkAls0RE5P1h4XoqmeeI5 tYTiUrHb57/QkbOVozVkpWCUgVZZGg4Dty01PE4sx904gF2IVSpPV4AyU5umodC4qOSu Km0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725179508; x=1725784308; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=BKexfbURPaysXI6M/Xx1H6AT4gVwpxoqhqGoUHD3gIY=; b=Hki7e7wUkEKmqg1HTOpwaDU2CmvBVgPpOQVR7hYYpgzJKuPL4yxXDtRDw0R9BfoJTk J4EPWqAMhpJgaJczuaAuQPAZoTQJVHXhoGsE9yd/u4C2mlgBj2iQqrBLTFcoPbrHAjTG GFQjYp952eXzjOyVsPdnJGkvcjOegTbPyfrRU6qPz8LZiMkHokOPIm/evgon98bZ75nV ENO26qxR3ttlMG1lwMvzipluY9fjeayqa+y13IbsSoszkP86dK26KAUwDGarQ+n4hS58 ru5/Rjiwn+zk0KgMVegk9OTBVltDc+OOcCF4SC9Jub6fqJKZ/JryDFtiOaqmLKYUQm24 3alw== X-Gm-Message-State: AOJu0Yy1N5Os+hBJ6zLUfdYfq+Z3grtnPbIo7WdfowZnWn89vwm/lGWr owcZiONPZ4Jr2Wiw/S/oNTPGLB6kX52rzPfdLIxKT7GcvOsVlpq6nIORZqsVDKpI9Nsb3iq2HrN CWnyB/gEpRiUcekJc/IsQ3P2oPxnmsZDk X-Google-Smtp-Source: AGHT+IFBy4M22lCge6CRnkqKuOqNmI64Fbsi25KhjkrH9e/VPMgjsk4XIpNInLX9/NzcTZUkLb1fCaerxaDVUKLQlA4= X-Received: by 2002:a05:6358:726:b0:1b3:94cc:6526 with SMTP id e5c5f4694b2df-1b7ef5fe6demr573380555d.2.1725179508141; Sun, 01 Sep 2024 01:31:48 -0700 (PDT) MIME-Version: 1.0 From: Omar Bassam Date: Sun, 1 Sep 2024 11:31:36 +0300 Message-ID: Subject: Adding JPM package for Janet To: guix-patches@gnu.org Content-Type: multipart/alternative; boundary="000000000000c1b67406210aa7ed" Received-SPF: pass client-ip=2607:f8b0:4864:20::c2a; envelope-from=omar.bassam88@gmail.com; helo=mail-oo1-xc2a.google.com X-Spam_score_int: -8 X-Spam_score: -0.9 X-Spam_bar: / X-Spam_report: (-0.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 01 Sep 2024 05:05:46 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --000000000000c1b67406210aa7ed Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable >From 14fd8cafaebc27a00a4b198abe8e3759583c56b5 Mon Sep 17 00:00:00 2001 Message-ID: < 14fd8cafaebc27a00a4b198abe8e3759583c56b5.1725179146.git.omar.bassam88@gmail= .com > From: Omar Bassam Date: Sun, 1 Sep 2024 08:17:08 +0000 Subject: [PATCH] adding jpm package Change-Id: I730ef2f5c874c5142a580a42af76180e95d93ccd --- gnu/packages/lisp.scm | 52 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 52 insertions(+) diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm index 5d4399f145..4d4748dcb4 100644 --- a/gnu/packages/lisp.scm +++ b/gnu/packages/lisp.scm @@ -29,6 +29,7 @@ ;;; Copyright =C2=A9 2024 Andreas Enge ;;; Copyright =C2=A9 2024 bigbug ;;; Copyright =C2=A9 2024 Ashish SHUKLA +;;; Copyright =C2=A9 2024 Omar Bassam ;;; ;;; This file is part of GNU Guix. ;;; @@ -917,6 +918,57 @@ (define-public janet assembler, PEG) is less than 1MB.") (license license:expat))) +(define-public jpm + (package + (name "jpm") + (version "1.1.0") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/janet-lang/jpm.git") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 (base32 "05rdxigmiy7vf93s16a8n2029lq33073jccz1rjl4iisxj6piw4l")))) + (build-system trivial-build-system) + (arguments + (list + #:modules `((guix build utils)) + #:builder #~(begin + (use-modules (guix build utils)) + (mkdir %output) + (for-each (lambda (dir) (mkdir (string-append %output "/" dir))) + '("bin" "lib" "share" "share/man" "lib/janet= " + "lib/janet/jpm" "share/man/man1")) + (copy-recursively (assoc-ref %build-inputs "source") "source") + (chdir "source") + (substitute* "configs/linux_config.janet" + (("auto-shebang true") "auto-shebang false")) + (substitute* "configs/linux_config.janet" + (("/usr/local") %output)) + (substitute* "jpm/shutil.janet" + (("cp") (string-append #$coreutils "/bin/cp"))) + (substitute* "jpm/declare.janet" + (("chmod") (string-append #$coreutils "/bin/chmod"))= ) + (setenv "PREFIX" %output) + (setenv "JANET_PREFIX" %output) + (setenv "JANET_LIBPATH" (string-append %output "/lib/janet")) + (setenv "JANET_MODPATH" (string-append %output "/lib/janet")) + (system* (string-append #$janet "/bin/janet") + "bootstrap.janet" "configs/linux_config.janet") + (substitute* (string-append %output "/bin/jpm") + (("/usr/bin/env janet") + (string-append #$janet "/bin/janet"))) + (copy-recursively (string-append #$janet "/include/janet") + (string-append %output "/include/janet")) + (copy-recursively (string-append #$janet "/lib") + (string-append %output "/lib"))))) + (inputs (list janet coreutils)) + (home-page "https://janet-lang.org/") + (synopsis "Janet Project Manager for the Janet programming language") + (description "JPM is the Janet Project Manager tool. It is for automating +builds and downloading dependencies of Janet projects.") + (license license:expat))) + (define-public lisp-repl-core-dumper (package (name "lisp-repl-core-dumper") base-commit: e05f0e9832326703fa90a02559f1a4b44e4401ad --=20 2.45.2 --000000000000c1b67406210aa7ed Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
From 14fd8cafaebc27a00a4b198abe8e3759583c= 56b5 Mon Sep 17 00:00:00 2001
Message-ID: <14= fd8cafaebc27a00a4b198abe8e3759583c56b5.1725179146.git.omar.bassam88@gmail.c= om>
From: Omar Bassam <omar.bassam88@gmail.com>
Date: Sun, 1 Sep 2024 08:17:08 +0000=
Subject: [PATCH] adding jpm package

Change-Id: I730ef2f5c874c514= 2a580a42af76180e95d93ccd
---
=C2=A0gnu/packages/lisp.scm | 52 +++++++= ++++++++++++++++++++++++++++++++++++
=C2=A01 file changed, 52 insertions= (+)

diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
in= dex 5d4399f145..4d4748dcb4 100644
--- a/gnu/packages/lisp.scm
+++ b/g= nu/packages/lisp.scm
@@ -29,6 +29,7 @@
=C2=A0;;; Copyright =C2=A9 202= 4 Andreas Enge <andreas@enge.fr&g= t;
=C2=A0;;; Copyright =C2=A9 2024 bigbug <bigbookofbug@proton.me>
=C2=A0;;; Copyright =C2= =A9 2024 Ashish SHUKLA <ashish.is= @lostca.se>
+;;; Copyright =C2=A9 2024 Omar Bassam <omar.bassam88@gmail.com>
=C2=A0;= ;;
=C2=A0;;; This file is part of GNU Guix.
=C2=A0;;;
@@ -917,6 +9= 18,57 @@ (define-public janet
=C2=A0assembler, PEG) is less than 1MB.&qu= ot;)
=C2=A0 =C2=A0 =C2=A0(license license:expat)))
=C2=A0
+(define= -public jpm
+ =C2=A0(package
+ =C2=A0 =C2=A0(name "jpm")+ =C2=A0 =C2=A0(version "1.1.0")
+ =C2=A0 =C2=A0(source (orig= in
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(method git-fetch)<= br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(uri (git-reference+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(ur= l "https://github.co= m/janet-lang/jpm.git")
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(commit (string-append "v" version= ))))
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(file-name (git-f= ile-name name version))
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0(sha256 (base32 "05rdxigmiy7vf93s16a8n2029lq33073jccz1rjl4iisxj6piw= 4l"))))
+ =C2=A0 =C2=A0(build-system trivial-build-system)
+ =C2= =A0 =C2=A0(arguments
+ =C2=A0 =C2=A0 (list
+ =C2=A0 =C2=A0 =C2=A0#:mo= dules `((guix build utils))
+ =C2=A0 =C2=A0 =C2=A0#:builder #~(begin
= + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(use= -modules (guix build utils))
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0(mkdir %output)
+ =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(for-each (lambda (dir) (mkdir= (string-append %output "/" dir)))
+ =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0'("bin" "lib" "share" "share/m= an" "lib/janet"
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&q= uot;lib/janet/jpm" "share/man/man1"))
+ =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(copy-recursively (asso= c-ref %build-inputs "source") "source")
+ =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(chdir "sou= rce")
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0(substitute* "configs/linux_config.janet"
+ =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0((&quo= t;auto-shebang true") "auto-shebang false"))
+ =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(substitute* &qu= ot;configs/linux_config.janet"
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(("/usr/local") %output= ))
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0(substitute* "jpm/shutil.janet"
+ =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(("cp") (stri= ng-append #$coreutils "/bin/cp")))
+ =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(substitute* "jpm/declare= .janet"
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0(("chmod") (string-append #$coreutils "/= bin/chmod")))
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0(setenv "PREFIX" %output)
+ =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(setenv "JANET_= PREFIX" %output)
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0(setenv "JANET_LIBPATH" (string-append %outp= ut "/lib/janet"))
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0(setenv "JANET_MODPATH" (string-append= %output "/lib/janet"))
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(system* (string-append #$janet "/bi= n/janet")
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "bootstrap.janet" &quo= t;configs/linux_config.janet")
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(substitute* (string-append %output &quo= t;/bin/jpm")
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0(("/usr/bin/env janet")
+ =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (string-= append #$janet "/bin/janet")))
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(copy-recursively (string-append #= $janet "/include/janet")
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0(string-append %output "/include/janet"))=
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (copy-recursively (string-append #$janet "/lib")
+ =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(string-append %output &quo= t;/lib")))))
+ =C2=A0 =C2=A0(inputs (list janet coreutils))
+ = =C2=A0 =C2=A0(home-page "https://j= anet-lang.org/")
+ =C2=A0 =C2=A0(synopsis "Janet Project M= anager for the Janet programming language")
+ =C2=A0 =C2=A0(descrip= tion "JPM is the Janet Project Manager tool. It is for automating
+= builds and downloading dependencies of Janet projects.")
+ =C2=A0 = =C2=A0(license license:expat)))
+
=C2=A0(define-public lisp-repl-core= -dumper
=C2=A0 =C2=A0(package
=C2=A0 =C2=A0 =C2=A0(name "lisp-re= pl-core-dumper")

base-commit: e05f0e9832326703fa90a02559f1a4b44= e4401ad
--
2.45.2


--000000000000c1b67406210aa7ed-- From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 04 08:32:51 2024 Received: (at 72925) by debbugs.gnu.org; 4 Sep 2024 12:32:51 +0000 Received: from localhost ([127.0.0.1]:33800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slpBq-0008G5-O8 for submit@debbugs.gnu.org; Wed, 04 Sep 2024 08:32:51 -0400 Received: from mail-ej1-f49.google.com ([209.85.218.49]:60619) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sllJv-0001JN-RA for 72925@debbugs.gnu.org; Wed, 04 Sep 2024 04:24:57 -0400 Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a89c8db505bso435067266b.0 for <72925@debbugs.gnu.org>; Wed, 04 Sep 2024 01:23:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725438166; x=1726042966; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=4CpTe0KjnjJ+SP/x5YqX4PcLT2PyXJawNcruYEzrFbA=; b=JibQu3B5jCVfbtqj27n2FvyDyIrH3c4LwM/zFhKY0OPk688g+Xsxy2lbm++9Uwzta7 XE8Egy2YOikQwHjWit+/GwCuinej9slLsFaUX+pVsZ3sLdhZuVo/L2VgheYYa3KK0xHR AIJb0+jHycUFogQ/IP+2iNork/aEsiB/rDgDwq31VBNu42HYLi2guZodTDBxCpltfi5G siBlxQCCbkv/ocTsHwdl1DC0hlrbALKp3f5J0Rqf9VCu9M1Sy7uHn/nHsLur+r03OpVg kAb8AOW8VTd8VEcDH3lO/WX+iBtRW7TMggYu+PFbb+i8xTxslQQShQzrg10FDF4dix14 youA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725438166; x=1726042966; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4CpTe0KjnjJ+SP/x5YqX4PcLT2PyXJawNcruYEzrFbA=; b=hxXKs8wYlaW8KscAfY3KVB98XnNKLPAtZz6iM5YieXcS9LgBI5pCq0EgIqDgLZ/ZRV 6jZbc6hK99xe2cTDvQhkYKOu1mPDVyahk5MMhcOVrOlDV1Suk+b09bSsiERGF/81AG47 HN/o6q0gfDPMr/FRgVXc7fanCkU/iO+Sdd4h5teYtjB0tYWz0LOTYXp1/kxLhnIBxgOV kA4t5GOmGHyEC3G3R8VFGL8iyiKs8rv10lAFXM6kTTEaVIM9HsnHOw17lm/GdjPtHQA/ kByG27ALIdPvNic+SPXWsVSYDBDyDmbCU4BTPlofwayUnc36+soy+J+2OdRwwnHz5ZKr ulSA== X-Gm-Message-State: AOJu0YxnOM1HfT8FaQoGQ29gU9VM6glzCNGqwStjIEKVd1lIpixxeJN5 kFEvuy4vSVhGPqCbMunG8TIrwxelwEv1jE7n2Ids0jfHUF0HuLSg629DRg== X-Google-Smtp-Source: AGHT+IEIgfZOua0GzoJ/3Y4XN+1tdfgHr4w3rHx8+t5mYtxAydmjwSkGX0DBimo4emuEvDSCIwVe6A== X-Received: by 2002:a17:907:97d6:b0:a86:7e2d:f10b with SMTP id a640c23a62f3a-a8a32eda45dmr250924466b.37.1725438165495; Wed, 04 Sep 2024 01:22:45 -0700 (PDT) Received: from omar-Latitude-5540.musala.com ([193.17.229.5]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a89891a3d60sm777781166b.123.2024.09.04.01.22.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Sep 2024 01:22:44 -0700 (PDT) From: Omar Bassam To: 72925@debbugs.gnu.org Subject: [PATCH] adding jpm package Date: Wed, 4 Sep 2024 11:22:37 +0300 Message-ID: <14fd8cafaebc27a00a4b198abe8e3759583c56b5.1725179146.git.omar.bassam88@gmail.com> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 X-Debbugs-Cc: Guillaume Le Vaillant , Katherine Cox-Buday , Munyoki Kilyungi , Sharlatan Hellseher , jgart Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 X-Mailman-Approved-At: Wed, 04 Sep 2024 08:32:47 -0400 Cc: Omar Bassam X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Change-Id: I730ef2f5c874c5142a580a42af76180e95d93ccd --- gnu/packages/lisp.scm | 52 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 52 insertions(+) diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm index 5d4399f145..4d4748dcb4 100644 --- a/gnu/packages/lisp.scm +++ b/gnu/packages/lisp.scm @@ -29,6 +29,7 @@ ;;; Copyright © 2024 Andreas Enge ;;; Copyright © 2024 bigbug ;;; Copyright © 2024 Ashish SHUKLA +;;; Copyright © 2024 Omar Bassam ;;; ;;; This file is part of GNU Guix. ;;; @@ -917,6 +918,57 @@ (define-public janet assembler, PEG) is less than 1MB.") (license license:expat))) +(define-public jpm + (package + (name "jpm") + (version "1.1.0") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/janet-lang/jpm.git") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 (base32 "05rdxigmiy7vf93s16a8n2029lq33073jccz1rjl4iisxj6piw4l")))) + (build-system trivial-build-system) + (arguments + (list + #:modules `((guix build utils)) + #:builder #~(begin + (use-modules (guix build utils)) + (mkdir %output) + (for-each (lambda (dir) (mkdir (string-append %output "/" dir))) + '("bin" "lib" "share" "share/man" "lib/janet" + "lib/janet/jpm" "share/man/man1")) + (copy-recursively (assoc-ref %build-inputs "source") "source") + (chdir "source") + (substitute* "configs/linux_config.janet" + (("auto-shebang true") "auto-shebang false")) + (substitute* "configs/linux_config.janet" + (("/usr/local") %output)) + (substitute* "jpm/shutil.janet" + (("cp") (string-append #$coreutils "/bin/cp"))) + (substitute* "jpm/declare.janet" + (("chmod") (string-append #$coreutils "/bin/chmod"))) + (setenv "PREFIX" %output) + (setenv "JANET_PREFIX" %output) + (setenv "JANET_LIBPATH" (string-append %output "/lib/janet")) + (setenv "JANET_MODPATH" (string-append %output "/lib/janet")) + (system* (string-append #$janet "/bin/janet") + "bootstrap.janet" "configs/linux_config.janet") + (substitute* (string-append %output "/bin/jpm") + (("/usr/bin/env janet") + (string-append #$janet "/bin/janet"))) + (copy-recursively (string-append #$janet "/include/janet") + (string-append %output "/include/janet")) + (copy-recursively (string-append #$janet "/lib") + (string-append %output "/lib"))))) + (inputs (list janet coreutils)) + (home-page "https://janet-lang.org/") + (synopsis "Janet Project Manager for the Janet programming language") + (description "JPM is the Janet Project Manager tool. It is for automating +builds and downloading dependencies of Janet projects.") + (license license:expat))) + (define-public lisp-repl-core-dumper (package (name "lisp-repl-core-dumper") base-commit: e05f0e9832326703fa90a02559f1a4b44e4401ad -- 2.45.2 From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 05 11:36:38 2024 Received: (at 72925) by debbugs.gnu.org; 5 Sep 2024 15:36:39 +0000 Received: from localhost ([127.0.0.1]:37889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smEXF-0002cx-Qg for submit@debbugs.gnu.org; Thu, 05 Sep 2024 11:36:38 -0400 Received: from mail-ej1-f53.google.com ([209.85.218.53]:48587) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smDyW-0008IY-57 for 72925@debbugs.gnu.org; Thu, 05 Sep 2024 11:00:45 -0400 Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a86e9db75b9so125257166b.1 for <72925@debbugs.gnu.org>; Thu, 05 Sep 2024 07:59:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725548312; x=1726153112; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ndCXZrwtYXRsOD9Cu/F1AzduO91Cd0Jc4en6azZTA5U=; b=iu3JNi6+RCf2T2mRUVXqeHfa0NEQVK20fiherZQFToFHnUyhdstXhLJjHatRf2OUmA MlCKgvLvZnigOH4kWkc17Zf+O1+sZXLHILQzV42OHl1VQG5ONb1hKBDwMTbnteVxuC2t uGWDMF7acOU3QEVZUPCJm7S/UjRWShm70M47aIHGFkC9WiL00RyxK4hoqIFuEri/2zH+ 5N+miv1/fWYpvYQBIsh0CgL269RgQdKaLIvfo1kanqmqL7UDup2DD1NKDv/Mr3ws5GFV sRhK3kFV8PBl7L2hl7Vy5SlEZgkDcS2m89RANuYYV0z3qUkZJSEXHH0ePWRPmVAf+IfK lOUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725548312; x=1726153112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ndCXZrwtYXRsOD9Cu/F1AzduO91Cd0Jc4en6azZTA5U=; b=hbj4steqLVNa9SQvQ6t9lig5JmpBVSg+/ymJwxBZcsIvAuKJAjHqTAs+5ohuiw2nha /FEuSOTmXso1vusfsHHFc9ixzXC5YrIp45RUwArwqosQS4WLoC+ZUFf4rm+EEV4Pz1l4 EJkp3alcQNzO4G5XBNThaxYk80jH3ywe4TB/5R+xKMucvhyl4kI0Sq4HAcn6L5t8CGry jy7pPprLRKnnOiRNgAStskROs7Ix5a3CitW9Fju5oSI8URJhSzb0+srr7mWP3bvUTIjA l3zvHuL00FEb5meTd8j/DrZWUpz9NhE4Oa9UHrg6eYu03F/ces2lRsO3eiSbSwqZRaqL lfjw== X-Gm-Message-State: AOJu0YzxZpi+fiD9ELf3gHf55WTTmRNKyQ/coGo/aIdoZ4UCwSZO/UQd 7sCDWcScJBjnAXCZpvvauLEM64CbSpKMSHBkt1FA4lo77lo2gsgzAEYEOw== X-Google-Smtp-Source: AGHT+IEva2Pji7ER4eeSW/Lcd4uyFkDl9MEQWMRD3X9oF2r5DiIIxHXBU+1oJDBJ0auE34kW7Ll5Ww== X-Received: by 2002:a2e:a596:0:b0:2ef:2c6a:4929 with SMTP id 38308e7fff4ca-2f64440dc3emr90720981fa.13.1725547812361; Thu, 05 Sep 2024 07:50:12 -0700 (PDT) Received: from omar-Latitude-5540.. ([37.63.117.235]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c3cc69a222sm1286588a12.69.2024.09.05.07.50.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Sep 2024 07:50:11 -0700 (PDT) From: Omar Bassam To: 72925@debbugs.gnu.org Subject: [PATCH] adding jpm package Date: Thu, 5 Sep 2024 17:50:02 +0300 Message-ID: <950a7d3637ddf17be84f52dc2ae0aac2ce4c4be6.1725547778.git.omar.bassam88@gmail.com> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 X-Debbugs-Cc: Guillaume Le Vaillant , Katherine Cox-Buday , Munyoki Kilyungi , Sharlatan Hellseher , jgart Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 X-Mailman-Approved-At: Thu, 05 Sep 2024 11:36:37 -0400 Cc: Omar Bassam X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Change-Id: I730ef2f5c874c5142a580a42af76180e95d93ccd --- gnu/packages/lisp.scm | 52 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 52 insertions(+) diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm index 5d4399f145..96698d375d 100644 --- a/gnu/packages/lisp.scm +++ b/gnu/packages/lisp.scm @@ -29,6 +29,7 @@ ;;; Copyright © 2024 Andreas Enge ;;; Copyright © 2024 bigbug ;;; Copyright © 2024 Ashish SHUKLA +;;; Copyright © 2024 Omar Bassam ;;; ;;; This file is part of GNU Guix. ;;; @@ -917,6 +918,57 @@ (define-public janet assembler, PEG) is less than 1MB.") (license license:expat))) +(define-public jpm + (package + (name "jpm") + (version "1.1.0") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/janet-lang/jpm.git") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 (base32 "05rdxigmiy7vf93s16a8n2029lq33073jccz1rjl4iisxj6piw4l")))) + (build-system trivial-build-system) + (arguments + (list + #:modules `((guix build utils)) + #:builder #~(begin + (use-modules (guix build utils)) + (mkdir %output) + (for-each (lambda (dir) (mkdir (string-append %output "/" dir))) + '("bin" "lib" "share" "share/man" "lib/janet" + "lib/janet/jpm" "share/man/man1")) + (copy-recursively (assoc-ref %build-inputs "source") "source") + (chdir "source") + (substitute* "configs/linux_config.janet" + (("auto-shebang true") "auto-shebang false")) + (substitute* "configs/linux_config.janet" + (("/usr/local") %output)) + (substitute* "jpm/shutil.janet" + (("cp") (string-append #$coreutils "/bin/cp"))) + (substitute* "jpm/declare.janet" + (("chmod") (string-append #$coreutils "/bin/chmod"))) + (setenv "PREFIX" %output) + (setenv "JANET_PREFIX" %output) + (setenv "JANET_LIBPATH" (string-append %output "/lib/janet")) + (setenv "JANET_MODPATH" (string-append %output "/lib/janet")) + (system* (string-append #$janet "/bin/janet") + "bootstrap.janet" "configs/linux_config.janet") + (substitute* (string-append %output "/bin/jpm") + (("/usr/bin/env janet") + (string-append #$janet "/bin/janet"))) + (copy-recursively (string-append #$janet "/include/janet") + (string-append %output "/include/janet")) + (copy-recursively (string-append #$janet "/lib") + (string-append %output "/lib"))))) + (inputs (list janet coreutils)) + (home-page "https://janet-lang.org/") + (synopsis "Janet Project Manager for the Janet programming language") + (description "JPM is the Janet Project Manager tool. It is for automating +builds and downloading dependencies of Janet projects.") + (license license:expat))) + (define-public lisp-repl-core-dumper (package (name "lisp-repl-core-dumper") base-commit: e05f0e9832326703fa90a02559f1a4b44e4401ad -- 2.45.2 From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 18 09:20:26 2024 Received: (at 72925) by debbugs.gnu.org; 18 Sep 2024 13:20:26 +0000 Received: from localhost ([127.0.0.1]:57276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1squba-0003Y1-5I for submit@debbugs.gnu.org; Wed, 18 Sep 2024 09:20:26 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:53752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1squbX-0003SO-HT for 72925@debbugs.gnu.org; Wed, 18 Sep 2024 09:20:24 -0400 Received: by mail-qt1-f195.google.com with SMTP id d75a77b69052e-4583083d019so38487211cf.3 for <72925@debbugs.gnu.org>; Wed, 18 Sep 2024 06:20:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726665541; x=1727270341; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=pS+pbTgw9TR6UxE02BiflUecDj1N4JcEjVEAiMqYIKI=; b=cqdZ7JQufeHcWeIdheT/CTxzmR47xBbYuS+rrijtnmhZ0VpW45Zm6j9hFtOk5g5Qqz mcNGwzmZXOlDCmrsv9avNHjoW7d2QxC1nOv29Qr9dCEvOqajcF9/5C7RU8BT5s9qVZCL yvdciRwPaVtekIIp1bqvk3cbFmJVU6Aj0a7g5/Qy/TV5tYqwVOjeCLHN8BrCZeINeUGS /4PouJaiHEln+O/jzFesSIJ+QqChYHY0D4ja/WWFf6WU8hjX5E0Bh7hTid+psBUexAnx zEUqvp4Q/dHYQelnTfRZx+1FykFwVQ1+dmxcAl/eK6RDIM08xbeetOw3dgeakk9iPmUR nVUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726665541; x=1727270341; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pS+pbTgw9TR6UxE02BiflUecDj1N4JcEjVEAiMqYIKI=; b=Jem+HoNR3N4ZZgtUpfoNzgkOPdev8hNjWjV/QHjfecrAVNY2c8oY64nmMc1Q3n3eru 5KHZC0I7dw3ccyitrN3rMfOXwO0GlhrjXrkvmMANpqpD9rCduK7qC1eUaNrJd08cODZm p5lpXI8wLZvWWA8B818IkTCDyN93sGpmfqMKpzBsIQQuRYnUYOYx1SXUj8YB7FKEeUX2 1tCS7G4mFkIzb581rLLA6EzPTefM9Gnk+PWRL1f1L3YVxUotwtPIyEfWTacZ5jcZ3Ibc z5I6FUYcly1x9KRVWkuUlVEa7pr3+9BNQcbKtkzCRNxQt9ogDoYyydWYIRRxm78EossB enRw== X-Gm-Message-State: AOJu0YzC3qvL177b9PVGMp0vJ+r2ETXDZCNHhXPXMNf5QgiiRe8D2SVR SHfaMWsuyAYtSheY/9hrsflYd3duMyt+E07raaNbJtdKmfrk/qAt X-Google-Smtp-Source: AGHT+IHE89ldymye99AdfTzkZ1r6jczldM5bPqO/PksBAgbHeND3DiXHqp/6v/MB9Ur4Uw1q7+h2zg== X-Received: by 2002:ac8:59d3:0:b0:458:34df:1e65 with SMTP id d75a77b69052e-4599d29f812mr272831381cf.44.1726665541476; Wed, 18 Sep 2024 06:19:01 -0700 (PDT) Received: from gnus ([65.94.70.53]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-459aacf611bsm48605841cf.70.2024.09.18.06.19.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 06:19:01 -0700 (PDT) From: "Suhail Singh" To: Omar Bassam Subject: Re: bug#72925: Adding JPM package for Janet In-Reply-To: <950a7d3637ddf17be84f52dc2ae0aac2ce4c4be6.1725547778.git.omar.bassam88@gmail.com> (Omar Bassam's message of "Thu, 5 Sep 2024 17:50:02 +0300") References: <950a7d3637ddf17be84f52dc2ae0aac2ce4c4be6.1725547778.git.omar.bassam88@gmail.com> Date: Wed, 18 Sep 2024 09:18:42 -0400 Message-ID: <87h6adyua5.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 72925 Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Munyoki Kilyungi , Katherine Cox-Buday , Guillaume Le Vaillant , jgart X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Hi Omar, Thank you for submitting this patch. A few comments: Omar Bassam writes: > Change-Id: I730ef2f5c874c5142a580a42af76180e95d93ccd > --- > gnu/packages/lisp.scm | 52 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 52 insertions(+) > > diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm > index 5d4399f145..96698d375d 100644 Could you please update the reroll-count when you send amendments to the patch? IIUC, this version should have been v2. > +(define-public jpm > + (package > + (name "jpm") > + (version "1.1.0") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/janet-lang/jpm.git") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 (base32 "05rdxigmiy7vf93s16a8n2029lq33073jccz1rjl4iisxj6piw4l")))) > + (build-system trivial-build-system) > ... > + (substitute* (string-append %output "/bin/jpm") > + (("/usr/bin/env janet") > + (string-append #$janet "/bin/janet"))) Is my understanding correct that you're updating the shebang line here? If so, would it be better to use the copy-build-system instead? If not, could you please elaborate? If copy-build-system does indeed turn out to be better suited, could you please send v3 of the patch? -- Suhail From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 18 09:30:15 2024 Received: (at control) by debbugs.gnu.org; 18 Sep 2024 13:30:16 +0000 Received: from localhost ([127.0.0.1]:57308 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1squl5-0004Bn-Ko for submit@debbugs.gnu.org; Wed, 18 Sep 2024 09:30:15 -0400 Received: from mail-qv1-f68.google.com ([209.85.219.68]:47262) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1squl3-0004BU-PL for control@debbugs.gnu.org; Wed, 18 Sep 2024 09:30:14 -0400 Received: by mail-qv1-f68.google.com with SMTP id 6a1803df08f44-6c354415c19so56363546d6.2 for ; Wed, 18 Sep 2024 06:29:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726666131; x=1727270931; darn=debbugs.gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=gJ9RaJWQlq+CSBfbGAQ/Hc7Io6UveoAbsG/8hz3sftY=; b=Qw6WJY5K7qojyL0sDcosLkaFKmnWbRS1/w2NK0DH8r0FBfFrDeMqG/N+vmaePAZ5o0 pimIL0c8+mP5Nr6STf/xmRLLuZNMcF6sK9XC98MgXFjK9JH3ut8EowLHjM69w+4lxYk5 jciG0UtAbaq0iWJlGZ0IJfmuh9GEFZJci4l8brMuzdi9byemPoGD66kcvd6SlI5sR1eD 0YvL8RZFqidJsspuH0+Oi0VfP5MDNLw9+lBCxmEwXM3OpcoLt+mJHEgzpAD2sYmlCsCP PeQnwDcAkvXByirvB/KPVZmq/cyvWb4o+mZD2wrtqlaqaYkeSuAi0PPEDCkL1XDC6k6U v2sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726666131; x=1727270931; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=gJ9RaJWQlq+CSBfbGAQ/Hc7Io6UveoAbsG/8hz3sftY=; b=UUAZq9D+jeCpcE9E5xvo4gsSZbgVrVasYWEjD9R9CtFIiHC8ObaFkSKfevfgPZlbmB oZOjCTJXWruidxd6PnXHnzfg9PivE/eA6F1YCVLvh/ABPP3wVlrf04Rf8pQxg2qGlFGA 7mb5K1a5khI2K2n5qQX/WqRPuXsluuhccZqSk76ufo2u3A1jh1yr4diPxBWL9MB7ZoRM xj4Yn8vnzBJd9LnP93ApsVgGutXdFBSMSOyBmuBK6MCCw+lvqZipolCSu9Iaf9t50Y5K 1flBaNZQHjCMHKjaR/z1/0kupIoUztSDXstepxJlDf0m+C0UhRBn7uOsGHeIdah+dDZ1 39KQ== X-Gm-Message-State: AOJu0Yz/V1/DuRhtFBLqIRGydPdu2qqS68QWE/MHo95yEaOKDy4F0w7P 6jznB8wW/44AYpvrVd/L1k2KuOqptgklM8VDd+EQtw/VWVoxZxYFZ0F5gaIX X-Google-Smtp-Source: AGHT+IFocjCJYtqRHysLa6rcK14tT5IFDXNaJmbwfzCLUnLuH7PkzkcCysccUpZd+BYFrjOhB4uLfg== X-Received: by 2002:a05:6214:2b96:b0:6c3:668b:b0e4 with SMTP id 6a1803df08f44-6c5736cba60mr414414836d6.39.1726666131452; Wed, 18 Sep 2024 06:28:51 -0700 (PDT) Received: from gnus (bras-base-mtrlpq0776w-grc-23-65-94-70-53.dsl.bell.ca. [65.94.70.53]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6c58c7da0b8sm44359026d6.130.2024.09.18.06.28.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 06:28:51 -0700 (PDT) From: "Suhail Singh" To: control@debbugs.gnu.org Subject: control message for bug #72925 Date: Wed, 18 Sep 2024 09:28:50 -0400 Message-ID: <87ed5hytt9.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) owner 72925 ! quit From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 18 12:17:55 2024 Received: (at 72925) by debbugs.gnu.org; 18 Sep 2024 16:17:55 +0000 Received: from localhost ([127.0.0.1]:59194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqxNL-0005k2-EX for submit@debbugs.gnu.org; Wed, 18 Sep 2024 12:17:55 -0400 Received: from mail-qv1-f68.google.com ([209.85.219.68]:46576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqxNI-0005jn-0s for 72925@debbugs.gnu.org; Wed, 18 Sep 2024 12:17:53 -0400 Received: by mail-qv1-f68.google.com with SMTP id 6a1803df08f44-6c36ff6e981so50778976d6.1 for <72925@debbugs.gnu.org>; Wed, 18 Sep 2024 09:17:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726676190; x=1727280990; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=PGbi8OiqZj40Y7YAsN1XIao/ajUyuqwQov+nV+sYgyk=; b=ZcTWvpcrc6jMCPE0vv18lJAUOpAKHptxrSIBuOb0V7RzwoNbhwbiE0xClHy5x80Q6c JopAef73Xc3LDLgHRv8h1g7Le04gN2CJPRjG70BdbxF7TZ5FBAiFy7oiONuRJoaVAuSC p59nvuGOVsPxC3RlaGjUQ6q7XTcHp+2TCWc4ByFC/VZMaQNXEuH4vJz5p2ME54aiTdP8 PxIVBfothL+L47QJ3hGNCfO63YsoXlrOELXOiqXGaYRgJOc+uPM1rZG20DrHCa0PMOC+ wsnjr5GESgpfEABBXZ/ZIe2t+UnecZTRKW+/Yrly2ctXIXPnHgadube30Jr3KYn558y0 fuKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726676190; x=1727280990; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PGbi8OiqZj40Y7YAsN1XIao/ajUyuqwQov+nV+sYgyk=; b=DKXfmtaRDfEGxQdt71o/zncYxeyM3mt07h/rEwgf9PtUSgVXu58o5iMdGIud5Ipn1A Bk4aiMJavA1JAay+M3tRHUjUllU7NPdbHAChnn8LHM2LqQunnZwQDQ9dEfkQ+3exlBpG Is61iJYqNqLiuWOBipQtca4OGSB6IFA8ILcSSWEHx+JCyT7HRaHk9O4yEGHPcG+8W7HQ KNnxAwLkaLTdjRWL2M2tFIAp9w65w7topwCQkh3cnLRtjqd7oA+HICsxdn1RamqsP96y z9D+lT7UEQxW4bOGBq3x8Gpwa97ibJkae99UBebM1mFL24sFWqx/Nee1tlG1EtZQ5kqp eyKQ== X-Forwarded-Encrypted: i=1; AJvYcCWYSI4dbYmbgs+PNbc031z1r2PvnmWvV+4KFtdbaYR6zw4ZeX1MDDihyLeSikA/0ahJauKuzQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxT2kzFeCDxmwyrHAuXv+fzLSgIHF90LhWemcqu1CXTcZlpoc11 h0MFew4kfeUynC1EZenvxEwXJaGZM2uYPhKLkEq6Ssc9QAPCrvdJ X-Google-Smtp-Source: AGHT+IF/v0N6JGSNdXy4sWCsNlZtLrrAxWNaATnIhemrErkKidGJSytaEXrXzt3/dKmYmhTzuSf5/Q== X-Received: by 2002:a05:6214:4802:b0:6c5:15dc:df02 with SMTP id 6a1803df08f44-6c573556ea6mr392704936d6.3.1726676190027; Wed, 18 Sep 2024 09:16:30 -0700 (PDT) Received: from gnus (bras-base-mtrlpq0776w-grc-23-65-94-70-53.dsl.bell.ca. [65.94.70.53]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6c58c691deasm45219026d6.80.2024.09.18.09.16.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 09:16:29 -0700 (PDT) From: Suhail Singh To: Omar Bassam Subject: Re: bug#72925: Adding JPM package for Janet In-Reply-To: (Omar Bassam's message of "Wed, 18 Sep 2024 18:34:17 +0300") References: <950a7d3637ddf17be84f52dc2ae0aac2ce4c4be6.1725547778.git.omar.bassam88@gmail.com> <87h6adyua5.fsf_-_@gmail.com> Date: Wed, 18 Sep 2024 12:16:28 -0400 Message-ID: <87a5g5vswz.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 72925 Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Munyoki Kilyungi , Katherine Cox-Buday , Guillaume Le Vaillant , jgart , Suhail Singh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Omar Bassam writes: > Thank you for taking the time to look into my patch. Sorry, I'm new to Guix > and to this workflow. So, forgive me if my questions look a bit naive: > 1. What do you mean by reroll count for the patch? Please refer to the man page of git-format-patch and look for --reroll-count : #+begin_quote -v , --reroll-count= Mark the series as the -th iteration of the topic. The output filenames have v prepended to them, and the subject prefix ("PATCH" by default, but configurable via the --subject-prefix option) has ` v` appended to it. E.g. --reroll-count=4 may produce v4-0001-add-makefile.patch file that has "Subject: [PATCH v4 1/20] Add makefile" in it. does not have to be an integer (e.g. "--reroll-count=4.4", or "--reroll-count=4rev2" are allowed), but the downside of using such a reroll-count is that the range-diff/interdiff with the previous version does not state exactly which version the new iteration is compared against. #+end_quote > 2. I looked at the copy-build-system documentation. I'm not sure how it can > be used here. I'm not just updating the shebang. As you can already see in > the patch, I'm doing a lot of string substitutions in the source code > itself because some values are hard coded. That's why I preferred to use > the trivial-build-system to have more control of what I need to substitute. Based on my understanding of the patch you are copying files, updating some references in files, and setting environment variables. I believe all of these are possible via the copy-build-system as well which is described as: #+begin_quote ;; Standard build procedure for simple packages that don't require much ;; compilation, mostly just copying files around. This is implemented as an ;; extension of `gnu-build-system'. #+end_quote If you'd like to learn more, you can grep under ./gnu/packages and look at some instances where it's used. I don't have experience with the trivial-build-system, which is why I wondered. > + (setenv "PREFIX" %output) > + (setenv "JANET_PREFIX" %output) > + (setenv "JANET_LIBPATH" (string-append %output "/lib/janet")) > + (setenv "JANET_MODPATH" (string-append %output "/lib/janet")) What would be a way to test that the above is doing the "correct" thing? Is there a sequence of steps that I can evaluate which will yield a different outcome depending on whether or not the above accomplishes what it intends to? Put another way, what breaks when the above aren't set (and how do I observe that failure)? -- Suhail From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 18 12:25:23 2024 Received: (at 72925) by debbugs.gnu.org; 18 Sep 2024 16:25:23 +0000 Received: from localhost ([127.0.0.1]:59204 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqxUY-00068D-Nq for submit@debbugs.gnu.org; Wed, 18 Sep 2024 12:25:23 -0400 Received: from mail-pj1-f50.google.com ([209.85.216.50]:45378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqwid-0003Us-8E for 72925@debbugs.gnu.org; Wed, 18 Sep 2024 11:35:51 -0400 Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-2d877e9054eso4981310a91.3 for <72925@debbugs.gnu.org>; Wed, 18 Sep 2024 08:35:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726673669; x=1727278469; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=mwFnAV/834GkdJhWuQRm8S9dgpvkwbxshmeTTuhItx8=; b=NqhCOdA/V+zKgrb14mOpOhpHBD+8PUjJe+GaX5wMIJsBOH929mLqpp6VhY+MAMrzge bQ5FIfyPlVtJ3scBhfrL2tBNeG9tpfvqSNNh0v+6te5OxPOtQa+y4+OKGvvt/Z0S36DC zUCA7ukp4vqtVUrm7MuMIxfI2HIxo9oHyNUa5r5/svZOnM8Pl+4NckbEae0Iq2k6T1aa jrQqD/7UlwEG4YH65oKMRsxI7f7UAx8N/c2VcPCnIFxw2sHVIaK/+yRrMCaT/xsfnk4P l63wFoKJVuat/SU+7e74hVR83TaTIGngwxA1zeVTXOy3eXx3C6LjElxXI2w4tKoNCUxh QP7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726673669; x=1727278469; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mwFnAV/834GkdJhWuQRm8S9dgpvkwbxshmeTTuhItx8=; b=Wvevo0y9nRb3YTFTZ3xVor3h0ez8i56yiDfQPUoseKprcJmeK6arZ94RLdL7kRiBRh k06+BtBz/JloT+jrv2bKXVeahDqfVU7l3bIarpPRGK/7a3yGbRnChgVgAIlm+z7yU/5q SC71/o9y+4EqjBVNlZDxrWYJ8xf56gcg/PIxVxGvMdxXxs2+qa+Qk6i9M14v9r07Y76j UxYMYab7CD6I73NQDmjb2DNdPgtRvEJfyg7Yz5E3Ess6RTjY+5Vy/LUPOGZ9mOgkbkbs NKwPPZboURyK0+qH+vpRqT+hJE/jqLDAgfBJMiAoId99EL05E9wFaMbFTMHXcwroqVGa Z/6w== X-Gm-Message-State: AOJu0Yz95aYM98dbhxlzd5tAMTqW2p4W9u9EAk7oyRPj6wJ5IFc0UhtG I2ghsWu65tz6TzLJZ7aWRhxAnCwh6XsD0fATG/q82Dfg07Zw//V4EtuYojPu9psZe81x/2nN1bz WX4uctp1ys0KZuU/WsXO+mL/Okng= X-Google-Smtp-Source: AGHT+IHr6WYR106NSUlJLQO69xRKrXNJ8/6fy0Cg0US3IVduYMpfyhTfHB4/L9bdImHFmZpYJFZoVdgoqb9advvKpds= X-Received: by 2002:a17:90a:f2c3:b0:2d8:b205:2345 with SMTP id 98e67ed59e1d1-2db9ffb416cmr25737931a91.23.1726673668901; Wed, 18 Sep 2024 08:34:28 -0700 (PDT) MIME-Version: 1.0 References: <950a7d3637ddf17be84f52dc2ae0aac2ce4c4be6.1725547778.git.omar.bassam88@gmail.com> <87h6adyua5.fsf_-_@gmail.com> In-Reply-To: <87h6adyua5.fsf_-_@gmail.com> From: Omar Bassam Date: Wed, 18 Sep 2024 18:34:17 +0300 Message-ID: Subject: Re: bug#72925: Adding JPM package for Janet To: Suhail Singh Content-Type: multipart/alternative; boundary="000000000000ad9bdf0622668af8" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 72925 X-Mailman-Approved-At: Wed, 18 Sep 2024 12:25:21 -0400 Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Munyoki Kilyungi , Katherine Cox-Buday , Guillaume Le Vaillant , jgart X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --000000000000ad9bdf0622668af8 Content-Type: text/plain; charset="UTF-8" Thank you for taking the time to look into my patch. Sorry, I'm new to Guix and to this workflow. So, forgive me if my questions look a bit naive: 1. What do you mean by reroll count for the patch? 2. I looked at the copy-build-system documentation. I'm not sure how it can be used here. I'm not just updating the shebang. As you can already see in the patch, I'm doing a lot of string substitutions in the source code itself because some values are hard coded. That's why I preferred to use the trivial-build-system to have more control of what I need to substitute. Thanks, Omar On Wed, 18 Sept 2024 at 16:19, Suhail Singh wrote: > Hi Omar, > > Thank you for submitting this patch. A few comments: > > Omar Bassam writes: > > > Change-Id: I730ef2f5c874c5142a580a42af76180e95d93ccd > > --- > > gnu/packages/lisp.scm | 52 +++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 52 insertions(+) > > > > diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm > > index 5d4399f145..96698d375d 100644 > > Could you please update the reroll-count when you send amendments to the > patch? IIUC, this version should have been v2. > > > +(define-public jpm > > + (package > > + (name "jpm") > > + (version "1.1.0") > > + (source (origin > > + (method git-fetch) > > + (uri (git-reference > > + (url "https://github.com/janet-lang/jpm.git") > > + (commit (string-append "v" version)))) > > + (file-name (git-file-name name version)) > > + (sha256 (base32 > "05rdxigmiy7vf93s16a8n2029lq33073jccz1rjl4iisxj6piw4l")))) > > + (build-system trivial-build-system) > > ... > > + (substitute* (string-append %output "/bin/jpm") > > + (("/usr/bin/env janet") > > + (string-append #$janet "/bin/janet"))) > > Is my understanding correct that you're updating the shebang line here? > If so, would it be better to use the copy-build-system instead? If not, > could you please elaborate? If copy-build-system does indeed turn out > to be better suited, could you please send v3 of the patch? > > -- > Suhail > --000000000000ad9bdf0622668af8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thank you for taking the time to look into my patch. = Sorry, I'm new to Guix and to this workflow. So, forgive me if my quest= ions look a bit naive:
1. What do you mean by reroll count for th= e patch?
2. I looked at the copy-build-system documentation. I= 9;m not sure how it can be used here. I'm not just updating the shebang= . As you can already see in the patch, I'm doing a lot of string substi= tutions in the source code itself because some values are hard coded. That&= #39;s why I preferred to use the trivial-build-system to have more control = of what I need to substitute.

Thanks,
Om= ar

On Wed, 18 Sept 2024 at 16:19, Suhail Singh <suhailsingh247@gmail.com> wrote:
Hi Omar,

Thank you for submitting this patch.=C2=A0 A few comments:

Omar Bassam <omar.bassam88@gmail.com> writes:

> Change-Id: I730ef2f5c874c5142a580a42af76180e95d93ccd
> ---
>=C2=A0 gnu/packages/lisp.scm | 52 +++++++++++++++++++++++++++++++++++++= ++++++
>=C2=A0 1 file changed, 52 insertions(+)
>
> diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
> index 5d4399f145..96698d375d 100644

Could you please update the reroll-count when you send amendments to the patch?=C2=A0 IIUC, this version should have been v2.

> +(define-public jpm
> +=C2=A0 (package
> +=C2=A0 =C2=A0 (name "jpm")
> +=C2=A0 =C2=A0 (version "1.1.0")
> +=C2=A0 =C2=A0 (source (origin
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (method git-fetch) > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (uri (git-reference<= br> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (url "https://github.com/janet-lang/jpm.git") > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (commit (string-append "v" version))))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (file-name (git-file= -name name version))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (sha256 (base32 &quo= t;05rdxigmiy7vf93s16a8n2029lq33073jccz1rjl4iisxj6piw4l"))))
> +=C2=A0 =C2=A0 (build-system trivial-build-system)
> ...
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (substitute* (string-append %output "/bin/jpm")
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 (("/usr/bin/env janet")
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0(string-append #$janet "/bin/janet")))

Is my understanding correct that you're updating the shebang line here?=
If so, would it be better to use the copy-build-system instead?=C2=A0 If no= t,
could you please elaborate?=C2=A0 If copy-build-system does indeed turn out=
to be better suited, could you please send v3 of the patch?

--
Suhail
--000000000000ad9bdf0622668af8-- From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 30 08:02:34 2024 Received: (at 72925) by debbugs.gnu.org; 30 Sep 2024 12:02:34 +0000 Received: from localhost ([127.0.0.1]:44880 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svF6n-0006SE-A2 for submit@debbugs.gnu.org; Mon, 30 Sep 2024 08:02:34 -0400 Received: from mail-ed1-f53.google.com ([209.85.208.53]:52507) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svBXf-0001nX-HN for 72925@debbugs.gnu.org; Mon, 30 Sep 2024 04:14:11 -0400 Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5c5b9bf9d8bso2979346a12.1 for <72925@debbugs.gnu.org>; Mon, 30 Sep 2024 01:13:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727683944; x=1728288744; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wzZYU46edSH9z2yNHntMirfCD4p/f49az9hDUmp0JhY=; b=XCKV6IL6Ajx0XM4QjK9IXxsI8a9Reg+NS06Nqp/wxLHF6kZiJJPapvW0hKQ+V//tZt uf6EIYCvQzityWw9Vw0aB+3BbYe/US6ya5ndXBBO1qA/hd5OGZQLCBwLhiJbU1ybevAK H6u1kFMGzR1ileyDKW9tHfKqZ9rvxK1NKD7tAbQqkhzxCrnOsFyhIzrjASjUMsoVsYYR j1wdhP4PTcl7CFQNPtZDLER2DIEBCQMd9MtRz+Tggi2V7aT2wNEvTRO4sZ543XFIVNcs 2IwfkYzFaMQN8c54OA+BvIcsnkt0NMTbQBsGmpwqyM/Cb0Bg/uvdl4scB4gp1ABV0/Oo Hn0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727683944; x=1728288744; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wzZYU46edSH9z2yNHntMirfCD4p/f49az9hDUmp0JhY=; b=i2SL9BOYpTDFD/JlbmnkC/7yh2JRnw00QbMtIDmAY4k2RuSIXR1ABhPqThTIYij+mR z9lnf/Q3nLaSe/EB3kqsdpFGBkPXiDK29Sl+E5LntuHLC0pPvn+U1hnHL2CV89d97WV8 wQ6bgWqokd+LlGNDHNQAwiFjxmUmG5sy/5cKQI8lwO5K1f6EYAdKEgUASyfpcSGEQYPd 2dPR1P6z4qH8DjfXGi7NF2PpzkHjf2XKtafbjsHuZrJql2uZUQNmjjo08tiobU6rSWYv gbMbdjeR+8CUMPLrJFX2HS+OZpi1qltz/mDH2PGl5J7T77CyDF2NDo9YERWdDIBSFM8e NLoA== X-Gm-Message-State: AOJu0YxZvEd70C8qHwi8uGA7n2ikVrA0RMJM+P/MBIThV+MSlJWYd9Z/ PemjFe4xA23c39gTntEDxAMshmlwZSWQTKvo46l3qZOaIeOjqDl3jg5Z4sjE X-Google-Smtp-Source: AGHT+IGyOKN7IyEGJDNq2/msgChH6WQ0yxlOJEN7r5IbbRq28OKHjIYu39wuP/2ONVfAOjkvtPXg9w== X-Received: by 2002:a05:6402:2109:b0:5c8:85eb:9d9b with SMTP id 4fb4d7f45d1cf-5c885eba003mr13440653a12.13.1727683944164; Mon, 30 Sep 2024 01:12:24 -0700 (PDT) Received: from omar-Latitude-5540.. ([46.232.152.32]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c882405b19sm4102648a12.11.2024.09.30.01.12.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Sep 2024 01:12:23 -0700 (PDT) From: Omar Bassam To: 72925@debbugs.gnu.org Subject: [PATCH v3] adding jpm package Date: Mon, 30 Sep 2024 11:12:13 +0300 Message-ID: <4e623d9571ff648ae1d1c6ffb8f9d73c421a5c10.1727683810.git.omar.bassam88@gmail.com> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 X-Debbugs-Cc: Guillaume Le Vaillant , Katherine Cox-Buday , Munyoki Kilyungi , Sharlatan Hellseher , jgart Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 X-Mailman-Approved-At: Mon, 30 Sep 2024 08:02:31 -0400 Cc: Omar Bassam X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Change-Id: I730ef2f5c874c5142a580a42af76180e95d93ccd --- gnu/packages/lisp.scm | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm index 6c16d8ab71..7348ab5548 100644 --- a/gnu/packages/lisp.scm +++ b/gnu/packages/lisp.scm @@ -29,6 +29,7 @@ ;;; Copyright © 2024 Andreas Enge ;;; Copyright © 2024 bigbug ;;; Copyright © 2024 Ashish SHUKLA +;;; Copyright © 2024 Omar Bassam ;;; ;;; This file is part of GNU Guix. ;;; @@ -917,6 +918,41 @@ (define-public janet assembler, PEG) is less than 1MB.") (license license:expat))) +(define-public jpm + (package + (name "jpm") + (version "1.1.0") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/janet-lang/jpm.git") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 (base32 "05rdxigmiy7vf93s16a8n2029lq33073jccz1rjl4iisxj6piw4l")))) + (build-system copy-build-system) + (arguments + (list + #:phases #~(modify-phases %standard-phases + (add-after 'unpack 'fix-prefix-path + (lambda _ + (substitute* "configs/linux_config.janet" + (("/usr/local") #$output)) + (setenv "PREFIX" #$output))) + (replace 'install + (lambda _ + (for-each (lambda (dir) (mkdir-p (string-append #$output "/" dir))) + '("lib/janet/jpm" "share/man/man1")) + (invoke "janet" "bootstrap.janet" "configs/linux_config.janet") + (wrap-program (string-append #$output "/bin/jpm") + `("JANET_HEADERPATH" ":" = (,(string-append #$janet "/include/janet"))) + `("JANET_LIBPATH" ":" = (,(string-append #$janet "/lib"))))))))) + (inputs (list janet)) + (home-page "https://janet-lang.org/") + (synopsis "Janet Project Manager for the Janet programming language") + (description "JPM is the Janet Project Manager tool. It is for automating +builds and downloading dependencies of Janet projects.") + (license license:expat))) + (define-public lisp-repl-core-dumper (package (name "lisp-repl-core-dumper") base-commit: 093f2fb8722fafcc7c1555cd845289096849f4a2 -- 2.45.2 From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 30 20:08:47 2024 Received: (at 72925) by debbugs.gnu.org; 1 Oct 2024 00:08:47 +0000 Received: from localhost ([127.0.0.1]:47896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svQRa-0001dE-8Q for submit@debbugs.gnu.org; Mon, 30 Sep 2024 20:08:46 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:56665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svQRU-0001d6-UM for 72925@debbugs.gnu.org; Mon, 30 Sep 2024 20:08:43 -0400 Received: by mail-qt1-f194.google.com with SMTP id d75a77b69052e-45830ff5b70so42704431cf.1 for <72925@debbugs.gnu.org>; Mon, 30 Sep 2024 17:08:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727741222; x=1728346022; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=7XpxWmIEG34YQry1abNzhRIo4dZHWv+FZ9nBItll93E=; b=hQcvs1Qneb/V7QZEHFcCcafTFxbpv+513b37mFqTk0vdNah8EjbLZbBab2uA6A3+9C agkZsR7qTXKToorDo4orf7fhhHQD0l1dYPHRil0Wkz7FUT00lAYkR/dd7i5RQDC4QQeg x1aMlQD4dBh3QGFUCPG5I8kfXvCfTQ8wOLF2fTgMe4WvdI6GAqzvLA7PmyLV4wJ93Xcs E6HH+vdsCAWXoTeqhDx2rfQoN9KxO0FT2/BUSFtXHdSZ4g3Aj0qfyj/iEW8de/TvgXsq 4MCNpEHiraEFb/rK3cRZVPDZzMJHBc47P5/A7pxIGrG/SQhse4JlSkpF5yKB39x2uiqN VqTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727741222; x=1728346022; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7XpxWmIEG34YQry1abNzhRIo4dZHWv+FZ9nBItll93E=; b=d0Xi+C4RpG0ZWL0JqGdzGe6Pb/PrFaokCX97jNyHCtCAc6MexH+8Ls+DP3NFZ9zy2I 0mUcIv4+xWBGDaWi8aBs/llaev+z1B9C0JemMy5VHChWVv/uAlKptBmohPK4BtutQHdp E4hbu8BQfHO6ivdVQ8j8WSmcuaA/Xuw+3aUO4zkblp6fl8QyuXeUcqp3MceBx3ci/1KW tByGvxJ1eSjaq0Jj+KpXzvK27xmXelottXImTRm4M9xWn+6QKSA+zqroUIY0S/P15c3v JkWjnMzYvE2gnMhcd/+TIMLs+mnzGHJ2IPafrWzE/Ef3DTUU6A2Q7EJOZRbS9Z+qidYr R9+A== X-Gm-Message-State: AOJu0Yz0mG2dtgWZwXAUQK/mO9o2d0VZGIVE+aVnOew7zDM7UyrrOeV8 KS5sTfqEaQGqazLfvMcTts5fEsNlSf0zVmUWMgRqOohZJA2QGh1D X-Google-Smtp-Source: AGHT+IHxqWm++2y2YjvgVMWLvDXnKffwwO/qMDT3LB0nct2rVDawQ3rX1Y7vHZw895ZPl+scr7T+Tw== X-Received: by 2002:a05:622a:199a:b0:447:f4f6:7a1 with SMTP id d75a77b69052e-45c9f2c628amr182709481cf.52.1727741221727; Mon, 30 Sep 2024 17:07:01 -0700 (PDT) Received: from gnus ([65.94.70.53]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-45c9f350fadsm40571751cf.80.2024.09.30.17.06.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Sep 2024 17:07:00 -0700 (PDT) From: Suhail Singh To: Omar Bassam Subject: Re: [bug#72925] [PATCH v3] adding jpm package In-Reply-To: <4e623d9571ff648ae1d1c6ffb8f9d73c421a5c10.1727683810.git.omar.bassam88@gmail.com> (Omar Bassam's message of "Mon, 30 Sep 2024 11:12:13 +0300") References: <4e623d9571ff648ae1d1c6ffb8f9d73c421a5c10.1727683810.git.omar.bassam88@gmail.com> Date: Mon, 30 Sep 2024 20:06:48 -0400 Message-ID: <87plok7kkn.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Munyoki Kilyungi , Katherine Cox-Buday , Guillaume Le Vaillant , jgart X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Omar, thank you for sending a revised patch. I have a few comments relating to style and one unanswered question from our last exchange. > Subject: [bug#72925] [PATCH v3] adding jpm package In v4, could you please update the commit message to conform to the ChangeLog format as noted in . Please see for additional details. If you're using magit, `magit-generate-changelog' can help with this. In your case the commit will probably look something like: #+begin_quote gnu: Add jpm. * gnu/packages/lisp.scm (jpm): New variable. #+end_quote Omar Bassam writes: > +(define-public jpm > + (package > + (name "jpm") > + (version "1.1.0") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/janet-lang/jpm.git") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 (base32 "05rdxigmiy7vf93s16a8n2029lq33073jccz1rjl4iisxj6piw4l")))) There are no build errors with this, however, it's not clear how to verify that the runtime behaviour of jpm is as expected. After installing janet and jpm in a guix profile, running a command such as: #+begin_src sh jpm install sh #+end_src Results in the following: #+begin_example $> jpm install sh error: Read-only file system: /gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/.cache in os/mkdir [src/core/os.c] on line 1981 in download-bundle [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/pm.janet] on line 200, column 3 in bundle-install [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/pm.janet] on line 217, column 13 in resolve-bundle-name [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/pm.janet] on line 118, column 20 in resolve-bundle [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/pm.janet] on line 148, column 9 in bundle-install [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/pm.janet] on line 216, column 4 in install [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/commands.janet] (tail call) on line 190, column 20 in run-main [boot.janet] on line 4432, column 16 in cli-main [boot.janet] on line 4613, column 17 #+end_example Could you please share an example code snippet which can be used to verify correctness of the installation? Additionally, it seems that the jpm repository comes with a test (./test/installtest.janet and ./testinstall). However, it doesn't seem like we're running it during the build. Could you please share the reasons why? If possible, we should enable and run these tests. > + (build-system copy-build-system) > + (arguments > + (list > + #:phases #~(modify-phases %standard-phases > + (add-after 'unpack 'fix-prefix-path > + (lambda _ > + (substitute* "configs/linux_config.janet" > + (("/usr/local") #$output)) > + (setenv "PREFIX" #$output))) > + (replace 'install > + (lambda _ V3 doesn't cleanly apply due to whitespace issues on this (^) line. Please fix. On a related note, in case you're not aware, please observe all the steps listed in . Steps 3 and 4 recommend invoking guix lint and guix style which, unless I'm mistaken, would've caught this issue. -- Suhail From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 02 11:20:31 2024 Received: (at 72925) by debbugs.gnu.org; 2 Oct 2024 15:20:31 +0000 Received: from localhost ([127.0.0.1]:58996 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw19P-00076R-Le for submit@debbugs.gnu.org; Wed, 02 Oct 2024 11:20:31 -0400 Received: from mail-wm1-f45.google.com ([209.85.128.45]:42325) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw0Tz-0004er-BW for 72925@debbugs.gnu.org; Wed, 02 Oct 2024 10:37:40 -0400 Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-42cbc38a997so6169055e9.1 for <72925@debbugs.gnu.org>; Wed, 02 Oct 2024 07:37:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727879797; x=1728484597; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=YVRUiX41V4afY+dzoeyZKacMROORCOIX9tGDTVz0iE4=; b=QLIKgEzb9Tnkc5scOG6XxdIigQhARpWcKgz++MWJO/p5ynPJjRNJfPaMR2dIzeuiZw qJZwwON6Wu6WJsn6+ksOvDu7uyVX7x3CjEFNcdPZBPFC2Cdkd9JO+DegVpQj9vO185t7 wW6GvbDPZZsHzxX2EMaB1b8Ak/iht2eLDdbYV8TzYDaMJwYT8Qyhs0/pUKTp7sGy7uOR 9WVpv9uVSNonLCOS3ml2bbveBN7jjEmN+bCCthjmKRQwL24sVEGjOLg3jRudfQ1gzPsO 9RtvzwLqUa0vfb7USBaU3Qz4yo22HpM7zXUXRPUY/7x9o3SepFZS7ATww2c9/L4HN0lx kPBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727879797; x=1728484597; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YVRUiX41V4afY+dzoeyZKacMROORCOIX9tGDTVz0iE4=; b=lsIJW08ZCUH+zfKtzuN3k8UoUHcejqmxh+kiRAGL2GdKNxyVQLNQNXdg8h0gxcVJc7 StWUlbRI2ihV+L1P8HfQ7y/pHqYXNHKJTtPtCNzt5UKvgSWfm3jtFTbFwFSRehJP7JRB 22IJey3XrPHOuEWZeIkHVrjMxPXDsiQYK3Rpq/jIZepsvVAEnTwN6HFDigbRB0zHI1DH 4ZwdPGGpJIHjlo61OVCKFmSUzIk7HkTVrmBqhcHlDEE7hppFBwTBdXx+kOUZq0kGrQN2 7gN6dfDqfYebQIya22AuWe5x9nQDOK4FK8MJRHRi7EO7jY2uZdbDnTm8yucG+pNk8mqZ qb1A== X-Gm-Message-State: AOJu0YwyzXBxVNm6yjOVcdB71dg77oapc2eF/083wWG1p6s48Qx6VDJj p9wCjx6vq8l6TsCv5LlzJKdqRJh5YXC3KavpkQZRLcT5wwOotwMiUvJpxnHA X-Google-Smtp-Source: AGHT+IH24Z1dOxeF4VtF9MQaUPlkBiOdWlnW6hyEVcR3g1eX46EMK/yNbNaNOEOEVjR0Tlxb92e9yw== X-Received: by 2002:a05:600c:4f55:b0:42c:b991:98bc with SMTP id 5b1f17b1804b1-42f71283d7amr44365405e9.0.1727879796847; Wed, 02 Oct 2024 07:36:36 -0700 (PDT) Received: from omar-Latitude-5540.. ([46.232.152.32]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42f79ec0c08sm20250005e9.20.2024.10.02.07.36.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Oct 2024 07:36:36 -0700 (PDT) From: Omar Bassam To: 72925@debbugs.gnu.org Subject: [PATCH v5] gnu: add jpm package Date: Wed, 2 Oct 2024 17:36:28 +0300 Message-ID: <3b0b58bd01fc50abef6764fee5ec1d02dd15303d.1727879744.git.omar.bassam88@gmail.com> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 X-Debbugs-Cc: Guillaume Le Vaillant , Katherine Cox-Buday , Munyoki Kilyungi , Sharlatan Hellseher , jgart Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 X-Mailman-Approved-At: Wed, 02 Oct 2024 11:20:22 -0400 Cc: Omar Bassam X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/packages/lisp.scm (jpm): New Variable Change-Id: I730ef2f5c874c5142a580a42af76180e95d93ccd --- gnu/packages/lisp.scm | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm index 6c16d8ab71..3f406c260a 100644 --- a/gnu/packages/lisp.scm +++ b/gnu/packages/lisp.scm @@ -29,6 +29,7 @@ ;;; Copyright © 2024 Andreas Enge ;;; Copyright © 2024 bigbug ;;; Copyright © 2024 Ashish SHUKLA +;;; Copyright © 2024 Omar Bassam ;;; ;;; This file is part of GNU Guix. ;;; @@ -917,6 +918,41 @@ (define-public janet assembler, PEG) is less than 1MB.") (license license:expat))) +(define-public jpm + (package + (name "jpm") + (version "1.1.0") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/janet-lang/jpm.git") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 (base32 "05rdxigmiy7vf93s16a8n2029lq33073jccz1rjl4iisxj6piw4l")))) + (build-system copy-build-system) + (arguments + (list + #:phases #~(modify-phases %standard-phases + (add-after 'unpack 'fix-prefix-path + (lambda _ + (substitute* "configs/linux_config.janet" + (("/usr/local") #$output)) + (setenv "PREFIX" #$output))) + (replace 'install + (lambda _ + (for-each (lambda (dir) (mkdir-p (string-append #$output "/" dir))) + '("lib/janet/jpm" "share/man/man1")) + (invoke "janet" "bootstrap.janet" "configs/linux_config.janet") + (wrap-program (string-append #$output "/bin/jpm") + `("JANET_HEADERPATH" ":" = (,(string-append #$janet "/include/janet"))) + `("JANET_LIBPATH" ":" = (,(string-append #$janet "/lib"))))))))) + (inputs (list janet)) + (home-page "https://janet-lang.org/") + (synopsis "Janet Project Manager for the Janet programming language") + (description "JPM is the Janet Project Manager tool. It is for automating +builds and downloading dependencies of Janet projects.") + (license license:expat))) + (define-public lisp-repl-core-dumper (package (name "lisp-repl-core-dumper") base-commit: 3d0668fe6667dabe71ee2840e75877f18399c1d9 -- 2.45.2 From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 02 11:20:32 2024 Received: (at 72925) by debbugs.gnu.org; 2 Oct 2024 15:20:33 +0000 Received: from localhost ([127.0.0.1]:59000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw19U-00076l-Gk for submit@debbugs.gnu.org; Wed, 02 Oct 2024 11:20:32 -0400 Received: from mail-wm1-f53.google.com ([209.85.128.53]:45403) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw0hA-0005Pc-9U for 72925@debbugs.gnu.org; Wed, 02 Oct 2024 10:51:17 -0400 Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-42cde6b5094so61226615e9.3 for <72925@debbugs.gnu.org>; Wed, 02 Oct 2024 07:51:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727880609; x=1728485409; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=YVRUiX41V4afY+dzoeyZKacMROORCOIX9tGDTVz0iE4=; b=lPqlYJQKWTzZVBT+FgzojSCZqqMK45W8J6u4ys6arxWLZ2PLbcqC2RmVlNzIlbRCmi oOLypgaz15IDWmi4eedWYQ9FEhYrmOsQ7pZE2o8k2G7hNHUJzAeT6JNk3wFuTmqXGgQs c47kVtB6PkUXBY5MZE1pj8SKKUg8CN+sgI2/cYwB77e7AT26FGYIT8B/7ZB7iHAWpWeK hS2GELALGKsZm4uu1HFUjJzPg5H5c5zvNKRxtzCGoZj1TFGz6J0ZgqSnMz9oSa1f5ZS8 Qoru+EVkXk0C9iX2p8oUpcANZ878NogmdJaif0tqHB4sQIZQUql1FwsmmGEqNzvg4pfp 3ebw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727880609; x=1728485409; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YVRUiX41V4afY+dzoeyZKacMROORCOIX9tGDTVz0iE4=; b=NRHkCHJSW0f5U8q6QZ7uLP4rYvSxIUUDDbFiKZMKGtxrPbLOouHdfBXhJ98wHogF0P PRmgyWn3hdIvIdnxRrBK9PgYIwoTdDKaK9CeB07whWs1kffkR6qoomeOK9miuCrDFWPf YxYT564P6CKv+cbkUq8RQBRNXQSdZZ2P1sQ2FOZUw6xf/sVckoPzOd2K48Rpw7xDfaW1 I/oTf8ZNzJj4JLzUvzJxEoTZkaSSWsEaDxEuLDj4800AyyFg2L4ZQ0yqrXGwbAPlvMhx MbsSilWSaKDhlZCWGVd+utbpXBIUZIz/cuIVQ8YUh8e1DZtvRTHtdQQR+kYotXoh+sOG Ku6Q== X-Gm-Message-State: AOJu0YyUwffA/ZLUiGdaUbeOZixHrwo62xJw8sK5/lEZe9dxewwZOdkq b1F9MVjpeNOY7rtd3yLST8dJqUXI8HxjuhtksBXe4K6g0RODiKPHzDPFn8lj X-Google-Smtp-Source: AGHT+IFt2f6Sx4qoXw4cpRdyxR3fRNSPkfJzBAGDoX/oWFbjaNJNX5uSSWNfm/xHeU0wkIeRwY7oXA== X-Received: by 2002:a05:6000:10c7:b0:37c:d512:d427 with SMTP id ffacd0b85a97d-37cfb9ddfc2mr2371783f8f.35.1727880609109; Wed, 02 Oct 2024 07:50:09 -0700 (PDT) Received: from omar-Latitude-5540.. ([46.232.152.32]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37cd564d42esm14137264f8f.14.2024.10.02.07.50.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Oct 2024 07:50:08 -0700 (PDT) From: Omar Bassam To: 72925@debbugs.gnu.org Subject: [PATCH v6] gnu: add jpm package Date: Wed, 2 Oct 2024 17:50:01 +0300 Message-ID: <3b0b58bd01fc50abef6764fee5ec1d02dd15303d.1727880584.git.omar.bassam88@gmail.com> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 X-Debbugs-Cc: Guillaume Le Vaillant , Katherine Cox-Buday , Munyoki Kilyungi , Sharlatan Hellseher , jgart Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 X-Mailman-Approved-At: Wed, 02 Oct 2024 11:20:22 -0400 Cc: Omar Bassam X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/packages/lisp.scm (jpm): New Variable Change-Id: I730ef2f5c874c5142a580a42af76180e95d93ccd --- gnu/packages/lisp.scm | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm index 6c16d8ab71..3f406c260a 100644 --- a/gnu/packages/lisp.scm +++ b/gnu/packages/lisp.scm @@ -29,6 +29,7 @@ ;;; Copyright © 2024 Andreas Enge ;;; Copyright © 2024 bigbug ;;; Copyright © 2024 Ashish SHUKLA +;;; Copyright © 2024 Omar Bassam ;;; ;;; This file is part of GNU Guix. ;;; @@ -917,6 +918,41 @@ (define-public janet assembler, PEG) is less than 1MB.") (license license:expat))) +(define-public jpm + (package + (name "jpm") + (version "1.1.0") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/janet-lang/jpm.git") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 (base32 "05rdxigmiy7vf93s16a8n2029lq33073jccz1rjl4iisxj6piw4l")))) + (build-system copy-build-system) + (arguments + (list + #:phases #~(modify-phases %standard-phases + (add-after 'unpack 'fix-prefix-path + (lambda _ + (substitute* "configs/linux_config.janet" + (("/usr/local") #$output)) + (setenv "PREFIX" #$output))) + (replace 'install + (lambda _ + (for-each (lambda (dir) (mkdir-p (string-append #$output "/" dir))) + '("lib/janet/jpm" "share/man/man1")) + (invoke "janet" "bootstrap.janet" "configs/linux_config.janet") + (wrap-program (string-append #$output "/bin/jpm") + `("JANET_HEADERPATH" ":" = (,(string-append #$janet "/include/janet"))) + `("JANET_LIBPATH" ":" = (,(string-append #$janet "/lib"))))))))) + (inputs (list janet)) + (home-page "https://janet-lang.org/") + (synopsis "Janet Project Manager for the Janet programming language") + (description "JPM is the Janet Project Manager tool. It is for automating +builds and downloading dependencies of Janet projects.") + (license license:expat))) + (define-public lisp-repl-core-dumper (package (name "lisp-repl-core-dumper") base-commit: 3d0668fe6667dabe71ee2840e75877f18399c1d9 -- 2.45.2 From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 02 11:20:33 2024 Received: (at 72925) by debbugs.gnu.org; 2 Oct 2024 15:20:33 +0000 Received: from localhost ([127.0.0.1]:59002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw19U-00076t-Uh for submit@debbugs.gnu.org; Wed, 02 Oct 2024 11:20:33 -0400 Received: from mail-wr1-f42.google.com ([209.85.221.42]:61488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw0iZ-0005S5-QK for 72925@debbugs.gnu.org; Wed, 02 Oct 2024 10:52:44 -0400 Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-37cc5fb1e45so4708549f8f.2 for <72925@debbugs.gnu.org>; Wed, 02 Oct 2024 07:52:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727880702; x=1728485502; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=or2rLfPZ7XqZDT+0vKEJNUS2SCAc0VapmU5Iy/6ORw4=; b=khW4boWx13Ptptyt6Cn/WzrfJq3szFc+E2IGXd52GYZvdXtpNxyYQCeiw0cRfbNTxa KIBA/n17Sl5CIlYXJHZQW7ZRcqk9ZsUrhL3plQJfMGxDOk9e+f52SIw4lM+u+sLABdkQ yZTvtgN1PdMYgZjLErtywuQjwbRW3H1al7p1R+p3zbqcRXQmqV9FytjKG1ApT/dBX90U tbMFX2ndZCHL83a/jwhf5LqEDVNACkhYRV3DU8XkNEcOZE+Et4Q9J1oG9WemRHrtiGMc UYJiiolyHqH9sdQbPKoRmr7+no966ohFnGTNqIeIHC3a+5lSv09kFMODolvYNwML8NbU 4DjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727880702; x=1728485502; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=or2rLfPZ7XqZDT+0vKEJNUS2SCAc0VapmU5Iy/6ORw4=; b=qgksgCp06OmRR5lqtBYycY5YkR0ZWkleABmG3tM739uKIkuqtQeswPTzKPRP6Z+Jyh 9VlZAryMOKCqStWi9LP9xALKrTjYI7mPh5DFjkpWxyyqdZocXh7gruhYGWpnyr+k2K49 vihKpAOSbUY1r89g/pDzk3SO+QGxiY15pLywroxPsu8O544fKDdzNtUyfkl/BRfliEmi f6Es5WRKH9UPmQXUqhravDjau6AsHyCSebGXHG4yFPzYXBAJmJjzMXnk0APkrJY6Pasy yDA0OBeGsNvCTivxSQAgxiC6c2PKmOCmjV2eTsfe4xqmTMyqkjE7DmvhedO6XfBcc27B 7dtg== X-Gm-Message-State: AOJu0Yxuy9SJuUZW+EPAGQJswcTNeebe/Ru5o5hmKFIuOmyzGeDAGinn NxgbH3p8/g2wKO3Pobt6j80kVP1IrHvuTQsdelOzW6Owx24TxpUGILvPvpTM X-Google-Smtp-Source: AGHT+IFbHnjIbEGR4TgafOpfVvprr/pj0ECCXBhbMFCsjxVapvDjsd+hGwwq+g5i//gzdxD5LQkvPQ== X-Received: by 2002:adf:a19e:0:b0:374:c45a:8afb with SMTP id ffacd0b85a97d-37cfb8c7647mr2239607f8f.19.1727880701852; Wed, 02 Oct 2024 07:51:41 -0700 (PDT) Received: from omar-Latitude-5540.. ([46.232.152.32]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37cd5730fbbsm14174102f8f.77.2024.10.02.07.51.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Oct 2024 07:51:41 -0700 (PDT) From: Omar Bassam To: 72925@debbugs.gnu.org Subject: [PATCH v7] gnu: add jpm package Date: Wed, 2 Oct 2024 17:51:36 +0300 Message-ID: <39f8c254574fb6f02f67d7ed90ee6fc33d7fee7b.1727880688.git.omar.bassam88@gmail.com> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 X-Debbugs-Cc: Guillaume Le Vaillant , Katherine Cox-Buday , Munyoki Kilyungi , Sharlatan Hellseher , jgart Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 X-Mailman-Approved-At: Wed, 02 Oct 2024 11:20:22 -0400 Cc: Omar Bassam X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/packages/lisp.scm (jpm): New Variable Change-Id: I730ef2f5c874c5142a580a42af76180e95d93ccd --- gnu/packages/lisp.scm | 44 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm index 6c16d8ab71..f9ae0fe55a 100644 --- a/gnu/packages/lisp.scm +++ b/gnu/packages/lisp.scm @@ -29,6 +29,7 @@ ;;; Copyright © 2024 Andreas Enge ;;; Copyright © 2024 bigbug ;;; Copyright © 2024 Ashish SHUKLA +;;; Copyright © 2024 Omar Bassam ;;; ;;; This file is part of GNU Guix. ;;; @@ -917,6 +918,49 @@ (define-public janet assembler, PEG) is less than 1MB.") (license license:expat))) +(define-public jpm + (package + (name "jpm") + (version "1.1.0") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/janet-lang/jpm.git") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 "05rdxigmiy7vf93s16a8n2029lq33073jccz1rjl4iisxj6piw4l")))) + (build-system copy-build-system) + (arguments + (list + #:phases #~(modify-phases %standard-phases + (add-after 'unpack 'fix-prefix-path + (lambda _ + (substitute* "configs/linux_config.janet" + (("/usr/local") + #$output)) + (setenv "PREFIX" + #$output))) + (replace 'install + (lambda _ + (for-each (lambda (dir) + (mkdir-p (string-append #$output "/" dir))) + '("lib/janet/jpm" "share/man/man1")) + (invoke "janet" "bootstrap.janet" + "configs/linux_config.janet") + (wrap-program (string-append #$output "/bin/jpm") + `("JANET_HEADERPATH" ":" = + (,(string-append #$janet "/include/janet"))) + `("JANET_LIBPATH" ":" = + (,(string-append #$janet "/lib"))))))))) + (inputs (list janet)) + (home-page "https://janet-lang.org/") + (synopsis "Janet Project Manager for the Janet programming language") + (description "JPM is the Janet Project Manager tool. It is for automating +builds and downloading dependencies of Janet projects.") + (license license:expat))) + (define-public lisp-repl-core-dumper (package (name "lisp-repl-core-dumper") base-commit: 3d0668fe6667dabe71ee2840e75877f18399c1d9 -- 2.45.2 From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 02 11:20:36 2024 Received: (at 72925) by debbugs.gnu.org; 2 Oct 2024 15:20:36 +0000 Received: from localhost ([127.0.0.1]:59006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw19X-000779-6X for submit@debbugs.gnu.org; Wed, 02 Oct 2024 11:20:35 -0400 Received: from mail-pl1-f181.google.com ([209.85.214.181]:43146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw103-0006Z0-Bi for 72925@debbugs.gnu.org; Wed, 02 Oct 2024 11:10:48 -0400 Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-20b84bfbdfcso6966735ad.0 for <72925@debbugs.gnu.org>; Wed, 02 Oct 2024 08:10:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727881785; x=1728486585; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=L5byGQnOXpZXRvr7hBHqzhBkI/AdTYWNyjdDK2ACXo8=; b=RR03Ma75qJjgv1IagYAnrGCo/dk+W70mowNc+DNdstJ5FzxrJeaabKGD/SEqNbzuv4 0nX62V+fCqEfZtl53nSQm4tuLnOTbNFacY7rzrdJLm0Ce9JRrV/BmIRFAvZfnwh+kAy0 mxDAk+1f02xFyW6cqhV26+OOtQTjKcKqQ2lokAG3oLXFXUL4np6T9su1uxTJSP/OfEQR spEv4eCLgr1EZqjC0kBcokYQTjfUKs6yHRNZpSifM2PxS3AJehuBaYGCKwp6MKKa13LV V6O0b6n3kKf86quJ8xsfC0MTT2qEk3EwuKsBw5ONCXw+wWCQSF30eSMWozsNde4cWyd7 d3DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727881785; x=1728486585; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=L5byGQnOXpZXRvr7hBHqzhBkI/AdTYWNyjdDK2ACXo8=; b=duYQ7a6I5KI7MkhUobPMEq7o65O+LbgbN0m+99vzvdOz3gv+cXsaAJj6lItlrlYIKM lRBkCCwQv1GXAnX4JXGPnuM5jETCoP1Yzv+r1+iY6eYDJnqgf1ckxoWmiGg+DV4jy9Xx BOBKQQs9B7cu0XXNGsEs6s1od8iJorxHof/A4JQAXIVLT9G6RsBd2MK2HwFZXS6X8Rqo ZpcfEnH6vlS+pMJzNZ/p2FqyRSzn/NWs2O7WhKgMgl7CKkGq1fjdth3MSA18WJ5ouX2N FvO/Mzu/1pXPrxul1/wxrozpZT7VczKBazUUOgly0JQgdPvgkLAkZowBeXkJLYdC/AnN b/kQ== X-Gm-Message-State: AOJu0YyrJje1nOeJfc+T4m3YzJq+Y8T/UipY+zM35MaNeSALluR6BBVm zHV4cV/nMuxpt/N9iZvcNsOtTet1u/wsvf9GHGznPzvffm9+Vpc8zqqY8rdt10FYcL3zCeM3QU9 JP4wdVVuaj8hkG2alkAMQ3s8q9/k= X-Google-Smtp-Source: AGHT+IEjRx2SqspeVje1IACcBjEMrgouOXb7+/o7w0gsna2QPKfZxQDh0/kHHALsGL7Ni0pfFf1lpBMDYyhPFBMPhcc= X-Received: by 2002:a17:90a:d483:b0:2e0:8780:ecb with SMTP id 98e67ed59e1d1-2e18521f746mr5381751a91.12.1727881784429; Wed, 02 Oct 2024 08:09:44 -0700 (PDT) MIME-Version: 1.0 References: <4e623d9571ff648ae1d1c6ffb8f9d73c421a5c10.1727683810.git.omar.bassam88@gmail.com> <87plok7kkn.fsf@gmail.com> In-Reply-To: <87plok7kkn.fsf@gmail.com> From: Omar Bassam Date: Wed, 2 Oct 2024 18:09:33 +0300 Message-ID: Subject: Re: [bug#72925] [PATCH v3] adding jpm package To: Suhail Singh Content-Type: multipart/alternative; boundary="000000000000f9945e06237fd311" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 X-Mailman-Approved-At: Wed, 02 Oct 2024 11:20:22 -0400 Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Munyoki Kilyungi , Katherine Cox-Buday , Guillaume Le Vaillant , jgart X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --000000000000f9945e06237fd311 Content-Type: text/plain; charset="UTF-8" Hi Suhail, I just submitted a new patch (v7) applying your suggestions and running guix lint and guix style. regarding your questions. I'll try to answer them below: On Tue, 1 Oct 2024 at 03:07, Suhail Singh wrote: > Omar, thank you for sending a revised patch. I have a few comments > relating to style and one unanswered question from our last exchange. > > > Subject: [bug#72925] [PATCH v3] adding jpm package > > In v4, could you please update the commit message to conform to the > ChangeLog format as noted in > . > Please see > > > for additional details. If you're using magit, > `magit-generate-changelog' can help with this. > > In your case the commit will probably look something like: > #+begin_quote > gnu: Add jpm. > > * gnu/packages/lisp.scm (jpm): New variable. > #+end_quote > > Omar Bassam writes: > > > +(define-public jpm > > + (package > > + (name "jpm") > > + (version "1.1.0") > > + (source (origin > > + (method git-fetch) > > + (uri (git-reference > > + (url "https://github.com/janet-lang/jpm.git") > > + (commit (string-append "v" version)))) > > + (file-name (git-file-name name version)) > > + (sha256 (base32 > "05rdxigmiy7vf93s16a8n2029lq33073jccz1rjl4iisxj6piw4l")))) > > There are no build errors with this, however, it's not clear how to > verify that the runtime behaviour of jpm is as expected. After > installing janet and jpm in a guix profile, running a command such as: > > #+begin_src sh > jpm install sh > #+end_src > > Results in the following: > > #+begin_example > $> jpm install sh > error: Read-only file system: > /gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/.cache > in os/mkdir [src/core/os.c] on line 1981 > in download-bundle > [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/pm.janet] > on line 200, column 3 > in bundle-install > [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/pm.janet] > on line 217, column 13 > in resolve-bundle-name > [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/pm.janet] > on line 118, column 20 > in resolve-bundle > [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/pm.janet] > on line 148, column 9 > in bundle-install > [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/pm.janet] > on line 216, column 4 > in install > [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/commands.janet] > (tail call) on line 190, column 20 > in run-main [boot.janet] on line 4432, column 16 > in cli-main [boot.janet] on line 4613, column 17 > #+end_example > > Could you please share an example code snippet which can be used to > verify correctness of the installation? > > This is expected as the jpm install command is meant to install janet packages globally which would be impure. To install janet packages to your local project directory, you need to add the "-l" flag as follows: jpm install -l sh Alternatively you can also set the JPM_TREE environment variable to install to a custom directory that you have access to. Maybe in the future we can add a "janet-build-system" that will allow us to add janet packages to the guix repository. > Additionally, it seems that the jpm repository comes with a test > (./test/installtest.janet and ./testinstall). However, it doesn't seem > like we're running it during the build. Could you please share the > reasons why? If possible, we should enable and run these tests. > > These tests are not testing the installation of jpm, they are only testing the "jpm install" command which will not work as I explained above. > > + (build-system copy-build-system) > > + (arguments > > + (list > > + #:phases #~(modify-phases %standard-phases > > + (add-after 'unpack 'fix-prefix-path > > + (lambda _ > > + (substitute* "configs/linux_config.janet" > > + (("/usr/local") #$output)) > > + (setenv "PREFIX" #$output))) > > > + (replace 'install > > + (lambda _ > > V3 doesn't cleanly apply due to whitespace issues on this (^) line. > Please fix. > > On a related note, in case you're not aware, please observe all the > steps listed in > . > Steps 3 and 4 recommend invoking guix lint and guix style which, unless > I'm mistaken, would've caught this issue. > > -- > Suhail > --000000000000f9945e06237fd311 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Suhail,
I just submitte= d a new patch (v7) applying your suggestions and running guix lint and guix= style.
regarding your questions. I'll try to answer the= m below:

On Tue, 1 Oct 2024 at 03:07, Suhail Singh <suhailsingh247@gmail.com> wrote:
Omar, thank you fo= r sending a revised patch.=C2=A0 I have a few comments
relating to style and one unanswered question from our last exchange.

> Subject: [bug#72925] [PATCH v3] adding jpm package

In v4, could you please update the commit message to conform to the
ChangeLog format as noted in
<https://guix.gnu.org/manua= l/devel/en/html_node/Submitting-Patches.html>.
Please see
<https://www.gnu.org/pre= p/standards/html_node/Change-Logs.html#Change-Logs>
for additional details.=C2=A0 If you're using magit,
`magit-generate-changelog' can help with this.

In your case the commit will probably look something like:
#+begin_quote
=C2=A0 gnu: Add jpm.

=C2=A0 * gnu/packages/lisp.scm (jpm): New variable.
#+end_quote

Omar Bassam <omar.bassam88@gmail.com> writes:

> +(define-public jpm
> +=C2=A0 (package
> +=C2=A0 =C2=A0 (name "jpm")
> +=C2=A0 =C2=A0 (version "1.1.0")
> +=C2=A0 =C2=A0 (source (origin
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (method git-fetch) > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (uri (git-reference<= br> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (url "https://github.com/janet-lang/jpm.git") > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (commit (string-append "v" version))))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (file-name (git-file= -name name version))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (sha256 (base32 &quo= t;05rdxigmiy7vf93s16a8n2029lq33073jccz1rjl4iisxj6piw4l"))))

There are no build errors with this, however, it's not clear how to
verify that the runtime behaviour of jpm is as expected.=C2=A0 After
installing janet and jpm in a guix profile, running a command such as:

#+begin_src sh
=C2=A0 jpm install sh
#+end_src

Results in the following:

#+begin_example
=C2=A0 $> jpm install sh
=C2=A0 error: Read-only file system: /gnu/store/ffmis4y6rld42biqx5lq4nvsjp0= bqiq6-jpm-1.1.0/lib/janet/.cache
=C2=A0 =C2=A0 in os/mkdir [src/core/os.c] on line 1981
=C2=A0 =C2=A0 in download-bundle [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqi= q6-jpm-1.1.0/lib/janet/jpm/pm.janet] on line 200, column 3
=C2=A0 =C2=A0 in bundle-install [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq= 6-jpm-1.1.0/lib/janet/jpm/pm.janet] on line 217, column 13
=C2=A0 =C2=A0 in resolve-bundle-name [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp= 0bqiq6-jpm-1.1.0/lib/janet/jpm/pm.janet] on line 118, column 20
=C2=A0 =C2=A0 in resolve-bundle [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq= 6-jpm-1.1.0/lib/janet/jpm/pm.janet] on line 148, column 9
=C2=A0 =C2=A0 in bundle-install [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq= 6-jpm-1.1.0/lib/janet/jpm/pm.janet] on line 216, column 4
=C2=A0 =C2=A0 in install [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1= .1.0/lib/janet/jpm/commands.janet] (tail call) on line 190, column 20
=C2=A0 =C2=A0 in run-main [boot.janet] on line 4432, column 16
=C2=A0 =C2=A0 in cli-main [boot.janet] on line 4613, column 17
#+end_example

Could you please share an example code snippet which can be used to
verify correctness of the installation?


This is expected as the jpm install co= mmand is meant to install janet packages globally which would be impure.=C2= =A0
To install janet packages to your local project directory, yo= u need to add the "-l" flag as follows:
jpm install -l = sh

Alternatively you can also set the JPM_TREE env= ironment variable to install to a custom directory that you have access to.=

Maybe in the future we can add a "janet-buil= d-system" that will allow us to add janet packages to the guix reposit= ory.
=C2=A0
Additionally, it seems that the jpm repository comes with a test
(./test/installtest.janet and ./testinstall).=C2=A0 However, it doesn't= seem
like we're running it during the build.=C2=A0 Could you please share th= e
reasons why?=C2=A0 If possible, we should enable and run these tests.

=C2=A0
These tests are not testing the inst= allation of jpm, they are only testing the "jpm install" command = which will not work as I explained above.
=C2=A0
> +=C2=A0 =C2=A0 (build-system copy-build-system)
> +=C2=A0 =C2=A0 (arguments
> +=C2=A0 =C2=A0 =C2=A0(list
> +=C2=A0 =C2=A0 =C2=A0 #:phases #~(modify-phases %standard-phases
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (add-after &#= 39;unpack 'fix-prefix-path
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (lambd= a _
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (substitute* "configs/linux_config.janet"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 (("/usr/local") #$output))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (setenv "PREFIX" #$output)))

> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (replace '= ;install
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (lambd= a _

V3 doesn't cleanly apply due to whitespace issues on this (^) line.
Please fix.

On a related note, in case you're not aware, please observe all the
steps listed in
<https://guix.gnu.org/manua= l/devel/en/html_node/Submitting-Patches.html>.
Steps 3 and 4 recommend invoking guix lint and guix style which, unless
I'm mistaken, would've caught this issue.

--
Suhail
--000000000000f9945e06237fd311-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 02 14:22:28 2024 Received: (at 72925) by debbugs.gnu.org; 2 Oct 2024 18:22:29 +0000 Received: from localhost ([127.0.0.1]:59202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw3zY-0008P7-KJ for submit@debbugs.gnu.org; Wed, 02 Oct 2024 14:22:28 -0400 Received: from mail-qk1-f194.google.com ([209.85.222.194]:46493) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw3zX-0008Oz-7e for 72925@debbugs.gnu.org; Wed, 02 Oct 2024 14:22:27 -0400 Received: by mail-qk1-f194.google.com with SMTP id af79cd13be357-7a9ae0e116cso10479985a.1 for <72925@debbugs.gnu.org>; Wed, 02 Oct 2024 11:22:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727893286; x=1728498086; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=X2oZFXtsXwXWCnNmR3kLen8jPWcFpkDJWV4KTrQKqCs=; b=KQaC3gb/f487tjV931eHaK14y5AXg2mXa+LhQhoodqHs0cdhudT96XS9Hxj+RY8T46 JvSet42XboP9IEM3N/5FWV8+6P1fb3rPKXB+m1sBNZmCUNzd4+RL/W+5eaF+c5CWB46T ZPG00OhHeVcxpZ6CStFetwYYQPSd4k1GVdq1KnjVShjS3Zo/KkIqED6/pxbDl0RRAJkN oQjp9wmVRldgrYyN647wu4Jpjb6m40mgPTaA/LGNoJhV2Au7QMt5n47WmoBpOifBfoDT QeG9j2MxxJVyI3zdb8/38OMErcekNkjGCu3xL39CW0m01TezYDwZpAwCUu2q5K3WfE5L DdOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727893286; x=1728498086; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=X2oZFXtsXwXWCnNmR3kLen8jPWcFpkDJWV4KTrQKqCs=; b=FhD9/KHa2wY8uescbycx8217PXjG49mAcTlcfudH4FbgTaWt9u0rcr3UpM46cgDHAa DG5Mkf5QqxkoRSbjYr8JzbOuhqjKYmM2xmezq1lO1e1oouLMujitMi4tZQLu7HkZGklA q0p0qCYAgPw9HUAB723zeYXvL9Gbwy0sj6TyePrEWyoB3fzHG+RI1hTaB4CEbqthiygb bQ/Dxmd6340NNcsFo04Em0RBS033G5Sl08KbxfUarrfpPcERJvb565EHc5JFGGZtJ3jH S7cjJyFXRztmnoyxLBLIhAM3GwI9sIdEzU0jDI4Qehv/TKsIc05G2Yi0aKxi5njQyn3x zfwg== X-Forwarded-Encrypted: i=1; AJvYcCUqogwB1Wb84wlvTTGSIl+vAweGd4ZRn2AX7im7NPZmqMFFyaBxhCWpPjMyeYF+uV6wSX8IAA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyPfZ5QJEhAebNdZ/2p+fCp2TG2XaT1U1sgTKAfBsXFSzNoUYGp 6rhvEZpfx70K1JIduKHVIWe0Z9Cj+DW1ccFJNcm0AM2rN10pT1PI X-Google-Smtp-Source: AGHT+IFL4rDt/ZKU+LncB8vk/tKmUYYQpaY5BhO+CMktxLpjnXWV4nfu5Q06FEvgDpEukvqbJZLSLQ== X-Received: by 2002:a05:620a:4514:b0:7a9:b2dc:99a2 with SMTP id af79cd13be357-7ae62740c78mr603179385a.62.1727893285705; Wed, 02 Oct 2024 11:21:25 -0700 (PDT) Received: from gnus ([65.94.70.53]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7ae3782c6c0sm639034585a.88.2024.10.02.11.21.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Oct 2024 11:21:24 -0700 (PDT) From: Suhail Singh To: Omar Bassam Subject: Re: [bug#72925] [PATCH v3] adding jpm package In-Reply-To: (Omar Bassam's message of "Wed, 2 Oct 2024 18:09:33 +0300") References: <4e623d9571ff648ae1d1c6ffb8f9d73c421a5c10.1727683810.git.omar.bassam88@gmail.com> <87plok7kkn.fsf@gmail.com> Date: Wed, 02 Oct 2024 14:21:13 -0400 Message-ID: <8734lev012.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Munyoki Kilyungi , Katherine Cox-Buday , Guillaume Le Vaillant , jgart , Suhail Singh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Omar Bassam writes: > This is expected as the jpm install command is meant to install janet > packages globally which would be impure. It would help for this to be noted in some manner. Be it in the description or as comments in the package description. > To install janet packages to your local project directory, you need to add > the "-l" flag as follows: > jpm install -l sh Does this work for you (for jpm installed via guix)? If so, could you please confirm the set of dependencies you have installed in the guix profile for the above to work? If not, could you provide an example invocation that I could test out which would allow me to install a janet dependency in a local directory? > Maybe in the future we can add a "janet-build-system" that will allow us to > add janet packages to the guix repository. That would be helpful. -- Suhail From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 02 15:04:28 2024 Received: (at 72925) by debbugs.gnu.org; 2 Oct 2024 19:04:28 +0000 Received: from localhost ([127.0.0.1]:59252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw4eC-0002Gi-Aq for submit@debbugs.gnu.org; Wed, 02 Oct 2024 15:04:28 -0400 Received: from mx1.dismail.de ([78.46.223.134]:22223) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw4e9-0002GS-Ha for 72925@debbugs.gnu.org; Wed, 02 Oct 2024 15:04:26 -0400 Received: from mx1.dismail.de (localhost [127.0.0.1]) by mx1.dismail.de (OpenSMTPD) with ESMTP id de9c1808; Wed, 2 Oct 2024 21:04:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h= mime-version:date:content-type:from:message-id:subject:to:cc :in-reply-to:references; s=20190914; bh=RSOxGEKsSARbE7vZ3oJvcfCg VkNwtLoaIYESng1TBRc=; b=uScMEglEEFJEv6LH4fcCZLd8q0XOaU1wmurtolWv Aq7z6jigyRA19l+pCFf5vdv7KqKoRWQ755mH9sG5tHCqoZ3Lef9PRWUQs8+pZGRn Gzwr3S2cxpHa6y73tPEo679M4eHZWE72JENiA95lmj9DlbzOdit/68l9d7scdJ6p L3Zn0RnFNpRlivpgDDSfwIrqo5CZ7Clb0Nc4DBWyJXLSCnhGC70vDbgOHcxWp9Gu YR3CqaJxbXJwX4tnerpM7fr+aiWlXs4ViCORr9aUKMcuobw91jExtENTMDuVwXx5 0cRaqKTfJtd7Bpylu3lgyhxBNT4UZbawM7eNdxAVPGYaDw== Received: from smtp1.dismail.de ( [10.240.26.11]) by mx1.dismail.de (OpenSMTPD) with ESMTP id b23442ad; Wed, 2 Oct 2024 21:04:15 +0200 (CEST) Received: from smtp1.dismail.de (localhost [127.0.0.1]) by smtp1.dismail.de (OpenSMTPD) with ESMTP id 512f3123; Wed, 2 Oct 2024 21:04:15 +0200 (CEST) Received: by dismail.de (OpenSMTPD) with ESMTPSA id e119d064 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 2 Oct 2024 21:04:14 +0200 (CEST) MIME-Version: 1.0 Date: Wed, 02 Oct 2024 19:04:14 +0000 Content-Type: multipart/alternative; boundary="549401ca-bad7-4b05-b914-45dc83707215-1" From: "jgart" Message-ID: TLS-Required: No Subject: Re: [bug#72925] [PATCH v3] adding jpm package To: "Suhail Singh" , "Omar Bassam" In-Reply-To: <8734lev012.fsf@gmail.com> References: <4e623d9571ff648ae1d1c6ffb8f9d73c421a5c10.1727683810.git.omar.bassam88@gmail.com> <87plok7kkn.fsf@gmail.com> <8734lev012.fsf@gmail.com> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 72925 Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Munyoki Kilyungi , Katherine Cox-Buday , Guillaume Le Vaillant , Suhail Singh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --549401ca-bad7-4b05-b914-45dc83707215-1 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable (un)related to this, what do people think of having language specific guides for using `guix s= hell` with particular programming languages? not unlike this Nix guide that shows how to use Python in a `nix shell` t= o develop on a flask application: https://nix.dev/guides/recipes/python-environment.html would be cool to document the expected workflow for a Guix user using jpm= and guix to develop on janet software, for example. we can continue my thought on #guix-devel didn't mean to distract ;() wdyt, jgart https://whereis.xn--q9jyb4c/ --549401ca-bad7-4b05-b914-45dc83707215-1 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable
(un)related to this,

what do people think of having language specific gu= ides for using `guix shell` with particular programming languages?

not unlike this Nix guide that shows how to use Py= thon in a `nix shell` to develop on a flask application:
https://nix.dev/guides/recipes/python-environment.html

would be cool to document the expected workflow for= a Guix user using jpm and guix to develop on janet software, for example= .

we can continue my thought on #guix-devel = didn't mean to distract ;()

wdyt,
<= div>
jgart


=

--549401ca-bad7-4b05-b914-45dc83707215-1-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 02 16:15:37 2024 Received: (at 72925) by debbugs.gnu.org; 2 Oct 2024 20:15:37 +0000 Received: from localhost ([127.0.0.1]:59345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw5l3-0006ff-8j for submit@debbugs.gnu.org; Wed, 02 Oct 2024 16:15:37 -0400 Received: from mail-yb1-f193.google.com ([209.85.219.193]:49164) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw5l0-0006fW-Su for 72925@debbugs.gnu.org; Wed, 02 Oct 2024 16:15:35 -0400 Received: by mail-yb1-f193.google.com with SMTP id 3f1490d57ef6-e25e4023cafso181033276.2 for <72925@debbugs.gnu.org>; Wed, 02 Oct 2024 13:15:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727900073; x=1728504873; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=iwxL2u6MroNuH/bK2neTq74tD4utEuKD+ddiWdCEKqQ=; b=ZzZ7nHobDBVpB7OIU92tRTI8gnhm7lkG5VL8ExwCoY5bZRYow0U08mubbk0ZxbnryR 51+lScElNQ9IghfcnsCBoNTs431YdLnZJKzlplkqJLx+2dYesZkyZxInUhuw7KEfjtVw R9sZK4sCEsmTwaYiZqYAfJ65D2Q5rcBs+wfiaVtiyYbLc21hiuubs2J+La1Fgk8MpELy xXE+w1wDX5jLyTcxOesqPxCy02IoS6gPc/bB7h4DFbBNtfhgqjaotSDI08k7h7MuCLUX wuu0F4r9MvxiXEYTr/Z8m3HapN+Z9iIVHWvDh5gX7UcbuthPruvKVgiMbSEIFd4RodXo lrCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727900073; x=1728504873; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iwxL2u6MroNuH/bK2neTq74tD4utEuKD+ddiWdCEKqQ=; b=RWcTU3ev16I/587xkNUyw0S9O/esfq1PRV7mga3sJ7L/beOuppWZ5El6uiuLKYjptz gvbEdrUspzvI1cbXUbnnPanOjBkwJbdacoSsR3vaxyJ9Bye4Fo7DB75SlVGsc3ltiDnQ KMVfBUuowAPIoKB8rqTGd7M+g1Opx9SDgKA+f9rjjzGz5tsqOZcOB3Dj+D+TSJDgNxrL /RjMDdCupc+w+Y49Y3wlaraypP1y1yCLDbE1dI2RC/c17bOUJ9SLD8oSf5qLD34aVYLF BdTA8vQKHtQN2vHEQVE1eglGdA4bsiI3y8xuKQjru2ZMpj4Ce5N9dY13Cs07MHuX3DzV l+Vg== X-Forwarded-Encrypted: i=1; AJvYcCU5HKT6FzWnG4ViAJvFO1Wku9bSvTvphwcIBCleR85F6JBpxbYgonsbw3aBKdgo3bUEmuFdwA==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yy/OrSU7mYKaFQaTPkUgIecdjQBGZWm/eWAbPRnGew6UeVr2H4t zgrVeHc/9VZIs6avuE/+y4DhMm7PsVFoX4hfEuf/l6OXmebfFSsl X-Google-Smtp-Source: AGHT+IENvI1yZnCf3Qfd64ujpObnyL9xKp94pP2aIJTVclxEnUgi6lDn7pFh7AimqKAfNdfTYQpS6Q== X-Received: by 2002:a05:6902:1009:b0:e1d:c175:5efd with SMTP id 3f1490d57ef6-e263843ad97mr3443079276.50.1727900073103; Wed, 02 Oct 2024 13:14:33 -0700 (PDT) Received: from gnus (bras-base-mtrlpq0776w-grc-23-65-94-70-53.dsl.bell.ca. [65.94.70.53]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-45c9f2b6d3fsm59788501cf.28.2024.10.02.13.14.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Oct 2024 13:14:32 -0700 (PDT) From: Suhail Singh To: Omar Bassam Subject: Re: [bug#72925] [PATCH v3] adding jpm package In-Reply-To: (Omar Bassam's message of "Wed, 2 Oct 2024 22:12:56 +0300") References: <4e623d9571ff648ae1d1c6ffb8f9d73c421a5c10.1727683810.git.omar.bassam88@gmail.com> <87plok7kkn.fsf@gmail.com> <8734lev012.fsf@gmail.com> Date: Wed, 02 Oct 2024 16:14:29 -0400 Message-ID: <875xqanty2.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Munyoki Kilyungi , Katherine Cox-Buday , Guillaume Le Vaillant , jgart , Suhail Singh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Omar Bassam writes: >> > This is expected as the jpm install command is meant to install janet >> > packages globally which would be impure. >> >> It would help for this to be noted in some manner. Be it in the >> description or as comments in the package description. > > I don't think this needs to be said because all package managers installed > via guix have this issue. For me, someone familiar with Guix, but unfamiliar with Janet and JPM defaults, it wasn't obvious that I needed to add "-l" to the invocation. I don't believe such a message is necessary, but it would be helpful to some (those individuals who aren't familiar with both JPM and Guix). > Also, there is no one way to solve this because jpm gives you the freedom > to install packages on a user level > or on a project only level. The fact that JPM doesn't install packages at a user level by default was not something I knew previously. >> > To install janet packages to your local project directory, you need to >> add >> > the "-l" flag as follows: >> > jpm install -l sh >> >> Does this work for you (for jpm installed via guix)? If so, could you >> please confirm the set of dependencies you have installed in the guix >> profile for the above to work? If not, could you provide an example >> invocation that I could test out which would allow me to install a janet >> dependency in a local directory? > > Do you still get the same error? No, a different one. > Yes, this does work for me without any other dependencies. I am using guix > on ubuntu with guix shell. I am running guix-shell (--pure) with the following dependencies installed: - janet - gcc-toolchain gcc-toolchain:static - openssl - git - jpm - bash coreutils - curl nss-certs With the above, when running "jpm --local install sh" I observe the following error: #+begin_example error: ( "cc" "-std=c99" "-I/gnu/store/rdlvs1p09brkk961lj3vncifb4xlsmm5-janet-1.36.0/include/janet" "-I/tmp/review-72925/jpm_tree/lib" "-O2" "-o" "build/_jmod_posix_spawn.so" "build/posix-spawn.o" "-shared" "-pthread"): No such file or directory error: build fail in pdag [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/dagbuild.janet] (tail call) on line 79, column 23 in with-dyns [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/pm.janet] on line 236, column 9 in defer [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/pm.janet] on line 221, column 5 in bundle-install [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/pm.janet] on line 219, column 3 in with-dyns [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/pm.janet] on line 234, column 13 in defer [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/pm.janet] on line 221, column 5 in bundle-install [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/pm.janet] on line 219, column 3 in install [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/commands.janet] (tail call) on line 190, column 20 in run-main [boot.janet] on line 4432, column 16 in cli-main [boot.janet] on line 4613, column 17 #+end_example When running "jpm --cc=gcc --local install sh" I get the same error. I was finally able to get it to succeed by having cc symlink to gcc and adding the directory containing the symlink to PATH. So I believe that the package definition you've submitted is correct. However, I'm wondering what (if anything) needs to be done about the issue I encountered. Specifically, it's unclear why passing "-cc=gcc" didn't work (nor did setting "CC=gcc", but perhaps JPM ignores the latter?). Is this an upstream bug? Were my expectations misplaced? Should the JPM package in Guix provide "cc" as well? -- Suhail From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 02 16:27:56 2024 Received: (at 72925) by debbugs.gnu.org; 2 Oct 2024 20:27:57 +0000 Received: from localhost ([127.0.0.1]:59360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw5wy-0007II-Ks for submit@debbugs.gnu.org; Wed, 02 Oct 2024 16:27:56 -0400 Received: from mx2.dismail.de ([159.69.191.136]:33944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw5wv-0007Hv-JW for 72925@debbugs.gnu.org; Wed, 02 Oct 2024 16:27:55 -0400 Received: from mx2.dismail.de (localhost [127.0.0.1]) by mx2.dismail.de (OpenSMTPD) with ESMTP id 16cb2ad7; Wed, 2 Oct 2024 22:27:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h= mime-version:date:content-type:from:message-id:subject:to:cc :in-reply-to:references; s=20190914; bh=tFwx7524q8vqNmryf2gufxmw F8tHiJT0f5H9NL47axA=; b=r0D3Zn30GsGJRcgfYCi3K/UfZVr00sK/5KjKDF0o c0/6q5tGTy/zjHkRcdRJYo9YUc5rvuyCniZOPPFzOyvzYszhn9GmSTw4qaCS2feD NiF0VJuDtDdI/2xHACW7bhSAB6PvrX4MMirFZr0OSG+RpmL/eZkghi1xl5qHYUcv SxmxFDojVkWHPKhWgVORerN11PW3yH+EapqhaOlp9oA0LdcdnLTclN+OK0qasgTF 1EWqDveL4O7vAwNk/3jt8D68yAef6A8AB7GXV7IiG8TE9EOn/A6Ti2neGrnf9gfN OvphHsefQuTSHQpo7S5qbEyetlLQPOqcAisyEuA66a6vVQ== Received: from smtp1.dismail.de ( [10.240.26.11]) by mx2.dismail.de (OpenSMTPD) with ESMTP id ed206231; Wed, 2 Oct 2024 22:27:45 +0200 (CEST) Received: from smtp1.dismail.de (localhost [127.0.0.1]) by smtp1.dismail.de (OpenSMTPD) with ESMTP id 7d744a3b; Wed, 2 Oct 2024 22:27:45 +0200 (CEST) Received: by dismail.de (OpenSMTPD) with ESMTPSA id c6fbedae (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 2 Oct 2024 22:27:44 +0200 (CEST) MIME-Version: 1.0 Date: Wed, 02 Oct 2024 20:27:43 +0000 Content-Type: multipart/alternative; boundary="5cd504e3-ae85-4c66-b21b-474f971c46d4-1" From: "jgart" Message-ID: <0a8758f3974bdfdb2bd19a87de60c0d65fa824b4@dismail.de> TLS-Required: No Subject: Re: [bug#72925] [PATCH v3] adding jpm package To: "Suhail Singh" , "Omar Bassam" In-Reply-To: <875xqanty2.fsf@gmail.com> References: <4e623d9571ff648ae1d1c6ffb8f9d73c421a5c10.1727683810.git.omar.bassam88@gmail.com> <87plok7kkn.fsf@gmail.com> <8734lev012.fsf@gmail.com> <875xqanty2.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72925 Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Munyoki Kilyungi , Katherine Cox-Buday , Guillaume Le Vaillant , Suhail Singh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --5cd504e3-ae85-4c66-b21b-474f971c46d4-1 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable >=20 >=20upstream bug? Were my expectations misplaced? >=20 Suhail, These=20are all very good points. Excuse the brevity as i am going on a hiking trip and need to prepare now= , jgart PS. I'll be away till the 8th. https://whereis.xn--q9jyb4c/ --5cd504e3-ae85-4c66-b21b-474f971c46d4-1 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable
upstream bug? Were m= y expectations misplaced?

Suhail,

These are all very good points.
=
Excuse the brevity as i am going on a hiking trip and need= to prepare now,

jgart

PS. I'll be away till the 8th.

https://whereis.xn--q9jyb4c/
<= /div>

--5cd504e3-ae85-4c66-b21b-474f971c46d4-1-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 02 16:34:11 2024 Received: (at 72925) by debbugs.gnu.org; 2 Oct 2024 20:34:11 +0000 Received: from localhost ([127.0.0.1]:59372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw631-0007lp-4w for submit@debbugs.gnu.org; Wed, 02 Oct 2024 16:34:11 -0400 Received: from mx1.dismail.de ([78.46.223.134]:36434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw62y-0007lW-08 for 72925@debbugs.gnu.org; Wed, 02 Oct 2024 16:34:09 -0400 Received: from mx1.dismail.de (localhost [127.0.0.1]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 7323e660; Wed, 2 Oct 2024 22:33:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h= mime-version:date:content-type:from:message-id:subject:to:cc :in-reply-to:references; s=20190914; bh=CumMgsEVN80EfS8S1BbTNpsX pPr0Ruk5IYjLmEfeI5o=; b=ZzFatOqlPmNLZLQGKaQx37o+o7Ta0DlMugGhypFs 7aWWiB/at6RsjU79q7re/xDgt24QGCgtSGDV7IppbroOc2VoKCUsa/KUlSI5Htn4 ULdR1spYYUdgAU0yxuxXYzLJ8LnXBAIE4V1c3kksbq+g5/tB1uV8mzsjKllXnduT D0/4EUMjIvtoAwmnna6xD/pS3Oq1hRDM7XAZ6G+8Atqr1BO9AePlz28urdtAVeaG V4DUjZ1u6PhE4A7yNYjOFh4+/Oaa1Pp3RzbOPJTGQbOpCmSDPzgDSldbrY2PvQY6 p8ep/hobDFa8F6oxr4byQXgWDNHwcWvOCGmY28SfuLTyrw== Received: from smtp2.dismail.de ( [10.240.26.12]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 97165137; Wed, 2 Oct 2024 22:33:59 +0200 (CEST) Received: from smtp2.dismail.de (localhost [127.0.0.1]) by smtp2.dismail.de (OpenSMTPD) with ESMTP id c2a7fece; Wed, 2 Oct 2024 22:33:59 +0200 (CEST) Received: by dismail.de (OpenSMTPD) with ESMTPSA id e3f1193a (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 2 Oct 2024 22:33:58 +0200 (CEST) MIME-Version: 1.0 Date: Wed, 02 Oct 2024 20:33:57 +0000 Content-Type: multipart/alternative; boundary="acfc7d5a-65b4-40fe-be05-cdb58399ea59-1" From: "jgart" Message-ID: TLS-Required: No Subject: Re: [bug#72925] [PATCH v3] adding jpm package To: "Omar Bassam" , "Suhail Singh" In-Reply-To: References: <4e623d9571ff648ae1d1c6ffb8f9d73c421a5c10.1727683810.git.omar.bassam88@gmail.com> <87plok7kkn.fsf@gmail.com> <8734lev012.fsf@gmail.com> <875xqanty2.fsf@gmail.com> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 72925 Cc: 72925@debbugs.gnu.org, Guillaume Le Vaillant , Munyoki Kilyungi , Katherine Cox-Buday , Sharlatan Hellseher X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --acfc7d5a-65b4-40fe-be05-cdb58399ea59-1 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable >=20 >=20This is where jgart suggestion would be really helpful. I am personal= ly working on a project > https://lisp-spectrum.org/ where I try to document all the struggles th= at I had with the Lisp ecosystem > and try to make it more accessible to new users. (Any contributions are= welcomed of course). > =C2=A0 >=20 >=20>=20 >=20>=20 >=20> >=20 That's=20a cool site. Let me get back to you on it once I am back from my= hiking trip. Thanks for sharing. I usually hang out at #whereiseveryone on irc.libera.= chat. Feel free to join me there or send me a personal email or I will once I a= m back on the 8th. all best, jgart https://whereis.xn--q9jyb4c/ --acfc7d5a-65b4-40fe-be05-cdb58399ea59-1 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable
This is where jgart suggestion would be really helpful. I am person= ally working on a project
https://lisp-spectrum.org/ wh= ere I try to document all the struggles that I had with the Lisp ecosyste= m
and try to make it more accessible to new users. (Any con= tributions are welcomed of course).
=C2=A0


That's a co= ol site. Let me get back to you on it once I am back from my hiking trip.=

Thanks for sharing. I usually hang out at #= whereiseveryone on irc.libera.chat.

Feel fre= e to join me there or send me a personal email or I will once I am back o= n the 8th.

all best,

jgart


= --acfc7d5a-65b4-40fe-be05-cdb58399ea59-1-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 02 17:40:55 2024 Received: (at 72925) by debbugs.gnu.org; 2 Oct 2024 21:40:55 +0000 Received: from localhost ([127.0.0.1]:59412 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw75b-000379-Ga for submit@debbugs.gnu.org; Wed, 02 Oct 2024 17:40:55 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:51476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw75Z-00036t-J6 for 72925@debbugs.gnu.org; Wed, 02 Oct 2024 17:40:54 -0400 Received: by mail-qt1-f194.google.com with SMTP id d75a77b69052e-4582c62ee33so1594501cf.3 for <72925@debbugs.gnu.org>; Wed, 02 Oct 2024 14:40:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727905187; x=1728509987; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=F0vtjmJ2Ty3K7ld+quiBOVL1WFwsh8pFZMfQztfjneE=; b=H2CKwUR5p263k641yXzAWM4PytNjZPyxAeqIOMtKwvFkIBf5yCigPQ9ucnCqSzthS/ 0curwxiIiWZtevSeuHF10dDtfzKNoBkmFe7Ls8EAgsrOBfw4+5NH3FfnRFVdy1no4QQn ejt7y2BFCWByfOeycmqFG5V4qNPeEGuonUPlrdVIftWc73637JcVcd6lxeIAZU/7cZ7x aZKKhZlT8xzND6Qe2CiKDaBVfYaBB2Yd7HhQlnaoXHN49ipGVny6sSRETbhLIB+Xtj9c ugo/0a/Dkv3JoJhAfKBz3bo1sAlbmSSwn2GoA9hGfBuaB3+d+efNxYNIAtgfnJ6f56VC eutQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727905187; x=1728509987; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=F0vtjmJ2Ty3K7ld+quiBOVL1WFwsh8pFZMfQztfjneE=; b=egg/F2JjMaL9y1hCmIfwL+zplxvpIabXODgeG62H5wlFrEX8RrXcWOJm8w4cDNYV6I gNu2e3KR2uNO1eo8YDGXAb9yEFFJ/DGZjXOvxaXAubx66AMIbr5WRYUzmSe83dtpnvDI 1FOH/6SDg0JZOFshTF7OPiC7zKgHKhq1RMPL/mR3wPJReZz3K3HHBYp57hWe8zI4h9qc c9HL8tWC4zUIxiIOmh6njf7ZBzNBFVL+ncGCOng+HJn3PbUt12rHfhT1O5vUHywCMDhw A46A4iIcrBbBuuMr2KTGbpnBr9OxEPjuayfEPG+PLWDs8cqgn20E9cxqvvI8Y3FF3W2o KUXw== X-Forwarded-Encrypted: i=1; AJvYcCUvjRObhMss9c2a8wRbLK1iuwuIknDy3EnmIidcn/Ck+0l+lilwdM6yYyLoMxSskiqfarXCHA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxU6kf0/gV7zHH/YV9IPfXlH55778CEGlp7DR/3WE0gZoEIs6fB 50jKrU2uUcvay1W/oTw3A/hJ1GjcrC4oxwduBwjSI/1lFPloQezv X-Google-Smtp-Source: AGHT+IFG/OqLRwEM1gDNLlCyM7GRN5CMuYJGOSEbEgtDKg87iYqljw7WBSANmfCAHFMkppj+4I2Xrg== X-Received: by 2002:ac8:5854:0:b0:45c:a601:4474 with SMTP id d75a77b69052e-45d80494364mr62491531cf.4.1727905187055; Wed, 02 Oct 2024 14:39:47 -0700 (PDT) Received: from gnus (bras-base-mtrlpq0776w-grc-23-65-94-70-53.dsl.bell.ca. [65.94.70.53]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-45c9f2e3fc3sm59928771cf.53.2024.10.02.14.39.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Oct 2024 14:39:46 -0700 (PDT) From: Suhail Singh To: Omar Bassam Subject: Re: [bug#72925] [PATCH v3] adding jpm package In-Reply-To: (Omar Bassam's message of "Wed, 2 Oct 2024 23:27:00 +0300") References: <4e623d9571ff648ae1d1c6ffb8f9d73c421a5c10.1727683810.git.omar.bassam88@gmail.com> <87plok7kkn.fsf@gmail.com> <8734lev012.fsf@gmail.com> <875xqanty2.fsf@gmail.com> Date: Wed, 02 Oct 2024 17:39:45 -0400 Message-ID: <87cyki9obi.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Munyoki Kilyungi , Katherine Cox-Buday , Guillaume Le Vaillant , jgart , Suhail Singh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Omar Bassam writes: >> When running "jpm --cc=gcc --local install sh" I get the same error. >> >> I was finally able to get it to succeed by having cc symlink to gcc and >> adding the directory containing the symlink to PATH. So I believe that >> the package definition you've submitted is correct. However, I'm >> wondering what (if anything) needs to be done about the issue I >> encountered. >> >> Specifically, it's unclear why passing "-cc=gcc" didn't work (nor did >> setting "CC=gcc", but perhaps JPM ignores the latter?). Is this an >> upstream bug? Were my expectations misplaced? Should the JPM package >> in Guix provide "cc" as well? >> > > No, this is not really a Janet or JPM issue but rather the fact that > you are overriding the gcc compiler with a symlinked binary instead of > the absolute path. I don't understand. All four variants below fail in exactly the same way: #+begin_src sh jpm --cc=gcc -l install sh #+end_src #+begin_src sh jpm --cc=/home/user/.guix-profile/bin/gcc -l install sh #+end_src #+begin_src sh jpm --cc=/gnu/store/x2kv3zw2k7ql211m5kvb6yw401gab0x9-gcc-toolchain-14.2.0/bin/gcc -l install sh #+end_src #+begin_src sh jpm --cc=/gnu/store/lq9y7sd4mvffs4hqp3hkr9fnd384pnkj-gcc-14.2.0/bin/gcc -l install sh #+end_src Note that the last variant uses an absolute path. Either I'm not using the "--cc" option correctly. Or for some dependency of "sh" (specifically, posix-spawn) the compiler has been hardcoded to "cc" and it's not picking up the option being passed to jpm. Further, if the above work for you in a "--pure" guix shell (where it doesn't for me), that's surprising. It is _only_ when I provide a fake "cc" (which is simply a symlink to gcc) that things work. -- Suhail From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 02 18:09:13 2024 Received: (at 72925) by debbugs.gnu.org; 2 Oct 2024 22:09:13 +0000 Received: from localhost ([127.0.0.1]:59447 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw7Wy-0004Xi-Pq for submit@debbugs.gnu.org; Wed, 02 Oct 2024 18:09:13 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:61759) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw7Wx-0004XT-0D for 72925@debbugs.gnu.org; Wed, 02 Oct 2024 18:09:11 -0400 Received: by mail-qt1-f193.google.com with SMTP id d75a77b69052e-4581ec0e00eso1637581cf.3 for <72925@debbugs.gnu.org>; Wed, 02 Oct 2024 15:09:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727906884; x=1728511684; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=2UStIK2F/ZkODdAz7AlDxYzszRzVrJxCmvYdBNHRSQQ=; b=Y0hAcPv59APQmy+bpkpvQixSP5v8g+fu8FXiC+RCHY0I2Uw6mmnnGrJxGvSx6MDJBs xnMA6bM22RRHVbzioEM45/PnWxVJZdrUQ1XXtXDRxJ4EtkFUtilQvtw5zNz8EMe1FNG1 sFK1FTB13NpAtQ3ApXq62MQZP+OBWXYZfhsCZDDtbxeS+dftxsWo7CqPhoAi9cpIWsvp hBRUg8nl/Sg/98SqEDhUtZft9dgmTHgpOzcAxLrKLgmzBje0niN6LTMPtz4eYhxvBMTl 8YPBmVwrb3exXtYNt6DerAuYydVM8VbeUglsdrPX5Pp9x7LCd68CqLEdDEOrD7QKp/GZ Qwag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727906884; x=1728511684; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2UStIK2F/ZkODdAz7AlDxYzszRzVrJxCmvYdBNHRSQQ=; b=k3pXH3Lu7Hgh1IHn8MnsLPgnblFtHufvCeFeJUAL41NxoqSLAr5b0/TlD9FBeubeqW sKv+q5TgRSLcJhk7kfd5X5bk1NDrp7p7ll/Ie56xVh5FUf10Wv1hKH+a4DGXhKhOAMUG LayYcRGswKNO1ohWD1DUFTGbj9+ZyeUi4uiCrXieTrfhcRJxoyJkLIoRWuo5bS5cfPJg GlWq8Ri734RF83sxitXe2wLs8XlKnfOblRVx4Kj9o6TVNpWVCiSYREOUc9YW7kP3DHW/ p0TNjzuEJDkpwHs9GKQarlE04KDupzRCq1E6Kj4TG2TsAHVM8AOkjOP5cyGyNn/tawik 6tQQ== X-Forwarded-Encrypted: i=1; AJvYcCVuxiQ43nh4l0VAuCp3nnucaBaRFDbXY4lfidDjzbkJbYyYNLWo74Djqe6UnUH3DU3b70jlVQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yy8ikaoeomcQKUc1AIY7umpC+VWbJBOsXZVgVxaJ3fgOwo3YK7F iRy56chAMklgIL+WQtte9J/ElzKHEwDVjRFL8xhbUOA2kWcGNQPI X-Google-Smtp-Source: AGHT+IEcq2ZMG/5FknqWobn5Ky8Qy44xg2cay9esIeeoS9RRto8v1RK0nmchf2q9t6H/furuaVofzQ== X-Received: by 2002:a05:6214:570d:b0:6c7:c12a:8dad with SMTP id 6a1803df08f44-6cb81a15783mr68796086d6.27.1727906884387; Wed, 02 Oct 2024 15:08:04 -0700 (PDT) Received: from gnus ([65.94.70.53]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6cb3b632366sm65919436d6.71.2024.10.02.15.08.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Oct 2024 15:08:03 -0700 (PDT) From: Suhail Singh To: Omar Bassam Subject: Re: [bug#72925] [PATCH v3] adding jpm package In-Reply-To: (Omar Bassam's message of "Thu, 3 Oct 2024 00:52:16 +0300") References: <4e623d9571ff648ae1d1c6ffb8f9d73c421a5c10.1727683810.git.omar.bassam88@gmail.com> <87plok7kkn.fsf@gmail.com> <8734lev012.fsf@gmail.com> <875xqanty2.fsf@gmail.com> <87cyki9obi.fsf@gmail.com> Date: Wed, 02 Oct 2024 18:07:51 -0400 Message-ID: <878qv69n0o.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Munyoki Kilyungi , Katherine Cox-Buday , Guillaume Le Vaillant , jgart , Suhail Singh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Omar Bassam writes: > I don't think this should be related to this patch. As I mentioned previously, I believe your packaging of "jpm" is correctly done. I was hoping to get some understanding as to why it doesn't work as expected, however. > Also, if you are running a guix shell with --pure flag, try adding > coreutils to your shell because jpm calls the "cp" command when building > libraries. As noted previously, coreutils is included as a dependency in the profile. > I tried with "jpm install -l spork" and with "jpm install -l sh" and it > works fine. Both fail for me. Is my understanding correct that you're not using a "--pure" shell and, thus, have "cc" provided by the system? Could you please share the output of "type cc" in the environment where you ran the above jpm commands? > I believe the --cc flag is meant to be used for the jpm build command. Even though it's listed under "Global options" for jpm? Interesting. If true, that would certainly explain why passing --cc didn't seem to help. -- Suhail From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 02 21:41:31 2024 Received: (at 72925) by debbugs.gnu.org; 3 Oct 2024 01:41:31 +0000 Received: from localhost ([127.0.0.1]:59546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swAqR-0007Pr-Gb for submit@debbugs.gnu.org; Wed, 02 Oct 2024 21:41:31 -0400 Received: from mail-qv1-f67.google.com ([209.85.219.67]:57676) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swAqP-0007PY-9u for 72925@debbugs.gnu.org; Wed, 02 Oct 2024 21:41:30 -0400 Received: by mail-qv1-f67.google.com with SMTP id 6a1803df08f44-6cb2ad51162so3696126d6.3 for <72925@debbugs.gnu.org>; Wed, 02 Oct 2024 18:41:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727919622; x=1728524422; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=twpw359G7PTOZeL2Ar4RRG3HMXxNtmwSGT4JAlh2how=; b=CRReZR5yipG7e9sg6B9VYwVdmiij+6S8OUJPqleIbKYon/qKW5elI/vIDqupy7OPYW Fi/bdDUTgslQ19NFfCv9YK7XzznsqBVltqWa+QY9IQ0z6K16CzR+BYza2jvSxqZSzx6d s+z+qcigxJ2p6LJF5yK5qetX0alXly3cI80jqPQb4R/tHU9+ArxIZE3oc0e9jOs3Lo24 Qd5nboVIyVSru2CLL+IXcBEEogJ5+ESmmfRMpf+bePNymYm1jfJtPGmUjR3rscrzoX5p f6Ga/nTELG1hBGPCEBqvTeVmULs26E3w6JlgkHkd1ZWL1KTEP4vj9Ml76sZRGqranZ2H 5f1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727919622; x=1728524422; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=twpw359G7PTOZeL2Ar4RRG3HMXxNtmwSGT4JAlh2how=; b=U8klELwpEPRSR6i7nVpkA3MoulyAXrj1vXrj+uzWqcUFqOXEfjKKTaEtv+w82D3Or3 pLcUDFyzZdzLsaZkpRcZY7m3NUpcT6n02pLTomt2KZQaVX+ZDrxPLGh7PrUX3ameJPu1 NZHvbUg27DcF/woHqPodNiBuYCmjIK90c944RQ/WzQH0wqUE7s3MTRGxICg8CXOw8zQB rpeaRL1C/0pQhhmnfeA8OvHapmcBaqkm1xJNZEDw/IfbOW9OQio4sRCHZTm7a1/pNyoL WoQlbPCEyzGWQvKNx/le6l0CinMQtXHjHv98nQU7IfYReShLVzpO8HU3eewkT5gj/+FS MI7g== X-Forwarded-Encrypted: i=1; AJvYcCVrpycCExQrSABkj4hCCEFi1z7qP2mGQsceM+Mhz9x8mrSiMsQ6PIZnNfbPCN7hlpmoH9MW5g==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzzlnPcUSj+POWlP+IQiNeRDyQLzYbDpYRlxujO4nt+TyfQ7ofs 9j/BiQeEJxAV2ijH84zNaHsmJtWYHkSFuikyU0jzMHH6rT5irP2t X-Google-Smtp-Source: AGHT+IEyB6ndn66NGmNqxQwPmjRUBBshCWwcILwL3aPWt+GaaFbSDyV5alNy7TtsZ1RGDNwgZDn/UA== X-Received: by 2002:a05:6214:3bc8:b0:6cb:4c76:59a5 with SMTP id 6a1803df08f44-6cb819e0af1mr74417436d6.13.1727919622384; Wed, 02 Oct 2024 18:40:22 -0700 (PDT) Received: from gnus ([65.94.70.53]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6cb937f55e2sm1129516d6.113.2024.10.02.18.40.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Oct 2024 18:40:21 -0700 (PDT) From: Suhail Singh To: Suhail Singh Subject: Re: [bug#72925] [PATCH v3] adding jpm package In-Reply-To: <878qv69n0o.fsf@gmail.com> (Suhail Singh's message of "Wed, 02 Oct 2024 18:07:51 -0400") References: <4e623d9571ff648ae1d1c6ffb8f9d73c421a5c10.1727683810.git.omar.bassam88@gmail.com> <87plok7kkn.fsf@gmail.com> <8734lev012.fsf@gmail.com> <875xqanty2.fsf@gmail.com> <87cyki9obi.fsf@gmail.com> <878qv69n0o.fsf@gmail.com> Date: Wed, 02 Oct 2024 21:40:09 -0400 Message-ID: <874j5u7yme.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Munyoki Kilyungi , Katherine Cox-Buday , Guillaume Le Vaillant , jgart , Omar Bassam X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Suhail Singh writes: >> I don't think this should be related to this patch. > > As I mentioned previously, I believe your packaging of "jpm" is > correctly done. After having taken a look at the source of JPM, I believe I was previously mistaken. I don't believe the JPM packaging is correct. And I do believe that the issue I was observing is related to the patch. Specifically, in the file "configs/linux_config.janet", among other things, the below are set #+begin_src janet :c++ "c++" :c++-link "c++" :cc "cc" :cc-link "cc" #+end_src Since Guix, as far as I know, doesn't have packages that provide c++ nor cc, I believe the above need to be patched to refer to gcc and g++ respectively. Further, I believe JPM should have a few propagated inputs: - gcc-toolchain - curl - git - nss-certs. Please address the above two in v8 if you agree. If not, please help me understand where I may have erred in the analysis above. -- Suhail From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 03 00:15:07 2024 Received: (at 72925) by debbugs.gnu.org; 3 Oct 2024 04:15:08 +0000 Received: from localhost ([127.0.0.1]:59608 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swDF4-0007DZ-1K for submit@debbugs.gnu.org; Thu, 03 Oct 2024 00:15:07 -0400 Received: from mail-pl1-f172.google.com ([209.85.214.172]:45176) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw4ne-0002mr-5c for 72925@debbugs.gnu.org; Wed, 02 Oct 2024 15:14:14 -0400 Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-20bb39d97d1so794945ad.2 for <72925@debbugs.gnu.org>; Wed, 02 Oct 2024 12:14:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727896387; x=1728501187; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=OlMWo/Af0hkuhdhtecNPGO4W+boFJvP/3zR4scNFR6Y=; b=NGveGHejPoX6w23wPpRnIOFdd/UctNrw0bx52jpESNGyI+rNDwFgs5NLJ22JKt8Mu7 h5Cw1ANkWDBxBOmVrVRye9qmiRLVeMrbcziQ1Q3C8ei8L1t2dg0ZKhmHsCtcNS+nhkMZ oY4ekUXEgG1Ammn5beGUtfCt/gNfJGCd4j2j3ZOtD6WZtYSGLRq+6122oTdxImTk/CZd HyV/UhRPGSMIaTfeQksd1Nho7C1dhL8aK2zOyT27g+vCL1Ro/0xADcwpmcCn+uX1Z2Nn 9NixdQ8O2CUM2+LfLv3K7lFH/gSY9jNwVLB/tSPDHyfWaP7Jv/VaqTHTecgi3J0hdvln bvVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727896387; x=1728501187; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OlMWo/Af0hkuhdhtecNPGO4W+boFJvP/3zR4scNFR6Y=; b=sLxQXBwTrOl+EVv7Z1qpVdTa9Ll4sn1rO5Fm2GMGJEvmWCxYscrGEiTFXbje5ULQ1Q 1VgrO+0pECpKl1GZICT3CRuUd70+he64QZwvTNta3tzxtpH8KLmwtKD7160cl31UIwWO 4vLLXqS91u9DoSglsphl0c3SBDLUqvJi3Aa6Q2fDrp8PgyrEhHkEmotDWoqW+SI8LXZW hV80J6IENUTB1k2mpzXbVNNKiZwDYjsbSl5w97/C2EJpmif8DtAHNMbPypdfoYczKvjF tGVSk7NtFQERWh7XUdoBntIlnH5Ux6+5hJz4x5B/0SUAch/ftBw4b2EPdWz0hLHYEv+T s3Xw== X-Gm-Message-State: AOJu0YyeavM0kIRsVGvyfxkYoZ5tB8gFkt3d+KDf5xV+VxHeIEw/QzHT 7g9yJOQ3M2dgr+NGEcgYTUI/3afn+cqcLMWRUiSLR59kEWh+l+684ZTjyV7FmXvP/IA6K4l5BLI 5VveII1TVMtcM+Nxc5Xly3tlpCPA= X-Google-Smtp-Source: AGHT+IGAVM+TqCUwBJQykNd1K0P8DBycSUVoT/9I17uXAKSYTNcGLkd1ysdjpfsVapSrL3krD9FL3Cxb7w2pAuFBpIw= X-Received: by 2002:a17:903:5cc:b0:20b:5b1a:209 with SMTP id d9443c01a7336-20bc59a3948mr39024115ad.9.1727896387443; Wed, 02 Oct 2024 12:13:07 -0700 (PDT) MIME-Version: 1.0 References: <4e623d9571ff648ae1d1c6ffb8f9d73c421a5c10.1727683810.git.omar.bassam88@gmail.com> <87plok7kkn.fsf@gmail.com> <8734lev012.fsf@gmail.com> In-Reply-To: <8734lev012.fsf@gmail.com> From: Omar Bassam Date: Wed, 2 Oct 2024 22:12:56 +0300 Message-ID: Subject: Re: [bug#72925] [PATCH v3] adding jpm package To: Suhail Singh Content-Type: multipart/alternative; boundary="00000000000061ea720623833ad9" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 X-Mailman-Approved-At: Thu, 03 Oct 2024 00:15:02 -0400 Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Munyoki Kilyungi , Katherine Cox-Buday , Guillaume Le Vaillant , jgart X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --00000000000061ea720623833ad9 Content-Type: text/plain; charset="UTF-8" Hi Suhail, Sorry if some of my instructions were not clear before. I'll try to explain in more detail. On Wed, 2 Oct 2024 at 21:21, Suhail Singh wrote: > Omar Bassam writes: > > > This is expected as the jpm install command is meant to install janet > > packages globally which would be impure. > > It would help for this to be noted in some manner. Be it in the > description or as comments in the package description. > I don't think this needs to be said because all package managers installed via guix have this issue. This is a common Nix/Guix issue that I struggled a lot to understand at the beginning. Also, there is no one way to solve this because jpm gives you the freedom to install packages on a user level or on a project only level. > > To install janet packages to your local project directory, you need to > add > > the "-l" flag as follows: > > jpm install -l sh > > Does this work for you (for jpm installed via guix)? If so, could you > please confirm the set of dependencies you have installed in the guix > profile for the above to work? If not, could you provide an example > invocation that I could test out which would allow me to install a janet > dependency in a local directory? > Do you still get the same error? Yes, this does work for me without any other dependencies. I am using guix on ubuntu with guix shell. It should create a "jpm_tree" folder in the directory where you invoked the command from. Alternatively you can set the "JANET_TREE" environment variable before invoking the command. For example: JANET_TREE=~/.jpm jpm install sh Also, note that janet is a lisp that compiles to C. So, if the library you are trying to install has other dependencies, you'll need to have those available in your profile/shell. > > Maybe in the future we can add a "janet-build-system" that will allow us > to > > add janet packages to the guix repository. > > That would be helpful. > Yes, indeed. I don't have much experience about that yet. But I plan to do so in the future. > -- > Suhail > --00000000000061ea720623833ad9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Suhail,

= Sorry if some of my instructions were not clear before. I'll try to exp= lain in more detail.

On Wed, 2 Oct 2024 at 21:21, Suhail Singh <= ;suhailsingh247@gmail.com&g= t; wrote:
Omar B= assam <omar= .bassam88@gmail.com> writes:

> This is expected as the jpm install command is meant to install janet<= br> > packages globally which would be impure.

It would help for this to be noted in some manner.=C2=A0 Be it in the
description or as comments in the package description.
=C2=A0
I don't think this needs to be said because all packa= ge managers installed via guix have this issue.
This is a co= mmon Nix/Guix issue that I struggled a lot to understand at the beginning. =
Also, there is no one way to solve this because jpm gives yo= u the freedom to install packages on a user level
or on a project= only level.
=C2=A0
> To install janet packages to your local project directory, you need to= add
> the "-l" flag as follows:
> jpm install -l sh

Does this work for you (for jpm installed via guix)?=C2=A0 If so, could you=
please confirm the set of dependencies you have installed in the guix
profile for the above to work?=C2=A0 If not, could you provide an example invocation that I could test out which would allow me to install a janet dependency in a local directory?

Do you= still get the same error?
Yes, this does work for me without= any other dependencies. I am using guix on ubuntu with guix shell.=C2=A0
It should create a "jpm_tree" folder in the directory wh= ere you invoked the command from.
Alternatively you can set the &= quot;JANET_TREE" environment variable before invoking the command. For= example:
JANET_TREE=3D~/.jpm jpm install sh

=
Also, note that janet is a lisp that compiles to C. So, if the library= you are trying to install has other dependencies,=C2=A0
you'= ll need to have those available in your profile/shell.

=C2=A0
> Maybe in the future we can add a "janet-build-system" that w= ill allow us to
> add janet packages to the guix repository.

That would be helpful.
Yes, indeed. I don't have m= uch experience about that yet. But I plan to do so in the future.
--
Suhail
--00000000000061ea720623833ad9-- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 03 00:15:11 2024 Received: (at 72925) by debbugs.gnu.org; 3 Oct 2024 04:15:11 +0000 Received: from localhost ([127.0.0.1]:59610 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swDF5-0007EO-Q6 for submit@debbugs.gnu.org; Thu, 03 Oct 2024 00:15:11 -0400 Received: from mail-pl1-f181.google.com ([209.85.214.181]:47276) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw5xL-0007JB-2B for 72925@debbugs.gnu.org; Wed, 02 Oct 2024 16:28:19 -0400 Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-20b7eb9e81eso1945055ad.2 for <72925@debbugs.gnu.org>; Wed, 02 Oct 2024 13:28:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727900832; x=1728505632; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Vk/vFxDGuA0PkyBqLMnVlqGSsv54XlV++839zqeRKBk=; b=dhTTmP5FbEwYhceM9qZdH8kaHUl4HD0no6GQnfTZzboyvm1CELxIdCFlM5TruO44T9 PBcRoojCkXaGKnZMIRFzuOeAdSkTY8Uxb5qw5DfwNBaoZVzgzDC5pVwz0uvxSspWn3tv 8dtgFGeYy5Fhz6fPyLdnVxUVTaXcvBY+l5rErFaFSH4wjpnq1BtAm7lg3XG+JPbgrP4h givmtlfo6mD8oucYGtZve2Hk4vEeDwwdXLI1X3ei+LEc1Z+IZmGn8r/4Hf8BnMgYPjst C1F4T39DdWsEC8fGbwvGKRD35E+QJH6v1MnMZf0+PYhtWtpp7o8fM78hDbBGH9cN8JEw Ky+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727900832; x=1728505632; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Vk/vFxDGuA0PkyBqLMnVlqGSsv54XlV++839zqeRKBk=; b=rjs5iKWI4/Zy294sr+OtVNLVh6mJNh6Swv0wc0jTtR6L1KL+RqYDFAqikyfSowYodl 31B4DMf8A0nfbGHnw2zixE0e2Putp7wCanQFMXNCXPSG01MypqnQT/74i37gLGdARe2Z 3prPjCJ6VoubUE/SDhxphjzTZC1dYI5BqJZR8ytCnmEj5e9jMKofaIJMxyungH6c5yEV w5odzMH/tJrEhQ9HBQrZOlUcyAwYVdumqd9yYJ241o/xGTlb6TevikgQQKyam1D2TQ3J C1mJchI2B/xQS7/0MwXVFw8Z8QOwVVsuFduB80rdI7Vkp+Tk2TxMrUhcZudmodNxXKt/ V23w== X-Gm-Message-State: AOJu0Yx6vD+NEe7XUuaYuCCBU9jNPflxD3UgglM1W+p7FTF8ZBWSXNXI YxA5o6SHzQOzTQfM8QRHEIm4b+hfVUocWzlnOJ7Ra8IL8Nfw5Moz2GdYQCcH+e9BvI5VunCwcaW xEy8BdPSV79Ev+UR0RVlHHlLlm9U= X-Google-Smtp-Source: AGHT+IH+NQjnfKVlr6get5MPq9gnCfdzCV/7FE+2TqVfSXPzEE5OMDa/c+jnwiFU4tMlLSqR/K8jVUTJtJmB6HEVg2s= X-Received: by 2002:a17:90b:4a52:b0:2d8:abdf:2ca9 with SMTP id 98e67ed59e1d1-2e184531e52mr5442829a91.3.1727900831955; Wed, 02 Oct 2024 13:27:11 -0700 (PDT) MIME-Version: 1.0 References: <4e623d9571ff648ae1d1c6ffb8f9d73c421a5c10.1727683810.git.omar.bassam88@gmail.com> <87plok7kkn.fsf@gmail.com> <8734lev012.fsf@gmail.com> <875xqanty2.fsf@gmail.com> In-Reply-To: <875xqanty2.fsf@gmail.com> From: Omar Bassam Date: Wed, 2 Oct 2024 23:27:00 +0300 Message-ID: Subject: Re: [bug#72925] [PATCH v3] adding jpm package To: Suhail Singh Content-Type: multipart/alternative; boundary="0000000000004bc1950623844389" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 X-Mailman-Approved-At: Thu, 03 Oct 2024 00:15:02 -0400 Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Munyoki Kilyungi , Katherine Cox-Buday , Guillaume Le Vaillant , jgart X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) --0000000000004bc1950623844389 Content-Type: text/plain; charset="UTF-8" On Wed, 2 Oct 2024 at 23:14, Suhail Singh wrote: > Omar Bassam writes: > > >> > This is expected as the jpm install command is meant to install janet > >> > packages globally which would be impure. > >> > >> It would help for this to be noted in some manner. Be it in the > >> description or as comments in the package description. > > > > I don't think this needs to be said because all package managers > installed > > via guix have this issue. > > For me, someone familiar with Guix, but unfamiliar with Janet and JPM > defaults, it wasn't obvious that I needed to add "-l" to the invocation. > > I don't believe such a message is necessary, but it would be helpful to > some (those individuals who aren't familiar with both JPM and Guix). > This is where jgart suggestion would be really helpful. I am personally working on a project https://lisp-spectrum.org/ where I try to document all the struggles that I had with the Lisp ecosystem and try to make it more accessible to new users. (Any contributions are welcomed of course). > > > Also, there is no one way to solve this because jpm gives you the freedom > > to install packages on a user level > > or on a project only level. > > The fact that JPM doesn't install packages at a user level by default > was not something I knew previously. > > >> > To install janet packages to your local project directory, you need to > >> add > >> > the "-l" flag as follows: > >> > jpm install -l sh > >> > >> Does this work for you (for jpm installed via guix)? If so, could you > >> please confirm the set of dependencies you have installed in the guix > >> profile for the above to work? If not, could you provide an example > >> invocation that I could test out which would allow me to install a janet > >> dependency in a local directory? > > > > Do you still get the same error? > > No, a different one. > > > Yes, this does work for me without any other dependencies. I am using > guix > > on ubuntu with guix shell. > > I am running guix-shell (--pure) with the following dependencies > installed: > - janet > - gcc-toolchain gcc-toolchain:static > - openssl > - git > - jpm > - bash coreutils > - curl nss-certs > > With the above, when running "jpm --local install sh" I observe the > following error: > > #+begin_example > error: ( "cc" > "-std=c99" > > "-I/gnu/store/rdlvs1p09brkk961lj3vncifb4xlsmm5-janet-1.36.0/include/janet" > "-I/tmp/review-72925/jpm_tree/lib" > "-O2" > "-o" > "build/_jmod_posix_spawn.so" > "build/posix-spawn.o" > "-shared" > "-pthread"): No such file or directory > error: build fail > in pdag > [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/dagbuild.janet] > (tail call) on line 79, column 23 > in with-dyns > [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/pm.janet] > on line 236, column 9 > in defer > [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/pm.janet] > on line 221, column 5 > in bundle-install > [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/pm.janet] > on line 219, column 3 > in with-dyns > [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/pm.janet] > on line 234, column 13 > in defer > [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/pm.janet] > on line 221, column 5 > in bundle-install > [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/pm.janet] > on line 219, column 3 > in install > [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/commands.janet] > (tail call) on line 190, column 20 > in run-main [boot.janet] on line 4432, column 16 > in cli-main [boot.janet] on line 4613, column 17 > #+end_example > > When running "jpm --cc=gcc --local install sh" I get the same error. > > I was finally able to get it to succeed by having cc symlink to gcc and > adding the directory containing the symlink to PATH. So I believe that > the package definition you've submitted is correct. However, I'm > wondering what (if anything) needs to be done about the issue I > encountered. > > Specifically, it's unclear why passing "-cc=gcc" didn't work (nor did > setting "CC=gcc", but perhaps JPM ignores the latter?). Is this an > upstream bug? Were my expectations misplaced? Should the JPM package > in Guix provide "cc" as well? > No, this is not really a Janet or JPM issue but rather the fact that you are overriding the gcc compiler with a symlinked binary instead of the absolute path. I faced this issue as well with LD_LIBRARY_PATH where you have to use "readlink" to point it to the absolute path of the "lib" folder in your guix profile. > -- > Suhail > --0000000000004bc1950623844389 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Wed, 2 Oct 2024 at 23:14, Suhail S= ingh <suhailsingh247@gmail.c= om> wrote:
omar.bassam88@gmail.com> writes:

>> > This is expected as the jpm install command is meant to insta= ll janet
>> > packages globally which would be impure.
>>
>> It would help for this to be noted in some manner.=C2=A0 Be it in = the
>> description or as comments in the package description.
>
> I don't think this needs to be said because all package managers i= nstalled
> via guix have this issue.

For me, someone familiar with Guix, but unfamiliar with Janet and JPM
defaults, it wasn't obvious that I needed to add "-l" to the = invocation.

I don't believe such a message is necessary, but it would be helpful to=
some (those individuals who aren't familiar with both JPM and Guix).

This is where jgart suggestion would be r= eally helpful. I am personally working on a project
https://lisp-spectrum.org/ where I try to doc= ument all the struggles that I had with the Lisp ecosystem
and tr= y to make it more accessible to new users. (Any contributions are welcomed = of course).
=C2=A0

> Also, there is no one way to solve this because jpm gives you the free= dom
> to install packages on a user level
> or on a project only level.

The fact that JPM doesn't install packages at a user level by default was not something I knew previously.

>> > To install janet packages to your local project directory, yo= u need to
>> add
>> > the "-l" flag as follows:
>> > jpm install -l sh
>>
>> Does this work for you (for jpm installed via guix)?=C2=A0 If so, = could you
>> please confirm the set of dependencies you have installed in the g= uix
>> profile for the above to work?=C2=A0 If not, could you provide an = example
>> invocation that I could test out which would allow me to install a= janet
>> dependency in a local directory?
>
> Do you still get the same error?

No, a different one.

> Yes, this does work for me without any other dependencies. I am using = guix
> on ubuntu with guix shell.

I am running guix-shell (--pure) with the following dependencies
installed:
- janet
- gcc-toolchain gcc-toolchain:static
- openssl
- git
- jpm
- bash coreutils
- curl nss-certs

With the above, when running "jpm --local install sh" I observe t= he
following error:

#+begin_example
=C2=A0 error: ( "cc"
=C2=A0 =C2=A0 "-std=3Dc99"
=C2=A0 =C2=A0 "-I/gnu/store/rdlvs1p09brkk961lj3vncifb4xlsmm5-janet-1.3= 6.0/include/janet"
=C2=A0 =C2=A0 "-I/tmp/review-72925/jpm_tree/lib"
=C2=A0 =C2=A0 "-O2"
=C2=A0 =C2=A0 "-o"
=C2=A0 =C2=A0 "build/_jmod_posix_spawn.so"
=C2=A0 =C2=A0 "build/posix-spawn.o"
=C2=A0 =C2=A0 "-shared"
=C2=A0 =C2=A0 "-pthread"): No such file or directory
=C2=A0 error: build fail
=C2=A0 =C2=A0 in pdag [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.= 0/lib/janet/jpm/dagbuild.janet] (tail call) on line 79, column 23
=C2=A0 =C2=A0 in with-dyns [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm= -1.1.0/lib/janet/jpm/pm.janet] on line 236, column 9
=C2=A0 =C2=A0 in defer [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1= .0/lib/janet/jpm/pm.janet] on line 221, column 5
=C2=A0 =C2=A0 in bundle-install [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq= 6-jpm-1.1.0/lib/janet/jpm/pm.janet] on line 219, column 3
=C2=A0 =C2=A0 in with-dyns [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm= -1.1.0/lib/janet/jpm/pm.janet] on line 234, column 13
=C2=A0 =C2=A0 in defer [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1= .0/lib/janet/jpm/pm.janet] on line 221, column 5
=C2=A0 =C2=A0 in bundle-install [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq= 6-jpm-1.1.0/lib/janet/jpm/pm.janet] on line 219, column 3
=C2=A0 =C2=A0 in install [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1= .1.0/lib/janet/jpm/commands.janet] (tail call) on line 190, column 20
=C2=A0 =C2=A0 in run-main [boot.janet] on line 4432, column 16
=C2=A0 =C2=A0 in cli-main [boot.janet] on line 4613, column 17
#+end_example

When running "jpm --cc=3Dgcc --local install sh" I get the same e= rror.

I was finally able to get it to succeed by having cc symlink to gcc and
adding the directory containing the symlink to PATH.=C2=A0 So I believe tha= t
the package definition you've submitted is correct.=C2=A0 However, I= 9;m
wondering what (if anything) needs to be done about the issue I
encountered.

Specifically, it's unclear why passing "-cc=3Dgcc" didn't= work (nor did
setting "CC=3Dgcc", but perhaps JPM ignores the latter?).=C2=A0 I= s this an
upstream bug?=C2=A0 Were my expectations misplaced?=C2=A0 Should the JPM pa= ckage
in Guix provide "cc" as well?

No, this is not really a Janet or JPM issue but rather the fact that you a= re overriding the gcc compiler with a symlinked binary
instead of= the absolute path. I faced this issue as well with LD_LIBRARY_PATH where y= ou have to use "readlink" to point it
to the absol= ute path of the "lib" folder in your guix profile.
= =C2=A0
--
Suhail
--0000000000004bc1950623844389-- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 03 00:15:14 2024 Received: (at 72925) by debbugs.gnu.org; 3 Oct 2024 04:15:14 +0000 Received: from localhost ([127.0.0.1]:59612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swDF9-0007GP-Bq for submit@debbugs.gnu.org; Thu, 03 Oct 2024 00:15:13 -0400 Received: from mail-pj1-f52.google.com ([209.85.216.52]:53407) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw7Hq-0003h3-SY for 72925@debbugs.gnu.org; Wed, 02 Oct 2024 17:53:35 -0400 Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-2e0af6e5da9so246399a91.2 for <72925@debbugs.gnu.org>; Wed, 02 Oct 2024 14:53:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727905948; x=1728510748; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=SCoP/Az5/Yaxq2VnPPZX1dgAQX+HbztkbF87+Ndfo1A=; b=D8bXKWlF24BOFOiJbkaj9mDLZ+SFynIipdKIFYN9jFOLeDiYrPEEVAbviEmTwF2wB7 E7aqBrA3bWh9s8SWW9QqclJlZBNeWoZ50G4rEpditvtqkvFdT3J6LTyN4gDDvkow3IyN /82+FKo2NbuWITsGiBcdqj/MC5BX6EzGmRkS/8nAXlixxjrwdwVlOnLP6BoyeopUbjFo Bh2Ih5eA8XysxmDOFnPw/8pxMHjdOvNbQiv+d5eNvdq/nb9FC+S1LWwV8BE1W7ti7fhU PuSQq8RfAIKEK/ovH3UDdbDuCRPd86Bp/99qPGsiSK34F78TJd3x5vhkpMcJpHYxGsUW UC4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727905948; x=1728510748; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SCoP/Az5/Yaxq2VnPPZX1dgAQX+HbztkbF87+Ndfo1A=; b=JTWFzIPpgXeTd1O05wlDAz3OvNK+GCr5BndcQWoNyt1rvkZDjJYAwUY0dnZSV7CdAC x27Rz+6D0Xo2rENCY00qnNwOA0kZIZpyuUpUiSliNt5t/36rq1NNrg7H9dj6vo2/PmI3 w1NrE3y0zfxFvrCn5JS9hUt7lCnc1QgjWJH9RUb8iHU7rWAcvGcdN6nuXZDPaYFZlXzb Z9szPf+1lNDtCP4U8uxjeBV/U9MJbTQcAHU7viMtyuSeApmB58zGBUqxIUT79NJmj7+8 J04W/u0PXkc/w6ymbIX96u1wQ+p0Gtzn3kb/RyMEclTgKp0brWFUdH378tWzLs5pdS7H JGew== X-Gm-Message-State: AOJu0YxvkCJQ2wp1wastCxqWSiWWn0MBSA0tMy4Dl/qc9zRtmaytewzo vWeO/pzKRvhnteU73nf1vcfz5LYA/Om77720RbjfXGFCrH332bXWH8OvcsmY1xzVhvbcoR+ydm8 XdH8/xomHXGXyCPnwFCrSi3pUZBI= X-Google-Smtp-Source: AGHT+IGIIxdKhcd2c4KfCGZakXVHrhmapTDliTaTkUFQFCdHtmf9RMk6GgwWBKXpeCWP8e5gzmr0ChHdaZ+ZxznGxtU= X-Received: by 2002:a05:6a20:9f8a:b0:1cf:4d4e:532b with SMTP id adf61e73a8af0-1d5e2d9e65fmr6929505637.43.1727905947847; Wed, 02 Oct 2024 14:52:27 -0700 (PDT) MIME-Version: 1.0 References: <4e623d9571ff648ae1d1c6ffb8f9d73c421a5c10.1727683810.git.omar.bassam88@gmail.com> <87plok7kkn.fsf@gmail.com> <8734lev012.fsf@gmail.com> <875xqanty2.fsf@gmail.com> <87cyki9obi.fsf@gmail.com> In-Reply-To: <87cyki9obi.fsf@gmail.com> From: Omar Bassam Date: Thu, 3 Oct 2024 00:52:16 +0300 Message-ID: Subject: Re: [bug#72925] [PATCH v3] adding jpm package To: Suhail Singh Content-Type: multipart/alternative; boundary="0000000000003a1801062385746f" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 X-Mailman-Approved-At: Thu, 03 Oct 2024 00:15:02 -0400 Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Munyoki Kilyungi , Katherine Cox-Buday , Guillaume Le Vaillant , jgart X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --0000000000003a1801062385746f Content-Type: text/plain; charset="UTF-8" On Thu, 3 Oct 2024 at 00:39, Suhail Singh wrote: > Omar Bassam writes: > > >> When running "jpm --cc=gcc --local install sh" I get the same error. > >> > >> I was finally able to get it to succeed by having cc symlink to gcc and > >> adding the directory containing the symlink to PATH. So I believe that > >> the package definition you've submitted is correct. However, I'm > >> wondering what (if anything) needs to be done about the issue I > >> encountered. > >> > >> Specifically, it's unclear why passing "-cc=gcc" didn't work (nor did > >> setting "CC=gcc", but perhaps JPM ignores the latter?). Is this an > >> upstream bug? Were my expectations misplaced? Should the JPM package > >> in Guix provide "cc" as well? > >> > > > > No, this is not really a Janet or JPM issue but rather the fact that > > you are overriding the gcc compiler with a symlinked binary instead of > > the absolute path. > > I don't understand. > > All four variants below fail in exactly the same way: > > #+begin_src sh > jpm --cc=gcc -l install sh > #+end_src > > #+begin_src sh > jpm --cc=/home/user/.guix-profile/bin/gcc -l install sh > #+end_src > > #+begin_src sh > jpm > --cc=/gnu/store/x2kv3zw2k7ql211m5kvb6yw401gab0x9-gcc-toolchain-14.2.0/bin/gcc > -l install sh > #+end_src > > #+begin_src sh > jpm --cc=/gnu/store/lq9y7sd4mvffs4hqp3hkr9fnd384pnkj-gcc-14.2.0/bin/gcc > -l install sh > #+end_src > > Note that the last variant uses an absolute path. > > Either I'm not using the "--cc" option correctly. Or for some > dependency of "sh" (specifically, posix-spawn) the compiler has been > hardcoded to "cc" and it's not picking up the option being passed to > jpm. > > Further, if the above work for you in a "--pure" guix shell (where it > doesn't for me), that's surprising. > > It is _only_ when I provide a fake "cc" (which is simply a symlink to > gcc) that things work. > > -- > Suhail > I believe this is a library specific thing. I don't think this should be related to this patch. Also, if you are running a guix shell with --pure flag, try adding coreutils to your shell because jpm calls the "cp" command when building libraries. I tried with "jpm install -l spork" and with "jpm install -l sh" and it works fine. I believe the --cc flag is meant to be used for the jpm build command. --0000000000003a1801062385746f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, 3 Oct 2024 at 00:39, Suhail S= ingh <suhailsingh247@gmail.c= om> wrote:
omar.bassam88@gmail.com> writes:

>> When running "jpm --cc=3Dgcc --local install sh" I get t= he same error.
>>
>> I was finally able to get it to succeed by having cc symlink to gc= c and
>> adding the directory containing the symlink to PATH.=C2=A0 So I be= lieve that
>> the package definition you've submitted is correct.=C2=A0 Howe= ver, I'm
>> wondering what (if anything) needs to be done about the issue I >> encountered.
>>
>> Specifically, it's unclear why passing "-cc=3Dgcc" d= idn't work (nor did
>> setting "CC=3Dgcc", but perhaps JPM ignores the latter?)= .=C2=A0 Is this an
>> upstream bug?=C2=A0 Were my expectations misplaced?=C2=A0 Should t= he JPM package
>> in Guix provide "cc" as well?
>>
>
> No, this is not really a Janet or JPM issue but rather the fact that > you are overriding the gcc compiler with a symlinked binary instead of=
> the absolute path.

I don't understand.

All four variants below fail in exactly the same way:

#+begin_src sh
=C2=A0 jpm --cc=3Dgcc -l install sh
#+end_src

#+begin_src sh
=C2=A0 jpm --cc=3D/home/user/.guix-profile/bin/gcc -l install sh
#+end_src

#+begin_src sh
=C2=A0 jpm --cc=3D/gnu/store/x2kv3zw2k7ql211m5kvb6yw401gab0x9-gcc-toolchain= -14.2.0/bin/gcc -l install sh
#+end_src

#+begin_src sh
=C2=A0 jpm --cc=3D/gnu/store/lq9y7sd4mvffs4hqp3hkr9fnd384pnkj-gcc-14.2.0/bi= n/gcc -l install sh
#+end_src

Note that the last variant uses an absolute path.

Either I'm not using the "--cc" option correctly.=C2=A0 Or fo= r some
dependency of "sh" (specifically, posix-spawn) the compiler has b= een
hardcoded to "cc" and it's not picking up the option being pa= ssed to
jpm.

Further, if the above work for you in a "--pure" guix shell (wher= e it
doesn't for me), that's surprising.

It is _only_ when I provide a fake "cc" (which is simply a symlin= k to
gcc) that things work.

--
Suhail

I believe this is a library spec= ific thing. I don't think this should be related to this patch.
Also, if you are running a guix shell with --pure flag, try adding coreu= tils to your shell because jpm calls the "cp" command when buildi= ng libraries.
I tried with "jpm install -l spork" and w= ith "jpm install -l sh" and it works fine. I believe the --cc fla= g is meant to be used for the jpm build command.
=C2=A0
--0000000000003a1801062385746f-- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 03 03:15:41 2024 Received: (at 72925) by debbugs.gnu.org; 3 Oct 2024 07:15:41 +0000 Received: from localhost ([127.0.0.1]:59844 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swG3p-0001N2-3h for submit@debbugs.gnu.org; Thu, 03 Oct 2024 03:15:41 -0400 Received: from mail-pj1-f53.google.com ([209.85.216.53]:47243) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swG3n-0001Mb-2b for 72925@debbugs.gnu.org; Thu, 03 Oct 2024 03:15:39 -0400 Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-2e1c91fe739so100429a91.2 for <72925@debbugs.gnu.org>; Thu, 03 Oct 2024 00:15:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727939671; x=1728544471; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Bo8YtopV9BAT9CLtcOU3du6+2Cu/55tHyrZx78T5LbM=; b=MmyiYm3jyzXdtzTwdwso9iUpvey+n3baHfPEo1VjeZXlahyszvF3PBjJif9f2mvB4+ e8NLRANOEecGch7v8l6YvXW2kr2K6+CG4c4FGTHqMoht8wF7rvPu0gUWtHfKwk7nZl8I 5NsjI/v2Jvor/JY1x9HE8NVoDyHIpZ70bl6CLlz/KBhRi6kEYNazSu96SOP/eMIdrmrB mmLODMUUS5K+ymkFk2zAjJ2tGP/jEvUKLqQR0eLM4J6ln62ebe/Oe8UXiVz+EhP9nNTn +QxI6qTKJduGGydOSRkHMcF2mwSzQutlbsia4KdgWyyuHV4Ng4KHM4qd2a8SLzcKrE4+ r+Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727939671; x=1728544471; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Bo8YtopV9BAT9CLtcOU3du6+2Cu/55tHyrZx78T5LbM=; b=gOucb//d+RSfss9ut1ae3VhJJm/YqPeMFCPxEptCBNCv82Q/i8i5Tv/iMLDrJRIJQr tihDt/+36AMLrrBMYIgwngvYWqJPYxsiq91IUOG7jvWwM48/xv8REtSZgNSIV/iU/vXA YS6+8zamL6ajDpRQVjIdb8q9CDpNXyAWHCXmPcGUFgY+0pmiAt1H8gJ/gwBCjODPC07F ya9VkiP1qD9DI04Yc5BurF2vveD6H8YtzrXcaEEOey5q0FLhFa+qpKSVlP1wWucsenxX E8w7OIYSWAAoE7419Ixo8r/GcsGY4LGbPuHhUoARP2407DAy6gtEkeruWvh1n0x2Bovt u3Mg== X-Gm-Message-State: AOJu0YxgXHRigeCgG2e5+ga08PcJf7Uv2jGwo+L96++Z6wsdAsYvMMUc RWUt/c1cLVh6ZH8dicxpsgQsIRPXur/BYEVtBQ0MlFCj9gJbJFgkroObh//pnfqw3a5Yg1F2s3t rrzf1pddhfNwcHgb/3L6oNkjZinU= X-Google-Smtp-Source: AGHT+IGp+3ckR8gs5MPcE9mFxqoJozEQ3KWH7qwiL697CR62LuG42BjMql73q4x6IJQOlnVTXTP9W5ln1Uzekqg2rtg= X-Received: by 2002:a17:90b:164f:b0:2e0:927a:6928 with SMTP id 98e67ed59e1d1-2e1846c5140mr7634298a91.24.1727939671353; Thu, 03 Oct 2024 00:14:31 -0700 (PDT) MIME-Version: 1.0 References: <4e623d9571ff648ae1d1c6ffb8f9d73c421a5c10.1727683810.git.omar.bassam88@gmail.com> <87plok7kkn.fsf@gmail.com> <8734lev012.fsf@gmail.com> <875xqanty2.fsf@gmail.com> <87cyki9obi.fsf@gmail.com> <878qv69n0o.fsf@gmail.com> <874j5u7yme.fsf@gmail.com> In-Reply-To: <874j5u7yme.fsf@gmail.com> From: Omar Bassam Date: Thu, 3 Oct 2024 10:14:20 +0300 Message-ID: Subject: Re: [bug#72925] [PATCH v3] adding jpm package To: Suhail Singh Content-Type: multipart/alternative; boundary="0000000000004df1e006238d4e26" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Munyoki Kilyungi , Katherine Cox-Buday , Guillaume Le Vaillant , jgart X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --0000000000004df1e006238d4e26 Content-Type: text/plain; charset="UTF-8" Hi Suhail, I just have some questions before submitting v8 if you don't mind. just to make sure I understand correctly. On Thu, 3 Oct 2024 at 04:40, Suhail Singh wrote: > Suhail Singh writes: > > >> I don't think this should be related to this patch. > > > > As I mentioned previously, I believe your packaging of "jpm" is > > correctly done. > > After having taken a look at the source of JPM, I believe I was > previously mistaken. I don't believe the JPM packaging is correct. And > I do believe that the issue I was observing is related to the patch. > > Specifically, in the file "configs/linux_config.janet", among other > things, the below are set > > #+begin_src janet > :c++ "c++" > :c++-link "c++" > :cc "cc" > :cc-link "cc" > #+end_src > > Since Guix, as far as I know, doesn't have packages that provide c++ nor > cc, I believe the above need to be patched to refer to gcc and g++ > respectively. > > So we need to substitute the above "c++" and "cc" in the "configs/linux_config.janet" to point to the absolute path for the gcc and g++ packages? Should we also replace other commands that are hard-coded like "cp" and "chown" from coreutils the same way I did in my first initial patch? Further, I believe JPM should have a few propagated inputs: > - gcc-toolchain > - curl > - git > - nss-certs. > > I understand why we need gcc-toolchain. But why do we need curl, git and nss-certs? Please address the above two in v8 if you agree. If not, please help me > understand where I may have erred in the analysis above. > > -- > Suhail > Thanks, Omar --0000000000004df1e006238d4e26 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Suhail,
I just have some que= stions before submitting v8 if you don't mind. just to make sure I unde= rstand correctly.

On Thu, 3 Oct 2024 at 04:40, Suhail Singh <suhailsingh247@gmail.com> wrote= :
Suhail Singh &= lt;suhailsing= h247@gmail.com> writes:

>> I don't think this should be related to this patch.
>
> As I mentioned previously, I believe your packaging of "jpm"= is
> correctly done.

After having taken a look at the source of JPM, I believe I was
previously mistaken.=C2=A0 I don't believe the JPM packaging is correct= .=C2=A0 And
I do believe that the issue I was observing is related to the patch.

Specifically, in the file "configs/linux_config.janet", among oth= er
things, the below are set

#+begin_src janet
=C2=A0 =C2=A0:c++ "c++"
=C2=A0 =C2=A0:c++-link "c++"
=C2=A0 =C2=A0:cc "cc"
=C2=A0 =C2=A0:cc-link "cc"
#+end_src

Since Guix, as far as I know, doesn't have packages that provide c++ no= r
cc, I believe the above need to be patched to refer to gcc and g++
respectively.

So we need to substitute the above "c++" an= d "cc" in the=20 "configs/linux_config.janet" to point to the absolute path for th= e gcc=20 and g++ packages?=C2=A0
Should we also replace other command= s that are hard-coded like "cp" and "chown" from coreut= ils the same way I did in my first initial patch?

<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex"> Further, I believe JPM should have a few propagated inputs:
- gcc-toolchain
- curl
- git
- nss-certs.

I understand why we need gcc-toolchain. But why do we= need curl, git and nss-certs?

Please address the above two in v8 if you agree.=C2=A0 If not, please help = me
understand where I may have erred in the analysis above.

--
Suhail

Thanks,
Omar
--0000000000004df1e006238d4e26-- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 03 09:41:22 2024 Received: (at 72925) by debbugs.gnu.org; 3 Oct 2024 13:41:22 +0000 Received: from localhost ([127.0.0.1]:60318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swM54-0004ZG-60 for submit@debbugs.gnu.org; Thu, 03 Oct 2024 09:41:22 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:60566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swM52-0004Z2-81 for 72925@debbugs.gnu.org; Thu, 03 Oct 2024 09:41:20 -0400 Received: by mail-qt1-f193.google.com with SMTP id d75a77b69052e-4582a0b438aso7567291cf.0 for <72925@debbugs.gnu.org>; Thu, 03 Oct 2024 06:41:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727962813; x=1728567613; darn=debbugs.gnu.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=hxcJaGEi7Tuny8VvSbKnxUwKTzOm1yxwm5BwC1vPymU=; b=gvwWlP8nNUytJ9cz1fr9XUGOHifQ52Bum9lpTIJVysWHVIYck1wVhDkafQ8Yhdva8Z 0xhexvHL0HwIIP54NJ5YW8SdIC5EAt9l8meAYoctOvBeu0oWcNkeCKEKBzD0WgEik97s LxZDQDUmCTp/hvxIcjEOMGoRBgrCbRRxO4wygxBdrOr68jF+AYXzu/HjwgtKqqr+OzkR P5y9FTDb5khi6lWNhCl9mEzezcolWp5UDusZZkmJiHdIkyi5m01nPCdLv1hbRHqpzVXR JFRdcQc/LijURmqfEBbi0odi3IwMOQKwd9Uu8kjJv2VfSHLyHbpF+e+K+qTsjcWQ6Swp 2o9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727962813; x=1728567613; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hxcJaGEi7Tuny8VvSbKnxUwKTzOm1yxwm5BwC1vPymU=; b=Tj1fGXZ6c/gN7hii5/ge7dk+WTlPBPp1R6nQ+nxW+0susFH+D27IO/qLFDunOYMF9o 9VUZf74bK7/LRGh/HIIGM9In47eRVl4ELgsjeg02KdrT8fsYdHSZDLA4w3nRTH1T5gfW kGAMzMZ1sE/OmK1OxWSpOVjDI2xwlDguUrqRFqfUiZcxXKEvpM21qAmkFXuGDDdWrpis bpc+1j2Lj9DbAUKMFLt7s8MOgFuy5dvXedz/yisH2bscYy8iSw6oJsu7ZPoZkm99kbcT wZDY4Zg4EN+kNCZA04h+/fN/QPW3pRmxOdWTO1Qlr4zGPPoscU5Ndo5kSd3u37BfQGH9 iEMQ== X-Forwarded-Encrypted: i=1; AJvYcCUufuH28JESNs9IPaw4VZQa+D4HkkgWuKw9bkB25dBElW2hgWwzWKNufWCFTRrluh+hEGoRNw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwoD080zDHm8pjUxyXhOcllpCkY4lY8PB9lBBtDj+AByv3fQH9h JAxGRlRrNcOFUnzqm0R4w/al8kEYmFIlCIKJMiuFctd/LkcLFGqz X-Google-Smtp-Source: AGHT+IEprmyH+AOrfly3UwyOpjOknoDYGAreYp0cR8Kcqdq2/zxAr3KJLvqYroVxiKAZR7p56SmeGw== X-Received: by 2002:a05:622a:120e:b0:458:294c:39e7 with SMTP id d75a77b69052e-45d8053d99bmr100755531cf.38.1727962812616; Thu, 03 Oct 2024 06:40:12 -0700 (PDT) Received: from gnus ([65.94.70.53]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-45d92e0fd0fsm5600821cf.24.2024.10.03.06.40.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Oct 2024 06:40:12 -0700 (PDT) From: "Suhail Singh" To: Omar Bassam Subject: Re: bug#72925: Adding JPM package for Janet In-Reply-To: (Omar Bassam's message of "Thu, 3 Oct 2024 10:14:20 +0300") References: <4e623d9571ff648ae1d1c6ffb8f9d73c421a5c10.1727683810.git.omar.bassam88@gmail.com> <87plok7kkn.fsf@gmail.com> <8734lev012.fsf@gmail.com> <875xqanty2.fsf@gmail.com> <87cyki9obi.fsf@gmail.com> <878qv69n0o.fsf@gmail.com> <874j5u7yme.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Thu, 03 Oct 2024 09:40:00 -0400 Message-ID: <87jzep2tlb.fsf_-_@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Guillaume Le Vaillant , Katherine Cox-Buday , Munyoki Kilyungi , jgart , Suhail Singh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Omar Bassam writes: > I just have some questions before submitting v8 if you don't mind. just to > make sure I understand correctly. Questions are always welcome :) >> Specifically, in the file "configs/linux_config.janet", among other >> things, the below are set >> >> #+begin_src janet >> :c++ "c++" >> :c++-link "c++" >> :cc "cc" >> :cc-link "cc" >> #+end_src >> >> Since Guix, as far as I know, doesn't have packages that provide c++ nor >> cc, I believe the above need to be patched to refer to gcc and g++ >> respectively. >> >> So we need to substitute the above "c++" and "cc" in the > "configs/linux_config.janet" to point to the absolute path for the gcc and > g++ packages? I believe there are multiple ways to make this work. I haven't tested this, so take my opinions as speculative. If we replace "cc" and "c++" with the _absolute path_ for "gcc" and "g++" respectively from the Guix store, then I don't think we need to specify gcc-toolchain as a propagated input. Upon reflecting on this, this is probably the better approach. If, however, we replace "cc" and "c++" with the _strings_ "gcc" and "g++", then I believe we may need to specify gcc-toolchain in the propagated inputs. IIUC, in this case we would replace the command that JPM invokes when building. By additionally having gcc-toolchain in the propagated inputs we'll ensure that they're available in the PATH. > Should we also replace other commands that are hard-coded like "cp" and > "chown" from coreutils the same way I did in my first initial patch? I don't believe this is necessary. There's a question regd. whether or not coreutils needs to be added to the propagated inputs, however. I don't have a definitive answer, but the way to test it would be to run it in a pure container and see if things work without having to explicitly specify coreutils. If you're unable to test it, let me know when you send v8 and I can test it on your behalf. For reference, I use something like the below: #+begin_src sh guix shell --pure -CPWN \ -E '.*GTK.*|.*XDG.*|.*DISPLAY.*|TERM|INSIDE_EMACS' \ -p /path/to/profile #+end_src > Further, I believe JPM should have a few propagated inputs: >> - gcc-toolchain >> - curl >> - git >> - nss-certs. >> >> I understand why we need gcc-toolchain. But why do we need curl, git and > nss-certs? linux_config.janet also specifies: #+begin_src janet ... :curlpath "curl" ... :gitpath "git" ... #+end_src Whether Guix packaging picks these up automatically or not, I haven't tested, but it seems for common usage of JPM these dependencies ought to be available. Similar to the case of "gcc" and "g++", it might be better to replace these with references to the respective binaries in the Guix store instead (as opposed to propagating them as I had previously suggested). Regarding nss-certs, it provides certificates for Certification Authorities which, IIUC, would be relevant for HTTPS URLs (e.g. fetching dependencies over git+https). To summarize, here's what I believe is needed. Add nss-certs to the propagated inputs, and for the below replace their occurrence in linux_config.janet with references to binaries in the store: - cc -> absolute path of gcc - c++ -> absolute path of g++ - curl -> absolute path of curl - git -> absolute path of git -- Suhail From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 03 15:46:26 2024 Received: (at 72925) by debbugs.gnu.org; 3 Oct 2024 19:46:26 +0000 Received: from localhost ([127.0.0.1]:33915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swRmM-0007rQ-0d for submit@debbugs.gnu.org; Thu, 03 Oct 2024 15:46:26 -0400 Received: from mail-pl1-f177.google.com ([209.85.214.177]:56669) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swRmJ-0007qs-RR for 72925@debbugs.gnu.org; Thu, 03 Oct 2024 15:46:24 -0400 Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-20b86298710so11668005ad.1 for <72925@debbugs.gnu.org>; Thu, 03 Oct 2024 12:46:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727984715; x=1728589515; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=7JQFuz6AeFnNqJucfFD2wDAQI3Kio1Sbt5xNkVDGspc=; b=BZJgPP0bilEPct/mvJJ7O4ujD8jIj3Q9BsiJHfonkAB59mLCMflnVN7AHL27U3xE17 OHyXGJa+eIJDTSR25HTOl5aUjTi75xjH+gvTXqLXEDEHZVT/XAkUegyPdcrHTpSyWwNp EN3Q3rD9YxOkLSNH1bctpKA0IrG84QHMfYynBTU2d82XI7Cz3Vf00Ruh+zI1yeu6cziU q/KxaTxOLWzJi3whI/OxYITiyhy8zKVAwlGOcdMZ0roL+GhenAV0nkHHPwr521njZ/xY EzuAMwKtk2QAi/aZjg07jChzU/JgA28GS/XZ1sZTogqJTsShg+KHttwsB8bSNl+CCSw5 y+hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727984715; x=1728589515; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7JQFuz6AeFnNqJucfFD2wDAQI3Kio1Sbt5xNkVDGspc=; b=gy+7wo9ti0/K9xNPpBLZ+RGDqV3RRBgA8d7HJksK0SFMuty7ypr1ATt3b185uv4Tcd KmpVf/y3LiqDKTJmyNWDNhyD0RlG6NDytATknKFT4fPgslk1e3f39Yiyr3OStGTR/+1M NRT2IZggKdKmzjWhkW+lLa5hqE2eudP2FeaDhm1Jo2wSl4qRglxWk7yxFxZOqgxxfB1O t/DJuKT9YYchCbXGxhZBTzofvwmIccCo5Rnj2e0Lan7EeJN8jus35Z/RrDwKxOzSxWpv qOkCRkU0TtcZK6nFFIRIq6HYWwloktvEwlxphQkD/1tBi8merMAKhyb6Rrn6tyzP8d/H YWcw== X-Forwarded-Encrypted: i=1; AJvYcCUcv2J2Sf8wSZ1pmLIjRVyT17hVzlgzBYy3+5UTYmjF6E76z1YiUHp8e8ri1JsAnPhy8ZcEbQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwP9E+fwOpmXNHS9vBn2h1cL9X4rO81egru/Nq+/F3bVxFw4Z0m GzAFnEmIbBUIAT0EKmEgvqRUfxDt1r6gLgPLrWw/BildjgcqDENdTGvBeafXGfbxo/avLjlL0// 8/sZwDxF57MPwfK2hBGkTFTUia4Q= X-Google-Smtp-Source: AGHT+IG6tkQfHKETQDQmvZAEXvLJzH/x2VRbJvdb9APDgHIGLmfTevkwPwiVM70TO0EaoRQHFvK561YPaUYQW+24DX0= X-Received: by 2002:a17:903:41c2:b0:20b:c1e4:2d5d with SMTP id d9443c01a7336-20bfe494d53mr3589385ad.34.1727984715433; Thu, 03 Oct 2024 12:45:15 -0700 (PDT) MIME-Version: 1.0 References: <4e623d9571ff648ae1d1c6ffb8f9d73c421a5c10.1727683810.git.omar.bassam88@gmail.com> <87plok7kkn.fsf@gmail.com> <8734lev012.fsf@gmail.com> <875xqanty2.fsf@gmail.com> <87cyki9obi.fsf@gmail.com> <878qv69n0o.fsf@gmail.com> <874j5u7yme.fsf@gmail.com> <87jzep2tlb.fsf_-_@gmail.com> In-Reply-To: <87jzep2tlb.fsf_-_@gmail.com> From: Omar Bassam Date: Thu, 3 Oct 2024 22:45:03 +0300 Message-ID: Subject: Re: bug#72925: Adding JPM package for Janet To: Suhail Singh Content-Type: multipart/alternative; boundary="000000000000240c26062397cb3a" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Guillaume Le Vaillant , Katherine Cox-Buday , Munyoki Kilyungi , jgart X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --000000000000240c26062397cb3a Content-Type: text/plain; charset="UTF-8" Hi Suhail, I really need some help here. I am having trouble using gcc-toolchain because when I add the (gnu packages commencement) modules to the lisp.scm file I get a lot of errors that I don't understand. I was able to create a local manifest file with the definition of my package and made the substitutions you suggested and added the propagated input and it worked fine. The issue that I'm having now is to include it in the lisp.scm file. Can you tell what's the right use-module form I need to use? On Thu, 3 Oct 2024 at 16:40, Suhail Singh wrote: > Omar Bassam writes: > > > I just have some questions before submitting v8 if you don't mind. just > to > > make sure I understand correctly. > > Questions are always welcome :) > > >> Specifically, in the file "configs/linux_config.janet", among other > >> things, the below are set > >> > >> #+begin_src janet > >> :c++ "c++" > >> :c++-link "c++" > >> :cc "cc" > >> :cc-link "cc" > >> #+end_src > >> > >> Since Guix, as far as I know, doesn't have packages that provide c++ nor > >> cc, I believe the above need to be patched to refer to gcc and g++ > >> respectively. > >> > >> So we need to substitute the above "c++" and "cc" in the > > "configs/linux_config.janet" to point to the absolute path for the gcc > and > > g++ packages? > > I believe there are multiple ways to make this work. I haven't tested > this, so take my opinions as speculative. > > If we replace "cc" and "c++" with the _absolute path_ for "gcc" and > "g++" respectively from the Guix store, then I don't think we need to > specify gcc-toolchain as a propagated input. Upon reflecting on this, > this is probably the better approach. > > If, however, we replace "cc" and "c++" with the _strings_ "gcc" and > "g++", then I believe we may need to specify gcc-toolchain in the > propagated inputs. IIUC, in this case we would replace the command that > JPM invokes when building. By additionally having gcc-toolchain in the > propagated inputs we'll ensure that they're available in the PATH. > > > Should we also replace other commands that are hard-coded like "cp" and > > "chown" from coreutils the same way I did in my first initial patch? > > I don't believe this is necessary. There's a question regd. whether or > not coreutils needs to be added to the propagated inputs, however. I > don't have a definitive answer, but the way to test it would be to run > it in a pure container and see if things work without having to > explicitly specify coreutils. If you're unable to test it, let me know > when you send v8 and I can test it on your behalf. > > For reference, I use something like the below: > #+begin_src sh > guix shell --pure -CPWN \ > -E '.*GTK.*|.*XDG.*|.*DISPLAY.*|TERM|INSIDE_EMACS' \ > -p /path/to/profile > #+end_src > > > Further, I believe JPM should have a few propagated inputs: > >> - gcc-toolchain > >> - curl > >> - git > >> - nss-certs. > >> > >> I understand why we need gcc-toolchain. But why do we need curl, git and > > nss-certs? > > linux_config.janet also specifies: > > #+begin_src janet > ... > :curlpath "curl" > ... > :gitpath "git" > ... > #+end_src > > Whether Guix packaging picks these up automatically or not, I haven't > tested, but it seems for common usage of JPM these dependencies ought to > be available. Similar to the case of "gcc" and "g++", it might be > better to replace these with references to the respective binaries in > the Guix store instead (as opposed to propagating them as I had > previously suggested). > > Regarding nss-certs, it provides certificates for Certification > Authorities which, IIUC, would be relevant for HTTPS URLs (e.g. fetching > dependencies over git+https). > > To summarize, here's what I believe is needed. Add nss-certs to the > propagated inputs, and for the below replace their occurrence in > linux_config.janet with references to binaries in the store: > - cc -> absolute path of gcc > - c++ -> absolute path of g++ > - curl -> absolute path of curl > - git -> absolute path of git > > -- > Suhail > --000000000000240c26062397cb3a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Suhail,
I really need some help her= e.
I am having trouble using gcc-toolchain because when I ad= d the (gnu packages commencement) modules to the lisp.scm file I get a lot = of errors that I don't understand.
I was able to create a loc= al manifest file with the definition of my package and made the substitutio= ns you suggested and added the propagated input and it worked fine.
The issue that I'm having now is to include it in the lisp.scm = file.
Can you tell what's the right use-module form I ne= ed to use?

On Thu, 3 Oct 2024 at 16:40, Suhail Singh <suhailsingh247@gmail.com> wrote= :
Omar Bassam &l= t;omar.bassam8= 8@gmail.com> writes:

> I just have some questions before submitting v8 if you don't mind.= just to
> make sure I understand correctly.

Questions are always welcome :)

>> Specifically, in the file "configs/linux_config.janet", = among other
>> things, the below are set
>>
>> #+begin_src janet
>>=C2=A0 =C2=A0 :c++ "c++"
>>=C2=A0 =C2=A0 :c++-link "c++"
>>=C2=A0 =C2=A0 :cc "cc"
>>=C2=A0 =C2=A0 :cc-link "cc"
>> #+end_src
>>
>> Since Guix, as far as I know, doesn't have packages that provi= de c++ nor
>> cc, I believe the above need to be patched to refer to gcc and g++=
>> respectively.
>>
>> So we need to substitute the above "c++" and "cc&qu= ot; in the
> "configs/linux_config.janet" to point to the absolute path f= or the gcc and
> g++ packages?

I believe there are multiple ways to make this work.=C2=A0 I haven't te= sted
this, so take my opinions as speculative.

If we replace "cc" and "c++" with the _absolute path_ f= or "gcc" and
"g++" respectively from the Guix store, then I don't think we= need to
specify gcc-toolchain as a propagated input.=C2=A0 Upon reflecting on this,=
this is probably the better approach.

If, however, we replace "cc" and "c++" with the _string= s_ "gcc" and
"g++", then I believe we may need to specify gcc-toolchain in the=
propagated inputs.=C2=A0 IIUC, in this case we would replace the command th= at
JPM invokes when building.=C2=A0 By additionally having gcc-toolchain in th= e
propagated inputs we'll ensure that they're available in the PATH.<= br>
> Should we also replace other commands that are hard-coded like "c= p" and
> "chown" from coreutils the same way I did in my first initia= l patch?

I don't believe this is necessary.=C2=A0 There's a question regd. w= hether or
not coreutils needs to be added to the propagated inputs, however.=C2=A0 I<= br> don't have a definitive answer, but the way to test it would be to run<= br> it in a pure container and see if things work without having to
explicitly specify coreutils.=C2=A0 If you're unable to test it, let me= know
when you send v8 and I can test it on your behalf.

For reference, I use something like the below:
#+begin_src sh
=C2=A0 guix shell --pure -CPWN \
=C2=A0 =C2=A0 -E '.*GTK.*|.*XDG.*|.*DISPLAY.*|TERM|INSIDE_EMACS' \<= br> =C2=A0 =C2=A0 -p /path/to/profile
#+end_src

> Further, I believe JPM should have a few propagated inputs:
>> - gcc-toolchain
>> - curl
>> - git
>> - nss-certs.
>>
>> I understand why we need gcc-toolchain. But why do we need curl, g= it and
> nss-certs?

linux_config.janet also specifies:

#+begin_src janet
=C2=A0 =C2=A0...
=C2=A0 =C2=A0:curlpath "curl"
=C2=A0 =C2=A0...
=C2=A0 =C2=A0:gitpath "git"
=C2=A0 =C2=A0...
#+end_src

Whether Guix packaging picks these up automatically or not, I haven't tested, but it seems for common usage of JPM these dependencies ought to be available.=C2=A0 Similar to the case of "gcc" and "g++&qu= ot;, it might be
better to replace these with references to the respective binaries in
the Guix store instead (as opposed to propagating them as I had
previously suggested).

Regarding nss-certs, it provides certificates for Certification
Authorities which, IIUC, would be relevant for HTTPS URLs (e.g. fetching dependencies over git+https).

To summarize, here's what I believe is needed.=C2=A0 Add nss-certs to t= he
propagated inputs, and for the below replace their occurrence in
linux_config.janet with references to binaries in the store:
- cc -> absolute path of gcc
- c++ -> absolute path of g++
- curl -> absolute path of curl
- git -> absolute path of git

--
Suhail
--000000000000240c26062397cb3a-- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 03 18:06:18 2024 Received: (at 72925) by debbugs.gnu.org; 3 Oct 2024 22:06:18 +0000 Received: from localhost ([127.0.0.1]:34046 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swTxh-0006vA-M9 for submit@debbugs.gnu.org; Thu, 03 Oct 2024 18:06:18 -0400 Received: from mail-pg1-f174.google.com ([209.85.215.174]:45171) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swTxf-0006ut-Ld for 72925@debbugs.gnu.org; Thu, 03 Oct 2024 18:06:16 -0400 Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-7e6bb2aa758so649685a12.2 for <72925@debbugs.gnu.org>; Thu, 03 Oct 2024 15:06:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727993107; x=1728597907; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=bOxF7+LD45PHc4mOVJgDLCiOMWlGfj5INYWg6Eb35O8=; b=Qj7gATJBa726KH9OqxLRxuW7jMvwsC5Lz0vQasYF+sI74b2L+2fC04wqzgNGo2rCuk v13WR3X4VR+ORQvvOmBIlPjAZyXi+tsVGuu/zWKRRydvSFME3afOnz5HasjnNif/WppA 3x6f0Zre59oFGdqeRaDpWxe5YXbLVpoojmxYmTzCI41J2IV7e0IcubqJcp8D4qi8M0vK q5InQC6zowBcxBWGBDFBDsC2wazN4BaTdrWA/PwwnqVyNnz1oJKrSlkvOMW/L13NYSHD VEEx5wSLDXrHrOTL2oIFurT1OeNzrdYM8D8T0xg8R7HrJTiBzaEbWB9hNUoxqlOKi8yz F3GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727993107; x=1728597907; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bOxF7+LD45PHc4mOVJgDLCiOMWlGfj5INYWg6Eb35O8=; b=BW6RSySrygJKebDdzBoAsgqa+Bb4CSaQAVC4d/kfRg/2INekQlLxbQ6u8UIZU63xA7 TsSouWMjpehc0dj62/NYBE5B+rYb20d9j94pgx1abkvizSvcaR2kltwdQZYz3e3crXn9 CgCi87iU/oXr0g/L20sD9PrvxYIm00kakpdOqcNAMJw5zy3HPrrtenWmFWVdSbLcqC+u OYuCZLt3mSmybL2yKzcQ8xkJO8GaxpLiq5L2X6igSKXK7fC2MUfgkHGbxdGijXiIVglM +DHnsKOyukYae1QWWdXydDISPVsVUn02kjj822n95xfqRogU11CaYK/o2aOnAKA40w1J szKg== X-Forwarded-Encrypted: i=1; AJvYcCXrbSaR6T0qf9WcjH2rjE6UyzVqY+DC8mufavwkI6vDVhQ95g7L++LR2WP2Xtm1pVPVFUru9A==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yxnpm07U/LmkRyEHdHHJL0bcTBbBszInWvqAp/xISkjuYvtMzK4 r9ZBRCPbso3zmRQN339QW7bpFqhRHU677i8ZuWi8y1n7sfAB2ObL7X2t+MJFd/r7l+hynB5yBg+ /0zKNfS5DNGOyDjRqRhZJiaX3pw8= X-Google-Smtp-Source: AGHT+IHZegmUcZ1cY2qiHHK2g+koT6Vjg+swAa/BsMCwc7yrfAoCLAURWy2gbSSVHwL3Alsgqmzjkr7nEmPwkLMXu/4= X-Received: by 2002:a17:90a:640b:b0:2dd:5e86:8c2f with SMTP id 98e67ed59e1d1-2e1e626c37emr589554a91.21.1727993107303; Thu, 03 Oct 2024 15:05:07 -0700 (PDT) MIME-Version: 1.0 References: <4e623d9571ff648ae1d1c6ffb8f9d73c421a5c10.1727683810.git.omar.bassam88@gmail.com> <87plok7kkn.fsf@gmail.com> <8734lev012.fsf@gmail.com> <875xqanty2.fsf@gmail.com> <87cyki9obi.fsf@gmail.com> <878qv69n0o.fsf@gmail.com> <874j5u7yme.fsf@gmail.com> <87jzep2tlb.fsf_-_@gmail.com> In-Reply-To: From: Omar Bassam Date: Fri, 4 Oct 2024 01:04:55 +0300 Message-ID: Subject: Re: bug#72925: Adding JPM package for Janet To: Suhail Singh Content-Type: multipart/alternative; boundary="00000000000055d65c062399bfe7" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Guillaume Le Vaillant , Katherine Cox-Buday , Munyoki Kilyungi , jgart X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --00000000000055d65c062399bfe7 Content-Type: text/plain; charset="UTF-8" It's OK I figured it out now. I'll be posting the patch soon. On Thu, 3 Oct 2024 at 22:45, Omar Bassam wrote: > Hi Suhail, > I really need some help here. > I am having trouble using gcc-toolchain because when I add the (gnu > packages commencement) modules to the lisp.scm file I get a lot of errors > that I don't understand. > I was able to create a local manifest file with the definition of my > package and made the substitutions you suggested and added the propagated > input and it worked fine. > The issue that I'm having now is to include it in the lisp.scm file. > Can you tell what's the right use-module form I need to use? > > On Thu, 3 Oct 2024 at 16:40, Suhail Singh > wrote: > >> Omar Bassam writes: >> >> > I just have some questions before submitting v8 if you don't mind. just >> to >> > make sure I understand correctly. >> >> Questions are always welcome :) >> >> >> Specifically, in the file "configs/linux_config.janet", among other >> >> things, the below are set >> >> >> >> #+begin_src janet >> >> :c++ "c++" >> >> :c++-link "c++" >> >> :cc "cc" >> >> :cc-link "cc" >> >> #+end_src >> >> >> >> Since Guix, as far as I know, doesn't have packages that provide c++ >> nor >> >> cc, I believe the above need to be patched to refer to gcc and g++ >> >> respectively. >> >> >> >> So we need to substitute the above "c++" and "cc" in the >> > "configs/linux_config.janet" to point to the absolute path for the gcc >> and >> > g++ packages? >> >> I believe there are multiple ways to make this work. I haven't tested >> this, so take my opinions as speculative. >> >> If we replace "cc" and "c++" with the _absolute path_ for "gcc" and >> "g++" respectively from the Guix store, then I don't think we need to >> specify gcc-toolchain as a propagated input. Upon reflecting on this, >> this is probably the better approach. >> >> If, however, we replace "cc" and "c++" with the _strings_ "gcc" and >> "g++", then I believe we may need to specify gcc-toolchain in the >> propagated inputs. IIUC, in this case we would replace the command that >> JPM invokes when building. By additionally having gcc-toolchain in the >> propagated inputs we'll ensure that they're available in the PATH. >> >> > Should we also replace other commands that are hard-coded like "cp" and >> > "chown" from coreutils the same way I did in my first initial patch? >> >> I don't believe this is necessary. There's a question regd. whether or >> not coreutils needs to be added to the propagated inputs, however. I >> don't have a definitive answer, but the way to test it would be to run >> it in a pure container and see if things work without having to >> explicitly specify coreutils. If you're unable to test it, let me know >> when you send v8 and I can test it on your behalf. >> >> For reference, I use something like the below: >> #+begin_src sh >> guix shell --pure -CPWN \ >> -E '.*GTK.*|.*XDG.*|.*DISPLAY.*|TERM|INSIDE_EMACS' \ >> -p /path/to/profile >> #+end_src >> >> > Further, I believe JPM should have a few propagated inputs: >> >> - gcc-toolchain >> >> - curl >> >> - git >> >> - nss-certs. >> >> >> >> I understand why we need gcc-toolchain. But why do we need curl, git >> and >> > nss-certs? >> >> linux_config.janet also specifies: >> >> #+begin_src janet >> ... >> :curlpath "curl" >> ... >> :gitpath "git" >> ... >> #+end_src >> >> Whether Guix packaging picks these up automatically or not, I haven't >> tested, but it seems for common usage of JPM these dependencies ought to >> be available. Similar to the case of "gcc" and "g++", it might be >> better to replace these with references to the respective binaries in >> the Guix store instead (as opposed to propagating them as I had >> previously suggested). >> >> Regarding nss-certs, it provides certificates for Certification >> Authorities which, IIUC, would be relevant for HTTPS URLs (e.g. fetching >> dependencies over git+https). >> >> To summarize, here's what I believe is needed. Add nss-certs to the >> propagated inputs, and for the below replace their occurrence in >> linux_config.janet with references to binaries in the store: >> - cc -> absolute path of gcc >> - c++ -> absolute path of g++ >> - curl -> absolute path of curl >> - git -> absolute path of git >> >> -- >> Suhail >> > --00000000000055d65c062399bfe7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
It's OK I figured it out now. I'll be posting the = patch soon.

On Thu, 3 Oct 2024 at 22:45, Omar Bassam <omar.bassam88@gmail.com> wrote:
H= i Suhail,
I really need some help here.
I am = having trouble using gcc-toolchain because when I add the (gnu packages com= mencement) modules to the lisp.scm file I get a lot of errors that I don= 9;t understand.
I was able to create a local manifest file with t= he definition of my package and made the substitutions you suggested and ad= ded the propagated input and it worked fine.
The issue that = I'm having now is to include it in the lisp.scm file.
Ca= n you tell what's the right use-module form I need to use?

On = Thu, 3 Oct 2024 at 16:40, Suhail Singh <suhailsingh247@gmail.com> wrote:
Omar Bassam <omar.bassam88@gmail= .com> writes:

> I just have some questions before submitting v8 if you don't mind.= just to
> make sure I understand correctly.

Questions are always welcome :)

>> Specifically, in the file "configs/linux_config.janet", = among other
>> things, the below are set
>>
>> #+begin_src janet
>>=C2=A0 =C2=A0 :c++ "c++"
>>=C2=A0 =C2=A0 :c++-link "c++"
>>=C2=A0 =C2=A0 :cc "cc"
>>=C2=A0 =C2=A0 :cc-link "cc"
>> #+end_src
>>
>> Since Guix, as far as I know, doesn't have packages that provi= de c++ nor
>> cc, I believe the above need to be patched to refer to gcc and g++=
>> respectively.
>>
>> So we need to substitute the above "c++" and "cc&qu= ot; in the
> "configs/linux_config.janet" to point to the absolute path f= or the gcc and
> g++ packages?

I believe there are multiple ways to make this work.=C2=A0 I haven't te= sted
this, so take my opinions as speculative.

If we replace "cc" and "c++" with the _absolute path_ f= or "gcc" and
"g++" respectively from the Guix store, then I don't think we= need to
specify gcc-toolchain as a propagated input.=C2=A0 Upon reflecting on this,=
this is probably the better approach.

If, however, we replace "cc" and "c++" with the _string= s_ "gcc" and
"g++", then I believe we may need to specify gcc-toolchain in the=
propagated inputs.=C2=A0 IIUC, in this case we would replace the command th= at
JPM invokes when building.=C2=A0 By additionally having gcc-toolchain in th= e
propagated inputs we'll ensure that they're available in the PATH.<= br>
> Should we also replace other commands that are hard-coded like "c= p" and
> "chown" from coreutils the same way I did in my first initia= l patch?

I don't believe this is necessary.=C2=A0 There's a question regd. w= hether or
not coreutils needs to be added to the propagated inputs, however.=C2=A0 I<= br> don't have a definitive answer, but the way to test it would be to run<= br> it in a pure container and see if things work without having to
explicitly specify coreutils.=C2=A0 If you're unable to test it, let me= know
when you send v8 and I can test it on your behalf.

For reference, I use something like the below:
#+begin_src sh
=C2=A0 guix shell --pure -CPWN \
=C2=A0 =C2=A0 -E '.*GTK.*|.*XDG.*|.*DISPLAY.*|TERM|INSIDE_EMACS' \<= br> =C2=A0 =C2=A0 -p /path/to/profile
#+end_src

> Further, I believe JPM should have a few propagated inputs:
>> - gcc-toolchain
>> - curl
>> - git
>> - nss-certs.
>>
>> I understand why we need gcc-toolchain. But why do we need curl, g= it and
> nss-certs?

linux_config.janet also specifies:

#+begin_src janet
=C2=A0 =C2=A0...
=C2=A0 =C2=A0:curlpath "curl"
=C2=A0 =C2=A0...
=C2=A0 =C2=A0:gitpath "git"
=C2=A0 =C2=A0...
#+end_src

Whether Guix packaging picks these up automatically or not, I haven't tested, but it seems for common usage of JPM these dependencies ought to be available.=C2=A0 Similar to the case of "gcc" and "g++&qu= ot;, it might be
better to replace these with references to the respective binaries in
the Guix store instead (as opposed to propagating them as I had
previously suggested).

Regarding nss-certs, it provides certificates for Certification
Authorities which, IIUC, would be relevant for HTTPS URLs (e.g. fetching dependencies over git+https).

To summarize, here's what I believe is needed.=C2=A0 Add nss-certs to t= he
propagated inputs, and for the below replace their occurrence in
linux_config.janet with references to binaries in the store:
- cc -> absolute path of gcc
- c++ -> absolute path of g++
- curl -> absolute path of curl
- git -> absolute path of git

--
Suhail
--00000000000055d65c062399bfe7-- From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 04 11:58:50 2024 Received: (at 72925) by debbugs.gnu.org; 4 Oct 2024 15:58:50 +0000 Received: from localhost ([127.0.0.1]:36312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swkhe-0005nf-4D for submit@debbugs.gnu.org; Fri, 04 Oct 2024 11:58:50 -0400 Received: from mail-ej1-f52.google.com ([209.85.218.52]:54493) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swkhc-0005nX-5N for 72925@debbugs.gnu.org; Fri, 04 Oct 2024 11:58:49 -0400 Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-a8d43657255so350100366b.0 for <72925@debbugs.gnu.org>; Fri, 04 Oct 2024 08:58:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728057463; x=1728662263; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=/AHCNYS+D25XpLGVSbGvwI5mif2B6pxJHFnzdTfatNs=; b=iodjar4tnYfbLaEG7kzHxGAcZSJJwHA2BRlKWCpRnAvuRROPXvFUJkhEt8MhPQDTJw JzlpTkQqB5nPoD6xQqnnRWwJLnCnHWP71EZ1pjNUVz27iK7BCdtj4cN4gL0oIzJyxDOe VI+ZrKsHa9dtcUb14n/i3c3uH+NTNFIHq7u3p2dhO305eKdiQtCBARArJUV1aNHEkJIW Kq49SxD5sj/bNOB0T3XfL07EX+48wnoq0CAuT8mYcpiH4J8tE6ad9pH7D4xNau3mOFai BK4LEC4SNlLi4pJs1wisc3/kDZw3r/PXOYnYUJjhd7aASqmWPKkJDP3mEFjfQVZC+ZcC dcfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728057463; x=1728662263; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/AHCNYS+D25XpLGVSbGvwI5mif2B6pxJHFnzdTfatNs=; b=Iz9Zc98hVT6+BGK5ryfiRqGO7IktD+9+vTV4g6uYYy4TKg2vZJQe7Rm7GRT7b97Vev So55RG5m8yuptEensSnWJYb5X4O16fyGuUjzNdvXrT0orLhS7qqOoKqPqsKoeR5RVm8A 7pDSYfmSk1bkAvcdAmkrOUHRXcmMqW/LXUuLeIvVW1s2alae7Uz60W3ubNB27wOIM5Xi Pf6lVuubLnHNq/NPIlxDolBp7ZyfPM1314S2fu7Nbw54wvAsYDY0ctaKL1s7RqOKxxMY FhFaB1Reget9k7dnczbXkqFCSaLubXPta9YgphyCbyhmpXZELgearHwDJPzYXrtEtmtJ 7Y8g== X-Gm-Message-State: AOJu0YzlK52dEfJV1xMEjAV/fO7WYuvTVpNXB4CI+RS0ilWv9PCr5gjo BaS+/8Ff6FzsA4UaQYRjz8Y647SbENuR0tGhNKmP4DeprgtkITLoSX+d9vuC X-Google-Smtp-Source: AGHT+IGz6HSmop5k/doDCuIOqHoo3GuyBTsoutXrVjZ87Y/jzf40Mxva7wj9g6fdubF9WWIvH7k+nA== X-Received: by 2002:a17:907:3f16:b0:a98:ec66:5e3f with SMTP id a640c23a62f3a-a991c053bcamr337256566b.58.1728057463061; Fri, 04 Oct 2024 08:57:43 -0700 (PDT) Received: from omar-Latitude-5540.. ([46.232.152.32]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a992e7ed135sm7851866b.218.2024.10.04.08.57.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Oct 2024 08:57:42 -0700 (PDT) From: Omar Bassam To: 72925@debbugs.gnu.org Subject: [PATCH v8] gnu: add jpm package Date: Fri, 4 Oct 2024 18:57:36 +0300 Message-ID: <8223c6391ac0b6a7d0aba42d32eb037c2deef26d.1728055031.git.omar.bassam88@gmail.com> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 X-Debbugs-Cc: Guillaume Le Vaillant , Katherine Cox-Buday , Munyoki Kilyungi , Sharlatan Hellseher , jgart Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: Omar Bassam X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/packages/lisp.scm (jpm): New Variable Change-Id: I92cf244ab23062ae3448099506d1b068394d7094 --- gnu/packages/lisp.scm | 72 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 72 insertions(+) diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm index 6c16d8ab71..ee9913f14e 100644 --- a/gnu/packages/lisp.scm +++ b/gnu/packages/lisp.scm @@ -29,6 +29,7 @@ ;;; Copyright © 2024 Andreas Enge ;;; Copyright © 2024 bigbug ;;; Copyright © 2024 Ashish SHUKLA +;;; Copyright © 2024 Omar Bassam ;;; ;;; This file is part of GNU Guix. ;;; @@ -70,6 +71,7 @@ (define-module (gnu packages lisp) #:use-module (gnu packages bdw-gc) #:use-module (gnu packages boost) #:use-module (gnu packages check) + #:use-module (gnu packages certs) #:use-module (gnu packages compression) #:use-module (gnu packages crypto) #:use-module (gnu packages curl) @@ -917,6 +919,76 @@ (define-public janet assembler, PEG) is less than 1MB.") (license license:expat))) +(define-public jpm + (package + (name "jpm") + (version "1.1.0") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/janet-lang/jpm.git") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 "05rdxigmiy7vf93s16a8n2029lq33073jccz1rjl4iisxj6piw4l")))) + (build-system copy-build-system) + (arguments + (list + #:phases #~(modify-phases %standard-phases + (add-after 'unpack 'fix-paths + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "configs/linux_config.janet" + (("/usr/local") + #$output) + (("\"cc\"") + (string-append "\"" + (assoc-ref inputs "gcc-toolchain") + "/bin/gcc" "\"")) + (("\"c++\"") + (string-append "\"" + (assoc-ref inputs "gcc-toolchain") + "/bin/g++" "\"")) + (("\"git\"") + (string-append "\"" + #$git "/bin/git" "\"")) + (("\"curl\"") + (string-append "\"" + #$curl "/bin/curl" "\""))) + (substitute* "jpm/shutil.janet" + (("cp") + (string-append #$coreutils "/bin/cp"))) + (setenv "PREFIX" + #$output))) + (replace 'install + (lambda _ + (for-each (lambda (dir) + (mkdir-p (string-append #$output "/" dir))) + '("lib/janet/jpm" "share/man/man1")) + (invoke "janet" "bootstrap.janet" + "configs/linux_config.janet") + (wrap-program (string-append #$output "/bin/jpm") + `("JANET_HEADERPATH" ":" = + (,(string-append #$janet "/include/janet"))) + `("JANET_LIBPATH" ":" = + (,(string-append #$janet "/lib"))))))))) + (inputs (list bash-minimal janet)) + (propagated-inputs (list janet + coreutils + git + curl + nss-certs + ;; Lazily resolve the gcc-toolchain to avoid + ;; a circular dependency. + (module-ref (resolve-interface '(gnu packages + commencement)) + 'gcc-toolchain))) + (home-page "https://janet-lang.org/") + (synopsis "Janet Project Manager for the Janet programming language") + (description "JPM is the Janet Project Manager tool. It is for automating +builds and downloading dependencies of Janet projects.") + (license license:expat))) + (define-public lisp-repl-core-dumper (package (name "lisp-repl-core-dumper") base-commit: ebb715aabfc4e59ed14b964ac7fdd2a9f9f44526 -- 2.45.2 From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 04 12:01:48 2024 Received: (at 72925) by debbugs.gnu.org; 4 Oct 2024 16:01:48 +0000 Received: from localhost ([127.0.0.1]:36320 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swkkV-000629-Ug for submit@debbugs.gnu.org; Fri, 04 Oct 2024 12:01:48 -0400 Received: from mail-pj1-f49.google.com ([209.85.216.49]:44164) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swkkT-00061s-An for 72925@debbugs.gnu.org; Fri, 04 Oct 2024 12:01:46 -0400 Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-2e0b9bca173so1731999a91.0 for <72925@debbugs.gnu.org>; Fri, 04 Oct 2024 09:01:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728057636; x=1728662436; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=tzkg8vk81MRTRUWSfwA1H5huGoSPu/bj4kiqA8+HHM0=; b=mD1T5OQuCWlYsjGOqSUtGPPzanmACmFxoc/hoa93NPmJXu4I6zwLwWVkrl3L7l3HmA 3hEIiMSAx/GzZ6cE3Z8+HSzkvRrapIxg9Viak3F7CGyhjWJKPoZTznYPkQUE5zlfK6qc 3MJUA9L4JEPYEMiasiI6yYuRreFyEtN21Hp07bLohOrMlEnKIBVzxO4qTlK/vXUVkeut hIhv7F0xGV3Ty2wM5X054GSJ1i3v8tPzMLMxfcqmUdIxe5RWuXd3U//bK3BE33nqxsJa +OLrZqD/nu0RGa5HZBeLImhSTlX9iFrLQQGlIv9ijZcKeS7Heb6ZOPp3WMwbMZjsFamo TjOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728057636; x=1728662436; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tzkg8vk81MRTRUWSfwA1H5huGoSPu/bj4kiqA8+HHM0=; b=j4l72bqK3+oI6OJD3U5FtGP7WigBayKtxX3/kl2ZpThT1wYf9ix49FQf/SRovF9FSc +v81XP/TReOcRZk/5sdmN14yyYbAzei/4oR5sdIRn98/6KQ0u5AY5eXVMCGl/mKkAIz5 y0M25vDUrsikuVkulI5gFndo/kOaOwru02O/XLm/7RI0UlO7uvRaI0eAMLsSuDo+Upn1 GXCZcRR1Aa0SHBNZMU+dfGklW/Iw6z0I2RU866NmUrZ+quZJYfHLDa3yrKbZCOKfO/B0 KaVN6DI37jSJaPSO7wh1NTaQBA41QSNUyTxfZ5SilDRbT7u9YMaWJEF6QCPHExRathoI 8dDg== X-Forwarded-Encrypted: i=1; AJvYcCWonrmRdv5awoMDVap7Or+79mKCIJCD3JjDVPqMQxHEckuXcLVj+WnJugzI8MgG91ifO2Okpw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyiyRaRKaU3akHHC44qxWw/EMk4Y7bllJY5C58xC6bEcZqJGuwX Bzh+XMWyJGTBVTA+Pac2EaLYLDlUL7jNcVrshn5t6ztTSF9OjoAied0C/tg5r1cGxCg1PomQ9ct v8XpPq3GTwwGCjauLcJbc22hXkFI= X-Google-Smtp-Source: AGHT+IH5DruoGEdwO+5YJfcPOrmRrtXqhriPFspLOFynynGWZ3jQEJ4akIlia9mCyMyifggRKTET+vUaVz9umrAaG9w= X-Received: by 2002:a17:90b:3806:b0:2e0:80e8:a31a with SMTP id 98e67ed59e1d1-2e1e636f5c3mr3168401a91.35.1728057635801; Fri, 04 Oct 2024 09:00:35 -0700 (PDT) MIME-Version: 1.0 References: <4e623d9571ff648ae1d1c6ffb8f9d73c421a5c10.1727683810.git.omar.bassam88@gmail.com> <87plok7kkn.fsf@gmail.com> <8734lev012.fsf@gmail.com> <875xqanty2.fsf@gmail.com> <87cyki9obi.fsf@gmail.com> <878qv69n0o.fsf@gmail.com> <874j5u7yme.fsf@gmail.com> <87jzep2tlb.fsf_-_@gmail.com> In-Reply-To: From: Omar Bassam Date: Fri, 4 Oct 2024 19:00:23 +0300 Message-ID: Subject: Re: bug#72925: Adding JPM package for Janet To: Suhail Singh Content-Type: multipart/alternative; boundary="0000000000008895b10623a8c547" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Guillaume Le Vaillant , Katherine Cox-Buday , Munyoki Kilyungi , jgart X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --0000000000008895b10623a8c547 Content-Type: text/plain; charset="UTF-8" Hi Suhail, I just submitted a new path v8. I tested in a pure container shell and it worked for me for the following commands: - "jpm install -l sh" - "jpm install -l spork" - "jpm build" : for a basic hello world project Can you please have another look and let me know if you have any comments Thanks, *Omar* On Fri, 4 Oct 2024 at 01:04, Omar Bassam wrote: > It's OK I figured it out now. I'll be posting the patch soon. > > On Thu, 3 Oct 2024 at 22:45, Omar Bassam wrote: > >> Hi Suhail, >> I really need some help here. >> I am having trouble using gcc-toolchain because when I add the (gnu >> packages commencement) modules to the lisp.scm file I get a lot of errors >> that I don't understand. >> I was able to create a local manifest file with the definition of my >> package and made the substitutions you suggested and added the propagated >> input and it worked fine. >> The issue that I'm having now is to include it in the lisp.scm file. >> Can you tell what's the right use-module form I need to use? >> >> On Thu, 3 Oct 2024 at 16:40, Suhail Singh >> wrote: >> >>> Omar Bassam writes: >>> >>> > I just have some questions before submitting v8 if you don't mind. >>> just to >>> > make sure I understand correctly. >>> >>> Questions are always welcome :) >>> >>> >> Specifically, in the file "configs/linux_config.janet", among other >>> >> things, the below are set >>> >> >>> >> #+begin_src janet >>> >> :c++ "c++" >>> >> :c++-link "c++" >>> >> :cc "cc" >>> >> :cc-link "cc" >>> >> #+end_src >>> >> >>> >> Since Guix, as far as I know, doesn't have packages that provide c++ >>> nor >>> >> cc, I believe the above need to be patched to refer to gcc and g++ >>> >> respectively. >>> >> >>> >> So we need to substitute the above "c++" and "cc" in the >>> > "configs/linux_config.janet" to point to the absolute path for the gcc >>> and >>> > g++ packages? >>> >>> I believe there are multiple ways to make this work. I haven't tested >>> this, so take my opinions as speculative. >>> >>> If we replace "cc" and "c++" with the _absolute path_ for "gcc" and >>> "g++" respectively from the Guix store, then I don't think we need to >>> specify gcc-toolchain as a propagated input. Upon reflecting on this, >>> this is probably the better approach. >>> >>> If, however, we replace "cc" and "c++" with the _strings_ "gcc" and >>> "g++", then I believe we may need to specify gcc-toolchain in the >>> propagated inputs. IIUC, in this case we would replace the command that >>> JPM invokes when building. By additionally having gcc-toolchain in the >>> propagated inputs we'll ensure that they're available in the PATH. >>> >>> > Should we also replace other commands that are hard-coded like "cp" and >>> > "chown" from coreutils the same way I did in my first initial patch? >>> >>> I don't believe this is necessary. There's a question regd. whether or >>> not coreutils needs to be added to the propagated inputs, however. I >>> don't have a definitive answer, but the way to test it would be to run >>> it in a pure container and see if things work without having to >>> explicitly specify coreutils. If you're unable to test it, let me know >>> when you send v8 and I can test it on your behalf. >>> >>> For reference, I use something like the below: >>> #+begin_src sh >>> guix shell --pure -CPWN \ >>> -E '.*GTK.*|.*XDG.*|.*DISPLAY.*|TERM|INSIDE_EMACS' \ >>> -p /path/to/profile >>> #+end_src >>> >>> > Further, I believe JPM should have a few propagated inputs: >>> >> - gcc-toolchain >>> >> - curl >>> >> - git >>> >> - nss-certs. >>> >> >>> >> I understand why we need gcc-toolchain. But why do we need curl, git >>> and >>> > nss-certs? >>> >>> linux_config.janet also specifies: >>> >>> #+begin_src janet >>> ... >>> :curlpath "curl" >>> ... >>> :gitpath "git" >>> ... >>> #+end_src >>> >>> Whether Guix packaging picks these up automatically or not, I haven't >>> tested, but it seems for common usage of JPM these dependencies ought to >>> be available. Similar to the case of "gcc" and "g++", it might be >>> better to replace these with references to the respective binaries in >>> the Guix store instead (as opposed to propagating them as I had >>> previously suggested). >>> >>> Regarding nss-certs, it provides certificates for Certification >>> Authorities which, IIUC, would be relevant for HTTPS URLs (e.g. fetching >>> dependencies over git+https). >>> >>> To summarize, here's what I believe is needed. Add nss-certs to the >>> propagated inputs, and for the below replace their occurrence in >>> linux_config.janet with references to binaries in the store: >>> - cc -> absolute path of gcc >>> - c++ -> absolute path of g++ >>> - curl -> absolute path of curl >>> - git -> absolute path of git >>> >>> -- >>> Suhail >>> >> --0000000000008895b10623a8c547 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Suhail,

I just submitted = a new path v8. I tested in a pure container shell and it worked for me for = the following commands:

- "jpm install -l sh&= quot;
- "jpm install -l spork"
- "jpm bu= ild" : for a basic hello world project

Can yo= u please have another look and let me know if you have any comments

Thanks,
Omar

On Fri, 4 Oct 2024= at 01:04, Omar Bassam <omar.= bassam88@gmail.com> wrote:
It's OK I figured it out now. I'= ll be posting the patch soon.

On Thu, 3 Oct 2024 at 22:45, Omar Bassam &= lt;omar.bassam= 88@gmail.com> wrote:
Hi Suhail,
I really need s= ome help here.
I am having trouble using gcc-toolchain becau= se when I add the (gnu packages commencement) modules to the lisp.scm file = I get a lot of errors that I don't understand.
I was able to = create a local manifest file with the definition of my package and made the= substitutions you suggested and added the propagated input and it worked f= ine.
The issue that I'm having now is to include it in t= he lisp.scm file.
Can you tell what's the right use-modu= le form I need to use?

On Thu, 3 Oct 2024 at 16:40, Suhail Singh &= lt;suhailsing= h247@gmail.com> wrote:
Omar Bassam <omar.bassam88@gmail.com> writes:

> I just have some questions before submitting v8 if you don't mind.= just to
> make sure I understand correctly.

Questions are always welcome :)

>> Specifically, in the file "configs/linux_config.janet", = among other
>> things, the below are set
>>
>> #+begin_src janet
>>=C2=A0 =C2=A0 :c++ "c++"
>>=C2=A0 =C2=A0 :c++-link "c++"
>>=C2=A0 =C2=A0 :cc "cc"
>>=C2=A0 =C2=A0 :cc-link "cc"
>> #+end_src
>>
>> Since Guix, as far as I know, doesn't have packages that provi= de c++ nor
>> cc, I believe the above need to be patched to refer to gcc and g++=
>> respectively.
>>
>> So we need to substitute the above "c++" and "cc&qu= ot; in the
> "configs/linux_config.janet" to point to the absolute path f= or the gcc and
> g++ packages?

I believe there are multiple ways to make this work.=C2=A0 I haven't te= sted
this, so take my opinions as speculative.

If we replace "cc" and "c++" with the _absolute path_ f= or "gcc" and
"g++" respectively from the Guix store, then I don't think we= need to
specify gcc-toolchain as a propagated input.=C2=A0 Upon reflecting on this,=
this is probably the better approach.

If, however, we replace "cc" and "c++" with the _string= s_ "gcc" and
"g++", then I believe we may need to specify gcc-toolchain in the=
propagated inputs.=C2=A0 IIUC, in this case we would replace the command th= at
JPM invokes when building.=C2=A0 By additionally having gcc-toolchain in th= e
propagated inputs we'll ensure that they're available in the PATH.<= br>
> Should we also replace other commands that are hard-coded like "c= p" and
> "chown" from coreutils the same way I did in my first initia= l patch?

I don't believe this is necessary.=C2=A0 There's a question regd. w= hether or
not coreutils needs to be added to the propagated inputs, however.=C2=A0 I<= br> don't have a definitive answer, but the way to test it would be to run<= br> it in a pure container and see if things work without having to
explicitly specify coreutils.=C2=A0 If you're unable to test it, let me= know
when you send v8 and I can test it on your behalf.

For reference, I use something like the below:
#+begin_src sh
=C2=A0 guix shell --pure -CPWN \
=C2=A0 =C2=A0 -E '.*GTK.*|.*XDG.*|.*DISPLAY.*|TERM|INSIDE_EMACS' \<= br> =C2=A0 =C2=A0 -p /path/to/profile
#+end_src

> Further, I believe JPM should have a few propagated inputs:
>> - gcc-toolchain
>> - curl
>> - git
>> - nss-certs.
>>
>> I understand why we need gcc-toolchain. But why do we need curl, g= it and
> nss-certs?

linux_config.janet also specifies:

#+begin_src janet
=C2=A0 =C2=A0...
=C2=A0 =C2=A0:curlpath "curl"
=C2=A0 =C2=A0...
=C2=A0 =C2=A0:gitpath "git"
=C2=A0 =C2=A0...
#+end_src

Whether Guix packaging picks these up automatically or not, I haven't tested, but it seems for common usage of JPM these dependencies ought to be available.=C2=A0 Similar to the case of "gcc" and "g++&qu= ot;, it might be
better to replace these with references to the respective binaries in
the Guix store instead (as opposed to propagating them as I had
previously suggested).

Regarding nss-certs, it provides certificates for Certification
Authorities which, IIUC, would be relevant for HTTPS URLs (e.g. fetching dependencies over git+https).

To summarize, here's what I believe is needed.=C2=A0 Add nss-certs to t= he
propagated inputs, and for the below replace their occurrence in
linux_config.janet with references to binaries in the store:
- cc -> absolute path of gcc
- c++ -> absolute path of g++
- curl -> absolute path of curl
- git -> absolute path of git

--
Suhail
--0000000000008895b10623a8c547-- From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 04 23:12:54 2024 Received: (at 72925) by debbugs.gnu.org; 5 Oct 2024 03:12:54 +0000 Received: from localhost ([127.0.0.1]:37067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swvDx-0007eK-SK for submit@debbugs.gnu.org; Fri, 04 Oct 2024 23:12:54 -0400 Received: from mail-qv1-f67.google.com ([209.85.219.67]:45366) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swvDw-0007e6-1U for 72925@debbugs.gnu.org; Fri, 04 Oct 2024 23:12:52 -0400 Received: by mail-qv1-f67.google.com with SMTP id 6a1803df08f44-6cb2e5d0104so17652946d6.3 for <72925@debbugs.gnu.org>; Fri, 04 Oct 2024 20:12:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728097902; x=1728702702; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=eRCbl2z9fyWR099lM2QHfAlnHGcpiVYcQfM6s+BDZfg=; b=Hz+9qM7WPdk5OTqLUtOq5udotFuzNrpx3Yx2rITcfUD7KQzAQoCl6E9JJTe0Dbx1HQ b+D2aqEKAd2KLzUgytYXIiU49Wt0+QsF2gfGRrQv/CwG90n6KVIbypwU1V1hXqjJrx0q CvB2HXh58zx24yK+EEwbXPfgtKgSVnAAi3PavdaSjqG6SDHnjhNRsLJchMhte8J/Vzfc 4ftRX9rrgTycOICGFT2S6kGxpwXvYOZuT3LwRkxpuZ9GRwVnZ0XC3unohMOJZgeKIVq5 /jTzNWiQjQM2D7CUyKNE3brJeATYIyCv4VNB5TErPZ5U5WSf30p6ABVAkHgMGM7kXcN7 Ydpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728097902; x=1728702702; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eRCbl2z9fyWR099lM2QHfAlnHGcpiVYcQfM6s+BDZfg=; b=LRm0+WKm32xCpZEUeLuzuvHwr5iKYv2syh3jewLTNWqT0h90Cr3i7DKBlxFsSAQLOY zPT1QIan3NS0HNEvA31ouTjnwSINCNJNbE/JBGU306V7Znnb4Q+diN5h2f9TRyMBCjAd rPSpvFsVJRUAmCPDMT1kygzJ9/pr4JGBbEI6eeBvaYHxd+ge+G58R2BKxp3Z7UOYxWBh EMmziOgTp2KPbs5Uf5NLgnfzsxQVbq8sTYan7CCWP0kDsZYZOx8SGMq91DPOA2VxhV6S qN0RGEgoNtDCCMdaxGkJ5OjS5N14bnSQa5elHQdcYBLQmyqJedRFam1uq4eLIQC3/p/A gFZw== X-Forwarded-Encrypted: i=1; AJvYcCWGXYVvAxv//Rs2yUQG5zMQiCeITt8sFmQf9g6xjJy/kFs6JrFlpURts0bLUcMJ+wdi9xKLxA==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yzk2VwrRy92nQFot24GHO1oWFjTHYuXmePuJBG6Fy4MCHaJojBH u/DWLCxGQPFrAkyB/FybaC/zHlrkh32J+2LVmGQ0sPkkGy7Ifz1Q X-Google-Smtp-Source: AGHT+IEIsGP+dEj4LIDTB5F0IvRecMYelwqC0iDuKZmsRm22Sde++Gz04C3CsNyv2+g5dFNjwEwgSQ== X-Received: by 2002:a05:6214:5243:b0:6cb:6059:92a with SMTP id 6a1803df08f44-6cb9a330786mr65744276d6.10.1728097902279; Fri, 04 Oct 2024 20:11:42 -0700 (PDT) Received: from gnus ([65.94.70.53]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6cba46e03adsm4711416d6.57.2024.10.04.20.11.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Oct 2024 20:11:41 -0700 (PDT) From: Suhail Singh To: Omar Bassam Subject: Re: bug#72925: Adding JPM package for Janet In-Reply-To: (Omar Bassam's message of "Fri, 4 Oct 2024 19:00:23 +0300") References: <4e623d9571ff648ae1d1c6ffb8f9d73c421a5c10.1727683810.git.omar.bassam88@gmail.com> <87plok7kkn.fsf@gmail.com> <8734lev012.fsf@gmail.com> <875xqanty2.fsf@gmail.com> <87cyki9obi.fsf@gmail.com> <878qv69n0o.fsf@gmail.com> <874j5u7yme.fsf@gmail.com> <87jzep2tlb.fsf_-_@gmail.com> Date: Fri, 04 Oct 2024 23:11:30 -0400 Message-ID: <87jzenkzvh.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Guillaume Le Vaillant , Katherine Cox-Buday , Munyoki Kilyungi , jgart , Suhail Singh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Omar Bassam writes: > I just submitted a new path v8. I tested in a pure container shell Thank you. > Can you please have another look and let me know if you have any comments I was unable to cleanly apply v8 on master. Additionally, it still had some issues as reported by "guix lint". I cleaned them up and also made some simplifications, removed unnecessary dependencies, and fixed a bug I observed. I'll make a few comments on v8 for your awareness, but will also share a v9 with my changes. Please review v9, and if you agree with the changes mark it as "reviewed-looks-good". Please see for details on how to add the reviewed-looks-good usertag. -- Suhail From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 04 23:16:50 2024 Received: (at 72925) by debbugs.gnu.org; 5 Oct 2024 03:16:50 +0000 Received: from localhost ([127.0.0.1]:37072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swvHl-0007tK-GA for submit@debbugs.gnu.org; Fri, 04 Oct 2024 23:16:49 -0400 Received: from mail-qk1-f193.google.com ([209.85.222.193]:48593) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swvHi-0007t6-Iv for 72925@debbugs.gnu.org; Fri, 04 Oct 2024 23:16:47 -0400 Received: by mail-qk1-f193.google.com with SMTP id af79cd13be357-7a99fd4ea26so220947185a.1 for <72925@debbugs.gnu.org>; Fri, 04 Oct 2024 20:16:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728098137; x=1728702937; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:date:message-id :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=G4XjoKxX02hmUl9m9McSQErVhvGIjioJMuNjb63w0HY=; b=cvY6OgrKjuH+sbmfajISXwuJ4qo1stYe7w+sikU8TpbT0Dn4UWRsW/b9ou2pak27Je 2fYo+SjlqqXbg5eA1UqFGR5mvIpAji2m+lzeGfqKQXuWq6dVVy+VCKbuLabyHg0A2udF wDm73ZbGHiGc6CcQxaDVwmMFJJAyEH1ejaiOkFjiWsiT2rs28y6iNjRmqJ8zECGc00jo 39aOCYkuLXh35BYukeyEdCvMqD9JCl+qP1fglhz0cRNdFpSTzOa2gzSBrXx+L8qn25nW EXhlsA8ag6td4sXYkja/ClQzKANLLeh3asKIW5Tp9xQNoz4x0CfaYnwugi+xqqsrPXEl bx/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728098137; x=1728702937; h=content-transfer-encoding:mime-version:user-agent:date:message-id :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=G4XjoKxX02hmUl9m9McSQErVhvGIjioJMuNjb63w0HY=; b=EqHMk76YJfxz6MT7fv24oFC2zxn+A1UdsFeQFj/+79UEB5m7XnH3YXDnBaXPadUEpU MXRBi47fBGxu/QCndylt82ct7r7X22foYDp5rI+LldJQR2R2wc8dvw0pi6A2h8RAHlwE cvsI5EO3j83F9BKdWVDUXQxvsOL6nCUV39wEBLGGwv1s86AvuDr6niihDzkA3oySSxh3 hkuyyU1g+6joNHjkTorre+pzlqBUO3S1vgbaVHDb4Oh3pqxku9W5nzpby9hX5ExeO0w0 2gjrePNvI3XpjtDKp7nx6NDbs0RbBQVdE04gdMlq2teILMdnfFMDVTKp3fOK0volhejl J8JQ== X-Gm-Message-State: AOJu0YwRTBdFAzsNrbhDhnQT94xSoO7pLKdovJD659aA7IDoC1KaLx9/ WWnP4fXoCDgy7zDCpPYXMbLq+7Heou6MsppLuLTp8dcyQWtH2JGa X-Google-Smtp-Source: AGHT+IHkHlEX1b7GRqZgr1JZQ28PhIw7Eyei2f90dWPpMgQBcm5pXf9BFaNz0OgS0c6cmnipM2PuWA== X-Received: by 2002:a05:620a:318b:b0:7a9:c129:4e84 with SMTP id af79cd13be357-7ae6f4880d0mr785246985a.45.1728098136621; Fri, 04 Oct 2024 20:15:36 -0700 (PDT) Received: from gnus ([65.94.70.53]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7ae75764f00sm40919485a.115.2024.10.04.20.15.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Oct 2024 20:15:35 -0700 (PDT) From: "Suhail Singh" To: 72925@debbugs.gnu.org Subject: [PATCH v9] gnu: Add jpm. Message-ID: <62a470b969879d779dbd6c77303a71a84193099d.1728096820.git.suhail@bayesians.ca> X-Debbugs-Cc: Guillaume Le Vaillant , Katherine Cox-Buday , Munyoki Kilyungi , Sharlatan Hellseher , jgart Date: Fri, 04 Oct 2024 23:15:16 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: Omar Bassam X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/packages/lisp.scm (jpm): New variable. Change-Id: I730ef2f5c874c5142a580a42af76180e95d93ccd Signed-off-by: Suhail --- gnu/packages/lisp.scm | 70 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 70 insertions(+) diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm index 6c16d8ab71..faa7ed7bed 100644 --- a/gnu/packages/lisp.scm +++ b/gnu/packages/lisp.scm @@ -29,6 +29,7 @@ ;;; Copyright =C2=A9 2024 Andreas Enge ;;; Copyright =C2=A9 2024 bigbug ;;; Copyright =C2=A9 2024 Ashish SHUKLA +;;; Copyright =C2=A9 2024 Omar Bassam ;;; ;;; This file is part of GNU Guix. ;;; @@ -69,6 +70,7 @@ (define-module (gnu packages lisp) #:use-module (gnu packages bash) #:use-module (gnu packages bdw-gc) #:use-module (gnu packages boost) + #:use-module (gnu packages certs) #:use-module (gnu packages check) #:use-module (gnu packages compression) #:use-module (gnu packages crypto) @@ -917,6 +919,74 @@ (define-public janet assembler, PEG) is less than 1MB.") (license license:expat))) =20 +(define-public jpm + (package + (name "jpm") + (version "1.1.0") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/janet-lang/jpm") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 "05rdxigmiy7vf93s16a8n2029lq33073jccz1rjl4iisxj6piw4l")))) + (build-system copy-build-system) + (arguments + (list + #:phases #~(modify-phases %standard-phases + (add-after 'unpack 'fix-paths + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "configs/linux_config.janet" + (("/usr/local") + #$output) + (("\"cc\"") + (string-append "\"" + #$gcc "/bin/gcc" "\"")) + (("\"c\\+\\+\"") + (string-append "\"" + #$gcc "/bin/g++" "\"")) + (("\"git\"") + (string-append "\"" + #$git "/bin/git" "\"")) + (("\"curl\"") + (string-append "\"" + #$curl "/bin/curl" "\""))) + (substitute* "jpm/shutil.janet" + (("cp") + (string-append #$coreutils "/bin/cp"))) + (setenv "PREFIX" + #$output))) + (replace 'install + (lambda _ + (for-each (lambda (dir) + (mkdir-p (string-append #$output "/" di= r))) + '("lib/janet/jpm" "share/man/man1")) + (invoke "janet" "bootstrap.janet" + "configs/linux_config.janet") + (wrap-program (string-append #$output "/bin/jpm") + `("JANET_HEADERPATH" ":" =3D + (,(string-append #$janet "/include/janet"))) + `("JANET_LIBPATH" ":" =3D + (,(string-append #$janet "/lib"))))))))) + (inputs (list bash-minimal)) + (propagated-inputs (list janet + git + nss-certs + ;; Lazily resolve the gcc-toolchain to avoid a + ;; circular dependency. + (module-ref (resolve-interface '(gnu packages + commencement= )) + 'gcc-toolchain))) + (home-page "https://janet-lang.org/") + (synopsis "Janet Project Manager for the Janet programming language") + (description + "@code{jpm} is the Janet Project Manager tool. It is a build +tool and its main uses are installing dependencies, compiling C/C++ to nat= ive +libraries, and other management tasks for Janet projects.") + (license license:expat))) + (define-public lisp-repl-core-dumper (package (name "lisp-repl-core-dumper") base-commit: 73ec844389e91cb0f5a2647070516fc8d19d8730 --=20 2.46.1 From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 04 23:30:09 2024 Received: (at 72925) by debbugs.gnu.org; 5 Oct 2024 03:30:09 +0000 Received: from localhost ([127.0.0.1]:37081 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swvUf-00005P-4L for submit@debbugs.gnu.org; Fri, 04 Oct 2024 23:30:09 -0400 Received: from mail-qk1-f195.google.com ([209.85.222.195]:51216) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swvUd-0008V6-RE for 72925@debbugs.gnu.org; Fri, 04 Oct 2024 23:30:08 -0400 Received: by mail-qk1-f195.google.com with SMTP id af79cd13be357-7a99fdf2e1aso345978985a.2 for <72925@debbugs.gnu.org>; Fri, 04 Oct 2024 20:30:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728098938; x=1728703738; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=XvCKYQXRFj8X2Gkt370pHomatZFBi2rvfIyIusf+7As=; b=LGxDWw5Cd9UeGDHNIpXCGE/B5UI9DsB+EKVTGkUHly3RMiUyRBQwtLPKBlK9HVjQ19 D/GZ6UhHluFTEqLXN5RqNdlNQyBksYcUxUzoWGoBgkjem0Y7YKZJzY2O8l9c2y8AFgjX A+vdKIPv8Q8ycT4vdJjGeyxIQ/Z5jYZT58UDXxRoUR9lbVh769FM2oN5C/DZC+CR2R2c mNRG6vs831qqG/dE/EHDrZL1HwHTgABEMHuHkwfjsYd0yI1uCHj0afwCqO+5L0Ieu8Qv ZBrVKYs0mLJafuxq7ktUXZ0tWMiE1PQZTjv+/PnXaBG+hF44xITwTwTaxScS63ohDWbj Gmzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728098938; x=1728703738; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XvCKYQXRFj8X2Gkt370pHomatZFBi2rvfIyIusf+7As=; b=Nmp1v86sCCFGzrvIvDLt+RKxummXY3+KVKmslZXUMS8uS6YSNXUqGHVz1Hx0TK0m+V ErlwRg7+4TfTENISXzwCa7wonSAuiuDcDt0XKQp/jq2Bh/bjNQ/eEroGr0uUVoXhkL87 LjNgH1jUylN5Pcc1sMVQ54Vbv9Bkabe5VUPfRqWc479rG3VSJ649s3fovX1gi1DI1LCh t21ihteHHjRrHu09+lsM9G3kfbxNXWX3gLYUA9geEwbeEFZfoOCzB4WfKVsjvSAH33QL w2ftdRbUqyOyfP//iLNWdZAJ2tMKrDkAvVaeLXl/W2vZPr1sOwO96QHjwKD1HqklFRCY eJOA== X-Gm-Message-State: AOJu0Yw/p3VrvQkXN8uEbMtCPYMN+C2hsO+HvVa5Sy00r/pdVZ5Fa5RT 4/CJGz5l8S819TkfimZpG9rV6u+oPU8/VH7KLP7dkwOozqxNhyJj X-Google-Smtp-Source: AGHT+IGwwB7EV0I0SBLt7WFRRxoz4FrnVzuyRCDvcw48CgQt51AlwEeljPGSWzVPLSfxRYvdn4Xf4w== X-Received: by 2002:a05:620a:4013:b0:7ac:b393:33cb with SMTP id af79cd13be357-7ae6f4b3747mr675017685a.66.1728098937855; Fri, 04 Oct 2024 20:28:57 -0700 (PDT) Received: from gnus ([65.94.70.53]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7ae7561e5d6sm42566985a.9.2024.10.04.20.28.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Oct 2024 20:28:57 -0700 (PDT) From: Suhail Singh To: Omar Bassam Subject: Re: [bug#72925] [PATCH v8] gnu: add jpm package In-Reply-To: <8223c6391ac0b6a7d0aba42d32eb037c2deef26d.1728055031.git.omar.bassam88@gmail.com> (Omar Bassam's message of "Fri, 4 Oct 2024 18:57:36 +0300") References: <8223c6391ac0b6a7d0aba42d32eb037c2deef26d.1728055031.git.omar.bassam88@gmail.com> Date: Fri, 04 Oct 2024 23:28:46 -0400 Message-ID: <87frpbkz2p.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Munyoki Kilyungi , Katherine Cox-Buday , Guillaume Le Vaillant , jgart X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Omar Bassam writes: > + (url "https://github.com/janet-lang/jpm.git") The URL redirects to . > + (("\"cc\"") > + (string-append "\"" > + (assoc-ref inputs "gcc-toolchain") > + "/bin/gcc" "\"")) Can be simplified to: #+begin_src diff + (("\"cc\"") + (string-append "\"" + #$gcc "/bin/gcc" "\"")) #+end_src > + (("\"c++\"") This regex doesn't match, it should be "\"c\\+\\+\"". > + (string-append "\"" > + (assoc-ref inputs "gcc-toolchain") > + "/bin/g++" "\"")) Can be similarly simplified. As well for others. > + (inputs (list bash-minimal janet)) Since "janet" is in the propagated-inputs, it doesn't need to be specified in inputs. > + (propagated-inputs (list janet > + coreutils "coreutils" is not a necessary dependency and can be removed. > + git > + curl > + nss-certs "curl" is not necessary either. The combination of "git" and "nss-certs" when propagated is sufficient > + ;; Lazily resolve the gcc-toolchain to avoid > + ;; a circular dependency. > + (module-ref (resolve-interface '(gnu packages > + commencement)) > + 'gcc-toolchain))) Nicely done! And this one ends up being essential (since it provides necessary header files etc.). > + (description "JPM is the Janet Project Manager tool. It is for automating > +builds and downloading dependencies of Janet projects.") I took some liberties with the description based on description on . -- Suhail From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 05 13:22:52 2024 Received: (at 72925) by debbugs.gnu.org; 5 Oct 2024 17:22:52 +0000 Received: from localhost ([127.0.0.1]:39540 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sx8UV-0003fk-CN for submit@debbugs.gnu.org; Sat, 05 Oct 2024 13:22:51 -0400 Received: from mail-qk1-f196.google.com ([209.85.222.196]:56831) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sx8US-0003fU-2x for 72925@debbugs.gnu.org; Sat, 05 Oct 2024 13:22:49 -0400 Received: by mail-qk1-f196.google.com with SMTP id af79cd13be357-7a99d23e036so336358885a.1 for <72925@debbugs.gnu.org>; Sat, 05 Oct 2024 10:22:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728148897; x=1728753697; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:date:message-id :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=scZjI9EzJoAq1UV65RilUrvN8Neeg2mnenBKaPhgsWY=; b=IKkfZXMCDG6lvfj9ODYwCU6fPOWaMqlKBWspuPj8XwLZUsOeqW7zHoM5+1Y1gdbbUM 3szeOsLOkqecygEngx1UjQsCbFvmwynmOi20Nl/eULppZ29/5oU2P9nCEOCzYHfZNwRo 4pELMLfcPVTMl41Ef8Z0nd8KP6CX2i2b+xxulAr+BGepwxjcJJiQnMBrSYTJ0IQJebXz kIqn6KFOk/b1pinEf/yqKTrePPzE0iWnjbuyiYUTdCanuBNCgI/RCNFia+/sDJezhAkd AnRAtDwPmpGHUsGnzhhjtg4jg6QVsX2jF5nlzZU80BF7emS1subCCWWypuLn8QOGIdSc OEug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728148897; x=1728753697; h=content-transfer-encoding:mime-version:user-agent:date:message-id :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=scZjI9EzJoAq1UV65RilUrvN8Neeg2mnenBKaPhgsWY=; b=tDZnTcRtEfMOLHhuZlBoQgesSyE6Dc0H2keN6BRKrM227DrYAvRKVtL00mb3fMosvo 07x6pZBWVP4oy3XKNiH4yZdzM/f1FYg/7VAP83sHUP8Pp0GCdx8a+9ABcVhK1Sj+uKkj ThpJ22JLV6x/Qix4HKlHLUwYv/7H3O3dJpp2s1YprZ7TQ0jwl9kwcbvsTpcaF7yrwbqW lPE6n8n03ZqcYY+6HCzFM0XYUL54Ma9l1p5y+hlb5xl0rQuTa6Ki/X/9338IQ9Ql/8/3 SJ5U2/nYa7HeFYBQeiuA6s2s0S+MiVP95ATxO+J9b+x3YzyC+ffKRNw8cUug29dX2zA7 bGng== X-Gm-Message-State: AOJu0Yw3uHyPJi4LonJgjQj0nvo68qVhAAbAcCErqknCCx6CulDDs8ds mFJ6SYbL7D8gfj35++yxTg9DD5XrjAVznGZl3dYgEmprz/0cMH2jSepI8AyY X-Google-Smtp-Source: AGHT+IGdQGBP4u/fRugflNqhxcQ+01HTsHLlmnQTVRvvbXHPbGUX/OLZvFBxZWUuv6bqkCP8tXlSyA== X-Received: by 2002:a05:620a:240a:b0:7ac:a0e6:70c with SMTP id af79cd13be357-7ae6f49da89mr1036026285a.60.1728148897476; Sat, 05 Oct 2024 10:21:37 -0700 (PDT) Received: from gnus ([142.115.189.80]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7ae756611cesm94894385a.73.2024.10.05.10.21.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Oct 2024 10:21:36 -0700 (PDT) From: "Suhail Singh" To: 72925@debbugs.gnu.org Subject: [PATCH v10] gnu: Add jpm. Message-ID: <6e198e7dc1f64bea3a2b1498fb69e597e4d03360.1728148557.git.suhail@bayesians.ca> X-Debbugs-Cc: Guillaume Le Vaillant , Katherine Cox-Buday , Munyoki Kilyungi , Sharlatan Hellseher , jgart Date: Sat, 05 Oct 2024 13:21:24 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: Omar Bassam X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/packages/lisp.scm (jpm): New variable. Change-Id: I730ef2f5c874c5142a580a42af76180e95d93ccd Signed-off-by: Suhail --- gnu/packages/lisp.scm | 77 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 77 insertions(+) diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm index 6c16d8ab71..48cf9dffab 100644 --- a/gnu/packages/lisp.scm +++ b/gnu/packages/lisp.scm @@ -29,6 +29,7 @@ ;;; Copyright =C2=A9 2024 Andreas Enge ;;; Copyright =C2=A9 2024 bigbug ;;; Copyright =C2=A9 2024 Ashish SHUKLA +;;; Copyright =C2=A9 2024 Omar Bassam ;;; ;;; This file is part of GNU Guix. ;;; @@ -62,6 +63,7 @@ (define-module (gnu packages lisp) #:use-module (guix build-system gnu) #:use-module (guix build-system haskell) #:use-module (guix build-system trivial) + #:use-module ((guix search-paths) #:select ($SSL_CERT_DIR $SSL_CERT_FILE= )) #:use-module (gnu packages admin) #:use-module (gnu packages algebra) #:use-module (gnu packages autotools) @@ -69,6 +71,7 @@ (define-module (gnu packages lisp) #:use-module (gnu packages bash) #:use-module (gnu packages bdw-gc) #:use-module (gnu packages boost) + #:use-module (gnu packages certs) #:use-module (gnu packages check) #:use-module (gnu packages compression) #:use-module (gnu packages crypto) @@ -917,6 +920,80 @@ (define-public janet assembler, PEG) is less than 1MB.") (license license:expat))) =20 +(define-public jpm + (package + (name "jpm") + (version "1.1.0") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/janet-lang/jpm") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 "05rdxigmiy7vf93s16a8n2029lq33073jccz1rjl4iisxj6piw4l")))) + (build-system copy-build-system) + (arguments + (list + #:phases #~(modify-phases %standard-phases + (add-after 'unpack 'fix-paths + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "configs/linux_config.janet" + (("/usr/local") + #$output) + (("\"cc\"") + (string-append "\"" + #$gcc "/bin/gcc" "\"")) + (("\"c\\+\\+\"") + (string-append "\"" + #$gcc "/bin/g++" "\"")) + (("\"git\"") + (string-append "\"" + #$git "/bin/git" "\"")) + (("\"curl\"") + (string-append "\"" + #$curl "/bin/curl" "\""))) + (substitute* "jpm/shutil.janet" + (("cp") + (string-append #$coreutils "/bin/cp"))) + (setenv "PREFIX" + #$output))) + (replace 'install + (lambda _ + (for-each (lambda (dir) + (mkdir-p (string-append #$output "/" di= r))) + '("lib/janet/jpm" "share/man/man1")) + (invoke "janet" "bootstrap.janet" + "configs/linux_config.janet") + (wrap-program (string-append #$output "/bin/jpm") + `("JANET_HEADERPATH" ":" =3D + (,(string-append #$janet "/include/janet"))) + `("JANET_LIBPATH" ":" =3D + (,(string-append #$janet "/lib"))))))))) + (inputs (list bash-minimal)) + (propagated-inputs (list janet + ;; Lazily resolve the gcc-toolchain to avoid a + ;; circular dependency. + (module-ref (resolve-interface '(gnu packages + commencement= )) + 'gcc-toolchain))) + ;; NOTE: Below ensures that the user provides the CA certificates they + ;; desire (as opposed to bundling `nss-certs' in propagated-inputs, wh= ich + ;; isn't recommended) and when they do, that they are respected. + ;; + ;; FIXME: It's unclear why `search-paths', instead of + ;; `native-search-paths', doesn't work. + (native-search-paths + (list $SSL_CERT_DIR $SSL_CERT_FILE)) + (home-page "https://janet-lang.org/") + (synopsis "Janet Project Manager for the Janet programming language") + (description + "@code{jpm} is the Janet Project Manager tool. It is a build +tool and its main uses are installing dependencies, compiling C/C++ to nat= ive +libraries, and other management tasks for Janet projects.") + (license license:expat))) + (define-public lisp-repl-core-dumper (package (name "lisp-repl-core-dumper") base-commit: 73ec844389e91cb0f5a2647070516fc8d19d8730 --=20 2.46.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 05 13:27:12 2024 Received: (at 72925) by debbugs.gnu.org; 5 Oct 2024 17:27:12 +0000 Received: from localhost ([127.0.0.1]:39549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sx8Yi-0003wM-Br for submit@debbugs.gnu.org; Sat, 05 Oct 2024 13:27:12 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:42106) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sx8Yg-0003w4-Ko for 72925@debbugs.gnu.org; Sat, 05 Oct 2024 13:27:11 -0400 Received: by mail-qt1-f193.google.com with SMTP id d75a77b69052e-45815723c87so26514741cf.0 for <72925@debbugs.gnu.org>; Sat, 05 Oct 2024 10:27:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728149160; x=1728753960; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Af8UaFSb7qqoXEJ3WDCXyYQ8tdLSyuhKaxDY/Zfn89E=; b=B6oYDr9ugp1Sh2e85p9P+bzmQMng4OAbRDIJm22iOqQJkz7UBBqyF9vPOrHwylSV3h eWPYE2YTCdZbRp34JVK2BoNI55oLD2hsynZqgqiNDMdjqCN87A4dyP0hpLNQSVvgKh8Z bUx6NCrI28/HHZXuCAS/JkzJx46B1sqAbRN6Uk99e9yYc2pRUebW+UEnZmqL0z0cQiyf RAP1I1Kvc+/RyUpa0f7pYxDcUSQcABlU0n31PRh3ijM5Xo1G27ysl3ECxGrV57fYxzsM YgfL4WqWCWWkoPEGixPCY7YyCA2u2ZoMS7INXdFQb2RzDLTe3Io9pqV1K1Ut21AaK6px fpeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728149160; x=1728753960; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Af8UaFSb7qqoXEJ3WDCXyYQ8tdLSyuhKaxDY/Zfn89E=; b=nEIqi8kH02Mh8zsrlpPRBSsNmeWZueZo5e4RUailky1KzlnJsdTtR8awew7PIrRgVM KH7dJjuWgisH4jbj4fP5wYFDGZCCrmAuSce8yjt3jYtbkmm0OF8A1PB7pVqS7MDFwtG4 k/RZEDL2qlHUV4b/RCUPBr7bZzk4LyN6cDMuByFmPm2BF6TlfQJ7w5K9H4fc0KJzVe+J orLMrvCYHxTFRn13cC/YYwShcGbS8fHEUg4RBYp4NUDuTSFInTLMEhq63j8yhagwUwz5 SmjD5Qi0NOkkoMRQynAq6w+HgYP+irP69kEgXmlUpVwBnVLZFk3/CVtKIHOsDBNpVgfc t1mQ== X-Gm-Message-State: AOJu0YzQ7S3KzFOnurkN+DYA6zo5q4xMM4ZJpX/SO4AmcD1Z0zBGMf4O BAnRxQHqkVfaNTljDmdhxa6q6/6un6fMnMvQ2SMqZh7MgyUf+QPz X-Google-Smtp-Source: AGHT+IFQ1BtDj8MOHeEQVntZdD0TC74TY2SE3Qlg4sOntdCbIzAhfrbI96qavesxciTKQjWXOKGwBg== X-Received: by 2002:ac8:7fd4:0:b0:447:f6c7:65ee with SMTP id d75a77b69052e-45d8d09bab2mr186295371cf.10.1728149160126; Sat, 05 Oct 2024 10:26:00 -0700 (PDT) Received: from gnus ([142.115.189.80]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-45da75ed33esm10096131cf.67.2024.10.05.10.25.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Oct 2024 10:25:59 -0700 (PDT) From: "Suhail Singh" To: 72925@debbugs.gnu.org Subject: Re: bug#72925: Adding JPM package for Janet In-Reply-To: <87frpbkz2p.fsf@gmail.com> (Suhail Singh's message of "Fri, 04 Oct 2024 23:28:46 -0400") References: <8223c6391ac0b6a7d0aba42d32eb037c2deef26d.1728055031.git.omar.bassam88@gmail.com> <87frpbkz2p.fsf@gmail.com> Date: Sat, 05 Oct 2024 13:25:47 -0400 Message-ID: <878qv2qx5w.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: Sharlatan Hellseher , Munyoki Kilyungi , Katherine Cox-Buday , Guillaume Le Vaillant , jgart , Omar Bassam X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Suhail Singh writes: >> + git >> + curl >> + nss-certs > > "curl" is not necessary either. The combination of "git" and > "nss-certs" when propagated is sufficient However, it turns out that it's not recommended to bundle nss-certs. v10 addresses this. -- Suhail From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 06 09:22:19 2024 Received: (at 72925) by debbugs.gnu.org; 6 Oct 2024 13:22:19 +0000 Received: from localhost ([127.0.0.1]:40429 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxRDG-0000C6-Gs for submit@debbugs.gnu.org; Sun, 06 Oct 2024 09:22:19 -0400 Received: from mail-ej1-f41.google.com ([209.85.218.41]:57508) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxRDC-0000Bx-U9 for 72925@debbugs.gnu.org; Sun, 06 Oct 2024 09:22:16 -0400 Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a99543ab209so15710966b.2 for <72925@debbugs.gnu.org>; Sun, 06 Oct 2024 06:22:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728220868; x=1728825668; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PsNn8ybx4aYeWDByJ9KajsfUROBvu4hRPzeKiQfbVmY=; b=IWiNJzoTUnfVrj6493NHUfbrLu2RXbBktijOIQiC6phEN1ZCNbjlMpHJHxWw/cqZlF mzwyw+TlS1vzs1W/hwG3E7pov05nimRXQt8MvewEqARfsowdTcxtZsmvi1Yv7fxarE7E AlqXYFZaCSXDiRKPqG8/tPa0dU5vMdoEMgz1S9OZDfoTejYICNXIlv8oP0RrqAVKZkwr +wICqHgD9luNvilBYTEvIYWIGr05xYtRzumXNsICSxFfMg7LYK2+S32Gh1HUFxvtPf9N 7hILWNoL778Q9gwF0THQjIml6d7faLB7oGpJ/HW5xVY1Epy/L5ZA24a4Di+RhBH/cD81 2S2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728220868; x=1728825668; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PsNn8ybx4aYeWDByJ9KajsfUROBvu4hRPzeKiQfbVmY=; b=j0AAk9auSgtmPtn8b6GuyOaFwRuBm9WvktdZ3C7xhPvDoew5d+x0Fkm0I+E1toxNTY Gk425+wEa3GThMI9bup9gs7YmSWbXK2Zzy+TwiPxu7waZ3WR4Ws5JaLw60+BGhTCDjq/ tdmIQkqTjD0qEiberwzyZ21GQYh8DExFqGk6PWUsi85dW8vCpHR8WgUCGBbSJvPuK4QD AfSe2XJy5Hw61ZMAsCJVAcIgz+nSbNaqM4J6+GfFpb4FBOB3PNC5ifF2jqnTTpXCzd4q QHF6VGWiV6E9ObLKv8Hd4TRc4k33Evi6oC0qFadJJFWGW83HQgB186uzYavKJ2YxnYu0 WSIA== X-Gm-Message-State: AOJu0YyQXlSvDv9I9koIzwri9ozz51u6mKuF4ryvLQIciVHjVvNEV63a xbRu4Sivi0Z4Lfg5a4fTonrLfkk4vWZCkjvslFD8YHQX8NYLh0s2 X-Google-Smtp-Source: AGHT+IGoZFV0Q8FnUV+oKvJsKtLfwbOCOATqNSB1scRxKus8G+ycby/cyWfWdzAbyrxPSeqiCsSfrg== X-Received: by 2002:a17:906:da88:b0:a86:b85d:9470 with SMTP id a640c23a62f3a-a991c077d6fmr1007237466b.59.1728220867748; Sun, 06 Oct 2024 06:21:07 -0700 (PDT) Received: from omar-Latitude-5540 ([46.232.152.32]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a993f13620dsm186470366b.215.2024.10.06.06.21.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Oct 2024 06:21:07 -0700 (PDT) From: Omar Bassam X-Google-Original-From: Omar Bassam To: "Suhail Singh" Subject: Re: [PATCH v10] gnu: Add jpm. In-Reply-To: <6e198e7dc1f64bea3a2b1498fb69e597e4d03360.1728148557.git.suhail@bayesians.ca> (Suhail Singh's message of "Sat, 05 Oct 2024 13:21:24 -0400") References: <6e198e7dc1f64bea3a2b1498fb69e597e4d03360.1728148557.git.suhail@bayesians.ca> Date: Sun, 06 Oct 2024 16:21:05 +0300 Message-ID: <87o73xgyf2.fsf@omar-Latitude-5540.mail-host-address-is-not-set> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: 72925@debbugs.gnu.org, Omar Bassam X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Thank you Suhail for helping me out wiht this patch. I have some questions about v10 patch about some parts that I don't fully understand. > * gnu/packages/lisp.scm (jpm): New variable. > > Change-Id: I730ef2f5c874c5142a580a42af76180e95d93ccd > Signed-off-by: Suhail > --- > gnu/packages/lisp.scm | 77 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 77 insertions(+) > > diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm > index 6c16d8ab71..48cf9dffab 100644 > --- a/gnu/packages/lisp.scm > +++ b/gnu/packages/lisp.scm > @@ -29,6 +29,7 @@ > ;;; Copyright =C2=A9 2024 Andreas Enge > ;;; Copyright =C2=A9 2024 bigbug > ;;; Copyright =C2=A9 2024 Ashish SHUKLA > +;;; Copyright =C2=A9 2024 Omar Bassam > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -62,6 +63,7 @@ (define-module (gnu packages lisp) > #:use-module (guix build-system gnu) > #:use-module (guix build-system haskell) > #:use-module (guix build-system trivial) > + #:use-module ((guix search-paths) #:select ($SSL_CERT_DIR $SSL_CERT_FI= LE)) > #:use-module (gnu packages admin) > #:use-module (gnu packages algebra) > #:use-module (gnu packages autotools) > @@ -69,6 +71,7 @@ (define-module (gnu packages lisp) > #:use-module (gnu packages bash) > #:use-module (gnu packages bdw-gc) > #:use-module (gnu packages boost) > + #:use-module (gnu packages certs) If we don't need nss-verts, do we still need this line? > #:use-module (gnu packages check) > #:use-module (gnu packages compression) > #:use-module (gnu packages crypto) > @@ -917,6 +920,80 @@ (define-public janet > assembler, PEG) is less than 1MB.") > (license license:expat))) >=20=20 > +(define-public jpm > + (package > + (name "jpm") > + (version "1.1.0") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/janet-lang/jpm") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "05rdxigmiy7vf93s16a8n2029lq33073jccz1rjl4iisxj6piw4l"))= )) > + (build-system copy-build-system) > + (arguments > + (list > + #:phases #~(modify-phases %standard-phases > + (add-after 'unpack 'fix-paths > + (lambda* (#:key inputs #:allow-other-keys) > + (substitute* "configs/linux_config.janet" > + (("/usr/local") > + #$output) > + (("\"cc\"") > + (string-append "\"" > + #$gcc "/bin/gcc" "\"")) > + (("\"c\\+\\+\"") > + (string-append "\"" > + #$gcc "/bin/g++" "\"")) > + (("\"git\"") > + (string-append "\"" > + #$git "/bin/git" "\"")) > + (("\"curl\"") > + (string-append "\"" > + #$curl "/bin/curl" "\""))) > + (substitute* "jpm/shutil.janet" > + (("cp") > + (string-append #$coreutils "/bin/cp"))) > + (setenv "PREFIX" > + #$output))) > + (replace 'install > + (lambda _ > + (for-each (lambda (dir) > + (mkdir-p (string-append #$output "/" = dir))) > + '("lib/janet/jpm" "share/man/man1")) > + (invoke "janet" "bootstrap.janet" > + "configs/linux_config.janet") > + (wrap-program (string-append #$output "/bin/jpm") > + `("JANET_HEADERPATH" ":" =3D > + (,(string-append #$janet "/include/janet"))) > + `("JANET_LIBPATH" ":" =3D > + (,(string-append #$janet "/lib"))))))))) > + (inputs (list bash-minimal)) > + (propagated-inputs (list janet > + ;; Lazily resolve the gcc-toolchain to avoi= d a > + ;; circular dependency. > + (module-ref (resolve-interface '(gnu packag= es > + commenceme= nt)) > + 'gcc-toolchain))) Since we no longer need gcc-toolchain and we are just using gcc directly, should we remove this module-ref expression and just add gcc as a= propagated input? > + ;; NOTE: Below ensures that the user provides the CA certificates th= ey > + ;; desire (as opposed to bundling `nss-certs' in propagated-inputs, = which > + ;; isn't recommended) and when they do, that they are respected. Why isn't bundling nss-certs recommended? > + ;; > + ;; FIXME: It's unclear why `search-paths', instead of > + ;; `native-search-paths', doesn't work. What are the difference between search-paths and native-search-paths. And were you able to run the "jpm install" command without nss-certs. Because, for me I was unable to do so. When I added back the nss-certs in propagated-inputs, it worked fine. > + (native-search-paths > + (list $SSL_CERT_DIR $SSL_CERT_FILE)) > + (home-page "https://janet-lang.org/") > + (synopsis "Janet Project Manager for the Janet programming language") > + (description > + "@code{jpm} is the Janet Project Manager tool. It is a build > +tool and its main uses are installing dependencies, compiling C/C++ to n= ative > +libraries, and other management tasks for Janet projects.") > + (license license:expat))) > + > (define-public lisp-repl-core-dumper > (package > (name "lisp-repl-core-dumper") > > base-commit: 73ec844389e91cb0f5a2647070516fc8d19d8730 Sorry I had to send this message twice. This is the first time sending from gnus in emacs and I didn't know the difference between a "reply" and a "wide-reply" BRs, Omar From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 06 11:47:48 2024 Received: (at 72925) by debbugs.gnu.org; 6 Oct 2024 15:47:48 +0000 Received: from localhost ([127.0.0.1]:42009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxTU3-0000Yg-T5 for submit@debbugs.gnu.org; Sun, 06 Oct 2024 11:47:48 -0400 Received: from mail-qv1-f68.google.com ([209.85.219.68]:57570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxTU1-0000YS-JZ for 72925@debbugs.gnu.org; Sun, 06 Oct 2024 11:47:46 -0400 Received: by mail-qv1-f68.google.com with SMTP id 6a1803df08f44-6cb35f2aec1so32676256d6.2 for <72925@debbugs.gnu.org>; Sun, 06 Oct 2024 08:47:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728229593; x=1728834393; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=PK2hsLEZ4eiUdePSOb8bLNTEUEhPFRtfrap7ghMxElY=; b=BXEYE8UY1Rx+szDVrrLBLlO50axmUX3lPubLY6DYElcqu+/Qyza8M9LiKikBlXsPRV mnP9hEEyZWt3oqHd4fqZYMCji9BESjtOg7CwBTE1cTxdcbno7i2540i04HjMQq4+FMNr D8XVMyvhlHGc7QGsN3fwndyYxUS8ZkCY+p0GeYr9mc4g4SVA8ZgkGOAQp4gg2GTKd3bT W1ZOkIwpCsMdYlllb2bpLKZ/UBCUEYne/0ZJQohSkZBGtE7pHB51M5Y5J/cqPnwxwmsx FstoYkiGxKBNBRB/Awr6y+pcFLV+UfuuqKJ93smuJ+4lrtrpOIYHVjuxs5qBSWnZ0pIB LbTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728229593; x=1728834393; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PK2hsLEZ4eiUdePSOb8bLNTEUEhPFRtfrap7ghMxElY=; b=pEanC2ZzKSR3Ib5lX2i00YkTEmqcqazfH7DRzIkYtvhSjO4dfle3EMlopumuAFjJrn 4s6wgWLe0erfvGxBj3B2zth7Zp8HB0BmCxZzyYrSa9uGP/SaXaiAoBp8KPAQyTVTciUc UD2nbdDF83WDEnm9tGb/V6GBMezmSxE/sopIAp2P+rkdAxOXjK2jfZp0rxDOxyWgAhCH ICQGioWDuh8YU+G3tk7PsQGIwkicYCeJCtRHpI2Ue/TZBtD33S9ZEIOx08VObe8RFDeJ cL5dYMvdFWPFc2HfraqmTwnpZjn9lK1dBx1LvcnmFk0GkFcCeFH7QMlRzu9gW8J7GhFi vVKw== X-Forwarded-Encrypted: i=1; AJvYcCWNsZHqkTyrlxLc5pIEsp+EHppmSFCqr5cmRqpnEyNFZYJ0DGH0j22Ay2Lz+qv4+O6uiqRigQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yy3R04WnisYPAzfbdmMff66pd++5igAgk2I/wGUaNDLJyXoNHiy +WiudWkvCkShgdh1SJkm4Om/EUfnCOWaXH5wpBfusqrGF9cpXlyaxx6IvrSC X-Google-Smtp-Source: AGHT+IHoky1/g2kdsE27PhB6XERE+3JvNjvdbnznv2aXEoKmJ+cBMdDAUUPhellsN573f1wgywYrjQ== X-Received: by 2002:a05:6214:5882:b0:6cb:600f:568b with SMTP id 6a1803df08f44-6cb9a1ef82amr134793146d6.8.1728229593283; Sun, 06 Oct 2024 08:46:33 -0700 (PDT) Received: from gnus ([65.94.70.53]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6cba475ff59sm17602476d6.118.2024.10.06.08.46.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Oct 2024 08:46:32 -0700 (PDT) From: Suhail Singh To: Omar Bassam Subject: Re: [PATCH v10] gnu: Add jpm. In-Reply-To: <87o73xgyf2.fsf@omar-Latitude-5540.mail-host-address-is-not-set> (Omar Bassam's message of "Sun, 06 Oct 2024 16:21:05 +0300") References: <6e198e7dc1f64bea3a2b1498fb69e597e4d03360.1728148557.git.suhail@bayesians.ca> <87o73xgyf2.fsf@omar-Latitude-5540.mail-host-address-is-not-set> Date: Sun, 06 Oct 2024 11:46:20 -0400 Message-ID: <87msjh5j5f.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: 72925@debbugs.gnu.org, Suhail Singh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Omar Bassam writes: >> + #:use-module (gnu packages certs) > > If we don't need nss-verts, do we still need this line? Good catch. We don't need this. Please remove in v11 when you send it. >> + (propagated-inputs (list janet >> + ;; Lazily resolve the gcc-toolchain to avoid a >> + ;; circular dependency. >> + (module-ref (resolve-interface '(gnu packages >> + commencement)) >> + 'gcc-toolchain))) > > Since we no longer need gcc-toolchain and we are just using gcc > directly, should we remove this module-ref expression and just add gcc > as a propagated input? What we need is _some_ mechanism to ensure that when jpm invokes gcc (or g++), the compiler is able to locate the appropriate header files. This should be doable without propagating any other inputs. For example by ensuring that jpm sets appropriate environment variables (such as $CPATH , $C_INCLUDE_PATH , $CPLUS_INCLUDE_PATH etc.) or flags when invoking the compiler. If so, that would be the preferred approach. We only want to propagate those inputs that are strictly necessary. I do know that when I had tried to remove gcc-toolchain (without doing anything else) I encountered some errors during "jpm install -l sh" (in a pure shell). However, I did not spend any effort in simplifying this, and I agree that we should try to. I look forward to seeing what you come up with in v11 :) >> + ;; NOTE: Below ensures that the user provides the CA certificates they >> + ;; desire (as opposed to bundling `nss-certs' in propagated-inputs, which >> + ;; isn't recommended) and when they do, that they are respected. > > Why isn't bundling nss-certs recommended? Doing so would deprive the user of the choice of which CAs to trust. I.e., if we were to bundle nss-certs we are taking an opinionated stance that the user agrees with Mozilla project's stance on these matters. >> + ;; FIXME: It's unclear why `search-paths', instead of >> + ;; `native-search-paths', doesn't work. > > What are the difference between search-paths and > native-search-paths. These are documented in the info manual. However, it's not clear to me _why_ native-search-paths is the right thing to use in this situation. I posted a message on guix-devel regarding this: . The FIXME was simply an attempt to get the attention of others more knowledgable than me. Use your discretion regd. whether to keep it or not. > And were you able to run the "jpm install" command without > nss-certs. Because, for me I was unable to do so. When I added back > the nss-certs in propagated-inputs, it worked fine. That is expected behaviour. The way to test it, when in a pure container, would be by explicitly ensuring that certificates of trusted CAs are included in the profile. On way to do so would by adding nss-certs alongside jpm when invoking the shell. Relying on the package to provide nss-certs isn't desirable. We simply want to ensure that when the certs are provided that the package _is able to use_ them. This is what the native-search-paths line accomplishes. -- Suhail From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 06 15:50:05 2024 Received: (at 72925) by debbugs.gnu.org; 6 Oct 2024 19:50:05 +0000 Received: from localhost ([127.0.0.1]:42377 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxXGW-00058L-Sx for submit@debbugs.gnu.org; Sun, 06 Oct 2024 15:50:05 -0400 Received: from mail-wr1-f50.google.com ([209.85.221.50]:52343) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxXGV-00057k-64 for 72925@debbugs.gnu.org; Sun, 06 Oct 2024 15:50:04 -0400 Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-37cdac05af9so3616789f8f.0 for <72925@debbugs.gnu.org>; Sun, 06 Oct 2024 12:49:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728244130; x=1728848930; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Y0+PTlBTYhmC8souGrNz3cbH5syx5wTtGDVz14EGNkA=; b=njSJB1oQ+g2jB5FWfw0WryMFbcaeqF/0+M8UsNnemMTCz/jZmZ7VBu5puwV4QlzGcK QnOAtoN/xo37N9YnjAHa4BVLvicult7qs7WzFrZIdzAtCKct3jXNrF4tSzXafyowO9nK Rj4DIPy/qjT8OgxFiiOvIxdYU4/dWRYj7WYW/c4nZPTeH+xPGIrX8LB7GaYAjBeE2iF/ q1grziOX+9lg3kDB4P071YAyx6mjynOAt55JUK1lD7uh/DH0SOso6vYvDNVoZtZc+MV1 92XkN+5HkcXRO0ONVoSNvQrW+aGbgv4ex3J0Xrcwxd1UbJN1ex8kGA+HOxEaC4xWwNso GYvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728244130; x=1728848930; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Y0+PTlBTYhmC8souGrNz3cbH5syx5wTtGDVz14EGNkA=; b=TRakS4J5KbiNsq4vlAPKwIIhMIDKVuvB53xi/Ix8sRCYeUNZmMQj8JQfq0SuqvhRFH U9/9QduXmpaAFD3kWXfFrjOqckmtlyss1TDvOYWjxJAt0/7CSJisuez2i/21RLY8UOmp 84UHQEmxBlJBKpBPdkgkGpNJfmeXykNFuWB2RJIgEJSw9VEaD3tCa6rQ9Hxh1E8SMp4H I4lpsMEBQsvTG5nHrno06WZEst7/VoqdnHcjm8Unw5eVtPH92cE8PIqHEzvQ7vP+GtQw Y5NJHqYsS0DvLUCu85W+njWcLUg1RNonGHdftdBY9uzz1mrlr1sc7Pam927zX3+LKcDr so/w== X-Forwarded-Encrypted: i=1; AJvYcCXuuI3If4tHsKiG95um35stYmL3v3B7FFrihjTy+xfbFQJ0+o0sGK4mOcJjxc1PRjCdHEH/Tg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxYR2qyFJRANIROs4KUuXw7qm4jtsGo0cBOhJA6/BV49W3gDIB1 6Vdj7d/282tIOZWcwCW3MSTRLI0Ygr43n88ug7FR7OS4SwI4KsCyUFYv3HZO X-Google-Smtp-Source: AGHT+IELKY2tV0hTPdtUoF4qBwbhUo5nqFkXlAEKYHgbyUHJnQr6QQcYU/nBgqkMcPieGUmNdZ6KIQ== X-Received: by 2002:a5d:58d8:0:b0:37c:cc60:2c56 with SMTP id ffacd0b85a97d-37d0e6eab2cmr8814727f8f.5.1728244129519; Sun, 06 Oct 2024 12:48:49 -0700 (PDT) Received: from omar-Latitude-5540 ([46.232.152.32]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a995253abfasm72432666b.185.2024.10.06.12.48.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Oct 2024 12:48:48 -0700 (PDT) From: Omar Bassam X-Google-Original-From: Omar Bassam To: Suhail Singh Subject: Re: [PATCH v10] gnu: Add jpm. In-Reply-To: <87msjh5j5f.fsf@gmail.com> (Suhail Singh's message of "Sun, 06 Oct 2024 11:46:20 -0400") References: <6e198e7dc1f64bea3a2b1498fb69e597e4d03360.1728148557.git.suhail@bayesians.ca> <87o73xgyf2.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87msjh5j5f.fsf@gmail.com> Date: Sun, 06 Oct 2024 22:48:47 +0300 Message-ID: <87bjzxgggw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: 72925@debbugs.gnu.org, Omar Bassam X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi Suhail, Sorry, I have more questions. > Omar Bassam writes: > >>> + #:use-module (gnu packages certs) >> >> If we don't need nss-verts, do we still need this line? > > Good catch. We don't need this. Please remove in v11 when you send it. > >>> + (propagated-inputs (list janet >>> + ;; Lazily resolve the gcc-toolchain to avoid a >>> + ;; circular dependency. >>> + (module-ref (resolve-interface '(gnu packages >>> + commencement)) >>> + 'gcc-toolchain))) >> >> Since we no longer need gcc-toolchain and we are just using gcc >> directly, should we remove this module-ref expression and just add gcc >> as a propagated input? > > What we need is _some_ mechanism to ensure that when jpm invokes gcc (or > g++), the compiler is able to locate the appropriate header files. > > This should be doable without propagating any other inputs. For example > by ensuring that jpm sets appropriate environment variables (such as > $CPATH , $C_INCLUDE_PATH , $CPLUS_INCLUDE_PATH etc.) or flags when > invoking the compiler. If so, that would be the preferred approach. We > only want to propagate those inputs that are strictly necessary. > > I do know that when I had tried to remove gcc-toolchain (without doing > anything else) I encountered some errors during "jpm install -l sh" (in > a pure shell). However, I did not spend any effort in simplifying this, > and I agree that we should try to. > > I look forward to seeing what you come up with in v11 :) > I gave tried replacing gcc-toolchain with gcc and both the "jpm install" commands and the "jpm build" commands worked fine for me without any issues. I didn't need to set up any C related environemnt variables. What kind of error where you getting? >>> + ;; NOTE: Below ensures that the user provides the CA certificates they >>> + ;; desire (as opposed to bundling `nss-certs' in propagated-inputs, which >>> + ;; isn't recommended) and when they do, that they are respected. >> >> Why isn't bundling nss-certs recommended? > > Doing so would deprive the user of the choice of which CAs to trust. > I.e., if we were to bundle nss-certs we are taking an opinionated stance > that the user agrees with Mozilla project's stance on these matters. > But how will the user know that they will need to install nss-certs in the shell or that they need to setup these SSL environemnt variables? I agree of giving the user the freedom to enable or disable this but I truly believe we need to provide sane defaults. >>> + ;; FIXME: It's unclear why `search-paths', instead of >>> + ;; `native-search-paths', doesn't work. >> >> What are the difference between search-paths and >> native-search-paths. > > These are documented in the info manual. However, it's not clear to me > _why_ native-search-paths is the right thing to use in this situation. > I posted a message on guix-devel regarding this: > . > OK, please let me know when you get to the bottom of this. > The FIXME was simply an attempt to get the attention of others more > knowledgable than me. Use your discretion regd. whether to keep it or > not. > >> And were you able to run the "jpm install" command without >> nss-certs. Because, for me I was unable to do so. When I added back >> the nss-certs in propagated-inputs, it worked fine. > > That is expected behaviour. > > The way to test it, when in a pure container, would be by explicitly > ensuring that certificates of trusted CAs are included in the profile. > On way to do so would by adding nss-certs alongside jpm when invoking > the shell. > > Relying on the package to provide nss-certs isn't desirable. We simply > want to ensure that when the certs are provided that the package _is > able to use_ them. This is what the native-search-paths line > accomplishes. I still don't understand why is it an expected behaviour if jpm by default is expected to download packages mainly from github? BRs, Omar From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 06 17:45:59 2024 Received: (at 72925) by debbugs.gnu.org; 6 Oct 2024 21:45:59 +0000 Received: from localhost ([127.0.0.1]:42635 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxZ4h-000350-6Q for submit@debbugs.gnu.org; Sun, 06 Oct 2024 17:45:59 -0400 Received: from mail-qk1-f193.google.com ([209.85.222.193]:52254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxZ4f-00034h-6B for 72925@debbugs.gnu.org; Sun, 06 Oct 2024 17:45:58 -0400 Received: by mail-qk1-f193.google.com with SMTP id af79cd13be357-7a9b72749bcso331050385a.0 for <72925@debbugs.gnu.org>; Sun, 06 Oct 2024 14:45:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728251085; x=1728855885; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Q1dWktniqilpb7evBneMicltxMRROhXrlTfrTJmnHg4=; b=MdUPRHoi9ruGWED3b9fd7BElKOkgfaTG0utmb1u4zLgGByoXHGIUo/xTfbZ8q9Roze KaOHlJ4TGEwlhmAY3338m2P7R1T0+q4dWuiW/ocEHuiCfSK+jlersu4t2CE/cEtTpgMD W3tmWIMpCDNjgF2WcLAGRpGne8n3pbLOGcmfGp2VvbeT91ickX4vZyQ63WMa33CiSRwa 6zPzLJ9AuL2H/Jf+WMkZuKLzjOvR1t2zX8xFvqt7WZhn7xJLalm82QE9FuhJZKr7Sqow tx22AnnwhnT7a/18rro1yRJT6WT4Odq855zZc69XPPFEhk7IqN+M3CqQaJw3lOr16SEG shSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728251085; x=1728855885; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Q1dWktniqilpb7evBneMicltxMRROhXrlTfrTJmnHg4=; b=ntJysMNdTRIHC6CNNUQPIA1Wy1+xeOAfWwqgdW5jg+2+5rE02KAZ7Ffc6k1rPPEzjN 2KMcFUlcLmIx7ST4QeuZeOiK6W/q3m8s/+bq43kCTi8zRJ4nDhH+WSrtaEG92GRxySiY 8NcNcrWKKpELZhKFy17I7D7RG0Nz1g30vHfT2yLBwC3NR+5/dhPoTjcoWl7wFxQjUHZy z8QWrLTjtoQINyDFrY/yKdcj0nQaJv57julPF/b+IDc1mevzHr73GJm50MIdiamOvFFf gUApj9P6nKQcY1vb17TAi32VDHMPp6g34h2kni0fLJgYgSjPROhXdlxsYnylbNV9TJSU k8Kw== X-Forwarded-Encrypted: i=1; AJvYcCVmFmX3q9Sf/p0096xg70/r95GR2hquJKeK4qNkDD9fWZGU9vyHSKcG5kxoMmwiebEMGp7QOQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyBvNVgzcU72/9wCJl5BqFtopmi3uZO/yZc5QXcG2e0mMPA5wlx PB6XCRyvbsWyPWVdqaXBWvRTxsH22BfZx9zd9DqvGXZx624usmIq442debdg X-Google-Smtp-Source: AGHT+IFUEsJX/+D7L49GWJvLwy5YcWq+jwi5dImO23+7vMKrmyha70xLgmjBuH6WIofWsEsHuKZerQ== X-Received: by 2002:a05:620a:319e:b0:7a9:be63:7b40 with SMTP id af79cd13be357-7ae6f422235mr1407000685a.3.1728251084615; Sun, 06 Oct 2024 14:44:44 -0700 (PDT) Received: from gnus (bras-base-mtrlpq0776w-grc-23-65-94-70-53.dsl.bell.ca. [65.94.70.53]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-45da755aa8csm20169991cf.57.2024.10.06.14.44.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Oct 2024 14:44:44 -0700 (PDT) From: Suhail Singh To: Omar Bassam Subject: Re: [PATCH v10] gnu: Add jpm. In-Reply-To: <87bjzxgggw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> (Omar Bassam's message of "Sun, 06 Oct 2024 22:48:47 +0300") References: <6e198e7dc1f64bea3a2b1498fb69e597e4d03360.1728148557.git.suhail@bayesians.ca> <87o73xgyf2.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87msjh5j5f.fsf@gmail.com> <87bjzxgggw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> Date: Sun, 06 Oct 2024 17:44:42 -0400 Message-ID: <8734l86h4l.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: 72925@debbugs.gnu.org, Suhail Singh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Omar Bassam writes: >> This should be doable without propagating any other inputs. For example >> by ensuring that jpm sets appropriate environment variables (such as >> $CPATH , $C_INCLUDE_PATH , $CPLUS_INCLUDE_PATH etc.) or flags when >> invoking the compiler. If so, that would be the preferred approach. We >> only want to propagate those inputs that are strictly necessary. >> >> I do know that when I had tried to remove gcc-toolchain (without doing >> anything else) I encountered some errors during "jpm install -l sh" (in >> a pure shell). However, I did not spend any effort in simplifying this, >> and I agree that we should try to. >> >> I look forward to seeing what you come up with in v11 :) >> > > I gave tried replacing gcc-toolchain with gcc and both the "jpm install" > commands and the "jpm build" commands worked fine for me without any > issues. I didn't need to set up any C related environemnt variables. > What kind of error where you getting? I am unable to get the exact message at the moment (due to non-technical and unrelated reasons), but it was some missing header file. As I mentioned in the quoted message above, however, what would be better than propagating gcc, g++ etc would be to ensure that jpm passes appropriate flags when invoking them. Have you looked into that? >>>> + ;; NOTE: Below ensures that the user provides the CA certificates they >>>> + ;; desire (as opposed to bundling `nss-certs' in propagated-inputs, which >>>> + ;; isn't recommended) and when they do, that they are respected. >>> >>> Why isn't bundling nss-certs recommended? >> >> Doing so would deprive the user of the choice of which CAs to trust. >> I.e., if we were to bundle nss-certs we are taking an opinionated stance >> that the user agrees with Mozilla project's stance on these matters. >> > > But how will the user know that they will need to install nss-certs in > the shell or that they need to setup these SSL environemnt variables? Are you saying that when you test in a _non-pure_ shell where system certificates are available, you observe failures? In pure containers, the failure one observes if the user hasn't done something to make certificates available is a commonly known occurrence. See for patch to change this default for networked containers. Note that if you're not using a pure container, things should just work. Please correct me if I am mistaken. > I agree of giving the user the freedom to enable or disable this but I > truly believe we need to provide sane defaults. Bundling nss-certs would depart from the current conventions in Guix (as I have recently come to understand). For what it's worth, I also (now) agree that it's not the place for _a package_ to make the determination of which CAs to trust vs not. However, since I don't have commit authority, you are welcome to ignore my opinions. My goal was simply to demonstrate a working patch that didn't depart from current conventions. I believe I did that. Perhaps there is a discussion to be had, to revise said conventions and/or to better understand the tradeoffs of said and related conventions. However, the guix-devel mailing list may be a better place for such discussions, and it might help your cause of upstreaming jpm if those discussions didn't block this patch. >>> What are the difference between search-paths and >>> native-search-paths. >> >> These are documented in the info manual. However, it's not clear to me >> _why_ native-search-paths is the right thing to use in this situation. >> I posted a message on guix-devel regarding this: >> . >> > > OK, please let me know when you get to the bottom of this. I invite you to join the discussion on guix-devel. It's possible that things that make sense to me, may not to you. >>> And were you able to run the "jpm install" command without >>> nss-certs. Because, for me I was unable to do so. When I added back >>> the nss-certs in propagated-inputs, it worked fine. >> >> That is expected behaviour. >> >> The way to test it, when in a pure container, would be by explicitly >> ensuring that certificates of trusted CAs are included in the profile. >> On way to do so would by adding nss-certs alongside jpm when invoking >> the shell. >> >> Relying on the package to provide nss-certs isn't desirable. We simply >> want to ensure that when the certs are provided that the package _is >> able to use_ them. This is what the native-search-paths line >> accomplishes. > > I still don't understand why is it an expected behaviour if jpm by > default is expected to download packages mainly from github? It is the expected behaviour given my understanding of current packaging practices in Guix. I have nothing more to add beyond what I've already said on this topic. Regards, -- Suhail From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 07 14:25:53 2024 Received: (at 72925) by debbugs.gnu.org; 7 Oct 2024 18:25:53 +0000 Received: from localhost ([127.0.0.1]:47928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxsQa-0003fy-LN for submit@debbugs.gnu.org; Mon, 07 Oct 2024 14:25:53 -0400 Received: from mail-ed1-f54.google.com ([209.85.208.54]:46381) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxsQY-0003fj-4g for 72925@debbugs.gnu.org; Mon, 07 Oct 2024 14:25:50 -0400 Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-5c89668464cso6337860a12.1 for <72925@debbugs.gnu.org>; Mon, 07 Oct 2024 11:25:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728325476; x=1728930276; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=XxGwfQHVj1fcFT4q/WPa6Z0HqmI7lYvAg5eQLefKUvE=; b=LBy9DGphBPZphszu1yBLCj9USX3W2ANIwPW5JTXUigvTFUGqQIStlblID0nYcB1/u9 IpOciGttcaQPsnqs5vn4A84hbR09VTUpM8+ZBywEPqHRS50PQJdgu/U1EqkAmNCM4bDj yaFlz+KmdNDu9y7yEv7jl23oUdWUlSJgl87p0bej2HZjSW4+qxSN3FLOqS6V6Z4WnFlw 9JPfA3R5trVhthK1EYylI/AQGavCIo1mc6+vohSMBtOu8QwL5COeLuMjfkc4JIU5y9AR SmWVX+m8W3Qlw8IfzwPippoPgwMRRzcHcC5gGg2E3TrfFJrYZHcpV9A6J4RAR9Idx1Ye iJVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728325476; x=1728930276; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XxGwfQHVj1fcFT4q/WPa6Z0HqmI7lYvAg5eQLefKUvE=; b=SOg7BSQ9pALljrlAl1zEkp1XgOb7JRoMGmbFELE07n++rEeOGIEcFVZQvY0Hj0csPG 9bwst9gHHAt0lmgaIyDICz8+ieYzY+qyQvv/MQxDSwjs0b9ERvQ9jZb02RoNH+ykSvdZ BQNL8kOj1c2NHSQZD3484RdroNrrTH7QJYd10XZur6WlZ9OhuLPcspVOIpGs55Skj3xi KwU4Ue+gmsJK0SbJsqeUMxiqplxGNWy++Lk+u3E5yxyPYJ9Gpw+ydhfy9U9FJu+5uX7y uZXRq84NE+/RdJjXF3NGXlJ4fbN9ART1wjtSmTvKT9iRHP1JZyGXdFTBbJspGma5sDn7 rKEA== X-Forwarded-Encrypted: i=1; AJvYcCX8kh++Ytkd+qdlN9CZwyzirr2Skl5vaVrH3DZLFBQMXJ551J/aZESdsOuozwHAnmpew1RteA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxaAhWANSq3CZTq6jqAfZXRdDCl/7bnSpgyGs+HVdLZGvCrqpPL 4cwTIP9STWM9humlLLwo4hLlVC0M1voYic9+3iTvWkFSZ7CjvhT/alPa8TZj X-Google-Smtp-Source: AGHT+IHyfWYZzzQ0f1yETtWhcAOv5qTZVVT+BxcSqSUsnB2efwuD1IJ8uIoGV3s2qh64g0zOngP0UA== X-Received: by 2002:a17:907:608b:b0:a99:56e1:bd30 with SMTP id a640c23a62f3a-a9956e1c04bmr360910266b.42.1728325475921; Mon, 07 Oct 2024 11:24:35 -0700 (PDT) Received: from omar-Latitude-5540 ([46.232.152.32]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a99457d756bsm287402266b.92.2024.10.07.11.24.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2024 11:24:35 -0700 (PDT) From: Omar Bassam X-Google-Original-From: Omar Bassam To: Suhail Singh Subject: Re: [PATCH v10] gnu: Add jpm. In-Reply-To: <8734l86h4l.fsf@gmail.com> (Suhail Singh's message of "Sun, 06 Oct 2024 17:44:42 -0400") References: <6e198e7dc1f64bea3a2b1498fb69e597e4d03360.1728148557.git.suhail@bayesians.ca> <87o73xgyf2.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87msjh5j5f.fsf@gmail.com> <87bjzxgggw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <8734l86h4l.fsf@gmail.com> Date: Mon, 07 Oct 2024 21:24:33 +0300 Message-ID: <871q0rhiu6.fsf@omar-Latitude-5540.mail-host-address-is-not-set> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: 72925@debbugs.gnu.org, Omar Bassam X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Suhail Singh writes: > Omar Bassam writes: > >>> This should be doable without propagating any other inputs. For example >>> by ensuring that jpm sets appropriate environment variables (such as >>> $CPATH , $C_INCLUDE_PATH , $CPLUS_INCLUDE_PATH etc.) or flags when >>> invoking the compiler. If so, that would be the preferred approach. We >>> only want to propagate those inputs that are strictly necessary. >>> >>> I do know that when I had tried to remove gcc-toolchain (without doing >>> anything else) I encountered some errors during "jpm install -l sh" (in >>> a pure shell). However, I did not spend any effort in simplifying this, >>> and I agree that we should try to. >>> >>> I look forward to seeing what you come up with in v11 :) >>> >> >> I gave tried replacing gcc-toolchain with gcc and both the "jpm install" >> commands and the "jpm build" commands worked fine for me without any >> issues. I didn't need to set up any C related environemnt variables. >> What kind of error where you getting? > > I am unable to get the exact message at the moment (due to non-technical > and unrelated reasons), but it was some missing header file. > > As I mentioned in the quoted message above, however, what would be > better than propagating gcc, g++ etc would be to ensure that jpm passes > appropriate flags when invoking them. Have you looked into that? > I am not really an expert in compiling C programs so I'm not sure what would be the best way to verify this? the "jpm build" command ran fine for me and I don't have any of those C*PATH environment variables set. >>>>> + ;; NOTE: Below ensures that the user provides the CA certificates they >>>>> + ;; desire (as opposed to bundling `nss-certs' in propagated-inputs, which >>>>> + ;; isn't recommended) and when they do, that they are respected. >>>> >>>> Why isn't bundling nss-certs recommended? >>> >>> Doing so would deprive the user of the choice of which CAs to trust. >>> I.e., if we were to bundle nss-certs we are taking an opinionated stance >>> that the user agrees with Mozilla project's stance on these matters. >>> >> >> But how will the user know that they will need to install nss-certs in >> the shell or that they need to setup these SSL environemnt variables? > > Are you saying that when you test in a _non-pure_ shell where system > certificates are available, you observe failures? Yes, it did fail initially even in a non-pure non-container shell. I had to manually set the SSL_CERT_DIR environment variable to /etc/ssl/certs (I'm on Ubuntu). I did not need to set the SSL_CERT_FILE variable. Is it possible to set a default value for that environment variable? I'm not sure though if the /etc/ssl/certs/ is a standard among all Linux distros or just Ubuntu. > > In pure containers, the failure one observes if the user hasn't done > something to make certificates available is a commonly known occurrence. > See for patch to change this default > for networked containers. > > Note that if you're not using a pure container, things should just work. > Please correct me if I am mistaken. > >> I agree of giving the user the freedom to enable or disable this but I >> truly believe we need to provide sane defaults. > > Bundling nss-certs would depart from the current conventions in Guix (as > I have recently come to understand). For what it's worth, I also (now) > agree that it's not the place for _a package_ to make the determination > of which CAs to trust vs not. However, since I don't have commit > authority, you are welcome to ignore my opinions. My goal was simply to > demonstrate a working patch that didn't depart from current conventions. > I believe I did that. > > Perhaps there is a discussion to be had, to revise said conventions > and/or to better understand the tradeoffs of said and related > conventions. However, the guix-devel mailing list may be a better place > for such discussions, and it might help your cause of upstreaming jpm if > those discussions didn't block this patch. > >>>> What are the difference between search-paths and >>>> native-search-paths. >>> >>> These are documented in the info manual. However, it's not clear to me >>> _why_ native-search-paths is the right thing to use in this situation. >>> I posted a message on guix-devel regarding this: >>> . >>> >> >> OK, please let me know when you get to the bottom of this. > > I invite you to join the discussion on guix-devel. It's possible that > things that make sense to me, may not to you. > Thank you, I'm relatively very new to Guix, so I definitely need to read involved more about those discussions. >>>> And were you able to run the "jpm install" command without >>>> nss-certs. Because, for me I was unable to do so. When I added back >>>> the nss-certs in propagated-inputs, it worked fine. >>> >>> That is expected behaviour. >>> >>> The way to test it, when in a pure container, would be by explicitly >>> ensuring that certificates of trusted CAs are included in the profile. >>> On way to do so would by adding nss-certs alongside jpm when invoking >>> the shell. >>> >>> Relying on the package to provide nss-certs isn't desirable. We simply >>> want to ensure that when the certs are provided that the package _is >>> able to use_ them. This is what the native-search-paths line >>> accomplishes. >> >> I still don't understand why is it an expected behaviour if jpm by >> default is expected to download packages mainly from github? > > It is the expected behaviour given my understanding of current packaging > practices in Guix. I have nothing more to add beyond what I've already > said on this topic. > > Regards, BRs, Omar From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 07 14:52:44 2024 Received: (at 72925) by debbugs.gnu.org; 7 Oct 2024 18:52:44 +0000 Received: from localhost ([127.0.0.1]:48163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxsqa-0005cw-3q for submit@debbugs.gnu.org; Mon, 07 Oct 2024 14:52:44 -0400 Received: from mail-qv1-f67.google.com ([209.85.219.67]:60482) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxsqZ-0005cp-1j for 72925@debbugs.gnu.org; Mon, 07 Oct 2024 14:52:43 -0400 Received: by mail-qv1-f67.google.com with SMTP id 6a1803df08f44-6cb2c5128d5so37966546d6.0 for <72925@debbugs.gnu.org>; Mon, 07 Oct 2024 11:52:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728327094; x=1728931894; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=AEE42sylsDYne4bIhWHuGrkvKq2zPIX09V4NmAV2Omo=; b=F0O0iKrQ+8aRJkCOw3IIGXa4B6dD3XrXb1+rbKFoybbKAUiUWM8nVt7hB4QuFkL2mx QQ2TtK97D9f1Tu/fhtZYhTESyWDaEQGha0zFH6FHH+tkrl3uNYK4Wq8mPxqiK9Gs7TMJ be/QIJ25ymINYI5dSwVoovOLy8N36N2tJFZ7ohRUGxzaxoW7Ux5FRrvZZWmg7khQXzn1 NeqekHvlyLLr/FUZIEpLs6JPpNGqALBTNBE8gvDY0m5/+Peq3pANm9sVBCCOtcgPkjtx DfW/ufHqRZRrSNitg43QvrSmx3xRyPv8kzl5zbZ7ZCqJHmPtlsFYCNzK+P0WvKzr8Mf0 raKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728327094; x=1728931894; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AEE42sylsDYne4bIhWHuGrkvKq2zPIX09V4NmAV2Omo=; b=QnxAP72laTHwMQMKsv3fXljCMttMZsXBsYIOq4/oXWDvkihiqNU6xkeK0lR/1OoAXc Dj2dVHJ24tTpz7tIG8OmscBC/7X9nrRCsF+HCm16F/R7BP07YQhhaUHTYo6xc5mY3ZMM tqUtWoWVgOOqJM+72FM36jlUZelQEECP0g4sCo9JqhXvgDiJHLAQ0l6EU7OljLd5KDZ0 Z49Es97ch8Pe5GijUECUrSdlcMFHBUEJOrh9lzsxG29jN4zRVKAVN1RloMRvxGL4ygfh MZnjtEbiUQlOVxUAYl+ug+UTn/5HfrsrxEvnAqjIjPuZ/b3/p/9tMNn0ABGAzAnsDmeg gQ/A== X-Forwarded-Encrypted: i=1; AJvYcCU/TGuwMsXvvMXS4ADKgOyRIvrTqg2p9cTAke530RdSkOlGJf5XejVH78tklc87/3D17oiuHw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzduBYu7JiwSArvoVRSBtJvkGOI0JUnY5BoN0tEuYSnEfQtvkrk rk7JVKLry5eWmQJsBMNVwV7BiJRzbyNbwqtsOzpZFBCapGB3/dIFJjt8eQ5s X-Google-Smtp-Source: AGHT+IFd2uL8s2mpwtvJNWjq2xXOs52t1kMJ6NV9XujNtN/Of2mVC+PutE82Laki9mXDuCDZJj4wYQ== X-Received: by 2002:a05:6214:5983:b0:6c5:73a6:ff37 with SMTP id 6a1803df08f44-6cb9a308253mr189209656d6.5.1728327094157; Mon, 07 Oct 2024 11:51:34 -0700 (PDT) Received: from gnus ([65.94.70.53]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6cba46dfd5fsm28102246d6.52.2024.10.07.11.51.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2024 11:51:33 -0700 (PDT) From: Suhail Singh To: Omar Bassam Subject: Re: [PATCH v10] gnu: Add jpm. In-Reply-To: <871q0rhiu6.fsf@omar-Latitude-5540.mail-host-address-is-not-set> (Omar Bassam's message of "Mon, 07 Oct 2024 21:24:33 +0300") References: <6e198e7dc1f64bea3a2b1498fb69e597e4d03360.1728148557.git.suhail@bayesians.ca> <87o73xgyf2.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87msjh5j5f.fsf@gmail.com> <87bjzxgggw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <8734l86h4l.fsf@gmail.com> <871q0rhiu6.fsf@omar-Latitude-5540.mail-host-address-is-not-set> Date: Mon, 07 Oct 2024 14:51:22 -0400 Message-ID: <877cajiw5x.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: 72925@debbugs.gnu.org, Suhail Singh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Omar Bassam writes: >>> I gave tried replacing gcc-toolchain with gcc and both the "jpm install" >>> commands and the "jpm build" commands worked fine for me without any >>> issues. I didn't need to set up any C related environemnt variables. >>> What kind of error where you getting? >> >> I am unable to get the exact message at the moment (due to non-technical >> and unrelated reasons), but it was some missing header file. >> >> As I mentioned in the quoted message above, however, what would be >> better than propagating gcc, g++ etc would be to ensure that jpm passes >> appropriate flags when invoking them. Have you looked into that? >> > > I am not really an expert in compiling C programs so I'm not sure what > would be the best way to verify this? the "jpm build" command ran fine > for me and I don't have any of those C*PATH environment variables set. When gcc-toolchain is excluded from propagated-inputs, and neither gcc nor g++ is in propagated-inputs (i.e., propagated-inputs only contains janet), you *don't* observe a build failure in a _pure_ container where nss-certs is available while evaluating "jpm install -l sh"? If so, please let me know and I shall try and reproduce the error I experienced. If not, and you are simply stating that things work by propagating gcc and g++, then we are talking about different things. Specifically, I was considering what would be needed for eliminating gcc and g++ from propagated-inputs. > Is it possible to set a default value for that environment variable? Since you already set $JANET_HEADERPATH and $JANET_LIBPATH via wrap-program, I am not sure I understand the complication you're running into while trying to provide a default for $SSL_CERT_DIR. -- Suhail From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 07 15:18:25 2024 Received: (at 72925) by debbugs.gnu.org; 7 Oct 2024 19:18:25 +0000 Received: from localhost ([127.0.0.1]:48219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxtFR-0006vo-0V for submit@debbugs.gnu.org; Mon, 07 Oct 2024 15:18:25 -0400 Received: from mail-ed1-f48.google.com ([209.85.208.48]:49207) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxtFO-0006vg-KA for 72925@debbugs.gnu.org; Mon, 07 Oct 2024 15:18:23 -0400 Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-5c89e66012aso6403465a12.2 for <72925@debbugs.gnu.org>; Mon, 07 Oct 2024 12:18:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728328634; x=1728933434; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=cQxWPIMv1HrwUGuEq2XkgJTMKfdRQ8HPGw/KImw2mCQ=; b=XWQI3tKNQr6ZjmoCgufmadD8E/MNH4FT7mGtrBPXx9G4eo1ynhoDcmmE0hkzr/xgzf Qv8J4kvEyA8ZIBZ1DhtnfvTPSktnlpnEXPBqKPAuVk12TxRQIMp2jvZs4BODgnyGLq7M DYSHKMTq07z+Vo6G7LDEY/EvePQSNxrXT5I4TdkJWs8viH6SGd7HVialUPbk0Mn2fQvu 8TjXGwTCtRM3ed3LJp+fNg8TOc7UVPwFatRbhS9/KFjbcDP9wFIZQLLuR47C2X4Ss647 I5K5e17OdthsTotK3NeloFXrsVjnjruB/uK5CdrZN4ttqHY07seRcndykUAwC+RCaEiL RiMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728328634; x=1728933434; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cQxWPIMv1HrwUGuEq2XkgJTMKfdRQ8HPGw/KImw2mCQ=; b=dpcUccp8QBLkrt/7NSyQmPCtUM/mpkZ9qz/P2chF+tFO7xcACzMeluQWpS6Iv8oCAs l7KTHClKmTrdnquYH+FWNWkXTZnNWBPol0rEnr1tSz5lmoLPBQujF9lQ8Cth7wx5+nHh YOCp3kzttnqjRU7RSot7UzeVVp0NEBqc29sNuy+WfxsPFU/sy3/3LRRUWREeZ3Gc7RYO 81UW6nB1Y66kUi5bnTgMPWfDzc64SxweFbSYMwDZ4MANnQF8DIvkuPwuhHHA+9ey8Evc CXr9L56phSLB9UvGPhpvtjqmovHK2HO8Zhj9UeiJUYNpeEKbS+WYb4MnzQR/QruPgyB7 yQtw== X-Forwarded-Encrypted: i=1; AJvYcCUP0Gij60Q33xWSC0o0gVEcYzoCWsyuyqEKwAae6JrCf7QxIfBfU+4e+CIpiXF5VCQbLgWGmA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzLUgUyT996AWJPPwecbXDX1KjdntMfM3bZXXf5fuQi2A3O4d/m iaWQqw5AQPe4dU/wCeRldazt3FfS3KuL29RzV0I9ZFZq65BVNKkkPqxfyphr X-Google-Smtp-Source: AGHT+IGNwemWgHKFOVMOT6TfnAKoUfgJTYVNK3oBSft/eiCYtOrQN7pmUVv132sFnIKPPzyP1L55PQ== X-Received: by 2002:a05:6402:4290:b0:5a3:a4d7:caf5 with SMTP id 4fb4d7f45d1cf-5c8d2eb4b73mr12332107a12.36.1728328633333; Mon, 07 Oct 2024 12:17:13 -0700 (PDT) Received: from omar-Latitude-5540 ([46.232.152.32]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c8e0597824sm3482659a12.15.2024.10.07.12.17.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2024 12:17:11 -0700 (PDT) From: Omar Bassam X-Google-Original-From: Omar Bassam To: Suhail Singh Subject: Re: [PATCH v10] gnu: Add jpm. In-Reply-To: <877cajiw5x.fsf@gmail.com> (Suhail Singh's message of "Mon, 07 Oct 2024 14:51:22 -0400") References: <6e198e7dc1f64bea3a2b1498fb69e597e4d03360.1728148557.git.suhail@bayesians.ca> <87o73xgyf2.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87msjh5j5f.fsf@gmail.com> <87bjzxgggw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <8734l86h4l.fsf@gmail.com> <871q0rhiu6.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <877cajiw5x.fsf@gmail.com> Date: Mon, 07 Oct 2024 22:17:10 +0300 Message-ID: <87ttdng1u1.fsf@omar-Latitude-5540.mail-host-address-is-not-set> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: 72925@debbugs.gnu.org, Omar Bassam X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Suhail Singh writes: > Omar Bassam writes: > >>>> I gave tried replacing gcc-toolchain with gcc and both the "jpm install" >>>> commands and the "jpm build" commands worked fine for me without any >>>> issues. I didn't need to set up any C related environemnt variables. >>>> What kind of error where you getting? >>> >>> I am unable to get the exact message at the moment (due to non-technical >>> and unrelated reasons), but it was some missing header file. >>> >>> As I mentioned in the quoted message above, however, what would be >>> better than propagating gcc, g++ etc would be to ensure that jpm passes >>> appropriate flags when invoking them. Have you looked into that? >>> >> >> I am not really an expert in compiling C programs so I'm not sure what >> would be the best way to verify this? the "jpm build" command ran fine >> for me and I don't have any of those C*PATH environment variables set. > > When gcc-toolchain is excluded from propagated-inputs, and neither gcc > nor g++ is in propagated-inputs (i.e., propagated-inputs only contains > janet), you *don't* observe a build failure in a _pure_ container where > nss-certs is available while evaluating "jpm install -l sh"? > > If so, please let me know and I shall try and reproduce the error I > experienced. Sorry, I didn't fully explain. I meant that instead of doing this module-ref expression to include "gcc-toolchain", I simply included "gcc" (which is already imported in lisp.scm) in the propagated-inputs and it worked fine (in a pure container) for both the "jpm install" and the "jpm build" command. > > If not, and you are simply stating that things work by propagating gcc > and g++, then we are talking about different things. Specifically, I > was considering what would be needed for eliminating gcc and g++ from > propagated-inputs. > >> Is it possible to set a default value for that environment variable? > > Since you already set $JANET_HEADERPATH and $JANET_LIBPATH via > wrap-program, I am not sure I understand the complication you're running > into while trying to provide a default for $SSL_CERT_DIR. So you think the following would make sense as a sane default for the "SSL_CERT_DIR" env variables as an example? #+begin_src scheme (native-search-paths (list (search-path-specification (variable "SSL_CERT_DIR") (files (list "/etc/ssl/certs/"))))) #+end_src I'm not sure what would be a good default for "SSL_CERT_FILE" though. Thanks, Omar From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 07 16:16:45 2024 Received: (at 72925) by debbugs.gnu.org; 7 Oct 2024 20:16:45 +0000 Received: from localhost ([127.0.0.1]:48355 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxu9s-0001fX-Ku for submit@debbugs.gnu.org; Mon, 07 Oct 2024 16:16:44 -0400 Received: from mail-qv1-f68.google.com ([209.85.219.68]:50392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxu9p-0001fO-Eb for 72925@debbugs.gnu.org; Mon, 07 Oct 2024 16:16:42 -0400 Received: by mail-qv1-f68.google.com with SMTP id 6a1803df08f44-6cb2f271043so54614516d6.0 for <72925@debbugs.gnu.org>; Mon, 07 Oct 2024 13:16:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728332133; x=1728936933; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=M2YLUSfzLDhpluav2op2E7UgJD6wmnaYau9KjNOYsF8=; b=LJS6lAV+eeFdj1JFF8K5mAHmWmz7S2fgC+TSblBDB/XOqluKglOmr/VO0IWwg6gcXY kl1QzvwESbLryB9h4AZrJ3cXoD7+ypdBxIY5z7ukJ89N1KCcM/pQB4vxpn0tWyhbUJLA RU9m4zNJFv6zSsmkc3mQNt2v9cKSBP1dDP+A05d1yJJpmyn98mV8qc/1/AZBAq0OybCL dbl71xpl006oQZ37PbUZ2PczXd6FWdXZdl+tNeX/T2mm6IhfkWK9WcoMhkRl3Q0DgAXE 2p1RCNngNcppXebXMTQ8uUvsrFtSw8ChocqLkBWMeARpV6MO/98cvibmQPUckwgDufOo IMzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728332133; x=1728936933; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=M2YLUSfzLDhpluav2op2E7UgJD6wmnaYau9KjNOYsF8=; b=X/FMQCIjFVFcbR/XbRdwf+NSvdRnC43+G1CxAjSpL9Wa3W9j+D7YdE/ZWjMvEQeWNY DVAg/TwCw29FpmERzVLv7qLtuWYkqke1gzhW1MuiPHqPRAlko4itBWf8wU+qnr473E4m xBJQqhh6ctNQr4sYpjJP7DtU1dB0f5jqbxPzROGYLUjGJmsUgBkFkTImiu2izMDn3tPF ELrjF0ElQ8IM0AuU7Kigcj2EXIbjtTnSJq1y708ZUYs4k4507tuLcxcwkcN3axE7fEk+ lf0a4sYSduNiWWvpwySGkhwG9EpTSOwf8C1z9wIvLUwYUDoCDg+b2KVjn27NV1V7D1+1 0gTg== X-Forwarded-Encrypted: i=1; AJvYcCWWXfENOsuNpZQ6ylwkI6/6W74HNyU473Dp8B3apq8DBUNE4lFkpdNRUCkMCtCTCPmoaLpmgg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzpDtgq4nOwQfP96vNi1IGbkzRfQF1zdLAnwb8Qq6AsLCQJD6es Ak6yg4mH2ms7BGzpkgGRyvan32XL9yYzvGxDNlZ5fS+3cmuWJ/o9qngPV+/I X-Google-Smtp-Source: AGHT+IE4XGxCn1/bMlTN8eYR5oOM7DflnLMDUZ/4h0GGOw2hH/1TDq1GemVkR6yepunKGnN6ioOJKA== X-Received: by 2002:a05:6214:311b:b0:6cb:830f:3541 with SMTP id 6a1803df08f44-6cb9a308ca6mr212115376d6.13.1728332132718; Mon, 07 Oct 2024 13:15:32 -0700 (PDT) Received: from gnus ([65.94.70.53]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6cba475ffefsm28718086d6.120.2024.10.07.13.15.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2024 13:15:32 -0700 (PDT) From: Suhail Singh To: Omar Bassam Subject: Re: [PATCH v10] gnu: Add jpm. In-Reply-To: <87ttdng1u1.fsf@omar-Latitude-5540.mail-host-address-is-not-set> (Omar Bassam's message of "Mon, 07 Oct 2024 22:17:10 +0300") References: <6e198e7dc1f64bea3a2b1498fb69e597e4d03360.1728148557.git.suhail@bayesians.ca> <87o73xgyf2.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87msjh5j5f.fsf@gmail.com> <87bjzxgggw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <8734l86h4l.fsf@gmail.com> <871q0rhiu6.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <877cajiw5x.fsf@gmail.com> <87ttdng1u1.fsf@omar-Latitude-5540.mail-host-address-is-not-set> Date: Mon, 07 Oct 2024 16:15:21 -0400 Message-ID: <875xq3k6ue.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: 72925@debbugs.gnu.org, Suhail Singh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Omar Bassam writes: >> When gcc-toolchain is excluded from propagated-inputs, and neither gcc >> nor g++ is in propagated-inputs (i.e., propagated-inputs only contains >> janet), you *don't* observe a build failure in a _pure_ container where >> nss-certs is available while evaluating "jpm install -l sh"? >> >> If so, please let me know and I shall try and reproduce the error I >> experienced. > > Sorry, I didn't fully explain. I meant that instead of doing this > module-ref expression to include "gcc-toolchain", I simply included > "gcc" (which is already imported in lisp.scm) in the propagated-inputs > and it worked fine (in a pure container) for both the "jpm install" and > the "jpm build" command. That not surprising. As I mentioned in my last: >> If not, and you are simply stating that things work by propagating gcc >> and g++, then we are talking about different things. Specifically, I >> was considering what would be needed for eliminating gcc and g++ from >> propagated-inputs. And as I mentioned in a still older message: >>>>>> What we need is _some_ mechanism to ensure that when jpm invokes gcc (or >>>>>> g++), the compiler is able to locate the appropriate header files. >>>>>> >>>>>> This should be doable without propagating any other inputs. For example >>>>>> by ensuring that jpm sets appropriate environment variables (such as >>>>>> $CPATH , $C_INCLUDE_PATH , $CPLUS_INCLUDE_PATH etc.) or flags when >>>>>> invoking the compiler. If so, that would be the preferred approach. We >>>>>> only want to propagate those inputs that are strictly necessary. >>>>>> >>>>>> ... >>>>>> >>>>>> I look forward to seeing what you come up with in v11 :) I.e., it's not clear to me that propagating gcc and g++ is necessary. And if the same can be achieved by passing appropriate environment variables, why not? Could you please answer? Regardless, we are in agreement that the propagation of gcc-toolchain is not necessary and should be removed. > So you think the following would make sense as a sane default for the > "SSL_CERT_DIR" env variables as an example? > > #+begin_src scheme > (native-search-paths > (list (search-path-specification > (variable "SSL_CERT_DIR") > (files (list "/etc/ssl/certs/"))))) > #+end_src I am quite confused. In the v10 I shared, native-search-paths already includes $SSL_CERT_DIR, whicb if you look at the source is defined as: #+begin_src scheme (define $SSL_CERT_DIR (search-path-specification (variable "SSL_CERT_DIR") (separator #f) ;single entry (files '("etc/ssl/certs")))) #+end_src I am no longer sure what problem you are trying to solve. -- Suhail From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 07 17:09:56 2024 Received: (at 72925) by debbugs.gnu.org; 7 Oct 2024 21:09:56 +0000 Received: from localhost ([127.0.0.1]:48551 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxuzL-0004Tm-O8 for submit@debbugs.gnu.org; Mon, 07 Oct 2024 17:09:56 -0400 Received: from mail-ej1-f53.google.com ([209.85.218.53]:43206) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxuzJ-0004Tc-1f for 72925@debbugs.gnu.org; Mon, 07 Oct 2024 17:09:54 -0400 Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a99415adecaso370600366b.0 for <72925@debbugs.gnu.org>; Mon, 07 Oct 2024 14:09:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728335324; x=1728940124; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=uKb+d32OYQ3jyheG44SBikTiazh7IaELvxCkm/DqjpY=; b=EN8ehI/o/f879+hFi+YSc+NzIlASnJ3GPePSbzzQbebIeyScN1BtT8NRigeEsBOqOH 4BHH13BOVGonAZKCe+MhsBklTFo3QCYlGeHis/c9/OaojiuUzmnR/KMyDkCnqII3h+hH 7rFdXZg9SfA4Y5oHKe4ejn0bjkpYd1k78dF4T2auKcdubxvbsYqAtzg12saRdK8BHArz T5N3qDVrDPkbNaeSkByXXkgDTLu8+UpaUxP+P5fJ4rcr8lplMJZobxQDCFwT2QKhczpa 60a/fgQLE37QWusgPbGPoUIWB3C9EYsTkv1ke1tP4IYKqQ4acCsLz3TcbRYDIETKO4Bi yngQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728335324; x=1728940124; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uKb+d32OYQ3jyheG44SBikTiazh7IaELvxCkm/DqjpY=; b=C4pFMgcAmhuR+LEuq2gJycJI0U+Hn4zEhwnsqvT1MsGNq8yrWsklULwYOxDMiC+2sR Fko5ZiLthhNkdzCjc5r/zuE4ZsAGlhJQzKzZMHwE3geh3hRAcOiMZbnsRwbidFdAZGLa Dbad3xnzTTqE9t2HtRJNBzW1QMqRVaZ3p3fLZjRh1Jf3RirZQwogE8es7zMpZiIULtk1 4x7jq5QueTDnvacegzNMv2Rsyp1g3QETeiusUjuBJvEolgcimeH2aWwGn6w1v2eSBsAA PSZBMwuJoicHB7OIBMZ5dytfb2QyBI298FSTe6kBe/QfSwWD40zYsC9PSKOrMD55QRWl r26Q== X-Gm-Message-State: AOJu0YySOxshmuY5rKk5+sXa1fXx5l7tcoIqZjdjiXrEn1eQ44+VLBPr YwtI9HtfGKcSv5v2gZvmCVHhHntEC8Hc7+g6PeIMRf2MzXHM3lcqKwUMxtgk X-Google-Smtp-Source: AGHT+IHO4Tf6Nyob7EJtrQnjaJ4SXu+lBrMwLS962wAjDkIgg/yO7/ou2bgVGfqJ2XTjt9qWIw9vcw== X-Received: by 2002:a17:907:7d8a:b0:a8d:3fb6:33df with SMTP id a640c23a62f3a-a99678aeeeemr105861866b.8.1728335323487; Mon, 07 Oct 2024 14:08:43 -0700 (PDT) Received: from omar-Latitude-5540.. ([46.232.152.32]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a995350d522sm191822866b.32.2024.10.07.14.08.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2024 14:08:42 -0700 (PDT) From: Omar Bassam To: 72925@debbugs.gnu.org Subject: [PATCH v11] gnu: Add jpm package. Date: Tue, 8 Oct 2024 00:08:37 +0300 Message-ID: <453b1ca8f09ec70707b71557d75dd46ca2299784.1728335255.git.omar.bassam88@gmail.com> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 X-Debbugs-Cc: Guillaume Le Vaillant , Katherine Cox-Buday , Munyoki Kilyungi , Sharlatan Hellseher , jgart Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: Omar Bassam X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/packages/lisp.scm (jpm): New variable. Change-Id: I9f5ab89a38622689b5d3545abe5d87906dc61f3b --- gnu/packages/lisp.scm | 65 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 65 insertions(+) diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm index 6c16d8ab71..04b56ea99b 100644 --- a/gnu/packages/lisp.scm +++ b/gnu/packages/lisp.scm @@ -29,6 +29,7 @@ ;;; Copyright © 2024 Andreas Enge ;;; Copyright © 2024 bigbug ;;; Copyright © 2024 Ashish SHUKLA +;;; Copyright © 2024 Omar Bassam ;;; ;;; This file is part of GNU Guix. ;;; @@ -62,6 +63,7 @@ (define-module (gnu packages lisp) #:use-module (guix build-system gnu) #:use-module (guix build-system haskell) #:use-module (guix build-system trivial) + #:use-module ((guix search-paths) #:select ($SSL_CERT_DIR $SSL_CERT_FILE)) #:use-module (gnu packages admin) #:use-module (gnu packages algebra) #:use-module (gnu packages autotools) @@ -917,6 +919,69 @@ (define-public janet assembler, PEG) is less than 1MB.") (license license:expat))) +(define-public jpm + (package + (name "jpm") + (version "1.1.0") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/janet-lang/jpm") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 "05rdxigmiy7vf93s16a8n2029lq33073jccz1rjl4iisxj6piw4l")))) + (build-system copy-build-system) + (arguments + (list + #:phases #~(modify-phases %standard-phases + (add-after 'unpack 'fix-paths + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "configs/linux_config.janet" + (("/usr/local") + #$output) + (("\"cc\"") + (string-append "\"" + #$gcc "/bin/gcc" "\"")) + (("\"c\\+\\+\"") + (string-append "\"" + #$gcc "/bin/g++" "\"")) + (("\"git\"") + (string-append "\"" + #$git "/bin/git" "\"")) + (("\"curl\"") + (string-append "\"" + #$curl "/bin/curl" "\""))) + (substitute* "jpm/shutil.janet" + (("cp") + (string-append #$coreutils "/bin/cp"))) + (setenv "PREFIX" + #$output))) + (replace 'install + (lambda _ + (for-each (lambda (dir) + (mkdir-p (string-append #$output "/" dir))) + '("lib/janet/jpm" "share/man/man1")) + (invoke "janet" "bootstrap.janet" + "configs/linux_config.janet") + (wrap-program (string-append #$output "/bin/jpm") + `("JANET_HEADERPATH" ":" = + (,(string-append #$janet "/include/janet"))) + `("JANET_LIBPATH" ":" = + (,(string-append #$janet "/lib"))))))))) + (inputs (list bash-minimal)) + (propagated-inputs (list janet)) + (native-search-paths + (list $SSL_CERT_DIR $SSL_CERT_FILE)) + (home-page "https://janet-lang.org/") + (synopsis "Janet Project Manager for the Janet programming language") + (description + "@code{jpm} is the Janet Project Manager tool. It is a build +tool and its main uses are installing dependencies, compiling C/C++ to native +libraries, and other management tasks for Janet projects.") + (license license:expat))) + (define-public lisp-repl-core-dumper (package (name "lisp-repl-core-dumper") base-commit: a873666d3bf716a5ae29275efaa000eaf6d1e2a8 -- 2.45.2 From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 07 17:14:22 2024 Received: (at 72925) by debbugs.gnu.org; 7 Oct 2024 21:14:22 +0000 Received: from localhost ([127.0.0.1]:48572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxv3d-0004jP-JF for submit@debbugs.gnu.org; Mon, 07 Oct 2024 17:14:21 -0400 Received: from mail-ej1-f41.google.com ([209.85.218.41]:42141) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxv3b-0004j9-36 for 72925@debbugs.gnu.org; Mon, 07 Oct 2024 17:14:20 -0400 Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a8a7596b7dfso846144366b.0 for <72925@debbugs.gnu.org>; Mon, 07 Oct 2024 14:14:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728335585; x=1728940385; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=uocr73kivctEdOCZ7dAn+PjTd8Ad8IJTFM8UmjPtwFY=; b=MvgsDLrkT/3e8N/o5USxud0k5qZxqbtRiTneNEXy9MIvSJLiALlkhx2/6PzauADdUN bj5qVGrztxDaM8/hJXFBtSZjrwvzJ9bHjz7vvQWbTR+LQde+/rPs1+Oc4oBPNtc2sSKd 8tyLY9eMdg0VMo1XtTvTobiu+eoL6zxRfJ/7Gp8kQGkRRAfQG40ROTbGzpvPplFsMiTV VvbgYnldWIBCWCYMgqYDAQj4TwR+Ie6/oY7EtTPbC2OIWcpKTYyf8Sneu7bkdOhNJvxJ F7uDBkokJYeQaf/+ticIiM8YGZSzct6UVqPBRPETF81Pu2XiJIO7SQ9Bwk+DqYu2FK7n LRUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728335585; x=1728940385; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uocr73kivctEdOCZ7dAn+PjTd8Ad8IJTFM8UmjPtwFY=; b=lMdJoJT7PC8ryfdhFpSaGDhCSKkrbAl+TKpluGEwRZppuVYwjzHF9e1unRC90UP5OU aOknyJjtInNZbwrWp8SkQzB2mtk3U8w4H4il36cBDao/JOySR2WAKzjkrL94ZseUQRIp 7/uNyklFgDNvPBDEW3zA6BjMPT7nqIYNrBHw653nNVVegf7aFIqBKHp35ovVeG0D+e0j CDxNiXYGV53dBexX+1bGAuLzj5vY/oxR+M5SBScNcLMmkkcVQ0I7PjUj60YgOUBz65GV wS30BCgCyiXJo/UA+oKYeiTwhShxML3QambadnKijxqIyxYVpat0q76lP0/TZ2lHzqT6 kxAQ== X-Forwarded-Encrypted: i=1; AJvYcCXvb8/HRxG0VP5iLXvf5XS7zY8iugnRQpiDxHn+fZjMwIaUwDUlvfClKO62GJy0nXF1JXj9dA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyZvK8cSL0HcmVuMOvnjVEBq7KxguVrsUw8c8KNrfK2qs6MSFuK GihrHul0QdQl0tgDoiNgRfCx3L2TxjuUNhHYvQLTsd9uu4S4rsREAAU1Ebr6 X-Google-Smtp-Source: AGHT+IHeLt2LD7MNxEibTmk1lAuNXauId8oH22DJuvD8abT7M8IVCmRKofJ3jM4QP/+SIVAYWf+pgw== X-Received: by 2002:a17:907:7e8e:b0:a99:5f45:cb69 with SMTP id a640c23a62f3a-a996785ef29mr117790166b.4.1728335584639; Mon, 07 Oct 2024 14:13:04 -0700 (PDT) Received: from omar-Latitude-5540 ([46.232.152.32]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a994ce357b2sm255246866b.144.2024.10.07.14.13.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2024 14:13:04 -0700 (PDT) From: Omar Bassam X-Google-Original-From: Omar Bassam To: Suhail Singh Subject: Re: [PATCH v10] gnu: Add jpm. In-Reply-To: <875xq3k6ue.fsf@gmail.com> (Suhail Singh's message of "Mon, 07 Oct 2024 16:15:21 -0400") References: <6e198e7dc1f64bea3a2b1498fb69e597e4d03360.1728148557.git.suhail@bayesians.ca> <87o73xgyf2.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87msjh5j5f.fsf@gmail.com> <87bjzxgggw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <8734l86h4l.fsf@gmail.com> <871q0rhiu6.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <877cajiw5x.fsf@gmail.com> <87ttdng1u1.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <875xq3k6ue.fsf@gmail.com> Date: Tue, 08 Oct 2024 00:13:03 +0300 Message-ID: <87ed4rfwgw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: 72925@debbugs.gnu.org, Omar Bassam X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi Suhail, I just sent v11 addressing your comments. > Omar Bassam writes: > >>> When gcc-toolchain is excluded from propagated-inputs, and neither gcc >>> nor g++ is in propagated-inputs (i.e., propagated-inputs only contains >>> janet), you *don't* observe a build failure in a _pure_ container where >>> nss-certs is available while evaluating "jpm install -l sh"? >>> >>> If so, please let me know and I shall try and reproduce the error I >>> experienced. >> >> Sorry, I didn't fully explain. I meant that instead of doing this >> module-ref expression to include "gcc-toolchain", I simply included >> "gcc" (which is already imported in lisp.scm) in the propagated-inputs >> and it worked fine (in a pure container) for both the "jpm install" and >> the "jpm build" command. > > That not surprising. As I mentioned in my last: > >>> If not, and you are simply stating that things work by propagating gcc >>> and g++, then we are talking about different things. Specifically, I >>> was considering what would be needed for eliminating gcc and g++ from >>> propagated-inputs. > > And as I mentioned in a still older message: > >>>>>>> What we need is _some_ mechanism to ensure that when jpm invokes gcc (or >>>>>>> g++), the compiler is able to locate the appropriate header files. >>>>>>> >>>>>>> This should be doable without propagating any other inputs. For example >>>>>>> by ensuring that jpm sets appropriate environment variables (such as >>>>>>> $CPATH , $C_INCLUDE_PATH , $CPLUS_INCLUDE_PATH etc.) or flags when >>>>>>> invoking the compiler. If so, that would be the preferred approach. We >>>>>>> only want to propagate those inputs that are strictly necessary. >>>>>>> >>>>>>> ... >>>>>>> >>>>>>> I look forward to seeing what you come up with in v11 :) > > I.e., it's not clear to me that propagating gcc and g++ is necessary. > And if the same can be achieved by passing appropriate environment > variables, why not? Could you please answer? > > Regardless, we are in agreement that the propagation of gcc-toolchain is > not necessary and should be removed. > I've now removed gcc from the propagated-inputs I've tested passing the gcc to jpm using the --cc flag as follows "jpm build --cc=/path/to/gcc". I hope I understood your concern correctly this time. If not, please feel free to add to the patch whatever you think is needed as I'm not a C compiling expert. >> So you think the following would make sense as a sane default for the >> "SSL_CERT_DIR" env variables as an example? >> >> #+begin_src scheme >> (native-search-paths >> (list (search-path-specification >> (variable "SSL_CERT_DIR") >> (files (list "/etc/ssl/certs/"))))) >> #+end_src > > I am quite confused. In the v10 I shared, native-search-paths already > includes $SSL_CERT_DIR, whicb if you look at the source is defined as: > > #+begin_src scheme > (define $SSL_CERT_DIR > (search-path-specification > (variable "SSL_CERT_DIR") > (separator #f) ;single entry > (files '("etc/ssl/certs")))) > #+end_src > > I am no longer sure what problem you are trying to solve. Sorry, I now looked at the code and understand what it's doing. Thanks again, Omar From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 07 20:12:58 2024 Received: (at 72925) by debbugs.gnu.org; 8 Oct 2024 00:12:58 +0000 Received: from localhost ([127.0.0.1]:49511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxxqU-00068g-Fu for submit@debbugs.gnu.org; Mon, 07 Oct 2024 20:12:58 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:54450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxxqS-00068T-Vd for 72925@debbugs.gnu.org; Mon, 07 Oct 2024 20:12:57 -0400 Received: by mail-qt1-f193.google.com with SMTP id d75a77b69052e-4581e7f31eeso44066071cf.0 for <72925@debbugs.gnu.org>; Mon, 07 Oct 2024 17:12:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728346303; x=1728951103; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=pkiEA61EcFMYoZuqwsSoZu3wKXpyBEzuGXrm1ebzAYs=; b=VeB1K6Udy+Z+XUakJBqSElnHJakcuY9eRQNluOSyOIPlzbYMJwCfT0jfEi5Ujvro8k ScyQUJuecO1ytAWZoL5hXd7OzpGHQo7PosmZDsYhs1+JiNO8kMNCKjlo/s3iN5cIHRJR 0Z0WJV1OCpinC976HO+CF4fArFEKnmY1q+aiPAzUu9FlEHLk43GECdS1jmy7jENA9W/O ONX8YbXhZzJMkHarZFxwBv7px7sO3bGVG26a9ieEyxQDm6RhtwrrvHkE//7p0e4jATVe G+8zNi3Ni11y+6yEEYteAALHyqwzA/JvPpCJiHXXg4f6dIyLG2OputMM4F88BwBeem1Z OMvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728346303; x=1728951103; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pkiEA61EcFMYoZuqwsSoZu3wKXpyBEzuGXrm1ebzAYs=; b=FMXij8d8jGMDv2heXypELMzomi1lL+WczzZJrFwfFZSwwnYBG3hzxlFKeCWXSGZFNj 0dEpzLLOqIK6P8p8fOvI1o0CG7ThTo5oFAIEuhSHh9lwUqmRO/YsuacIFFcxY+ZBGx61 hiu9JXeOlCwdU4mchvzgT2+6RdDh9Ihl4CEGKZqJqY3cvk0Hy5xCQTLyQKR7XR4G3xUe tlxNppZKeln8vdXD3EKtXH92/wLgWOcLvyiYKY8J18CppjQADZTCWIxEk+3/7UduzsIK 1F3cnU8DQpjko031PrKW2gdorcqko7eoTfI4+8DvtOJeXyxDFb349MmFWbKfm9N4qLWs uyPw== X-Forwarded-Encrypted: i=1; AJvYcCVReZfeF2BLfrMlj4asZL6XQ394h7eGPMpdPs9csZocE6/Urh0hRZVQYxezn2zNBn5z1Xe1fw==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yzc4kdEJjU8tOUJwim9CMZgewfsWPgLkzVIvbbi1HyjadAl8ggw p2EiXWU9Zy+blwjHI4ixLV6zwOR71xXgHE2qlZwfyZPr3MptncYSCrQTaRiT X-Google-Smtp-Source: AGHT+IGjp+8sO7+tMxIHUL+XKGsLqRDzsoOKmwxafGD3vhhpF4XXlbj+vV5HDn5oaxk8F55JgRJZnw== X-Received: by 2002:ac8:5a47:0:b0:458:4f11:3e15 with SMTP id d75a77b69052e-45d9ba427b9mr200309741cf.5.1728346302959; Mon, 07 Oct 2024 17:11:42 -0700 (PDT) Received: from gnus ([65.94.70.53]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-45da74fac93sm31320261cf.36.2024.10.07.17.11.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2024 17:11:41 -0700 (PDT) From: Suhail Singh To: Omar Bassam Subject: Re: [PATCH v10] gnu: Add jpm. In-Reply-To: <87ed4rfwgw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> (Omar Bassam's message of "Tue, 08 Oct 2024 00:13:03 +0300") References: <6e198e7dc1f64bea3a2b1498fb69e597e4d03360.1728148557.git.suhail@bayesians.ca> <87o73xgyf2.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87msjh5j5f.fsf@gmail.com> <87bjzxgggw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <8734l86h4l.fsf@gmail.com> <871q0rhiu6.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <877cajiw5x.fsf@gmail.com> <87ttdng1u1.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <875xq3k6ue.fsf@gmail.com> <87ed4rfwgw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> Date: Mon, 07 Oct 2024 20:11:30 -0400 Message-ID: <87y12zh2rx.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: 72925@debbugs.gnu.org, Suhail Singh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Omar Bassam writes: >>>>>>>> What we need is _some_ mechanism to ensure that when jpm invokes gcc (or >>>>>>>> g++), the compiler is able to locate the appropriate header files. >>>>>>>> >>>>>>>> This should be doable without propagating any other inputs. For example >>>>>>>> by ensuring that jpm sets appropriate environment variables (such as >>>>>>>> $CPATH , $C_INCLUDE_PATH , $CPLUS_INCLUDE_PATH etc.) or flags when >>>>>>>> invoking the compiler. If so, that would be the preferred approach. We >>>>>>>> only want to propagate those inputs that are strictly necessary. >>>>>>>> >>>>>>>> ... >>>>>>>> >>>>>>>> I look forward to seeing what you come up with in v11 :) >> >> I.e., it's not clear to me that propagating gcc and g++ is necessary. >> And if the same can be achieved by passing appropriate environment >> variables, why not? Could you please answer? >> >> Regardless, we are in agreement that the propagation of gcc-toolchain is >> not necessary and should be removed. >> > > I've now removed gcc from the propagated-inputs I've tested passing the > gcc to jpm using the --cc flag as follows "jpm build --cc=/path/to/gcc". Am I understanding correctly that, with v11 in order for the user to be able to install a Janet package such as "sh", they have to find the location of gcc being used by jpm and pass that to it? If so, why? This is not what I tried to explain above. The jpm package "knows" the specific version of gcc (and g++) that have been patched in, so why does it require the user to take additional action? I.e., the goal, IMHO, should be that in a pure container that contains nss-certs, one is simply able to run "jpm install -l sh" and it works. > I hope I understood your concern correctly this time. I don't believe so. > If not, please feel free to add to the patch whatever you think is > needed as I'm not a C compiling expert. Sorry, but I am no C compiling expert either. In addition, for the past few exchanges, it's not clear that I am able to bring value to the discussion. As evidenced by the recent exchanges, I seem to be struggling with expressing myself effectively. As such, I will step-away from actively reviewing this issue. I hope you are able to get jpm upstreamed with help from jgart and others more experienced than myself. -- Suhail From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 07 20:17:13 2024 Received: (at control) by debbugs.gnu.org; 8 Oct 2024 00:17:13 +0000 Received: from localhost ([127.0.0.1]:49529 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxxub-0006OJ-Gm for submit@debbugs.gnu.org; Mon, 07 Oct 2024 20:17:13 -0400 Received: from mail-qv1-f65.google.com ([209.85.219.65]:61682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxxuZ-0006O4-5b for control@debbugs.gnu.org; Mon, 07 Oct 2024 20:17:11 -0400 Received: by mail-qv1-f65.google.com with SMTP id 6a1803df08f44-6cb97afcec9so35014596d6.2 for ; Mon, 07 Oct 2024 17:17:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728346557; x=1728951357; darn=debbugs.gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=EYS2GdI234wMMX1KUKb9EUIm0MAdERp/eA1HxiotvhM=; b=gvQrorsnbZBzgJwkEi+hQXJn9ApcD3tTBRn2f6PczRZxnTS9C57gFQO08+pack5K7M IeJ+hrknRv31XASp3KEgrTH6DIqoQ6tUbhPhN7XQElr1tOf4D1tIQ/p5Z2G2AjQvnRi2 DyPyg+iSW3n3NSPmTow1nqQ7igcQzxxk6+o0hFzXDi0YOAQzZ3JlRoHJ687jNT2lH7fw XVSMY9todjCwbVqUtO/TRWvCRb0sU+wm45GVfng91X9ZEkum+12xHnqxTbGjg52ZHhjq S4wh5I5VGGwXtA6AsQpxexEFmp9YvikFHhKUrw2eIvOoXKIht6U8zsfKvlT5QzkKaLaE cdIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728346557; x=1728951357; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=EYS2GdI234wMMX1KUKb9EUIm0MAdERp/eA1HxiotvhM=; b=KOXvZuFQg64y13kprQS2i9MZAIBEQO9MfnWCprbvQQDzS4mFQ35fWZkzRrVmJ2IquR /qCFG1Ol893inDf7LefVpb1B2VJ8dahXY26LGTnKEIE/GEmuJ9fDHF+gwv1TBiOaO4am jgvTMSy2uhEHbIo3h8j+teo5XJ6/kmbgGAVvnalE5LfgRR8uwfp9W+TQ3IBIfx2HHZYg IqgwhCIquLOcJ53FOMD3Gk8mV9NHYJ+ElWko6Itfsaih2P5rmC9qWUtZQ04L4U0i/Kz0 bzzliqbrnc89TOhRxleR+4NYaZuJnf8OWgUxcigLPOu7Ex2QzvW9N823l5xqr1FWb7j2 3sJg== X-Gm-Message-State: AOJu0Yz9NPVlMpGjt8sITC3COEL8ryKQyvClgOddvF/kaBfP9VXeLTBH wbIqrao297ePe0GosdzzsSiY/j8pMvFUNpsr/+kF/XW1AKwRE50ine8+Wg9X X-Google-Smtp-Source: AGHT+IGwsat/zv0oaVjn+FgS17CL9XfpeSEdxfHQT1rcc1hO/YagpIjWrXDRoAOFJ52IJO2WsNckLA== X-Received: by 2002:a05:6214:4906:b0:6cb:8267:4a0e with SMTP id 6a1803df08f44-6cb9a0328abmr228881416d6.0.1728346557216; Mon, 07 Oct 2024 17:15:57 -0700 (PDT) Received: from gnus ([65.94.70.53]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6cba47528c9sm30595116d6.89.2024.10.07.17.15.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2024 17:15:56 -0700 (PDT) From: "Suhail Singh" To: control@debbugs.gnu.org Subject: control message for bug #72925 Date: Mon, 07 Oct 2024 20:15:45 -0400 Message-ID: <87v7y3h2ku.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) noowner 72925 user guix usertag 72925 - under-review usertag 72925 + escalated-review-request quit From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 07 23:50:46 2024 Received: (at 72925) by debbugs.gnu.org; 8 Oct 2024 03:50:46 +0000 Received: from localhost ([127.0.0.1]:50054 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sy1FG-0000j9-5C for submit@debbugs.gnu.org; Mon, 07 Oct 2024 23:50:46 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:48466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sy1FD-0000it-Vd for 72925@debbugs.gnu.org; Mon, 07 Oct 2024 23:50:44 -0400 Received: by mail-qt1-f193.google.com with SMTP id d75a77b69052e-4581f44b9b4so36149081cf.1 for <72925@debbugs.gnu.org>; Mon, 07 Oct 2024 20:50:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728359370; x=1728964170; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=2f5UADGo1b2W9oT3taLpE5M2wg6few+yMK/15fsYQW4=; b=Q2peu6mas9RiGRvh+t5O6em0+XtH6tsLA0QFBhr3i1rfiQB4+fhooZy2peagQ0iDwN zgPNR3vUk/tSEeXFem0GJjeyeqvVUUQq+fItschuPxTSXyCM5FZ259L+3HRPyJxBr11q XiZ6Ef+0QWodCWK26OxAp8+obe1Ok4CajhDjV0pReJHWjrgT0DevDQIkJFR/frtxPvmc FTnp/ng7/nBLiouJ4XS2V2KT17sKxNof66p0gpkfCihBMwLTsqzza7nv6DaxYicuc2wt J3CG8tOpS8CnV91Y2eowvtPl99avCaQbGbNCX3pirhZAcwMOJb5Khpn07Gzjs60b/8i8 SoMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728359370; x=1728964170; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2f5UADGo1b2W9oT3taLpE5M2wg6few+yMK/15fsYQW4=; b=kl27KSqpNMVj3jmtd0Lo8dM5O1bqDF0H/FYb6zCPaYb7VYdUlaWNSQ/oz2VVZz71L6 Q9Aqj0KkJvofDDmqkb2Cc9QqTugo8FdG56vT428ah5Qx/cTNCuYUdXJVJYMzar5dG7gL 80ll3NAQk7Hh7vr4Rxa2erpqGGlSo1m+/BYsZIsFTgskMev9FnY2/eBrNfMUIa++NQzN FcmqTAfe2mVx2PPutXeCQH8LjHrTOrub0UFO1Ubm4H0I6rBoBLQK2Nm3+QB/qvNNOCGk trtIug8OA5aUFa8O3+09CvqeGwCMrOSek9NYe/+cHJSxEeocZFSLhKy6omR7K+Z+mCv4 eCTA== X-Forwarded-Encrypted: i=1; AJvYcCVxjeoRWDotN9iVB4i1bgRM8ACj+Iz260NJKoAbjd/+ePGsv+Aq+wKfPmmI4vN+RZkJfixfaw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyRVvlO2t5qno6fCw0zNfCk931KBdmOmVMeT4tM8Sx5Glpv07iE enLA7GZ5pQXZT/4p1U9jUvEBDAkmZbQxHh6VXt3cPniWN4ay+ooJtsTrHxvo X-Google-Smtp-Source: AGHT+IGQNrpo7B9vxiQA8GmDMgzRQYuZiMkvzfNw/sSxOP96HC5GqwdH8PqZpfcNLH2VT/apRMIFbw== X-Received: by 2002:ac8:578d:0:b0:456:45c6:2c30 with SMTP id d75a77b69052e-45d9bb7c434mr209006151cf.53.1728359369741; Mon, 07 Oct 2024 20:49:29 -0700 (PDT) Received: from gnus ([65.94.70.53]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-45da75262fesm32612111cf.40.2024.10.07.20.49.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2024 20:49:29 -0700 (PDT) From: Suhail Singh To: Suhail Singh Subject: Re: [PATCH v10] gnu: Add jpm. In-Reply-To: <87y12zh2rx.fsf@gmail.com> (Suhail Singh's message of "Mon, 07 Oct 2024 20:11:30 -0400") References: <6e198e7dc1f64bea3a2b1498fb69e597e4d03360.1728148557.git.suhail@bayesians.ca> <87o73xgyf2.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87msjh5j5f.fsf@gmail.com> <87bjzxgggw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <8734l86h4l.fsf@gmail.com> <871q0rhiu6.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <877cajiw5x.fsf@gmail.com> <87ttdng1u1.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <875xq3k6ue.fsf@gmail.com> <87ed4rfwgw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87y12zh2rx.fsf@gmail.com> Date: Mon, 07 Oct 2024 23:49:17 -0400 Message-ID: <87r08rgsoy.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: 72925@debbugs.gnu.org, Omar Bassam X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Suhail Singh writes: >> If not, please feel free to add to the patch whatever you think is >> needed as I'm not a C compiling expert. > > Sorry, but I am no C compiling expert either. > > In addition, for the past few exchanges, it's not clear that I am able > to bring value to the discussion. As evidenced by the recent exchanges, > I seem to be struggling with expressing myself effectively. As such, I > will step-away from actively reviewing this issue. Having stepped away as the reviewer, and since I had a few minutes to spare this evening, I decided to go ahead and implement what I had in mind. It was quite straightforward. I'll submit it shortly in the form of a patch series with my changes in a separate patch. That should make it easy to discard or incorporate my proposed changes as desired. > I hope you are able to get jpm upstreamed with help from jgart and > others more experienced than myself. This sentiment still stands, with or without my revisions. -- Suhail From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 08 00:14:29 2024 Received: (at 72925) by debbugs.gnu.org; 8 Oct 2024 04:14:29 +0000 Received: from localhost ([127.0.0.1]:50094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sy1cD-000265-E7 for submit@debbugs.gnu.org; Tue, 08 Oct 2024 00:14:29 -0400 Received: from mail-qv1-f68.google.com ([209.85.219.68]:55402) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sy1cA-00025p-OD for 72925@debbugs.gnu.org; Tue, 08 Oct 2024 00:14:27 -0400 Received: by mail-qv1-f68.google.com with SMTP id 6a1803df08f44-6cb54eef205so47788606d6.2 for <72925@debbugs.gnu.org>; Mon, 07 Oct 2024 21:14:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728360793; x=1728965593; darn=debbugs.gnu.org; h=mime-version:user-agent:date:message-id:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=S7Ar2W4DIEc3ehbsK/TCVXJPbQffZvN7UZwX/Z+CS/g=; b=eSZl3Kkc/riFNPvRsdxxDYtRrdjkmwR/M9Mfdz1ZzWkeXw2okRRFauPkNmTVOmlLRv zby5Huw3IvzbucNlUKHqDuJesmd6ViynvS3TAfW/v+ZYWEDmxRfaeizM+8clAzwKwSBs KwVzwCLl9ylp+mwJuZWrowgq8eMq7e3zFOiMAJ5hBVKEf6vCqPIckxpGjSg8FpWGfFyi FVT7gDzL4ms3lEgq59ZARVrPf9kG/IvDiVZuWonWIHOBchX0LxdRnM0Eca14+OfIxEjy NE79F6gy/eoAc79L4aca13wD37lE79YMbcRai/msMCSy3/62b/lEJKYLZxFYWsHU3N0i Jbqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728360793; x=1728965593; h=mime-version:user-agent:date:message-id:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S7Ar2W4DIEc3ehbsK/TCVXJPbQffZvN7UZwX/Z+CS/g=; b=vBQKywFRZKUUZisrkupOLouCrwogcJBJ6i4H91nMVwGZefQIdpWKucJVJrfsI8bsxp lr/jQKva+zo9v/PBchDiRN2xBMu2b9mNOaQ2cbYdRuxS0LMoGZZCBZrXxNSvZt0mM7OW DBuNhBew++gz4448O/piOQvvon/V51F/zMf5oPvvdxdYy8GHa2H0APyzMJVD3w27uSJq eaSHP0nUTtAYn9zdiSn525KFfhFY52sLqnfJF/XdEKZ/EHkJk0BoX5xF62V/qyFuBswu +5OJm/pSucCEc3HwcfIfE5ZdXMtK9RzsWibu6ncLGI4rz++8FxKXjooQOAxcrVTM7mFe mGrg== X-Gm-Message-State: AOJu0YzsuArpPUEKiPdOAfUaq/1Lr+iPoLnpExKuOMLqMKZaAsx5vqc6 u7IMuYXuYl0Y9o1LuMNU50xKMkmgyoyoe3FQuRzk0CV7tLZMNb5d/agJHhVy X-Google-Smtp-Source: AGHT+IGvoluc0HSr8hZEiJuSrlA26ejxRTro6ezr7YXa4ZRLB4QddO1N0QmCFcvHjpuVHTMopoTa7A== X-Received: by 2002:a05:6214:2c0f:b0:6cb:704b:d27a with SMTP id 6a1803df08f44-6cb9a45c576mr238300616d6.37.1728360792600; Mon, 07 Oct 2024 21:13:12 -0700 (PDT) Received: from gnus ([65.94.70.53]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6cba475efcdsm31966866d6.116.2024.10.07.21.13.12 for <72925@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2024 21:13:12 -0700 (PDT) From: Suhail Singh To: 72925@debbugs.gnu.org Subject: [PATCH v12 0/2] gnu: Add jpm package. Message-ID: X-Debbugs-Cc: Guillaume Le Vaillant , Katherine Cox-Buday , Munyoki Kilyungi , Sharlatan Hellseher , jgart Date: Tue, 08 Oct 2024 00:13:01 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hello Guix, This revision adds some changes to Omar's patch for adding JPM to Guix. Since I am not an experienced Guix user, nor do I frequently deal directly with GCC, it is possible that the revisions I introduce in the second patch are misguided. I request someone with more (relevant) experience to review these and make the determination on whether or not the changes I introduce ought to be accepted as is, modified, or rejected outright. If rejected, please share a summary of the reasons. AFAIU, jpm invokes gcc/g++ in order to compile Janet modules. With my changes, in a pure container with networking enabled and nss-certs available the below commands succeed: - jpm install -l sh - jpm install -l spork Without my changes, the invocation in the first item above (without additional flags being passed by the user) fails due to missing header files (). Regards, Suhail Omar Bassam (1): gnu: Add jpm package. Suhail (1): gnu: Improve user-experience for jpm. gnu/packages/lisp.scm | 82 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 82 insertions(+) base-commit: 73ec844389e91cb0f5a2647070516fc8d19d8730 -- 2.46.1 From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 08 00:15:30 2024 Received: (at 72925) by debbugs.gnu.org; 8 Oct 2024 04:15:30 +0000 Received: from localhost ([127.0.0.1]:50111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sy1dB-0002GK-Q0 for submit@debbugs.gnu.org; Tue, 08 Oct 2024 00:15:30 -0400 Received: from mail-qv1-f66.google.com ([209.85.219.66]:56329) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sy1d9-0002GC-Oy for 72925@debbugs.gnu.org; Tue, 08 Oct 2024 00:15:28 -0400 Received: by mail-qv1-f66.google.com with SMTP id 6a1803df08f44-6cb2f272f8bso46478716d6.0 for <72925@debbugs.gnu.org>; Mon, 07 Oct 2024 21:15:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728360858; x=1728965658; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:date:references :message-id:in-reply-to:subject:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/S+s70+VsfFP7Wg6hI2DCzvoKSPwtBXxpUisA7Z6Q2s=; b=DA/y2H5JyRIPX8+fg9FIkgLUNBs+aFWk9Fl5yOYD8L1Wa9VExI2xcQSSGulO23IfTY e+t1ZuMc2ckwPeR5CoNEUJdRT1/Iuak8nCErxOjCgGXJbU/xbHZ3bSVqtGqNcFoPVgas xTf8yYku2rGBb2vX4xZKf7JoIDE1JHdbIewwsvT+atnGA9cVtw1AU+sy9/7rRCZSNO8w Cj5Ue0LRlLGmG6fj3Z+AkDIRJknO8EFkS6RXdCfiP0irv840dOqhH7SdYUMcJgjJtvZr qwqnLB0TL+1/jv2b3hSwaN9iGj8emqQ6FM9N0VujK8D9bybT6GolYTs5fSTsvbPJJQwq q8bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728360858; x=1728965658; h=content-transfer-encoding:mime-version:user-agent:date:references :message-id:in-reply-to:subject:to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=/S+s70+VsfFP7Wg6hI2DCzvoKSPwtBXxpUisA7Z6Q2s=; b=ivCj8LODzgTN1ofcGxnysP/eFuT+gbBiVwp0Y/ZbUj+YMyz8H+mgB3MWrnn6ukgG/S X8Ow6M0vkXKiJwq9PC9fkOb+/MLzMGi2zh4J/vCQ7UCgk0GaGHpksX4yjvugMeCGmT1m w3ppEkwTt8V2QTWEZtXxsxI0aBc6Feddfxgym1evk1256qs8YJvUsx1ma8GmVWaiO4rk O/UTvHRAsTzi+FC63R77yR1GosMFZFrqjVRaIkoNSQQbIKcR7mVgHX36qihWAGdBvGto IdtgrKjab/XwlHBH78a079ozNkTaG9ZtGNuj7rDcKG5gtUrTU0zyOlgidMuM+tPt0nNo wzgg== X-Gm-Message-State: AOJu0Yz4Ue/YehlOMYqtGzRESYjdYHlBD+3xLrwTj7hAGxERkkl439q5 2+Y1t/GoVhnDQmxnxg1cDLW5LL+HDtLjWZ49psz0hEw/PlKNf/dSb2V6/h0Z X-Google-Smtp-Source: AGHT+IFHjtWYoY2I1qMZuVwmVYYRgh1Kje0HdFQ/z/oWC35rmApcFyjgEkduGcXvzIHE2jYMkkzrqg== X-Received: by 2002:a05:6214:53c9:b0:6cb:3a1f:e47b with SMTP id 6a1803df08f44-6cb9a4ca073mr185076116d6.52.1728360858393; Mon, 07 Oct 2024 21:14:18 -0700 (PDT) Received: from gnus ([65.94.70.53]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6cba47528c9sm32110356d6.89.2024.10.07.21.14.17 for <72925@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2024 21:14:18 -0700 (PDT) From: Suhail Singh To: 72925@debbugs.gnu.org Subject: [PATCH v12 1/2] gnu: Add jpm package. In-Reply-To: Message-ID: References: X-Debbugs-Cc: Guillaume Le Vaillant , Katherine Cox-Buday , Munyoki Kilyungi , Sharlatan Hellseher , jgart Date: Tue, 08 Oct 2024 00:14:06 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/packages/lisp.scm (jpm): New variable. Change-Id: I9f5ab89a38622689b5d3545abe5d87906dc61f3b Signed-off-by: Suhail --- gnu/packages/lisp.scm | 65 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 65 insertions(+) diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm index 6c16d8ab71..04b56ea99b 100644 --- a/gnu/packages/lisp.scm +++ b/gnu/packages/lisp.scm @@ -29,6 +29,7 @@ ;;; Copyright =C2=A9 2024 Andreas Enge ;;; Copyright =C2=A9 2024 bigbug ;;; Copyright =C2=A9 2024 Ashish SHUKLA +;;; Copyright =C2=A9 2024 Omar Bassam ;;; ;;; This file is part of GNU Guix. ;;; @@ -62,6 +63,7 @@ (define-module (gnu packages lisp) #:use-module (guix build-system gnu) #:use-module (guix build-system haskell) #:use-module (guix build-system trivial) + #:use-module ((guix search-paths) #:select ($SSL_CERT_DIR $SSL_CERT_FILE= )) #:use-module (gnu packages admin) #:use-module (gnu packages algebra) #:use-module (gnu packages autotools) @@ -917,6 +919,69 @@ (define-public janet assembler, PEG) is less than 1MB.") (license license:expat))) =20 +(define-public jpm + (package + (name "jpm") + (version "1.1.0") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/janet-lang/jpm") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 "05rdxigmiy7vf93s16a8n2029lq33073jccz1rjl4iisxj6piw4l")))) + (build-system copy-build-system) + (arguments + (list + #:phases #~(modify-phases %standard-phases + (add-after 'unpack 'fix-paths + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "configs/linux_config.janet" + (("/usr/local") + #$output) + (("\"cc\"") + (string-append "\"" + #$gcc "/bin/gcc" "\"")) + (("\"c\\+\\+\"") + (string-append "\"" + #$gcc "/bin/g++" "\"")) + (("\"git\"") + (string-append "\"" + #$git "/bin/git" "\"")) + (("\"curl\"") + (string-append "\"" + #$curl "/bin/curl" "\""))) + (substitute* "jpm/shutil.janet" + (("cp") + (string-append #$coreutils "/bin/cp"))) + (setenv "PREFIX" + #$output))) + (replace 'install + (lambda _ + (for-each (lambda (dir) + (mkdir-p (string-append #$output "/" di= r))) + '("lib/janet/jpm" "share/man/man1")) + (invoke "janet" "bootstrap.janet" + "configs/linux_config.janet") + (wrap-program (string-append #$output "/bin/jpm") + `("JANET_HEADERPATH" ":" =3D + (,(string-append #$janet "/include/janet"))) + `("JANET_LIBPATH" ":" =3D + (,(string-append #$janet "/lib"))))))))) + (inputs (list bash-minimal)) + (propagated-inputs (list janet)) + (native-search-paths + (list $SSL_CERT_DIR $SSL_CERT_FILE)) + (home-page "https://janet-lang.org/") + (synopsis "Janet Project Manager for the Janet programming language") + (description + "@code{jpm} is the Janet Project Manager tool. It is a build +tool and its main uses are installing dependencies, compiling C/C++ to nat= ive +libraries, and other management tasks for Janet projects.") + (license license:expat))) + (define-public lisp-repl-core-dumper (package (name "lisp-repl-core-dumper") --=20 2.46.1 From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 08 00:18:18 2024 Received: (at 72925) by debbugs.gnu.org; 8 Oct 2024 04:18:18 +0000 Received: from localhost ([127.0.0.1]:50119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sy1ft-0002Ld-Ib for submit@debbugs.gnu.org; Tue, 08 Oct 2024 00:18:18 -0400 Received: from mail-qk1-f193.google.com ([209.85.222.193]:50478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sy1fr-0002LU-F5 for 72925@debbugs.gnu.org; Tue, 08 Oct 2024 00:18:16 -0400 Received: by mail-qk1-f193.google.com with SMTP id af79cd13be357-7ae6f8956baso481717185a.1 for <72925@debbugs.gnu.org>; Mon, 07 Oct 2024 21:18:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728361026; x=1728965826; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:date:references :message-id:in-reply-to:subject:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EEhjZWGCH83mFLY6MjMJqK1Omn8ZIAMAqcOFP+FzNvk=; b=cGy9nVInWQn+GpathmeUsb+wL6wbXbbobFdGYckKefrNp1Qr4BWx/pCh2Qv6/+YmQ5 CYQZreBm0pQtqHWDF5/GipY39S+Y0Z3PmuXKFr+IiQvhWsI/t/abMngmCBu6vJ8U4QlW ChAsBAosgcYm7tm2orB8frsOdtLCX7W4JY+M1uhhVptMwp/TAko9rcyLwY5Z2AYEtqz7 hgo+MX3q24sr3TlwdAh8hWBoSjL45Zn5oqGGd+j13VF7s4I5rHUHHddULhy8EraNH0VO 9OTmFCcjgK2mrJVWc+Z1wNcF5HQsm9BNpYvJklFh6TM0vgwOX3OZpx6wYe424IBEKrpU I5rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728361026; x=1728965826; h=content-transfer-encoding:mime-version:user-agent:date:references :message-id:in-reply-to:subject:to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=EEhjZWGCH83mFLY6MjMJqK1Omn8ZIAMAqcOFP+FzNvk=; b=rRjF2XHF+rtTz+C49hul36BPx7JKeSDv6+B5nB9kHRy71KYOP+i+HsCQV1CKuikFwG UScy/fMpSIBygCYiYlrGNtbKb+LXx/dPvpor7lG24bfZRofj+v6q3yOr8VF3Wqq3/ii7 0zZhAVyJef1LZG9LqIZjRgnhP5PJBjyoAvu8o+fcdEawXauLt/mSCQ3ldvn7Lk2K4uo9 yj5aya1PBCkgiTGUSfnWgjAuntdXJ8zpaxey7cFzmiMdAdCjn81lMqplxIZcATy1O/yE ReZ8FlY+ZhcUY0R8UCw5p2XWLJEiCmyUuIj9be/PVLO8GyaL3Drb/4Cy3vj2jaOQg1n/ 89eQ== X-Gm-Message-State: AOJu0YxyJazTmott9/lJ+QsHlBoaTgN33bcZBf+dGCOYFjV3tl5z8YE3 FVjfHULrre3zqALYk9S6zOsK+0WUOUK8AND96ShHP1baPv5CI3u+yJNKkLbw X-Google-Smtp-Source: AGHT+IHr8qMaKGn3mW3rus9cwtQZXO+FGDdMKA3+zOl3DDs1Fb7wjXE9uyw3OaV1PMTK/oWwiuZpXw== X-Received: by 2002:a05:620a:3195:b0:79f:67b:4fdc with SMTP id af79cd13be357-7ae6f42cefemr2663917985a.2.1728361026383; Mon, 07 Oct 2024 21:17:06 -0700 (PDT) Received: from gnus ([65.94.70.53]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-45da74b1eafsm32735311cf.5.2024.10.07.21.17.04 for <72925@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2024 21:17:05 -0700 (PDT) From: Suhail Singh To: 72925@debbugs.gnu.org Subject: [PATCH v12 2/2] gnu: Improve user-experience for jpm. In-Reply-To: Message-ID: <4665e2a478a63cf0bc6b8a18a2fb44687298bbd7.1728359428.git.suhail@bayesians.ca> References: X-Debbugs-Cc: Guillaume Le Vaillant , Katherine Cox-Buday , Munyoki Kilyungi , Sharlatan Hellseher , jgart Date: Tue, 08 Oct 2024 00:16:54 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/packages/lisp.scm (jpm): Ensure jpm respects JANET_HEADERPATH and JANET_LIBPATH if set by user. Ensure gcc/g++ is able to find header files = and compilation-related utilities. Change-Id: Ic7218dbd10e6fabddded50894b82492de8cabc88 --- gnu/packages/lisp.scm | 31 ++++++++++++++++++++++++------- 1 file changed, 24 insertions(+), 7 deletions(-) diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm index 04b56ea99b..4223540913 100644 --- a/gnu/packages/lisp.scm +++ b/gnu/packages/lisp.scm @@ -30,6 +30,7 @@ ;;; Copyright =C2=A9 2024 bigbug ;;; Copyright =C2=A9 2024 Ashish SHUKLA ;;; Copyright =C2=A9 2024 Omar Bassam +;;; Copyright =C2=A9 2024 Suhail Singh ;;; ;;; This file is part of GNU Guix. ;;; @@ -959,18 +960,34 @@ (define-public jpm (setenv "PREFIX" #$output))) (replace 'install - (lambda _ + (lambda* (#:key inputs #:allow-other-keys) (for-each (lambda (dir) (mkdir-p (string-append #$output "/" di= r))) '("lib/janet/jpm" "share/man/man1")) (invoke "janet" "bootstrap.janet" "configs/linux_config.janet") - (wrap-program (string-append #$output "/bin/jpm") - `("JANET_HEADERPATH" ":" =3D - (,(string-append #$janet "/include/janet"))) - `("JANET_LIBPATH" ":" =3D - (,(string-append #$janet "/lib"))))))))) - (inputs (list bash-minimal)) + (let ((gcc-toolchain (assoc-ref inputs "gcc-toolcha= in"))) + (wrap-program (string-append #$output "/bin/jpm") + `("JANET_HEADERPATH" ":" prefix + (,(string-append #$janet "/include/janet"))) + `("JANET_LIBPATH" ":" prefix + (,(string-append #$janet "/lib"))) + `("C_INCLUDE_PATH" ":" prefix + (,(string-append gcc-toolchain "/include"))) + `("CPLUS_INCLUDE_PATH" ":" prefix + (,(string-append gcc-toolchain "/include/c++") + ,(string-append gcc-toolchain "/include"))) + `("LIBRARY_PATH" ":" prefix + (,(string-append gcc-toolchain "/lib") + ,(string-append gcc-toolchain "/lib64"))) + `("PATH" ":" prefix + (,(string-append gcc-toolchain "/bin") + ,(string-append #$coreutils "/bin")))))))))) + (inputs (list bash-minimal + ;; Lazily resolve the gcc-toolchain to avoid a circular + ;; dependency. + (module-ref (resolve-interface '(gnu packages commenceme= nt)) + 'gcc-toolchain))) (propagated-inputs (list janet)) (native-search-paths (list $SSL_CERT_DIR $SSL_CERT_FILE)) --=20 2.46.1 From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 08 04:27:03 2024 Received: (at 72925) by debbugs.gnu.org; 8 Oct 2024 08:27:03 +0000 Received: from localhost ([127.0.0.1]:50816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sy5Yc-0007TI-Rx for submit@debbugs.gnu.org; Tue, 08 Oct 2024 04:27:03 -0400 Received: from mail-wm1-f53.google.com ([209.85.128.53]:47551) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sy5Ya-0007SY-Mw for 72925@debbugs.gnu.org; Tue, 08 Oct 2024 04:27:01 -0400 Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-42cbb08a1a5so54760305e9.3 for <72925@debbugs.gnu.org>; Tue, 08 Oct 2024 01:26:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728375946; x=1728980746; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=eUYxs/CMF/KrnS6mYzrISf244lNTZqh0wbtxWhQmhvw=; b=N2MtuOzkE2e1VkIY7XU4tiwCntfLoHSg2dYrLHWenj8xLLpBF3aZCMFgiUZ5sKVYMJ orRj8+kYrGJ3+RbgkW972TsyzUCRVyiE2WqrgLseW4ZIqfskUI4QiTMKtFn+H8cPEeD5 bPGYu5jcWiwk91c40lQMd+HxkdcCUtX0bglyTNHngS1vUPcGpTZcfFBzdCmZYKh0qprA msShVp0ASM63HMpss64V06SiOGQ78W5z2ioPDM/llIdbWQBMIaDFTq6lDE82xXbMMWe2 hnt2K0rTPgtuzlH1roWV89He464BmbUvOAc71f6IHG7Qn1lPy8dBegE4odwu6ZnnUtNV J68Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728375946; x=1728980746; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eUYxs/CMF/KrnS6mYzrISf244lNTZqh0wbtxWhQmhvw=; b=crKqQ38RtS3eDZ6ut5J6jzP274Qazy5LCfgSMPzJ2fCwasI/qwii0bS/gdz8BBy7Wf h/JQCt6gHYdaQn6BjPq3uFfczNyKlW+UVD4LM869PVjyTuC0LOkmTiYVQOS/SfC/NMD0 LW6VC7AQiNdu/6UAg00AT6bsBSVjmIf5cXA3Qp0AEc6klHbhMeHlbOkCMCtRHBVfe1N4 ECgIG0vtKYfBuFzI2vHorAZvHlY/WEPT8VAFNtW1e9ImD9JS4FPf+zbDSyoVKckDAHRs T7PDIKBjc/Ngdup+9Lc1SAiTMXLIzqxoySYctR3iKLTO8SA2vsegZhUMvMjBRUOzg788 CRMA== X-Forwarded-Encrypted: i=1; AJvYcCUNqVeKLeKFCdkoPIs/+rWQPlhe2E9FYAGMY1VY3htuFNTvEW1eIEzsjO88D8ChkwabfQ0IJw==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yy5PxqOYK5uie5WMUi9Jo3BmA+wPpK0JkFWV8DZYYrORlt1vky1 EET61miEn3704zxdfAkXLfZN5Y3HpMJVouJt1cnM4k5FXYaaGhyJ+JUMeGGw X-Google-Smtp-Source: AGHT+IHm9jeKi/DR2K/XJyCLU789w/HIVFiO66ZKXxQQHZHfGdqLEjF69UxSa60XxBi6r/lzhYw6Bg== X-Received: by 2002:a05:600c:6048:b0:42c:df54:1908 with SMTP id 5b1f17b1804b1-42f85ab7dffmr110987695e9.18.1728375945365; Tue, 08 Oct 2024 01:25:45 -0700 (PDT) Received: from omar-Latitude-5540 ([94.156.217.228]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43054b04a9fsm6343245e9.9.2024.10.08.01.25.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2024 01:25:44 -0700 (PDT) From: Omar Bassam X-Google-Original-From: Omar Bassam To: Suhail Singh Subject: Re: [PATCH v10] gnu: Add jpm. In-Reply-To: <87y12zh2rx.fsf@gmail.com> (Suhail Singh's message of "Mon, 07 Oct 2024 20:11:30 -0400") References: <6e198e7dc1f64bea3a2b1498fb69e597e4d03360.1728148557.git.suhail@bayesians.ca> <87o73xgyf2.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87msjh5j5f.fsf@gmail.com> <87bjzxgggw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <8734l86h4l.fsf@gmail.com> <871q0rhiu6.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <877cajiw5x.fsf@gmail.com> <87ttdng1u1.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <875xq3k6ue.fsf@gmail.com> <87ed4rfwgw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87y12zh2rx.fsf@gmail.com> Date: Tue, 08 Oct 2024 11:25:41 +0300 Message-ID: <87a5fff1bu.fsf@omar-Latitude-5540.mail-host-address-is-not-set> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: 72925@debbugs.gnu.org, Omar Bassam X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Suhail Singh writes: > Omar Bassam writes: > >>>>>>>>> What we need is _some_ mechanism to ensure that when jpm invokes gcc (or >>>>>>>>> g++), the compiler is able to locate the appropriate header files. >>>>>>>>> >>>>>>>>> This should be doable without propagating any other inputs. For example >>>>>>>>> by ensuring that jpm sets appropriate environment variables (such as >>>>>>>>> $CPATH , $C_INCLUDE_PATH , $CPLUS_INCLUDE_PATH etc.) or flags when >>>>>>>>> invoking the compiler. If so, that would be the preferred approach. We >>>>>>>>> only want to propagate those inputs that are strictly necessary. >>>>>>>>> >>>>>>>>> ... >>>>>>>>> >>>>>>>>> I look forward to seeing what you come up with in v11 :) >>> >>> I.e., it's not clear to me that propagating gcc and g++ is necessary. >>> And if the same can be achieved by passing appropriate environment >>> variables, why not? Could you please answer? >>> >>> Regardless, we are in agreement that the propagation of gcc-toolchain is >>> not necessary and should be removed. >>> >> >> I've now removed gcc from the propagated-inputs I've tested passing the >> gcc to jpm using the --cc flag as follows "jpm build --cc=/path/to/gcc". > > Am I understanding correctly that, with v11 in order for the user to be > able to install a Janet package such as "sh", they have to find the > location of gcc being used by jpm and pass that to it? > > If so, why? This is not what I tried to explain above. The jpm package > "knows" the specific version of gcc (and g++) that have been patched in, > so why does it require the user to take additional action? I.e., the > goal, IMHO, should be that in a pure container that contains nss-certs, > one is simply able to run "jpm install -l sh" and it works. > No, the user doesn't need to specify the flag if the gcc package is available in their shell (or pure container shell). I was just testing that you can pass the C flags that you were concerned about from before. I am still not sure if I fully understood your C paths cocern correctly. >> I hope I understood your concern correctly this time. > > I don't believe so. > >> If not, please feel free to add to the patch whatever you think is >> needed as I'm not a C compiling expert. > > Sorry, but I am no C compiling expert either. > > In addition, for the past few exchanges, it's not clear that I am able > to bring value to the discussion. As evidenced by the recent exchanges, > I seem to be struggling with expressing myself effectively. As such, I > will step-away from actively reviewing this issue. > On the contrary, I've learned so much from your comments and I really appreciate your patience. I believe it's my lack of understanding of guix packagin philosophy as this is my first time diving into the source code of Guix. > I hope you are able to get jpm upstreamed with help from jgart and > others more experienced than myself. Thank you, if it ever get upstreamed it will be mostly becuase of your comments, knowledge sharing and patience that I really appreciate. Many Thanks, Omar From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 08 09:41:19 2024 Received: (at 72925) by debbugs.gnu.org; 8 Oct 2024 13:41:19 +0000 Received: from localhost ([127.0.0.1]:51734 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syASl-0007jP-J4 for submit@debbugs.gnu.org; Tue, 08 Oct 2024 09:41:19 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:49472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syASi-0007jF-75 for 72925@debbugs.gnu.org; Tue, 08 Oct 2024 09:41:18 -0400 Received: by mail-ot1-f65.google.com with SMTP id 46e09a7af769-71547c00de3so2994893a34.3 for <72925@debbugs.gnu.org>; Tue, 08 Oct 2024 06:41:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728394806; x=1728999606; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=ruWRjIKCKUeEF8u9YOS10KFGiZbH94d9ZrkCOhGDm+M=; b=CmDEXcRbaHPySbbgs0gSwiwdWZ0QgIPUaQs3l8E+5DrbxIF8dx365a3ODSzHAVxkgr gUNGtMHZLh98be83qorXj0ylwYSypsgfFluoFSqcgtX+LRNRZPQSw/pvOW2mHRXwt68x P4ltn5YylWf/2iDeM357C5WeTymR8bRebPv2fa7YS3+zlp6JgfReLLj6kLCDfTEeOVse a4KSJ/eZ1bbAkGcM/l690DqwierWFrSaWHMZ/txb7jkhh+lfgaqPc1Bv6BQnzsbM4BiO 2gq5dSLiphBmHuZ8/yii69d3H7vvLO9AuN3A0+PycDH7OJRVOaYB9CzpR2zhuUF8oem3 /bAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728394806; x=1728999606; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ruWRjIKCKUeEF8u9YOS10KFGiZbH94d9ZrkCOhGDm+M=; b=Thm+nz9qLmXPT0rGc3J80OE5dMDLf7v46QF+CVgnMSvntw6pM/17yE2ky0B6maMBAC m78S1M6RZ+oAHZR8p5G1XpdO0OefsXOC0Uc7rYQ7PsqDzGojuVpyzRsJbf6dqcJMGNKy dNPop5piDBYt9MhnbiEuaO3Fp+VT6HyM59l/VUrb/Yr5wfI4jtidJYH6M8JQ0eHBoYEy VEzOUU7LVSrERyBBT7pLl7oZzGCacF2Di5jI0RSQshNXAouObZmYmGMeYT4IipoI+kBb m/QLGJC0f7UIzkeHdDray3mPubuMXhHyQOG2Miyuxak+/WBqurwKoQ93TfpTg73XAnb7 +Qhw== X-Forwarded-Encrypted: i=1; AJvYcCX+XbBhfmWfh1OvqyIiuEBZTgntoNNIqcnMdSvob2mC1nnq7HqfExkpIc8ks7PCTiF7dZjYTQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YziBJQTZ6GHWQKhe65vvRJ/moBMZPLHtEgHzGvbM0ALFYcA+9Ev /0k4137znARykh11AsHb2vIqpZAzXQSzrW0E3sG2l9EJBexYTjUhIl/sOpVi X-Google-Smtp-Source: AGHT+IFGgyqSNiSEyXcwoMCJlehvg+lHC1xb71IZAC73mpgidbOhoy8QX/jduxJQgJgpjtC7M+b4Og== X-Received: by 2002:a05:6358:528d:b0:1b8:3b4c:39c2 with SMTP id e5c5f4694b2df-1c2b7fcb874mr595962355d.14.1728394806334; Tue, 08 Oct 2024 06:40:06 -0700 (PDT) Received: from gnus ([65.94.70.53]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6cba46efec2sm35587276d6.74.2024.10.08.06.40.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2024 06:40:05 -0700 (PDT) From: Suhail Singh To: Omar Bassam Subject: Re: [PATCH v10] gnu: Add jpm. In-Reply-To: <87a5fff1bu.fsf@omar-Latitude-5540.mail-host-address-is-not-set> (Omar Bassam's message of "Tue, 08 Oct 2024 11:25:41 +0300") References: <6e198e7dc1f64bea3a2b1498fb69e597e4d03360.1728148557.git.suhail@bayesians.ca> <87o73xgyf2.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87msjh5j5f.fsf@gmail.com> <87bjzxgggw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <8734l86h4l.fsf@gmail.com> <871q0rhiu6.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <877cajiw5x.fsf@gmail.com> <87ttdng1u1.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <875xq3k6ue.fsf@gmail.com> <87ed4rfwgw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87y12zh2rx.fsf@gmail.com> <87a5fff1bu.fsf@omar-Latitude-5540.mail-host-address-is-not-set> Date: Tue, 08 Oct 2024 09:39:54 -0400 Message-ID: <877cai7lxx.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: 72925@debbugs.gnu.org, Suhail Singh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Omar Bassam writes: > ... if the gcc package is available in their shell (or pure container > shell). In v12, the testing container does _not_ need to provide gcc, g++, gcc-toolchain etc. It only needs to provide nss-certs in addition to some usable shell environment. > I am still not sure if I fully understood your C paths cocern correctly. You may see v12 if curious. -- Suhail From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 08 12:34:42 2024 Received: (at 72925) by debbugs.gnu.org; 8 Oct 2024 16:34:42 +0000 Received: from localhost ([127.0.0.1]:54102 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syDAX-0000ZH-Up for submit@debbugs.gnu.org; Tue, 08 Oct 2024 12:34:42 -0400 Received: from mail-ej1-f53.google.com ([209.85.218.53]:50629) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syDAV-0000Z9-BN for 72925@debbugs.gnu.org; Tue, 08 Oct 2024 12:34:40 -0400 Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a9939f20ca0so533625866b.1 for <72925@debbugs.gnu.org>; Tue, 08 Oct 2024 09:34:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728405209; x=1729010009; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=rYygzyc7dLq2DjWLREi3Ghei6CgcKBnIPptHCqIxG6I=; b=B9LANdwP166f4ndEop+orKfCY3/mpHe4jfD7R+AxFd+ZNRWIxg/nlla2quKvUwvLgv hkNjM8a+SM0RH1aIbWIIazvEDwopQS6tkYNtDbVTzxFI0y18TxY+TYrR3/F6dfvMDuDC k2R0vUb1mDAENyLXI+lYNr5TXNoD9Gs7wZ2NNqPMDvbkU+knnI3Y2t0xDjUOCCjjwFSA cRn/7WtIHs6TLwpOccgKB0W7r3eIhy+3Tpy4kcdSJQeM+1c1OUvdT2+TtGAQrkL27vfi DdAzGzJWw+IRXMd7ZvnxgQEuGnmE2Neo/G8Ej5xXL0/zVon19XF79Ivcj335kREExgo1 7qwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728405209; x=1729010009; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rYygzyc7dLq2DjWLREi3Ghei6CgcKBnIPptHCqIxG6I=; b=VwwBb9m7HpTf5taW8NGFpLA2LoQ6WMBubgmk6RAtfgu62bB1Mgr7zAmK6st++dh7dB q0nIl7lqT40CiTbqgTS+ekPWeE8Up2cRzX/zeW/rpKVxHz81NZ+3AHmCXjXpMjnX3HZ+ lxs6TuZPH+rzvauj4ijXjAzjhgb03OlU5HLwEn9RSW9HYosQj/6OiDZj4joa6wfwbb/M eUZjFrbQ2pgvgLldmF1afh5++VssrDoVV54gr9TYwDWYfFI503bnTsWpyNRYQg8fdQY5 3juVQIWy6bJZ4b250fijHizr6S608VVV40RkUIhQHGqiQzh8jmmPwWkXfUM20Qw5dlfp Tiaw== X-Forwarded-Encrypted: i=1; AJvYcCVqYxDVGimpq13FDzodaIA2RqCkyME9P9PpOqUONgKVCcAEItIXeKO6MoRIbT3z8MfGRdwZbg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzBv/nHRk1ALzecQoTM3qmbEEiasCQ8eLfDh6OJ4HzNM7yZhIzc PbYpIENV5u1zH1Tu8TJX8WrMQOhYjHs8hDYVbaIha/PVKk5VcBUvZ0PrbWSm X-Google-Smtp-Source: AGHT+IG6BJVROeCZsciHcYVUtufEdTPzoee1W9myutrs/LSBNE6VPsxpmemLLjFTNXvQILFK9GbNOA== X-Received: by 2002:a17:907:2d8f:b0:a99:85ba:483c with SMTP id a640c23a62f3a-a9985ba4962mr49480166b.59.1728405208319; Tue, 08 Oct 2024 09:33:28 -0700 (PDT) Received: from omar-Latitude-5540 ([46.232.152.58]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a99501a5c0asm321424266b.214.2024.10.08.09.33.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2024 09:33:27 -0700 (PDT) From: Omar Bassam X-Google-Original-From: Omar Bassam To: Suhail Singh Subject: Re: [PATCH v10] gnu: Add jpm. In-Reply-To: <877cai7lxx.fsf@gmail.com> (Suhail Singh's message of "Tue, 08 Oct 2024 09:39:54 -0400") References: <6e198e7dc1f64bea3a2b1498fb69e597e4d03360.1728148557.git.suhail@bayesians.ca> <87o73xgyf2.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87msjh5j5f.fsf@gmail.com> <87bjzxgggw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <8734l86h4l.fsf@gmail.com> <871q0rhiu6.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <877cajiw5x.fsf@gmail.com> <87ttdng1u1.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <875xq3k6ue.fsf@gmail.com> <87ed4rfwgw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87y12zh2rx.fsf@gmail.com> <87a5fff1bu.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <877cai7lxx.fsf@gmail.com> Date: Tue, 08 Oct 2024 19:33:26 +0300 Message-ID: <875xq2ftbd.fsf@omar-Latitude-5540.mail-host-address-is-not-set> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: 72925@debbugs.gnu.org, Omar Bassam X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Suhail Singh writes: > Omar Bassam writes: > >> ... if the gcc package is available in their shell (or pure container >> shell). > > In v12, the testing container does _not_ need to provide gcc, g++, > gcc-toolchain etc. It only needs to provide nss-certs in addition to > some usable shell environment. Can you give me an example of what guix shell commands I need to run to test these. > >> I am still not sure if I fully understood your C paths cocern correctly. > > You may see v12 if curious. For some reason I didn't receive an email for v12. I just saw it on the issues website and I now understand better what you meant from before. It makes much more sense for me now. Thanks, Omar From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 08 18:02:45 2024 Received: (at 72925) by debbugs.gnu.org; 8 Oct 2024 22:02:45 +0000 Received: from localhost ([127.0.0.1]:54760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syII1-00013W-De for submit@debbugs.gnu.org; Tue, 08 Oct 2024 18:02:45 -0400 Received: from mail-qk1-f196.google.com ([209.85.222.196]:54295) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syIHy-00013M-TO for 72925@debbugs.gnu.org; Tue, 08 Oct 2024 18:02:43 -0400 Received: by mail-qk1-f196.google.com with SMTP id af79cd13be357-7afe994d519so17584385a.0 for <72925@debbugs.gnu.org>; Tue, 08 Oct 2024 15:02:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728424893; x=1729029693; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=2C68+/5wuVFkye6PXoVz4s8GLvauHeXrFsupOTDBpaw=; b=M0qDFNCNV+5cT/BtyeOKTIXG4sGZ9rKpuF/yUQ8k/3QmGh2gBwyHjwobJKBDlEYrid Qrq7TBptne8M43WWyNxxbZcdUke76stkS+BRszofveU2M1SdPspkQN7tPcN5j1M4VIdA /ndSBF5BJ6xGKTm3Q1OhS4DbK3Ca5XNwtALeHbgfICbBvuXLFrmx6Dh6UvxFZ4AhLh/F 2ON56Yd5CroAVvO8OHMqLyGL2NBiQotRtHmi6xHQc5LsEZmwMFjWzJ/LnWwjzwlI0sOf q0kUO164H+AisvhqkiRvO+gN54nTEzP5KnCIO8HYkH5wzmos5lIYlRnCfxKEWLAi4Fa3 O+ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728424893; x=1729029693; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2C68+/5wuVFkye6PXoVz4s8GLvauHeXrFsupOTDBpaw=; b=ndr6FaiaSrH1xbKiOWItUJGwAl6DJmB0w3+lvUhB7BMfvrLf+h6Dz0bo5fa2/Zb6HZ 6VcVzAVT5N29qODu7MYri9bS4522QYTMs0+QLPyt6s50vN6RL6rcixC91Jfuk+7sfnod Wg9ViS3zmr/W8iP662nkOqpEHjyqTs3Jx33Qg4uPCXhuOmNZeRfGxf2M7zXXkt9nw7Tj cMLmi1+AnhdvrGDOJEf1sUKBD/9Od/wCV3wcdtUqEbJ1W60u66qsuZf+km+6qIMtXWEC BP2tl0vPfQr9hmKVaO9fjbrYE84dd5giD+0tUAs2unuZws2JLFXie8f9bO71FOGptj8M EtHQ== X-Forwarded-Encrypted: i=1; AJvYcCUOa9JIm3qMhmLL3Qf0cgeGA0V97tO0VoXUogQYWsZXv0hKiDZ0qq+9kvXDBFRJAauy4M4CIw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwDRN32Eeu4IXsw2HDxKQiHthEG1ERy/WFYdDT1/p2cgwpOY0N0 7KtAmkLcXEtXq1huhkqC+uQ+naWVYbVhODlTBuOofEaRi0JvT1w+WEUz4exO X-Google-Smtp-Source: AGHT+IF3+utYVU73hxI+iHpNbRm4xjT9jj+S+0NY9h33CxUO6Y26Txu+caHDuedPPRHPK8WdFWkT5Q== X-Received: by 2002:a05:620a:440b:b0:7a9:cf71:fe4e with SMTP id af79cd13be357-7b0794f4248mr50369285a.33.1728424892419; Tue, 08 Oct 2024 15:01:32 -0700 (PDT) Received: from gnus ([65.94.70.53]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7afcf404084sm35383385a.132.2024.10.08.15.01.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2024 15:01:32 -0700 (PDT) From: Suhail Singh To: Omar Bassam Subject: Re: [PATCH v10] gnu: Add jpm. In-Reply-To: <875xq2ftbd.fsf@omar-Latitude-5540.mail-host-address-is-not-set> (Omar Bassam's message of "Tue, 08 Oct 2024 19:33:26 +0300") References: <6e198e7dc1f64bea3a2b1498fb69e597e4d03360.1728148557.git.suhail@bayesians.ca> <87o73xgyf2.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87msjh5j5f.fsf@gmail.com> <87bjzxgggw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <8734l86h4l.fsf@gmail.com> <871q0rhiu6.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <877cajiw5x.fsf@gmail.com> <87ttdng1u1.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <875xq3k6ue.fsf@gmail.com> <87ed4rfwgw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87y12zh2rx.fsf@gmail.com> <87a5fff1bu.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <877cai7lxx.fsf@gmail.com> <875xq2ftbd.fsf@omar-Latitude-5540.mail-host-address-is-not-set> Date: Tue, 08 Oct 2024 18:01:20 -0400 Message-ID: <87iku245lb.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: 72925@debbugs.gnu.org, Suhail Singh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Omar Bassam writes: > Can you give me an example of what guix shell commands I need to run to > test these. I already have. Given a profile containing only bash, coreutils-minimal, and nss-certs, one can launch an interactive shell via snippet I shared in . Having done so they can navigate to /tmp and test jpm by using it to install packages locally as noted in . I don't understand what's unclear. -- Suhail From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 09 07:59:58 2024 Received: (at 72925) by debbugs.gnu.org; 9 Oct 2024 11:59:59 +0000 Received: from localhost ([127.0.0.1]:55845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syVM9-0002lk-0g for submit@debbugs.gnu.org; Wed, 09 Oct 2024 07:59:58 -0400 Received: from mail-ej1-f52.google.com ([209.85.218.52]:49594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syVM3-0002lQ-Bh for 72925@debbugs.gnu.org; Wed, 09 Oct 2024 07:59:51 -0400 Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-a9941a48ac8so533268166b.3 for <72925@debbugs.gnu.org>; Wed, 09 Oct 2024 04:59:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728475111; x=1729079911; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=abtOWzwj0xmYiPkG0r6YB4XozsvZuVs6+5PUocv5Z7g=; b=RLWpExm6CvNNGqbIsM0Vkq4uSWfg9wkqcAmFHl/lijHxQcAuji+K6huZWEFfj15Um7 x5doFZ5VFUhW5thMz9PWH7SZGb442Q35PWpk4vV+NX8fbQ3w26ImWKzM0fIhzeG3Ge2d BFU8uVJ/84OajwquysylAnblhFsrzf6wx4gL0aGXE0hWthll8cNVSEvVGcgalPopUhiJ P7Pr7DDw52yATtM8repU5hEgY4RorWdJzvFNfkdr23nJj/xOjRND8U4FCsay+j8bao2G +hIoLklkqL7n36DPbpyWY1NIZyDsnzvaAM60qEtTbt7rpEIPxgvtBGjLbGRg9OGRmKrB xmPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728475111; x=1729079911; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=abtOWzwj0xmYiPkG0r6YB4XozsvZuVs6+5PUocv5Z7g=; b=dJJ1ISZkv+1n9TyQI+Ca+9f6MeEwONfWgbijfhKuM2HJBC4OoAT+lauAW2A/Du2Q4l vVTh3mAnV9684tDM5S/IfNsTDaMl14NIVhHsBow5wfWHzbXItqqzev4iQ5T/RLcYgI8j 5hCVsjoSShxZ+98rSHXzM4dcebZGTaNIISzMhUSMHF1aSg3dJmqA4YjZeDdBOYIPahqr lhMzM2dXreEe1B2pUw+rIaZenlpKMmdHw9Q0znUqpgP/+Qtz+tTrHbaW0S1dLe5G3kbr apVt/lbTbloZubfY1i6zpt3biyztt6kSXGXaet5N1Q+T7ASZ/EB27MvED7toXibZNatw NblA== X-Forwarded-Encrypted: i=1; AJvYcCUyEmxrgWgDd03IR/OvA+ULwHQnDt9ncvcxcxTdG4GfLRGPENcxLdIKcnzFQx8HH7uhF/Udrw==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yw2p0fnVLENkmaITmPMjCGxi0SAePBGdzwa56vlz8a0jyVX1hf5 bstm4tzhuYTJlKA+9xogfxzj8+ohOLH8DFwDUeQLFSRTrqI/WYdjv27a4GIw X-Google-Smtp-Source: AGHT+IEGzZ7+SfqqiwmF4ERpOfzHpTIgSKEoR2iIKAw/hWV/Djy//qYD6YMPeul63rMuxUrMZR8yfQ== X-Received: by 2002:a17:907:e89:b0:a99:3f4e:6de8 with SMTP id a640c23a62f3a-a998d3832e7mr186177866b.64.1728475110935; Wed, 09 Oct 2024 04:58:30 -0700 (PDT) Received: from omar-Latitude-5540 ([193.17.229.5]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9955d4bb48sm399608866b.90.2024.10.09.04.58.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2024 04:58:30 -0700 (PDT) From: Omar Bassam X-Google-Original-From: Omar Bassam To: Suhail Singh Subject: Re: [PATCH v10] gnu: Add jpm. In-Reply-To: <87iku245lb.fsf@gmail.com> (Suhail Singh's message of "Tue, 08 Oct 2024 18:01:20 -0400") References: <6e198e7dc1f64bea3a2b1498fb69e597e4d03360.1728148557.git.suhail@bayesians.ca> <87o73xgyf2.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87msjh5j5f.fsf@gmail.com> <87bjzxgggw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <8734l86h4l.fsf@gmail.com> <871q0rhiu6.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <877cajiw5x.fsf@gmail.com> <87ttdng1u1.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <875xq3k6ue.fsf@gmail.com> <87ed4rfwgw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87y12zh2rx.fsf@gmail.com> <87a5fff1bu.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <877cai7lxx.fsf@gmail.com> <875xq2ftbd.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87iku245lb.fsf@gmail.com> Date: Wed, 09 Oct 2024 14:58:26 +0300 Message-ID: <871q0pfpy5.fsf@omar-Latitude-5540.mail-host-address-is-not-set> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: 72925@debbugs.gnu.org, Omar Bassam X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Suhail Singh writes: > Omar Bassam writes: > >> Can you give me an example of what guix shell commands I need to run to >> test these. > > I already have. Yes, sorry I thought you were going to use other commands to test these C*PATH variables. > > Given a profile containing only bash, coreutils-minimal, and nss-certs, > one can launch an interactive shell via snippet I shared in > . Having done so > they can navigate to /tmp and test jpm by using it to install packages > locally as noted in > . > > I don't understand what's unclear. It's clear now, thanks. I've tested v12 and it works without any issues for both the "jpm install" and the "jpm build command". Many Thanks, Omar From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 09 09:13:54 2024 Received: (at 72925) by debbugs.gnu.org; 9 Oct 2024 13:13:54 +0000 Received: from localhost ([127.0.0.1]:55998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syWVm-0006iD-AJ for submit@debbugs.gnu.org; Wed, 09 Oct 2024 09:13:54 -0400 Received: from mail-qk1-f195.google.com ([209.85.222.195]:42423) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syWVk-0006hx-5E for 72925@debbugs.gnu.org; Wed, 09 Oct 2024 09:13:52 -0400 Received: by mail-qk1-f195.google.com with SMTP id af79cd13be357-7afc67e9447so71300485a.1 for <72925@debbugs.gnu.org>; Wed, 09 Oct 2024 06:13:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728479556; x=1729084356; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=jiywCtl3zXT71TRvUmmIrXgN1o+5c/WhldPJp7A1urE=; b=ODepP9S/cmhWoZYvLqDaDzuXC2ry5HtGZ3DPkxyjrvNxYG7CdfSlE0p7Dl5GvAtnac fwb1fmVEMFeu5qvhYKGG2Y4OQidnrZH18cPyzn7jVPNsiri2QeKv5/GgGF34xfo+Pr33 7+XKLBqHiApc10oLhMiMLazh/KU6WqgEqxhmLlxUF0dX07MARKLTcjEyt/XFmbUmLmrT jpEkOIEHU0tPjZa9gHZM19rnGLUHSZi5kbl2/kLGUV0v5PBjBUdNFgvQIJwHao5Ib1vs vXXY2gpm0rqBWPwOj0G3u7KLx7qusGfQD5xw8ZKMKHF2eDNKaQ9uF8KpJHHTIjbSD8EL i2zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728479556; x=1729084356; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jiywCtl3zXT71TRvUmmIrXgN1o+5c/WhldPJp7A1urE=; b=LUX+SZWEAQ1hU6tlDaoD0W2Svn/Zxm070LZNBAR1zj0psJWJhXWYTZktDYoirvSE6a xNydE8abS9/Dw3Tz784gZdZmenVE133Rr3qMrG3Xeaj/YvZx/4hdYE4x9N1IDpwtqLuQ 6ea/ysaIPoJgyTGIrO+sGlazFpTF8Gg7DUezBUVxTP7BV3OofsB5ZMCz3hP1bQsSR0Nz M0fZdw2zBchiQBLMrrsRZIPP7QN8IUEf+L+AV1FxMqAZsvfi030WTf1In/wArvgpu5i+ GD7FRThFIBvMpFROO+VLgrscRlJuXD/xFX5TQP3UNu4wOPIaIO7OtxE/ID5nopvx4ESJ 5t0g== X-Forwarded-Encrypted: i=1; AJvYcCUjlOckjtxc14W1uW8LHqqs9qjay3VKou3qrEUPUZ7ASOBXQtPraofn+9ExzN6CsRopwzPAPQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yz+2dP9Nu3fgUhh1g5/aoTpIjzS5W6/IahD21mbhLTl+q+bSlRr /sQ0HpiGevg1iBlcVlscKpfDuPkouhYXp8HyVZLRuDFsFFC+Liyl4aZjyrRq X-Google-Smtp-Source: AGHT+IEo3om9o4mJ8A8wRKg2B4V20JjHTZYAd4F7vlo3aWJqkG/zG36SQ28oKIB+pwXnzfmX7kTT3Q== X-Received: by 2002:a05:620a:46ab:b0:7a9:a6f5:4912 with SMTP id af79cd13be357-7b006eae7f0mr293551885a.22.1728479556155; Wed, 09 Oct 2024 06:12:36 -0700 (PDT) Received: from gnus (bras-base-mtrlpq0776w-grc-23-65-94-70-53.dsl.bell.ca. [65.94.70.53]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b11067d36bsm22180685a.40.2024.10.09.06.12.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2024 06:12:35 -0700 (PDT) From: Suhail Singh To: Omar Bassam Subject: Re: [PATCH v10] gnu: Add jpm. In-Reply-To: <871q0pfpy5.fsf@omar-Latitude-5540.mail-host-address-is-not-set> (Omar Bassam's message of "Wed, 09 Oct 2024 14:58:26 +0300") References: <6e198e7dc1f64bea3a2b1498fb69e597e4d03360.1728148557.git.suhail@bayesians.ca> <87o73xgyf2.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87msjh5j5f.fsf@gmail.com> <87bjzxgggw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <8734l86h4l.fsf@gmail.com> <871q0rhiu6.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <877cajiw5x.fsf@gmail.com> <87ttdng1u1.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <875xq3k6ue.fsf@gmail.com> <87ed4rfwgw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87y12zh2rx.fsf@gmail.com> <87a5fff1bu.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <877cai7lxx.fsf@gmail.com> <875xq2ftbd.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87iku245lb.fsf@gmail.com> <871q0pfpy5.fsf@omar-Latitude-5540.mail-host-address-is-not-set> Date: Wed, 09 Oct 2024 09:12:34 -0400 Message-ID: <87ttdl773x.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: 72925@debbugs.gnu.org, Suhail Singh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Omar Bassam writes: > Yes, sorry I thought you were going to use other commands to test these > C*PATH variables. No, installation in a pure container with minimal dependencies is the only automated test I've done (given my lack of familiarity with jpm and Janet). However, I did manually inspect the generated jpm script in the store to check that the variables were being set in a reasonable manner. -- Suhail From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 09 12:50:26 2024 Received: (at 72925) by debbugs.gnu.org; 9 Oct 2024 16:50:26 +0000 Received: from localhost ([127.0.0.1]:57485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syZtJ-00025f-PI for submit@debbugs.gnu.org; Wed, 09 Oct 2024 12:50:26 -0400 Received: from mail-pg1-f180.google.com ([209.85.215.180]:60485) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syZtG-00021Y-VH for 72925@debbugs.gnu.org; Wed, 09 Oct 2024 12:50:24 -0400 Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-6bce380eb96so4218825a12.0 for <72925@debbugs.gnu.org>; Wed, 09 Oct 2024 09:50:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728492552; x=1729097352; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=b6Dx8ue7U0KGs4e+pk4vqyI5Gc9bGz/jgznJCkFDlwg=; b=UIBFFUrIrSsehzznXyJQi5SBlh/Xr4QBVlnBde2x80I1RjrVKE4JBooqDtna/mGiJg d5Hu/2qENz1i9QZbTJB6Kuk9Dca/kDxDFv4IFZOzYDbBeKxXTCwMz81T8TXRHsSeBbL/ sjvW26KRiBbyIjDpeYl1izfRUwEUlnZO4BVQBpjsAFfmvDTY20ZHSo2gr/5xyhgiAycD ap9xec8/PlafsicTLEUC0bdcRkrOSGsbSKAuFe4/r6frZQXa+gmEbZmfJBE3CnFBSfqd 2/sZ9o4wWGtYTU16fvLfAUZ2R2qIvWDAUIkCouT8xpP/zIAZySKcIdegWNMDhjkPHX/M zLug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728492552; x=1729097352; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=b6Dx8ue7U0KGs4e+pk4vqyI5Gc9bGz/jgznJCkFDlwg=; b=KCI3WJyaFIehqF3HybbZ+srp9ODsxEMB88pbCopXkxk7UvfPS8S0EghanhcOxv6S0x 9TekbRP5Lzrl5PsVsOi/5h+Re6IeubeNsjAgH6SDQdTzgVYLkPWIvCoiVXje4G7EBSQ9 9L0cp74kmK73jx9fIK5eO+iwOLKEoV0qhVtKNtHA/Q4+qd/75vvn0PuFsdJhf6wlxFQA jsHiqwKbb3S9GBErE66fNMvSa4vCySEpCJytw+K8ROZI48yqxKysVMJQslQVWPgZqVS0 QnMdTX7SBf2+mlESnYukJNqvqh6Kjm9M57ilo4RgcOAxxsPHHuXWRK1pqJtu+icGaSqW 3fHA== X-Gm-Message-State: AOJu0Yy2WZJH+UydcNdmDdUSaT5MTWUewbdIAjkTOoL8kqJJ2LO1uk5A IWPOsQUEozo++i+fdAtNgX6wLZRmMDyNvttA7zCArR7bNj0n6ub/Dv0enBxLMWLqGF8TuPov22N NzVp1y06u78KgI7wjsmJSvagrbCM= X-Google-Smtp-Source: AGHT+IHJlRmbIdesoKIMnA9L/T14DdAaxr7ZULbATs1d3iLMd6nMC1hfXuKE/AMYoYPg1wGzGxWp136kFJ4m134WGlA= X-Received: by 2002:a05:6a21:4d81:b0:1d8:ae07:c06 with SMTP id adf61e73a8af0-1d8ae070e88mr277860637.48.1728492551644; Wed, 09 Oct 2024 09:49:11 -0700 (PDT) MIME-Version: 1.0 References: <6e198e7dc1f64bea3a2b1498fb69e597e4d03360.1728148557.git.suhail@bayesians.ca> <87o73xgyf2.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87msjh5j5f.fsf@gmail.com> <87bjzxgggw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <8734l86h4l.fsf@gmail.com> <871q0rhiu6.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <877cajiw5x.fsf@gmail.com> <87ttdng1u1.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <875xq3k6ue.fsf@gmail.com> <87ed4rfwgw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87y12zh2rx.fsf@gmail.com> <87a5fff1bu.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <877cai7lxx.fsf@gmail.com> <875xq2ftbd.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87iku245lb.fsf@gmail.com> <871q0pfpy5.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87ttdl773x.fsf@gmail.com> In-Reply-To: <87ttdl773x.fsf@gmail.com> From: Omar Bassam Date: Wed, 9 Oct 2024 19:49:00 +0300 Message-ID: Subject: Re: [PATCH v10] gnu: Add jpm. To: Suhail Singh Content-Type: multipart/alternative; boundary="00000000000089af9506240e08e5" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: 72925@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --00000000000089af9506240e08e5 Content-Type: text/plain; charset="UTF-8" That's good to hear. So is this patch now done and ready to be merged? or do we need something else? On Wed, 9 Oct 2024 at 16:12, Suhail Singh wrote: > Omar Bassam writes: > > > Yes, sorry I thought you were going to use other commands to test these > > C*PATH variables. > > No, installation in a pure container with minimal dependencies is the > only automated test I've done (given my lack of familiarity with jpm and > Janet). However, I did manually inspect the generated jpm script in the > store to check that the variables were being set in a reasonable manner. > > -- > Suhail > --00000000000089af9506240e08e5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
That's good to hear.
So is this pa= tch now done and ready to be merged? or do we need something else?

On Wed, 9 Oct 2024 at 16:12, Suhail Singh <suhailsingh247@gmail.com> wrote:
Omar Bassam <omar.bassam88@gmail.com> w= rites:

> Yes, sorry I thought you were going to use other commands to test thes= e
> C*PATH variables.

No, installation in a pure container with minimal dependencies is the
only automated test I've done (given my lack of familiarity with jpm an= d
Janet).=C2=A0 However, I did manually inspect the generated jpm script in t= he
store to check that the variables were being set in a reasonable manner.
--
Suhail
--00000000000089af9506240e08e5-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 09 13:17:18 2024 Received: (at 72925) by debbugs.gnu.org; 9 Oct 2024 17:17:18 +0000 Received: from localhost ([127.0.0.1]:57510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syaJK-0003UR-5s for submit@debbugs.gnu.org; Wed, 09 Oct 2024 13:17:18 -0400 Received: from mail-qv1-f65.google.com ([209.85.219.65]:53694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syaJF-0003U9-RF for 72925@debbugs.gnu.org; Wed, 09 Oct 2024 13:17:16 -0400 Received: by mail-qv1-f65.google.com with SMTP id 6a1803df08f44-6cbc08e7495so637306d6.3 for <72925@debbugs.gnu.org>; Wed, 09 Oct 2024 10:17:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728494157; x=1729098957; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=e5hXRRgE5LCDOSax3nBPfI3ljkByhuB/oKDfEoE34dM=; b=XmJtj5+oehcToxmt8gsouC7S5ibx7bkM5l7y7Gqa0LI8JZ6JnECb8FojQiq/eaNNDi xSdNy9uqnPze6OqiK1E0QW6Iqi9l8/yD9U1JTBsK7QMs/P21LN+64iGwhdlar6UFdprq hXqDbYLs1IDleZY5lppyCbLzlw0EMqnEeyU2i1c44YSEIOc4TIAVEGhZnz9pv5zmhamt JgtL77r/YMCZHmVKMKdSPRh/XJ/vkCQkGtP1vizKKQtRf0sYAk28qbV75rnedH5x6z5U eUp4xFXftZivCUl9DvVGRYhl+crhWrEgd5Rq5S+wC24i8nrcZP59uz08I1xDwOvXflwa muhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728494157; x=1729098957; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=e5hXRRgE5LCDOSax3nBPfI3ljkByhuB/oKDfEoE34dM=; b=ukwYrUMtPfOuGvxv8my/uwo1Qb54cFGZSrnJCf5Q1RT+svlt//0CPgGxGvbzeUarjZ n02cs1ga9jpX/bv+FqXgB3QlSowAII2HnsmqBl1nIBEmu+aqFx+ptM017UK13oO2XAyF WVkRxj88xTG3/8SYWaiyzbhY2GeW9LNL5auM6zPdpM8i+jGRbri+laQuCiNynD0EpSAb UWmhgdI3Dx+85WbwqQGK1JdZl4RJPjidqaRxOaVHpiRYO2HFKw0doANHk7pMI0qjt5EP rWMHfsWyMqGnDFZ2OEjKOKeDj3cBnJvddjRfGk4ua2cVrzX/QZnkVKVVsqNxwmmiC55q 4scA== X-Forwarded-Encrypted: i=1; AJvYcCXHHzkW/c1jgRP6vSkifjEVbJBtGlx70JkFiwVcNDfGuC+ljH08EAxGk5cE/gGVJC/JNXgbUg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxmI8m5TDzGWiR7pTSKIEQ8Rxgn/Szw7OUaFAYoIY5W+xxg+SCJ QmP8Mf0uxRRZDnCdCvCb2+OwTaevMnwwO34uf+BzZ3XYbPZAInG00klZdd4t X-Google-Smtp-Source: AGHT+IFDqBFC4m9DP6l0pXV+KvTOJOkWNYYig6AY60gzcy4MeoHxmPWKoNhdkBHxSEls4vxalx59Mw== X-Received: by 2002:a05:6214:2c02:b0:6cb:c8fd:b15b with SMTP id 6a1803df08f44-6cbc957498cmr39771916d6.25.1728494157311; Wed, 09 Oct 2024 10:15:57 -0700 (PDT) Received: from gnus (bras-base-mtrlpq0776w-grc-23-65-94-70-53.dsl.bell.ca. [65.94.70.53]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6cba4754b04sm47807176d6.78.2024.10.09.10.15.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2024 10:15:56 -0700 (PDT) From: Suhail Singh To: Omar Bassam Subject: Re: [PATCH v10] gnu: Add jpm. In-Reply-To: (Omar Bassam's message of "Wed, 9 Oct 2024 19:49:00 +0300") References: <6e198e7dc1f64bea3a2b1498fb69e597e4d03360.1728148557.git.suhail@bayesians.ca> <87o73xgyf2.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87msjh5j5f.fsf@gmail.com> <87bjzxgggw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <8734l86h4l.fsf@gmail.com> <871q0rhiu6.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <877cajiw5x.fsf@gmail.com> <87ttdng1u1.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <875xq3k6ue.fsf@gmail.com> <87ed4rfwgw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87y12zh2rx.fsf@gmail.com> <87a5fff1bu.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <877cai7lxx.fsf@gmail.com> <875xq2ftbd.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87iku245lb.fsf@gmail.com> <871q0pfpy5.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87ttdl773x.fsf@gmail.com> Date: Wed, 09 Oct 2024 13:15:56 -0400 Message-ID: <87plo96vub.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: 72925@debbugs.gnu.org, Suhail Singh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Omar Bassam writes: > So is this patch now done I have nothing to add other than what I did in v12. I don't know if that means it's "done". > and ready to be merged? That's a question for others more experienced than myself, and probably for someone with commit access. > or do we need something else? See above. -- Suhail From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 11 12:24:54 2024 Received: (at 72925) by debbugs.gnu.org; 11 Oct 2024 16:24:54 +0000 Received: from localhost ([127.0.0.1]:35068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szIRh-0003eG-Rn for submit@debbugs.gnu.org; Fri, 11 Oct 2024 12:24:54 -0400 Received: from mail-pj1-f48.google.com ([209.85.216.48]:48214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szIRf-0003e5-OR for 72925@debbugs.gnu.org; Fri, 11 Oct 2024 12:24:52 -0400 Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-2e2eb9dde40so909156a91.0 for <72925@debbugs.gnu.org>; Fri, 11 Oct 2024 09:24:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728663818; x=1729268618; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=KEi1TffCgHrpjZptgJP+SqIdpF/OWzxclU4hnLDoWYo=; b=lfs4e6S84EsNbjue8JeGqytuAyk1H027APO/mK6l+ahZUH4cXojtXKfj9OiIItUuj2 dCcMKFIGAfE2pSlWWECC7+Xvt7Hh9xeDL6dV75PjTN91IdQBl2usSIeOMX4cOcqdZa2A oB8vIS/RmSCl/0SGEcP7g/Z9NZXxmPwx+SdYPoWc5KOBedllIvX816rAiKsB6+JGGoX6 ViiXDlBd1fahnCMT+a6OYE/qCA2MmLsLZ2lDxbospnhWdKuffcWXiRk312wXoKWcbNLG BrAExxjKNENTMWcI4Bu3hvUxkmi+t1ghyUFtwT3p0CQA4KZ1a5IFX1355o8gF/BE4iKg /KXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728663818; x=1729268618; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KEi1TffCgHrpjZptgJP+SqIdpF/OWzxclU4hnLDoWYo=; b=nGQTIGMAYmb1/HbTnik0DD6zPFhosrsQCQjPfKlV8Nr1UcbtEq3ChqlbdDwzdkqcNM MsBjK2Sjm5KuSJ4OP2GTYGNZiJV/eNQzUtPJi8m/mrzsz1IdMlAe0Qm9b8KFQBQz1Awx u1hG2wvSnAdtr8GpZl0x2EgQucGGm0GDOIfhH6khzIO4DrXWDmyngfaKF249LoNLAulD DThHRl63zR2ZcTSNheCeZCJRuo6boALbulGhJyfd8S+PHa5QMIz4St6kC+248Jq+iYeG oyWloL3s0qVXKBnhVlGTdJFnjeaeE8Pm+RZcuEIKqJrSuHEjexPfGLJqZbLebc7uSfC/ dFVA== X-Gm-Message-State: AOJu0YxhOPLQoJNxDy9TTSMlJGCZS4QCT9kvbL7ef2ak6ihSvmByQpl0 QK8humFehuK/cnNml5dvfCveaRIzy3i4PDUqxjdRkkfTR0t8S+ucIR/KDAPuhWleGNbhRBb+iVt NEmmSvYX2tUzTfNAzopF2qsuLZww= X-Google-Smtp-Source: AGHT+IGb2TD3BVr6OJ6IIKxafNyojVUchf4QkvIDm2nUc60nrNqaHd5E7uihoRJs1gA+8MhoPV1wqDdAs5GWMBiqRnQ= X-Received: by 2002:a17:90a:fa84:b0:2e2:b922:492 with SMTP id 98e67ed59e1d1-2e2f0affa8emr3630827a91.17.1728663817530; Fri, 11 Oct 2024 09:23:37 -0700 (PDT) MIME-Version: 1.0 References: <6e198e7dc1f64bea3a2b1498fb69e597e4d03360.1728148557.git.suhail@bayesians.ca> <87o73xgyf2.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87msjh5j5f.fsf@gmail.com> <87bjzxgggw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <8734l86h4l.fsf@gmail.com> <871q0rhiu6.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <877cajiw5x.fsf@gmail.com> <87ttdng1u1.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <875xq3k6ue.fsf@gmail.com> <87ed4rfwgw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87y12zh2rx.fsf@gmail.com> <87a5fff1bu.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <877cai7lxx.fsf@gmail.com> <875xq2ftbd.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87iku245lb.fsf@gmail.com> <871q0pfpy5.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87ttdl773x.fsf@gmail.com> <87plo96vub.fsf@gmail.com> In-Reply-To: <87plo96vub.fsf@gmail.com> From: Omar Bassam Date: Fri, 11 Oct 2024 19:23:26 +0300 Message-ID: Subject: Re: [PATCH v10] gnu: Add jpm. To: Suhail Singh Content-Type: multipart/alternative; boundary="000000000000c7b655062435e847" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: 72925@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --000000000000c7b655062435e847 Content-Type: text/plain; charset="UTF-8" On Wed, 9 Oct 2024 at 20:15, Suhail Singh wrote: > Omar Bassam writes: > > > So is this patch now done > > I have nothing to add other than what I did in v12. I don't know if > that means it's "done". > > I think so, I've tested different commands with installing and building janet packages and it worked flawlessly. > > and ready to be merged? > > That's a question for others more experienced than myself, and probably > for someone with commit access. > > So, how can we know who we need to contact to ask for a review? > or do we need something else? > > See above. > > -- > Suhail > --000000000000c7b655062435e847 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Wed, 9 Oct 2024 at 20:15, Suhail S= ingh <suhailsingh247@gmail.c= om> wrote:
omar.bassam88@gmail.com> writes:

> So is this patch now done

I have nothing to add other than what I did in v12.=C2=A0 I don't know = if
that means it's "done".


I think so, I've tested different = commands with installing and building janet packages and it worked flawless= ly.
=C2=A0
> and ready to be merged?

That's a question for others more experienced than myself, and probably=
for someone with commit access.

=C2=A0
So, how can we know who we need to c= ontact to ask for a review?

> or do we need something else?

See above.

--
Suhail
--000000000000c7b655062435e847-- From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 11 12:47:15 2024 Received: (at 72925) by debbugs.gnu.org; 11 Oct 2024 16:47:15 +0000 Received: from localhost ([127.0.0.1]:35099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szInL-0004sQ-95 for submit@debbugs.gnu.org; Fri, 11 Oct 2024 12:47:15 -0400 Received: from mail-oa1-f65.google.com ([209.85.160.65]:47253) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szInH-0004rv-3S for 72925@debbugs.gnu.org; Fri, 11 Oct 2024 12:47:11 -0400 Received: by mail-oa1-f65.google.com with SMTP id 586e51a60fabf-27b7a1480bdso894644fac.2 for <72925@debbugs.gnu.org>; Fri, 11 Oct 2024 09:46:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728665151; x=1729269951; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=/8LbOZTVyK3njHefevqoq4ZdxdoppKW9uajHcFA+Eh0=; b=WXDAWJ5Yqt8HVIGZocdTIcXHXHKY1vTPNl4D69z4idTvDyJqJ/H4DoPGbTA/UVOlxY xoE4p+sPmn56hbLfk52eyvOTmfXp3uTFpD/o3QBDXJNMfDjVLTZ6uzQGX8jG3Mb1ih2s wAtQDjSk38egHfT18RX11/01E0AA7tyr/eboTi1Agn1W0Z0vHllTxdZIWlEoNS5WpKbe +4XYlW2bnoNpweOlYcEmG/n3Z96GdewLjZeQYLMLwlhZk6RkukY2IuD7wBD1bUsfE7qs jtzMnnz8HcX8BJ3pmTdCsdmpMYG8GgmyhArbO5qUaQBfGdIRAGc/JsezLgliOnqUCl4i Lllw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728665151; x=1729269951; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/8LbOZTVyK3njHefevqoq4ZdxdoppKW9uajHcFA+Eh0=; b=Xst/h8REoLNRRhJSmMF1JfPJXYHVnj3Soc1FIQj/uibR+rkPdzx43otTFq3R7zoxkL mMeCEIWPFry98FBLiUz9UcM1b3HHhgwKzhh+3Kg2k9c/vsX1hmy0ePTyGCEEvKXwjolz iWsENeU+8CpeDU/3Euxd/rQP9/Cu5eNxd8LlGhg9IBY84rpM+G+dpcI0WBnZWJhAIXUu 4TBXspg+JKqMlQGPeIXDdzDazhuZAgfYUwufC6IOHyFrk/Rd/DjQ6gPRodJrW79bCQKm nMUi32FjBV2dO8GLzn02ct3yzqzPIC0/gedT91cnDm9d7wyBDeO1v5Hiy+pXrhjbCHZs WL4w== X-Forwarded-Encrypted: i=1; AJvYcCWO7vFSuuVGjvsYol6/OspkdGHaO9V0NWqNktFlJuUbmzHjHrT6AaQw//F5TqI7mekGo5Bo3Q==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwUQMIDT8oheQRXoyi7g3Xi8kX/pTkKL+yakm2XNj3SEOnW2+qs 1XlwLezSvmiDA3C5FL7NQFnI8xXmpdFnuz+ON/TDRPUE1DCwQfK93vt/0r9w X-Google-Smtp-Source: AGHT+IGJ5jIX+GLc7rRMBCClglISvTgQU53GoV3KcSG0T8YkbeQMtcqSV1/zV5YE9imWEO1erTy7ow== X-Received: by 2002:a05:6870:6110:b0:288:4313:a3f8 with SMTP id 586e51a60fabf-2886dd5d49amr3179214fac.13.1728665151491; Fri, 11 Oct 2024 09:45:51 -0700 (PDT) Received: from gnus ([70.48.225.6]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b1148e0948sm146438285a.48.2024.10.11.09.45.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Oct 2024 09:45:51 -0700 (PDT) From: Suhail Singh To: Omar Bassam Subject: Re: [PATCH v10] gnu: Add jpm. In-Reply-To: (Omar Bassam's message of "Fri, 11 Oct 2024 19:23:26 +0300") References: <6e198e7dc1f64bea3a2b1498fb69e597e4d03360.1728148557.git.suhail@bayesians.ca> <87o73xgyf2.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87msjh5j5f.fsf@gmail.com> <87bjzxgggw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <8734l86h4l.fsf@gmail.com> <871q0rhiu6.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <877cajiw5x.fsf@gmail.com> <87ttdng1u1.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <875xq3k6ue.fsf@gmail.com> <87ed4rfwgw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87y12zh2rx.fsf@gmail.com> <87a5fff1bu.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <877cai7lxx.fsf@gmail.com> <875xq2ftbd.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87iku245lb.fsf@gmail.com> <871q0pfpy5.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87ttdl773x.fsf@gmail.com> <87plo96vub.fsf@gmail.com> Date: Fri, 11 Oct 2024 12:45:40 -0400 Message-ID: <87r08mlhaj.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: 72925@debbugs.gnu.org, Suhail Singh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Omar Bassam writes: > So, how can we know who we need to contact to ask for a review? See the output of "./etc/teams.scm list-members lisp". If unaware, please see the relevant guideline in the manual [1] to ensure that the relevant team is notified when submitting patches. For what it's worth, the X-Debbugs-Cc header included their addresses when I sent v12, so they should've been notified. [1]: (info "(guix) Teams") -- Suhail From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 12 13:19:04 2024 Received: (at 72925) by debbugs.gnu.org; 12 Oct 2024 17:19:04 +0000 Received: from localhost ([127.0.0.1]:53546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szflg-0005rk-1W for submit@debbugs.gnu.org; Sat, 12 Oct 2024 13:19:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50976) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szfld-0005rF-SN for 72925@debbugs.gnu.org; Sat, 12 Oct 2024 13:19:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1szflI-0007B1-8q; Sat, 12 Oct 2024 13:18:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=kwIzghKNCGJwueo3lzR8UrYLfCBFODp0zjkdsBfETys=; b=axQjXIE7z0/2BFkvDfvr /W7mP+lMfLqz5nfujRdf5KQwlGLiztwuSjIsDmDXrW25CbtC2sGK0IyptbWchE7ngTZH7rOH3gH4M OjqLxNxmY4SBbPr0OnyG2T5hSZlgfa+MU74JcWehcaRfFZXRxAKF13DaCLoztNmyABFkII8EPBist EnYkANQlVY04oTXtMLxDk6/n9RxNZsfi5n9CJWXjtrNul2N4K2ffUTJFHlkEDDTc1v93iFNbV++lS Rs+voH+5eeRoOmicGisTqpHwqg4PHCh4wLgoZIQmM4lDgVmWD/R/5cFjXmt8D+kd0LxXdSNB1wQmN B5EzNiF4VII8hQ==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Suhail Singh Subject: Re: bug#72925: Adding JPM package for Janet In-Reply-To: (Suhail Singh's message of "Tue, 08 Oct 2024 00:14:06 -0400") References: Date: Sat, 12 Oct 2024 19:18:38 +0200 Message-ID: <87plo5s0i9.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72925 Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Munyoki Kilyungi , Katherine Cox-Buday , Guillaume Le Vaillant , jgart X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Suhail Singh skribis: > * gnu/packages/lisp.scm (jpm): New variable. > > Change-Id: I9f5ab89a38622689b5d3545abe5d87906dc61f3b > Signed-off-by: Suhail There=E2=80=99s already been a lot of work and many versions, so I feel bad asking for more changes, but here I am=E2=80=A6 > + (arguments > + (list > + #:phases #~(modify-phases %standard-phases > + (add-after 'unpack 'fix-paths > + (lambda* (#:key inputs #:allow-other-keys) > + (substitute* "configs/linux_config.janet" > + (("/usr/local") > + #$output) > + (("\"cc\"") > + (string-append "\"" > + #$gcc "/bin/gcc" "\"")) > + (("\"c\\+\\+\"") > + (string-append "\"" > + #$gcc "/bin/g++" "\"")) > + (("\"git\"") > + (string-append "\"" > + #$git "/bin/git" "\"")) > + (("\"curl\"") > + (string-append "\"" > + #$curl "/bin/curl" "\""))) > + (substitute* "jpm/shutil.janet" > + (("cp") > + (string-append #$coreutils "/bin/cp"))) Please add =E2=80=98git-minimal/pinned=E2=80=99, =E2=80=98curl=E2=80=99, an= d =E2=80=98coreutils-minimal=E2=80=99 to the =E2=80=98inputs=E2=80=99 field. Then you can fix the stanzas above to thin= gs like: (string-append "\"" (search-input-file inputs "/bin/curl") "\"") Likewise for GCC, but see next message. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 12 13:22:27 2024 Received: (at 72925) by debbugs.gnu.org; 12 Oct 2024 17:22:27 +0000 Received: from localhost ([127.0.0.1]:53559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szfow-000655-Sd for submit@debbugs.gnu.org; Sat, 12 Oct 2024 13:22:27 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szfou-00064q-NC for 72925@debbugs.gnu.org; Sat, 12 Oct 2024 13:22:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1szfoa-0007fs-3m; Sat, 12 Oct 2024 13:22:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=zpMelJjyS4pPUecy3Jly+aBJVEj8Z89rwzLHJfTXIkk=; b=V5dTCEvZ9la2sJ/Bm29z yB77j9e8UH+mCq/bPw0BrRwsgw/Zcp9v3vWqPXbymE0Zj0l1QPts8tMjO7Bhpwu2pWS4iLSUSSBH8 Hfxy1jFM7SMrXsYDlbO5NAIDgPsSeVNi6udJa1W6uOu+KKBmK4izDiwlxtY1pPiOMonvUCzAk2Lzc ap0sI27BGRJIeADj120LPI8UtoWr9Rg3FVdvIp13nuSMY+H5PkaYv0NDvxu/clDD7HS30GOsjuwFO XnVdIm8d7mFF0i4JZBtOwSWFioujSdDhQ3npNP8VW2H1L6FkLi4179/K/I39031RVTOBBUXaj9w8/ xMO/ZW2EGDYJKA==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Suhail Singh Subject: Re: bug#72925: Adding JPM package for Janet In-Reply-To: <4665e2a478a63cf0bc6b8a18a2fb44687298bbd7.1728359428.git.suhail@bayesians.ca> (Suhail Singh's message of "Tue, 08 Oct 2024 00:16:54 -0400") References: <4665e2a478a63cf0bc6b8a18a2fb44687298bbd7.1728359428.git.suhail@bayesians.ca> Date: Sat, 12 Oct 2024 19:22:01 +0200 Message-ID: <87ldyts0cm.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72925 Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Munyoki Kilyungi , Katherine Cox-Buday , Guillaume Le Vaillant , jgart X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Suhail Singh skribis: > * gnu/packages/lisp.scm (jpm): Ensure jpm respects JANET_HEADERPATH and > JANET_LIBPATH if set by user. Ensure gcc/g++ is able to find header file= s and > compilation-related utilities. > > Change-Id: Ic7218dbd10e6fabddded50894b82492de8cabc88 [...] > + (wrap-program (string-append #$output "/bin/jpm= ") > + `("JANET_HEADERPATH" ":" prefix > + (,(string-append #$janet "/include/janet"))) > + `("JANET_LIBPATH" ":" prefix > + (,(string-append #$janet "/lib"))) > + `("C_INCLUDE_PATH" ":" prefix > + (,(string-append gcc-toolchain "/include"))) > + `("CPLUS_INCLUDE_PATH" ":" prefix > + (,(string-append gcc-toolchain "/include/c+= +") > + ,(string-append gcc-toolchain "/include"))) > + `("LIBRARY_PATH" ":" prefix > + (,(string-append gcc-toolchain "/lib") > + ,(string-append gcc-toolchain "/lib64"))) > + `("PATH" ":" prefix > + (,(string-append gcc-toolchain "/bin") > + ,(string-append #$coreutils "/bin"))))))))= )) > + (inputs (list bash-minimal > + ;; Lazily resolve the gcc-toolchain to avoid a circular > + ;; dependency. > + (module-ref (resolve-interface '(gnu packages commence= ment)) > + 'gcc-toolchain))) I suppose JPM shells out to GCC to compiler Janet (or C?) code, right? I=E2=80=99d recommend adding =E2=80=98gcc=E2=80=99, =E2=80=98glibc=E2=80=99= , =E2=80=98binutils=E2=80=99, and =E2=80=98ld-wrapper=E2=80=99 to =E2=80=98inputs=E2=80=99; that=E2=80=99d less us avoid the =E2=80=98gcc-too= lchain=E2=80=99 dance. Then in, the phase above, make sure to =E2=80=98search-input-file=E2=80=99 = rather than direct references to these variables. How does that sound? Alternatively, depending on how important this is for JPM, you could also leave it up to users to install =E2=80=98gcc-toolchain=E2=80=99 alongs= ide JPM when they need it. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 12 16:19:03 2024 Received: (at 72925) by debbugs.gnu.org; 12 Oct 2024 20:19:03 +0000 Received: from localhost ([127.0.0.1]:33036 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sziZq-0000Uy-Nc for submit@debbugs.gnu.org; Sat, 12 Oct 2024 16:19:03 -0400 Received: from mail-qv1-f65.google.com ([209.85.219.65]:58413) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sziZn-0000UC-SS for 72925@debbugs.gnu.org; Sat, 12 Oct 2024 16:19:01 -0400 Received: by mail-qv1-f65.google.com with SMTP id 6a1803df08f44-6c5acb785f2so16780596d6.0 for <72925@debbugs.gnu.org>; Sat, 12 Oct 2024 13:18:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728764260; x=1729369060; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gQxXtaGKuWCgazvI7WXwfUXQ/J7E5OtIHozcgmcX008=; b=TdyeHJSvfuAOOA8O/F0e4K+E3y+qw1bwx6TiKC8XhpwsE8iRbf/YGa7/pTF/VYPmWU YkdA+q9JGbWqVrDWdUCLUDjq15yjnUYzrdLEG7L+vhTXTwuLPgHKXd9f5PcW6h4IO6c5 jzdUgijqrycXAhWTsQrFX7CAtDxtW7NLzfFzwJs8GRFxx24AjUKaiAqJRwmwHS/tz7o8 WPtHD48Yfn0pcmLBrmG+wCGeJDHcA2BrfndmqnUrmNZXbI4BLfUhpTo6r6nqejVQ4g2Q cMb/Ijbcmh+BqKL4aulBS1m+G8b4jM/TfTColRndfrqX+MaAUqHyQ9UtFawrJWYoM4IM ztGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728764260; x=1729369060; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gQxXtaGKuWCgazvI7WXwfUXQ/J7E5OtIHozcgmcX008=; b=mA8eptbLTGkA4pctGQQnnDwhqJPg0nhvAjlutXAXC+EDEzoy6Q72518SHtxC6Qubjt vdfInQlnam6Xyt7EgddGZzqAxFyFnPmOA3f+V7yfl8pmJ4v0to5mBJoxpIsPWmFrGf92 AvnHHNgPimaqXnWipnc1F3+2hhKZIMrBHOk/rMw7PRf1ckPaSHtstqBq+BxF3MumIpih ahWljSThzvPHAS9fLsB2kqz1GDhWhtV4cAUVOtZFOqfRylGaHv3Oq8oqjR2osYCq/VZ6 RBf6U2A4Ippiwm61fL8wSWaS4XnGlGtiNfKsVDJsZPZquZIw5HSbwraPYpQtvz9A/sew yzgg== X-Forwarded-Encrypted: i=1; AJvYcCXEzkSO61rkdq5Q8m7F8GIup2/CaRfbw8tei22N6wx596kVnSwgC0CjTNljym14xQeKcaxo2g==@debbugs.gnu.org X-Gm-Message-State: AOJu0Ywn2SgB3PpgchtT92lc0gSGgrRP8LziL5QwzC7BwL7Rpr74kNp1 Czyeuhje1DKpTXRZ2iXvZu5qjfLpUuP9glexCqaiEXGAb65Dka+g X-Google-Smtp-Source: AGHT+IFqro4iJ/Esj7n4sq2OxrlbgxwdCZtqToOYFABDHRas66D+SCYHDfuxVZIo+GlkZtwz94G7fw== X-Received: by 2002:a05:6214:4a08:b0:6cb:a170:68ec with SMTP id 6a1803df08f44-6cbf0098a15mr125124966d6.33.1728764259636; Sat, 12 Oct 2024 13:17:39 -0700 (PDT) Received: from gnus ([70.48.225.6]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6cbe8635268sm28715686d6.111.2024.10.12.13.17.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Oct 2024 13:17:38 -0700 (PDT) From: Suhail Singh To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#72925: Adding JPM package for Janet In-Reply-To: <87plo5s0i9.fsf_-_@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s?= =?utf-8?Q?=22's?= message of "Sat, 12 Oct 2024 19:18:38 +0200") References: <87plo5s0i9.fsf_-_@gnu.org> Date: Sat, 12 Oct 2024 16:17:27 -0400 Message-ID: <87iktxuld4.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Munyoki Kilyungi , Katherine Cox-Buday , Guillaume Le Vaillant , jgart , Suhail Singh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Ludovic Court=C3=A8s writes: >> + (("\"curl\"") >> + (string-append "\"" >> + #$curl "/bin/curl" "\""))) >> + (substitute* "jpm/shutil.janet" >> + (("cp") >> + (string-append #$coreutils "/bin/cp"))) > > Please add =E2=80=98git-minimal/pinned=E2=80=99, =E2=80=98curl=E2=80=99, = and =E2=80=98coreutils-minimal=E2=80=99 to the > =E2=80=98inputs=E2=80=99 field. Then you can fix the stanzas above to th= ings like: > > (string-append "\"" (search-input-file inputs "/bin/curl") "\"") Happy to make the requested changes. Could you please, however, elaborate on the guiding principle here? I.e., what's the "lesson" here? It seems that the preference is for search-input-file over gexps such as #$curl, but it's not clear what makes it the preferred approach. --=20 Suhail From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 12 16:31:49 2024 Received: (at 72925) by debbugs.gnu.org; 12 Oct 2024 20:31:49 +0000 Received: from localhost ([127.0.0.1]:33761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szimD-0001Py-C0 for submit@debbugs.gnu.org; Sat, 12 Oct 2024 16:31:49 -0400 Received: from mail-oo1-f68.google.com ([209.85.161.68]:44459) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szimB-0001Pg-4D for 72925@debbugs.gnu.org; Sat, 12 Oct 2024 16:31:47 -0400 Received: by mail-oo1-f68.google.com with SMTP id 006d021491bc7-5e800d4e462so1942980eaf.1 for <72925@debbugs.gnu.org>; Sat, 12 Oct 2024 13:31:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728765027; x=1729369827; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nPhOr+L4bU0wd2uFGyf8eWkA1iEgU30QLiGI44JlQNo=; b=g99UoNLcVnECMlrLAobwEKx1q5yHCIT3WKTMfL9HKGNjezif/uMQZACN16PSGrR2Oe c/iBX+D64CJLrX1VQgan88Hgy68Ao/4zOjfylrw4HP0HMatFD3tRMijRx5WfHDKaNAzO hgaoEIvxCItOvQ21U1fTSUQzb3d15qhsw/FZ5idnrRcV+E2es0gFr81l51rLRG7hXJS9 5xurQdq0vKgy/bLlGbvt4a1A4pcpFXt4VMFRXadKNGoGEE5EMwauxuuUBIyR0a/HRMJ7 YxAI5Qz253yE59Rlsv5hH00vsVV+gIdG8OOpMHYH41OtDFch05W+khQ7b4oDQYpovDxN T1Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728765027; x=1729369827; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=nPhOr+L4bU0wd2uFGyf8eWkA1iEgU30QLiGI44JlQNo=; b=cM8+qnQxH2tyQKHPA7ZOzthAP0dPhL2NOOrkwkUTZO4R2+zyhmYlrUyzFlsqYs/14a YjS5Pqfz8an9MzuRezCwT04twNUCKgaSwlRSnSIl8ZhOZt28wqrZ+QqFYekAjK/4193s xMvLvbzYpUs+tVPVVtsfi1AqZSyKvHTrjvnG8Poc3RzY79G/xYtWmuNzqsKqwu1Gvw5B p8OmZGiLfPSi7wsdQjgb4mgkWRdh7axOdiMeVpRyJT93NIoq6rcZhyO/6n0ndHosDonA rKHXXwy8ETHulZiaJG4SEFRYfLYyqIYtQozLSzdf+MoEF2r0Rvdwq9p5w+HfbgcBBjzH e6jw== X-Forwarded-Encrypted: i=1; AJvYcCVQqC4yKRvepM44u+w3OnuvCiCG+IWMWauEChCJtaUYou7kngSni/R3qdNI8W18JKBxeIMlsQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwID3T2uaoG43Ai6Fi89moY6Anb0Wl9lB6ElRgD++cPRiNYAW2Q u66hYoSCH2hkob6hICHnFjInDly7r3CoXksPYzpm5jLiy9nIALy/FPfKdOELpWI= X-Google-Smtp-Source: AGHT+IHXaLe52sop/PGYnS7XTgssic6dXf3AQGMAvYDPodXqDXVo3ahE1fUHBy9egwL7zG4MudjBxg== X-Received: by 2002:a05:6214:2b88:b0:6c5:bc40:9bdb with SMTP id 6a1803df08f44-6cbf00748c6mr96899166d6.22.1728764581814; Sat, 12 Oct 2024 13:23:01 -0700 (PDT) Received: from gnus (bras-base-mtrlpq0776w-grc-11-70-48-225-6.dsl.bell.ca. [70.48.225.6]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6cbe86322a7sm28660276d6.116.2024.10.12.13.22.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Oct 2024 13:23:00 -0700 (PDT) From: Suhail Singh To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#72925: Adding JPM package for Janet In-Reply-To: <87ldyts0cm.fsf_-_@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s?= =?utf-8?Q?=22's?= message of "Sat, 12 Oct 2024 19:22:01 +0200") References: <4665e2a478a63cf0bc6b8a18a2fb44687298bbd7.1728359428.git.suhail@bayesians.ca> <87ldyts0cm.fsf_-_@gnu.org> Date: Sat, 12 Oct 2024 16:22:59 -0400 Message-ID: <87ed4lul3w.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Munyoki Kilyungi , Katherine Cox-Buday , Guillaume Le Vaillant , jgart , Suhail Singh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Ludovic Court=C3=A8s writes: > I suppose JPM shells out to GCC to compiler Janet (or C?) code, right? Yes. > I=E2=80=99d recommend adding =E2=80=98gcc=E2=80=99, =E2=80=98glibc=E2=80= =99, =E2=80=98binutils=E2=80=99, and =E2=80=98ld-wrapper=E2=80=99 to > =E2=80=98inputs=E2=80=99; that=E2=80=99d less us avoid the =E2=80=98gcc-t= oolchain=E2=80=99 dance. > > Then in, the phase above, make sure to =E2=80=98search-input-file=E2=80= =99 rather than > direct references to these variables. > > How does that sound? Sounds good. > Alternatively, depending on how important this is for JPM, you could > also leave it up to users to install =E2=80=98gcc-toolchain=E2=80=99 alon= gside JPM when > they need it. It's a pretty essential dependency for JPM, so adding gcc, glibc etc to inputs would be preferable. I'll submit v13 shortly. I look forward to your elaboration on why direct references aren't preferable. Thank you for taking the time to review. --=20 Suhail From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 12 17:16:15 2024 Received: (at 72925) by debbugs.gnu.org; 12 Oct 2024 21:16:15 +0000 Received: from localhost ([127.0.0.1]:35761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szjTC-0004Qp-Gd for submit@debbugs.gnu.org; Sat, 12 Oct 2024 17:16:15 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:49564) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szjTA-0004QN-TN for 72925@debbugs.gnu.org; Sat, 12 Oct 2024 17:16:13 -0400 Received: by mail-qt1-f195.google.com with SMTP id d75a77b69052e-45f091bf433so26253521cf.3 for <72925@debbugs.gnu.org>; Sat, 12 Oct 2024 14:15:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728767692; x=1729372492; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5lfiJ8E4Gcbjs2+C1xTJO43V+1JstI09kJC+GjMx/fI=; b=F2bKtj9/YLAQ7pGlPC0j9js1qVMZDXdFWDovf5ve2VsAsJ0/x8CIGaBTkqug+rHiHc kyWb85GTsSKgMf/ZnDxcT0deQhk/Y7Nib8IikgarhOTIdPmQ0rWDtJgpB8PkK73xQq7f lnaLe3WcM95rmW0OcbXT4K5JM2jvAVC0HA4GQlBKBJfpiaEjhkL40xqqk0p7d+Gv3UtH eEilbX7ce8rjg8c4IvVnoOnGbG086hO8Qy6NpOOV60Ix8BraYkbbjc2OVTO5q2SvXGeW gAOJrZ8yPHsuujJ+nQISzzRppw3ON6HICsE8plc+bijC0X4hFcksjJyjKu0gd1xcWazb LJNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728767692; x=1729372492; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5lfiJ8E4Gcbjs2+C1xTJO43V+1JstI09kJC+GjMx/fI=; b=efOZIqr45hoSNIx2RI8TPOwELSknyiHmPvcBoWurr/j1+b++SMKob/FiHRTXCPy21Y /aUyCiV4EBM5FYuShuB+0b68XHDr+AVtoZPNUMiH6pSh+fdbKBVLwctDYMGa/6evwFje b/LDFzIgmiWqRfFZyqv8mWZpqtMiOA/dSRlrELsG7WtOIQj21gnTS738tJgH8vCoLsun Di+uoBst19caRqejWZNgdbVkjrW4nsq204EUBH9eB5fkfrj2M2VufwknqN26MdUjT4HD jCZ1ae46vDdvUtmmGcBrCzi15ZUTLINfHCBvE+EZGQIUpmGrQePFuaf0bm16MjEQ3tN6 oKKA== X-Forwarded-Encrypted: i=1; AJvYcCXomt3l41HnM2tFKXl/3dWVyiAHFKil/Y2VglVDTK+HDQG57QQ6IQSDhNhiFcd4q3JvomfUsw==@debbugs.gnu.org X-Gm-Message-State: AOJu0Ywfu00TvpXG5ohEKQvqleSfiHueBrf3+WzmrDG2HJ/5Odz4B2Q1 leoxYVRenzGClYxQhOAtPfUVbjYq1xZDnVF1IG64qjQ0XfhqlPmM X-Google-Smtp-Source: AGHT+IFJCyFqZStmkEpJ/Euy0tmqWIB1XU2t1k1bxemjip19+RkZvsSwbiH+iexGd4A6YDlbT8VK6A== X-Received: by 2002:a05:6214:468a:b0:6cb:fff6:8f31 with SMTP id 6a1803df08f44-6cbfff6932emr46330796d6.47.1728767692539; Sat, 12 Oct 2024 14:14:52 -0700 (PDT) Received: from gnus (bras-base-mtrlpq0776w-grc-11-70-48-225-6.dsl.bell.ca. [70.48.225.6]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6cbe85a5d75sm29009466d6.20.2024.10.12.14.14.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Oct 2024 14:14:51 -0700 (PDT) From: Suhail Singh To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#72925: Adding JPM package for Janet In-Reply-To: <87ldyts0cm.fsf_-_@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s?= =?utf-8?Q?=22's?= message of "Sat, 12 Oct 2024 19:22:01 +0200") References: <4665e2a478a63cf0bc6b8a18a2fb44687298bbd7.1728359428.git.suhail@bayesians.ca> <87ldyts0cm.fsf_-_@gnu.org> Date: Sat, 12 Oct 2024 17:14:49 -0400 Message-ID: <875xpxuipi.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Munyoki Kilyungi , Katherine Cox-Buday , Guillaume Le Vaillant , jgart , Suhail Singh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Ludovic Court=C3=A8s writes: >> + (wrap-program (string-append #$output "/bin/jp= m") >> + `("JANET_HEADERPATH" ":" prefix >> + (,(string-append #$janet "/include/janet")= )) >> + `("JANET_LIBPATH" ":" prefix >> + (,(string-append #$janet "/lib"))) >> + `("C_INCLUDE_PATH" ":" prefix >> + (,(string-append gcc-toolchain "/include")= )) >> + `("CPLUS_INCLUDE_PATH" ":" prefix >> + (,(string-append gcc-toolchain "/include/c= ++") >> + ,(string-append gcc-toolchain "/include")= )) >> + `("LIBRARY_PATH" ":" prefix >> + (,(string-append gcc-toolchain "/lib") >> + ,(string-append gcc-toolchain "/lib64"))) >> + `("PATH" ":" prefix >> + (,(string-append gcc-toolchain "/bin") >> + ,(string-append #$coreutils "/bin")))))))= ))) >> + (inputs (list bash-minimal >> + ;; Lazily resolve the gcc-toolchain to avoid a circul= ar >> + ;; dependency. >> + (module-ref (resolve-interface '(gnu packages commenc= ement)) >> + 'gcc-toolchain))) > > I suppose JPM shells out to GCC to compiler Janet (or C?) code, right? > > I=E2=80=99d recommend adding =E2=80=98gcc=E2=80=99, =E2=80=98glibc=E2=80= =99, =E2=80=98binutils=E2=80=99, and =E2=80=98ld-wrapper=E2=80=99 to > =E2=80=98inputs=E2=80=99; that=E2=80=99d less us avoid the =E2=80=98gcc-t= oolchain=E2=80=99 dance. It seems "ld-wrapper" requires (gnu packages commencement) and this results in doing the lazy dereference similar to gcc-toolchain above. Am I doing something wrong? If not, is the guidance still to add "ld-wrapper" to inputs? > Then in, the phase above, make sure to =E2=80=98search-input-file=E2=80= =99 rather than > direct references to these variables. Hmm just to be clear, instead of: #+begin_src scheme `("C_INCLUDE_PATH" ":" prefix (,(string-append gcc-toolchain "/include"))) #+end_src What we want is something like: #+begin_src scheme `("C_INCLUDE_PATH" ":" prefix (,(search-input-file inputs "/include"))) #+end_src Is my understanding correct? If so, adding "gcc", "glibc", "binutils", and "ld-wrapper" seems insufficient to make that work. The search-input-file for "/include" results in a "&search-error" when building the package. --=20 Suhail From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 14 13:26:46 2024 Received: (at 72925) by debbugs.gnu.org; 14 Oct 2024 17:26:46 +0000 Received: from localhost ([127.0.0.1]:43242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t0OqD-0003BP-Qb for submit@debbugs.gnu.org; Mon, 14 Oct 2024 13:26:46 -0400 Received: from mail-qk1-f195.google.com ([209.85.222.195]:42238) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t0OqC-0003B3-BC for 72925@debbugs.gnu.org; Mon, 14 Oct 2024 13:26:45 -0400 Received: by mail-qk1-f195.google.com with SMTP id af79cd13be357-7ac83a98e5eso385645185a.0 for <72925@debbugs.gnu.org>; Mon, 14 Oct 2024 10:26:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728926721; x=1729531521; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:date:references :message-id:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sOfougrq5EhDMU0vn0kiGeEj1JcJh4gGmDwNUaW2Hhk=; b=CB/NUsymCYQ2zYsGpY2/EsW+nwiD5+RmpiWhtyr6nesexxhjMHGdIkgoEMFP0oZw5I YISbT9YbFhx1XrO8zc5LUIrLJxfoU+B8uF5L/wM+SQXoA5b3eCUsgXGTvVCKJiS2p2zV V6LUrJEjpr8ndWMl3MHY+3+RBj0Cwsx8Wl2KVZ4Z/3umy3fiS/b851CDmwi6Rl1qJRZN PipnrtYo335r+LD2tDf5/GKbIA8+WsPxfF7+lL1f46Zu3VP0kABUkqzfXCG7JOZKLXGu dBqVooeoMc8GhwLWOHzUPbYq9myVo2vF8HpM8AUIE512T8E84F6tuxAEgUcwKJHSXF0k QFow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728926721; x=1729531521; h=content-transfer-encoding:mime-version:user-agent:date:references :message-id:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=sOfougrq5EhDMU0vn0kiGeEj1JcJh4gGmDwNUaW2Hhk=; b=ttThCOILP7bZ2YUsRNMCRBkmLVLXkkVo/94pd2xK0W19ywbIj7pq5OENfzmMDSRhHN IdJK+obmb4TzAXNd73WTKomLPlEB2jnKs1A2a0Y+J03vva0F6u03wVu+fAp7XOGAkKMb x9WfzbnXKfGUBWR+Qp8zPjA59X32Pb9yuLAlAE8NQeSVZxzDvs64J+i8F0mr49gbpE1X ycRs6W0c3K5CixhuI/s0YBxtAnuPQ/Xxql73lNiV1Xp/W1JaE4AWor0/bsmOIVHMpXb3 DNjuJifo6VXM6Sa1znl8RqceseFsrM1JTKTsaUTeog65UDhU6KikBU2m5p7meHyXGwLs Yzgw== X-Gm-Message-State: AOJu0Yx1S4eLYrW/QGIAwLYM0SMzwx7TGgCse6wr+4vE7eS1EDXjsQw7 W9v1bKroujnH159x5zVq12PM47UBZANx9sHSs3LDUkiKQZ9exS0rJMFQ1mpb X-Google-Smtp-Source: AGHT+IFGpS99X6pXtIeXzwoHZYSXZ5MGnjSx3lo8/Ar9OKWNcJ3cqoyJfAepZb6tFcxJWp3bW9XUIw== X-Received: by 2002:a05:620a:394d:b0:7a9:bbb8:e8b4 with SMTP id af79cd13be357-7b112535c13mr2426793285a.30.1728926721079; Mon, 14 Oct 2024 10:25:21 -0700 (PDT) Received: from gnus (bas6-montrealak-70-48-225-6.dsl.bell.ca. [70.48.225.6]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b114956069sm438048385a.74.2024.10.14.10.25.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Oct 2024 10:25:20 -0700 (PDT) From: Suhail Singh To: 72925@debbugs.gnu.org Subject: [PATCH v13 1/2] gnu: Add jpm package. In-Reply-To: Message-ID: <9936b453a5f36ad3addca7e4d5dae36a97a855d9.1728925129.git.suhail@bayesians.ca> References: X-Debbugs-Cc: Guillaume Le Vaillant , Katherine Cox-Buday , Munyoki Kilyungi , Sharlatan Hellseher , jgart Date: Mon, 14 Oct 2024 13:25:20 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , Omar Bassam X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/packages/lisp.scm (jpm): New variable. Change-Id: I9f5ab89a38622689b5d3545abe5d87906dc61f3b Signed-off-by: Suhail --- gnu/packages/lisp.scm | 73 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 73 insertions(+) diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm index 6c16d8ab71..7b557fc493 100644 --- a/gnu/packages/lisp.scm +++ b/gnu/packages/lisp.scm @@ -29,6 +29,7 @@ ;;; Copyright =C2=A9 2024 Andreas Enge ;;; Copyright =C2=A9 2024 bigbug ;;; Copyright =C2=A9 2024 Ashish SHUKLA +;;; Copyright =C2=A9 2024 Omar Bassam ;;; ;;; This file is part of GNU Guix. ;;; @@ -62,6 +63,7 @@ (define-module (gnu packages lisp) #:use-module (guix build-system gnu) #:use-module (guix build-system haskell) #:use-module (guix build-system trivial) + #:use-module ((guix search-paths) #:select ($SSL_CERT_DIR $SSL_CERT_FILE= )) #:use-module (gnu packages admin) #:use-module (gnu packages algebra) #:use-module (gnu packages autotools) @@ -917,6 +919,77 @@ (define-public janet assembler, PEG) is less than 1MB.") (license license:expat))) =20 +(define-public jpm + (package + (name "jpm") + (version "1.1.0") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/janet-lang/jpm") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 "05rdxigmiy7vf93s16a8n2029lq33073jccz1rjl4iisxj6piw4l")))) + (build-system copy-build-system) + (arguments + (list + #:phases #~(modify-phases %standard-phases + (add-after 'unpack 'fix-paths + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "configs/linux_config.janet" + (("/usr/local") + #$output) + (("\"cc\"") + (string-append "\"" + (search-input-file inputs "/bin/g= cc") + "\"")) + (("\"c\\+\\+\"") + (string-append "\"" + (search-input-file inputs "/bin/g= ++") + "\"")) + (("\"git\"") + (string-append "\"" + (search-input-file inputs "/bin/g= it") + "\"")) + (("\"curl\"") + (string-append "\"" + (search-input-file inputs "/bin/c= url") + "\""))) + (substitute* "jpm/shutil.janet" + (("cp") + (string-append (search-input-file inputs "/bin/c= p")))) + (setenv "PREFIX" + #$output))) + (replace 'install + (lambda _ + (for-each (lambda (dir) + (mkdir-p (string-append #$output "/" di= r))) + '("lib/janet/jpm" "share/man/man1")) + (invoke "janet" "bootstrap.janet" + "configs/linux_config.janet") + (wrap-program (string-append #$output "/bin/jpm") + `("JANET_HEADERPATH" ":" =3D + (,(string-append #$janet "/include/janet"))) + `("JANET_LIBPATH" ":" =3D + (,(string-append #$janet "/lib"))))))))) + (inputs (list bash-minimal + coreutils-minimal + curl + gcc + git-minimal/pinned)) + (propagated-inputs (list janet)) + (native-search-paths + (list $SSL_CERT_DIR $SSL_CERT_FILE)) + (home-page "https://janet-lang.org/") + (synopsis "Janet Project Manager for the Janet programming language") + (description + "@code{jpm} is the Janet Project Manager tool. It is a build +tool and its main uses are installing dependencies, compiling C/C++ to nat= ive +libraries, and other management tasks for Janet projects.") + (license license:expat))) + (define-public lisp-repl-core-dumper (package (name "lisp-repl-core-dumper") --=20 2.47.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 14 13:28:06 2024 Received: (at 72925) by debbugs.gnu.org; 14 Oct 2024 17:28:06 +0000 Received: from localhost ([127.0.0.1]:43271 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t0OrV-0003Fg-Fc for submit@debbugs.gnu.org; Mon, 14 Oct 2024 13:28:06 -0400 Received: from mail-vk1-f194.google.com ([209.85.221.194]:54582) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t0OrT-0003FV-9E for 72925@debbugs.gnu.org; Mon, 14 Oct 2024 13:28:03 -0400 Received: by mail-vk1-f194.google.com with SMTP id 71dfb90a1353d-50d4a333a87so448041e0c.1 for <72925@debbugs.gnu.org>; Mon, 14 Oct 2024 10:27:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728926805; x=1729531605; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:date:references :message-id:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=70RyHG51SfPE1Mps5b2/NMHA54ndvxy6ii1PqbwN6/s=; b=neKfgXCBPsuxBQKMqg9xpDT/EbjOT5lYGhiwOF6cuoCufntY8AqyL31U2v13E9eeCy qC1uxp8TlXLGRGRbCuVo107UfN1HXqx2E/fcA7oRgSE5+hpu0QIZTfDNQU8BR6CmQ4Se 0vSeOmKgoGXaZthhhUfUlXv+qQab5HtQ70fIsCzXdBqb9uNY+JmZe9dbGnQrdwLp702A mE1KY0thE+COtruOSMKtELCGDkoArlmUELUClCZmDn2KONxXzCkPwiF6LbpCiJirBcmH sGg2tpPYUAHnJ/gAsrkpvqQ+TxE2ZKL2EkIEQH6z/aSrMwf3oD5tT9SBKHUoglmbIZeq k95w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728926805; x=1729531605; h=content-transfer-encoding:mime-version:user-agent:date:references :message-id:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=70RyHG51SfPE1Mps5b2/NMHA54ndvxy6ii1PqbwN6/s=; b=OwYrm4ZyP/H3oa15mIZVR6JaIsRQvtwYCzXrdG9jt486d8J76J67IkvhXaH6O5914A bb2sY8HlTIrGaVbK6cE4eHDJNHwudDgRHSez4yxRj1xrXowTCbtEJQcz7/dErtvyKqPt +a9pLYR9vxzsovJxQnSq9jaxX3e9mnyToIHwVO7wrgHCeoMnlU0VedyGyUW98Zqp9xI1 A65gM36xSuKyaqBUMZy1AutpH+O3LSb/ng7za6NYGU70Eh5SpGM246PWINvnXGoI1lSX GWiX2EYNnc30NZoBv7qQJ0tPYeGYH7UWOIYZLiz8Dc4JsmpFZpOkx+IIQ7Bh7nh9fYmF vFXg== X-Gm-Message-State: AOJu0YwS+zxWrTFLxKQvuahBi5HRGvN28I7f+IapSbQPn7ur+z1fyrqM 418BSZ3batWCK02Mrwb0UlLG6MuIXVmOCmVvzHEewDCO6GuX+H8S X-Google-Smtp-Source: AGHT+IHXJ4UYx349h0v7vELzyIkuJ438dPkrwnRVNS6VEqhCTjiD5qak9oomcGxTXpH69E1UqZs0zQ== X-Received: by 2002:a05:6122:659a:b0:50a:ca69:2b76 with SMTP id 71dfb90a1353d-50d3736ffb1mr4304112e0c.0.1728926805416; Mon, 14 Oct 2024 10:26:45 -0700 (PDT) Received: from gnus ([70.48.225.6]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6cbe85a5906sm47670306d6.9.2024.10.14.10.26.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Oct 2024 10:26:45 -0700 (PDT) From: Suhail Singh To: 72925@debbugs.gnu.org Subject: [PATCH v13 2/2] gnu: Improve user-experience for jpm. In-Reply-To: Message-ID: <3cbf3de67871ab5aa7771d146e4dcdcef1a3e880.1728925129.git.suhail@bayesians.ca> References: X-Debbugs-Cc: Guillaume Le Vaillant , Katherine Cox-Buday , Munyoki Kilyungi , Sharlatan Hellseher , jgart Date: Mon, 14 Oct 2024 13:26:34 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , Omar Bassam X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/packages/lisp.scm (jpm): Ensure jpm respects JANET_HEADERPATH and JANET_LIBPATH if set by user. Ensure gcc/g++ is able to find header files = and compilation-related utilities. Change-Id: Ic7218dbd10e6fabddded50894b82492de8cabc88 --- gnu/packages/lisp.scm | 32 +++++++++++++++++++++++++------- 1 file changed, 25 insertions(+), 7 deletions(-) diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm index 7b557fc493..1cc8390f6b 100644 --- a/gnu/packages/lisp.scm +++ b/gnu/packages/lisp.scm @@ -30,6 +30,7 @@ ;;; Copyright =C2=A9 2024 bigbug ;;; Copyright =C2=A9 2024 Ashish SHUKLA ;;; Copyright =C2=A9 2024 Omar Bassam +;;; Copyright =C2=A9 2024 Suhail Singh ;;; ;;; This file is part of GNU Guix. ;;; @@ -963,22 +964,39 @@ (define-public jpm (setenv "PREFIX" #$output))) (replace 'install - (lambda _ + (lambda* (#:key inputs #:allow-other-keys) (for-each (lambda (dir) (mkdir-p (string-append #$output "/" di= r))) '("lib/janet/jpm" "share/man/man1")) (invoke "janet" "bootstrap.janet" "configs/linux_config.janet") - (wrap-program (string-append #$output "/bin/jpm") - `("JANET_HEADERPATH" ":" =3D - (,(string-append #$janet "/include/janet"))) - `("JANET_LIBPATH" ":" =3D - (,(string-append #$janet "/lib"))))))))) + (let ((gcc-toolchain (assoc-ref inputs "gcc-toolcha= in")) + (core-min (assoc-ref inputs "coreutils-minima= l"))) + (wrap-program (string-append #$output "/bin/jpm") + `("JANET_HEADERPATH" ":" prefix + (,(string-append #$janet "/include/janet"))) + `("JANET_LIBPATH" ":" prefix + (,(string-append #$janet "/lib"))) + `("C_INCLUDE_PATH" ":" prefix + (,(string-append gcc-toolchain "/include"))) + `("CPLUS_INCLUDE_PATH" ":" prefix + (,(string-append gcc-toolchain "/include/c++") + ,(string-append gcc-toolchain "/include"))) + `("LIBRARY_PATH" ":" prefix + (,(string-append gcc-toolchain "/lib") + ,(string-append gcc-toolchain "/lib64"))) + `("PATH" ":" prefix + (,(string-append gcc-toolchain "/bin") + ,(string-append core-min "/bin")))))))))) (inputs (list bash-minimal coreutils-minimal curl gcc - git-minimal/pinned)) + git-minimal/pinned + ;; Lazily resolve the gcc-toolchain to avoid a circular + ;; dependency. + (module-ref (resolve-interface '(gnu packages commenceme= nt)) + 'gcc-toolchain))) (propagated-inputs (list janet)) (native-search-paths (list $SSL_CERT_DIR $SSL_CERT_FILE)) --=20 2.47.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 14 13:33:19 2024 Received: (at 72925) by debbugs.gnu.org; 14 Oct 2024 17:33:20 +0000 Received: from localhost ([127.0.0.1]:43442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t0OwZ-0003fA-GA for submit@debbugs.gnu.org; Mon, 14 Oct 2024 13:33:19 -0400 Received: from mail-yw1-f196.google.com ([209.85.128.196]:46427) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t0OwW-0003em-IV for 72925@debbugs.gnu.org; Mon, 14 Oct 2024 13:33:17 -0400 Received: by mail-yw1-f196.google.com with SMTP id 00721157ae682-6e2f4c1f79bso38348697b3.1 for <72925@debbugs.gnu.org>; Mon, 14 Oct 2024 10:32:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728927114; x=1729531914; darn=debbugs.gnu.org; h=mime-version:user-agent:date:message-id:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=UdGwAtzMnT7bH2X3Qzhafy3h0+593/LeOIOZ/MCTB38=; b=TWamdQ//jTbxG+JLNWKxO53nGKnF9Wa3n9F1Tvuf+Ndi+ZTWm4HrIKmvaxk3yBOKHZ MDYo2Nxg9bi3usMWrJYn22GyCHJhmoUaDT9hh4Je2UL3g0/aNRr92wCeMD3ZSpNriqXs Ed9oSMlQyVKh9OqZu2l3P8LUoEtaR5dG40JUc2odbGFBqE7IyrtTizMFFiPbq+45QEyG 4hK1Ul4yvWGtHsvoRGrrjkLqwq2MZazIPR7Q89pRWTphv8GswF6nqY7fRRgm5wJhj/or FOw0XKEqwRD3UhBEX03/e1QL8qp3hxmpcDDJsK8471DjvLbrvxbyZwBfkdfJj48Yiv6r DnVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728927114; x=1729531914; h=mime-version:user-agent:date:message-id:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UdGwAtzMnT7bH2X3Qzhafy3h0+593/LeOIOZ/MCTB38=; b=eM3BddEAj4eW7Jgvrvm0pyO4Fv1HlLm9Gqweh1Wz9t2xTk1VYJDLH7Sitg6j7fx1GV OTurkf/wnIjW5gtzzxKQEMu00sUCrQ/1mmFB6p1qvX3ovw31P5yU5+GoQq+xil9v9o44 WxwvY55hnQR+quFHXAJiTBezYuyHlcVx51hizKO61FgZgRpAFbKbdOzDT/tqxwGIArVE cZ27IgcAxOg2y0n0AfnvVDpFZA3H27RYZWzMONrEPo2tTPGhJk5ZAybpdGeV6+d5HuH5 8jlg3c5ABd0xI6GImkqw4qVG/fscqGXUf+L5RITiSr6+Ep8xqd7qmVssnt5OlFfv/R3q XpYw== X-Gm-Message-State: AOJu0YwHO+Do1yKwvMeUE+L0K0YBxGvyu68Y0+xqiZnZ2frUonczgmeJ 4O+veS1uODkasL/Z7s16KdHX157ZEcU6i0K1XR+FfYZjWHnmDlC+WYFbZAKA X-Google-Smtp-Source: AGHT+IFihJMl8eX13y1FiU5alkqcoEBTpIqoFEFDjXOHVW2Dhg/HunqIxf8WHHatv/IZRtpuYew5eA== X-Received: by 2002:a05:6808:10c1:b0:3e5:c7d2:57d6 with SMTP id 5614622812f47-3e5c911eb9amr8077048b6e.37.1728926624312; Mon, 14 Oct 2024 10:23:44 -0700 (PDT) Received: from gnus (bras-base-mtrlpq0776w-grc-11-70-48-225-6.dsl.bell.ca. [70.48.225.6]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-460427d5220sm47552321cf.32.2024.10.14.10.23.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Oct 2024 10:23:43 -0700 (PDT) From: Suhail Singh To: 72925@debbugs.gnu.org Subject: [PATCH v13 0/2] Add jpm. Message-ID: X-Debbugs-Cc: Guillaume Le Vaillant , Katherine Cox-Buday , Munyoki Kilyungi , Sharlatan Hellseher , jgart Date: Mon, 14 Oct 2024 13:23:42 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , Omar Bassam X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi, This version incorporates one feedback from Ludo (), however, I was unable to incorporate the changes suggested in the second comment regarding gcc-toolchain (). I posted some clarifying questions in . Since, I will have limited availability in the next ~1-2 weeks I am sharing the current state for everyone's benefit. Please feel free to take this to completion if someone has a better understanding of what the desired outstanding changes are. Regards, Suhail Omar Bassam (1): gnu: Add jpm package. Suhail (1): gnu: Improve user-experience for jpm. gnu/packages/lisp.scm | 91 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 91 insertions(+) base-commit: 9d1b97d7a4ab9c0dbd5808e7859d52cff338f377 -- 2.47.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 05 12:14:25 2024 Received: (at 72925) by debbugs.gnu.org; 5 Nov 2024 17:14:26 +0000 Received: from localhost ([127.0.0.1]:44719 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8N8L-0005kf-Kc for submit@debbugs.gnu.org; Tue, 05 Nov 2024 12:14:25 -0500 Received: from mail-qt1-f194.google.com ([209.85.160.194]:61604) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8N8J-0005kO-Sz for 72925@debbugs.gnu.org; Tue, 05 Nov 2024 12:14:24 -0500 Received: by mail-qt1-f194.google.com with SMTP id d75a77b69052e-460b04e4b1cso40202291cf.2 for <72925@debbugs.gnu.org>; Tue, 05 Nov 2024 09:14:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730826798; x=1731431598; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pIT35hmoAIlO3/b8df6JSKDL13AdHDQ5fceW292/Crg=; b=ECllOK5G4xuDHH4da1GbvczkqLdeijBg16vv9iaFQIeZe8IXgGr8Vm0S8+oJ+NAg4S G0AgOdApEEqCjoAM3lI6U3eH7GHrPggMbuKpLr+o8ISM7ZCjQKtH7V3NhsaaCZrZYqLW ig0GVoenw1r5ENG3Sw8ijDCNJ2BOrog8fPaAxa/99FFgp3Ea9s8RVETKEyDOwop2IGNM +oppR4JoB/Lh/zjjqnOji5QGs8Qs9a6JfXeBHVP4wXG2NG5Mq1Ub4XYCkxgrfqk3NhEv 6X2OejcL2HKfkPeG0ZDiYiO42ZQsGLlDCtsFTL/1TNd4P6sKl1eZSzoyE4NPNPnl87/g pmAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730826798; x=1731431598; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pIT35hmoAIlO3/b8df6JSKDL13AdHDQ5fceW292/Crg=; b=wrQQ8yQNdVCZ7vms3IQS8eRGAesTryuT34L4aa7IXNOm+wYGZeRZL/YWeyVz6Z8E50 SdQ3ag/XxTXRJ/O1iwvoo3qtsiEVdBzbh8+MjtsMKD1MwKQlHpiS3m7ZCR0SuHMulBGg 4KHlnLyMDgvVA4lHrT3OubfzfvyCNUOXLGMWdXiUREmfyQtvIXYRIBVdXxsBwyh9XTMK L5tL5xkVhfUI59yEuJd/bo1EcmHYlYLZ9V0uAIoPMPLaLKT+Cpl81Wk0OAyPxFdidmuz MbDL8QO7/IFxs2m5j+L1ol3XDeFs7aSjr/k9kyBUiw9NgNjZSeq5HPVNYCz+dPXahk4a QsGQ== X-Forwarded-Encrypted: i=1; AJvYcCW0Pm/N9yhibiDPhNgdtid/MSRO65OOxRK3mZQEGt90JusBKxb7/aPyr4m7YhhkP24iY+tivQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxVi8EArFZVPIbmWIcNKtS3CBCC5Ri+glL6nc3bFNRFKOSALzU+ RDdzpqaADAschUcyULcIsYFgzSZQkCr67HpOewYHUIc3/YMeLpaJ X-Google-Smtp-Source: AGHT+IE/JBBd1AltwZpIZJ28dCYUIBa8f5/u5dg/i/2yZGc5YCg2WiyekpYqBFFAjeBye2ZeGpd95g== X-Received: by 2002:a05:622a:34c:b0:461:313e:8868 with SMTP id d75a77b69052e-4613c1c6c65mr550577591cf.50.1730826797975; Tue, 05 Nov 2024 09:13:17 -0800 (PST) Received: from gnus (bras-base-mtrlpq0776w-grc-36-174-92-178-190.dsl.bell.ca. [174.92.178.190]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-462ad161f62sm61109751cf.60.2024.11.05.09.13.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Nov 2024 09:13:17 -0800 (PST) From: "Suhail Singh" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#72925: Adding JPM package for Janet In-Reply-To: <875xpxuipi.fsf@gmail.com> (Suhail Singh's message of "Sat, 12 Oct 2024 17:14:49 -0400") References: <4665e2a478a63cf0bc6b8a18a2fb44687298bbd7.1728359428.git.suhail@bayesians.ca> <87ldyts0cm.fsf_-_@gnu.org> <875xpxuipi.fsf@gmail.com> Date: Tue, 05 Nov 2024 12:13:14 -0500 Message-ID: <877c9hr4d1.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Guillaume Le Vaillant , Katherine Cox-Buday , Munyoki Kilyungi , jgart , Suhail Singh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Ludo=E2=80=99 (or anyone else with sufficient experience), Suhail Singh writes: >> I suppose JPM shells out to GCC to compiler Janet (or C?) code, right? >> >> I=E2=80=99d recommend adding =E2=80=98gcc=E2=80=99, =E2=80=98glibc=E2=80= =99, =E2=80=98binutils=E2=80=99, and =E2=80=98ld-wrapper=E2=80=99 to >> =E2=80=98inputs=E2=80=99; that=E2=80=99d less us avoid the =E2=80=98gcc-= toolchain=E2=80=99 dance. > > It seems "ld-wrapper" requires (gnu packages commencement) and this > results in doing the lazy dereference similar to gcc-toolchain above. > Am I doing something wrong? If not, is the guidance still to add > "ld-wrapper" to inputs? > >> Then in, the phase above, make sure to =E2=80=98search-input-file=E2=80= =99 rather than >> direct references to these variables. > > Hmm just to be clear, instead of: > > #+begin_src scheme > `("C_INCLUDE_PATH" ":" prefix > (,(string-append gcc-toolchain "/include"))) > #+end_src > > > What we want is something like: > > #+begin_src scheme > `("C_INCLUDE_PATH" ":" prefix > (,(search-input-file inputs "/include"))) > #+end_src > > Is my understanding correct? > > If so, adding "gcc", "glibc", "binutils", and "ld-wrapper" seems > insufficient to make that work. The search-input-file for "/include" > results in a "&search-error" when building the package. Could you please clarify the above? Is v13 I sent good enough? If not, could someone provide guidance on what's left to do? Regards, --=20 Suhail From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 05 11:29:16 2025 Received: (at 72925) by debbugs.gnu.org; 5 Jan 2025 16:29:17 +0000 Received: from localhost ([127.0.0.1]:34930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUTV6-00047u-Jv for submit@debbugs.gnu.org; Sun, 05 Jan 2025 11:29:16 -0500 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]:54544) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tUTV3-00047e-9O for 72925@debbugs.gnu.org; Sun, 05 Jan 2025 11:29:14 -0500 Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-aa6a92f863cso2394222866b.1 for <72925@debbugs.gnu.org>; Sun, 05 Jan 2025 08:29:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736094547; x=1736699347; darn=debbugs.gnu.org; h=mime-version:message-id:date:cc:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=S/nT+CUOTsAlCWYNV3uUy8sfAQJnjh/yOwcHVEvozXE=; b=l4jHrC0KTcp4PUg4eTxK2xt7kw4G6btxixOAsA9lUisMAx0qTIf1uS6t4Fg9B688Pa 5QY5YV3jVG89IBn6IAkZGDIQLi014cgADgIaOTUEOVrASEZMMJm6yTFVa8tiYsZAemjW jrPnhDiCYAqFzmwF+PDEpEyUplokqyEYxRQnEltKra/pFI6nKZpBYchQ5sth4yDrZBfF G1R4cFAwOBWCam337FpiNIXG/82ITt7mgLNdCxKJhtvFkfjnAbRjb/O7MDIpo+g82flL Qn5tRlB5ARJwK+5msgoZSOHutlU9gAkn3mCcbV2GgGQeFpwjAlGh1po4BJbRZgzOmFyf MJbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736094547; x=1736699347; h=mime-version:message-id:date:cc:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=S/nT+CUOTsAlCWYNV3uUy8sfAQJnjh/yOwcHVEvozXE=; b=bWtZLLLS5xkFPSaBNZekfSbTqXS9J2n5296BUBPU909ELG/4TOz1HI4FU/+V3poglk yXYHGX0StdFriu53kDlDicnPK/gR30iQ3eu6rzeQKz/B8IQG4vNc/K4fVa8iR49nakVV ZIz6LzUuMIfx50MCs2K6qZdP0zr+OROCSquzPpUjzSbnxKINQb1E/ZbgAqnxLha6T8Cg kp38ExH3oSB0pKsTwzkCJWx0l5ww3bpGXsai+IrPWYNwAwls4ykZXAJn4GYwRqPr6qVv tliikUlv0oSm0YDNofECKai3dRjJEpkgFCVKY0hoC57pJvZ47YYOQU5XTEYAvcSFDqU7 geRg== X-Gm-Message-State: AOJu0YxYOodeLggNA9OjsyG4Ympewb3GkniUYhjNtLDaYC5jDg2pTfFH rmt+Rk8mSlCj4Wf/H07Kja8tBjrhQP3G4S5iUQ9albic/qentT+U X-Gm-Gg: ASbGncutVXp9UNRhBWlhmYrPrr4Ko8woM5rXeosmeUHJx49VZX4EXM/YSpVS8cFiG24 M7sAACGpWadqrJzMo+RY/OYIO4YlhOsJTeyx9YoQZ0beKA8CJ5I2y7ngKnZSiLIF5/6EGOcCMJj PT023e6C9JVxBRNfee0Su/ysYbie4rFmw54jkGr9wbPdSwC2m3U1K7ueXYwEwVMXVn8sbe+GGt/ DRq+pD/BM/QDq4tZA1K8gx6DBYReSgzcd0JJRt0MzqWsQEaNsDvqKclAZWvOFGUzah2yw== X-Google-Smtp-Source: AGHT+IGqV1hSZECuAl8oGqTEP2UajzuxW7UFdD36COhdqJOiYRkrT6xTeIBWy+3iNYkTFmmL45ZG9g== X-Received: by 2002:a17:907:971e:b0:aa6:8d51:8fdb with SMTP id a640c23a62f3a-aac2ad81a68mr5490134666b.19.1736094546779; Sun, 05 Jan 2025 08:29:06 -0800 (PST) Received: from omar-Latitude-5540 ([46.232.152.54]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aac0e895d31sm2152515266b.61.2025.01.05.08.29.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jan 2025 08:29:06 -0800 (PST) From: Omar Bassam To: 72925@debbugs.gnu.org Subject: Adding JPM package for Janet Date: Sun, 05 Jan 2025 18:28:59 +0200 Message-ID: <87ed1hcjhw.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: jgart@dismail.de, suhailsingh247@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) I've noticed that jgart has already worked on this on onther channel here: https://git.sr.ht/~whereiseveryone/guixrus/tree/master/item/guixrus/packages/misc.scm#L1168 Is there's a reason why we can't just include this here? BRs, Omar From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 05 12:12:26 2025 Received: (at 72925) by debbugs.gnu.org; 5 Jan 2025 17:12:26 +0000 Received: from localhost ([127.0.0.1]:34988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUUAs-0006D2-Gz for submit@debbugs.gnu.org; Sun, 05 Jan 2025 12:12:26 -0500 Received: from mail-qv1-xf43.google.com ([2607:f8b0:4864:20::f43]:57505) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tUUAp-0006Cs-AQ for 72925@debbugs.gnu.org; Sun, 05 Jan 2025 12:12:24 -0500 Received: by mail-qv1-xf43.google.com with SMTP id 6a1803df08f44-6dd049b5428so114966376d6.2 for <72925@debbugs.gnu.org>; Sun, 05 Jan 2025 09:12:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736097142; x=1736701942; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=H2Jc6mJZFZvJhO00FW4M7GQ8dO8vKQfwQDTnDoTkH8M=; b=VvQwbcv1keKzLX/OieremsWU3LIuodxqN71ih/JKhBtVKTxNRUjLbh5zdXRCY0aytT DMqQcAooE24613KtjinoJNnyqonlLiOprwpEfMqh9WsbXPcwBeRbkzZ1LuP8W8oE4sie 9QkcaRlKzlUEDVZE3Rjovi3LKuPvUUGDc/5KCRDSIyH3uWbCjXWhnZGYQixRQVtvgpM+ wVNdeRmO3m/ByzZomAktSWD+glILgfa6TRqVT9FRCsDjddobFtQRmczXCJhrYPZXfYii G3f3BqCZQW9LTMvloB1p9y/nDsdVpORlU1FTixtgSsPTYCyR0aJQAixNw8AhpCpC1yDw e2Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736097142; x=1736701942; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=H2Jc6mJZFZvJhO00FW4M7GQ8dO8vKQfwQDTnDoTkH8M=; b=wCz787SshOiGilKihmQy5914DzJpuJtsdO8w80DqpW2Na2poeDfe29oJRtAwN5+3dI Um5WSy4nhnRharjmlHgp5+ygW5twIBdexdnj60wyC8ta2iu2vTZNWvQZtYA8sps1SEO0 qZrHK7SLtIiBdViI8pBrBnz6hKck0ZGMQlTFZ0vZCx0ddZgYWhfnszmOVOf7GVilu2BZ BV99Qh+53HcHtDjZuIEL6XzNSIJygcI75bdWFTLplr4bqZJ2OmXZeL2kFwdNeQ6qIgGh rl9zo93DIQtfp6DUB3dtExLEL6t/Z/ARxNqa7U8iPSpcbfJ6xfaY5ONNvQzAtVel4mqT T4kQ== X-Gm-Message-State: AOJu0YzMBEDSjltH4wusQkSmcbiXAfQAgXYxYI7zPc/2ZW3LJwbj3R0L 24A2Bl7aVT7+szmyO4kKg6tFqd26khpjDMvwC3T2QFQFtk62WdvN X-Gm-Gg: ASbGnct2aadYKgITbESV8FFWWI4ZxSibUfeSOYEnpiqskyXB/2tmi2YQaZVyl4Ulydq s8KwWfzutrAhixSo/uZBNoWSe8SedaoJaeBajGBnaIaclYEwCYBpzKC6FztIHizjihp0XS1cC6/ RrcUnqQtzav3KrVa5bQNQQ7m3Hm6EcGHOB6ahcUNerndEr9PVw07re5OHLvYGDGtNWqLOg5E1bu J7pm82cWqFlyceAkb+MRJYCCSsZkFcgiUL3dTvv7l8AVZJ3NwJv X-Google-Smtp-Source: AGHT+IE7eOkUf9Evjz5TkN5z5TQTtFDXHTw78Gk18eAoh9gkNJTcdwKaLCMouE5znDVDtVD8mZCAMQ== X-Received: by 2002:ad4:5d61:0:b0:6d8:7e03:c434 with SMTP id 6a1803df08f44-6dd2332e43bmr943665116d6.20.1736097142513; Sun, 05 Jan 2025 09:12:22 -0800 (PST) Received: from gnus ([70.26.179.129]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6dd181a7c1fsm164869876d6.72.2025.01.05.09.12.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jan 2025 09:12:21 -0800 (PST) From: Suhail Singh To: Omar Bassam Subject: Re: Adding JPM package for Janet In-Reply-To: <87ed1hcjhw.fsf@gmail.com> (Omar Bassam's message of "Sun, 05 Jan 2025 18:28:59 +0200") References: <87ed1hcjhw.fsf@gmail.com> Date: Sun, 05 Jan 2025 12:12:10 -0500 Message-ID: <87zfk5gp79.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: 72925@debbugs.gnu.org, =?utf-8?Q?Ludovic_Court=C3=A8s?= , jgart@dismail.de, suhailsingh247@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Omar Bassam writes: > Is there's a reason why we can't just include this here? Biased, as I might be I do believe v13 is better off for the feedback it's received. However, it's been almost 3 months since v13 was posted [1]. And 2 months since I pinged the last time [2] =/ : > Is v13 I sent good enough? If not, could someone provide guidance on > what's left to do? Ludo, jgart: comments? [1]: [2]: -- Suhail From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 05 15:14:26 2025 Received: (at 72925) by debbugs.gnu.org; 5 Jan 2025 20:14:27 +0000 Received: from localhost ([127.0.0.1]:35376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUX10-0007Ly-H4 for submit@debbugs.gnu.org; Sun, 05 Jan 2025 15:14:26 -0500 Received: from mx1.dismail.de ([78.46.223.134]:5889) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tUX0x-0007Ld-TU for 72925@debbugs.gnu.org; Sun, 05 Jan 2025 15:14:25 -0500 Received: from mx1.dismail.de (localhost [127.0.0.1]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 1519ba21; Sun, 5 Jan 2025 21:14:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h= mime-version:date:content-type:from:message-id:subject:to:cc :in-reply-to:references; s=20190914; bh=pXvC3e+LFIHrOiRi9OPdi/L/ UmWB7HQ5QzJ3nbzoRgA=; b=rRhlyuaoAkqX+pPJL75Rr9tkoyJJpMp2ephczhR4 CG4YCs7blhKcEm7J1AhzQoALW3rlAvEbZ2Q2xUBXXM0+Di/vhp65NW/Co5KeWuSx v7V2ym9WZdE8ksUYylO5hNmAJFxEPDPnnUAShhO8DImo4/JzEsAvFRPIm8CyOsqF ERfkXtm3ofIsatLOL7U7uyntyOIsHcNnWdJVsE4xt+lsNfrlg4PMBjZp0MRVXFak 1aZUiTE4qjfLZfEywLvHPnayibaLmMNqD6bd3LWyt0zRrnU6Zo48+Rpko2uf3bV0 BrmmmM19xQu0kC8C+uxGY5W69oWsEc3Q68g7soW8xlxlcQ== Received: from smtp1.dismail.de ( [10.240.26.11]) by mx1.dismail.de (OpenSMTPD) with ESMTP id eade4230; Sun, 5 Jan 2025 21:14:15 +0100 (CET) Received: from smtp1.dismail.de (localhost [127.0.0.1]) by smtp1.dismail.de (OpenSMTPD) with ESMTP id e202faf7; Sun, 5 Jan 2025 21:14:15 +0100 (CET) Received: by dismail.de (OpenSMTPD) with ESMTPSA id d8420528 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sun, 5 Jan 2025 21:14:14 +0100 (CET) MIME-Version: 1.0 Date: Sun, 05 Jan 2025 20:14:13 +0000 Content-Type: multipart/alternative; boundary="2056b055-9e93-40ea-8901-e7a16d67899c-1" From: "jgart" Message-ID: TLS-Required: No Subject: Re: Adding JPM package for Janet To: "Suhail Singh" , "Omar Bassam" In-Reply-To: <87zfk5gp79.fsf@gmail.com> References: <87ed1hcjhw.fsf@gmail.com> <87zfk5gp79.fsf@gmail.com> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 72925 Cc: 72925@debbugs.gnu.org, =?utf-8?B?THVkb3ZpYyBDb3VydMOocw==?= , suhailsingh247@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --2056b055-9e93-40ea-8901-e7a16d67899c-1 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable >=20 >=20Ludo, jgart: comments? >=20 >=20[1]: https://issues.guix.gnu.o= rg/72925#68%3E=20 >=20[2]: https://issues.guix.gnu.o= rg/72925#69%3E >=20 >=20I've noticed that jgart has already worked on this on onther channel = here: Hi Omar,=20 I=20would probably not use that as I am not maintaining it and I haven't = gotten janet/jpm to load libraries. I'll delete that from Guix 'R Us. Hi Ludo, I haven't had the time to review this.=20 I=20will try to review it next weekend when I free up some time hopefully= . Can the contributor please summarize for me/fill me in on the latest vers= ion, if it is able load janet packages with jpm, and what they have teste= d that works so far without me having to parse through a huge wall of out= dated thread text?=20 This=20will help expedite, focus, and contextualize the ticket during the= limited amount of time I have to review it next weekend. Thanks! all best, jgart --2056b055-9e93-40ea-8901-e7a16d67899c-1 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable
Ludo, jgart: comments= ?



[1]: <https://issues.guix.= gnu.org/72925#68>

[2]: <https://issues.guix.gnu.org= /72925#69>

> I've noticed = that jgart has already worked on this on onther channel here:

Hi Omar,

I would probably= not use that as I am not maintaining it and I haven't gotten janet/jpm t= o load libraries.

I'll delete that from Guix= 'R Us.

Hi Ludo,

I h= aven't had the time to review this.

I will try = to review it next weekend when I free up some time hopefully.

Can the contributor please summarize for me/fill me in = on the latest version, if it is able load janet packages with jpm, and wh= at they have tested that works so far without me having to parse through = a huge wall of outdated thread text?

This w= ill help expedite, focus, and contextualize the ticket during the limited= amount of time I have to review it next weekend.

Thanks!

all best,

jgart
--2056b055-9e93-40ea-8901-e7a16d67899c-1-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 05 16:12:40 2025 Received: (at 72925) by debbugs.gnu.org; 5 Jan 2025 21:12:40 +0000 Received: from localhost ([127.0.0.1]:35518 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUXvM-0002fs-0j for submit@debbugs.gnu.org; Sun, 05 Jan 2025 16:12:40 -0500 Received: from mail-qv1-xf42.google.com ([2607:f8b0:4864:20::f42]:48407) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tUXvJ-0002fj-Kx for 72925@debbugs.gnu.org; Sun, 05 Jan 2025 16:12:38 -0500 Received: by mail-qv1-xf42.google.com with SMTP id 6a1803df08f44-6d896be3992so81370636d6.1 for <72925@debbugs.gnu.org>; Sun, 05 Jan 2025 13:12:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736111557; x=1736716357; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=00tHTEPBNmXXmY0hcg4vi2D88BgRCvGqKbiU9ozHSSw=; b=Pfn0U2pkdAfJQAGmkx6LsmBHTbRnrQZbSX/U3VwGPRuvqogPThPc36XRV/bOnUq31H HE0X3lDVtm9pDNjTXm+lnfkfwTfdO5KtfFB0AY5z1ymqwV/v5egmeNfH71YFQtD0jlx3 1OKWmDz9Jzt9EA7QQKHL6Jz1O2t6DXBW8x5CfDyV5bveAycY5hSXH15NbJ7hjZtIIbqA A9rz7TKJN4Xy+FzWvqCnCM2tcnuiqGygPhs1X+WegS+vVjUpUjcqGcPQg0J5a9sQC5Sa SqyoKPUfycjHgwR3WQVwV7aZHWK1AGfC3PwRFjURIHyk/E9iUyRbQXWu9LQhaSezdqS0 KdBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736111557; x=1736716357; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=00tHTEPBNmXXmY0hcg4vi2D88BgRCvGqKbiU9ozHSSw=; b=BGyh2CJ6wMr3K+It8AjW3f9TjuRUq0qugnIV5oIRNPNShf4iYdqGBTJ8v3SIOk2vhy kP3h6nne077CSgt1qOQ56B6Y8yShIVL7UEJ7fHmjdN5HExYPB5sUaHTg8KGZFPPBwynC C4qpWQ7cfJLjtgO8ssAVHqdWzAI1NNtO8gwNPjs5kai+hQy2c2qBlkPtr6oPwOF7p7cg F/fgvbL9rRJYhiotsyBPXrmcReYrCtM4JXCf/namuuUA+gq1irXcuTk9SePUOJLFAzn7 xnJZUhxvSS1dH7IJyWL3FXn3zp8KCIFu7dm6bZGUjom3byS6K97TzEUkBiqdc14UfjNa iDfQ== X-Forwarded-Encrypted: i=1; AJvYcCV8Ao8sPnsiuHc+moaGkVZd9z7+DrbhfMzaP9Ip2q9k77KOI2UZOowJ6BFRrR8MKDgw8/uYxQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yxj5q2Hs8jNFyxj+wIj9apbiQmqT/dcy/Kt5JkdjlYaoXD6bL/q 9IXpdyq/RdTIsmhE4lmBVOSF7HxWyFW3k099yM7o4Z0KVF9rgKoB1HBw34T1 X-Gm-Gg: ASbGncsH3gJi21pvYHYzq214WCTyknIqMgfutSfl/wPzLDzI9v1zA1befuTaNRV/4VM gR8F5kYfTW7N5Iaq2fBpKz3EoF/2ywNlL/hQj6klUNfKvknMVl+56jxEeO6rwCpSU841kXOond9 3e5LA5grDwlGtBqpKcMab5fLGddKebVw7rFZb9sR65Vl/VMDmzffWzYnIUSv7cP98VXkxRuwdM+ w803lOR39GrK7ZsWGe6IChkvSAyLDllAGGYDkUkc1LHP06LzvN7 X-Google-Smtp-Source: AGHT+IFphi5E2tgeUZVvNf/wtdwWVrCtjEZUPtiuZIkI2wHGUKpbnnGvdjb4cyUeC4PL9iNsP2oDhQ== X-Received: by 2002:a05:6214:250a:b0:6d8:8256:41d7 with SMTP id 6a1803df08f44-6dd233978ccmr841852966d6.33.1736111556642; Sun, 05 Jan 2025 13:12:36 -0800 (PST) Received: from gnus ([70.26.179.129]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6dd249e8604sm153143716d6.4.2025.01.05.13.12.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jan 2025 13:12:35 -0800 (PST) From: Suhail Singh To: "jgart" Subject: Re: Adding JPM package for Janet In-Reply-To: (jgart@dismail.de's message of "Sun, 05 Jan 2025 20:14:13 +0000") References: <87ed1hcjhw.fsf@gmail.com> <87zfk5gp79.fsf@gmail.com> Date: Sun, 05 Jan 2025 16:12:24 -0500 Message-ID: <874j2dt16v.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: 72925@debbugs.gnu.org, Omar Bassam , =?utf-8?Q?Ludovic_Cou?= =?utf-8?Q?rt=C3=A8s?= , Suhail Singh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) "jgart" writes: > I will try to review it next weekend when I free up some time > hopefully. Thank you. > Can the contributor please summarize for me/fill me in on the latest > version, Omar submitted the original patch series that spawned the issue. I reviewed the patches. However, at some point it was easier to provide feedback by submitting a revision myself. Specifically, v12 was submitted by me. Ludo requested some further tweaks. I was able to partially address that feedback in v13. The possibly outstanding point (which may or may not be a nitpick and may or may not be relevant), is noted in . > if it is able load janet packages with jpm Yes. > and what they have tested that works so far For v13, given a profile containing only jpm, bash, coreutils-minimal and nss-certs and loading it using something like the below: #+begin_src sh guix shell --pure -CPWN \ -E '.*GTK.*|.*XDG.*|.*DISPLAY.*|TERM|INSIDE_EMACS' \ -p /path/to/profile #+end_src I have tested using the below commands: #+begin_src sh cd /tmp mkdir -p review-72925 && cd review-72925 jpm install -l sh jpm install -l spork #+end_src Based on , I believe Omar may have done some additional testing as well. -- Suhail From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 05 16:22:42 2025 Received: (at 72925) by debbugs.gnu.org; 5 Jan 2025 21:22:42 +0000 Received: from localhost ([127.0.0.1]:35545 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUY54-0003CJ-34 for submit@debbugs.gnu.org; Sun, 05 Jan 2025 16:22:42 -0500 Received: from mx1.dismail.de ([78.46.223.134]:5180) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tUY52-0003C3-1h for 72925@debbugs.gnu.org; Sun, 05 Jan 2025 16:22:41 -0500 Received: from mx1.dismail.de (localhost [127.0.0.1]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 1a5289f8; Sun, 5 Jan 2025 22:22:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h= mime-version:date:content-type:from:message-id:subject:to:cc :in-reply-to:references; s=20190914; bh=JtOxuy2+sb6I+xR0jkBpkpHE Z0aUlHHTtDQk4EEmjZA=; b=aBEbrDxG8NdpuniU4fdMxU7eu6pwu0I5DstYbjNq wKyE2XlHeFzrF5FYDqrzleEG0aMahs8Op/JcFnVPHQZ1ClmfuRAc+SRa8IyRCBCY IA2Fm2DqlxXnQNnpgIoEiMZeaqN/hhaogrVbD4G4UVcevLDWW2QU1VWEND8CusSB j8R8jgCnIp3zWv1s1civlbD9C6hkFFC2k0w9VcVL8hBimu+LF3xSgwOy507OF2eL HhFV77klBkA9JUUiOgRAtlhHe+CXSoVWBdilTsxnHhLiy3Y40zBYJ2z357EGYZiN oiW9JzvVtOy9a+Gp5mIBHAGwnuvvz1gAc0CVEfw0lHCSIQ== Received: from smtp2.dismail.de ( [10.240.26.12]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 8041cd87; Sun, 5 Jan 2025 22:22:30 +0100 (CET) Received: from smtp2.dismail.de (localhost [127.0.0.1]) by smtp2.dismail.de (OpenSMTPD) with ESMTP id ae666d9c; Sun, 5 Jan 2025 22:22:30 +0100 (CET) Received: by dismail.de (OpenSMTPD) with ESMTPSA id 9598e1ab (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sun, 5 Jan 2025 22:22:30 +0100 (CET) MIME-Version: 1.0 Date: Sun, 05 Jan 2025 21:22:29 +0000 Content-Type: multipart/alternative; boundary="aec42ca0-2f4d-4f6d-b993-464e6090261d-1" From: "jgart" Message-ID: TLS-Required: No Subject: Re: Adding JPM package for Janet To: "Suhail Singh" In-Reply-To: <874j2dt16v.fsf@gmail.com> References: <87ed1hcjhw.fsf@gmail.com> <87zfk5gp79.fsf@gmail.com> <874j2dt16v.fsf@gmail.com> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 72925 Cc: 72925@debbugs.gnu.org, Omar Bassam , =?utf-8?B?THVkb3ZpYyBDb3VydMOocw==?= , Suhail Singh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --aec42ca0-2f4d-4f6d-b993-464e6090261d-1 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable >=20 >=20I have tested using the below commands: >=20 >=20#+begin_src sh > cd /tmp > mkdir -p review-72925 && cd review-72925 > jpm install -l sh > jpm install -l spork >=20 Hi,=20 Did you also test that sh and spork successfully load in a janet REPL via= some require or loading command?=20 Note,=20that I am not a Janet user. I mostly work on Common Lisp and Guil= e (mostly Guix). all best, jgart --aec42ca0-2f4d-4f6d-b993-464e6090261d-1 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable
I have tested using t= he below commands:


#+begin_src sh

cd /tmp

mkdir -p review-72925 && cd review-= 72925

jpm install -l sh

jpm install -l sp= ork


Hi,
Did you also test that sh and spork successfully load in a ja= net REPL via some require or loading command?

Note, that I am not a Janet user. I mostly work on Common Lisp and Gui= le (mostly Guix).

all best,
jgart
--aec42ca0-2f4d-4f6d-b993-464e6090261d-1-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 05 17:30:43 2025 Received: (at 72925) by debbugs.gnu.org; 5 Jan 2025 22:30:43 +0000 Received: from localhost ([127.0.0.1]:35710 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUZ8s-0007yG-Ud for submit@debbugs.gnu.org; Sun, 05 Jan 2025 17:30:43 -0500 Received: from mail-qv1-xf41.google.com ([2607:f8b0:4864:20::f41]:60760) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tUZ8o-0007xz-OU for 72925@debbugs.gnu.org; Sun, 05 Jan 2025 17:30:41 -0500 Received: by mail-qv1-xf41.google.com with SMTP id 6a1803df08f44-6dd5c544813so93972436d6.1 for <72925@debbugs.gnu.org>; Sun, 05 Jan 2025 14:30:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736116232; x=1736721032; darn=debbugs.gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=CwpzRJsQoD8rooQRgUaMpbaS/Dq994xJajiLNhiHUzQ=; b=UjkE6CeJJRSqOwwlNjepaSWcgFqrGKPyo3x9cDwulRu8+F2dcQBXv4et7s+SzLHGYK LOVWRbhqU5mLiRszi17sd7pHvoKYftf48VBL6g9eSiACCWcU+UxswqOxpFMbFAxcfffh vT8ipJig6nGrmv3Mp5bM0rfGAJ6nPNbx7zO3IWPC0fQCg8rEkryM/FJTBUywYL67jagR Rro0Q4499vNFRdUKiAdhOIGkny3Ybd5SQY3CW0SNQ9Z2u4rOOYmzSPdVzceO1SCggkpL mVH9WsNER5AygVz384QPjsuZ36ssWW9pluKG8JM9RnxjKPvsRNJeXjvkjSDGeHls7JoS ugrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736116232; x=1736721032; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=CwpzRJsQoD8rooQRgUaMpbaS/Dq994xJajiLNhiHUzQ=; b=P5qMiWMzhTAlx6q5P8LQxooNwCzhbalGpFNiNQZwxyFXjMGowyxbBLCRByHKOcE7iQ ftWqcPHzTAX0KaNKHgox2RduE0avQRu+0+DSkkwEbNx0h2ceDzhClAmo8nw9KIOt6dkH GbDBOZb6PlB9vVJ3DOwVBcRybt550skMugBHMtllfGJPUy/+o5AwGORB03yDGdZzAI8w VqQpYjeJSVFOjOw+9VDENzYAlLLlHsxM5s7dJBOB6RiAemShZIm8EREICcHpo/yHUOax zwKALfjzxG+F3vt55hYnpY7mFW6TWOq7SbsgEhRpkgU+6HQUz+GIcLipH/rPTWrWS9bk 7tAg== X-Gm-Message-State: AOJu0Yx6BOQkcOBZAe4M21MJbs7Kku6+CZi0Mce1lHYOP2m1up2XHRXE 2Sj8jdt2I3mC4l7u9pnGO1JCUiRzA5W1SCpzPiufMKM0HSznXAkcBdDOpKSN X-Gm-Gg: ASbGncv/3RTqqN37aueeC1Wo7hv0hBtJwl/DFvT6iUmgZmjbS5NQ/iImm7GVZZ0WE+q VR7eRB+9XlxFQHFT2Rm/5oO2zSwILuuB/OtB8uyuZp96JG4VKn71AiW1vKln+trhAqRUboyM/Fy tsNJmRZSJDIyzDAJnU7Km23454KJOS1L/G9pBFTGVWqiagq8XQYBRT06rPnfl/k9LitA1QSKtZZ Tkhh65UBM7PWUQvyXBqyZrOo6w8Cr7e6HLMTBP5Tm0HNutbuO6O X-Google-Smtp-Source: AGHT+IGKOkWLfAdKASOq/VNGsAbT7QDt29lhd+cr9fDdqndJ5XaACLcaVLUJKDUWvwLm3BclQv/QZw== X-Received: by 2002:a05:6214:5189:b0:6d8:a148:9ac9 with SMTP id 6a1803df08f44-6dd233ac14cmr770535766d6.30.1736116232323; Sun, 05 Jan 2025 14:30:32 -0800 (PST) Received: from gnus ([70.26.179.129]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6dd181bb4desm163960666d6.87.2025.01.05.14.30.31 for <72925@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jan 2025 14:30:31 -0800 (PST) From: "Suhail Singh" To: 72925@debbugs.gnu.org Subject: [PATCH v14 0/2] Add jpm. Date: Sun, 5 Jan 2025 17:28:28 -0500 X-Debbugs-Cc: Guillaume Le Vaillant , Katherine Cox-Buday , Munyoki Kilyungi , Sharlatan Hellseher , jgart Message-Id: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hello Guix, v14 is the same as v13, but has been rebased onto master. Given a profile containing only jpm, bash, coreutils-minimal and nss-certs and loading it using something like the below: #+begin_src sh guix shell --pure -CPWN \ -E '.*GTK.*|.*XDG.*|.*DISPLAY.*|TERM|INSIDE_EMACS' \ -p /path/to/profile #+end_src I have tested using the below commands: #+begin_src sh cd /tmp mkdir -p review-72925 && cd review-72925 jpm install -l sh jpm install -l spork #+end_src For "sh", the below successfully works in janet repl which is loaded via "jpm -l repl": #+begin_src janet (import sh) (sh/$ touch foo.txt) #+end_src For spork, I the following example has been tested as working in a janet repl invoked via "jpm -l repl": #+begin_src janet (import spork/tasker) (def t (tasker/new-tasker)) (ev/spawn (tasker/run-executors t)) (tasker/queue-task t ["echo" "hello," "world"]) (tasker/queue-task t ["echo" "hello," "world"]) (tasker/queue-task t ["echo" "hello," "world"]) (tasker/queue-task t ["sleep" "5"]) #+end_src Omar Bassam (1): gnu: Add jpm package. Suhail (1): gnu: Improve user-experience for jpm. gnu/packages/lisp.scm | 91 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 91 insertions(+) base-commit: ddbb59f9bc5eb6dfaf1fc24881bb62f11960d664 From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 05 17:30:59 2025 Received: (at 72925) by debbugs.gnu.org; 5 Jan 2025 22:31:00 +0000 Received: from localhost ([127.0.0.1]:35713 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUZ99-0007yz-Bu for submit@debbugs.gnu.org; Sun, 05 Jan 2025 17:30:59 -0500 Received: from mail-qk1-x744.google.com ([2607:f8b0:4864:20::744]:59749) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tUZ95-0007yZ-Nk for 72925@debbugs.gnu.org; Sun, 05 Jan 2025 17:30:57 -0500 Received: by mail-qk1-x744.google.com with SMTP id af79cd13be357-7b700c13edaso731348185a.3 for <72925@debbugs.gnu.org>; Sun, 05 Jan 2025 14:30:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736116250; x=1736721050; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:in-reply-to :subject:to:from:from:to:cc:subject:date:message-id:reply-to; bh=cdibrNKha1/ItOQt6Tm3aI33gJc2DMjfkEq8UOR12Ws=; b=IrmdeTv0hKp4T9vMFbYwukBSNPS5kHemMwRoEbcPJupnja0BmAsFzVIqAiP7mh/aTJ 8/aNdMg5FfvqFAhVtEllScQMOKQMk5fYlaPW7y2f3ZevZ6HGpS+UNDlUkBWRSl5Dl9vb M2kqZGIFryMtoCmUrOAUld1aOcbXUx+jscLw6va2jNFQ0W3RPifjV2fNZAoeL6C7xFvJ XBjCma11tzVjyLsj0D92ayg2xeEwzk1jtDVVCpFH3Z6XFc2wjFo5GtQhqPSbr/SupfXj hFcuE1uqWY763Nv/zpz5+bt1TdkXBBWBzsRyd6OKHEgp1hNRKBncSv7e3MNNNsWlyrlM bwGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736116250; x=1736721050; h=content-transfer-encoding:mime-version:message-id:date:in-reply-to :subject:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cdibrNKha1/ItOQt6Tm3aI33gJc2DMjfkEq8UOR12Ws=; b=ET9zboNRr/CE6uxoXQVJMJtccVbai9vvCfF18a0Cq7Z1EkqfGTZlwCiu8P45xkY6gN 2m9IGWRZW3f2J/7Yrk5NCgggWNtQT0o1/ECRNszix+YYGgYHi14ciqhw0n245XSyQ4Cq 8092rLjFgnDeVKwI9atLpxyBzaZ/uTfkbDB8q8hg/hO6t8h8FFymhnAEkHDNViDUUz9D NIfPfln/s71Dsc2K4M5WLUH+4p55Uoz20KNQVJNCFUldyit0jda8eTxeaJ3hwJs+AmIQ WVQlsU7/2akerkVyipspz3yC/LVBjL19uzGJsfVmf+EasBd0LtPJ1Rhn6CI86jNy1kNQ PIAg== X-Gm-Message-State: AOJu0YzMLzu7ONeL28gk8IsAPBIYwYnB6eUhAYHwQnPIsGfKKrV2QImz 33XFpLb9jiEfuX0VfCApydGNAJB/8oV/KwKdlA0AufEzmdd97aI6gNY8S7+4 X-Gm-Gg: ASbGncvXkN/R4YnsVaNJdCJlSXWJ9h8D40GZsQcNGLucF+5idw7kxaxepi6h3FmvqOY 39ZAX+vV3EVaM1GvAvLROmGcufJ7mXiRLG9RF6LHIDSKZ7V0CT0Y72dFzmqLlzFWCGb6Dx8gCCw i37ZVQR1S0rtJVnr/HDhbMPKK7j2TyMuVtEG28Vx8bzgX3ToPVj7EsLcnd4UkRD2FZzGba4xltQ Df4P1YBrqsARkCcIYQHTHmvetsxCnqWpKLZNWp12BKVrBvJUu7c X-Google-Smtp-Source: AGHT+IFL/+xLxTMoPNnsvjscOvykNaJngadqlitJ1o6SUFDj9zJb9sEZsZIJt9ZldjGXCGnsYhsNdg== X-Received: by 2002:ad4:5c6a:0:b0:6d8:9d81:2107 with SMTP id 6a1803df08f44-6dd2332dfa2mr814740316d6.20.1736116249723; Sun, 05 Jan 2025 14:30:49 -0800 (PST) Received: from gnus ([70.26.179.129]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6dd181d5aabsm164735306d6.108.2025.01.05.14.30.48 for <72925@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jan 2025 14:30:49 -0800 (PST) From: "Suhail Singh" To: 72925@debbugs.gnu.org Subject: [PATCH v14 1/2] gnu: Add jpm package. In-Reply-To: Date: Mon, 7 Oct 2024 23:31:57 -0400 X-Debbugs-Cc: Guillaume Le Vaillant , Katherine Cox-Buday , Munyoki Kilyungi , Sharlatan Hellseher , jgart Message-Id: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 2.3 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * gnu/packages/lisp.scm (jpm): New variable. Change-Id: I9f5ab89a38622689b5d3545abe5d87906dc61f3b Signed-off-by: Suhail --- gnu/packages/lisp.scm | 73 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 73 insertions(+) Content analysis details: (2.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (suhailsingh247[at]gmail.com) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (suhailsingh247[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 2.1 DATE_IN_PAST_96_XX Date: is 96 hours or more before Received: date -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:744 listed in] [list.dnswl.org] X-Debbugs-Envelope-To: 72925 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * gnu/packages/lisp.scm (jpm): New variable. Change-Id: I9f5ab89a38622689b5d3545abe5d87906dc61f3b Signed-off-by: Suhail --- gnu/packages/lisp.scm | 73 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 73 insertions(+) Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:744 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (suhailsingh247[at]gmail.com) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (suhailsingh247[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 2.1 DATE_IN_PAST_96_XX Date: is 96 hours or more before Received: date -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager * gnu/packages/lisp.scm (jpm): New variable. Change-Id: I9f5ab89a38622689b5d3545abe5d87906dc61f3b Signed-off-by: Suhail --- gnu/packages/lisp.scm | 73 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 73 insertions(+) diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm index 9cc630eec2..f99ad68828 100644 --- a/gnu/packages/lisp.scm +++ b/gnu/packages/lisp.scm @@ -29,6 +29,7 @@ ;;; Copyright =C2=A9 2024 Andreas Enge ;;; Copyright =C2=A9 2024 bigbug ;;; Copyright =C2=A9 2024 Ashish SHUKLA +;;; Copyright =C2=A9 2024 Omar Bassam ;;; Copyright =C2=A9 2024 David Pflug ;;; Copyright =C2=A9 2024 Janneke Nieuwenhuizen ;;; @@ -64,6 +65,7 @@ (define-module (gnu packages lisp) #:use-module (guix build-system gnu) #:use-module (guix build-system haskell) #:use-module (guix build-system trivial) + #:use-module ((guix search-paths) #:select ($SSL_CERT_DIR $SSL_CERT_FILE= )) #:use-module (gnu packages admin) #:use-module (gnu packages algebra) #:use-module (gnu packages autotools) @@ -919,6 +921,77 @@ (define-public janet assembler, PEG) is less than 1MB.") (license license:expat))) =20 +(define-public jpm + (package + (name "jpm") + (version "1.1.0") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/janet-lang/jpm") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 "05rdxigmiy7vf93s16a8n2029lq33073jccz1rjl4iisxj6piw4l")))) + (build-system copy-build-system) + (arguments + (list + #:phases #~(modify-phases %standard-phases + (add-after 'unpack 'fix-paths + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "configs/linux_config.janet" + (("/usr/local") + #$output) + (("\"cc\"") + (string-append "\"" + (search-input-file inputs "/bin/g= cc") + "\"")) + (("\"c\\+\\+\"") + (string-append "\"" + (search-input-file inputs "/bin/g= ++") + "\"")) + (("\"git\"") + (string-append "\"" + (search-input-file inputs "/bin/g= it") + "\"")) + (("\"curl\"") + (string-append "\"" + (search-input-file inputs "/bin/c= url") + "\""))) + (substitute* "jpm/shutil.janet" + (("cp") + (string-append (search-input-file inputs "/bin/c= p")))) + (setenv "PREFIX" + #$output))) + (replace 'install + (lambda _ + (for-each (lambda (dir) + (mkdir-p (string-append #$output "/" di= r))) + '("lib/janet/jpm" "share/man/man1")) + (invoke "janet" "bootstrap.janet" + "configs/linux_config.janet") + (wrap-program (string-append #$output "/bin/jpm") + `("JANET_HEADERPATH" ":" =3D + (,(string-append #$janet "/include/janet"))) + `("JANET_LIBPATH" ":" =3D + (,(string-append #$janet "/lib"))))))))) + (inputs (list bash-minimal + coreutils-minimal + curl + gcc + git-minimal/pinned)) + (propagated-inputs (list janet)) + (native-search-paths + (list $SSL_CERT_DIR $SSL_CERT_FILE)) + (home-page "https://janet-lang.org/") + (synopsis "Janet Project Manager for the Janet programming language") + (description + "@code{jpm} is the Janet Project Manager tool. It is a build +tool and its main uses are installing dependencies, compiling C/C++ to nat= ive +libraries, and other management tasks for Janet projects.") + (license license:expat))) + (define-public lisp-repl-core-dumper (package (name "lisp-repl-core-dumper") From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 05 17:31:12 2025 Received: (at 72925) by debbugs.gnu.org; 5 Jan 2025 22:31:12 +0000 Received: from localhost ([127.0.0.1]:35726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUZ9M-000807-2x for submit@debbugs.gnu.org; Sun, 05 Jan 2025 17:31:12 -0500 Received: from mail-qt1-x844.google.com ([2607:f8b0:4864:20::844]:61440) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tUZ9J-0007zu-3G for 72925@debbugs.gnu.org; Sun, 05 Jan 2025 17:31:10 -0500 Received: by mail-qt1-x844.google.com with SMTP id d75a77b69052e-467a37a2a53so169642191cf.2 for <72925@debbugs.gnu.org>; Sun, 05 Jan 2025 14:31:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736116268; x=1736721068; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:in-reply-to :subject:to:from:from:to:cc:subject:date:message-id:reply-to; bh=0ZlKn2Hgndbawu/M/HUtuyHym9j/CljB0id0CwkGC7g=; b=G9SeYVfnGZtq7PxgrvBsUiOwHWPdrZAMgWlvYOG7qIVCeu1MqepTGExG5rTlP5Ojsv 7+jgOIwbEcLKZ/giLZbZJLq87fj8L4tRF09Hm33jNUpk0mDKB3LpP8MlgZEgzJAkXOZe /NkQ/vXCjMjBSlIHShr+Dq0UoxKhfr7oP7zDcwAcCnd6PqYysOxnkjnSSsDCMQ67dM6f KU0g78TVjfp4cQVqn5v/0XC/7XNMhcs3xhkPJu43ySLG8yu121IT4EEcIohqKhIXsPHJ tmG21jn1K5ZBPk29n1EU9ggv62clOyLro3tbS9legTO0QgCdlmK+/YF3lhhZ6teWIICm eLww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736116268; x=1736721068; h=content-transfer-encoding:mime-version:message-id:date:in-reply-to :subject:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0ZlKn2Hgndbawu/M/HUtuyHym9j/CljB0id0CwkGC7g=; b=KCCcPF4F1e7P29GLDuDtYIBfu1BwL5lQzf6yvaD74TyoEhR6r7ZVoTUnSFq8OI+3wd uTUMzOfSp+ElQWuzwSYP7E1qqJpp4SVcZwFQF52igiy2FNY40HlPxgwob1QRr7VtxwKp pR2P38mmQfCVztKKAODn6glLI9dbxRe5/NHrM9eg6ORqcYNwXLf1t5ywZUG/f7y4EzQM EyVGkyfvAapE71A+ttY30419z+QWajQfQs/l9JuVVb44hGDnZqEeUDb3kAaJtymanKOo WV/k6QpTitUortIBcKD0IxCaZAGYJEKoGNAr/m/Bnolov0+JFKQdlUaOcwtikz/eMqFf dUhQ== X-Gm-Message-State: AOJu0Yy9fi/T6HVnQU0qtc5Xc1XrerJzD2KUdtSG7knGeuE6n0FkmKcI 9Qr9f5tIavRjwkqqrCNT12+x1kj4dNHGDkOlrPZDwBm9sLBLyMScnsNcnWkj X-Gm-Gg: ASbGnctFGBwFS9qgKwhxqtGBtwKZvdqQxJ6UkvmZG8IH4rd58WDF03lM/OYeEoLIhvM XCd0M1OXBifWaOUHEykUT2ExCMs2kDmjrg31El5l7hg036dRv1d2MvbOUB6/pVOmoggfg1niDp0 PRXMEYZ50Ufa+kQ1cZYAcqIJr2YKIrMhK0rwG6Cjm//iXm4wlvZsOtAhVuDGWalpkrWsMWU4Wto xmGe2r6OCYxjYYpQyKHvSa8gPV7Re0dgbyh1RGv0wUzeQxoHHMA X-Google-Smtp-Source: AGHT+IEAnORCsJXeqsMmHyGM0zuFpGNXHAUpd8Hk81GhnObYNFTIMtoWC8+1Zhb5m/qHEYeoMelQpQ== X-Received: by 2002:a05:622a:14c:b0:460:aa51:840a with SMTP id d75a77b69052e-46a4a9a2914mr736728261cf.45.1736116267751; Sun, 05 Jan 2025 14:31:07 -0800 (PST) Received: from gnus ([70.26.179.129]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-46a3e67773esm169676501cf.21.2025.01.05.14.31.06 for <72925@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jan 2025 14:31:07 -0800 (PST) From: "Suhail Singh" To: 72925@debbugs.gnu.org Subject: [PATCH v14 2/2] gnu: Improve user-experience for jpm. In-Reply-To: Date: Mon, 7 Oct 2024 23:22:13 -0400 X-Debbugs-Cc: Guillaume Le Vaillant , Katherine Cox-Buday , Munyoki Kilyungi , Sharlatan Hellseher , jgart Message-Id: <68d09c78846a198ba4499f89f53e4b3782208c9d.1736116108.git.suhail@bayesians.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 2.3 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * gnu/packages/lisp.scm (jpm): Ensure jpm respects JANET_HEADERPATH and JANET_LIBPATH if set by user. Ensure gcc/g++ is able to find header files and compilation-related utilities. Change-Id: Ic7218dbd10e6fabddded50894b82492de8cabc88 --- gnu/packages/lisp.scm | 32 +++++++++++++++++++++++++------- 1 file changed, 25 insertions(+), 7 deletions(-) Content analysis details: (2.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (suhailsingh247[at]gmail.com) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (suhailsingh247[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 2.1 DATE_IN_PAST_96_XX Date: is 96 hours or more before Received: date -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:844 listed in] [list.dnswl.org] X-Debbugs-Envelope-To: 72925 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * gnu/packages/lisp.scm (jpm): Ensure jpm respects JANET_HEADERPATH and JANET_LIBPATH if set by user. Ensure gcc/g++ is able to find header files and compilation-related utilities. Change-Id: Ic7218dbd10e6fabddded50894b82492de8cabc88 --- gnu/packages/lisp.scm | 32 +++++++++++++++++++++++++------- 1 file changed, 25 insertions(+), 7 deletions(-) Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:844 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (suhailsingh247[at]gmail.com) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (suhailsingh247[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 2.1 DATE_IN_PAST_96_XX Date: is 96 hours or more before Received: date -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager * gnu/packages/lisp.scm (jpm): Ensure jpm respects JANET_HEADERPATH and JANET_LIBPATH if set by user. Ensure gcc/g++ is able to find header files = and compilation-related utilities. Change-Id: Ic7218dbd10e6fabddded50894b82492de8cabc88 --- gnu/packages/lisp.scm | 32 +++++++++++++++++++++++++------- 1 file changed, 25 insertions(+), 7 deletions(-) diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm index f99ad68828..eb3063d3d9 100644 --- a/gnu/packages/lisp.scm +++ b/gnu/packages/lisp.scm @@ -30,6 +30,7 @@ ;;; Copyright =C2=A9 2024 bigbug ;;; Copyright =C2=A9 2024 Ashish SHUKLA ;;; Copyright =C2=A9 2024 Omar Bassam +;;; Copyright =C2=A9 2024 Suhail Singh ;;; Copyright =C2=A9 2024 David Pflug ;;; Copyright =C2=A9 2024 Janneke Nieuwenhuizen ;;; @@ -965,22 +966,39 @@ (define-public jpm (setenv "PREFIX" #$output))) (replace 'install - (lambda _ + (lambda* (#:key inputs #:allow-other-keys) (for-each (lambda (dir) (mkdir-p (string-append #$output "/" di= r))) '("lib/janet/jpm" "share/man/man1")) (invoke "janet" "bootstrap.janet" "configs/linux_config.janet") - (wrap-program (string-append #$output "/bin/jpm") - `("JANET_HEADERPATH" ":" =3D - (,(string-append #$janet "/include/janet"))) - `("JANET_LIBPATH" ":" =3D - (,(string-append #$janet "/lib"))))))))) + (let ((gcc-toolchain (assoc-ref inputs "gcc-toolcha= in")) + (core-min (assoc-ref inputs "coreutils-minima= l"))) + (wrap-program (string-append #$output "/bin/jpm") + `("JANET_HEADERPATH" ":" prefix + (,(string-append #$janet "/include/janet"))) + `("JANET_LIBPATH" ":" prefix + (,(string-append #$janet "/lib"))) + `("C_INCLUDE_PATH" ":" prefix + (,(string-append gcc-toolchain "/include"))) + `("CPLUS_INCLUDE_PATH" ":" prefix + (,(string-append gcc-toolchain "/include/c++") + ,(string-append gcc-toolchain "/include"))) + `("LIBRARY_PATH" ":" prefix + (,(string-append gcc-toolchain "/lib") + ,(string-append gcc-toolchain "/lib64"))) + `("PATH" ":" prefix + (,(string-append gcc-toolchain "/bin") + ,(string-append core-min "/bin")))))))))) (inputs (list bash-minimal coreutils-minimal curl gcc - git-minimal/pinned)) + git-minimal/pinned + ;; Lazily resolve the gcc-toolchain to avoid a circular + ;; dependency. + (module-ref (resolve-interface '(gnu packages commenceme= nt)) + 'gcc-toolchain))) (propagated-inputs (list janet)) (native-search-paths (list $SSL_CERT_DIR $SSL_CERT_FILE)) From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 05 17:39:32 2025 Received: (at 72925) by debbugs.gnu.org; 5 Jan 2025 22:39:32 +0000 Received: from localhost ([127.0.0.1]:35738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUZHP-0008N1-Dg for submit@debbugs.gnu.org; Sun, 05 Jan 2025 17:39:31 -0500 Received: from mail-qv1-xf44.google.com ([2607:f8b0:4864:20::f44]:50488) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tUZHK-0008Mb-B6 for 72925@debbugs.gnu.org; Sun, 05 Jan 2025 17:39:29 -0500 Received: by mail-qv1-xf44.google.com with SMTP id 6a1803df08f44-6dd420f82e2so91173196d6.1 for <72925@debbugs.gnu.org>; Sun, 05 Jan 2025 14:39:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736116760; x=1736721560; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=nq4vnSakM0YnxzIY/+jUBxJA6dGYoGgSg7tdzX0JblI=; b=eANyQmODj5SVvjr1CMzjzly1+/hogt2qVWUwpxSjGmXa5i9aBGbWOd31Gxb8/Yx9jM 7j/v78LgJXwoI9QrY3KIxHQdJ8Yz9Kp+athlJXlRTIj2+gJkz1AdD3/8TrtpCaqX6X2R X8sZ488ZD6+vLeQQVDoL3TFfUE5w/C1RbsAi1FXLAsNz1XOLTqwHj/I0SU4wPdhUwsoO lK7yrQ1ygoDNxm2qenLuTkDhdlpGGTQZUd593FkKuoqFxc1nBrfrKpv5+FhFvZIb1nph wNqGnT9EUN3KwgJoHWSxeqj/4bJdDQWhBZ+wOR6+5iKoc21f14Y75bnFtUo+GHBW1oef Wo9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736116760; x=1736721560; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nq4vnSakM0YnxzIY/+jUBxJA6dGYoGgSg7tdzX0JblI=; b=PGjbAoH02CNOW2g+FqkSYqwD/QwQJ2bhpHUoOMl1n1PCmt0QphzganpTHbDZlexCOZ FqzK6A6pcc2fkSFY76tYVfbwX6wZZ33NvM99L6+D38sCPndSE8uqcXuEal5eQqpP/7Bg 0zn6P0EjvdIQfopL6wMw3Pn/2ZF5WYHIQbS2gT2EGbeEdya+06btxOgyax1xOKt6KkcA hxnAGLVKKtXO+wfnUd95aYbIh5ZhU6UpfwsSPcarVvZL2ZCKFF4h0hCd+sDlDHcrsJsS j1/xhuZAfEqKKd5j6DCWlBXMNep4o0L93ylidHjqJXUYRt2DtDmcI/z8xifovWu1o/Nm lMiA== X-Forwarded-Encrypted: i=1; AJvYcCVJekgpPJbNe78t8dvqNbsyPk9mQSHgltQSsKUvCSnFcaCf84uvb3InkrF7nFR7tlxQU+sA1w==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxrqzHRBsWBNIP+o5/aiJ1EGe4rcWxRhcPLKUnplsMUxs+LyAbZ FLLER+Z/vO70Tq+Rx4bl8zJFQ4TpK/xK/cNjhKLs5c5pF2b6lde3 X-Gm-Gg: ASbGncttam9dJZeS+Ie6Gz7ojVNtkGYJC1YR6nt0mHv9TaLzx2X89+HsR2eZa5sNHUv NimYVTlTXEa3mzqcTiHA6GrtP0bM2AeR+p4C/9AdlPsrJfWgGM2ycfsFbUnGMZv/HwrS2fnXD5X dHK7TOYLvcoKL8TfrbzTZg/lCM+0pbN7p4cGomSoPFpVYoo9S3IE0qyv5TKSD1qQBlJEg0R+8aZ JfGg/8OXGAA7W9YWX/8qqnP4mPRGuQon9sN/J+l6zIiO403Amsz X-Google-Smtp-Source: AGHT+IHay9BfZXJVBMRg3v2z517JP7w6DSK5ooQ6JeAWiZ8R2tQ8k445LctZhJKWaMwuuPLYovCBhQ== X-Received: by 2002:a05:6214:d89:b0:6d4:1ea3:981d with SMTP id 6a1803df08f44-6dd233a2bccmr806959826d6.43.1736116760423; Sun, 05 Jan 2025 14:39:20 -0800 (PST) Received: from gnus ([70.26.179.129]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6dd18137367sm164607196d6.65.2025.01.05.14.39.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jan 2025 14:39:19 -0800 (PST) From: Suhail Singh To: "jgart" Subject: Re: Adding JPM package for Janet In-Reply-To: (jgart@dismail.de's message of "Sun, 05 Jan 2025 21:22:29 +0000") References: <87ed1hcjhw.fsf@gmail.com> <87zfk5gp79.fsf@gmail.com> <874j2dt16v.fsf@gmail.com> Date: Sun, 05 Jan 2025 17:39:08 -0500 Message-ID: <87zfk4sx6b.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: 72925@debbugs.gnu.org, Omar Bassam , =?utf-8?Q?Ludovic_Cou?= =?utf-8?Q?rt=C3=A8s?= , Suhail Singh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) "jgart" writes: > Did you also test that sh and spork successfully load in a janet REPL > via some require or loading command? Yes. See v14 (rebased onto recent master) cover letter [1] for details. > Note, that I am not a Janet user. Likewise. [1]: -- Suhail From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 05 18:00:21 2025 Received: (at 72925) by debbugs.gnu.org; 5 Jan 2025 23:00:22 +0000 Received: from localhost ([127.0.0.1]:35785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUZbZ-000227-EL for submit@debbugs.gnu.org; Sun, 05 Jan 2025 18:00:21 -0500 Received: from mx1.dismail.de ([2a01:4f8:c17:e5e::2]:30801) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tUZbN-0001ve-JC for 72925@debbugs.gnu.org; Sun, 05 Jan 2025 18:00:18 -0500 Received: from mx1.dismail.de (localhost [127.0.0.1]) by mx1.dismail.de (OpenSMTPD) with ESMTP id e29ea5e2; Sun, 5 Jan 2025 23:59:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h= mime-version:date:content-type:from:message-id:subject:to:cc :in-reply-to:references; s=20190914; bh=YjO6ZNX2gdaBGUiU3f9puaYC bdfLljSCBHuVhIq+cpE=; b=Dbd9r2Vupoo4LPDsLDN4oYdsA60WTE8G/AyPwZwN eGCu20DOa3wxsoGdaiPK8DKE3Tmc9xPtvFVq30MKXTNgisuvCXlhugmFNw7N7HE4 ExjMD7yFt+FYv+Rl10BgABf6wJ7nget0ENeEd0z/O1wE8D9bF/JnGM5h9GJy6GO8 bmTE9VXV+EP0K6kfsyrX3iUWD4pzc+HS7JfDfyY7UU6uK2PpmBxiLjBqYSn8S66b vmhhFFWFvmIyow05hQybru9HCm1++S3qNFQ8v5Q9Y5V51KPHK90rk0iRzyKvYjTo CX46uv/FvAyzCbo26m0V2oJY2puTCqsGe2CsKi9TggI8ZA== Received: from smtp2.dismail.de ( [10.240.26.12]) by mx1.dismail.de (OpenSMTPD) with ESMTP id d88764b9; Sun, 5 Jan 2025 23:59:54 +0100 (CET) Received: from smtp2.dismail.de (localhost [127.0.0.1]) by smtp2.dismail.de (OpenSMTPD) with ESMTP id c8a4983b; Sun, 5 Jan 2025 23:59:53 +0100 (CET) Received: by dismail.de (OpenSMTPD) with ESMTPSA id 9c45c78c (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sun, 5 Jan 2025 23:59:53 +0100 (CET) MIME-Version: 1.0 Date: Sun, 05 Jan 2025 22:59:53 +0000 Content-Type: multipart/alternative; boundary="e1a2f2f6-857a-4634-aa18-d0f0090c6208-1" From: "jgart" Message-ID: <809ce5dd52cb5168d8f62062a44f9b0cb8b5fbaa@dismail.de> TLS-Required: No Subject: Re: Adding JPM package for Janet To: "Suhail Singh" In-Reply-To: <87zfk4sx6b.fsf@gmail.com> References: <87ed1hcjhw.fsf@gmail.com> <87zfk5gp79.fsf@gmail.com> <874j2dt16v.fsf@gmail.com> <87zfk4sx6b.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72925 Cc: 72925@debbugs.gnu.org, Omar Bassam , =?utf-8?B?THVkb3ZpYyBDb3VydMOocw==?= , Suhail Singh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --e1a2f2f6-857a-4634-aa18-d0f0090c6208-1 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Ok, can you resend patch v14? I'm not sure what happened but `mumi am -- -s` cannot apply it and says t= hat the patch is empty. Did you send the last version with `git send-email` or by some other mean= s? all best, jgart --e1a2f2f6-857a-4634-aa18-d0f0090c6208-1 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable
Ok, can you resend patch v14= ?

I'm not sure what happened but `mumi am --= -s` cannot apply it and says that the patch is empty.

=
Did you send the last version with `git send-email` or by some= other means?

all best,

jgart
--e1a2f2f6-857a-4634-aa18-d0f0090c6208-1-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 05 18:28:03 2025 Received: (at 72925) by debbugs.gnu.org; 5 Jan 2025 23:28:03 +0000 Received: from localhost ([127.0.0.1]:35889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUa2N-0003UA-8T for submit@debbugs.gnu.org; Sun, 05 Jan 2025 18:28:03 -0500 Received: from mail-qt1-x843.google.com ([2607:f8b0:4864:20::843]:43049) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tUa2I-0003TV-6e for 72925@debbugs.gnu.org; Sun, 05 Jan 2025 18:28:01 -0500 Received: by mail-qt1-x843.google.com with SMTP id d75a77b69052e-4678afeb133so126034741cf.0 for <72925@debbugs.gnu.org>; Sun, 05 Jan 2025 15:27:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736119672; x=1736724472; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=MAnYu72Spx7h+2jo4FCHa0UUcaqd6iWDdjeazk6/3mE=; b=O5gNVRzUSina1whpETrKsJYLMAxvcryKIXF58suBGtbct1o19mqF+OtwJBIyLBINY5 Ug+GIABSwgt7/un6ShRXRL3cMz9qnOFJh1vLL1PGsEaAsjcl3y7rq1GMp0zo0jjgCCYA LwK1dFnuHHBxJDQTiRYtJ3jQr5yCaDDBHQj/2LKu6Y1gxlg1AH5obtMnoDlKRUybQLmI UlFRRvmiWqGH+LSAtOH5+qCEMupZHJ5VB5VGhRXmWjeFLA06iINrvFktB32hriqlEyKz b/Cy2I2INntpjGsSizn7d/mUwnnnm6FXcnR8/VhzIG6hYsYl2yPnLflYNkJzSbXAOFXO e0nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736119672; x=1736724472; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MAnYu72Spx7h+2jo4FCHa0UUcaqd6iWDdjeazk6/3mE=; b=YDID7e/L03QfS37Y56J4iD7cRZtmNAzQWk8p1wZohQTT5TsANeTVrCReefZfzwxRSo HE9Gwwkz9TVHcdVBKfGVL0HxglSM0nrS0Yug03tb47/EcYI+KVKuVMhJmW+62AmuLi/E t32TJv+lfPd/qJPxh6MUdF+0JHeHey6kcz7ADWIBt7+kPRQ1CPfdE4V7FE/bJsn5nL/l 42ugswxsNtxT6YsXWtQ8quFTcQMuTi9W/kSEpcAeJ2fvE+3V8P7ukF++ahtciVYxDCWM wzm0lNJuX/WCF1AAH/OD96QXztWj3UlaVq56zxkq72SsCnl3tBlQLv3vPkztLNe274a0 X/+Q== X-Forwarded-Encrypted: i=1; AJvYcCUWTlGRXtPI6uAHG5o7AARR/5afNgQT/GdqzOz3mEWtppcaNQyY+7NI6W4b8ta9E0UgLcM7Wg==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yw12OFp9HUjhrKm8OxZCvPqW85BfqCVGBZgP7Rv7/szI62B15an FhkalDr7bsQPCsz8X6o4XU0D2Q9ejNaTpi20d6YAmUTwtq2MtigANeUWkgKA X-Gm-Gg: ASbGncuC9VHE0LRtm2UHWR4Zd87v1LwO/HYWpFZ7YCNKKfZHm/t2S9Xr+bN4hIKTz/U xeyBURA4BGyw994tODj22uLacWmsPtYNNJ6DFB5aEliIhkFreegFi9rFC0PvhBh+DWObTlTHfJ8 WWgs6b2iFvtMxImq9WpmKIMvuKU4VE0y+k7ViWwOC2dsTDyofFAQBz0SqG6mg5+aalS4BBx00cZ 5fGfZHcukpmNyKvT1rsyLOH70CPcZcsnzBQilICOyTjAusMJTVe X-Google-Smtp-Source: AGHT+IF9GoVJdStFSTB+kPSXzVBO59SerqVUPTJpNZKWSpOi8r42m9MAJWU7+VbVSFei0jXHpZYKaQ== X-Received: by 2002:a05:622a:345:b0:466:8f43:4aa8 with SMTP id d75a77b69052e-46a3af9ec65mr918503311cf.7.1736119672471; Sun, 05 Jan 2025 15:27:52 -0800 (PST) Received: from gnus ([70.26.179.129]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-46b2b6b70desm13496181cf.79.2025.01.05.15.27.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jan 2025 15:27:52 -0800 (PST) From: Suhail Singh To: "jgart" Subject: Re: Adding JPM package for Janet In-Reply-To: <809ce5dd52cb5168d8f62062a44f9b0cb8b5fbaa@dismail.de> (jgart@dismail.de's message of "Sun, 05 Jan 2025 22:59:53 +0000") References: <87ed1hcjhw.fsf@gmail.com> <87zfk5gp79.fsf@gmail.com> <874j2dt16v.fsf@gmail.com> <87zfk4sx6b.fsf@gmail.com> <809ce5dd52cb5168d8f62062a44f9b0cb8b5fbaa@dismail.de> Date: Sun, 05 Jan 2025 18:27:40 -0500 Message-ID: <87a5c4yh77.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: 72925@debbugs.gnu.org, Omar Bassam , =?utf-8?Q?Ludovic_Cou?= =?utf-8?Q?rt=C3=A8s?= , Suhail Singh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) "jgart" writes: > Ok, can you resend patch v14? I can, but I don't think it will help. See below. > I'm not sure what happened but `mumi am -- -s` cannot apply it and > says that the patch is empty. There's a bug in mumi. I recall encountering this issue with prior versions posted by Omar in this issue as well. My hypothesis is that some past message in 72925 triggers the bug in mumi. In the past (when I encountered this in #72925) I worked around by applying the patches manually via magit-dired-am-apply-patches . One option would be to close 72925 and start a new issue. Let me know if you'd like me to do so. > Did you send the last version with `git send-email` or by some other > means? I sent via gnus, which is how I've contributed previous patches to Guix. -- Suhail From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 05 20:05:46 2025 Received: (at 72925) by debbugs.gnu.org; 6 Jan 2025 01:05:46 +0000 Received: from localhost ([127.0.0.1]:36016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUbYv-0008L4-UD for submit@debbugs.gnu.org; Sun, 05 Jan 2025 20:05:46 -0500 Received: from mx1.dismail.de ([78.46.223.134]:3527) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tUbYu-0008Ko-1w for 72925@debbugs.gnu.org; Sun, 05 Jan 2025 20:05:45 -0500 Received: from mx1.dismail.de (localhost [127.0.0.1]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 3171f1b2; Mon, 6 Jan 2025 02:05:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h= mime-version:date:content-type:from:message-id:subject:to:cc :in-reply-to:references; s=20190914; bh=Xf+dF96ptk8DvpA8dbWhcTfQ /C/iXr8byHFzE8l+tpo=; b=k9VXk9Ld/n/6ARV6ladtMBdAvEZsMNYLLLk15dLr QaKlYNn2Mx2sjVKDE2PydPNMq8U4YdmRLNxN+pvSdlgz7cp3c70sR+80ocUVwZLE ovCluszLbcc2Thov4Tw/UTVSoG9Vir6GdTxAGNwr9X/8r/+n+xX8hREZAft1b+ph 899ENHP19FVfptVNSCcjSnZiCytgYBTWNIu2p+yufAEOIxlL5D1eAu2DavfLsPcN BAMzK+lUaQ+la9x/NutDZDmRymULosDrp4RP8POSXH98EejNLe1h+LDtSh2qno2j ubfbnQlS+UVBL1rYfr4wbTQAc8U9zUo91Kt8OzcJe6/rAg== Received: from smtp1.dismail.de ( [10.240.26.11]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 2472266d; Mon, 6 Jan 2025 02:05:34 +0100 (CET) Received: from smtp1.dismail.de (localhost [127.0.0.1]) by smtp1.dismail.de (OpenSMTPD) with ESMTP id 4516d79e; Mon, 6 Jan 2025 02:05:34 +0100 (CET) Received: by dismail.de (OpenSMTPD) with ESMTPSA id 89ed77ad (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 6 Jan 2025 02:05:34 +0100 (CET) MIME-Version: 1.0 Date: Mon, 06 Jan 2025 01:05:33 +0000 Content-Type: multipart/alternative; boundary="faa3df10-bd4c-4289-8489-a4978ef3c113-1" From: "jgart" Message-ID: <11be729cce0b193ddb3882df02260bbf7389e9d0@dismail.de> TLS-Required: No Subject: Re: Adding JPM package for Janet To: "Suhail Singh" In-Reply-To: <87a5c4yh77.fsf@gmail.com> References: <87ed1hcjhw.fsf@gmail.com> <87zfk5gp79.fsf@gmail.com> <874j2dt16v.fsf@gmail.com> <87zfk4sx6b.fsf@gmail.com> <809ce5dd52cb5168d8f62062a44f9b0cb8b5fbaa@dismail.de> <87a5c4yh77.fsf@gmail.com> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 72925 Cc: 72925@debbugs.gnu.org, Omar Bassam , =?utf-8?B?THVkb3ZpYyBDb3VydMOocw==?= , Suhail Singh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --faa3df10-bd4c-4289-8489-a4978ef3c113-1 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable >=20 >=20One option would be to close 72925 and start a new issue. Let me know > if you'd like me to do so. >=20 Yes,=20can you send those two patches in a new issue? I tried applying it= manually just now but it doesn't apply. Don't close this issue. I'll reference the new issue here and close both = after I review it and merge if good. all best, jgart --faa3df10-bd4c-4289-8489-a4978ef3c113-1 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable
One option would be t= o close 72925 and start a new issue. Let me know

if you'd = like me to do so.


Yes, can you= send those two patches in a new issue? I tried applying it manually just= now but it doesn't apply.

Don't close this = issue. I'll reference the new issue here and close both after I review it= and merge if good.

all best,
=
jgart

--faa3df10-bd4c-4289-8489-a4978ef3c113-1-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 05 20:33:19 2025 Received: (at 72925) by debbugs.gnu.org; 6 Jan 2025 01:33:19 +0000 Received: from localhost ([127.0.0.1]:36072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUbzb-0001B6-3Y for submit@debbugs.gnu.org; Sun, 05 Jan 2025 20:33:19 -0500 Received: from mail-qt1-x841.google.com ([2607:f8b0:4864:20::841]:57663) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tUbzZ-0001Ap-2b for 72925@debbugs.gnu.org; Sun, 05 Jan 2025 20:33:17 -0500 Received: by mail-qt1-x841.google.com with SMTP id d75a77b69052e-46785fbb949so130210421cf.3 for <72925@debbugs.gnu.org>; Sun, 05 Jan 2025 17:33:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736127191; x=1736731991; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=XNwQz2VzMCDCaEgfPCKAKK4q1u6sN65CIpBCptJZ3HM=; b=ANxlThWyH/yBmxVPg5fuH2sXFflPl5TtfhcHPOUvVFq3uHh1aQiyHAuwICKlmFjsUA oBtCSGiQ3R3l8I2Kz5ZJxcHO+RKy2yQ6ldXhtRj1K+7O05alW7vrf9epZx6OiaWc1Bpu X7Ksrbn8pS56nhjzPcDdtfGOKXCyJ8nXCIT8aiQTKmK8AEwqbq5SwOMJlH1H+oat8bSd 4ZpGROik+67v3Pt0+1wFOgXVjFtFAjY8dvPb+H1B9nENqnZ2fKPqqoxcbFsnzw07TPwj SYhZ3olXOF6H0UVDJUD7lG5teeNh5MD8WVcVOUpVLSieSWg+ITMJIfP5K1I+rr+fBUeS qy3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736127191; x=1736731991; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XNwQz2VzMCDCaEgfPCKAKK4q1u6sN65CIpBCptJZ3HM=; b=E7y7NEOAD97CEGsmvJ0zZgkS9U7v6I0/N5WqR9jSVJE5vfnsQ6+1kzgk1+N6FDoh+a 9Wv72cYKY8jIWUx7R4ORpKF7+4zMC0sbhcR5QSbN8WgJXidhMui/eYK3uwn01OepLwyy rjirQPuqcJIzDPbdpuCtSMOMvUlPHQnIAF9g0vJEw90Dw+hsC8k7HGAadOqWcq0xE8ZG A2pUDH/knKA4z9bBWgxdQirYyraqMu0RSyhqLDV9v9EvraHaIGndtuwy3h0nkswe31cS hCWjfQM6Z3xkeUdWL2iebKmeBb2IvtFvQglMMWru6sMTkxKm70tfOj8EB0/GDMc6eqVz dXXw== X-Forwarded-Encrypted: i=1; AJvYcCXMEKVQ4QLhas5zL+0Q4bwVW+xX3vs+w81caRvR9oUQ/hxq3kzHz16dz6RgmeTQHtZuNV+RjQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yx7YxJ0PqdNL8OsT3P3LtkexioZX3F+tkko3C6O36HHIJkXdJeT lfSpuLGXhziFZ86SeCbvc7QAohUdXFD1JTAE6XyT47ZMrf/CfALP X-Gm-Gg: ASbGncskVYxOqnh4EIjoQlmD53yYR/8C42dM5G45ocFkp5bGeh3Sn6L2hQJSzzpx1oz 2h+L4rZz1vLh94X3j2Rj2Ubbzsj6XZ0byKvbTy4duC2UD6atQvrPlwlZJzZX0Dr7UKYQcrh1epF jQXhj/nRpDgQAoyPbrU8N84byILRNHUj0/8niFdXGUGUMnAVV7LQZ21T9qSkMHelY6UaPf+dJex SHlKv5KeeCa10gPhf+GHQ7IMSiuBKFKWHghAxPDv9AqFx56CyhspgkQ3LAZlf1AFjuU/gZJl+eb ov2PV7PeSbQf6y2TxQ== X-Google-Smtp-Source: AGHT+IFkygNnxBUuIWyZuydiEsXX0eW4hElZtvA/gDEoXVKrYgqCHwMEq9wbyqbPL9gSfg+5bPJHXw== X-Received: by 2002:ac8:5854:0:b0:467:6e45:218d with SMTP id d75a77b69052e-46a4a8af764mr868592631cf.3.1736127191428; Sun, 05 Jan 2025 17:33:11 -0800 (PST) Received: from gnus (mtrlpq0776w-70-26-179-129.dsl.bell.ca. [70.26.179.129]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-46a3e6a106fsm170612571cf.38.2025.01.05.17.33.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jan 2025 17:33:10 -0800 (PST) From: Suhail Singh To: "jgart" Subject: Re: Adding JPM package for Janet In-Reply-To: <11be729cce0b193ddb3882df02260bbf7389e9d0@dismail.de> (jgart@dismail.de's message of "Mon, 06 Jan 2025 01:05:33 +0000") References: <87ed1hcjhw.fsf@gmail.com> <87zfk5gp79.fsf@gmail.com> <874j2dt16v.fsf@gmail.com> <87zfk4sx6b.fsf@gmail.com> <809ce5dd52cb5168d8f62062a44f9b0cb8b5fbaa@dismail.de> <87a5c4yh77.fsf@gmail.com> <11be729cce0b193ddb3882df02260bbf7389e9d0@dismail.de> Date: Sun, 05 Jan 2025 20:33:09 -0500 Message-ID: <8734hwybe2.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72925 Cc: 72925@debbugs.gnu.org, Omar Bassam , =?utf-8?Q?Ludovic_Cou?= =?utf-8?Q?rt=C3=A8s?= , Suhail Singh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) "jgart" writes: > Yes, can you send those two patches in a new issue? Please see #75394. Hopefully it applies cleanly. Please let me know in case there are still issues. -- Suhail From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 05 21:16:32 2025 Received: (at 72925-done) by debbugs.gnu.org; 6 Jan 2025 02:16:33 +0000 Received: from localhost ([127.0.0.1]:36169 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUcfQ-0003ig-Lz for submit@debbugs.gnu.org; Sun, 05 Jan 2025 21:16:32 -0500 Received: from mx1.dismail.de ([78.46.223.134]:21556) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tUcfO-0003iK-Mm for 72925-done@debbugs.gnu.org; Sun, 05 Jan 2025 21:16:31 -0500 Received: from mx1.dismail.de (localhost [127.0.0.1]) by mx1.dismail.de (OpenSMTPD) with ESMTP id a2426af8; Mon, 6 Jan 2025 03:16:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h=from:to:cc :subject:in-reply-to:date:message-id:mime-version:content-type; s=20190914; bh=5WyFwgXcSLuRUetpGTlpsyJM0KwGKXAWWuwAiH2giWw=; b= MCquDvS1eV9Ibap7A++KMw2eK5iHXiYcwKUq9l5gl5KHovwXJ5Ig7xae/OTvSFzj o11MvImgxa+oO7srTxDymffS2WCP7wDbNFyRy81UQtJ8PPZEX9nblH9lhdnzNrFJ Eht3EHIy1iyaa6hfdhMNSddUScEektsbnMMe4jgylLVUbna4ReCs/R4iO77HxbDv s3DcLr7YxnMnjp0ieUZ74WRXMwVL7lSnO4Scgeqf/0pbVfxJs7wgwageUUDpCfye 3H3Tabu9+X5WoVfI5WOcGJ95tFQ+snmub4z0WEP0UBJ09tPDBgP3tr2UYf5gyUzw EfPBmGbS0CXZ45zMksedCg== Received: from smtp2.dismail.de ( [10.240.26.12]) by mx1.dismail.de (OpenSMTPD) with ESMTP id d5890dda; Mon, 6 Jan 2025 03:16:22 +0100 (CET) Received: from smtp2.dismail.de (localhost [127.0.0.1]) by smtp2.dismail.de (OpenSMTPD) with ESMTP id b72c9eca; Mon, 6 Jan 2025 03:16:22 +0100 (CET) Received: by dismail.de (OpenSMTPD) with ESMTPSA id 201f9baa (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 6 Jan 2025 03:16:22 +0100 (CET) From: jgart To: 72925-done@debbugs.gnu.org Subject: Re: Adding JPM package for Janet In-Reply-To: <8734hwybe2.fsf@gmail.com> Date: Sun, 05 Jan 2025 20:16:19 -0600 Message-ID: <871pxgsn4c.fsf@dismail.de> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 72925-done Cc: Ludovic =?utf-8?Q?C?= =?utf-8?Q?ourt=C3=A8s?= , Omar Bassam , jgart , Suhail Singh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Thanks, applied from ticket 75394. -- all the best, jgart From unknown Sat Jun 21 02:42:53 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 03 Feb 2025 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator