Subject: [bug#72920] [PATCH 2/3] services: cleanup: Create directories with the right mode upfront.

From: Ludovic Courtès <[email-masked]>
Date: Wed, 25 Sep 2024 18:14:20 +0200

Hi Hilton,

Hilton Chain <[email-masked]> skribis:

[...]

>> -           (mkdir "/tmp")
>> -           (chmod "/tmp" #o1777)
>> -           (mkdir "/var/run")
>> -           (chmod "/var/run" #o755)
>> +           (mkdir "/tmp" #o1777)
>> +           (mkdir "/var/run" #o755)
>>             (delete-file-recursively "/run/udev/watch.old"))))))
>>
>>  (define cleanup-service-type
>
> It seems that the mode is not applied correctly:
>
> $ guile -c '(mkdir "/tmp/test" #o1777)' && stat /tmp/test
> [...]
> Access: (1755/drwxr-xr-t)  Uid: ( 1000/    hako)   Gid: (  998/   users)

Oops, I saw your message too late, apologies.

Commit f92151133da4b98f98e755ce0996e8be59acac72 fixes that and adds a
test so we can catch it next time.

The story is that the 2nd argument to ‘mkdir’ is and’ed with umask,
something that I had forgotten.

Thanks and sorry for the mess.

Ludo’.