GNU bug report logs - #7292
Inappropriate uses of toggle-read-only?

Previous Next

Package: emacs;

Reported by: Ryan Twitchell <metatheorem <at> gmail.com>

Date: Thu, 28 Oct 2010 00:12:01 UTC

Severity: minor

Fixed in version 24.0.92

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ryan Twitchell <metatheorem <at> gmail.com>
Subject: bug#7292: closed (Re: bug#7292: view-mode clobbers speedbar bindings)
Date: Thu, 10 Nov 2011 02:20:02 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#7292: Inappropriate uses of toggle-read-only?

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 7292 <at> debbugs.gnu.org.

-- 
7292: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7292
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Glenn Morris <rgm <at> gnu.org>
To: 7292-done <at> debbugs.gnu.org
Subject: Re: bug#7292: view-mode clobbers speedbar bindings
Date: Wed, 09 Nov 2011 21:19:48 -0500
Version: 24.0.92

Stefan Monnier wrote:

> So let's add it to byte-compile-interactive-only-functions (with
> a comment about why); and if it turns out that there are many cases
> where calling it from Elisp makes sense, then we'll get to learn which
> are the cases where it makes sense.

Done.

[Message part 3 (message/rfc822, inline)]
From: Ryan Twitchell <metatheorem <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: view-mode clobbers speedbar bindings
Date: Wed, 27 Oct 2010 20:03:10 -0400
Hi,

A number of speedbar's bindings, such as 'n' and 'p', do not work with
view-mode enabled in the speedbar buffer (which makes no sense anyway). 
This is relevant when view-read-only is set, causing speedbar-mode to
implicitly enable view-mode.

For my part, I have redefined speedbar-mode in my .emacs file as follows:

(require 'speedbar)
(defvar real-speedbar-mode #'speedbar-mode)
(defun speedbar-mode ()
  (let ((view-read-only nil))
    (funcall #'real-speedbar-mode)))


This appears to solve the problem.  speedbar-mode calls
toggle-read-only; binding view-read-only to nil around that call should
be a more permanent fix.

M-x emacs-version
GNU Emacs 23.2.1 (x86_64-pc-linux-gnu, GTK+ Version 2.20.1) of
2010-09-26 on falconsrevenge

Thanks,
Ryan Twitchell




This bug report was last modified 13 years and 196 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.