GNU bug report logs - #7292
Inappropriate uses of toggle-read-only?

Previous Next

Package: emacs;

Reported by: Ryan Twitchell <metatheorem <at> gmail.com>

Date: Thu, 28 Oct 2010 00:12:01 UTC

Severity: minor

Fixed in version 24.0.92

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

Message #14 received at 7292 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Ryan Twitchell <metatheorem <at> gmail.com>
Cc: 7292 <at> debbugs.gnu.org
Subject: Re: bug#7292: view-mode clobbers speedbar bindings
Date: Fri, 29 Oct 2010 03:49:29 -0400

Ryan Twitchell wrote:

>> (I notice a few other files call toggle-read-only as well. Seems odd.)
>
> A fair question.  I suppose this is just caution: toggle-read-only will
> always "do the right thing" to make sure the buffer is read-only, though
> setting buffer-read-only should be sufficient.

That doesn't make sense to me. I replace several inappropriate uses,
including the speedbar one.

I wonder if toggle-read-only should even be added to
byte-compile-interactive-only-functions.
This bug report was last modified 13 years and 196 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.