GNU bug report logs -
#72915
Docstrings of add-hook and remove-hook improvement?
Previous Next
Reported by: Tomas Nordin <tomasn <at> posteo.net>
Date: Sat, 31 Aug 2024 12:38:01 UTC
Severity: normal
Tags: patch
Fixed in version 30.1
Done: Stefan Kangas <stefankangas <at> gmail.com>
Bug is archived. No further changes may be made.
Full log
Message #52 received at 72915 <at> debbugs.gnu.org (full text, mbox):
Stefan Kangas <stefankangas <at> gmail.com> writes:
> Tomas Nordin <tomasn <at> posteo.net> writes:
>
>> Tomas Nordin <tomasn <at> posteo.net> writes:
>>
>>> Stefan Monnier <monnier <at> iro.umontreal.ca> writes:
>>>
>>>> The `add-hook` part was OK for me, indeed.
>>>>
>>>> [ I'm no great fan of that paragraph (neither the original nor the one
>>>> you replace it with), tho, because it's a bit "too detailed" for my
>>>> taste. E.g. the value *always* ends up being a list of functions, and
>>>> the parenthesis states something which sounds to me like it should be
>>>> inferrable from the rest of the docstring. ]
>>>
>>> I think I agree, the parenthesized part could be discarded, shortening
>>> the paragraph to
>>>
>>> "HOOK should be a symbol. If HOOK is void, or if HOOK's value is a
>>> single function, it is changed to a list of functions."
>>
>> I think nothing was installed along this discussion so far. Attached is
>> an attempt to summarize the suggestions as patch.
>
> Thanks. I think this contribution is bigger than what we can accept
> without a copyright assignment from you to the FSF.
>
> Please see etc/copyright-assign.txt in emacs.git to get started.
Actually I got my assignment confirmed in November last year. It took
some time, but it should be there on file somewhere. Should I provide
the assignment number?
This bug report was last modified 80 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.