Subject: Re: bug#72915: Docstrings of add-hook and remove-hook improvement?

From: Tomas Nordin <[email-masked]>
Date: Fri, 28 Feb 2025 17:38:29 +0000

Stefan Kangas <[email-masked]> writes:

> No need, thanks.  I just pushed your patch to emacs-30 with the below
> small change to use the imperative mood.
>
> Thanks for the patch!  Closing this bug now.
>
> diff --git a/lisp/subr.el b/lisp/subr.el
> index d0faff73e4a..7af21125b33 100644
> --- a/lisp/subr.el
> +++ b/lisp/subr.el
> @@ -2177,8 +2177,8 @@ add-hook
>  (defun remove-hook (hook function &optional local)
>    "Remove FUNCTION from HOOK's functions.
>  HOOK should be a symbol, and FUNCTION may be any valid function.
> -Does nothing if HOOK does not currently contain FUNCTION.
> -Compares functions with `equal`, which means that it can be
> +Do nothing if HOOK does not currently contain FUNCTION.
> +Compare functions with `equal`, which means that it can be
>  slow if FUNCTION is not a symbol.  See `add-hook'.
>
>  The optional third argument, LOCAL, if non-nil, says to modify

I wanted to write it like that but was too shy and took Stefan M:s text
verbatim. Perfect, thanks.