GNU bug report logs - #72912
[PATCH 0/1] Update Minetest to 5.9.0 (again)

Previous Next

Package: guix-patches;

Reported by: Jan Wielkiewicz <tona_kosmicznego_smiecia <at> interia.pl>

Date: Sat, 31 Aug 2024 10:54:02 UTC

Severity: normal

Tags: patch

Done: Leo Famulari <leo <at> famulari.name>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Leo Famulari <leo <at> famulari.name>
To: Jan Wielkiewicz <tona_kosmicznego_smiecia <at> interia.pl>
Cc: Adam Faiz <adam.faiz <at> disroot.org>, 72912 <at> debbugs.gnu.org, Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 宋文武 <iyzsong <at> envs.net>
Subject: [bug#72912] [PATCH 0/1] Update Minetest to 5.9.0 (again)
Date: Thu, 5 Sep 2024 15:17:56 -0400
[Message part 1 (text/plain, inline)]
Hi Jan,

Thanks so much for performing this complicated upgrade! I confirm it
works fine to play Minetest.

On Sat, Aug 31, 2024 at 02:26:05PM +0200, Jan Wielkiewicz wrote:
> The minetest-something convention is for packages that are either
> games for minetest or mods for any minetest game. Minetest - the engine
> executes games. Previously "Minetest Game" was the default game for
> Minetest (the engine), but is not anymore. A similar example would be a
> game called "MineClone" for Minetest, the package is then called
> minetest-mineclone. But "Minetest Game" is indeed the name of the
> ex-default game, hence minetest-minetest-game. "minetest-game" would
> suggest it's a game for minetest named "game" also could make it
> possible to confuse it with simply "minetest" - the engine.
> The name of the package: https://github.com/minetest/minetest_game

We have similar conventions for other packages in Guix, such as Python
modules.

But if a Python program is named by its authors "python-foo", we do not
package it as "python-python-foo". Well, there is one package like this
currently, but that's one mistake, after we avoided the repetitive names
many times.

I think that if somebody wants to play the basic Minetest game, they
will not have much trouble choosing the package called "minetest-game".

I've attached a diff against your patch that makes that change and some
other minor changes.

Specifically:

It tweaks the description of the minetest engine packages to remove the
"marketing" word "easy", as requested in the guidelines on writing
package descriptions:

https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.html

It also uses "minetest-game" as an example of a game that could be
installed based on this engine. Or should we use mineclone? We don't
have any other games packaged, right?

It adjusts the version procedure of minetest-game to respect the
guidlines in the manual section Version Numbers:

https://guix.gnu.org/manual/en/html_node/Version-Numbers.html

It removes irrlicht-for-minetest entirely. I don't think we need to
deprecate libraries that wouldn't have been installed into someone's
profile.

I'm not as sure about minetest-data. Was that something that people
would install? I never needed to in order to play the minetest game.

What do you think?
[0001-WIP.patch (text/plain, attachment)]

This bug report was last modified 250 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.