GNU bug report logs - #72878
[PATCH] gnu: plasma-nm: Fix build on aarch64

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72878 in the body.
You can then email your comments to 72878 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Doğan Çeçen <sepeth <at> fastmail.com>
To: guix-patches <at> gnu.org
Cc: Doğan Çeçen <sepeth <at> fastmail.com>
Subject: [PATCH] gnu: plasma-nm: Fix build on aarch64
Date: Thu, 29 Aug 2024 18:37:00 +0300

* gnu/packages/qt.scm (qtcoro-qt6): pass -fPIC explicitly

Change-Id: Ifb26600945548d84df2cc70318781d87253af476
---
 gnu/packages/qt.scm | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
index a91bebf358..974af2a342 100644
--- a/gnu/packages/qt.scm
+++ b/gnu/packages/qt.scm
@@ -153,10 +153,11 @@ (define-public qcoro-qt5
     (build-system qt-build-system)
     (arguments
      (list #:configure-flags
-           #~(list (string-append "-DUSE_QT_VERSION="
+           #~(list "-DCMAKE_CXX_FLAGS=-fPIC"
+                   (string-append "-DUSE_QT_VERSION="
                                   #$(version-major
-                                     (package-version
-                                      (this-package-input "qtbase")))))))
+                                      (package-version
+                                        (this-package-input "qtbase")))))))
     (native-inputs (list dbus))         ;for tests
     (inputs (list qtbase-5 qtdeclarative-5 qtwebsockets-5))
     (home-page "https://qcoro.dvratil.cz/")
@@ -169,6 +170,7 @@ (define-public qcoro-qt6
   (package
     (inherit qcoro-qt5)
     (name "qcoro-qt6")
+    (synopsis "C++ Coroutine Library for Qt6")
     (inputs (modify-inputs (package-inputs qcoro-qt5)
               (replace "qtbase" qtbase)
               (replace "qtdeclarative" qtdeclarative)

base-commit: d5312370b46ace47e138d84e1bb28e5651cee94b
-- 
2.45.2

Message #8 received at 72878 <at> debbugs.gnu.org (full text, mbox):

From: Doğan Çeçen <sepeth <at> fastmail.com>
To: 72878 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: plasma-nm: Fix build on aarch64
Date: Thu, 29 Aug 2024 21:35:12 +0300

Sorry for not adding a little context, I was battling with my email config.

Anyhow, I was getting the following error when installing plasma-nm:

--8<---------------cut here---------------start------------->8---
ld: /gnu/store/drbppxblx1gf943dxilhwz5vags287ir-qcoro-qt6-0.10.0/lib/libQCoro6DBus.a(qcorodbuspendingcall.cpp.o): relocation R_AARCH64_ADR_PREL_PG_HI21 against symbol `_ZN23QDBusPendingCallWatcher8finishedEPS_@@Qt_6' which may bind externally can not be used when making a shared object; recompile with -fPIC
ld: /gnu/store/drbppxblx1gf943dxilhwz5vags287ir-qcoro-qt6-0.10.0/lib/libQCoro6DBus.a(qcorodbuspendingcall.cpp.o)(.text+0xb0): unresolvable R_AARCH64_ADR_PREL_PG_HI21 relocation against symbol `_ZN23QDBusPendingCallWatcher8finishedEPS_@@Qt_6'
ld: final link failed: bad value
--8<---------------cut here---------------end--------------->8---

The problem seemed to be qcoro-qt6. I checked its logs on x86_64, and it seems -fPIC is being passed:

https://ci.guix.gnu.org/build/5466920/details

Unfortunately, aarch64 build is still Scheduled:

https://ci.guix.gnu.org/build/5454563/details

Anyhow, the suggestion that the linker gave has worked, which is adding -fPIC.

Message #11 received at 72878 <at> debbugs.gnu.org (full text, mbox):

From: Z572 <zhengjunjie <at> iscas.ac.cn>
To: Doğan Çeçen <sepeth <at> fastmail.com>
Cc: 宋文武 <iyzsong <at> envs.net>,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>, 72878 <at> debbugs.gnu.org
Subject: Re: [bug#72878] [PATCH] gnu: plasma-nm: Fix build on aarch64
Date: Sun, 01 Sep 2024 10:08:24 +0800

[Message part 1 (text/plain, inline)]

Doğan Çeçen <sepeth <at> fastmail.com> writes:

Title should "gnu: qcoro-qt: Build with -fPIC.", because it change qcoro-qt{5,6}.

> * gnu/packages/qt.scm (qtcoro-qt6): pass -fPIC explicitly

* gnu/packages/qt.scm (qcoro-qt5, qcoro-qt6)[arguments]: Adjust
  configure-flags to add -fPIC to CMAKE_CXX_FLAGS.
  
>
> Change-Id: Ifb26600945548d84df2cc70318781d87253af476
> ---
>  gnu/packages/qt.scm | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
> index a91bebf358..974af2a342 100644
> --- a/gnu/packages/qt.scm
> +++ b/gnu/packages/qt.scm
> @@ -153,10 +153,11 @@ (define-public qcoro-qt5
>      (build-system qt-build-system)
>      (arguments
>       (list #:configure-flags
> -           #~(list (string-append "-DUSE_QT_VERSION="
> +           #~(list "-DCMAKE_CXX_FLAGS=-fPIC"
> +                   (string-append "-DUSE_QT_VERSION="
>                                    #$(version-major
> -                                     (package-version
> -                                      (this-package-input "qtbase")))))))
> +                                      (package-version
> +                                        (this-package-input "qtbase")))))))
>      (native-inputs (list dbus))         ;for tests
>      (inputs (list qtbase-5 qtdeclarative-5 qtwebsockets-5))
>      (home-page "https://qcoro.dvratil.cz/")
> @@ -169,6 +170,7 @@ (define-public qcoro-qt6
>    (package
>      (inherit qcoro-qt5)
>      (name "qcoro-qt6")
> +    (synopsis "C++ Coroutine Library for Qt6")

please split to a new patch.

>      (inputs (modify-inputs (package-inputs qcoro-qt5)
>                (replace "qtbase" qtbase)
>                (replace "qtdeclarative" qtdeclarative)
>
> base-commit: d5312370b46ace47e138d84e1bb28e5651cee94b

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 72878 <at> debbugs.gnu.org (full text, mbox):

From: Doğan Çeçen <sepeth <at> fastmail.com>
To: 72878 <at> debbugs.gnu.org
Cc: Doğan Çeçen <sepeth <at> fastmail.com>
Subject: [PATCH] gnu: qcoro-qt: Build with -fPIC
Date: Mon,  2 Sep 2024 15:29:32 +0300

* gnu/packages/qt.scm (qcoro-qt5, qcoro-qt6)[arguments]: Adjust
  configure-flags to add -fPIC to CMAKE_CXX_FLAGS.

Change-Id: I5ed2ee18cec120b282863ce6a5f6b6b149059515
---
 gnu/packages/qt.scm | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
index b99ce365d7..635fc37639 100644
--- a/gnu/packages/qt.scm
+++ b/gnu/packages/qt.scm
@@ -153,10 +153,11 @@ (define-public qcoro-qt5
     (build-system qt-build-system)
     (arguments
      (list #:configure-flags
-           #~(list (string-append "-DUSE_QT_VERSION="
+           #~(list "-DCMAKE_CXX_FLAGS=-fPIC"
+                   (string-append "-DUSE_QT_VERSION="
                                   #$(version-major
-                                     (package-version
-                                      (this-package-input "qtbase")))))))
+                                      (package-version
+                                        (this-package-input "qtbase")))))))
     (native-inputs (list dbus))         ;for tests
     (inputs (list qtbase-5 qtdeclarative-5 qtwebsockets-5))
     (home-page "https://qcoro.dvratil.cz/")
@@ -169,6 +170,7 @@ (define-public qcoro-qt6
   (package
     (inherit qcoro-qt5)
     (name "qcoro-qt6")
+    (synopsis "C++ Coroutine Library for Qt6")
     (inputs (modify-inputs (package-inputs qcoro-qt5)
               (replace "qtbase" qtbase)
               (replace "qtdeclarative" qtdeclarative)

base-commit: ad7211cfe0cba1b7a97308c0fec941c807c1c1e5
-- 
2.45.2

Message #19 received at 72878-done <at> debbugs.gnu.org (full text, mbox):

From: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
To: Doğan Çeçen <sepeth <at> fastmail.com>
Cc: 72878-done <at> debbugs.gnu.org, 宋文武 <iyzsong <at> envs.net>,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: Re: [bug#72878] [PATCH] gnu: qcoro-qt: Build with -fPIC
Date: Fri, 06 Sep 2024 22:52:01 +0800

[Message part 1 (text/plain, inline)]

Doğan Çeçen <sepeth <at> fastmail.com> writes:

> * gnu/packages/qt.scm (qcoro-qt5, qcoro-qt6)[arguments]: Adjust
>   configure-flags to add -fPIC to CMAKE_CXX_FLAGS.
>
> Change-Id: I5ed2ee18cec120b282863ce6a5f6b6b149059515
> ---
>  gnu/packages/qt.scm | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
> index b99ce365d7..635fc37639 100644
> --- a/gnu/packages/qt.scm
> +++ b/gnu/packages/qt.scm
> @@ -153,10 +153,11 @@ (define-public qcoro-qt5
>      (build-system qt-build-system)
>      (arguments
>       (list #:configure-flags
> -           #~(list (string-append "-DUSE_QT_VERSION="
> +           #~(list "-DCMAKE_CXX_FLAGS=-fPIC"
> +                   (string-append "-DUSE_QT_VERSION="
>                                    #$(version-major
> -                                     (package-version
> -                                      (this-package-input "qtbase")))))))
> +                                      (package-version
> +                                        (this-package-input "qtbase")))))))
>      (native-inputs (list dbus))         ;for tests
>      (inputs (list qtbase-5 qtdeclarative-5 qtwebsockets-5))
>      (home-page "https://qcoro.dvratil.cz/")
> @@ -169,6 +170,7 @@ (define-public qcoro-qt6
>    (package
>      (inherit qcoro-qt5)
>      (name "qcoro-qt6")
> +    (synopsis "C++ Coroutine Library for Qt6")

split it on new commit

>      (inputs (modify-inputs (package-inputs qcoro-qt5)
>                (replace "qtbase" qtbase)
>                (replace "qtdeclarative" qtdeclarative)
>
> base-commit: ad7211cfe0cba1b7a97308c0fec941c807c1c1e5


push, close.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.