GNU bug report logs - #72858
[PATCH] gnu: godot: Update to 4.3

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72858 in the body.
You can then email your comments to 72858 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: msglm <msglm <at> techchud.xyz>
To: guix-patches <at> gnu.org
Cc: msglm <msglm <at> techchud.xyz>
Subject: [PATCH] gnu: godot: Update to 4.3
Date: Wed, 28 Aug 2024 13:09:03 -0500

* gnu/packages/game-development.scm (godot): Update to 4.3.

Change-Id: I9a0e11cd9299311b92b31e2be1f0099d960ddcfa
---
 gnu/packages/game-development.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm
index aff95d48a1..fe2a372493 100644
--- a/gnu/packages/game-development.scm
+++ b/gnu/packages/game-development.scm
@@ -2101,16 +2101,16 @@ (define-public godot-lts
 (define-public godot
   (package
     (name "godot")
-    (version "4.2.2")
+    (version "4.3")
     (source (origin
               (method git-fetch)
               (uri (git-reference
                     (url "https://github.com/godotengine/godot")
-                    (commit (string-append version "-stable"))))
-              (file-name (git-file-name name version))
+                    (commit (string-append version))))
+              (file-name (git-file-name name version "-stable"))
               (sha256
                (base32
-                "0wm0pla6f6gvk21gbm5kiihinn05dvvprk0242m6s8c78wy60wka"))
+                "1hg6hkysvf6znpy8rcbgkzvan3qqg3iiva7g5g6y7mjd30a6dsy3"))
               (modules '((guix build utils)
                          (ice-9 ftw)
                          (srfi srfi-1)))
-- 
2.45.2

Message #8 received at 72858 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: msglm <msglm <at> techchud.xyz>
Cc: 72858 <at> debbugs.gnu.org, Simon Tournier <zimon.toutoune <at> gmail.com>,
 Mathieu Othacehe <othacehe <at> gnu.org>, Tobias Geerinckx-Rice <me <at> tobias.gr>,
 Ricardo Wurmus <rekado <at> elephly.net>, jgart <jgart <at> dismail.de>,
 paren <at> disroot.org, Christopher Baines <guix <at> cbaines.net>
Subject: Re: [bug#72858] [PATCH] gnu: godot: Update to 4.3
Date: Tue, 03 Sep 2024 13:44:52 +0200

Hi,

msglm <msglm <at> techchud.xyz> skribis:

> * gnu/packages/game-development.scm (godot): Update to 4.3.
>
> Change-Id: I9a0e11cd9299311b92b31e2be1f0099d960ddcfa

[...]

> +              (file-name (git-file-name name version "-stable"))

There are three arguments to ‘git-file-name’ instead of two.

Could you send an updated version of this patch and make sure it builds
fine on your side?

Thanks,
Ludo’.

Message #11 received at 72858 <at> debbugs.gnu.org (full text, mbox):

From: msglm <msglm <at> techchud.xyz>
To: ludo <at> gnu.org
Cc: 72858 <at> debbugs.gnu.org, msglm <msglm <at> techchud.xyz>
Subject: [PATCH] gnu: godot: Update to 4.3
Date: Tue,  3 Sep 2024 12:17:13 -0500

* gnu/packages/game-development.scm (godot): Update to 4.3.

Change-Id: I6a5056d9e0dce346d47be441fd550793831ec5b7

---
 gnu/packages/game-development.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm
index aff95d48a1..fe2a372493 100644
--- a/gnu/packages/game-development.scm
+++ b/gnu/packages/game-development.scm
@@ -2101,16 +2101,16 @@ (define-public godot-lts
 (define-public godot
   (package
     (name "godot")
-    (version "4.2.2")
+    (version "4.3")
     (source (origin
               (method git-fetch)
               (uri (git-reference
                     (url "https://github.com/godotengine/godot")
-                    (commit (string-append version "-stable"))))
-              (file-name (git-file-name name version))
+                    (commit (string-append version))))
+              (file-name (git-file-name name version "-stable"))
               (sha256
                (base32
-                "0wm0pla6f6gvk21gbm5kiihinn05dvvprk0242m6s8c78wy60wka"))
+                "1hg6hkysvf6znpy8rcbgkzvan3qqg3iiva7g5g6y7mjd30a6dsy3"))
               (modules '((guix build utils)
                          (ice-9 ftw)
                          (srfi srfi-1)))
-- 
2.45.2

Message #14 received at 72858 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: msglm <msglm <at> techchud.xyz>
Cc: 72858 <at> debbugs.gnu.org
Subject: Re: [bug#72858] [PATCH] gnu: godot: Update to 4.3
Date: Wed, 04 Sep 2024 19:12:05 +0200

Hi,

msglm <msglm <at> techchud.xyz> skribis:

> +              (file-name (git-file-name name version "-stable"))

The problem mentioned in my previous message is still here.

Could you send a patch without this typo?

Ludo’.

Message #19 received at 72858-done <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: msglm <msglm <at> techchud.xyz>, 72858-done <at> debbugs.gnu.org
Subject: Re: [bug#72858] [PATCH] gnu: godot: Update to 4.3
Date: Sat, 07 Sep 2024 21:05:08 +0000

Hello msglm and Ludo’,

On Wed, Sep 04, 2024 at 07:12 PM, Ludovic Courtès wrote:

> Hi,
>
> msglm <msglm <at> techchud.xyz> skribis:
>
>> +              (file-name (git-file-name name version "-stable"))
>
> The problem mentioned in my previous message is still here.
>
> Could you send a patch without this typo?
>
> Ludo’.

Thanks for trying to update Godot, msglm. Unfortunately, your patch does
not work (as noted above) and there was more to be done to update Godot,
which I've done after testing locally (building and running). In
particular, the snippet and a phase needed to be adjusted. Please see
commit 123b7226a0442ee4103c04064d453421424d5fac for details if you are
interested. I also needed to update embree (also tested locally and
build blender with it) which was done with
31a55a652f8e4856fd66b47377e214b7d20b4f61.

Thank you for your efforts! If you are interested, Godot has many
bundled libraries which should be unbundled, some of which we have
packaged (but may need updates or patching in Godot to use them) and
others which are not packaged. It would be great to make some progress
on that front if you'd like to work on Godot-related packaging.

John

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.