Subject: Re: [PATCH] gnu: pidgin: Update to 2.14.13 [security fixes].

From: Liliana Marie Prikler <[email-masked]>
Date: Wed, 28 Aug 2024 20:35:56 +0200

Am Mittwoch, dem 28.08.2024 um 07:41 +0000 schrieb Dariqq:
> The 2.14.9 update fixes CVE-2022-26491.
> 
> Cleanup leftovers from 89f4f0baa9ff956ba0efe9ec20e1805f01230a54.
> 
> * gnu/packages/messaging.scm (pidgin): Update to 2.14.13.
> [source]: Switch to bz2 compression.
> [snippet]: Remove.
Why?
> [native-inputs]: Remove autoconf, automake and libtool.
Again, why?

> Change-Id: Icde29d67b5ac09d7dc0939eb6c779d39b3470a6f
> ---
> Change to bz2 compressed tarball as that is what guix refresh
> downloaded. This is the one used by other distributions (I have
> checked Arch, Fedora, NixOs). CCing the person who did the last
> update.
> 
>  gnu/packages/messaging.scm | 19 +++++--------------
>  1 file changed, 5 insertions(+), 14 deletions(-)
> 
> diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
> index 3f375f34c6..aaee5f7286 100644
> --- a/gnu/packages/messaging.scm
> +++ b/gnu/packages/messaging.scm
> @@ -948,32 +948,23 @@ (define-public ngircd
>  (define-public pidgin
>    (package
>      (name "pidgin")
> -    (version "2.14.5")
> +    (version "2.14.13")
>      (source
>       (origin
>         (method url-fetch)
>         (uri
>          (string-append "mirror://sourceforge/pidgin/Pidgin/"
> -                       version "/pidgin-" version ".tar.gz"))
> +                       version "/pidgin-" version ".tar.bz2"))
>         (sha256
> -        (base32
> "12llip3r8126gph82r638xjv2v2rg34qgggn1nbwfmc3s7halimr"))
> +        (base32
> "1a3by4niw5ls67mwgj20p2mr317zj4hzysi5glm9mq0pivf4j00j"))
>         (patches
> -        (search-patches "pidgin-add-search-path.patch"))
> -       (modules '((guix build utils)))
> -       (snippet
> -        '(begin
> -           ;; Remove stale generated file after applying patches.
> -           (delete-file "configure")
> -           #t))))
> +        (search-patches "pidgin-add-search-path.patch"))))
>      (build-system glib-or-gtk-build-system)
>      (native-inputs
> -     `(("autoconf" ,autoconf) ;; For bootstrap
> -       ("automake" ,automake) ;; For bootstrap
> -       ("check" ,check)
> +     `(("check" ,check)
>         ("dot" ,graphviz)
>         ("gconf" ,gconf)
>         ("intltool" ,intltool)
> -       ("libtool" ,libtool) ;; For bootstrap
>         ("pkg-config" ,pkg-config)))
As a follow-up commit, you might want to drop the input labels.

Cheers