Subject: Re: [PATCH v2 4/6] gnu: pidgin: Use system ssl certs.

From: Liliana Marie Prikler <[email-masked]>
Date: Fri, 30 Aug 2024 22:09:56 +0200

Am Donnerstag, dem 29.08.2024 um 08:35 +0000 schrieb Dariqq:
> If not present pidgin bundles its own certs otherwise.
This should probably be a code comment or none at all.

> * gnu/packages/messaging.scm (pdigin) [inputs]: Add nss-certs.
Note: pdgin, not pidgin.
> [#:configure-flags]: Add  --with-system-ssl-certs
> 
> Change-Id: I14ec36002b31b4de52871f065bd18c9d30eca275
> ---
>  gnu/packages/messaging.scm | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
> index 6b3dff2152..4992db1bee 100644
> --- a/gnu/packages/messaging.scm
> +++ b/gnu/packages/messaging.scm
> @@ -74,6 +74,7 @@ (define-module (gnu packages messaging)
>    #:use-module (gnu packages bison)
>    #:use-module (gnu packages boost)
>    #:use-module (gnu packages check)
> +  #:use-module (gnu packages certs)
>    #:use-module (gnu packages code)
>    #:use-module (gnu packages compression)
>    #:use-module (gnu packages cpp)
> @@ -1002,6 +1003,7 @@ (define-public pidgin
>             network-manager
>             nspr
>             nss
> +           nss-certs
>             pango
>             perl
>             python-2
> @@ -1024,6 +1026,9 @@ (define-public pidgin
>          "--disable-gevolution"
>          "--enable-cap"
>          "--enable-cyrus-sasl"
> +        (string-append "--with-system-ssl-certs="
> +                       (assoc-ref %build-inputs "nss-certs")
> +                       "/etc/ssl/certs")
If pidgin bundles certificates, we should also drop them with a
snippet.  A runtime option would still be preferable – search for
SSL_CERT_DIR.

Cheers