GNU bug report logs - #72848
[PATCH RESEND] xwidget: Fix xwidget-at misinterpreting non-xwidget text-properties

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: George Huebner <george <at> feyor.sh>
Subject: bug#72848: closed (Re: bug#72848: [PATCH RESEND] xwidget: Fix
 xwidget-at misinterpreting non-xwidget text-properties)
Date: Thu, 29 Aug 2024 12:16:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#72848: [PATCH RESEND] xwidget: Fix xwidget-at misinterpreting non-xwidget text-properties

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 72848 <at> debbugs.gnu.org.

-- 
72848: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=72848
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: George Huebner <george <at> feyor.sh>
Cc: 72848-done <at> debbugs.gnu.org
Subject: Re: bug#72848: [PATCH RESEND] xwidget: Fix xwidget-at misinterpreting
 non-xwidget text-properties
Date: Thu, 29 Aug 2024 15:13:58 +0300

> From: George Huebner <george <at> feyor.sh>
> Date: Tue, 27 Aug 2024 20:03:44 -0500
> 
> xwidget-at assumes the text-property at `point-min` either doesn't
> exist or is an xwidget, and can improperly access fields. This 
> patch
> just returns nil if the text-property isn't an xwidget.
> 
> This is definitely an edge case; I use a package called org-modern
> where headlines are formatted with text-properties, which is how I
> found the bug:
> Debugger entered--Lisp error: (wrong-type-argument listp #("◉" 0 1
> (face org-modern-symbol)))
>  xwidget-at(1)
>  xwidget-webkit-current-session()

Thanks, installed on the emacs-30 branch, and closing the bug.

[Message part 3 (message/rfc822, inline)]

From: George Huebner <george <at> feyor.sh>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH RESEND] xwidget: Fix xwidget-at misinterpreting non-xwidget
 text-properties
Date: Tue, 27 Aug 2024 20:03:44 -0500

[Message part 4 (text/plain, inline)]

Tags: patch

xwidget-at assumes the text-property at `point-min` either doesn't
exist or is an xwidget, and can improperly access fields. This 
patch
just returns nil if the text-property isn't an xwidget.

This is definitely an edge case; I use a package called org-modern
where headlines are formatted with text-properties, which is how I
found the bug:
Debugger entered--Lisp error: (wrong-type-argument listp #("◉" 0 1
(face org-modern-symbol)))
xwidget-at(1)
xwidget-webkit-current-session()


In GNU Emacs 29.1 (build 1, aarch64-apple-darwin23.6.0, Carbon 
Version
170 AppKit 2487.7)
Windowing system distributor 'Apple Inc.', version 14.6.0
System Description:  macOS 14.6

Configured using:
'configure
--prefix=/nix/store/59qdq2kd14ix95z4g3k9s6l79zwa2s2b-emacs-mac-macport-29.1
--disable-build-details --with-modules --without-gif 
--without-jpeg
--without-png --without-tiff --without-x --without-xpm
'--enable-mac-app=$$out/Applications' --with-gnutls --with-mac
--with-xml2 --without-ns --with-compress-install
--with-toolkit-scroll-bars --with-native-compilation
--without-imagemagick --with-mailutils --without-small-ja-dic
--with-tree-sitter --without-xinput2 --without-xwidgets 
--without-dbus
--without-selinux --with-xwidgets'

[0001-xwidget-Fix-xwidget-at-misinterpreting-non-xwidget-t.patch (text/patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.