From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 27 21:04:45 2024 Received: (at submit) by debbugs.gnu.org; 28 Aug 2024 01:04:45 +0000 Received: from localhost ([127.0.0.1]:47916 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sj776-00082p-Md for submit@debbugs.gnu.org; Tue, 27 Aug 2024 21:04:45 -0400 Received: from lists.gnu.org ([209.51.188.17]:40716) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sj774-00082e-DA for submit@debbugs.gnu.org; Tue, 27 Aug 2024 21:04:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sj76C-0001BS-Oo for bug-gnu-emacs@gnu.org; Tue, 27 Aug 2024 21:03:48 -0400 Received: from mail-qk1-f171.google.com ([209.85.222.171]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sj76B-0005gZ-6Y for bug-gnu-emacs@gnu.org; Tue, 27 Aug 2024 21:03:48 -0400 Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-7a1d6f4714bso12950085a.1 for ; Tue, 27 Aug 2024 18:03:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724807025; x=1725411825; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=RRiHGKsoMQekhZmaCM8iJmw4UM1uEFHpaAQz9G4tj0Y=; b=vFtt83PFbcnur4Qvrir25QOYGfYBSkqq2syDW5PHfryPw3NghCBOO3rv6/tG0+JApr Va98nzufICYqEmlsJAScZyWdMhHhNPakrdwf6azpl4pA0t35XzNEJ418/dUZslqOc0/Y iyQp5jk0vRRrTUtN8O/ShXtcpLlkIhCFy9yfqFPD1XZnPCnOHtPtGHHXvx9RNLKBWWTP 8FhxAGtnYmi626d7Xftl3iaUZfqRSZN/iupyh+0k7AOMpPcerDv5qkcqYLCBezANhGFK h6id7SK4ZKHE2fq+P/Zj5P0Ao/JBPcaG6Gi8liD3v/92PWjzBRlJfj6jrx89ekWjFSXB oGaw== X-Gm-Message-State: AOJu0Yxm+b5UGNH9DFG5zK01Ysy0TBiEhoGHm6020Fpm707vgvVQArtb lq/AUq7Uisgeep5IStzYeeo7pcYzNZ3MKAFLHfbTQo9ST1iy/c3sxdKc5w== X-Google-Smtp-Source: AGHT+IFVrO2EyiFu2qM0owRZ7DbMXIVaoc4Xt+wW/ELgYIbUxsAwyTfmnv+Del8n65KtY2Zx359gWA== X-Received: by 2002:a05:620a:318e:b0:7a1:d69f:5b9c with SMTP id af79cd13be357-7a7f427f970mr122492485a.27.1724807025381; Tue, 27 Aug 2024 18:03:45 -0700 (PDT) Received: from localhost (s-26-173.flex.volo.net. [76.191.26.173]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-454fe0f3e24sm57919671cf.55.2024.08.27.18.03.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Aug 2024 18:03:45 -0700 (PDT) From: George Huebner To: bug-gnu-emacs@gnu.org Subject: [PATCH RESEND] xwidget: Fix xwidget-at misinterpreting non-xwidget text-properties Date: Tue, 27 Aug 2024 20:03:44 -0500 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=209.85.222.171; envelope-from=ghubs25@gmail.com; helo=mail-qk1-f171.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Tags: patch xwidget-at assumes the text-property at `point-min` either doesn't exist or is an xwidget, and can improperly access fields. This=20 patch just returns nil if the text-property isn't an xwidget. This is definitely an edge case; I use a package called org-modern where headlines are formatted with text-properties, which is how I found the bug: Debugger entered--Lisp error: (wrong-type-argument listp #("=E2=97=89" 0 1 (face org-modern-symbol))) xwidget-at(1) xwidget-webkit-current-session() In GNU Emacs 29.1 (build 1, aarch64-apple-darwin23.6.0, Carbon=20 Version 170 AppKit 2487.7) Windowing system distributor 'Apple Inc.', version 14.6.0 System Description: macOS 14.6 Configured using: 'configure --prefix=3D/nix/store/59qdq2kd14ix95z4g3k9s6l79zwa2s2b-emacs-mac-macport-2= 9.1 --disable-build-details --with-modules --without-gif=20 --without-jpeg --without-png --without-tiff --without-x --without-xpm '--enable-mac-app=3D$$out/Applications' --with-gnutls --with-mac --with-xml2 --without-ns --with-compress-install --with-toolkit-scroll-bars --with-native-compilation --without-imagemagick --with-mailutils --without-small-ja-dic --with-tree-sitter --without-xinput2 --without-xwidgets=20 --without-dbus --without-selinux --with-xwidgets' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-xwidget-Fix-xwidget-at-misinterpreting-non-xwidget-t.patch >From 48a662563bc6e7c5bc63dc63da4e0c36909b6cc2 Mon Sep 17 00:00:00 2001 From: George Huebner Date: Sun, 14 Jul 2024 01:46:07 -0500 Subject: [PATCH] xwidget: Fix xwidget-at misinterpreting non-xwidget text-properties xwidget-open wrongly assumes the the text-property at min-position is an xwidget, if it exists; the fix is just returning nil if the text-property isn't an xwidget. --- lisp/xwidget.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/xwidget.el b/lisp/xwidget.el index bf5987d..c5a84db 100644 --- a/lisp/xwidget.el +++ b/lisp/xwidget.el @@ -81,7 +81,7 @@ This returns the result of `make-xwidget'." (defun xwidget-at (pos) "Return xwidget at POS." (let* ((disp (get-text-property pos 'display)) - (xw (car (cdr (cdr disp))))) + (xw (ignore-errors (car (cdr (cdr disp)))))) (when (xwidget-live-p xw) xw))) -- 2.44.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 29 08:15:09 2024 Received: (at 72848-done) by debbugs.gnu.org; 29 Aug 2024 12:15:09 +0000 Received: from localhost ([127.0.0.1]:50691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sje3Q-0005Sp-Rb for submit@debbugs.gnu.org; Thu, 29 Aug 2024 08:15:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56022) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sje3M-0005S5-JU for 72848-done@debbugs.gnu.org; Thu, 29 Aug 2024 08:15:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sje2N-0007ke-9g; Thu, 29 Aug 2024 08:14:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=KwFUqZnMbMJikyNsK0DbBlPLcmp6b8BsZs7IsoLKdq0=; b=JSkfKacohQ4pXWWRpfvF z+I8lxyyMbohVgEqOWyihx/NzMyeetL5SHHmXQKz1lMx4d7u1/23kCmM/4lijdBLwTMitDDcf/D97 wI2iDLg3ff+18gkhfeE+uHgnCEqD2/FaAG0Q5zz9fHjAKFy+dK/Vir7U9x+Mn80FL5PmS3bmevoOg wmgcagIBLfY0hU+IOZNZd+I/e7r/2tgjohlk6fswuuoTPBOJtyzPspQpiSX/8FvBfZ6DUuZ6r9BfV TkIp1JOvO8FLMnaqIW+1p0QCwcTgcwHN8yDzX0qeSJdZW4U/NHZiGL5/GTrG1xQIvhh3z4ujIybNn M+6IOeBg6joxkQ==; Date: Thu, 29 Aug 2024 15:13:58 +0300 Message-Id: <86bk1bfrw9.fsf@gnu.org> From: Eli Zaretskii To: George Huebner In-Reply-To: (message from George Huebner on Tue, 27 Aug 2024 20:03:44 -0500) Subject: Re: bug#72848: [PATCH RESEND] xwidget: Fix xwidget-at misinterpreting non-xwidget text-properties References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72848-done Cc: 72848-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: George Huebner > Date: Tue, 27 Aug 2024 20:03:44 -0500 > > xwidget-at assumes the text-property at `point-min` either doesn't > exist or is an xwidget, and can improperly access fields. This > patch > just returns nil if the text-property isn't an xwidget. > > This is definitely an edge case; I use a package called org-modern > where headlines are formatted with text-properties, which is how I > found the bug: > Debugger entered--Lisp error: (wrong-type-argument listp #("◉" 0 1 > (face org-modern-symbol))) > xwidget-at(1) > xwidget-webkit-current-session() Thanks, installed on the emacs-30 branch, and closing the bug. From unknown Wed Jun 18 00:21:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 27 Sep 2024 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 24 16:27:11 2025 Received: (at control) by debbugs.gnu.org; 24 Feb 2025 21:27:11 +0000 Received: from localhost ([127.0.0.1]:43029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tmfyo-0006bW-UE for submit@debbugs.gnu.org; Mon, 24 Feb 2025 16:27:11 -0500 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]:60597) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tmfym-0006b5-UG for control@debbugs.gnu.org; Mon, 24 Feb 2025 16:27:09 -0500 Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-5e0373c7f55so7594405a12.0 for ; Mon, 24 Feb 2025 13:27:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740432423; x=1741037223; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=w+kVK4XgWP8WbXXyXNyeVPSLqxm4gb7poRqbgSBbpPs=; b=j/5JiRXebIwzFkPpBSVZJ5QWTHiieIEYNnTqqAzo/k67mnLnMiVsNCBWVJGem4G8zG gNqG7ZTcb5xd7HeHGnYiod/rJOavdYtGbjMseTFt1rnn2yM6/wX3VBlvt8KXXykUzSw8 1JBkUDakTnI8QyGwCpWlAap0aR7d0WX3uv32hMopOebp3Q2B6ONv033a8aOVJB3ODRy1 tNh+NWX1KZdUkIUYleo8TAapKAGgSUnOKv1+ngoTCMacSL0qVLviJIme7/50CyUNRk1w 47WwpSUvCQ4rEWkT1YI1evnwof6YLldZHZllHMaEeGBHIVeeUuXs6qQjdtaphbcEiaLU FGow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740432423; x=1741037223; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=w+kVK4XgWP8WbXXyXNyeVPSLqxm4gb7poRqbgSBbpPs=; b=Qfnd0mQDdO+9LnBMrOsStkQky2NhJnx1ObZpUbxEbaxtb9Ii8rBPPLYSt41jFZUUIf /OokfQmouuJ3WcWaDZEm27HaSUbeAfAhnxPCmi32oQXhQtQ4HZwQ6pvIUL08jD4eSiZS ODTuIYFBsvXLT1v5rzenAoHROY3Taut3m9vmoSKV4Jny1gnEv/x+urbVC6/Fo/n8Ns1g Eii1vTTbOYrslzGxM7KKIcAGjKoQPXcG1npMzbB/oNh0ycgPqW8Fmx/Rp+QUf07VSDgX 6gzEniOrweSHx+2MFP8fxWeBhkB8WCsGOOfhLWvMlunqheICS5faCsHuQ6snFCd7NEyU xLEg== X-Gm-Message-State: AOJu0YxeVu+I0csYWS4HvdsntkPrJ/fjvr83HlFSUjOxfVo9PnNHJGT3 leGokOOIs5BTodIL9xp083qB3DQ7jbUrwE2Vb+d2fGcssZMrRUjvilppNWWAMSWfc5iDPAsAot1 h7eEIhQIX+07+2tv0XrZYn+m03bGvUsvzxA8= X-Gm-Gg: ASbGnctiN0Sdi5KHELf64F4aeSl/rJ3VznOtYeqiyfQ1/WZYS4Yso4wxgQ7NHT/6qEe IcF2N/ZHsZ+s7cYv1fmqYWS8BkmCMm8vAYD4wUjsMD68sIsyBCrqa3jDUukEtAhiHuA55vOGOxe 50y/TXXbPZ0w== X-Google-Smtp-Source: AGHT+IEI/cBLYAVTD642qL8Ysd/T/AeOWSUweP6ne8cO8A22uHCDJXJyuxh/HyaoeBnngCS0aTl4EHvL/90MT7hj61U= X-Received: by 2002:a05:6402:3488:b0:5e0:51a9:d425 with SMTP id 4fb4d7f45d1cf-5e0b724ecfcmr14108846a12.29.1740432422761; Mon, 24 Feb 2025 13:27:02 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 24 Feb 2025 21:27:01 +0000 From: Stefan Kangas MIME-Version: 1.0 Date: Mon, 24 Feb 2025 21:27:01 +0000 X-Gm-Features: AWEUYZl_EchKberoASRoxFK-lTgm-qumpZJVNCWzdlaei4GP7QPVoJuj9GEbju4 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: unarchive 72848 forcemerge 72848 72104 thanks Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:52b listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines 2.0 BLANK_SUBJECT Subject is present but empty X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) unarchive 72848 forcemerge 72848 72104 thanks From unknown Wed Jun 18 00:21:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 25 Mar 2025 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator