GNU bug report logs - #72838
[PATCH core-updates] gnu: ffmpeg: Fix build on i686 with binutils 2.41.

Previous Next

Package: guix-patches;

Reported by: André Batista <nandre <at> riseup.net>

Date: Tue, 27 Aug 2024 18:48:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: André Batista <nandre <at> riseup.net>
Subject: bug#72838: closed (Re: bug#72838: [PATCH core-updates] gnu:
 ffmpeg: Fix build on i686 with binutils 2.41.)
Date: Wed, 28 Aug 2024 21:17:01 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#72838: [PATCH core-updates] gnu: ffmpeg: Fix build on i686 with binutils 2.41.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 72838 <at> debbugs.gnu.org.

-- 
72838: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=72838
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Ludovic Courtès <ludo <at> gnu.org>
To: André Batista <nandre <at> riseup.net>
Cc: 72838-done <at> debbugs.gnu.org
Subject: Re: bug#72838: [PATCH core-updates] gnu: ffmpeg: Fix build on i686
 with binutils 2.41.
Date: Wed, 28 Aug 2024 23:15:00 +0200
[Message part 3 (text/plain, inline)]
Hello,

André Batista <nandre <at> riseup.net> skribis:

> * gnu/packages/video.scm (ffmpeg): Add 'bypass-openal-check phase
> which breaks configure phase on i686. Unconditionally set openal
> configure check to true.

Applied with the change below to avoid a rebuild on other systems.

Thanks!

Ludo’.

[Message part 4 (text/x-patch, inline)]
diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index e2720628bb..ac89562a55 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1835,15 +1835,18 @@ (define-public ffmpeg
          "--disable-mipsfpu")
       #:phases
       #~(modify-phases %standard-phases
-          (add-before 'configure 'bypass-openal-check
-            ;; configure fails linking to openal when using binutils >= 2.38
-            ;; due to openal's usage of protected visibility for its dynamic
-            ;; symbols. Bypass this configure time check for now. See:
-            ;; https://lists.gnu.org/archive/html/guix-devel/2024-08/msg00159.html
-            (lambda _
-              (substitute* "configure"
-                (("alGetError \\|\\|")
-                 "alGetError \|\| true \|\|"))))
+          #$@(if (target-x86-32?)
+                 #~((add-before 'configure 'bypass-openal-check
+                      ;; configure fails linking to openal when using binutils
+                      ;; >= 2.38 due to openal's usage of protected visibility
+                      ;; for its dynamic symbols. Bypass this configure time
+                      ;; check for now. See:
+                      ;; https://lists.gnu.org/archive/html/guix-devel/2024-08/msg00159.html
+                      (lambda _
+                        (substitute* "configure"
+                          (("alGetError \\|\\|")
+                           "alGetError \|\| true \|\|")))))
+                 #~())
           (replace 'configure
             ;; configure does not work followed by "SHELL=..." and
             ;; "CONFIG_SHELL=..."; set environment variables instead
[Message part 5 (message/rfc822, inline)]
From: André Batista <nandre <at> riseup.net>
To: guix-patches <at> gnu.org
Cc: André Batista <nandre <at> riseup.net>
Subject: [PATCH core-updates] gnu: ffmpeg: Fix build on i686 with binutils
 2.41.
Date: Tue, 27 Aug 2024 15:46:26 -0300
* gnu/packages/video.scm (ffmpeg): Add 'bypass-openal-check phase
which breaks configure phase on i686. Unconditionally set openal
configure check to true.
---
 gnu/packages/video.scm | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index f7d58ab8f5..e2720628bb 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1835,6 +1835,15 @@ (define-public ffmpeg
          "--disable-mipsfpu")
       #:phases
       #~(modify-phases %standard-phases
+          (add-before 'configure 'bypass-openal-check
+            ;; configure fails linking to openal when using binutils >= 2.38
+            ;; due to openal's usage of protected visibility for its dynamic
+            ;; symbols. Bypass this configure time check for now. See:
+            ;; https://lists.gnu.org/archive/html/guix-devel/2024-08/msg00159.html
+            (lambda _
+              (substitute* "configure"
+                (("alGetError \\|\\|")
+                 "alGetError \|\| true \|\|"))))
           (replace 'configure
             ;; configure does not work followed by "SHELL=..." and
             ;; "CONFIG_SHELL=..."; set environment variables instead

base-commit: 87cc46aefce0072dc83e667d85a59a34eecfd89f
-- 
2.45.2




This bug report was last modified 296 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.