GNU bug report logs - #72838
[PATCH core-updates] gnu: ffmpeg: Fix build on i686 with binutils 2.41.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72838 in the body.
You can then email your comments to 72838 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: André Batista <nandre <at> riseup.net>
To: guix-patches <at> gnu.org
Cc: André Batista <nandre <at> riseup.net>
Subject: [PATCH core-updates] gnu: ffmpeg: Fix build on i686 with binutils
 2.41.
Date: Tue, 27 Aug 2024 15:46:26 -0300

* gnu/packages/video.scm (ffmpeg): Add 'bypass-openal-check phase
which breaks configure phase on i686. Unconditionally set openal
configure check to true.
---
 gnu/packages/video.scm | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index f7d58ab8f5..e2720628bb 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1835,6 +1835,15 @@ (define-public ffmpeg
          "--disable-mipsfpu")
       #:phases
       #~(modify-phases %standard-phases
+          (add-before 'configure 'bypass-openal-check
+            ;; configure fails linking to openal when using binutils >= 2.38
+            ;; due to openal's usage of protected visibility for its dynamic
+            ;; symbols. Bypass this configure time check for now. See:
+            ;; https://lists.gnu.org/archive/html/guix-devel/2024-08/msg00159.html
+            (lambda _
+              (substitute* "configure"
+                (("alGetError \\|\\|")
+                 "alGetError \|\| true \|\|"))))
           (replace 'configure
             ;; configure does not work followed by "SHELL=..." and
             ;; "CONFIG_SHELL=..."; set environment variables instead

base-commit: 87cc46aefce0072dc83e667d85a59a34eecfd89f
-- 
2.45.2

Message #10 received at 72838-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: André Batista <nandre <at> riseup.net>
Cc: 72838-done <at> debbugs.gnu.org
Subject: Re: bug#72838: [PATCH core-updates] gnu: ffmpeg: Fix build on i686
 with binutils 2.41.
Date: Wed, 28 Aug 2024 23:15:00 +0200

[Message part 1 (text/plain, inline)]

Hello,

André Batista <nandre <at> riseup.net> skribis:

> * gnu/packages/video.scm (ffmpeg): Add 'bypass-openal-check phase
> which breaks configure phase on i686. Unconditionally set openal
> configure check to true.

Applied with the change below to avoid a rebuild on other systems.

Thanks!

Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index e2720628bb..ac89562a55 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1835,15 +1835,18 @@ (define-public ffmpeg
          "--disable-mipsfpu")
       #:phases
       #~(modify-phases %standard-phases
-          (add-before 'configure 'bypass-openal-check
-            ;; configure fails linking to openal when using binutils >= 2.38
-            ;; due to openal's usage of protected visibility for its dynamic
-            ;; symbols. Bypass this configure time check for now. See:
-            ;; https://lists.gnu.org/archive/html/guix-devel/2024-08/msg00159.html
-            (lambda _
-              (substitute* "configure"
-                (("alGetError \\|\\|")
-                 "alGetError \|\| true \|\|"))))
+          #$@(if (target-x86-32?)
+                 #~((add-before 'configure 'bypass-openal-check
+                      ;; configure fails linking to openal when using binutils
+                      ;; >= 2.38 due to openal's usage of protected visibility
+                      ;; for its dynamic symbols. Bypass this configure time
+                      ;; check for now. See:
+                      ;; https://lists.gnu.org/archive/html/guix-devel/2024-08/msg00159.html
+                      (lambda _
+                        (substitute* "configure"
+                          (("alGetError \\|\\|")
+                           "alGetError \|\| true \|\|")))))
+                 #~())
           (replace 'configure
             ;; configure does not work followed by "SHELL=..." and
             ;; "CONFIG_SHELL=..."; set environment variables instead

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.