GNU bug report logs - #72835
[PATCH qt-team 00/38] update qt6 to 6.7.2

Previous Next

Full log

View this message in rfc822 format

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
Cc: 72835 <at> debbugs.gnu.org, 宋文武 <iyzsong <at> envs.net>
Subject: [bug#72835] [PATCH qt-team 23/38] gnu: qt-creator: Update to 14.0.1.
Date: Thu, 26 Sep 2024 12:51:49 +0900

Hi,

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:

> Hi,
>
> Zheng Junjie <zhengjunjie <at> iscas.ac.cn> writes:
>
>> * gnu/packages/qt.scm (qt-creator): Update to 14.0.1.
>> [source]: Adjust snippet.
>> [arguments]<#:phases>: adjust patch-paths phase.
>>
>> Change-Id: Ideafcf3a7c0ce9c85025472d41fb72527cc4b9fb
>> ---
>>  gnu/packages/qt.scm | 10 +++++++---
>>  1 file changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
>> index bf7eaa8546..f322b02d91 100644
>> --- a/gnu/packages/qt.scm
>> +++ b/gnu/packages/qt.scm
>> @@ -5550,7 +5550,7 @@ (define-public clazy
>>  (define-public qt-creator
>>    (package
>>      (name "qt-creator")
>> -    (version "12.0.2")
>> +    (version "14.0.1")
>>      (source (origin
>>                (method url-fetch)
>>                (uri (string-append
>> @@ -5567,13 +5567,17 @@ (define-public qt-creator
>>                               ;; Marketplace recommends nonfree extensions;
>>                               ;; remove it.
>>                               "src/plugins/marketplace"))
>> +                          (mkdir-p "src/libs/3rdparty/yaml-cpp")
>> +                          (call-with-output-file "src/libs/3rdparty/yaml-cpp/LICENSE"
>> +                            (lambda (port)
>> +                              (const #t)))
>
> Why is the above necessary?  An explanatory comment would be nice.

I think that's my only comment which hasn't been addressed; if you
could, that'd be nice.  Otherwise I've already added my Reviewed-by tag
so feel free to push at your convenience.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.