From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 23 21:35:25 2010 Received: (at submit) by debbugs.gnu.org; 24 Oct 2010 01:35:25 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P9pUa-00052w-ID for submit@debbugs.gnu.org; Sat, 23 Oct 2010 21:35:25 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P9pUX-00052r-RW for submit@debbugs.gnu.org; Sat, 23 Oct 2010 21:35:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P9pYM-0004OY-Ei for submit@debbugs.gnu.org; Sat, 23 Oct 2010 21:39:19 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:54235) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P9pYM-0004OS-BQ for submit@debbugs.gnu.org; Sat, 23 Oct 2010 21:39:18 -0400 Received: from [140.186.70.92] (port=45313 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P9pYK-0007ty-GC for bug-coreutils@gnu.org; Sat, 23 Oct 2010 21:39:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P9pYI-0004Nj-MQ for bug-coreutils@gnu.org; Sat, 23 Oct 2010 21:39:16 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:45961) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P9pYI-0004NX-8h for bug-coreutils@gnu.org; Sat, 23 Oct 2010 21:39:14 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 324B739E80B1 for ; Sat, 23 Oct 2010 18:39:13 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LhZ2O7ylln8u for ; Sat, 23 Oct 2010 18:39:12 -0700 (PDT) Received: from [192.168.1.10] (pool-71-189-109-235.lsanca.fios.verizon.net [71.189.109.235]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id E5C5A39E80DF for ; Sat, 23 Oct 2010 18:39:11 -0700 (PDT) Message-ID: <4CC38E3F.8070607@cs.ucla.edu> Date: Sat, 23 Oct 2010 18:39:11 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.11) Gecko/20101006 Thunderbird/3.1.5 MIME-Version: 1.0 To: bug-coreutils@gnu.org Subject: tail-2/F-vs-missing failure on RHEL 5.5 x86-64 + NetApp filer Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.7 (----) I got the following failure when running "make test" on RHEL 5.5 x86-64 when the build directory is served from a Network Appliance filer. I'm no expert in what "tail" is supposed to do here, but a casual look at the output makes it appear that it might just be a bug in the test program. The filer does suffer from minor clock skew with respect to the RHEL client. FAIL: tail-2/F-vs-missing (exit: 1) =================================== ++ initial_cwd_=/u/cs/fac/eggert/src/gnu/cu-tmp/tests +++ testdir_prefix_ +++ printf gt ++ pfx_=gt +++ mktempd_ /u/cs/fac/eggert/src/gnu/cu-tmp/tests gt-F-vs-missing.XXXX +++ case $# in +++ destdir_=/u/cs/fac/eggert/src/gnu/cu-tmp/tests +++ template_=gt-F-vs-missing.XXXX +++ MAX_TRIES_=4 +++ case $destdir_ in +++ case $template_ in +++ fail=0 ++++ unset TMPDIR ++++ mktemp -d -t -p /u/cs/fac/eggert/src/gnu/cu-tmp/tests gt-F-vs-missing.XXXX +++ d=/u/cs/fac/eggert/src/gnu/cu-tmp/tests/gt-F-vs-missing.PmAp +++ case $d in +++ test -d /u/cs/fac/eggert/src/gnu/cu-tmp/tests/gt-F-vs-missing.PmAp ++++ ls -dgo /u/cs/fac/eggert/src/gnu/cu-tmp/tests/gt-F-vs-missing.PmAp ++++ tr S - +++ perms='drwx------ 2 4096 Oct 23 2010 /u/cs/fac/eggert/src/gnu/cu-tmp/tests/gt-F-vs-missing.PmAp' +++ case $perms in +++ test 0 = 0 +++ echo /u/cs/fac/eggert/src/gnu/cu-tmp/tests/gt-F-vs-missing.PmAp +++ return ++ test_dir_=/u/cs/fac/eggert/src/gnu/cu-tmp/tests/gt-F-vs-missing.PmAp ++ cd /u/cs/fac/eggert/src/gnu/cu-tmp/tests/gt-F-vs-missing.PmAp ++ for sig_ in 1 2 3 13 15 +++ expr 1 + 128 ++ eval 'trap '\''Exit 129'\'' 1' +++ trap 'Exit 129' 1 ++ for sig_ in 1 2 3 13 15 +++ expr 2 + 128 ++ eval 'trap '\''Exit 130'\'' 2' +++ trap 'Exit 130' 2 ++ for sig_ in 1 2 3 13 15 +++ expr 3 + 128 ++ eval 'trap '\''Exit 131'\'' 3' +++ trap 'Exit 131' 3 ++ for sig_ in 1 2 3 13 15 +++ expr 13 + 128 ++ eval 'trap '\''Exit 141'\'' 13' +++ trap 'Exit 141' 13 ++ for sig_ in 1 2 3 13 15 +++ expr 15 + 128 ++ eval 'trap '\''Exit 143'\'' 15' +++ trap 'Exit 143' 15 ++ trap remove_tmp_ 0 + path_prepend_ ../src + test 1 '!=' 0 + path_dir_=../src + case $path_dir_ in ++ cd /u/cs/fac/eggert/src/gnu/cu-tmp/tests/../src ++ echo /u/cs/fac/eggert/src/gnu/cu-tmp/src + abs_path_dir_=/u/cs/fac/eggert/src/gnu/cu-tmp/src + case $abs_path_dir_ in + PATH=/u/cs/fac/eggert/src/gnu/cu-tmp/src:/u/cs/fac/eggert/src/gnu/cu-tmp/src:/u/cs/fac/eggert/bin:/usr/local/cs/bin:/usr/local/bin:/usr/local/sbin:/usr/bin:/usr/sbin:/usr/X11R6/bin:/bin:/sbin + create_exe_shims_ /u/cs/fac/eggert/src/gnu/cu-tmp/src + case $EXEEXT in + return 0 + shift + test 0 '!=' 0 + export PATH + test yes = yes + tail --version tail (GNU coreutils) 8.6.9-d5d8-dirty Copyright (C) 2010 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later . This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by Paul Rubin, David MacKenzie, Ian Lance Taylor, and Jim Meyering. + debug=---disable-inotify + debug= + tail -F -s.1 missing/file + pid=21936 + tail_re='cannot open' + retry_delay_ check_tail_output .1 7 + local test_func=check_tail_output + local init_delay=.1 + local max_n_tries=7 + local attempt=1 + local num_sleeps=1 + local time_fail + test 1 -le 7 ++ gawk -v n=1 -v s=.1 'BEGIN { for (i=0;i) id 1PA0cZ-0002Jo-8R for submit@debbugs.gnu.org; Sun, 24 Oct 2010 09:28:23 -0400 Received: from mail1.slb.deg.dub.stisp.net ([84.203.253.98]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1PA0cW-0002Jj-Oe for 7274-done@debbugs.gnu.org; Sun, 24 Oct 2010 09:28:21 -0400 Received: (qmail 7747 invoked from network); 24 Oct 2010 13:32:18 -0000 Received: from unknown (HELO ?192.168.2.25?) (84.203.137.218) by mail1.slb.deg.dub.stisp.net with SMTP; 24 Oct 2010 13:32:18 -0000 Message-ID: <4CC43558.4010207@draigBrady.com> Date: Sun, 24 Oct 2010 14:32:08 +0100 From: =?UTF-8?B?UMOhZHJhaWcgQnJhZHk=?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3 MIME-Version: 1.0 To: Paul Eggert Subject: Re: bug#7274: tail-2/F-vs-missing failure on RHEL 5.5 x86-64 + NetApp filer References: <4CC38E3F.8070607@cs.ucla.edu> In-Reply-To: <4CC38E3F.8070607@cs.ucla.edu> X-Enigmail-Version: 1.0.1 Content-Type: multipart/mixed; boundary="------------030201040900090204070800" X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 7274-done Cc: 7274-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) This is a multi-part message in MIME format. --------------030201040900090204070800 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 24/10/10 02:39, Paul Eggert wrote: > I got the following failure when running "make test" > on RHEL 5.5 x86-64 when the build directory is served > from a Network Appliance filer. I'm no expert in what > "tail" is supposed to do here, but a casual look at the > output makes it appear that it might just be a bug in > the test program. The filer does suffer from minor > clock skew with respect to the RHEL client. > > FAIL: tail-2/F-vs-missing (exit: 1) > =================================== > > tail: cannot open `missing/file' for reading: No such file or directory > tail: cannot watch parent directory of `missing/file': No such file or directory > tail: inotify cannot be used, reverting to polling > tail: `missing/file' has been replaced with a remote file. giving up on this name > + fail=1 Seems like an edge case I didn't consider in 61b77891 Hopefully the attached fixes it. cheers, Pádraig. --------------030201040900090204070800 Content-Type: text/x-patch; name="tail-F-missing-remote.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="tail-F-missing-remote.diff" >From d0781181b44e26e81e5daf7ec7de8fd84fecab35 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?P=C3=A1draig=20Brady?= Date: Sun, 24 Oct 2010 14:02:12 +0100 Subject: [PATCH] tail: support rechecking remote files in currently missing dirs src/tail.c (main): As an optimization, don't bother checking stdin or for remote files, when ---disable-inotify specified. To improve the fix in commit 61b77891, set the disable_inotify flag when we fall back to polling, so that we recheck remote files. NEWS: Mention the fix --- NEWS | 5 +++++ src/tail.c | 1 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index f28c243..7dbbf1f 100644 --- a/NEWS +++ b/NEWS @@ -2,6 +2,11 @@ GNU coreutils NEWS -*- outline -*- * Noteworthy changes in release ?.? (????-??-??) [?] +** Bug fixes + + tail -F once again notices changes in a currently unavailable + remote directory [bug introduced in coreutils-7.5] + * Noteworthy changes in release 8.6 (2010-10-15) [stable] diff --git a/src/tail.c b/src/tail.c index 68cc819..5c8f9a3 100644 --- a/src/tail.c +++ b/src/tail.c @@ -2189,6 +2189,7 @@ main (int argc, char **argv) error (0, errno, _("inotify cannot be used, reverting to polling")); } #endif + disable_inotify = true; tail_forever (F, n_files, sleep_interval); } -- 1.6.2.5 --------------030201040900090204070800-- From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 24 16:36:15 2010 Received: (at 7274-done) by debbugs.gnu.org; 24 Oct 2010 20:36:15 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PA7Ic-0007Tx-9N for submit@debbugs.gnu.org; Sun, 24 Oct 2010 16:36:14 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PA7IY-0007Tp-M5 for 7274-done@debbugs.gnu.org; Sun, 24 Oct 2010 16:36:12 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 96B4339E80DF; Sun, 24 Oct 2010 13:40:09 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pyrANb9B7ZJu; Sun, 24 Oct 2010 13:40:09 -0700 (PDT) Received: from [192.168.1.10] (pool-71-189-109-235.lsanca.fios.verizon.net [71.189.109.235]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 25F5F39E80DB; Sun, 24 Oct 2010 13:40:09 -0700 (PDT) Message-ID: <4CC499A8.8030706@cs.ucla.edu> Date: Sun, 24 Oct 2010 13:40:08 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.11) Gecko/20101006 Thunderbird/3.1.5 MIME-Version: 1.0 To: =?UTF-8?B?UMOhZHJhaWcgQnJhZHk=?= Subject: Re: bug#7274: tail-2/F-vs-missing failure on RHEL 5.5 x86-64 + NetApp filer References: <4CC38E3F.8070607@cs.ucla.edu> <4CC43558.4010207@draigBrady.com> In-Reply-To: <4CC43558.4010207@draigBrady.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 7274-done Cc: 7274-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) On 10/24/2010 06:32 AM, P=C3=A1draig Brady wrote: > [PATCH] tail: support rechecking remote files in currently missing dirs Thanks, that was fast! I verified that it fixed the bug in my RHEL 5.5 + NetApp environment. From unknown Sat Aug 16 12:44:32 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 22 Nov 2010 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator