GNU bug report logs - #72739
[PATCH] * lisp/gnus/gnus-sum.el: Handle leafs with children in summary line

Previous Next

To reply to this bug, email your comments to 72739 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Blyte Scholar <bs <at> blyte.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] * lisp/gnus/gnus-sum.el: Handle leafs with children in
 summary line
Date: Tue, 20 Aug 2024 17:44:48 -0400

[Message part 1 (text/plain, inline)]

Tags: patch

Tags: patch

Tags: patch


This patch adds customization options which handle the cases where a
thread leaf has both siblings and children. This allows using box
drawing characters to seamlessly connect all messages in a
thread. Previously, there would be messages could either be connected to
a sibling or a child, but not both.



In GNU Emacs 31.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version
 3.24.43, cairo version 1.18.0) of 2024-08-20 built on rhipidon
Repository revision: 5d435afc0e389e107fcee8d63405078341592f97
Repository branch: master
System Description: Fedora Linux 40 (Workstation Edition)

Configured using:
 'configure --with-imagemagick --with-tree-sitter
 --with-native-compilation=aot --with-pgtk'

[0001-lisp-gnus-gnus-sum.el-Handle-leafs-with-children-in-.patch (text/patch, attachment)]

Message #8 received at 72739 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Blyte Scholar <bs <at> blyte.net>, eric <at> ericabrahamsen.net
Cc: 72739 <at> debbugs.gnu.org
Subject: Re: bug#72739: [PATCH] * lisp/gnus/gnus-sum.el: Handle leafs with
 children in summary line
Date: Sat, 24 Aug 2024 12:14:07 +0300

> From: Blyte Scholar <bs <at> blyte.net>
> Date: Tue, 20 Aug 2024 17:44:48 -0400
> 
> Tags: patch
> 
> 
> This patch adds customization options which handle the cases where a
> thread leaf has both siblings and children. This allows using box
> drawing characters to seamlessly connect all messages in a
> thread. Previously, there would be messages could either be connected to
> a sibling or a child, but not both.

Eric, any comments?

Message #11 received at 72739 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Blyte Scholar <bs <at> blyte.net>, eric <at> ericabrahamsen.net
Cc: 72739 <at> debbugs.gnu.org
Subject: Re: bug#72739: [PATCH] * lisp/gnus/gnus-sum.el: Handle leafs with
 children in summary line
Date: Sat, 31 Aug 2024 11:14:25 +0300

> From: Blyte Scholar <bs <at> blyte.net>
> Date: Tue, 20 Aug 2024 17:44:48 -0400
> 
> Tags: patch
> 
> 
> This patch adds customization options which handle the cases where a
> thread leaf has both siblings and children. This allows using box
> drawing characters to seamlessly connect all messages in a
> thread. Previously, there would be messages could either be connected to
> a sibling or a child, but not both.

Thanks.

Eric, any comments to the patch or the issue in general?

Message #14 received at 72739 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: eric <at> ericabrahamsen.net
Cc: 72739 <at> debbugs.gnu.org, bs <at> blyte.net
Subject: Re: bug#72739: [PATCH] * lisp/gnus/gnus-sum.el: Handle leafs with
 children in summary line
Date: Sat, 07 Sep 2024 10:13:53 +0300

Ping!

> Cc: 72739 <at> debbugs.gnu.org
> Date: Sat, 24 Aug 2024 12:14:07 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> 
> > From: Blyte Scholar <bs <at> blyte.net>
> > Date: Tue, 20 Aug 2024 17:44:48 -0400
> > 
> > Tags: patch
> > 
> > 
> > This patch adds customization options which handle the cases where a
> > thread leaf has both siblings and children. This allows using box
> > drawing characters to seamlessly connect all messages in a
> > thread. Previously, there would be messages could either be connected to
> > a sibling or a child, but not both.
> 
> Eric, any comments?
> 
> 
> 
> 

Message #17 received at 72739 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Blyte Scholar <bs <at> blyte.net>
Cc: Andrew Cohen <acohen <at> ust.hk>, 72739 <at> debbugs.gnu.org,
 Eric Abrahamsen <eric <at> ericabrahamsen.net>
Subject: Re: bug#72739: [PATCH] * lisp/gnus/gnus-sum.el: Handle leafs with
 children in summary line
Date: Sun, 23 Feb 2025 00:25:54 +0000

Blyte Scholar <bs <at> blyte.net> writes:

> This patch adds customization options which handle the cases where a
> thread leaf has both siblings and children. This allows using box
> drawing characters to seamlessly connect all messages in a
> thread. Previously, there would be messages could either be connected to
> a sibling or a child, but not both.

Andrew, Eric, could you please help review the below patch?

> From fca49a37ec7cc0c512290de93dd8311ca5a012d6 Mon Sep 17 00:00:00 2001
> From: Blyte Scholar <bs <at> blyte.net>
> Date: Tue, 20 Aug 2024 17:32:10 -0400
> Subject: [PATCH] * lisp/gnus/gnus-sum.el: Handle leafs with children in
>  summary line
>
> (gnus-sum-thread-tree-leaf-with-other-root): New variable.
> (gnus-sum-thread-tree-single-leaf-root): New variable.
> (gnus-summary-prepare-threads):
> Use gnus-sum-thread-tree-leaf-with-other-root and
> gnus-sum-thread-single-leaf-root strings in summary line when they are
> available.
> ---
>  lisp/gnus/gnus-sum.el | 24 ++++++++++++++++++++++--
>  1 file changed, 22 insertions(+), 2 deletions(-)
>
> diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el
> index a9caa83b15c..2fd342f3a0c 100644
> --- a/lisp/gnus/gnus-sum.el
> +++ b/lisp/gnus/gnus-sum.el
> @@ -5193,12 +5193,26 @@ gnus-sum-thread-tree-leaf-with-other
>    :type 'string
>    :group 'gnus-thread)
>
> +(defcustom gnus-sum-thread-tree-leaf-with-other-root nil
> +  "With %B spec, used for a leaf with brothers and children.
> +If nil use `gnus-sum-thread-tree-leaf-with-other' instead."
> +  :version "31.1"
> +  :type 'string
> +  :group 'gnus-thread)
> +
>  (defcustom gnus-sum-thread-tree-single-leaf "\\-> "
>    "With %B spec, used for a leaf without brothers."
>    :version "22.1"
>    :type 'string
>    :group 'gnus-thread)
>
> +(defcustom gnus-sum-thread-tree-single-leaf-root nil
> +  "With %B spec, used for a leaf without brothers but children.
> +If nil use `gnus-sum-thread-tree-leaf-single-leaf' instead."
> +  :version "31.1"
> +  :type 'string
> +  :group 'gnus-thread)
> +
>  (defcustom gnus-summary-display-while-building nil
>    "If non-nil, show and update the summary buffer as it's being built.
>  If the value is t, update the buffer after every line is inserted.  If
> @@ -5474,8 +5488,14 @@ gnus-summary-prepare-threads
>  					  gnus-sum-thread-tree-indent))
>  				      (cdr (reverse tree-stack))))
>  		       (if (nth 1 thread)
> -			   gnus-sum-thread-tree-leaf-with-other
> -			 gnus-sum-thread-tree-single-leaf)))))
> +                           (if (and gnus-sum-thread-tree-leaf-with-other-root
> +                                    (cadar thread))
> +                               gnus-sum-thread-tree-leaf-with-other-root
> +			     gnus-sum-thread-tree-leaf-with-other)
> +                         (if (and gnus-sum-thread-tree-single-leaf-root
> +                                  (cadar thread))
> +                             gnus-sum-thread-tree-single-leaf-root
> +			   gnus-sum-thread-tree-single-leaf))))))
>  	    (when (string= gnus-tmp-name "")
>  	      (setq gnus-tmp-name gnus-tmp-from))
>  	    (unless (numberp gnus-tmp-lines)

Message #20 received at 72739 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Cohen <acohen <at> ust.hk>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: Eric Abrahamsen <eric <at> ericabrahamsen.net>, 72739 <at> debbugs.gnu.org,
 Blyte Scholar <bs <at> blyte.net>
Subject: Re: bug#72739: [PATCH] * lisp/gnus/gnus-sum.el: Handle leafs with
 children in summary line
Date: Mon, 24 Feb 2025 07:34:02 +0800

I think this change is fine (I'm already using it:)).  It would be good
to also update the gnus manual to mention these two new threading
variables.

Also, the box drawing vertical lines have large gaps, so I set
`line-spacing' to nil in gnus summary buffers, which minimizes (but does
not eliminate) the gaps. Is there an alternative?

>>>>> "SK" == Stefan Kangas <stefankangas <at> gmail.com> writes:

    SK> Blyte Scholar <bs <at> blyte.net> writes:
    >> This patch adds customization options which handle the cases
    >> where a thread leaf has both siblings and children. This allows
    >> using box drawing characters to seamlessly connect all messages
    >> in a thread. Previously, there would be messages could either be
    >> connected to a sibling or a child, but not both.

    SK> Andrew, Eric, could you please help review the below patch?

    >> From fca49a37ec7cc0c512290de93dd8311ca5a012d6 Mon Sep 17 00:00:00
    >> 2001 From: Blyte Scholar <bs <at> blyte.net> Date: Tue, 20 Aug 2024
    >> 17:32:10 -0400 Subject: [PATCH] * lisp/gnus/gnus-sum.el: Handle
    >> leafs with children in summary line
    >> 
    >> (gnus-sum-thread-tree-leaf-with-other-root): New variable.
    >> (gnus-sum-thread-tree-single-leaf-root): New variable.
    >> (gnus-summary-prepare-threads): Use
    >> gnus-sum-thread-tree-leaf-with-other-root and
    >> gnus-sum-thread-single-leaf-root strings in summary line when
    >> they are available.  --- lisp/gnus/gnus-sum.el | 24
    >> ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2
    >> deletions(-)
    >> 
    >> diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el index
    >> a9caa83b15c..2fd342f3a0c 100644 --- a/lisp/gnus/gnus-sum.el +++
    >> b/lisp/gnus/gnus-sum.el @@ -5193,12 +5193,26 @@
    >> gnus-sum-thread-tree-leaf-with-other :type 'string :group
    >> 'gnus-thread)
    >> 
    >> +(defcustom gnus-sum-thread-tree-leaf-with-other-root nil + "With
    >> %B spec, used for a leaf with brothers and children.  +If nil use
    >> `gnus-sum-thread-tree-leaf-with-other' instead."  + :version
    >> "31.1" + :type 'string + :group 'gnus-thread) + (defcustom
    >> gnus-sum-thread-tree-single-leaf "\\-> " "With %B spec, used for
    >> a leaf without brothers."  :version "22.1" :type 'string :group
    >> 'gnus-thread)
    >> 
    >> +(defcustom gnus-sum-thread-tree-single-leaf-root nil + "With %B
    >> spec, used for a leaf without brothers but children.  +If nil use
    >> `gnus-sum-thread-tree-leaf-single-leaf' instead."  + :version
    >> "31.1" + :type 'string + :group 'gnus-thread) + (defcustom
    >> gnus-summary-display-while-building nil "If non-nil, show and
    >> update the summary buffer as it's being built.  If the value is
    >> t, update the buffer after every line is inserted.  If @@ -5474,8
    >> +5488,14 @@ gnus-summary-prepare-threads
    >> gnus-sum-thread-tree-indent)) (cdr (reverse tree-stack)))) (if
    >> (nth 1 thread) - gnus-sum-thread-tree-leaf-with-other -
    >> gnus-sum-thread-tree-single-leaf))))) + (if (and
    >> gnus-sum-thread-tree-leaf-with-other-root + (cadar thread)) +
    >> gnus-sum-thread-tree-leaf-with-other-root +
    >> gnus-sum-thread-tree-leaf-with-other) + (if (and
    >> gnus-sum-thread-tree-single-leaf-root + (cadar thread)) +
    >> gnus-sum-thread-tree-single-leaf-root +
    >> gnus-sum-thread-tree-single-leaf)))))) (when (string=
    >> gnus-tmp-name "") (setq gnus-tmp-name gnus-tmp-from)) (unless
    >> (numberp gnus-tmp-lines)

-- 
Andrew Cohen

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.