From unknown Sun Aug 17 10:26:11 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#72734] [PATCH] gnu: libfabric: Depend on PSM2 only on supported systems. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: leo@famulari.name, w@wmeyer.eu, guix-patches@gnu.org Resent-Date: Tue, 20 Aug 2024 15:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 72734 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 72734@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Leo Famulari , Wilko Meyer X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: Leo Famulari , Wilko Meyer Received: via spool by submit@debbugs.gnu.org id=B.172416597919066 (code B ref -1); Tue, 20 Aug 2024 15:00:02 +0000 Received: (at submit) by debbugs.gnu.org; 20 Aug 2024 14:59:39 +0000 Received: from localhost ([127.0.0.1]:33557 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgQKg-0004xS-Jm for submit@debbugs.gnu.org; Tue, 20 Aug 2024 10:59:38 -0400 Received: from lists.gnu.org ([209.51.188.17]:46996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgQKe-0004xK-CJ for submit@debbugs.gnu.org; Tue, 20 Aug 2024 10:59:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sgQJw-00038h-Mk for guix-patches@gnu.org; Tue, 20 Aug 2024 10:58:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sgQJv-0007EH-Cg; Tue, 20 Aug 2024 10:58:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=8VLcNSXl5ERvjucF+e8hhRCBYhTcAwZ75tYs/5qkfLs=; b=YQaomzQ3CHFr+a jXs8LELK2WlYLJZLuNbqcc7XnSr+gnZT7Iopd52MS/XSD7p4mav8H245b/Dic/HuJ3YkjH4TmT1h6 N1cKscr7bxdOmOqZz7TbXWnrrRcgC9/tMm/Ckx7DOF11vgb+c25mBqbOBpDYwM3u+yW8nxh7WVqAh m8n/oJe/sgw4aBvijulW8hp9osVMBrgUGJznFcjw1ri4oSY+2uLx/DS87xYJy0ZwTmlK2UoRYIB8X 6TEN7VyQ46p5H+qeouJOL7XazBcUOEZqqDPL5WbXxqmQ4dqdwm2S1FoZK6MJdUgm/HUbWFQ5Lu+or q3GIsbGZ8Y+7TyiBA1dQ==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Date: Tue, 20 Aug 2024 16:58:41 +0200 Message-ID: <5a4c44b1676fe59b115e132771cebf686f060f39.1724165876.git.ludo@gnu.org> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) From: Ludovic Courtès Fixes a regression introduced in 2a6ea3895bf554a70c699a1013d75ffa5407bcad, that would make ‘libfabric’ unsupported on non-x86_64 systems. * gnu/packages/linux.scm (libfabric)[inputs]: Define ‘if-supported’. Use it for ‘psm’ and ‘psm2, and remove labels. [arguments]: Remove ‘--enable-psm2’, which is unnecessary. Change-Id: I2a52ce6feb52b8773779a401088743491c3ad30b --- gnu/packages/linux.scm | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm index a2a3601246..fecae036fb 100644 --- a/gnu/packages/linux.scm +++ b/gnu/packages/linux.scm @@ -8928,17 +8928,20 @@ (define-public libfabric (sha256 (base32 "1znmw83rmippv0fwz0x7lgylfk17dr9ckll8lrm4z7kclspnqpj8")))) (build-system gnu-build-system) - (inputs `(("rdma-core" ,rdma-core) - ,@(match (%current-system) - ((member (package-supported-systems psm)) - `(("psm" ,psm))) - (_ `())) - ("psm2" ,psm2) - ("libnl" ,libnl))) + (inputs + (let ((if-supported ;XXX: copied from openmpi + (lambda (package) + (if (and (not (%current-target-system)) + (member (%current-system) + (package-supported-systems package))) + (list package) + '())))) + (append (list rdma-core libnl) + (if-supported psm) + (if-supported psm2)))) (arguments (list #:configure-flags - #~(list "--enable-psm2" - "--enable-efa" + #~(list "--enable-efa" "--enable-verbs"))) (home-page "https://ofiwg.github.io/libfabric/") (synopsis "Open Fabric Interfaces") base-commit: ce40b1c655edab622b4ad9ff49f948bd65753662 -- 2.45.2 From unknown Sun Aug 17 10:26:11 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#72734] [PATCH] gnu: libfabric: Depend on PSM2 only on supported systems. References: <5a4c44b1676fe59b115e132771cebf686f060f39.1724165876.git.ludo@gnu.org> In-Reply-To: <5a4c44b1676fe59b115e132771cebf686f060f39.1724165876.git.ludo@gnu.org> Resent-From: Marcel van der Boom Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 26 Aug 2024 12:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72734 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 72734@debbugs.gnu.org Received: via spool by 72734-submit@debbugs.gnu.org id=B72734.172467408811162 (code B ref 72734); Mon, 26 Aug 2024 12:09:01 +0000 Received: (at 72734) by debbugs.gnu.org; 26 Aug 2024 12:08:08 +0000 Received: from localhost ([127.0.0.1]:43845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1siYW0-0002ty-BI for submit@debbugs.gnu.org; Mon, 26 Aug 2024 08:08:08 -0400 Received: from read.hsdev.com ([209.250.245.235]:42922) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1siYVx-0002tP-71 for 72734@debbugs.gnu.org; Mon, 26 Aug 2024 08:08:06 -0400 Received: from [IPV6:2a10:3781:4bea:1:a4bd:52ff:fe44:591f] (unknown [IPv6:2a10:3781:4bea:1:a4bd:52ff:fe44:591f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) by read.hsdev.com (Postfix) with ESMTPSA id 0B23C2075C for <72734@debbugs.gnu.org>; Mon, 26 Aug 2024 14:07:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=van-der-boom.nl; s=202103; t=1724674026; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jeue2CKQEnI6NFxuyAPMW1lELQhdyvFbrR3Na+KEp3A=; b=X2RhYg90Zmid75ziL73+Tsa4dC76KH/jO/qxtJKxubhnzbxRxkFqTqIF5XSvlAVvtP6Avp wj1brGdIvErKNirYeGHdovhCgluCCed/Zl+8ptXW01BQzjUDNCaytJRKCfix0kgl6z0VFP Lf/fcYrFKpar6/QNExTz6IvEzVooddA= Message-ID: Date: Mon, 26 Aug 2024 14:07:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: nl, en-GB From: Marcel van der Boom Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.09 X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Can this patch be merged? my powerpc64le machine is affected by this bug. From unknown Sun Aug 17 10:26:11 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Subject: bug#72734: closed (Re: [bug#72734] [PATCH] gnu: libfabric: Depend on PSM2 only on supported systems.) Message-ID: References: <87h6b0irbu.fsf@gnu.org> <5a4c44b1676fe59b115e132771cebf686f060f39.1724165876.git.ludo@gnu.org> X-Gnu-PR-Message: they-closed 72734 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 72734@debbugs.gnu.org Date: Sat, 31 Aug 2024 16:36:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1725122162-18343-1" This is a multi-part message in MIME format... ------------=_1725122162-18343-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #72734: [PATCH] gnu: libfabric: Depend on PSM2 only on supported systems. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 72734@debbugs.gnu.org. --=20 72734: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D72734 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1725122162-18343-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 72734-done) by debbugs.gnu.org; 31 Aug 2024 16:35:54 +0000 Received: from localhost ([127.0.0.1]:55692 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1skR4s-0004lQ-5l for submit@debbugs.gnu.org; Sat, 31 Aug 2024 12:35:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1skR4q-0004l6-KB for 72734-done@debbugs.gnu.org; Sat, 31 Aug 2024 12:35:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1skR3o-0005ct-0u; Sat, 31 Aug 2024 12:34:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=WrR1V60uN0NgBVAyalGdKSol8nqg5aJLjSHBwbMCL3s=; b=e/FP/TFcdYCl+mTzBj5Q H+hua94u2AbzGRbuiBu942ettdWhePyCYiwRjXcPgjXtokb2kBJZyI85VHvwbAL9HBrj8GoUtUkNl OzLT3Ygl4v9xggSOuzOXTIg3rOY+UV/PkQxOfHK5s28UvpxJsReAe1KKgVGxWjnXYcA6484nJIUiQ ycoOH3GkwaGnOI219s2omCOZCQVCcQqQtlzgVVcnI8eV8WBHCWP9EwB3yFQROS1fjPPwH8U/ojw5S +33I3j0qVDr1yVqn+a0O9co330giEOeKrNNlCRVJPjfY/xBMDUyB6VJ/0u8n7rYxh3fyzdLSazOKw k5VvMSQ3ZncfZg==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Marcel van der Boom Subject: Re: [bug#72734] [PATCH] gnu: libfabric: Depend on PSM2 only on supported systems. In-Reply-To: (Marcel van der Boom's message of "Mon, 26 Aug 2024 14:07:05 +0200") References: <5a4c44b1676fe59b115e132771cebf686f060f39.1724165876.git.ludo@gnu.org> Date: Sat, 31 Aug 2024 18:34:45 +0200 Message-ID: <87h6b0irbu.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72734-done Cc: 72734-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Marcel, Marcel van der Boom skribis: > Can this patch be merged? my powerpc64le machine is affected by this bug. Sure, will push in a moment. The best way to get a patch applied is to review it, which you sorta did indirectly, so thanks! https://guix.gnu.org/manual/devel/en/html_node/Reviewing-the-Work-of-Othe= rs.html Ludo=E2=80=99. ------------=_1725122162-18343-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 20 Aug 2024 14:59:39 +0000 Received: from localhost ([127.0.0.1]:33557 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgQKg-0004xS-Jm for submit@debbugs.gnu.org; Tue, 20 Aug 2024 10:59:38 -0400 Received: from lists.gnu.org ([209.51.188.17]:46996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgQKe-0004xK-CJ for submit@debbugs.gnu.org; Tue, 20 Aug 2024 10:59:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sgQJw-00038h-Mk for guix-patches@gnu.org; Tue, 20 Aug 2024 10:58:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sgQJv-0007EH-Cg; Tue, 20 Aug 2024 10:58:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=8VLcNSXl5ERvjucF+e8hhRCBYhTcAwZ75tYs/5qkfLs=; b=YQaomzQ3CHFr+a jXs8LELK2WlYLJZLuNbqcc7XnSr+gnZT7Iopd52MS/XSD7p4mav8H245b/Dic/HuJ3YkjH4TmT1h6 N1cKscr7bxdOmOqZz7TbXWnrrRcgC9/tMm/Ckx7DOF11vgb+c25mBqbOBpDYwM3u+yW8nxh7WVqAh m8n/oJe/sgw4aBvijulW8hp9osVMBrgUGJznFcjw1ri4oSY+2uLx/DS87xYJy0ZwTmlK2UoRYIB8X 6TEN7VyQ46p5H+qeouJOL7XazBcUOEZqqDPL5WbXxqmQ4dqdwm2S1FoZK6MJdUgm/HUbWFQ5Lu+or q3GIsbGZ8Y+7TyiBA1dQ==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: guix-patches@gnu.org Subject: [PATCH] gnu: libfabric: Depend on PSM2 only on supported systems. Date: Tue, 20 Aug 2024 16:58:41 +0200 Message-ID: <5a4c44b1676fe59b115e132771cebf686f060f39.1724165876.git.ludo@gnu.org> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: Leo Famulari , Wilko Meyer Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) From: Ludovic Courtès Fixes a regression introduced in 2a6ea3895bf554a70c699a1013d75ffa5407bcad, that would make ‘libfabric’ unsupported on non-x86_64 systems. * gnu/packages/linux.scm (libfabric)[inputs]: Define ‘if-supported’. Use it for ‘psm’ and ‘psm2, and remove labels. [arguments]: Remove ‘--enable-psm2’, which is unnecessary. Change-Id: I2a52ce6feb52b8773779a401088743491c3ad30b --- gnu/packages/linux.scm | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm index a2a3601246..fecae036fb 100644 --- a/gnu/packages/linux.scm +++ b/gnu/packages/linux.scm @@ -8928,17 +8928,20 @@ (define-public libfabric (sha256 (base32 "1znmw83rmippv0fwz0x7lgylfk17dr9ckll8lrm4z7kclspnqpj8")))) (build-system gnu-build-system) - (inputs `(("rdma-core" ,rdma-core) - ,@(match (%current-system) - ((member (package-supported-systems psm)) - `(("psm" ,psm))) - (_ `())) - ("psm2" ,psm2) - ("libnl" ,libnl))) + (inputs + (let ((if-supported ;XXX: copied from openmpi + (lambda (package) + (if (and (not (%current-target-system)) + (member (%current-system) + (package-supported-systems package))) + (list package) + '())))) + (append (list rdma-core libnl) + (if-supported psm) + (if-supported psm2)))) (arguments (list #:configure-flags - #~(list "--enable-psm2" - "--enable-efa" + #~(list "--enable-efa" "--enable-verbs"))) (home-page "https://ofiwg.github.io/libfabric/") (synopsis "Open Fabric Interfaces") base-commit: ce40b1c655edab622b4ad9ff49f948bd65753662 -- 2.45.2 ------------=_1725122162-18343-1--