From unknown Sat Jun 14 19:43:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#72731: Wrong source comment in src/w32term.c Resent-From: Cecilio Pardo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Aug 2024 11:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 72731 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 72731@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.172415424929169 (code B ref -1); Tue, 20 Aug 2024 11:45:01 +0000 Received: (at submit) by debbugs.gnu.org; 20 Aug 2024 11:44:09 +0000 Received: from localhost ([127.0.0.1]:59956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgNHU-0007aO-Eh for submit@debbugs.gnu.org; Tue, 20 Aug 2024 07:44:09 -0400 Received: from lists.gnu.org ([209.51.188.17]:57368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgNHR-0007aG-TF for submit@debbugs.gnu.org; Tue, 20 Aug 2024 07:44:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sgNGk-00024k-5l for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2024 07:43:22 -0400 Received: from mail.imayhem.com ([82.223.54.191] helo=zealous-pike.82-223-54-191.plesk.page) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sgNGg-0007w4-Fh for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2024 07:43:21 -0400 Received: from [10.0.12.202] (66.red-2-136-43.staticip.rima-tde.net [2.136.43.66]) by zealous-pike.82-223-54-191.plesk.page (Postfix) with ESMTPSA id BFA0D800F2 for ; Tue, 20 Aug 2024 11:43:15 +0000 (UTC) Authentication-Results: zealous-pike.82-223-54-191.plesk.page; spf=pass (sender IP is 2.136.43.66) smtp.mailfrom=cpardo@imayhem.com smtp.helo=[10.0.12.202] Received-SPF: pass (zealous-pike.82-223-54-191.plesk.page: connection is authenticated) Message-ID: <24971b2b-a0a6-47ce-9f20-74324b88ea47@imayhem.com> Date: Tue, 20 Aug 2024 13:43:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: es-ES From: Cecilio Pardo Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=82.223.54.191; envelope-from=cpardo@imayhem.com; helo=zealous-pike.82-223-54-191.plesk.page X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) I think this comment in w32term.c is wrong:     ...     case WM_RBUTTONUP:     case WM_XBUTTONDOWN:     case WM_XBUTTONUP:       {             /* If we decide we want to generate an event to be seen                by the rest of Emacs, we put it here.  */         Lisp_Object tab_bar_arg = Qnil;         bool tab_bar_p = 0;     ... It was added on https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=791f420fea18d7ef5ddfc386509de2c84d4f39c3 + /* If we decide we want to generate an event to be seen + by the rest of Emacs, we put it here. */ + struct input_event emacs_event; + int tool_bar_p = 0; int button; int up; The comment is attached to the emacs_event variable? The variable was then removed on: https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=004b1d3853dbb7ef5c5b2e3b5d011718e602c33a /* If we decide we want to generate an event to be seen by the rest of Emacs, we put it here. */ - struct input_event emacs_event; int tool_bar_p = 0; int button; int up; But the comment stayed there for years to come. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 29 21:41:39 2024 Received: (at control) by debbugs.gnu.org; 30 Sep 2024 01:41:39 +0000 Received: from localhost ([127.0.0.1]:43530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sv5Pu-0000DW-Vz for submit@debbugs.gnu.org; Sun, 29 Sep 2024 21:41:39 -0400 Received: from mail-wr1-f45.google.com ([209.85.221.45]:56525) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sv5Ps-0000DO-N5 for control@debbugs.gnu.org; Sun, 29 Sep 2024 21:41:37 -0400 Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-37cc4e718ecso2584717f8f.0 for ; Sun, 29 Sep 2024 18:41:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727660399; x=1728265199; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=BUc62J1SyW5oQiGa/gTzIvKUsPfABtIS+lxOIuXipbw=; b=DY9Ab707DzHZkzaGjaviaLBcyvTDmUzCQsbxnoTCgTE5V+EFGZywNAQQoECMiIGtqx CRHB7pqWo6A0gLeilBpj7Z6zgDLAbAZCJR/q2t7Te8Fehu8xpI8zpiPj5KE4/AeV1eod yR7j3sOInLAfkLodcMqJr9zcizJfiD5OkFJghEh9dWlEG7lMQ5IJqbN5yVCN9s8MlHqE vlqo/Dtp83W4pKwvViEwUbiEIwpD8yo6Z/OmuwlLahFcpT7Ed91vyjRUJwHxQgMcv+oT tQ7TMauCWMzoiwdMdvA55whkD+xK0POlKbvspp8mEjrVL1xhIfd/3TFGY1Kw+7SNkqtn Hx+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727660399; x=1728265199; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=BUc62J1SyW5oQiGa/gTzIvKUsPfABtIS+lxOIuXipbw=; b=Ufpqh8W9S2rUw6uY07ra0nCQcxA2zSAH0ced7XXnZGwhwZgo8kuNrSb2OcZe5zOnSQ MLCLltTtpGHc+0Co5Sc7cnUGa9arZc/dZgbw7SzaLV8MuDB7Pz3w4Y76wkTQA5knCrVS AvYeHKMG5DXtgnPIMB47S81klCDg91VNZYsfKSo8qhMhfBOzniyFvUf+iRNUTVk7QSzd 6SJj5yXvYzH3XGlOK6+xqNbXbIhp5jv3ixfiQus8GNmm7l79e7Tz/4dGslgkoqxkQYG6 o6L970JU69YEVv1hyA7qY/8FzsqNB3hMp5jfqSu6e6trLsslLl3cCZZH2Gc9dk5dwaz/ HWPA== X-Gm-Message-State: AOJu0YwrXf9fgiL4HRSwUSj2baCFGhsb0avY7WqB33rcvfJVj3Dm65/3 Gvx2gs24yY6qShSCrblIVL83IxKXSxwimPNcyCk99+e4drJfm/r5a7fiXsc+u8bDnBV+GTn0eAI Hv2elu7JwoNRSsbg67DYfbclIqSc/xQ== X-Google-Smtp-Source: AGHT+IHa3My8frag7EZPU7MDrqq+l/lzhzpUJQkbeQC1Y3H+aUQQ0Ybicc/t7ILgbQ8vdYldLQaFJkK0SyjpcOlpabE= X-Received: by 2002:adf:e7c7:0:b0:37c:d2d9:f3f0 with SMTP id ffacd0b85a97d-37cd5a77bf1mr5185551f8f.16.1727660398481; Sun, 29 Sep 2024 18:39:58 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 29 Sep 2024 18:39:58 -0700 From: Stefan Kangas MIME-Version: 1.0 Date: Sun, 29 Sep 2024 18:39:58 -0700 Message-ID: Subject: control message for bug #72731 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.9 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) severity 72731 wishlist quit