GNU bug report logs - #72731
Wrong source comment in src/w32term.c

Previous Next

To reply to this bug, email your comments to 72731 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Cecilio Pardo <cpardo <at> imayhem.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Wrong source comment in src/w32term.c
Date: Tue, 20 Aug 2024 13:43:14 +0200

I think this comment in w32term.c is wrong:

    ...
    case WM_RBUTTONUP:
    case WM_XBUTTONDOWN:
    case WM_XBUTTONUP:
      {
            /* If we decide we want to generate an event to be seen
               by the rest of Emacs, we put it here.  */
        Lisp_Object tab_bar_arg = Qnil;
        bool tab_bar_p = 0;
    ...

It was added on

https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=791f420fea18d7ef5ddfc386509de2c84d4f39c3 


+ /* If we decide we want to generate an event to be seen
+ by the rest of Emacs, we put it here. */
+ struct input_event emacs_event;
+ int tool_bar_p = 0;
int button;
int up;


The comment is attached to the emacs_event variable?

The variable was then removed on:

https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=004b1d3853dbb7ef5c5b2e3b5d011718e602c33a 



/* If we decide we want to generate an event to be seen
by the rest of Emacs, we put it here. */
- struct input_event emacs_event;
int tool_bar_p = 0;
int button;
int up;


But the comment stayed there for years to come.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.