From unknown Sun Jun 22 08:05:24 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#72721 <72721@debbugs.gnu.org> To: bug#72721 <72721@debbugs.gnu.org> Subject: Status: 31.0.50; Visual-wrap-prefix-mode breaks Magit log buffers Reply-To: bug#72721 <72721@debbugs.gnu.org> Date: Sun, 22 Jun 2025 15:05:24 +0000 retitle 72721 31.0.50; Visual-wrap-prefix-mode breaks Magit log buffers reassign 72721 emacs submitter 72721 Gautier Ponsinet severity 72721 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 19 18:28:05 2024 Received: (at submit) by debbugs.gnu.org; 19 Aug 2024 22:28:05 +0000 Received: from localhost ([127.0.0.1]:59394 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgAr4-0002jQ-Ee for submit@debbugs.gnu.org; Mon, 19 Aug 2024 18:28:05 -0400 Received: from lists.gnu.org ([209.51.188.17]:57648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgA7g-0001Pf-46 for submit@debbugs.gnu.org; Mon, 19 Aug 2024 17:41:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sgA6z-0005aS-IP for bug-gnu-emacs@gnu.org; Mon, 19 Aug 2024 17:40:25 -0400 Received: from 14.mo550.mail-out.ovh.net ([178.32.97.215]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sgA6s-0000VZ-86 for bug-gnu-emacs@gnu.org; Mon, 19 Aug 2024 17:40:24 -0400 Received: from director9.ghost.mail-out.ovh.net (unknown [10.109.140.35]) by mo550.mail-out.ovh.net (Postfix) with ESMTP id 4WnmGZ1Bw7z1Txc for ; Mon, 19 Aug 2024 21:40:06 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-gj56x (unknown [10.110.178.240]) by director9.ghost.mail-out.ovh.net (Postfix) with ESMTPS id F21C01FD41 for ; Mon, 19 Aug 2024 21:40:03 +0000 (UTC) Received: from gautierponsinet.xyz ([37.59.142.109]) by ghost-submission-6684bf9d7b-gj56x with ESMTPSA id x9eXErO7w2Z4FyoAu//YcQ (envelope-from ) for ; Mon, 19 Aug 2024 21:40:03 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-109S0039d262141-b396-433e-93b6-aace20f402db, 2F08FAF67FC11C17368435EE60915FD3D9531CD4) smtp.auth=gautier@gautierponsinet.xyz X-OVh-ClientIp: 2.87.16.101 From: Gautier Ponsinet To: bug-gnu-emacs@gnu.org Subject: 31.0.50; Visual-wrap-prefix-mode breaks Magit log buffers X-Debbugs-Cc: Date: Mon, 19 Aug 2024 23:39:49 +0200 Message-ID: <87cym4ry3e.fsf@gautierponsinet.xyz> MIME-Version: 1.0 Content-Type: text/plain X-Ovh-Tracer-Id: 13525998530964481956 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 70 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeeftddrudduhedgtdduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucgfrhhlucfvnfffucdljedtmdenucfjughrpefhvffufffkgggtsehttdertddttddtnecuhfhrohhmpefirghuthhivghrucfrohhnshhinhgvthcuoehgrghuthhivghrsehgrghuthhivghrphhonhhsihhnvghtrdighiiiqeenucggtffrrghtthgvrhhnpeduveejgeetfeekjeehtdeghffgieeivdevleeiieeivdeihfdutdetveeigedvvdenucffohhmrghinhepghgruhhtihgvrhdrlhhotggrlhenucfkphepuddvjedrtddrtddruddpvddrkeejrdduiedruddtuddpfeejrdehledrudegvddruddtleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepghgruhhtihgvrhesghgruhhtihgvrhhpohhnshhinhgvthdrgiihiidpnhgspghrtghpthhtohepuddprhgtphhtthhopegsuhhgqdhgnhhuqdgvmhgrtghssehgnhhurdhorhhgpdfovfetjfhoshhtpehmohehhedtpdhmohguvgepshhmthhpohhuth DKIM-Signature: a=rsa-sha256; bh=3v1uKaaV36UwFicnvhVS9w8qM0lEE3ZC6whjsa1Et1M=; c=relaxed/relaxed; d=gautierponsinet.xyz; h=From; s=ovhmo4576755-selector1; t=1724103606; v=1; b=CEwVTNfZ35/ZVRX1YJSNM62oe6/gNuYAYQy8KW1H/zWnzotPQzzUaatyjNuYhu9iJadf0iPW YDKN7r5iyTCtbWyRxb187zoVP4Jp04vy+d1I/zNeXiNvXijHVo1EHroOJaqylj5xP1sKoAeXl2a YyOZNYhbWTQXYjnPRqxakhEfTy2vx/quSJJwNJiCTuLlhMrkaJOMdleNMZBAMK87WEKtdQO6R9R GYfAbk2JIwkagKVmfw975vj33n/G6a7nTzdpsLwyIReQAZvWYjBwaRFKd3zG+eIySe4McJfSWw9 zvOFaaiCnwO4lnhi/9fm8txb/xIB5hY+DhJkUZLIrKWeA== Received-SPF: pass client-ip=178.32.97.215; envelope-from=gautier@gautierponsinet.xyz; helo=14.mo550.mail-out.ovh.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 19 Aug 2024 18:28:01 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hello everyone, The new visual-wrap-prefix-mode breaks the rendering of the Magit Log buffers. In emacs -Q: * Install Magit and its dependencies and load Magit. * Go to a local repository (via M-x dired or M-x cd). * M-x global-visual-wrap-prefix-mode * M-x magit-log-current Could someone please confirm/reproduce? All the best, Gautier. ------------------------------------------------------------------------ In GNU Emacs 31.0.50 (build 67, x86_64-pc-linux-gnu, X toolkit, cairo version 1.18.0, Xaw3d scroll bars) of 2024-08-19 built on gautier-laptop Repository revision: a876c4d7a17df152e3e78800c76ddf158f632ee5 Repository branch: makepkg Windowing system distributor 'The X.Org Foundation', version 11.0.12101013 System Description: Arch Linux Configured using: 'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/var --mandir=/usr/share/man --with-gameuser=:games --with-modules --without-m17n-flt --without-gconf --with-native-compilation=no --with-xinput2 --with-x-toolkit=lucid --without-xft --with-xaw3d --with-sound=no --with-tree-sitter --without-gpm --without-compress-install '--program-transform-name=s/\([ec]tags\)/\1.emacs/' 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -g -ffile-prefix-map=/home/gautier/.packages/aur/emacs-git/src=/usr/src/debug/emacs-git -flto=auto' 'LDFLAGS=-Wl,-O1 -Wl,--sort-common -Wl,--as-needed -Wl,-z,relro -Wl,-z,now -Wl,-z,pack-relative-relocs -flto=auto'' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG LCMS2 LIBOTF LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XAW3D XDBE XIM XINPUT2 XPM LUCID ZLIB Important settings: value of $LANG: fr_FR.UTF-8 locale-coding-system: utf-8-unix Major mode: notmuch-hello Minor modes in effect: pdf-occur-global-minor-mode: t TeX-PDF-mode: t global-git-commit-mode: t magit-auto-revert-mode: t server-mode: t recentf-mode: t global-corfu-mode: t corfu-mode: t vertico-mode: t minibuffer-depth-indicate-mode: t delete-selection-mode: t global-goto-address-mode: t goto-address-mode: t pulsar-global-mode: t pulsar-mode: t lin-global-mode: t override-global-mode: t winner-mode: t repeat-mode: t global-word-wrap-whitespace-mode: t word-wrap-whitespace-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t window-divider-mode: t minibuffer-regexp-mode: t column-number-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/gautier/.local/share/emacs/packages/notmuch-20240816.2039/notmuch-tag hides /usr/share/emacs/site-lisp/notmuch-tag /home/gautier/.local/share/emacs/packages/notmuch-20240816.2039/notmuch hides /usr/share/emacs/site-lisp/notmuch /home/gautier/.local/share/emacs/packages/notmuch-20240816.2039/notmuch-wash hides /usr/share/emacs/site-lisp/notmuch-wash /home/gautier/.local/share/emacs/packages/notmuch-20240816.2039/notmuch-maildir-fcc hides /usr/share/emacs/site-lisp/notmuch-maildir-fcc /home/gautier/.local/share/emacs/packages/notmuch-20240816.2039/notmuch-hello hides /usr/share/emacs/site-lisp/notmuch-hello /home/gautier/.local/share/emacs/packages/notmuch-20240816.2039/notmuch-jump hides /usr/share/emacs/site-lisp/notmuch-jump /home/gautier/.local/share/emacs/packages/notmuch-20240816.2039/notmuch-mua hides /usr/share/emacs/site-lisp/notmuch-mua /home/gautier/.local/share/emacs/packages/notmuch-20240816.2039/notmuch-query hides /usr/share/emacs/site-lisp/notmuch-query /home/gautier/.local/share/emacs/packages/notmuch-20240816.2039/notmuch-print hides /usr/share/emacs/site-lisp/notmuch-print /home/gautier/.local/share/emacs/packages/notmuch-20240816.2039/notmuch-compat hides /usr/share/emacs/site-lisp/notmuch-compat /home/gautier/.local/share/emacs/packages/notmuch-20240816.2039/notmuch-company hides /usr/share/emacs/site-lisp/notmuch-company /home/gautier/.local/share/emacs/packages/notmuch-20240816.2039/notmuch-message hides /usr/share/emacs/site-lisp/notmuch-message /home/gautier/.local/share/emacs/packages/notmuch-20240816.2039/notmuch-parser hides /usr/share/emacs/site-lisp/notmuch-parser /home/gautier/.local/share/emacs/packages/notmuch-20240816.2039/notmuch-crypto hides /usr/share/emacs/site-lisp/notmuch-crypto /home/gautier/.local/share/emacs/packages/notmuch-20240816.2039/notmuch-address hides /usr/share/emacs/site-lisp/notmuch-address /home/gautier/.local/share/emacs/packages/notmuch-20240816.2039/notmuch-tree hides /usr/share/emacs/site-lisp/notmuch-tree /home/gautier/.local/share/emacs/packages/notmuch-20240816.2039/notmuch-show hides /usr/share/emacs/site-lisp/notmuch-show /home/gautier/.local/share/emacs/packages/notmuch-20240816.2039/coolj hides /usr/share/emacs/site-lisp/coolj /home/gautier/.local/share/emacs/packages/notmuch-20240816.2039/notmuch-draft hides /usr/share/emacs/site-lisp/notmuch-draft /home/gautier/.local/share/emacs/packages/notmuch-20240816.2039/notmuch-lib hides /usr/share/emacs/site-lisp/notmuch-lib /home/gautier/.local/share/emacs/packages/transient-20240819.1250/transient hides /usr/share/emacs/31.0.50/lisp/transient /home/gautier/.local/share/emacs/packages/modus-themes-20240811.502/theme-loaddefs hides /usr/share/emacs/31.0.50/lisp/theme-loaddefs /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-makefile hides /usr/share/emacs/31.0.50/lisp/org/ob-makefile /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-processing hides /usr/share/emacs/31.0.50/lisp/org/ob-processing /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-table hides /usr/share/emacs/31.0.50/lisp/org/ob-table /home/gautier/.local/share/emacs/packages/org-9.7.10/org-src hides /usr/share/emacs/31.0.50/lisp/org/org-src /home/gautier/.local/share/emacs/packages/org-9.7.10/org-clock hides /usr/share/emacs/31.0.50/lisp/org/org-clock /home/gautier/.local/share/emacs/packages/org-9.7.10/org-lint hides /usr/share/emacs/31.0.50/lisp/org/org-lint /home/gautier/.local/share/emacs/packages/org-9.7.10/ol-eww hides /usr/share/emacs/31.0.50/lisp/org/ol-eww /home/gautier/.local/share/emacs/packages/org-9.7.10/org-mobile hides /usr/share/emacs/31.0.50/lisp/org/org-mobile /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-plantuml hides /usr/share/emacs/31.0.50/lisp/org/ob-plantuml /home/gautier/.local/share/emacs/packages/org-9.7.10/org-table hides /usr/share/emacs/31.0.50/lisp/org/org-table /home/gautier/.local/share/emacs/packages/org-9.7.10/org-tempo hides /usr/share/emacs/31.0.50/lisp/org/org-tempo /home/gautier/.local/share/emacs/packages/org-9.7.10/oc-bibtex hides /usr/share/emacs/31.0.50/lisp/org/oc-bibtex /home/gautier/.local/share/emacs/packages/org-9.7.10/ox-texinfo hides /usr/share/emacs/31.0.50/lisp/org/ox-texinfo /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-C hides /usr/share/emacs/31.0.50/lisp/org/ob-C /home/gautier/.local/share/emacs/packages/org-9.7.10/ol-w3m hides /usr/share/emacs/31.0.50/lisp/org/ol-w3m /home/gautier/.local/share/emacs/packages/org-9.7.10/org hides /usr/share/emacs/31.0.50/lisp/org/org /home/gautier/.local/share/emacs/packages/org-9.7.10/org-feed hides /usr/share/emacs/31.0.50/lisp/org/org-feed /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-emacs-lisp hides /usr/share/emacs/31.0.50/lisp/org/ob-emacs-lisp /home/gautier/.local/share/emacs/packages/org-9.7.10/org-goto hides /usr/share/emacs/31.0.50/lisp/org/org-goto /home/gautier/.local/share/emacs/packages/org-9.7.10/org-macs hides /usr/share/emacs/31.0.50/lisp/org/org-macs /home/gautier/.local/share/emacs/packages/org-9.7.10/org-attach hides /usr/share/emacs/31.0.50/lisp/org/org-attach /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-ruby hides /usr/share/emacs/31.0.50/lisp/org/ob-ruby /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-maxima hides /usr/share/emacs/31.0.50/lisp/org/ob-maxima /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-lilypond hides /usr/share/emacs/31.0.50/lisp/org/ob-lilypond /home/gautier/.local/share/emacs/packages/org-9.7.10/org-fold-core hides /usr/share/emacs/31.0.50/lisp/org/org-fold-core /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-python hides /usr/share/emacs/31.0.50/lisp/org/ob-python /home/gautier/.local/share/emacs/packages/org-9.7.10/oc hides /usr/share/emacs/31.0.50/lisp/org/oc /home/gautier/.local/share/emacs/packages/org-9.7.10/ox-odt hides /usr/share/emacs/31.0.50/lisp/org/ox-odt /home/gautier/.local/share/emacs/packages/org-9.7.10/oc-natbib hides /usr/share/emacs/31.0.50/lisp/org/oc-natbib /home/gautier/.local/share/emacs/packages/org-9.7.10/oc-basic hides /usr/share/emacs/31.0.50/lisp/org/oc-basic /home/gautier/.local/share/emacs/packages/org-9.7.10/ol-info hides /usr/share/emacs/31.0.50/lisp/org/ol-info /home/gautier/.local/share/emacs/packages/org-9.7.10/ol-man hides /usr/share/emacs/31.0.50/lisp/org/ol-man /home/gautier/.local/share/emacs/packages/org-9.7.10/org-element hides /usr/share/emacs/31.0.50/lisp/org/org-element /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-fortran hides /usr/share/emacs/31.0.50/lisp/org/ob-fortran /home/gautier/.local/share/emacs/packages/org-9.7.10/oc-csl hides /usr/share/emacs/31.0.50/lisp/org/oc-csl /home/gautier/.local/share/emacs/packages/org-9.7.10/ox-ascii hides /usr/share/emacs/31.0.50/lisp/org/ox-ascii /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-gnuplot hides /usr/share/emacs/31.0.50/lisp/org/ob-gnuplot /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-calc hides /usr/share/emacs/31.0.50/lisp/org/ob-calc /home/gautier/.local/share/emacs/packages/org-9.7.10/ol hides /usr/share/emacs/31.0.50/lisp/org/ol /home/gautier/.local/share/emacs/packages/org-9.7.10/org-pcomplete hides /usr/share/emacs/31.0.50/lisp/org/org-pcomplete /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-java hides /usr/share/emacs/31.0.50/lisp/org/ob-java /home/gautier/.local/share/emacs/packages/org-9.7.10/org-loaddefs hides /usr/share/emacs/31.0.50/lisp/org/org-loaddefs /home/gautier/.local/share/emacs/packages/org-9.7.10/org-macro hides /usr/share/emacs/31.0.50/lisp/org/org-macro /home/gautier/.local/share/emacs/packages/org-9.7.10/ol-bbdb hides /usr/share/emacs/31.0.50/lisp/org/ol-bbdb /home/gautier/.local/share/emacs/packages/org-9.7.10/org-fold hides /usr/share/emacs/31.0.50/lisp/org/org-fold /home/gautier/.local/share/emacs/packages/org-9.7.10/ox-publish hides /usr/share/emacs/31.0.50/lisp/org/ox-publish /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-forth hides /usr/share/emacs/31.0.50/lisp/org/ob-forth /home/gautier/.local/share/emacs/packages/org-9.7.10/ox-icalendar hides /usr/share/emacs/31.0.50/lisp/org/ox-icalendar /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-octave hides /usr/share/emacs/31.0.50/lisp/org/ob-octave /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-lob hides /usr/share/emacs/31.0.50/lisp/org/ob-lob /home/gautier/.local/share/emacs/packages/org-9.7.10/org-keys hides /usr/share/emacs/31.0.50/lisp/org/org-keys /home/gautier/.local/share/emacs/packages/org-9.7.10/org-plot hides /usr/share/emacs/31.0.50/lisp/org/org-plot /home/gautier/.local/share/emacs/packages/org-9.7.10/org-agenda hides /usr/share/emacs/31.0.50/lisp/org/org-agenda /home/gautier/.local/share/emacs/packages/org-9.7.10/org-compat hides /usr/share/emacs/31.0.50/lisp/org/org-compat /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-lisp hides /usr/share/emacs/31.0.50/lisp/org/ob-lisp /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-ditaa hides /usr/share/emacs/31.0.50/lisp/org/ob-ditaa /home/gautier/.local/share/emacs/packages/org-9.7.10/ox-beamer hides /usr/share/emacs/31.0.50/lisp/org/ox-beamer /home/gautier/.local/share/emacs/packages/org-9.7.10/ol-rmail hides /usr/share/emacs/31.0.50/lisp/org/ol-rmail /home/gautier/.local/share/emacs/packages/org-9.7.10/org-refile hides /usr/share/emacs/31.0.50/lisp/org/org-refile /home/gautier/.local/share/emacs/packages/org-9.7.10/org-datetree hides /usr/share/emacs/31.0.50/lisp/org/org-datetree /home/gautier/.local/share/emacs/packages/org-9.7.10/ol-mhe hides /usr/share/emacs/31.0.50/lisp/org/ol-mhe /home/gautier/.local/share/emacs/packages/org-9.7.10/ox-html hides /usr/share/emacs/31.0.50/lisp/org/ox-html /home/gautier/.local/share/emacs/packages/org-9.7.10/org-timer hides /usr/share/emacs/31.0.50/lisp/org/org-timer /home/gautier/.local/share/emacs/packages/org-9.7.10/org-habit hides /usr/share/emacs/31.0.50/lisp/org/org-habit /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-ocaml hides /usr/share/emacs/31.0.50/lisp/org/ob-ocaml /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-tangle hides /usr/share/emacs/31.0.50/lisp/org/ob-tangle /home/gautier/.local/share/emacs/packages/org-9.7.10/ol-eshell hides /usr/share/emacs/31.0.50/lisp/org/ol-eshell /home/gautier/.local/share/emacs/packages/org-9.7.10/org-mouse hides /usr/share/emacs/31.0.50/lisp/org/org-mouse /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-css hides /usr/share/emacs/31.0.50/lisp/org/ob-css /home/gautier/.local/share/emacs/packages/org-9.7.10/org-protocol hides /usr/share/emacs/31.0.50/lisp/org/org-protocol /home/gautier/.local/share/emacs/packages/org-9.7.10/org-crypt hides /usr/share/emacs/31.0.50/lisp/org/org-crypt /home/gautier/.local/share/emacs/packages/org-9.7.10/ol-doi hides /usr/share/emacs/31.0.50/lisp/org/ol-doi /home/gautier/.local/share/emacs/packages/org-9.7.10/org-colview hides /usr/share/emacs/31.0.50/lisp/org/org-colview /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-eval hides /usr/share/emacs/31.0.50/lisp/org/ob-eval /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-scheme hides /usr/share/emacs/31.0.50/lisp/org/ob-scheme /home/gautier/.local/share/emacs/packages/org-9.7.10/ol-irc hides /usr/share/emacs/31.0.50/lisp/org/ol-irc /home/gautier/.local/share/emacs/packages/org-9.7.10/ox hides /usr/share/emacs/31.0.50/lisp/org/ox /home/gautier/.local/share/emacs/packages/org-9.7.10/org-list hides /usr/share/emacs/31.0.50/lisp/org/org-list /home/gautier/.local/share/emacs/packages/org-9.7.10/org-capture hides /usr/share/emacs/31.0.50/lisp/org/org-capture /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-sql hides /usr/share/emacs/31.0.50/lisp/org/ob-sql /home/gautier/.local/share/emacs/packages/org-9.7.10/org-cycle hides /usr/share/emacs/31.0.50/lisp/org/org-cycle /home/gautier/.local/share/emacs/packages/org-9.7.10/ob hides /usr/share/emacs/31.0.50/lisp/org/ob /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-sqlite hides /usr/share/emacs/31.0.50/lisp/org/ob-sqlite /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-sed hides /usr/share/emacs/31.0.50/lisp/org/ob-sed /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-lua hides /usr/share/emacs/31.0.50/lisp/org/ob-lua /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-eshell hides /usr/share/emacs/31.0.50/lisp/org/ob-eshell /home/gautier/.local/share/emacs/packages/org-9.7.10/org-inlinetask hides /usr/share/emacs/31.0.50/lisp/org/org-inlinetask /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-org hides /usr/share/emacs/31.0.50/lisp/org/ob-org /home/gautier/.local/share/emacs/packages/org-9.7.10/ol-docview hides /usr/share/emacs/31.0.50/lisp/org/ol-docview /home/gautier/.local/share/emacs/packages/org-9.7.10/org-id hides /usr/share/emacs/31.0.50/lisp/org/org-id /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-R hides /usr/share/emacs/31.0.50/lisp/org/ob-R /home/gautier/.local/share/emacs/packages/org-9.7.10/org-indent hides /usr/share/emacs/31.0.50/lisp/org/org-indent /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-latex hides /usr/share/emacs/31.0.50/lisp/org/ob-latex /home/gautier/.local/share/emacs/packages/org-9.7.10/org-duration hides /usr/share/emacs/31.0.50/lisp/org/org-duration /home/gautier/.local/share/emacs/packages/org-9.7.10/org-ctags hides /usr/share/emacs/31.0.50/lisp/org/org-ctags /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-exp hides /usr/share/emacs/31.0.50/lisp/org/ob-exp /home/gautier/.local/share/emacs/packages/org-9.7.10/org-persist hides /usr/share/emacs/31.0.50/lisp/org/org-persist /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-comint hides /usr/share/emacs/31.0.50/lisp/org/ob-comint /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-core hides /usr/share/emacs/31.0.50/lisp/org/ob-core /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-haskell hides /usr/share/emacs/31.0.50/lisp/org/ob-haskell /home/gautier/.local/share/emacs/packages/org-9.7.10/org-num hides /usr/share/emacs/31.0.50/lisp/org/org-num /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-perl hides /usr/share/emacs/31.0.50/lisp/org/ob-perl /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-groovy hides /usr/share/emacs/31.0.50/lisp/org/ob-groovy /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-awk hides /usr/share/emacs/31.0.50/lisp/org/ob-awk /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-shell hides /usr/share/emacs/31.0.50/lisp/org/ob-shell /home/gautier/.local/share/emacs/packages/org-9.7.10/ox-md hides /usr/share/emacs/31.0.50/lisp/org/ox-md /home/gautier/.local/share/emacs/packages/org-9.7.10/ol-gnus hides /usr/share/emacs/31.0.50/lisp/org/ol-gnus /home/gautier/.local/share/emacs/packages/org-9.7.10/oc-biblatex hides /usr/share/emacs/31.0.50/lisp/org/oc-biblatex /home/gautier/.local/share/emacs/packages/org-9.7.10/ox-org hides /usr/share/emacs/31.0.50/lisp/org/ox-org /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-screen hides /usr/share/emacs/31.0.50/lisp/org/ob-screen /home/gautier/.local/share/emacs/packages/org-9.7.10/org-element-ast hides /usr/share/emacs/31.0.50/lisp/org/org-element-ast /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-julia hides /usr/share/emacs/31.0.50/lisp/org/ob-julia /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-ref hides /usr/share/emacs/31.0.50/lisp/org/ob-ref /home/gautier/.local/share/emacs/packages/org-9.7.10/ox-man hides /usr/share/emacs/31.0.50/lisp/org/ox-man /home/gautier/.local/share/emacs/packages/org-9.7.10/ol-bibtex hides /usr/share/emacs/31.0.50/lisp/org/ol-bibtex /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-js hides /usr/share/emacs/31.0.50/lisp/org/ob-js /home/gautier/.local/share/emacs/packages/org-9.7.10/org-attach-git hides /usr/share/emacs/31.0.50/lisp/org/org-attach-git /home/gautier/.local/share/emacs/packages/org-9.7.10/ox-koma-letter hides /usr/share/emacs/31.0.50/lisp/org/ox-koma-letter /home/gautier/.local/share/emacs/packages/org-9.7.10/ox-latex hides /usr/share/emacs/31.0.50/lisp/org/ox-latex /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-dot hides /usr/share/emacs/31.0.50/lisp/org/ob-dot /home/gautier/.local/share/emacs/packages/org-9.7.10/org-faces hides /usr/share/emacs/31.0.50/lisp/org/org-faces /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-sass hides /usr/share/emacs/31.0.50/lisp/org/ob-sass /home/gautier/.local/share/emacs/packages/org-9.7.10/org-entities hides /usr/share/emacs/31.0.50/lisp/org/org-entities /home/gautier/.local/share/emacs/packages/org-9.7.10/org-footnote hides /usr/share/emacs/31.0.50/lisp/org/org-footnote /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-clojure hides /usr/share/emacs/31.0.50/lisp/org/ob-clojure /home/gautier/.local/share/emacs/packages/org-9.7.10/ob-matlab hides /usr/share/emacs/31.0.50/lisp/org/ob-matlab /home/gautier/.local/share/emacs/packages/org-9.7.10/org-archive hides /usr/share/emacs/31.0.50/lisp/org/org-archive /home/gautier/.local/share/emacs/packages/org-9.7.10/org-version hides /usr/share/emacs/31.0.50/lisp/org/org-version Features: (shadow sort mail-extr emacsbug cus-start modus-vivendi-theme debbugs-gnu debbugs-compat debbugs soap-client rng-xsd rng-dt rng-util xsd-regexp sqlite emacsql-sqlite-common warnings emacsql emacsql-compiler loaddefs-gen lisp-mnt radix-tree tar-mode arc-mode archive-mode mm-archive mule-util network-stream url-cache url-http url-auth url-gw nsm display-line-numbers finder-inf char-fold view nov esxml-query pdf-sync pdf-occur ibuf-ext ibuffer ibuffer-loaddefs tablist advice tablist-filter semantic/wisent/comp semantic/wisent semantic/wisent/wisent semantic/util-modes semantic/util semantic semantic/tag semantic/lex semantic/fw mode-local cedet pdf-isearch let-alist pdf-misc pdf-tools compile pdf-view pdf-cache pdf-info tq pdf-util pdf-macs tex texmathp elfeed-show elfeed-search elfeed-csv elfeed elfeed-curl elfeed-log elfeed-db elfeed-lib xml-query ol-notmuch notmuch notmuch-tree notmuch-jump notmuch-hello notmuch-show notmuch-print notmuch-crypto notmuch-mua notmuch-message notmuch-draft notmuch-maildir-fcc notmuch-address notmuch-company notmuch-parser notmuch-wash coolj icalendar notmuch-tag notmuch-lib notmuch-version notmuch-compat vc-git vc-dispatcher visual-wrap quail oc-basic disp-table org-habit ol-eww eww url-queue mm-url ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file svg dom gnus-group gnus-undo gnus-start gnus-dbus gnus-cloud nnimap nnmail mail-source utf7 nnoo parse-time gnus-spec gnus-int gnus-range gnus-win gnus nnheader range ol-docview doc-view jka-compr image-mode exif ol-bibtex bibtex iso8601 ol-bbdb ol-w3m ol-doi org-link-doi org-agenda embark-org org-element org-persist org-id org-refile org-element-ast inline avl-tree generator org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src sh-script smie treesit executable ob-comint org-pcomplete org-list org-footnote org-faces org-entities noutline outline ob-emacs-lisp ob-core ob-eval org-cycle org-table ol rx org-fold org-fold-core org-keys oc org-loaddefs find-func org-version org-compat org-macs notifications dbus xml appt diary-lib diary-loaddefs cal-menu calendar cal-loaddefs project magit-extras magit-bookmark magit-submodule magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log which-func imenu magit-diff smerge-mode diff diff-mode track-changes git-commit log-edit message sendmail yank-media puny rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log magit-core magit-autorevert autorevert filenotify magit-margin magit-transient magit-process with-editor shell pcomplete comint ansi-osc server ansi-color magit-mode transient benchmark magit-git magit-base magit-section format-spec cursor-sensor crm dash recentf tree-widget gnus-dired dired dired-loaddefs embark-consult embark ffap consult orderless cape corfu vertico-directory vertico mb-depth jinx tempel compat delsel goto-addr modus-operandi-theme pulsar pulse color cus-edit cus-load wid-edit lin hl-line face-remap modus-themes edmacro kmacro cl-extra help-mode use-package-bind-key bind-key easy-mmode use-package-ensure use-package-core burly frameset thingatpt bookmark text-property-search pp winner ring repeat word-wrap-mode auctex-autoloads tex-site burly-autoloads cape-autoloads corfu-autoloads debbugs-autoloads elfeed-autoloads embark-consult-autoloads consult-autoloads embark-autoloads forge-autoloads closql-autoloads emacsql-autoloads fountain-mode-autoloads ghub-autoloads gnuplot-autoloads htmlize-autoloads jinx-autoloads ledger-mode-autoloads lin-autoloads magit-autoloads pcase git-commit-autoloads magit-section-autoloads dash-autoloads marginalia-autoloads markdown-mode-autoloads modus-themes-autoloads nov-autoloads ol-notmuch-autoloads notmuch-autoloads orderless-autoloads org-autoloads osm-autoloads parsebib-autoloads pdf-tools-autoloads pulsar-autoloads rainbow-mode-autoloads tablist-autoloads tempel-autoloads transient-autoloads trashed-autoloads treepy-autoloads vertico-autoloads visual-fill-column-autoloads info with-editor-autoloads yaml-autoloads xdg package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs icons password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo x-toolkit xinput2 x multi-tty move-toolbar make-network-process emacs) Memory information: ((conses 16 3076867 314883) (symbols 48 48860 3) (strings 32 460986 132416) (string-bytes 1 13110413) (vectors 16 367812) (vector-slots 8 4143966 163480) (floats 8 8450 2122) (intervals 56 274559 7666) (buffers 992 25)) From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 19 20:48:10 2024 Received: (at 72721) by debbugs.gnu.org; 20 Aug 2024 00:48:10 +0000 Received: from localhost ([127.0.0.1]:59453 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgD2f-0006K7-NW for submit@debbugs.gnu.org; Mon, 19 Aug 2024 20:48:10 -0400 Received: from mail-pf1-f180.google.com ([209.85.210.180]:54703) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgD2d-0006Jt-Vj for 72721@debbugs.gnu.org; Mon, 19 Aug 2024 20:48:08 -0400 Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-71275436546so4226428b3a.1 for <72721@debbugs.gnu.org>; Mon, 19 Aug 2024 17:47:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724114779; x=1724719579; darn=debbugs.gnu.org; h=in-reply-to:from:cc:references:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=7jP234xiBU++0ZaJg2vuQtdBglXO8YnUVj2sC8hly4s=; b=Lyx5sum+/gddvfs7S0Xb77I9D5o+47cSxnWKD3u/GxJDtaU96GDWLe7AKs+pYSP/IL /HTCwZ0yM4LJs5gROrPTI64SZvIscB/IfLqVxi3bSX9XIrKTxi2OPSFPzcWjHPoWgtaF me6A0M8kDM3Qc91MwkIkXKqfuVhps14G1UywTHWGrI9EatKLd0EP/FgqjCmPErBS1hzM lJ2IEusROPDfQoiWXlvk2jUJM0rzgOiwdZST4Lr9UrKXznXUIV6SAFASdmWcZO2SIemN srexvXRBW9n2aWShjkPOU3dsJ9KrBU9NcME9892/pp+yX91Tn+vR7HwZhi5W1VB5ldZc mWZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724114779; x=1724719579; h=in-reply-to:from:cc:references:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=7jP234xiBU++0ZaJg2vuQtdBglXO8YnUVj2sC8hly4s=; b=hr2V7T86KWaHf/LD5MgjrJzXlzcsYBXDcWGMWayOJkNAheF3e7mMIq6qCVaSNRRjYL NuNh20P4frHq025A14WGev2CY2AJCdKDiMDCOTqm5gOM90k90mz/ztz0app1EHuB4GQA 16p/zKQVHOdPjwJ44mfcS68AxlPv8A3BCTT03TgRWrquyG7zbsraCgQiGKA/N2YB5uNT aYEbgftEap01i8TEG3yn424VK326KrBuc/I51jhZTUhHGC77cV/u7GXaAJU1ku02SEsm EXm99MoYQA11Uio+Q8Wj+SmFvmZKfDXgaMr8B6+UiIUk6KH9jI18aoHUyM2Cqemya6tY 8M7Q== X-Forwarded-Encrypted: i=1; AJvYcCW3XxBNZ89uuMZhbqD36VWEMkcx72NBUCzuwx1eg162U4JxyxqslUhSzOVoIr/FM8Zp2n74fQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxtMYxgf+ti1t3edZjaStUciFqJ2bc1HDsUl3d8TnUQAsluLtPt 13H3aUrP3INzkbddjiN1JqdB7oRYdaA71bQMOacsWPFSCgUX6Uod X-Google-Smtp-Source: AGHT+IFKt1VtKaVcCvIqPgAvPyuU+u8+iOBnwDlgh3NkaL/SY32WBa59tHXi81p8UOEhs5pavmjB3Q== X-Received: by 2002:a05:6a20:ce4a:b0:1c3:ac70:f579 with SMTP id adf61e73a8af0-1c9050279a2mr17454723637.38.1724114779375; Mon, 19 Aug 2024 17:46:19 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-7127aef57fbsm7370734b3a.97.2024.08.19.17.46.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Aug 2024 17:46:18 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------uk4b8nICc0faNLSdvxp0SVTi" Message-ID: <49828281-6a20-3791-91bd-9708ec51eb57@gmail.com> Date: Mon, 19 Aug 2024 17:46:18 -0700 MIME-Version: 1.0 Subject: Re: bug#72721: 31.0.50; Visual-wrap-prefix-mode breaks Magit log buffers Content-Language: en-US To: Gautier Ponsinet , 72721@debbugs.gnu.org References: <87cym4ry3e.fsf@gautierponsinet.xyz> From: Jim Porter In-Reply-To: <87cym4ry3e.fsf@gautierponsinet.xyz> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72721 Cc: eliz@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------uk4b8nICc0faNLSdvxp0SVTi Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/19/2024 2:39 PM, Gautier Ponsinet wrote: > Hello everyone, > > The new visual-wrap-prefix-mode breaks the rendering of the Magit Log > buffers. > > In emacs -Q: > * Install Magit and its dependencies and load Magit. > * Go to a local repository (via M-x dired or M-x cd). > * M-x global-visual-wrap-prefix-mode > * M-x magit-log-current > > Could someone please confirm/reproduce? I can confirm this. I'm not quite sure of all the details, but it seem that this is due to a bad interaction between overlays and the 'min-width' display spec. The end result was that we were calling 'get-text-property' with a (large-ish) buffer position when the OBJECT arg was a string of length 1. That can happen in magit-log on the mostly-blank line where it's making the ASCII art just below a merge commit. (The leading whitespace makes 'visual-wrap-prefix-mode' do its thing.) I'm not super familiar with how the display engine works, but I think we don't want to call 'display_min_width' when we're working with an overlay. See the attached patch. Eli, I'm sure you understand this code much better than me. Does the above make sense? I can also try to improve the commentary in the code, but I'm just making some educated guesses as to what's happening here. --------------uk4b8nICc0faNLSdvxp0SVTi Content-Type: text/plain; charset=UTF-8; name="0001-Fix-bad-interaction-between-min-width-display-spec-a.patch" Content-Disposition: attachment; filename*0="0001-Fix-bad-interaction-between-min-width-display-spec-a.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBkYTAyMTU3ZWU2OWM2YWUyYTIyMGE4ZjM4YTljZDhjMGY3MTA1NjQxIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IE1vbiwgMTkgQXVnIDIwMjQgMTc6Mzg6NDcgLTA3MDAKU3ViamVjdDogW1BB VENIXSBGaXggYmFkIGludGVyYWN0aW9uIGJldHdlZW4gJ21pbi13aWR0aCcgZGlzcGxheSBz cGVjIGFuZAogb3ZlcmxheXMKCiogc3JjL3hkaXNwLmMgKGhhbmRsZV9kaXNwbGF5X3Byb3Ap OiBEb24ndCBoYW5kbGUgJ21pbi13aWR0aCcgd2hlbgppdGVyYXRpbmcgb3ZlciBhIHN0cmlu ZyAoYnVnIzcyNzIxKS4KLS0tCiBzcmMveGRpc3AuYyB8IDE2ICsrKysrKysrKystLS0tLS0K IDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQoKZGlm ZiAtLWdpdCBhL3NyYy94ZGlzcC5jIGIvc3JjL3hkaXNwLmMKaW5kZXggMzA3NzFhMWM4M2Qu LmJkNjY1N2ZlNTIyIDEwMDY0NAotLS0gYS9zcmMveGRpc3AuYworKysgYi9zcmMveGRpc3Au YwpAQCAtNTc5MSwxNCArNTc5MSwxOCBAQCBoYW5kbGVfZGlzcGxheV9wcm9wIChzdHJ1Y3Qg aXQgKml0KQogICBwcm9wdmFsID0gZ2V0X2NoYXJfcHJvcGVydHlfYW5kX292ZXJsYXkgKG1h a2VfZml4bnVtIChwb3NpdGlvbi0+Y2hhcnBvcyksCiAJCQkJCSAgIFFkaXNwbGF5LCBvYmpl Y3QsICZvdmVybGF5KTsKIAotICAvKiBSZXN0IG9mIHRoZSBjb2RlIG11c3QgaGF2ZSBPQkpF Q1QgYmUgZWl0aGVyIGEgc3RyaW5nIG9yIGEgYnVmZmVyLiAgKi8KKwogICBpZiAoIVNUUklO R1AgKGl0LT5zdHJpbmcpKQotICAgIG9iamVjdCA9IGl0LT53LT5jb250ZW50czsKKyAgICB7 CisgICAgICAvKiBSZXN0IG9mIHRoZSBjb2RlIG11c3QgaGF2ZSBPQkpFQ1QgYmUgZWl0aGVy IGEgc3RyaW5nIG9yIGEgYnVmZmVyLiAgKi8KKyAgICAgIG9iamVjdCA9IGl0LT53LT5jb250 ZW50czsKIAotICAvKiBIYW5kbGUgbWluLXdpZHRoIGVuZHMuICovCi0gIGlmICghTklMUCAo aXQtPm1pbl93aWR0aF9wcm9wZXJ0eSkKLSAgICAgICYmIE5JTFAgKGZpbmRfZGlzcGxheV9w cm9wZXJ0eSAocHJvcHZhbCwgUW1pbl93aWR0aCkpKQotICAgIGRpc3BsYXlfbWluX3dpZHRo IChpdCwgYnVmcG9zLCBvYmplY3QsIFFuaWwpOworICAgICAgLyogSGFuZGxlIG1pbi13aWR0 aCBlbmRzLiAgVGhpcyBkb2Vzbid0IGFwcGx5IHdoaWxlIGl0ZXJhdGluZyBvdmVyCisJIGEg c3RyaW5nLiAgKi8KKyAgICAgIGlmICghTklMUCAoaXQtPm1pbl93aWR0aF9wcm9wZXJ0eSkK KwkgICYmIE5JTFAgKGZpbmRfZGlzcGxheV9wcm9wZXJ0eSAocHJvcHZhbCwgUW1pbl93aWR0 aCkpKQorCWRpc3BsYXlfbWluX3dpZHRoIChpdCwgYnVmcG9zLCBvYmplY3QsIFFuaWwpOwor ICAgIH0KIAogICBpZiAoTklMUCAocHJvcHZhbCkpCiAgICAgcmV0dXJuIEhBTkRMRURfTk9S TUFMTFk7Ci0tIAoyLjI1LjEKCg== --------------uk4b8nICc0faNLSdvxp0SVTi-- From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 20 07:54:29 2024 Received: (at 72721) by debbugs.gnu.org; 20 Aug 2024 11:54:29 +0000 Received: from localhost ([127.0.0.1]:59969 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgNRV-0007tZ-En for submit@debbugs.gnu.org; Tue, 20 Aug 2024 07:54:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgNRR-0007tF-5k for 72721@debbugs.gnu.org; Tue, 20 Aug 2024 07:54:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sgNQd-000187-80; Tue, 20 Aug 2024 07:53:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=axFE46ABiuZp9vMGL3mWl0d52RHMcOWXC8HDwzu1Guw=; b=VF6v/VwustxZ mih46KFFZHb1ojUT6uRm5Oe+nuPaNVZgnkQNriW1R6iGdtt9NKwXOyvhot6LH1V02X401f2yBaxEc gOjgMWyWZ0GYuL2MEIQFdML30hp6V4uPZdAaUl7z+TzT+ExoVXDUQFYS0+DLFgac4CQYg4yg4UT0L bcYOWlE4VxOHCwaHPsk/MUG2MqSpGL09fiBKKgCWDFkCbjVIwsQArZqdfTMTI/5FNO6ZSonkDVO2q Kt2agLl7BrBG92OqfHA5tDb9OqmS3cAWlUEYkuj/8uaBlxzMdvLLp1OvIbyAkGfn+iXclmmSicY7u frN7BiZHBiBLXfbSAQISQg==; Date: Tue, 20 Aug 2024 14:53:30 +0300 Message-Id: <86jzgbwgud.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: <49828281-6a20-3791-91bd-9708ec51eb57@gmail.com> (message from Jim Porter on Mon, 19 Aug 2024 17:46:18 -0700) Subject: Re: bug#72721: 31.0.50; Visual-wrap-prefix-mode breaks Magit log buffers References: <87cym4ry3e.fsf@gautierponsinet.xyz> <49828281-6a20-3791-91bd-9708ec51eb57@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72721 Cc: 72721@debbugs.gnu.org, gautier@gautierponsinet.xyz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 19 Aug 2024 17:46:18 -0700 > Cc: eliz@gnu.org > From: Jim Porter > > On 8/19/2024 2:39 PM, Gautier Ponsinet wrote: > > Hello everyone, > > > > The new visual-wrap-prefix-mode breaks the rendering of the Magit Log > > buffers. > > > > In emacs -Q: > > * Install Magit and its dependencies and load Magit. > > * Go to a local repository (via M-x dired or M-x cd). > > * M-x global-visual-wrap-prefix-mode > > * M-x magit-log-current > > > > Could someone please confirm/reproduce? > > I can confirm this. I'm not quite sure of all the details, but it seem > that this is due to a bad interaction between overlays and the > 'min-width' display spec. The end result was that we were calling > 'get-text-property' with a (large-ish) buffer position when the OBJECT > arg was a string of length 1. That can happen in magit-log on the > mostly-blank line where it's making the ASCII art just below a merge > commit. (The leading whitespace makes 'visual-wrap-prefix-mode' do its > thing.) > > I'm not super familiar with how the display engine works, but I think we > don't want to call 'display_min_width' when we're working with an > overlay. See the attached patch. I'd appreciate a reproducer without Magit, as I don't have it installed and would prefer not to have to. > Eli, I'm sure you understand this code much better than me. Does the > above make sense? I can also try to improve the commentary in the code, > but I'm just making some educated guesses as to what's happening here. It looks like you are breaking min-width support for display strings? They are used on the mode line and also in other places, and in general, min-width should treat buffers and strings alike. Can you explain the motivation for the proposed changes, and describe what you saw with the current code in this case? Where's the call to get-text-property and why did it use a buffer position instead of a string position? From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 20 13:34:59 2024 Received: (at 72721) by debbugs.gnu.org; 20 Aug 2024 17:34:59 +0000 Received: from localhost ([127.0.0.1]:33614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgSl0-0000p6-J0 for submit@debbugs.gnu.org; Tue, 20 Aug 2024 13:34:59 -0400 Received: from mail-pf1-f174.google.com ([209.85.210.174]:53297) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgSkx-0000oj-4w for 72721@debbugs.gnu.org; Tue, 20 Aug 2024 13:34:56 -0400 Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-7141feed424so254044b3a.2 for <72721@debbugs.gnu.org>; Tue, 20 Aug 2024 10:34:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724175186; x=1724779986; darn=debbugs.gnu.org; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=B5eD/gCdL9xfs+js1E4aVeCsLEfxnwYRu6FS+hmcxr8=; b=GdhdALewUda6NP9DPX3peng0FI68Fc8/0nI+XeiXIO/EuLXsOVPhvwB6fpymoEjM1X Dv0ptGq29xRREnHWJI68YM/sk4Y2DqBfyA/nVE3lCoqyIVp27mKy1Pkotp/p1fbGtkbO MVdR306+Zp0pxZxyYe8ePTAk22M6ZcDqHlXktF+zOKxpygKqGJhajy1mAf1ggdn2TPXc M5ZApOoJKzaGvmNIOTppUUMry5dbztTYY71/8aZ7920ibViw/+eRZLYi5SIGXhlee5nE oabOmXjHOyjzErdnTprd4ZR+mfQn95VhuZWs+6p+PIviMhBoN9q9zAT2tvMEjLt6kYp0 J+9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724175186; x=1724779986; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=B5eD/gCdL9xfs+js1E4aVeCsLEfxnwYRu6FS+hmcxr8=; b=qZk1adqGx91DHv51AWqmxtWwZODrZ06kzr1QdlrN/wti46AbVVy/2sFwKXsTrtMyne CDSG6kLWydX2JcnBeEhipEEXPlh63+CQV+SYSqU97KzgVaI/nKPHfHKnXPx++lyIcC7L cYLHkq+62d/qmYoiKeJXHdXj/W9h2aycF3XvCr8EaEtJY5Il01019XynvjQrVf8/BeyI JpvurdnrmybfsVxw7OBQWnVgOHdevuOquzKXFRKEIRRV4xuplxUeZR//lYxwEwBFeI3p WC6joR+6EwWB4m44qMp4yAwuKHegQIoM3CMgOES9iOcyYQLZ65CZ+ArOhr97JLeYPjXZ fdQg== X-Gm-Message-State: AOJu0YwbP0urfPWFM0bTYO++CzUp6ALF0jdoPKet7CR61KzLKfRDUAo3 alsEY+bTIgkCfgc0Yi6QCpAlFejYbzTxvYdxrdQ8tOof5gANqZ+l X-Google-Smtp-Source: AGHT+IFLSXHE4bElUHKHtkTjpMLm4Snnr+TcRf0MONpyAOA2o0N5U7I9vDWSeqDKb93hL671rJGY8A== X-Received: by 2002:a05:6a20:c78e:b0:1c3:b1e2:f826 with SMTP id adf61e73a8af0-1cad8352b82mr80647637.35.1724175185749; Tue, 20 Aug 2024 10:33:05 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-7141fe23514sm246880b3a.80.2024.08.20.10.33.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Aug 2024 10:33:05 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------6eyFOUt0P2yOv5TSTflDG2Z8" Message-ID: <36584786-6af4-c59f-bb3e-f3459b2904be@gmail.com> Date: Tue, 20 Aug 2024 10:33:06 -0700 MIME-Version: 1.0 Subject: Re: bug#72721: 31.0.50; Visual-wrap-prefix-mode breaks Magit log buffers Content-Language: en-US To: Eli Zaretskii References: <87cym4ry3e.fsf@gautierponsinet.xyz> <49828281-6a20-3791-91bd-9708ec51eb57@gmail.com> <86jzgbwgud.fsf@gnu.org> From: Jim Porter In-Reply-To: <86jzgbwgud.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72721 Cc: 72721@debbugs.gnu.org, gautier@gautierponsinet.xyz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------6eyFOUt0P2yOv5TSTflDG2Z8 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/20/2024 4:53 AM, Eli Zaretskii wrote: >> Date: Mon, 19 Aug 2024 17:46:18 -0700 >> Cc: eliz@gnu.org >> From: Jim Porter >> >> On 8/19/2024 2:39 PM, Gautier Ponsinet wrote: >>> Hello everyone, >>> >>> The new visual-wrap-prefix-mode breaks the rendering of the Magit Log >>> buffers. >>> >>> In emacs -Q: >>> * Install Magit and its dependencies and load Magit. >>> * Go to a local repository (via M-x dired or M-x cd). >>> * M-x global-visual-wrap-prefix-mode >>> * M-x magit-log-current >>> >>> Could someone please confirm/reproduce? >> >> I can confirm this. I'm not quite sure of all the details, but it seem >> that this is due to a bad interaction between overlays and the >> 'min-width' display spec. The end result was that we were calling >> 'get-text-property' with a (large-ish) buffer position when the OBJECT >> arg was a string of length 1. That can happen in magit-log on the >> mostly-blank line where it's making the ASCII art just below a merge >> commit. (The leading whitespace makes 'visual-wrap-prefix-mode' do its >> thing.) >> >> I'm not super familiar with how the display engine works, but I think we >> don't want to call 'display_min_width' when we're working with an >> overlay. See the attached patch. > > I'd appreciate a reproducer without Magit, as I don't have it > installed and would prefer not to have to. Me too... I haven't been able to get a reduced test case yet since Magit is pretty complex and I haven't figured out what it's doing exactly. It *seems* to be due to overlays, but I only know that from examining things in GDB. I haven't deciphered the relevant Magit code yet. >> Eli, I'm sure you understand this code much better than me. Does the >> above make sense? I can also try to improve the commentary in the code, >> but I'm just making some educated guesses as to what's happening here. > > It looks like you are breaking min-width support for display strings? > They are used on the mode line and also in other places, and in > general, min-width should treat buffers and strings alike. Can you > explain the motivation for the proposed changes, and describe what you > saw with the current code in this case? Where's the call to > get-text-property and why did it use a buffer position instead of a > string position? You're probably right. I think my patch was a little over-aggressive (see attached for a more-surgical one). This patch may still be wrong, but hopefully it gets a bit closer to what we want. I think this is what's happening, in a bit more detail: magit-log-current uses overlays (I think to set up the right margin text?). When visual-wrap-prefix-mode ("vwpm") is enabled, the display engine goes through the buffer, finds the 'min-width' display property from vwpm and holds onto it. Next, it starts processing an overlay. Eventually, that calls 'handle_display_prop' for the overlay which calls 'display_min_width'. At this point, we have an object stored in 'it->min_width_property' (thanks to vwpm), the local variable 'object' is the overlay string, and 'bufpos' is the actual buffer position. Finally we call 'get_display_property' with the bufpos and object (which calls 'Fget_text_property'), and kaboom: 'object' is a string of length 1, but bufpos is much larger (~400 in my test). I've also attached a backtrace, though I'm not sure how informative it is on its own. --------------6eyFOUt0P2yOv5TSTflDG2Z8 Content-Type: text/plain; charset=UTF-8; name="0001-Fix-bad-interaction-between-min-width-display-spec-a.patch" Content-Disposition: attachment; filename*0="0001-Fix-bad-interaction-between-min-width-display-spec-a.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAxM2ZlNjhlYmMyZWIyZmU3Y2EwZWU0YWM0NzMzYjNhYmMzZWQwY2FiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IE1vbiwgMTkgQXVnIDIwMjQgMTc6Mzg6NDcgLTA3MDAKU3ViamVjdDogW1BB VENIXSBGaXggYmFkIGludGVyYWN0aW9uIGJldHdlZW4gJ21pbi13aWR0aCcgZGlzcGxheSBz cGVjIGFuZAogb3ZlcmxheXMKClByZXZpb3VzbHksIHdoZW4gaXRlcmF0aW5nIG92ZXIgb3Zl cmxheXMsIHdlIHdvdWxkIHBhc3MgdGhlIG92ZXJsYXkKc3RyaW5nIGFuZCB0aGUgYnVmZmVy IHBvc2l0aW9uIHRvICdkaXNwbGF5X21pbl93aWR0aCcsIHdoaWNoIHdvdWxkIHVzZQp0aG9z ZSB2YWx1ZXMgdG8gdHJ5IHRvIGdldCB0aGUgZGlzcGxheSBwcm9wZXJ0eS4gIEhvd2V2ZXIs IHRoZSBidWZmZXIKcG9zaXRpb24gaXMgdmVyeSBsaWtlbHkgb3V0IG9mIGJvdW5kcyBmb3Ig dGhlIG92ZXJsYXkgc3RyaW5nIQoKKiBzcmMveGRpc3AuYyAoZ2V0X2Rpc3BsYXlfcHJvcGVy dHkpOiBSZW5hbWUgQlVGUE9TIHRvIENIQVJQT1MuCihkaXNwbGF5X21pbl93aWR0aCk6IFRh a2UgQ0hBUlBPUyBpbnN0ZWFkIG9mIEJVRlBPUywgYW5kIGdldCBCVUZQT1Mgb24Kb3VyIG93 bi4gIFRoaXMgd2F5LCB3ZSBjYW4gYmUgc3VyZSB0aGF0IHdoZW4gY2FsbGluZwonZ2V0X2Rp c3BsYXlfcHJvcGVydHknLCB3ZSBwcm92aWRlIGl0IHdpdGggdGhlIGNvcnJlY3Qga2luZCBv ZiBwb3NpdGlvbi4KKGhhbmRsZV9kaXNwbGF5X3Byb3ApOiBQYXNzIHRoZSBjaGFyYWN0ZXIg cG9zIG9mIE9CSkVDVCdzIHBvc2l0aW9uIHRvCidkaXNwbGF5X21pbl93aWR0aCcgKGJ1ZyM3 MjcyMSkuCi0tLQogc3JjL3hkaXNwLmMgfCAyMCArKysrKysrKysrKy0tLS0tLS0tLQogMSBm aWxlIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvc3JjL3hkaXNwLmMgYi9zcmMveGRpc3AuYwppbmRleCAzMDc3MWExYzgzZC4uYWY5 M2E4MjRiZWUgMTAwNjQ0Ci0tLSBhL3NyYy94ZGlzcC5jCisrKyBiL3NyYy94ZGlzcC5jCkBA IC01NjMzLDE3ICs1NjMzLDE5IEBAIGZpbmRfZGlzcGxheV9wcm9wZXJ0eSAoTGlzcF9PYmpl Y3QgZGlzcCwgTGlzcF9PYmplY3QgcHJvcCkKIH0KIAogc3RhdGljIExpc3BfT2JqZWN0Ci1n ZXRfZGlzcGxheV9wcm9wZXJ0eSAocHRyZGlmZl90IGJ1ZnBvcywgTGlzcF9PYmplY3QgcHJv cCwgTGlzcF9PYmplY3Qgb2JqZWN0KQorZ2V0X2Rpc3BsYXlfcHJvcGVydHkgKHB0cmRpZmZf dCBjaGFycG9zLCBMaXNwX09iamVjdCBwcm9wLCBMaXNwX09iamVjdCBvYmplY3QpCiB7Ci0g IHJldHVybiBmaW5kX2Rpc3BsYXlfcHJvcGVydHkgKEZnZXRfdGV4dF9wcm9wZXJ0eSAobWFr ZV9maXhudW0gKGJ1ZnBvcyksCisgIHJldHVybiBmaW5kX2Rpc3BsYXlfcHJvcGVydHkgKEZn ZXRfdGV4dF9wcm9wZXJ0eSAobWFrZV9maXhudW0gKGNoYXJwb3MpLAogCQkJCQkJICAgIFFk aXNwbGF5LCBvYmplY3QpLAogCQkJCXByb3ApOwogfQogCiBzdGF0aWMgdm9pZAotZGlzcGxh eV9taW5fd2lkdGggKHN0cnVjdCBpdCAqaXQsIHB0cmRpZmZfdCBidWZwb3MsCitkaXNwbGF5 X21pbl93aWR0aCAoc3RydWN0IGl0ICppdCwgcHRyZGlmZl90IGNoYXJwb3MsCiAJCSAgIExp c3BfT2JqZWN0IG9iamVjdCwgTGlzcF9PYmplY3Qgd2lkdGhfc3BlYykKIHsKKyAgcHRyZGlm Zl90IGJ1ZnBvcyA9IENIQVJQT1MgKGl0LT5jdXJyZW50LnBvcyk7CisKICAgLyogV2UncmUg YmVpbmcgY2FsbGVkIGF0IHRoZSBlbmQgb2YgdGhlIGBtaW4td2lkdGgnIHNlcXVlbmNlLAog ICAgICBwcm9iYWJseS4gKi8KICAgaWYgKCFOSUxQIChpdC0+bWluX3dpZHRoX3Byb3BlcnR5 KQpAQCAtNTY1OCw5ICs1NjYwLDkgQEAgZGlzcGxheV9taW5fd2lkdGggKHN0cnVjdCBpdCAq aXQsIHB0cmRpZmZfdCBidWZwb3MsCiAJCSAgIGdldF9kaXNwbGF5X3Byb3BlcnR5ICgwLCBR bWluX3dpZHRoLCBvYmplY3QpKSkKIAkgIC8qIEluIGEgYnVmZmVyIC0tIGNoZWNrIHRoYXQg d2UncmUgcmVhbGx5IHJpZ2h0IGFmdGVyIHRoZQogCSAgICAgc2VxdWVuY2Ugb2YgY2hhcmFj dGVycyBjb3ZlcmVkIGJ5IHRoaXMgYG1pbi13aWR0aCcuICAqLwotCSAgfHwgKGJ1ZnBvcyA+ IEJFR1YKKwkgIHx8IChidWZwb3MgPiBCRUdWICYmIGNoYXJwb3MgPiAwCiAJICAgICAgJiYg RVEgKGl0LT5taW5fd2lkdGhfcHJvcGVydHksCi0JCSAgICAgZ2V0X2Rpc3BsYXlfcHJvcGVy dHkgKGJ1ZnBvcyAtIDEsIFFtaW5fd2lkdGgsIG9iamVjdCkpKSkKKwkJICAgICBnZXRfZGlz cGxheV9wcm9wZXJ0eSAoY2hhcnBvcyAtIDEsIFFtaW5fd2lkdGgsIG9iamVjdCkpKSkKIAl7 CiAJICBMaXNwX09iamVjdCB3ID0gUW5pbDsKIAkgIGRvdWJsZSB3aWR0aDsKQEAgLTU3MTMs OSArNTcxNSw5IEBAIGRpc3BsYXlfbWluX3dpZHRoIChzdHJ1Y3QgaXQgKml0LCBwdHJkaWZm X3QgYnVmcG9zLAogCSAgICAgICYmICFFUSAoaXQtPm1pbl93aWR0aF9wcm9wZXJ0eSwKIAkJ ICAgICAgZ2V0X2Rpc3BsYXlfcHJvcGVydHkgKDAsIFFtaW5fd2lkdGgsIG9iamVjdCkpKQog CSAgLyogQnVmZmVyLiAgKi8KLQkgIHx8IChidWZwb3MgPiBCRUdWCisJICB8fCAoYnVmcG9z ID4gQkVHViAmJiBjaGFycG9zID4gMAogCSAgICAgICYmICFFUSAod2lkdGhfc3BlYywKLQkJ ICAgICAgZ2V0X2Rpc3BsYXlfcHJvcGVydHkgKGJ1ZnBvcyAtIDEsIFFtaW5fd2lkdGgsIG9i amVjdCkpKSkKKwkJICAgICAgZ2V0X2Rpc3BsYXlfcHJvcGVydHkgKGNoYXJwb3MgLSAxLCBR bWluX3dpZHRoLCBvYmplY3QpKSkpCiAJewogCSAgaXQtPm1pbl93aWR0aF9wcm9wZXJ0eSA9 IHdpZHRoX3NwZWM7CiAJICBpdC0+bWluX3dpZHRoX3N0YXJ0ID0gaXQtPmN1cnJlbnRfeDsK QEAgLTU3OTUsMTAgKzU3OTcsMTAgQEAgaGFuZGxlX2Rpc3BsYXlfcHJvcCAoc3RydWN0IGl0 ICppdCkKICAgaWYgKCFTVFJJTkdQIChpdC0+c3RyaW5nKSkKICAgICBvYmplY3QgPSBpdC0+ dy0+Y29udGVudHM7CiAKLSAgLyogSGFuZGxlIG1pbi13aWR0aCBlbmRzLiAqLworICAvKiBI YW5kbGUgbWluLXdpZHRoIGVuZHMsIGV4Y2VwdCB3aGVuIHByb2Nlc3NpbmcgYW4gb3Zlcmxh eS4gICovCiAgIGlmICghTklMUCAoaXQtPm1pbl93aWR0aF9wcm9wZXJ0eSkKICAgICAgICYm IE5JTFAgKGZpbmRfZGlzcGxheV9wcm9wZXJ0eSAocHJvcHZhbCwgUW1pbl93aWR0aCkpKQot ICAgIGRpc3BsYXlfbWluX3dpZHRoIChpdCwgYnVmcG9zLCBvYmplY3QsIFFuaWwpOworICAg IGRpc3BsYXlfbWluX3dpZHRoIChpdCwgQ0hBUlBPUyAoKnBvc2l0aW9uKSwgb2JqZWN0LCBR bmlsKTsKIAogICBpZiAoTklMUCAocHJvcHZhbCkpCiAgICAgcmV0dXJuIEhBTkRMRURfTk9S TUFMTFk7Ci0tIAoyLjI1LjEKCg== --------------6eyFOUt0P2yOv5TSTflDG2Z8 Content-Type: text/plain; charset=UTF-8; name="backtrace.txt" Content-Disposition: attachment; filename="backtrace.txt" Content-Transfer-Encoding: base64 IzAgIHJhaXNlIChzaWc9c2lnQGVudHJ5PTUpIGF0IC4uL3N5c2RlcHMvdW5peC9zeXN2L2xp bnV4L3JhaXNlLmM6NTAKIzEgIDB4MDAwMDU1NTU1NTVlNzhhYSBpbiBkaXNwbGF5X21pbl93 aWR0aAogICAgKGl0PWl0QGVudHJ5PTB4N2ZmZmZmZmY3NTAwLCBidWZwb3M9YnVmcG9zQGVu dHJ5PTQ0MCwgb2JqZWN0PW9iamVjdEBlbnRyeT0weDU1NTU1NzJhMmYxNCwgd2lkdGhfc3Bl Yz13aWR0aF9zcGVjQGVudHJ5PTB4MCkgYXQgLi4vLi4vc3JjL3hkaXNwLmM6NTY1MwojMiAg MHgwMDAwNTU1NTU1NWU5ZmUwIGluIGhhbmRsZV9kaXNwbGF5X3Byb3AgKGl0PTB4N2ZmZmZm ZmY3NTAwKQogICAgYXQgLi4vLi4vc3JjL2xpc3AuaDoxMTc4CiMzICAweDAwMDA1NTU1NTU1 ZTJmODUgaW4gaGFuZGxlX3N0b3AgKGl0PTB4N2ZmZmZmZmY3NTAwKQogICAgYXQgLi4vLi4v c3JjL3hkaXNwLmM6NDE2MgojNCAgMHgwMDAwNTU1NTU1NWYwOTk4IGluIG5leHRfZWxlbWVu dF9mcm9tX2J1ZmZlciAoaXQ9MHg3ZmZmZmZmZjc1MDApCiAgICBhdCAuLi8uLi9zcmMveGRp c3AuYzo5NzAxCiM1ICAweDAwMDA1NTU1NTU1ZWU2NzUgaW4gZ2V0X25leHRfZGlzcGxheV9l bGVtZW50IChpdD1pdEBlbnRyeT0weDdmZmZmZmZmNzUwMCkKICAgIGF0IC4uLy4uL3NyYy94 ZGlzcC5jOjgyNjcKIzYgIDB4MDAwMDU1NTU1NTVmNGVhOCBpbiBkaXNwbGF5X2xpbmUKICAg IChpdD0weDdmZmZmZmZmNzUwMCwgY3Vyc29yX3Zwb3M9PG9wdGltaXplZCBvdXQ+KSBhdCAu Li8uLi9zcmMveGRpc3AuYzoyNTM5NQojNyAgMHgwMDAwNTU1NTU1NWY5OGYxIGluIHRyeV93 aW5kb3cKICAgICh3aW5kb3c9d2luZG93QGVudHJ5PTB4NTU1NTU3MmUxZWNkLCBwb3M9Li4u LCBmbGFncz1mbGFnc0BlbnRyeT0xKQogICAgYXQgLi4vLi4vc3JjL3hkaXNwLmM6MjEyMTQK IzggIDB4MDAwMDU1NTU1NTYxODc5MCBpbiByZWRpc3BsYXlfd2luZG93CiAgICAod2luZG93 PTB4NTU1NTU3MmUxZWNkLCBqdXN0X3RoaXNfb25lX3A9PG9wdGltaXplZCBvdXQ+KQogICAg YXQgLi4vLi4vc3JjL3hkaXNwLmM6MjA1OTQKIzkgIDB4MDAwMDU1NTU1NTYxYWRlMyBpbiBy ZWRpc3BsYXlfd2luZG93XzAKICAgICh3aW5kb3c9d2luZG93QGVudHJ5PTB4NTU1NTU3MmUx ZWNkKSBhdCAuLi8uLi9zcmMveGRpc3AuYzoxODA3NwojMTAgMHgwMDAwNTU1NTU1NzY3NmZj IGluIGludGVybmFsX2NvbmRpdGlvbl9jYXNlXzEKICAgIChiZnVuPWJmdW5AZW50cnk9MHg1 NTU1NTU2MWFkYjAgPHJlZGlzcGxheV93aW5kb3dfMD4sIGFyZz1hcmdAZW50cnk9MHg1NTU1 NTcyZTFlY2QsIGhhbmRsZXJzPTxvcHRpbWl6ZWQgb3V0PiwgaGZ1bj1oZnVuQGVudHJ5PTB4 NTU1NTU1NWQyMzgwIDxyZWRpc3BsYXlfd2luZG93X2Vycm9yPikgYXQgLi4vLi4vc3JjL2V2 YWwuYzoxNjIyCiMxMSAweDAwMDA1NTU1NTU1Y2VmZjkgaW4gcmVkaXNwbGF5X3dpbmRvd3Mg KHdpbmRvdz0weDU1NTU1NzJlMWVjZCkKICAgIGF0IC4uLy4uL3NyYy94ZGlzcC5jOjE4MDQ2 CiMxMiAweDAwMDA1NTU1NTU1Y2YwMWQgaW4gcmVkaXNwbGF5X3dpbmRvd3MgKHdpbmRvdz0w eDU1NTU1NzJlMWNhZCkKICAgIGF0IC4uLy4uL3NyYy94ZGlzcC5jOjE4MDQwCiMxMyAweDAw MDA1NTU1NTU2MDE5YzYgaW4gcmVkaXNwbGF5X2ludGVybmFsICgpIGF0IC4uLy4uL3NyYy94 ZGlzcC5jOjE3NDQ1CiMxNCAweDAwMDA1NTU1NTU2ZWI1YjYgaW4gcmVhZF9jaGFyCiAgICAo Y29tbWFuZGZsYWc9MSwgbWFwPTB4N2ZmZmU3NGE3YWQzLCBwcmV2X2V2ZW50PTB4MCwgdXNl ZF9tb3VzZV9tZW51PTB4N2ZmZmZmZmZkZDhiLCBlbmRfdGltZT0weDApIGF0IC4uLy4uL3Ny Yy9rZXlib2FyZC5jOjI2NzMKIzE1IDB4MDAwMDU1NTU1NTZlZGVkNSBpbiByZWFkX2tleV9z ZXF1ZW5jZQogICAgKGtleWJ1Zj0weDdmZmZmZmZmZGVlMCwgcHJvbXB0PTB4MCwgZG9udF9k b3duY2FzZV9sYXN0PTxvcHRpbWl6ZWQgb3V0PiwgY2FuX3JldHVybl9zd2l0Y2hfZnJhbWU9 dHJ1ZSwgZml4X2N1cnJlbnRfYnVmZmVyPXRydWUsIHByZXZlbnRfcmVkaXNwbGF5PTxvcHRp bWl6ZWQgb3V0PiwgZGlzYWJsZV90ZXh0X2NvbnZlcnNpb25fcD1mYWxzZSkgYXQgLi4vLi4v c3JjL2tleWJvYXJkLmM6MTA3NDcKIzE2IDB4MDAwMDU1NTU1NTZlZmNjZiBpbiBjb21tYW5k X2xvb3BfMSAoKSBhdCAuLi8uLi9zcmMvbGlzcC5oOjExNzgKIzE3IDB4MDAwMDU1NTU1NTc2 NzY2NyBpbiBpbnRlcm5hbF9jb25kaXRpb25fY2FzZQogICAgKGJmdW49YmZ1bkBlbnRyeT0w eDU1NTU1NTZlZmIwMCA8Y29tbWFuZF9sb29wXzE+LCBoYW5kbGVycz1oYW5kbGVyc0BlbnRy eT0weDkwLCBoZnVuPWhmdW5AZW50cnk9MHg1NTU1NTU2ZTJmOTAgPGNtZF9lcnJvcj4pIGF0 IC4uLy4uL3NyYy9ldmFsLmM6MTU5OAojMTggMHgwMDAwNTU1NTU1NmRiNmVhIGluIGNvbW1h bmRfbG9vcF8yIChoYW5kbGVycz1oYW5kbGVyc0BlbnRyeT0weDkwKQogICAgYXQgLi4vLi4v c3JjL2tleWJvYXJkLmM6MTE2MwojMTkgMHgwMDAwNTU1NTU1NzY3NTU5IGluIGludGVybmFs X2NhdGNoCiAgICAodGFnPXRhZ0BlbnRyeT0weDEyNDUwLCBmdW5jPWZ1bmNAZW50cnk9MHg1 NTU1NTU2ZGI2YzAgPGNvbW1hbmRfbG9vcF8yPiwgYXJnPWFyZ0BlbnRyeT0weDkwKSBhdCAu Li8uLi9zcmMvZXZhbC5jOjEyNzcKIzIwIDB4MDAwMDU1NTU1NTZkYjY4NiBpbiBjb21tYW5k X2xvb3AgKCkgYXQgLi4vLi4vc3JjL2xpc3AuaDoxMTc4CiMyMSAweDAwMDA1NTU1NTU2ZTJh ZTcgaW4gcmVjdXJzaXZlX2VkaXRfMSAoKSBhdCAuLi8uLi9zcmMva2V5Ym9hcmQuYzo3NDkK IzIyIDB4MDAwMDU1NTU1NTZlMmVhNCBpbiBGcmVjdXJzaXZlX2VkaXQgKCkgYXQgLi4vLi4v c3JjL2tleWJvYXJkLmM6ODMyCiMyMyAweDAwMDA1NTU1NTU1YjI4YzMgaW4gbWFpbiAoYXJn Yz08b3B0aW1pemVkIG91dD4sIGFyZ3Y9PG9wdGltaXplZCBvdXQ+KQogICAgYXQgLi4vLi4v c3JjL2VtYWNzLmM6MjYyNAo= --------------6eyFOUt0P2yOv5TSTflDG2Z8-- From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 20 15:02:41 2024 Received: (at 72721) by debbugs.gnu.org; 20 Aug 2024 19:02:41 +0000 Received: from localhost ([127.0.0.1]:33654 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgU7t-0003AJ-1T for submit@debbugs.gnu.org; Tue, 20 Aug 2024 15:02:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgU7q-0003A2-4d for 72721@debbugs.gnu.org; Tue, 20 Aug 2024 15:02:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sgU72-0005yi-3G; Tue, 20 Aug 2024 15:01:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=dIEeMxm0rpKg0Lnif2z5goQ4TxsVq4xroEpuKKftnGM=; b=Gm2Ns7oWVorn pLo40j0hcwbvb8JONQd6Gsw0+vT/YlkinNV18jLXEodGU0KD7CtwA2r/5dRT6jg4ZWMnmTqOtg0wU 26zQ7PDjHxFhxg7wGPyrkIWvailYtMjHLU/oP9wS2YdkYJ/dU6TDHN2qbGSdqQCh0h/y1Lr7m91qQ HZhZIxihg5DfvVd8Rd5UNdovsucsV7SPRIsaWozA7g6qdPYvvMEOCy204aa6XKpx56JpawsngNxcU 2c1RNilckXllQE8dZ3/aELVxIJykM13koN4aliSuenY75YVNh/cAQHUDzzC448nzgoC4pay/wWy6p Z8Y36njEM11GS2XmhCcWMQ==; Date: Tue, 20 Aug 2024 22:01:33 +0300 Message-Id: <86r0ajuigi.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: <36584786-6af4-c59f-bb3e-f3459b2904be@gmail.com> (message from Jim Porter on Tue, 20 Aug 2024 10:33:06 -0700) Subject: Re: bug#72721: 31.0.50; Visual-wrap-prefix-mode breaks Magit log buffers References: <87cym4ry3e.fsf@gautierponsinet.xyz> <49828281-6a20-3791-91bd-9708ec51eb57@gmail.com> <86jzgbwgud.fsf@gnu.org> <36584786-6af4-c59f-bb3e-f3459b2904be@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72721 Cc: 72721@debbugs.gnu.org, gautier@gautierponsinet.xyz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Tue, 20 Aug 2024 10:33:06 -0700 > Cc: 72721@debbugs.gnu.org, gautier@gautierponsinet.xyz > From: Jim Porter > > > I'd appreciate a reproducer without Magit, as I don't have it > > installed and would prefer not to have to. > > Me too... I haven't been able to get a reduced test case yet since Magit > is pretty complex and I haven't figured out what it's doing exactly. It > *seems* to be due to overlays, but I only know that from examining > things in GDB. I haven't deciphered the relevant Magit code yet. M-x describe-text-properties will show you the properties and overlays at point, and it should be possible to concoct some Lisp which just reproduces those properties. > > It looks like you are breaking min-width support for display strings? > > They are used on the mode line and also in other places, and in > > general, min-width should treat buffers and strings alike. Can you > > explain the motivation for the proposed changes, and describe what you > > saw with the current code in this case? Where's the call to > > get-text-property and why did it use a buffer position instead of a > > string position? > > You're probably right. I think my patch was a little over-aggressive > (see attached for a more-surgical one). This patch may still be wrong, > but hopefully it gets a bit closer to what we want. It still doesn't feel right. But min-width is weird, so I need to look into the problem deeper to understand what is going on, and if you will be able to come up with a reproducer without Magit, it will help. > > I think this is what's happening, in a bit more detail: > magit-log-current uses overlays (I think to set up the right margin > text?). When visual-wrap-prefix-mode ("vwpm") is enabled, the display > engine goes through the buffer, finds the 'min-width' display property > from vwpm and holds onto it. Next, it starts processing an overlay. > > Eventually, that calls 'handle_display_prop' for the overlay which calls > 'display_min_width'. At this point, we have an object stored in > 'it->min_width_property' (thanks to vwpm), the local variable 'object' > is the overlay string, and 'bufpos' is the actual buffer position. > > Finally we call 'get_display_property' with the bufpos and object (which > calls 'Fget_text_property'), and kaboom: 'object' is a string of length > 1, but bufpos is much larger (~400 in my test). This sounds like we shouldn't be calling get_display_property here, or use a different OBJECT when we call it. IOW, the object and the position must match, and since here they don't, there's a disconnect somewhere. We need to find that disconnect and understand why it happens. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 20 23:17:42 2024 Received: (at 72721) by debbugs.gnu.org; 21 Aug 2024 03:17:43 +0000 Received: from localhost ([127.0.0.1]:34740 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgbqw-0000qD-9O for submit@debbugs.gnu.org; Tue, 20 Aug 2024 23:17:42 -0400 Received: from mail-pl1-f169.google.com ([209.85.214.169]:52446) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgbqt-0000py-Li for 72721@debbugs.gnu.org; Tue, 20 Aug 2024 23:17:41 -0400 Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2021aeee5e4so23388605ad.0 for <72721@debbugs.gnu.org>; Tue, 20 Aug 2024 20:16:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724210149; x=1724814949; darn=debbugs.gnu.org; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=7PbnEEoS2IGxs48ceCETayW2xHWtFRI0GRLaJQ+pTs8=; b=AcKbP7IfEioBENFuir1Lefa1xBVMX9AHq9KE4ppDC8EEZmf6wILN/4u2L/wa4shwAR rtTwj8zfssq6OPyFRCigpnOwbeLAQcJDSxFcqgED7heaLgbGLbXBxyohC4y3J0/1v8Kq 2Pk/tPrjOxTuk3pisGnO7hut47i7+iuc/C7S3dgyRueskdv8yGT/SRIrJPt3ugkJzWRN U9Kv8JAvlzLROEv8K/0LQ1qEF4aoKyJUNkvhDsYrH3Z4aLoAZykFbII918lbKeFiQk7m 09QWMJY9Cf80vQqfobaXrJMfBmJ1gCdEZg5lw4wU+OmN59a9eKMr6TSz0A0GN9Q4/sIe Oypw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724210149; x=1724814949; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=7PbnEEoS2IGxs48ceCETayW2xHWtFRI0GRLaJQ+pTs8=; b=i5DdY4ZwmWwCA6IBe9xK6pY+LNZ0u/sX3PnbasIdWq2I8hCtMcb0PJvkH1We7ph4hP wmctSRw9Ex5l+i0Jd0J02QkE4h15NzqKkVDeQWMh4q85Hj0AYNU94ydaDuyn6Byb2V44 a0vZe2bCE9oefWjvIzyXO+On8J6iFQKWG2a86D4M5u7SHSldJPtP4l5OgN8EMZRJjPGN czAn5YiPXGPFVWPxrBoHfbp2PWjQ5YyZmqopN2qgbPUAjDfFrrhyYevRnpzWJyREq5+e 52D3AozONCBNwECtacy43Mm5+iBkKkM8ddVqDbCi0KtC7X7n2czWbraNuMX6XOzfLXQY cmOQ== X-Gm-Message-State: AOJu0YxKxP0Qlaanoz9bTomBqBBCwDU+9nwiOrwipsTd0yUE8pztp2qQ JdPs5PugmY8BwYQDU8XI+fxBl7cnFFEO8761rJGVNr2P+Y4VP44G X-Google-Smtp-Source: AGHT+IEAJ9z4sPQBiSRyMYOTl3gEc82cxdjiJlu+4iHSOUMGCJjwwC3JFvExVpOFo/I1SZF4p4LdgA== X-Received: by 2002:a17:902:ecc9:b0:202:f8e:7749 with SMTP id d9443c01a7336-20367d4a76amr12337735ad.34.1724210149107; Tue, 20 Aug 2024 20:15:49 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-201f039e06bsm84700585ad.241.2024.08.20.20.15.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Aug 2024 20:15:48 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------7WCaS6lsFDXB1deA4IdnYJj2" Message-ID: Date: Tue, 20 Aug 2024 20:15:48 -0700 MIME-Version: 1.0 Subject: Re: bug#72721: 31.0.50; Visual-wrap-prefix-mode breaks Magit log buffers Content-Language: en-US To: Eli Zaretskii References: <87cym4ry3e.fsf@gautierponsinet.xyz> <49828281-6a20-3791-91bd-9708ec51eb57@gmail.com> <86jzgbwgud.fsf@gnu.org> <36584786-6af4-c59f-bb3e-f3459b2904be@gmail.com> <86r0ajuigi.fsf@gnu.org> From: Jim Porter In-Reply-To: <86r0ajuigi.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72721 Cc: 72721@debbugs.gnu.org, gautier@gautierponsinet.xyz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------7WCaS6lsFDXB1deA4IdnYJj2 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/20/2024 12:01 PM, Eli Zaretskii wrote: >> Date: Tue, 20 Aug 2024 10:33:06 -0700 >> Cc: 72721@debbugs.gnu.org, gautier@gautierponsinet.xyz >> From: Jim Porter >> >>> I'd appreciate a reproducer without Magit, as I don't have it >>> installed and would prefer not to have to. >> >> Me too... I haven't been able to get a reduced test case yet since Magit >> is pretty complex and I haven't figured out what it's doing exactly. It >> *seems* to be due to overlays, but I only know that from examining >> things in GDB. I haven't deciphered the relevant Magit code yet. > > M-x describe-text-properties will show you the properties and overlays > at point, and it should be possible to concoct some Lisp which just > reproduces those properties. I'd tried that but just wasn't looking at the right point. I've now figured it out and provided a few reduced test cases. (The "simple" and "consecutive" cases should already work.) While making these test cases, I noticed a similar issue with a nested 'display' property (see the "nested" case), and fixed that too (I hope!). > It still doesn't feel right. But min-width is weird, so I need to > look into the problem deeper to understand what is going on, and if > you will be able to come up with a reproducer without Magit, it will > help. Hopefully the attached reproducers help make sense of this. I've also updated my patch to handle 'min-width' in what I think is a simpler way. This implementation relies on the fact that you can't nest 'min-width' specs (the iterator struct can only hold one spec at a time). I'm guessing on some of these parts, so I may be totally off-base, but the test cases do what I expect anyway... --------------7WCaS6lsFDXB1deA4IdnYJj2 Content-Type: text/plain; charset=UTF-8; name="0001-Fix-bad-interaction-between-min-width-display-spec-a.patch" Content-Disposition: attachment; filename*0="0001-Fix-bad-interaction-between-min-width-display-spec-a.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAxM2ZlNjhlYmMyZWIyZmU3Y2EwZWU0YWM0NzMzYjNhYmMzZWQwY2FiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IE1vbiwgMTkgQXVnIDIwMjQgMTc6Mzg6NDcgLTA3MDAKU3ViamVjdDogW1BB VENIXSBGaXggYmFkIGludGVyYWN0aW9uIGJldHdlZW4gJ21pbi13aWR0aCcgZGlzcGxheSBz cGVjIGFuZAogb3ZlcmxheXMKClByZXZpb3VzbHksIHdoZW4gaXRlcmF0aW5nIG92ZXIgb3Zl cmxheXMsIHdlIHdvdWxkIHBhc3MgdGhlIG92ZXJsYXkKc3RyaW5nIGFuZCB0aGUgYnVmZmVy IHBvc2l0aW9uIHRvICdkaXNwbGF5X21pbl93aWR0aCcsIHdoaWNoIHdvdWxkIHVzZQp0aG9z ZSB2YWx1ZXMgdG8gdHJ5IHRvIGdldCB0aGUgZGlzcGxheSBwcm9wZXJ0eS4gIEhvd2V2ZXIs IHRoZSBidWZmZXIKcG9zaXRpb24gaXMgdmVyeSBsaWtlbHkgb3V0IG9mIGJvdW5kcyBmb3Ig dGhlIG92ZXJsYXkgc3RyaW5nIQoKKiBzcmMveGRpc3AuYyAoZ2V0X2Rpc3BsYXlfcHJvcGVy dHkpOiBSZW5hbWUgQlVGUE9TIHRvIENIQVJQT1MuCihkaXNwbGF5X21pbl93aWR0aCk6IFRh a2UgQ0hBUlBPUyBpbnN0ZWFkIG9mIEJVRlBPUywgYW5kIGdldCBCVUZQT1Mgb24Kb3VyIG93 bi4gIFRoaXMgd2F5LCB3ZSBjYW4gYmUgc3VyZSB0aGF0IHdoZW4gY2FsbGluZwonZ2V0X2Rp c3BsYXlfcHJvcGVydHknLCB3ZSBwcm92aWRlIGl0IHdpdGggdGhlIGNvcnJlY3Qga2luZCBv ZiBwb3NpdGlvbi4KKGhhbmRsZV9kaXNwbGF5X3Byb3ApOiBQYXNzIHRoZSBjaGFyYWN0ZXIg cG9zIG9mIE9CSkVDVCdzIHBvc2l0aW9uIHRvCidkaXNwbGF5X21pbl93aWR0aCcgKGJ1ZyM3 MjcyMSkuCi0tLQogc3JjL3hkaXNwLmMgfCAyMCArKysrKysrKysrKy0tLS0tLS0tLQogMSBm aWxlIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvc3JjL3hkaXNwLmMgYi9zcmMveGRpc3AuYwppbmRleCAzMDc3MWExYzgzZC4uYWY5 M2E4MjRiZWUgMTAwNjQ0Ci0tLSBhL3NyYy94ZGlzcC5jCisrKyBiL3NyYy94ZGlzcC5jCkBA IC01NjMzLDE3ICs1NjMzLDE5IEBAIGZpbmRfZGlzcGxheV9wcm9wZXJ0eSAoTGlzcF9PYmpl Y3QgZGlzcCwgTGlzcF9PYmplY3QgcHJvcCkKIH0KIAogc3RhdGljIExpc3BfT2JqZWN0Ci1n ZXRfZGlzcGxheV9wcm9wZXJ0eSAocHRyZGlmZl90IGJ1ZnBvcywgTGlzcF9PYmplY3QgcHJv cCwgTGlzcF9PYmplY3Qgb2JqZWN0KQorZ2V0X2Rpc3BsYXlfcHJvcGVydHkgKHB0cmRpZmZf dCBjaGFycG9zLCBMaXNwX09iamVjdCBwcm9wLCBMaXNwX09iamVjdCBvYmplY3QpCiB7Ci0g IHJldHVybiBmaW5kX2Rpc3BsYXlfcHJvcGVydHkgKEZnZXRfdGV4dF9wcm9wZXJ0eSAobWFr ZV9maXhudW0gKGJ1ZnBvcyksCisgIHJldHVybiBmaW5kX2Rpc3BsYXlfcHJvcGVydHkgKEZn ZXRfdGV4dF9wcm9wZXJ0eSAobWFrZV9maXhudW0gKGNoYXJwb3MpLAogCQkJCQkJICAgIFFk aXNwbGF5LCBvYmplY3QpLAogCQkJCXByb3ApOwogfQogCiBzdGF0aWMgdm9pZAotZGlzcGxh eV9taW5fd2lkdGggKHN0cnVjdCBpdCAqaXQsIHB0cmRpZmZfdCBidWZwb3MsCitkaXNwbGF5 X21pbl93aWR0aCAoc3RydWN0IGl0ICppdCwgcHRyZGlmZl90IGNoYXJwb3MsCiAJCSAgIExp c3BfT2JqZWN0IG9iamVjdCwgTGlzcF9PYmplY3Qgd2lkdGhfc3BlYykKIHsKKyAgcHRyZGlm Zl90IGJ1ZnBvcyA9IENIQVJQT1MgKGl0LT5jdXJyZW50LnBvcyk7CisKICAgLyogV2UncmUg YmVpbmcgY2FsbGVkIGF0IHRoZSBlbmQgb2YgdGhlIGBtaW4td2lkdGgnIHNlcXVlbmNlLAog ICAgICBwcm9iYWJseS4gKi8KICAgaWYgKCFOSUxQIChpdC0+bWluX3dpZHRoX3Byb3BlcnR5 KQpAQCAtNTY1OCw5ICs1NjYwLDkgQEAgZGlzcGxheV9taW5fd2lkdGggKHN0cnVjdCBpdCAq aXQsIHB0cmRpZmZfdCBidWZwb3MsCiAJCSAgIGdldF9kaXNwbGF5X3Byb3BlcnR5ICgwLCBR bWluX3dpZHRoLCBvYmplY3QpKSkKIAkgIC8qIEluIGEgYnVmZmVyIC0tIGNoZWNrIHRoYXQg d2UncmUgcmVhbGx5IHJpZ2h0IGFmdGVyIHRoZQogCSAgICAgc2VxdWVuY2Ugb2YgY2hhcmFj dGVycyBjb3ZlcmVkIGJ5IHRoaXMgYG1pbi13aWR0aCcuICAqLwotCSAgfHwgKGJ1ZnBvcyA+ IEJFR1YKKwkgIHx8IChidWZwb3MgPiBCRUdWICYmIGNoYXJwb3MgPiAwCiAJICAgICAgJiYg RVEgKGl0LT5taW5fd2lkdGhfcHJvcGVydHksCi0JCSAgICAgZ2V0X2Rpc3BsYXlfcHJvcGVy dHkgKGJ1ZnBvcyAtIDEsIFFtaW5fd2lkdGgsIG9iamVjdCkpKSkKKwkJICAgICBnZXRfZGlz cGxheV9wcm9wZXJ0eSAoY2hhcnBvcyAtIDEsIFFtaW5fd2lkdGgsIG9iamVjdCkpKSkKIAl7 CiAJICBMaXNwX09iamVjdCB3ID0gUW5pbDsKIAkgIGRvdWJsZSB3aWR0aDsKQEAgLTU3MTMs OSArNTcxNSw5IEBAIGRpc3BsYXlfbWluX3dpZHRoIChzdHJ1Y3QgaXQgKml0LCBwdHJkaWZm X3QgYnVmcG9zLAogCSAgICAgICYmICFFUSAoaXQtPm1pbl93aWR0aF9wcm9wZXJ0eSwKIAkJ ICAgICAgZ2V0X2Rpc3BsYXlfcHJvcGVydHkgKDAsIFFtaW5fd2lkdGgsIG9iamVjdCkpKQog CSAgLyogQnVmZmVyLiAgKi8KLQkgIHx8IChidWZwb3MgPiBCRUdWCisJICB8fCAoYnVmcG9z ID4gQkVHViAmJiBjaGFycG9zID4gMAogCSAgICAgICYmICFFUSAod2lkdGhfc3BlYywKLQkJ ICAgICAgZ2V0X2Rpc3BsYXlfcHJvcGVydHkgKGJ1ZnBvcyAtIDEsIFFtaW5fd2lkdGgsIG9i amVjdCkpKSkKKwkJICAgICAgZ2V0X2Rpc3BsYXlfcHJvcGVydHkgKGNoYXJwb3MgLSAxLCBR bWluX3dpZHRoLCBvYmplY3QpKSkpCiAJewogCSAgaXQtPm1pbl93aWR0aF9wcm9wZXJ0eSA9 IHdpZHRoX3NwZWM7CiAJICBpdC0+bWluX3dpZHRoX3N0YXJ0ID0gaXQtPmN1cnJlbnRfeDsK QEAgLTU3OTUsMTAgKzU3OTcsMTAgQEAgaGFuZGxlX2Rpc3BsYXlfcHJvcCAoc3RydWN0IGl0 ICppdCkKICAgaWYgKCFTVFJJTkdQIChpdC0+c3RyaW5nKSkKICAgICBvYmplY3QgPSBpdC0+ dy0+Y29udGVudHM7CiAKLSAgLyogSGFuZGxlIG1pbi13aWR0aCBlbmRzLiAqLworICAvKiBI YW5kbGUgbWluLXdpZHRoIGVuZHMsIGV4Y2VwdCB3aGVuIHByb2Nlc3NpbmcgYW4gb3Zlcmxh eS4gICovCiAgIGlmICghTklMUCAoaXQtPm1pbl93aWR0aF9wcm9wZXJ0eSkKICAgICAgICYm IE5JTFAgKGZpbmRfZGlzcGxheV9wcm9wZXJ0eSAocHJvcHZhbCwgUW1pbl93aWR0aCkpKQot ICAgIGRpc3BsYXlfbWluX3dpZHRoIChpdCwgYnVmcG9zLCBvYmplY3QsIFFuaWwpOworICAg IGRpc3BsYXlfbWluX3dpZHRoIChpdCwgQ0hBUlBPUyAoKnBvc2l0aW9uKSwgb2JqZWN0LCBR bmlsKTsKIAogICBpZiAoTklMUCAocHJvcHZhbCkpCiAgICAgcmV0dXJuIEhBTkRMRURfTk9S TUFMTFk7Ci0tIAoyLjI1LjEKCg== --------------7WCaS6lsFDXB1deA4IdnYJj2 Content-Type: text/plain; charset=UTF-8; name="test-cases.el" Content-Disposition: attachment; filename="test-cases.el" Content-Transfer-Encoding: base64 KHByb2duCiAgOzsgU2hvdWxkIGxvb2sgbGlrZToKICA7OyAxMjM0NQogIDs7IDY3OCAgICAg OTAKICAoc3dpdGNoLXRvLWJ1ZmZlciAic2ltcGxlIikKICAoZXJhc2UtYnVmZmVyKQogIChp bnNlcnQgIjEyMzQ1XG42Nzg5MCIpCiAgKHJlZGlzcGxheSkKICAocHV0LXRleHQtcHJvcGVy dHkKICAgNyAxMCAnZGlzcGxheSAnKChtaW4td2lkdGggKDgpKSkpKQoKCihwcm9nbgogIDs7 IFNob3VsZCBsb29rIGxpa2U6CiAgOzsgMTIzNDUKICA7OyA2NyAgODkgIDAKICAoc3dpdGNo LXRvLWJ1ZmZlciAiY29uc2VjdXRpdmUiKQogIChlcmFzZS1idWZmZXIpCiAgKGluc2VydCAi MTIzNDVcbjY3ODkwIikKICAocmVkaXNwbGF5KQogIChwdXQtdGV4dC1wcm9wZXJ0eQogICA3 IDkgJ2Rpc3BsYXkgJygobWluLXdpZHRoICg0KSkpKQogIChwdXQtdGV4dC1wcm9wZXJ0eQog ICA5IDExICdkaXNwbGF5ICcoKG1pbi13aWR0aCAoNCkpKSkpCgoKKHByb2duCiAgOzsgU2hv dWxkIGxvb2sgbGlrZToKICA7OyAxMjM0NQogIDs7IGhpICA4OTAKICAoc3dpdGNoLXRvLWJ1 ZmZlciAibmVzdGVkIikKICAoZXJhc2UtYnVmZmVyKQogIChpbnNlcnQgIjEyMzQ1XG42Nzg5 MCIpCiAgKHJlZGlzcGxheSkKICAocHV0LXRleHQtcHJvcGVydHkKICAgNyA5ICdkaXNwbGF5 CiAgIChwcm9wZXJ0aXplICJoaSIgJ2Rpc3BsYXkgJygobWluLXdpZHRoICg0KSkpKSkpCgoK KHByb2duCiAgOzsgU2hvdWxkIGxvb2sgbGlrZToKICA7OyAxMjM0NSAgICAgICAgIHwKICA7 OyA2NzggICAgIDkwICAgIHxYCiAgKHN3aXRjaC10by1idWZmZXIgIm92ZXJsYXkiKQogIChl cmFzZS1idWZmZXIpCiAgKGluc2VydCAiMTIzNDVcbjY3ODkwIikKICAoc2V0LXdpbmRvdy1t YXJnaW5zIChzZWxlY3RlZC13aW5kb3cpIDAgMSkKICAocmVkaXNwbGF5KQogIChzZXRxIG8g KG1ha2Utb3ZlcmxheSA4IDkpKQogIChvdmVybGF5LXB1dCBvICdiZWZvcmUtc3RyaW5nCiAg ICAgICAgICAgICAgIChwcm9wZXJ0aXplICJvIiAnZGlzcGxheSAnKChtYXJnaW4gcmlnaHQt bWFyZ2luKSAiWCIpKSkKICAocHV0LXRleHQtcHJvcGVydHkKICAgNyAxMCAnZGlzcGxheSAn KChtaW4td2lkdGggKDgpKSkpKQo= --------------7WCaS6lsFDXB1deA4IdnYJj2-- From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 21 01:20:05 2024 Received: (at 72721) by debbugs.gnu.org; 21 Aug 2024 05:20:05 +0000 Received: from localhost ([127.0.0.1]:34753 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgdlM-0004fB-PL for submit@debbugs.gnu.org; Wed, 21 Aug 2024 01:20:05 -0400 Received: from mail-ot1-f41.google.com ([209.85.210.41]:55326) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgdlK-0004eV-6n for 72721@debbugs.gnu.org; Wed, 21 Aug 2024 01:20:03 -0400 Received: by mail-ot1-f41.google.com with SMTP id 46e09a7af769-70df2bd6421so632973a34.2 for <72721@debbugs.gnu.org>; Tue, 20 Aug 2024 22:19:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724217492; x=1724822292; darn=debbugs.gnu.org; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=L3ZVDFZqwfGN2E2nm3WZBBludpmj+hSwzsa9+iHo5go=; b=BlSQJW77fcwMPEOcvC7dxuA17qkwD+W6+zNVddWKII66mTAsxFwLThzvv7a8H5Q3Tz hcm6IM1X9W7Vf6XNKg2sammVa+c5QSA0reRs0FICGOTiE4kDKde6//ZH2WhX+zUqb/bQ QXeJyxkCwBMtGhBlpahjOpHKdTmmmyNfSFMFEkVD78U6lJFgHS2GslQErGapmO37bdmB 77PGaCfOx2J3WIOX+imTfS8moorhVuBcFaunxX+HnKwJxWNuiSDxwNZlobrbHOCnlmlf OMT6EAG+H9sp9SEjxkYg/s78QEAhBbN7Ge8q2pctq+MrmWns2K3Qw8XuM2fvj66Obd+c RLsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724217492; x=1724822292; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=L3ZVDFZqwfGN2E2nm3WZBBludpmj+hSwzsa9+iHo5go=; b=qAnuRwJcUXsfNgENDQLc+X7jVE99bc27m5s7XrtswyVddA4KnOMBWeiGvyrSY9lxbM +JT0ytus8OMaheVOvg7IKkWwQeZLvfhVuby0rsYlG3Vzj205KYpYCxKkl9ZuxV6v0eUg 8OssCgfFJUyi7nyyVLy9IIdlZWqKuMnwyRAkwE5mxaPq2l7MsKiHgGYXlk050uJ1HF9x AQyQvOl4zBXrtkLtONu4nuWe8b1fQnzyQmRmFfg6fp3nYDmejPZKWeiGgG9xvEjcmDLl Bntfaoy9ryRg33iDk62LvkRpAJJd8nezgBGEZi6c9EOyrwBYef3EB33YoFiaJy9ZQ9Yo EKHw== X-Gm-Message-State: AOJu0YyCoHdRhGYHPrkaPA22Nd8+gJb3/7s8vJb/19cSJ21DrordBJxx aKrBWdRShssl0Z7mlgE5FNIrDqIW+xHE1NC67VH7OL+YajZme4OK X-Google-Smtp-Source: AGHT+IH0yYCgssrunsx5VGGq3bA26+ENMysUITvPFqMCAQ1Q2OKKzQhHj157CRDNsthXUslnWIIQmg== X-Received: by 2002:a05:6870:b289:b0:25d:ff1b:3793 with SMTP id 586e51a60fabf-2738be316damr1222331fac.35.1724217492268; Tue, 20 Aug 2024 22:18:12 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-714127ffe38sm1757973b3a.117.2024.08.20.22.18.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Aug 2024 22:18:11 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------MsjWH1I3x0n6cjghScoa5TSf" Message-ID: Date: Tue, 20 Aug 2024 22:18:11 -0700 MIME-Version: 1.0 Subject: Re: bug#72721: 31.0.50; Visual-wrap-prefix-mode breaks Magit log buffers Content-Language: en-US From: Jim Porter To: Eli Zaretskii References: <87cym4ry3e.fsf@gautierponsinet.xyz> <49828281-6a20-3791-91bd-9708ec51eb57@gmail.com> <86jzgbwgud.fsf@gnu.org> <36584786-6af4-c59f-bb3e-f3459b2904be@gmail.com> <86r0ajuigi.fsf@gnu.org> In-Reply-To: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72721 Cc: 72721@debbugs.gnu.org, gautier@gautierponsinet.xyz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------MsjWH1I3x0n6cjghScoa5TSf Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/20/2024 8:15 PM, Jim Porter wrote: > Hopefully the attached reproducers help make sense of this. I've also > updated my patch to handle 'min-width' in what I think is a simpler way. > This implementation relies on the fact that you can't nest 'min-width' > specs (the iterator struct can only hold one spec at a time). I'm > guessing on some of these parts, so I may be totally off-base, but the > test cases do what I expect anyway... Whoops, I'd uploaded the wrong patch. Here's the correct one. --------------MsjWH1I3x0n6cjghScoa5TSf Content-Type: text/plain; charset=UTF-8; name="0001-Fix-bad-interactions-with-min-width-display-spec-and.patch" Content-Disposition: attachment; filename*0="0001-Fix-bad-interactions-with-min-width-display-spec-and.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBmMTQ5Y2YyZDZmYmQ5Zjg2NDY5NjYyMGY5NDE4N2UzNzM4MTJjOTE5IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IE1vbiwgMTkgQXVnIDIwMjQgMTc6Mzg6NDcgLTA3MDAKU3ViamVjdDogW1BB VENIXSBGaXggYmFkIGludGVyYWN0aW9ucyB3aXRoICdtaW4td2lkdGgnIGRpc3BsYXkgc3Bl YyBhbmQKIHJlcGxhY2VtZW50IHN0cmluZ3MKClByZXZpb3VzbHksIHdoZW4gaXRlcmF0aW5n IG92ZXIgb3ZlcmxheXMgb3IgcmVwbGFjZW1lbnQgc3RyaW5ncyBmcm9tIGEKZGlzcGxheSBz cGVjLCB3ZSB3b3VsZCBwYXNzIHRoZSBzdHJpbmcgYW5kIHRoZSBidWZmZXIgcG9zaXRpb24g dG8KJ2Rpc3BsYXlfbWluX3dpZHRoJywgd2hpY2ggd291bGQgdXNlICB0aG9zZSB2YWx1ZXMg dG8gdHJ5IHRvIGdldCB0aGUKZGlzcGxheSBwcm9wZXJ0eS4gIEhvd2V2ZXIsIHRoZSBidWZm ZXIgcG9zaXRpb24gaXMgdmVyeSBsaWtlbHkgb3V0IG9mCmJvdW5kcyBmb3IgdGhlIHJlcGxh Y2VtZW50IHN0cmluZyEgKGJ1ZyM3MjcyMSkKCiogc3JjL3hkaXNwLmMgKGdldF9kaXNwbGF5 X3Byb3BlcnR5KTogUmVuYW1lIEJVRlBPUyB0byBDSEFSUE9TOyBPQkpFQ1QKbWlnaHQgbm90 IGJlIGEgYnVmZmVyLgooZGlzcGxheV9taW5fd2lkdGgpOiBBZGQgQ0hBUlBPUyBhcmd1bWVu dCBhbmQgdXBkYXRlIGNhbGxlcnMuICBUaGlzCmhlbHBzIHVzIGRpc3Rpbmd1aXNoIHdoZW4g d2UncmUgc3RpbGwgZXhhbWluaW5nIGEgcmVwbGFjZW1lbnQgc3RyaW5nLgpTaW1wbGlmeSBp bXBsZW1lbnRhdGlvbiB0byB1c2UgYSBub24tbmlsICdtaW5fd2lkdGhfcHJvcGVydHknIHRv CmRldGVybWluZSB3aGF0IHRvIGRvOyBzaW5jZSB3ZSBjYW4ndCBuZXN0ICdtaW4td2lkdGgn LCB0aGlzIHNob3VsZCBiZQpzYWZlLiAgSXQgYWxzbyBsZXRzIHVzIGluc2VydCBzcGFjZSBp bnRvIHRoZSBidWZmZXIgYXQgdGhlIHJpZ2h0IHRpbWUuCi0tLQogc3JjL3hkaXNwLmMgfCA0 MSArKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogMSBmaWxlIGNo YW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDI2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L3NyYy94ZGlzcC5jIGIvc3JjL3hkaXNwLmMKaW5kZXggMzA3NzFhMWM4M2QuLjFmYjlhNDM2 YjhjIDEwMDY0NAotLS0gYS9zcmMveGRpc3AuYworKysgYi9zcmMveGRpc3AuYwpAQCAtNTYz MywxNSArNTYzMywxNSBAQCBmaW5kX2Rpc3BsYXlfcHJvcGVydHkgKExpc3BfT2JqZWN0IGRp c3AsIExpc3BfT2JqZWN0IHByb3ApCiB9CiAKIHN0YXRpYyBMaXNwX09iamVjdAotZ2V0X2Rp c3BsYXlfcHJvcGVydHkgKHB0cmRpZmZfdCBidWZwb3MsIExpc3BfT2JqZWN0IHByb3AsIExp c3BfT2JqZWN0IG9iamVjdCkKK2dldF9kaXNwbGF5X3Byb3BlcnR5IChwdHJkaWZmX3QgY2hh cnBvcywgTGlzcF9PYmplY3QgcHJvcCwgTGlzcF9PYmplY3Qgb2JqZWN0KQogewotICByZXR1 cm4gZmluZF9kaXNwbGF5X3Byb3BlcnR5IChGZ2V0X3RleHRfcHJvcGVydHkgKG1ha2VfZml4 bnVtIChidWZwb3MpLAorICByZXR1cm4gZmluZF9kaXNwbGF5X3Byb3BlcnR5IChGZ2V0X3Rl eHRfcHJvcGVydHkgKG1ha2VfZml4bnVtIChjaGFycG9zKSwKIAkJCQkJCSAgICBRZGlzcGxh eSwgb2JqZWN0KSwKIAkJCQlwcm9wKTsKIH0KIAogc3RhdGljIHZvaWQKLWRpc3BsYXlfbWlu X3dpZHRoIChzdHJ1Y3QgaXQgKml0LCBwdHJkaWZmX3QgYnVmcG9zLAorZGlzcGxheV9taW5f d2lkdGggKHN0cnVjdCBpdCAqaXQsIHB0cmRpZmZfdCBidWZwb3MsIHB0cmRpZmZfdCBjaGFy cG9zLAogCQkgICBMaXNwX09iamVjdCBvYmplY3QsIExpc3BfT2JqZWN0IHdpZHRoX3NwZWMp CiB7CiAgIC8qIFdlJ3JlIGJlaW5nIGNhbGxlZCBhdCB0aGUgZW5kIG9mIHRoZSBgbWluLXdp ZHRoJyBzZXF1ZW5jZSwKQEAgLTU2NTYsMTEgKzU2NTYsOCBAQCBkaXNwbGF5X21pbl93aWR0 aCAoc3RydWN0IGl0ICppdCwgcHRyZGlmZl90IGJ1ZnBvcywKICAgICAgIGlmICgoYnVmcG9z ID09IDAKIAkgICAmJiAhRVEgKGl0LT5taW5fd2lkdGhfcHJvcGVydHksCiAJCSAgIGdldF9k aXNwbGF5X3Byb3BlcnR5ICgwLCBRbWluX3dpZHRoLCBvYmplY3QpKSkKLQkgIC8qIEluIGEg YnVmZmVyIC0tIGNoZWNrIHRoYXQgd2UncmUgcmVhbGx5IHJpZ2h0IGFmdGVyIHRoZQotCSAg ICAgc2VxdWVuY2Ugb2YgY2hhcmFjdGVycyBjb3ZlcmVkIGJ5IHRoaXMgYG1pbi13aWR0aCcu ICAqLwotCSAgfHwgKGJ1ZnBvcyA+IEJFR1YKLQkgICAgICAmJiBFUSAoaXQtPm1pbl93aWR0 aF9wcm9wZXJ0eSwKLQkJICAgICBnZXRfZGlzcGxheV9wcm9wZXJ0eSAoYnVmcG9zIC0gMSwg UW1pbl93aWR0aCwgb2JqZWN0KSkpKQorCSAgLyogSW4gYSBidWZmZXIsIGFuZCBub3Qgd29y a2luZyB3aXRoIGEgcmVwbGFjZW1lbnQgc3RyaW5nLiAgKi8KKwkgIHx8IChidWZwb3MgPiBC RUdWICYmIGNoYXJwb3MgPiAwKSkKIAl7CiAJICBMaXNwX09iamVjdCB3ID0gUW5pbDsKIAkg IGRvdWJsZSB3aWR0aDsKQEAgLTU3MDUsMjEgKzU3MDIsMTMgQEAgZGlzcGxheV9taW5fd2lk dGggKHN0cnVjdCBpdCAqaXQsIHB0cmRpZmZfdCBidWZwb3MsCiAgIC8qIFdlJ3JlIGF0IHRo ZSBzdGFydCBvZiBhIGBtaW4td2lkdGgnIHNlcXVlbmNlIC0tIHJlY29yZCB0aGUKICAgICAg cG9zaXRpb24gYW5kIHRoZSBwcm9wZXJ0eSwgc28gdGhhdCB3ZSBjYW4gbGF0ZXIgc2VlIGlm IHdlJ3JlIGF0CiAgICAgIHRoZSBlbmQuICAqLwotICBpZiAoQ09OU1AgKHdpZHRoX3NwZWMp KQorICBpZiAoQ09OU1AgKHdpZHRoX3NwZWMpCisgICAgICAvKiBNYWtlIHN1cmUgd2UncmUg bm90IGFjdGl2ZWx5IHByb2Nlc3NpbmcgYSBgbWluLXdpZHRoJyBzZXF1ZW5jZS4KKwkgV2Ug Y2FuJ3QgY3VycmVudGx5IG5lc3QgdGhlbS4gICovCisgICAgICAmJiBOSUxQIChpdC0+bWlu X3dpZHRoX3Byb3BlcnR5KSkKICAgICB7Ci0gICAgICBpZiAoYnVmcG9zID09IEJFR1YKLQkg IC8qIE1vZGUgbGluZSAoc2VlIGFib3ZlKS4gICovCi0JICB8fCAoYnVmcG9zID09IDAKLQkg ICAgICAmJiAhRVEgKGl0LT5taW5fd2lkdGhfcHJvcGVydHksCi0JCSAgICAgIGdldF9kaXNw bGF5X3Byb3BlcnR5ICgwLCBRbWluX3dpZHRoLCBvYmplY3QpKSkKLQkgIC8qIEJ1ZmZlci4g ICovCi0JICB8fCAoYnVmcG9zID4gQkVHVgotCSAgICAgICYmICFFUSAod2lkdGhfc3BlYywK LQkJICAgICAgZ2V0X2Rpc3BsYXlfcHJvcGVydHkgKGJ1ZnBvcyAtIDEsIFFtaW5fd2lkdGgs IG9iamVjdCkpKSkKLQl7Ci0JICBpdC0+bWluX3dpZHRoX3Byb3BlcnR5ID0gd2lkdGhfc3Bl YzsKLQkgIGl0LT5taW5fd2lkdGhfc3RhcnQgPSBpdC0+Y3VycmVudF94OwotCX0KKyAgICAg IGl0LT5taW5fd2lkdGhfcHJvcGVydHkgPSB3aWR0aF9zcGVjOworICAgICAgaXQtPm1pbl93 aWR0aF9zdGFydCA9IGl0LT5jdXJyZW50X3g7CiAgICAgfQogfQogCkBAIC01Nzk1LDEwICs1 Nzg0LDEwIEBAIGhhbmRsZV9kaXNwbGF5X3Byb3AgKHN0cnVjdCBpdCAqaXQpCiAgIGlmICgh U1RSSU5HUCAoaXQtPnN0cmluZykpCiAgICAgb2JqZWN0ID0gaXQtPnctPmNvbnRlbnRzOwog Ci0gIC8qIEhhbmRsZSBtaW4td2lkdGggZW5kcy4gKi8KKyAgLyogSGFuZGxlIG1pbi13aWR0 aCBlbmRzLiAgKi8KICAgaWYgKCFOSUxQIChpdC0+bWluX3dpZHRoX3Byb3BlcnR5KQogICAg ICAgJiYgTklMUCAoZmluZF9kaXNwbGF5X3Byb3BlcnR5IChwcm9wdmFsLCBRbWluX3dpZHRo KSkpCi0gICAgZGlzcGxheV9taW5fd2lkdGggKGl0LCBidWZwb3MsIG9iamVjdCwgUW5pbCk7 CisgICAgZGlzcGxheV9taW5fd2lkdGggKGl0LCBidWZwb3MsIENIQVJQT1MgKCpwb3NpdGlv biksIG9iamVjdCwgUW5pbCk7CiAKICAgaWYgKE5JTFAgKHByb3B2YWwpKQogICAgIHJldHVy biBIQU5ETEVEX05PUk1BTExZOwpAQCAtNjA5OSw3ICs2MDg4LDcgQEAgaGFuZGxlX3Npbmds ZV9kaXNwbGF5X3NwZWMgKHN0cnVjdCBpdCAqaXQsIExpc3BfT2JqZWN0IHNwZWMsIExpc3Bf T2JqZWN0IG9iamVjdCwKICAgICAgICYmIENPTlNQIChYQ0FSIChYQ0RSIChzcGVjKSkpKQog ICAgIHsKICAgICAgIGlmIChpdCkKLQlkaXNwbGF5X21pbl93aWR0aCAoaXQsIGJ1ZnBvcywg b2JqZWN0LCBYQ0FSIChYQ0RSIChzcGVjKSkpOworCWRpc3BsYXlfbWluX3dpZHRoIChpdCwg YnVmcG9zLCBDSEFSUE9TICgqcG9zaXRpb24pLCBvYmplY3QsIFhDQVIgKFhDRFIgKHNwZWMp KSk7CiAgICAgICByZXR1cm4gMDsKICAgICB9CiAKQEAgLTI5MjM1LDcgKzI5MjI0LDcgQEAg ZGlzcGxheV9zdHJpbmcgKGNvbnN0IGNoYXIgKnN0cmluZywgTGlzcF9PYmplY3QgbGlzcF9z dHJpbmcsIExpc3BfT2JqZWN0IGZhY2Vfc3QKIAkgICAgewogCSAgICAgIExpc3BfT2JqZWN0 IG1pbl93aWR0aCA9IHBsaXN0X2dldCAoZGlzcGxheSwgUW1pbl93aWR0aCk7CiAJICAgICAg aWYgKCFOSUxQIChtaW5fd2lkdGgpKQotCQlkaXNwbGF5X21pbl93aWR0aCAoaXQsIDAsIGZh Y2Vfc3RyaW5nLCBtaW5fd2lkdGgpOworCQlkaXNwbGF5X21pbl93aWR0aCAoaXQsIDAsIDAs IGZhY2Vfc3RyaW5nLCBtaW5fd2lkdGgpOwogCSAgICB9CiAJfQogICAgIH0KLS0gCjIuMjUu MQoK --------------MsjWH1I3x0n6cjghScoa5TSf-- From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 21 15:13:55 2024 Received: (at 72721) by debbugs.gnu.org; 21 Aug 2024 19:13:55 +0000 Received: from localhost ([127.0.0.1]:36384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgqmJ-0005GO-CU for submit@debbugs.gnu.org; Wed, 21 Aug 2024 15:13:55 -0400 Received: from mail-pg1-f172.google.com ([209.85.215.172]:60844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgqmG-0005G6-Np for 72721@debbugs.gnu.org; Wed, 21 Aug 2024 15:13:53 -0400 Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-7c691c8f8dcso35656a12.1 for <72721@debbugs.gnu.org>; Wed, 21 Aug 2024 12:13:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724267522; x=1724872322; darn=debbugs.gnu.org; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=EURY2DxudcKpa96EcyWuIs0L/UuYdWAJcnxP8/a2shI=; b=hWxpm+GGwZy5f8oCgdwjIf3tQzlIsxAMv4NRed3kjwNP73qJk87EinV2NKDKXFPkda qeZ0s+27FZXHfwsztmuuZOtP3WZiVtdjUv6t+FMd3QsNyWFBIrKDyQIpdz4VGQKgu70f AaarvHIh7d1GaSEHCdKta5s+rEW0mLIdQSYC5N1fOOmU+abwcCbaDCtAqlq+Z8Pf27iY l7zxaRBl/eeb7hY5zhvCELSHa8MNuisIOgf4cmUePS/o4XVHOBLUBgQg2/WABaIBGDnb zUxCvBPtQamWVOM3Vvy7j7GNBxs0zd8ggRo1/gHO9HGM3DraHuifUMmIcCT9rAKDUJAR 9J0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724267522; x=1724872322; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=EURY2DxudcKpa96EcyWuIs0L/UuYdWAJcnxP8/a2shI=; b=jnE/SWPY04BJrcWxrE7BTZk5d/3lyuGq9McwpnrBg9orOxATjluVL7cxqpAvaOQqAH XkzXqAsu1zoidj6L6HT9KC2ST1wdoSz0Sd4FScPBUKcULMRGsTfrD0Ph92GEE75tExel /iC7KszN1IryK5pbmmbOebVqU6tVuhi5Kss7aLGT2Nv+HBVRjM+eek/8hc3RjNhMhDBm aPHvIoH4rFEG+waf9XTkUmIilYjmBlnWCR4IVgRWCWRHyadquP6Ayp6iFasIpps+1QPf sBgs/N/VjDwJ+0za01IMUsav/Fc1WvansP5a72mQ7lLq7WeScI+y3lWxo32D+0xQpZfz gg5A== X-Gm-Message-State: AOJu0Yy+cZUj28FDkmu1SXxoyV7VgKtYhuNykVYD2hIafiUbsG6GniaZ dBWT+i7GgMgeqfHtDBlBLUEftGIdIVtA87uPBLL0BPjlAxs7bmEK X-Google-Smtp-Source: AGHT+IHPfxWLCDB1N/ZMzO0nZru+dWQbi14Xg7jvnvEekzIG9u7fl1rPvLo65x+QT85/e471758yvg== X-Received: by 2002:a17:90a:640b:b0:2c9:8105:483 with SMTP id 98e67ed59e1d1-2d5e9a3fb15mr3588628a91.14.1724267521694; Wed, 21 Aug 2024 12:12:01 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id 98e67ed59e1d1-2d5eb9034d6sm2267056a91.14.2024.08.21.12.12.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Aug 2024 12:12:01 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------IL7mBidZaXGDFK4qbYOa4imV" Message-ID: <378d3451-12b8-c802-4340-12e432bcaa35@gmail.com> Date: Wed, 21 Aug 2024 12:12:00 -0700 MIME-Version: 1.0 Subject: Re: bug#72721: 31.0.50; Visual-wrap-prefix-mode breaks Magit log buffers Content-Language: en-US From: Jim Porter To: Eli Zaretskii References: <87cym4ry3e.fsf@gautierponsinet.xyz> <49828281-6a20-3791-91bd-9708ec51eb57@gmail.com> <86jzgbwgud.fsf@gnu.org> <36584786-6af4-c59f-bb3e-f3459b2904be@gmail.com> <86r0ajuigi.fsf@gnu.org> In-Reply-To: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72721 Cc: 72721@debbugs.gnu.org, gautier@gautierponsinet.xyz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------IL7mBidZaXGDFK4qbYOa4imV Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/20/2024 10:18 PM, Jim Porter wrote: > On 8/20/2024 8:15 PM, Jim Porter wrote: >> Hopefully the attached reproducers help make sense of this. I've also >> updated my patch to handle 'min-width' in what I think is a simpler >> way. This implementation relies on the fact that you can't nest >> 'min-width' specs (the iterator struct can only hold one spec at a >> time). I'm guessing on some of these parts, so I may be totally >> off-base, but the test cases do what I expect anyway... > > Whoops, I'd uploaded the wrong patch. Here's the correct one. ... and here's a new test case (overlay-min-width). This shows that now you can apply 'min-width' as an overlay property, which would be great for 'visual-wrap-prefix-mode'. I could then convert that code to use overlays (at least for 'min-width', maybe for 'wrap-prefix' too), which would make it easier to clean up when deactivating the mode. Of course, if there's a way to write regression tests for this, I'm happy to do so, but I've never looked into how (or if) one can write regression tests for display engine features. --------------IL7mBidZaXGDFK4qbYOa4imV Content-Type: text/plain; charset=UTF-8; name="test-cases.el" Content-Disposition: attachment; filename="test-cases.el" Content-Transfer-Encoding: base64 KHByb2duCiAgOzsgU2hvdWxkIGxvb2sgbGlrZToKICA7OyAxMjM0NQogIDs7IDY3OCAgICAg OTAKICAoc3dpdGNoLXRvLWJ1ZmZlciAic2ltcGxlIikKICAoZXJhc2UtYnVmZmVyKQogIChp bnNlcnQgIjEyMzQ1XG42Nzg5MCIpCiAgKHJlZGlzcGxheSkKICAocHV0LXRleHQtcHJvcGVy dHkKICAgNyAxMCAnZGlzcGxheSAnKChtaW4td2lkdGggKDgpKSkpKQoKCihwcm9nbgogIDs7 IFNob3VsZCBsb29rIGxpa2U6CiAgOzsgMTIzNDUKICA7OyA2NyAgODkgIDAKICAoc3dpdGNo LXRvLWJ1ZmZlciAiY29uc2VjdXRpdmUiKQogIChlcmFzZS1idWZmZXIpCiAgKGluc2VydCAi MTIzNDVcbjY3ODkwIikKICAocmVkaXNwbGF5KQogIChwdXQtdGV4dC1wcm9wZXJ0eQogICA3 IDkgJ2Rpc3BsYXkgJygobWluLXdpZHRoICg0KSkpKQogIChwdXQtdGV4dC1wcm9wZXJ0eQog ICA5IDExICdkaXNwbGF5ICcoKG1pbi13aWR0aCAoNCkpKSkpCgoKKHByb2duCiAgOzsgU2hv dWxkIGxvb2sgbGlrZToKICA7OyAxMjM0NQogIDs7IGhpICA4OTAKICAoc3dpdGNoLXRvLWJ1 ZmZlciAibmVzdGVkIikKICAoZXJhc2UtYnVmZmVyKQogIChpbnNlcnQgIjEyMzQ1XG42Nzg5 MCIpCiAgKHJlZGlzcGxheSkKICAocHV0LXRleHQtcHJvcGVydHkKICAgNyA5ICdkaXNwbGF5 CiAgIChwcm9wZXJ0aXplICJoaSIgJ2Rpc3BsYXkgJygobWluLXdpZHRoICg0KSkpKSkpCgoK KHByb2duCiAgOzsgU2hvdWxkIGxvb2sgbGlrZToKICA7OyAxMjM0NSAgICAgICAgIHwKICA7 OyA2NzggICAgIDkwICAgIHxYCiAgKHN3aXRjaC10by1idWZmZXIgIm92ZXJsYXkiKQogIChl cmFzZS1idWZmZXIpCiAgKGluc2VydCAiMTIzNDVcbjY3ODkwIikKICAoc2V0LXdpbmRvdy1t YXJnaW5zIChzZWxlY3RlZC13aW5kb3cpIDAgMSkKICAocmVkaXNwbGF5KQogIChzZXRxIG8g KG1ha2Utb3ZlcmxheSA4IDkpKQogIChvdmVybGF5LXB1dCBvICdiZWZvcmUtc3RyaW5nCiAg ICAgICAgICAgICAgIChwcm9wZXJ0aXplICJvIiAnZGlzcGxheSAnKChtYXJnaW4gcmlnaHQt bWFyZ2luKSAiWCIpKSkKICAocHV0LXRleHQtcHJvcGVydHkKICAgNyAxMCAnZGlzcGxheSAn KChtaW4td2lkdGggKDgpKSkpKQoKCihwcm9nbgogIDs7IFNob3VsZCBsb29rIGxpa2U6CiAg OzsgMTIzNDUKICA7OyA2NzggICAgIDkwCiAgKHN3aXRjaC10by1idWZmZXIgIm92ZXJsYXkt bWluLXdpZHRoIikKICAoZXJhc2UtYnVmZmVyKQogIChpbnNlcnQgIjEyMzQ1XG42Nzg5MCIp CiAgKHNldC13aW5kb3ctbWFyZ2lucyAoc2VsZWN0ZWQtd2luZG93KSAwIDEpCiAgKHJlZGlz cGxheSkKICAoc2V0cSBvIChtYWtlLW92ZXJsYXkgNyAxMCkpCiAgKG92ZXJsYXktcHV0IG8g J2Rpc3BsYXkgJygobWluLXdpZHRoICg4KSkpKSkK --------------IL7mBidZaXGDFK4qbYOa4imV-- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 22 05:54:21 2024 Received: (at 72721) by debbugs.gnu.org; 22 Aug 2024 09:54:21 +0000 Received: from localhost ([127.0.0.1]:36753 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sh4WL-0004Nl-8k for submit@debbugs.gnu.org; Thu, 22 Aug 2024 05:54:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sh4WJ-0004NZ-SF for 72721@debbugs.gnu.org; Thu, 22 Aug 2024 05:54:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sh4VT-0002Cg-5p; Thu, 22 Aug 2024 05:53:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/Mf68nd6gkDdVL6+d9VRj6NusIDaRRODAvmCu+M51tA=; b=Fcr9y3I7EAIG M7/S36aiW7PiJmLUtEce/7Id54IfO0UNDUbz19vpITqilg+jDsPc04oHtN+LPp7ZjShY60q0cbpz/ PAEHCX2VNdA4o6i5aDtWVzSdqcefV13ZEdHkjutW8aB/caprxae5jnhfNdQOCxoDIzX4klQ0vDpo6 q5DzC3k3wQZvp8OmCKSPuR+8gXlQDIBX/b3WTams9PZYaEzoVaWNCf67Z8BJ63PO7vRc+paqJTKuj wuzjl8fsyEPQuGZ0UkWhxWszMEhXZkEVsUowuOBxNGxTavfhUTdePiUbI/Bj6Jxl58tntAG0c6aSt EWLs7hjmdFcuMYoz04tJiQ==; Date: Thu, 22 Aug 2024 12:53:23 +0300 Message-Id: <86h6bcubn0.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: (message from Jim Porter on Tue, 20 Aug 2024 20:15:48 -0700) Subject: Re: bug#72721: 31.0.50; Visual-wrap-prefix-mode breaks Magit log buffers References: <87cym4ry3e.fsf@gautierponsinet.xyz> <49828281-6a20-3791-91bd-9708ec51eb57@gmail.com> <86jzgbwgud.fsf@gnu.org> <36584786-6af4-c59f-bb3e-f3459b2904be@gmail.com> <86r0ajuigi.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72721 Cc: 72721@debbugs.gnu.org, gautier@gautierponsinet.xyz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Tue, 20 Aug 2024 20:15:48 -0700 > Cc: 72721@debbugs.gnu.org, gautier@gautierponsinet.xyz > From: Jim Porter > > > M-x describe-text-properties will show you the properties and overlays > > at point, and it should be possible to concoct some Lisp which just > > reproduces those properties. > > I'd tried that but just wasn't looking at the right point. I've now > figured it out and provided a few reduced test cases. (The "simple" and > "consecutive" cases should already work.) > > While making these test cases, I noticed a similar issue with a nested > 'display' property (see the "nested" case), and fixed that too (I hope!). Thanks for the test cases, they helped a lot. Can you please try the patch below, including in the original use case with Magit? I hope I've figured out all of the quirks of min-width and its possible uses, and the few extensions you demonstrated. It should be possible now to have min-width on overlay strings as well, I think (but I didn't test that). If the patch below gives good results, I will install it. diff --git a/src/xdisp.c b/src/xdisp.c index 30771a1..1e92ed4 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -5632,16 +5632,24 @@ find_display_property (Lisp_Object disp, Lisp_Object prop) return XCDR (elem); } +/* Return the value of 'display' property PROP of character at CHARPOS + in OBJECT. Return nil if character at CHARPOS has no 'display' + property or if the 'display' property of that character does not + include PROP. OBJECT can be a buffer or a string. */ static Lisp_Object -get_display_property (ptrdiff_t bufpos, Lisp_Object prop, Lisp_Object object) +get_display_property (ptrdiff_t charpos, Lisp_Object prop, Lisp_Object object) { - return find_display_property (Fget_text_property (make_fixnum (bufpos), + return find_display_property (Fget_text_property (make_fixnum (charpos), Qdisplay, object), prop); } +/* Handle 'display' property '(min-width (WIDTH))' at CHARPOS in OBJECT. + OBJECT can be a buffer (or nil, which means the current buffer) or a + string. MIN_WIDTH is the value of min-width spec that we expect to + process. */ static void -display_min_width (struct it *it, ptrdiff_t bufpos, +display_min_width (struct it *it, ptrdiff_t charpos, Lisp_Object object, Lisp_Object width_spec) { /* We're being called at the end of the `min-width' sequence, @@ -5652,15 +5660,21 @@ display_min_width (struct it *it, ptrdiff_t bufpos, /* When called from display_string (i.e., the mode line), we're being called with a string as the object, and we may be called with many sub-strings belonging to the same - :propertize run. */ - if ((bufpos == 0 - && !EQ (it->min_width_property, - get_display_property (0, Qmin_width, object))) + :propertize run. */ + if ((STRINGP (object) + && ((charpos == 0 + && !EQ (it->min_width_property, + get_display_property (0, Qmin_width, object))) + || (charpos > 0 + && EQ (it->min_width_property, + get_display_property (charpos - 1, Qmin_width, + object))))) /* In a buffer -- check that we're really right after the sequence of characters covered by this `min-width'. */ - || (bufpos > BEGV + || (!STRINGP (object) + && charpos > BEGV && EQ (it->min_width_property, - get_display_property (bufpos - 1, Qmin_width, object)))) + get_display_property (charpos - 1, Qmin_width, object)))) { Lisp_Object w = Qnil; double width; @@ -5707,15 +5721,18 @@ display_min_width (struct it *it, ptrdiff_t bufpos, the end. */ if (CONSP (width_spec)) { - if (bufpos == BEGV + if ((!STRINGP (object) + && charpos == BEGV) /* Mode line (see above). */ - || (bufpos == 0 + || (STRINGP (object) + && charpos == 0 && !EQ (it->min_width_property, get_display_property (0, Qmin_width, object))) /* Buffer. */ - || (bufpos > BEGV + || (!STRINGP (object) + && charpos > BEGV && !EQ (width_spec, - get_display_property (bufpos - 1, Qmin_width, object)))) + get_display_property (charpos - 1, Qmin_width, object)))) { it->min_width_property = width_spec; it->min_width_start = it->current_x; @@ -5798,7 +5815,17 @@ handle_display_prop (struct it *it) /* Handle min-width ends. */ if (!NILP (it->min_width_property) && NILP (find_display_property (propval, Qmin_width))) - display_min_width (it, bufpos, object, Qnil); + { + ptrdiff_t pos = bufpos, start = BEGV; + + if (STRINGP (object)) + { + pos = IT_STRING_CHARPOS (*it); + start = 0; + } + if (pos > start) + display_min_width (it, pos, object, Qnil); + } if (NILP (propval)) return HANDLED_NORMALLY; @@ -6099,7 +6126,13 @@ handle_single_display_spec (struct it *it, Lisp_Object spec, Lisp_Object object, && CONSP (XCAR (XCDR (spec)))) { if (it) - display_min_width (it, bufpos, object, XCAR (XCDR (spec))); + { + ptrdiff_t pos = bufpos; + + if (STRINGP (object)) + pos = IT_STRING_CHARPOS (*it); + display_min_width (it, pos, object, XCAR (XCDR (spec))); + } return 0; } @@ -9004,6 +9037,10 @@ set_iterator_to_next (struct it *it, bool reseat_p) next, if there is one. */ if (IT_STRING_CHARPOS (*it) >= SCHARS (it->string)) { + /* Maybe add a stretch glyph if the string had 'min-width' + display spec. */ + display_min_width (it, IT_STRING_CHARPOS (*it), it->string, + Qnil); it->ellipsis_p = false; next_overlay_string (it); if (it->ellipsis_p) @@ -9019,6 +9056,12 @@ set_iterator_to_next (struct it *it, bool reseat_p) if (IT_STRING_CHARPOS (*it) == SCHARS (it->string) && it->sp > 0) { + /* Maybe add a stretch glyph if the string had 'min-width' + display spec. We only do this if it->sp > 0 because + mode-line strings are handled differently, see + display_min_width. */ + display_min_width (it, IT_STRING_CHARPOS (*it), it->string, + Qnil); pop_it (it); if (it->method == GET_FROM_STRING) goto consider_string_end; From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 22 06:00:40 2024 Received: (at 72721) by debbugs.gnu.org; 22 Aug 2024 10:00:40 +0000 Received: from localhost ([127.0.0.1]:36763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sh4cS-0004ZU-Io for submit@debbugs.gnu.org; Thu, 22 Aug 2024 06:00:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53520) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sh4cQ-0004Z7-80 for 72721@debbugs.gnu.org; Thu, 22 Aug 2024 06:00:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sh4ba-0002mP-CM; Thu, 22 Aug 2024 05:59:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ImV/DtXLTQAy7t1p8q9UsYdJS6kL//GmIRvNkUnAugE=; b=ocaMhrYudQug QZtbk7awdhDnnIS0KeGUujwe3R0GR5cPNQnnFO5uQQ/xdVKedINL4WLj/xZvfM3yrA7NcwXTp/g+O vkvBmfkXkO47n3ONiybEsxf4wCurnh5Wpt3ZFcxz97xpG4yjfCjL+Wpgk3/VZev3pgGbH1PmaKts7 82PywFKSAVBCZxUSlyFRQKM6BA3RRs7Lq0maw2YgoGlF4qZKGK4bv3cpdK3Mc/1ODULeszPckRa+u 5nbqwc8QLs/GJjN22B/SLRwdW4Q7ESQMew06xRT9KAAtVYqp/eGlVaZxUSLbEbPON/HhhbVnAkIJW eRe7MGIQ0iKfrAT/n937Ig==; Date: Thu, 22 Aug 2024 12:59:42 +0300 Message-Id: <86frqwubch.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: (message from Jim Porter on Tue, 20 Aug 2024 22:18:11 -0700) Subject: Re: bug#72721: 31.0.50; Visual-wrap-prefix-mode breaks Magit log buffers References: <87cym4ry3e.fsf@gautierponsinet.xyz> <49828281-6a20-3791-91bd-9708ec51eb57@gmail.com> <86jzgbwgud.fsf@gnu.org> <36584786-6af4-c59f-bb3e-f3459b2904be@gmail.com> <86r0ajuigi.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72721 Cc: 72721@debbugs.gnu.org, gautier@gautierponsinet.xyz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Tue, 20 Aug 2024 22:18:11 -0700 > From: Jim Porter > Cc: 72721@debbugs.gnu.org, gautier@gautierponsinet.xyz > > Whoops, I'd uploaded the wrong patch. Here's the correct one. Thanks. I eventually decided to make the logic in display_min_width more robust wrt buffer vs string case, and also tried to handle the case of min-width property on Lisp strings, see the patch I sent. The case of min-width display spec on an overlay string that covers buffer text which itself has min-width spec is not handled yet, I think. Not sure this is needed, but if it is, we could add it in the future as an enhancement. From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 22 08:55:30 2024 Received: (at 72721) by debbugs.gnu.org; 22 Aug 2024 12:55:30 +0000 Received: from localhost ([127.0.0.1]:37038 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sh7Le-0001F3-GS for submit@debbugs.gnu.org; Thu, 22 Aug 2024 08:55:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56870) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sh7La-0001Em-E7 for 72721@debbugs.gnu.org; Thu, 22 Aug 2024 08:55:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sh7Kj-0001WE-Q3; Thu, 22 Aug 2024 08:54:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=QQIu10KEw5bz3Nwtg1CViJ30r5nxnoIitCG+fy7bIP4=; b=dHCu1KkN6hLo iPF5EvtXWFWBYZmxCEssvBWWr4v1YJZQMcfI0iv2xvHmispWDBscfuVSJ0D5gqs8O8HAtYfSs91mA uEuIYxmSo4utmQSUSLsM1wM6gKixIsUDZqyfvsoOO6Fhkq0V2eHN8kNnwS+Ew/jizcWpjebbbgeoL gc4PE/gyeQAMcwO4pPWzlalna8QEv1KtHAUKEldBbXRgwBwuRgzMQKDT9EJG1iRZE9tafqF+Qsv9e kn6IYRoOPWXxV07PcEp6eNRBgsAFlqrIdjl4ydDT5ds2d+6bFK6pYjsBRtdgL4RWjbLw6H0zmcO3r bOgWz+SdIjbT+mVChvwSSA==; Date: Thu, 22 Aug 2024 15:54:27 +0300 Message-Id: <86plq0soos.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: <378d3451-12b8-c802-4340-12e432bcaa35@gmail.com> (message from Jim Porter on Wed, 21 Aug 2024 12:12:00 -0700) Subject: Re: bug#72721: 31.0.50; Visual-wrap-prefix-mode breaks Magit log buffers References: <87cym4ry3e.fsf@gautierponsinet.xyz> <49828281-6a20-3791-91bd-9708ec51eb57@gmail.com> <86jzgbwgud.fsf@gnu.org> <36584786-6af4-c59f-bb3e-f3459b2904be@gmail.com> <86r0ajuigi.fsf@gnu.org> <378d3451-12b8-c802-4340-12e432bcaa35@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72721 Cc: 72721@debbugs.gnu.org, gautier@gautierponsinet.xyz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 21 Aug 2024 12:12:00 -0700 > From: Jim Porter > Cc: 72721@debbugs.gnu.org, gautier@gautierponsinet.xyz > > ... and here's a new test case (overlay-min-width). This shows that now > you can apply 'min-width' as an overlay property, which would be great > for 'visual-wrap-prefix-mode'. I could then convert that code to use > overlays (at least for 'min-width', maybe for 'wrap-prefix' too), which > would make it easier to clean up when deactivating the mode. Doesn't adding support for overlays boils down to replacing Fget_text_property in get_display_property with Fget_char_property, and otherwise keeping the code intact? display_min_width is the only caller of get_display_property, so we can change that at will. From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 22 12:21:44 2024 Received: (at 72721) by debbugs.gnu.org; 22 Aug 2024 16:21:45 +0000 Received: from localhost ([127.0.0.1]:38263 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1shAZE-0007Ub-K1 for submit@debbugs.gnu.org; Thu, 22 Aug 2024 12:21:44 -0400 Received: from mail-pf1-f170.google.com ([209.85.210.170]:42422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1shAZ9-0007UM-Rm for 72721@debbugs.gnu.org; Thu, 22 Aug 2024 12:21:43 -0400 Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-7142448aaf9so742577b3a.1 for <72721@debbugs.gnu.org>; Thu, 22 Aug 2024 09:20:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724343587; x=1724948387; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=G5bKJBg5MozTwkxWCBfnjmbXD9J/R3kC3cwDee9kNOg=; b=XFJQe+92RMKc30YpqsPkLrHHaEi8fJV3bAiQmki6ausfoZKdAhN1RegY4eW5Uofge+ HVMQpuPWhfk3lRSQUsNlvuHvttjo85sEY/MSMngbAq4N+l/SqBhRqqZmfdaaQUrkggoU hsSy+dmRz2d1gjLDdh117n/s9MApBX8/E45Nw65qPr2sQINhqwhSRbUWFbVNHtq2ytjz fIRMcXk5MkDUucu7umNGOuMpeK5DzHNx5QzxgMef2CiruKyuQszEwcCH0UoI7RK4QJ+Y KNBbQ/WuSMGlBda6IiskzWFpu6pc6sNhqvdaMhKSO9uUlFj1XJu4rrirDyAEHgTJ5j0J UnPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724343587; x=1724948387; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=G5bKJBg5MozTwkxWCBfnjmbXD9J/R3kC3cwDee9kNOg=; b=bIwB3hgZGMHav0w+GFXx9Pa4Ne4vmE9fV9Hkmd+a2zSpqRid8aYMPvkU80L/u1R3Od FTq29/FDUcSaYLOZkbYY0d0KfEqTouw1W0R9FAf66WMNG6kgRzE4XvI0k7iF9fpN4OHw qtMItHV96h+ON94R18i94QkLyNimNsv7XS2FKuVlJetyGqYAHeWEeTlDcL5IT7ZUVX8R h+Oho8XXuY3hIybjdHOFPLKciT9C73lT1EVADFQGiPyQge3Fjgr6BU6jeTqTgH9JUEls 3/OpuV5rFeZ/R8JaxSkUAJwt08wfkM7/oR6qCFKdeQoFmOwDmKkB7vilp8FJqZSBEACj Nj8Q== X-Gm-Message-State: AOJu0YzlEh+ITrdqoT4+2nf+RXzeFC2J7bTThoe+WOBVpGenvRkaTMGL 0025hEi4NnKG168KA8S7QcKYpHaB7Sq+kmPBp4COgeNFqabjwxSo5aMZcw== X-Google-Smtp-Source: AGHT+IE1wPXEb1P3/nuNXcUi86D5bxY4rcrSXJG3xsxHmYmfwIGD0Vx9VuIcvT+1Vbv6vWNnDUnt5Q== X-Received: by 2002:a62:e70d:0:b0:710:9d5e:1154 with SMTP id d2e1a72fcca58-7143170e307mr5848794b3a.2.1724343587175; Thu, 22 Aug 2024 09:19:47 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-7cd9acdca5dsm1558519a12.49.2024.08.22.09.19.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Aug 2024 09:19:46 -0700 (PDT) Message-ID: Date: Thu, 22 Aug 2024 09:19:47 -0700 MIME-Version: 1.0 Subject: Re: bug#72721: 31.0.50; Visual-wrap-prefix-mode breaks Magit log buffers Content-Language: en-US To: Eli Zaretskii References: <87cym4ry3e.fsf@gautierponsinet.xyz> <49828281-6a20-3791-91bd-9708ec51eb57@gmail.com> <86jzgbwgud.fsf@gnu.org> <36584786-6af4-c59f-bb3e-f3459b2904be@gmail.com> <86r0ajuigi.fsf@gnu.org> <86h6bcubn0.fsf@gnu.org> From: Jim Porter In-Reply-To: <86h6bcubn0.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72721 Cc: 72721@debbugs.gnu.org, gautier@gautierponsinet.xyz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 8/22/2024 2:53 AM, Eli Zaretskii wrote: > Thanks for the test cases, they helped a lot. > > Can you please try the patch below, including in the original use case > with Magit? I hope I've figured out all of the quirks of min-width > and its possible uses, and the few extensions you demonstrated. It > should be possible now to have min-width on overlay strings as well, I > think (but I didn't test that). This works for me in all my test cases (except "overlay-min-width"), including the original report with Magit. I also replaced 'Fget_text_property' with 'Fget_char_property' in 'get_display_property' and tested that: it works with all my test cases, including "overlay-min-width". If you're not too worried about using 'Fget_char_property', I think that would be the preferable patch, since it would (probably?) make it easier for me to fix a small bug I noticed in 'visual-wrap-prefix-mode': I neglected to remove the 'min-width' properties when deactivating the mode. Using overlays for that might make it easier to wipe them out at the right time. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 25 01:54:23 2024 Received: (at control) by debbugs.gnu.org; 25 Aug 2024 05:54:23 +0000 Received: from localhost ([127.0.0.1]:42138 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1si6Cl-0001dg-5U for submit@debbugs.gnu.org; Sun, 25 Aug 2024 01:54:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1si6Cj-0001dI-6F; Sun, 25 Aug 2024 01:54:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1si6Bp-0004eX-6L; Sun, 25 Aug 2024 01:53:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=O49dH/3o85lHst+sw13605Qip/XmxaSUAveqFxDANWo=; b=AKuXUtO8LVCc 3doICF/2LvWsr+a104MPmxU1tbasiQLfHzcZK8bl7VnzVIehndN7bOju8qwmglvod4loD6QPAJ8xj Rpx4OSoAwUQM5LTHlOoX83QvGFS8UrT50oKxfUTrzqvJBci7UQvEA5R4l0kHCWk3hLD2++a6BOISg MPFnWlTwF8QWg+9GurKIkgs53x08gi9Y0Fp34ZeDL/FSnxGRi4Z2aNVSu5RgLeu57n0prL1IYKrLS k2SCw7YEBFPNGryYatnWSD4cF8D/yQE9UM8bA6eeu7ZrpLhIJFzaESEXLKwiEoyUWADbSgSZSfUzK ZC1s7R1ZWSxOLHy6uNxn3Q==; Date: Sun, 25 Aug 2024 08:53:22 +0300 Message-Id: <861q2dm9m5.fsf@gnu.org> From: Eli Zaretskii To: "Mark Hepburn" In-Reply-To: <57b5c930-9ed1-4ee1-8150-35ec198ae0cd@app.fastmail.com> (mark@markhepburn.com) Subject: Re: bug#72710: 31.0.50; visual-wrap-prefix-mode freezes rendering in conjunction with diff-hl (fringe display) References: <4eabc3a8-26d7-4eee-ad63-9fe9c383ff7e@app.fastmail.com> <86a5h2nvkz.fsf@gnu.org> <68229ac3-f783-8e8d-b3c5-0821b1d42c5e@gmail.com> <57b5c930-9ed1-4ee1-8150-35ec198ae0cd@app.fastmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control Cc: jporterbugs@gmail.com, 72710@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) merge 72710 72721 thanks > Date: Sun, 25 Aug 2024 10:11:48 +1000 > From: "Mark Hepburn" > Cc: 72710@debbugs.gnu.org > > Thanks Jim, that does seem to work for me. Thanks, I'm therefore merging these two bugs. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 25 03:30:26 2024 Received: (at 72721) by debbugs.gnu.org; 25 Aug 2024 07:30:26 +0000 Received: from localhost ([127.0.0.1]:42195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1si7hh-0004YC-Nj for submit@debbugs.gnu.org; Sun, 25 Aug 2024 03:30:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1si7hf-0004Xs-Hu for 72721@debbugs.gnu.org; Sun, 25 Aug 2024 03:30:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1si7gk-0005t8-5A; Sun, 25 Aug 2024 03:29:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jy5bGyFIiLhbONdtntfmfEIL75VYIZmkcD9oLNYzgf0=; b=PHaGRZ9bz4Cq 1kz/yPi2QYIm4whCl4EBHqpsWI9x8D8e/B999OhSRpwVJx9lS8pUKq8SbQs5SWVVV97Nb5nxv32MS Ef+KthESwzRUJtZB2Ym6ZsXfEERUVEbx1snxxMHHDx3bHsA+h9Ugf4/iAYaezQmwuINAYnX82Ht2i Z51BzC2myGWBqq9i32a/dPk1iuW1l6H5/W7KbcMG5izDkIDDDhTV4qT8fnqMx6Lm6oS84JUfudqBT u7DYu5OtxW5GHMjsL3dxS1uthfcaT+y6nDfPDeMobRMYXolO71bmyOTY209DHUcMCDyXc7xVCv+um wRodJHyqqdDRVXtlljOzIg==; Date: Sun, 25 Aug 2024 10:29:22 +0300 Message-Id: <86r0adkqlp.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: (message from Jim Porter on Thu, 22 Aug 2024 09:19:47 -0700) Subject: Re: bug#72721: 31.0.50; Visual-wrap-prefix-mode breaks Magit log buffers References: <87cym4ry3e.fsf@gautierponsinet.xyz> <49828281-6a20-3791-91bd-9708ec51eb57@gmail.com> <86jzgbwgud.fsf@gnu.org> <36584786-6af4-c59f-bb3e-f3459b2904be@gmail.com> <86r0ajuigi.fsf@gnu.org> <86h6bcubn0.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72721 Cc: 72721@debbugs.gnu.org, gautier@gautierponsinet.xyz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 22 Aug 2024 09:19:47 -0700 > Cc: 72721@debbugs.gnu.org, gautier@gautierponsinet.xyz > From: Jim Porter > > On 8/22/2024 2:53 AM, Eli Zaretskii wrote: > > Thanks for the test cases, they helped a lot. > > > > Can you please try the patch below, including in the original use case > > with Magit? I hope I've figured out all of the quirks of min-width > > and its possible uses, and the few extensions you demonstrated. It > > should be possible now to have min-width on overlay strings as well, I > > think (but I didn't test that). > > This works for me in all my test cases (except "overlay-min-width"), > including the original report with Magit. I also replaced > 'Fget_text_property' with 'Fget_char_property' in 'get_display_property' > and tested that: it works with all my test cases, including > "overlay-min-width". > > If you're not too worried about using 'Fget_char_property', I think that > would be the preferable patch, since it would (probably?) make it easier > for me to fix a small bug I noticed in 'visual-wrap-prefix-mode': I > neglected to remove the 'min-width' properties when deactivating the > mode. Using overlays for that might make it easier to wipe them out at > the right time. I made the change to use Fget_char_property and installed the changeset on the master branch. Please note that overlays can be window-specific, and the changes I installed are supposed to handle that, but I didn't test that too much. Please test with window-specific overlays and see if it works correctly; if not, I'd appreciate a test case for looking into the failure. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 25 12:28:10 2024 Received: (at 72721) by debbugs.gnu.org; 25 Aug 2024 16:28:10 +0000 Received: from localhost ([127.0.0.1]:43182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1siG66-0002za-FW for submit@debbugs.gnu.org; Sun, 25 Aug 2024 12:28:10 -0400 Received: from mail-pl1-f169.google.com ([209.85.214.169]:48312) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1siG64-0002zJ-H2 for 72721@debbugs.gnu.org; Sun, 25 Aug 2024 12:28:09 -0400 Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-201df0b2df4so27840505ad.0 for <72721@debbugs.gnu.org>; Sun, 25 Aug 2024 09:27:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724603172; x=1725207972; darn=debbugs.gnu.org; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=qlYe3oTT3jnlyGvD5sOF0tvuznD+qXuUtQ0qm3YPHuI=; b=FbJV/ovTc+XNrpmVcuCMloIC+WGCVhUfIqAd9TY8aWRK/+FXj2oS6ThVhSbSnzW1De IrcrFcaPS64YXkUS0QALbAt4+tmdqUhqx9hUMTont3J0/4g5l6LTrY4ukkV+tpokjJrv dySRPPmOHaqCPzdqjZfpojBiFHw2ECXqr3BsBb85SW0v8rLp+ayF5At1WNNCzS3Pbs9x x+pZDkcx54KPHuts0U2QtRpzGdB+RnbC19By0T8/ExoWfRFcApwVn3+t+pfTCR6VHJ7s 2iE/CKj25cvoU63l+gdvLZLuW4uPzYmR4/mMMCF5DEV//PJh+jhMH4j5xACNKtqLetDA IJHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724603172; x=1725207972; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=qlYe3oTT3jnlyGvD5sOF0tvuznD+qXuUtQ0qm3YPHuI=; b=xOxsXe5Ec0kB3Urx+SQVIYvrE3kYFehx56byGgBy5KWnDrnQCSDtP65JFp9LkYjFRO uHLzfkUxpCsgk3XJrD/XcJy8xVEAmFegduulQagjCwAskEXbUAF2SJ8L0nmQcKhzxpKj Ml8XQNuKbJkIzF3DbyXq9n2lWSQZYlhgv9Y5aOBtYifVnKrNct2ThVa8RkmD3QdMC4pI HJMtUS6nEe+2XZc+5w6OOry4pE67yEAUFBUPgDp4dEwPaxZLY4/EF+exkU3ZIt6XvktN U2r2VQiZpnyaKnMIJXGkOSiAX2ib5CcbIcCloJ/d56xfk+YPUu+jTTw+q0kAyMe18l60 bglQ== X-Gm-Message-State: AOJu0Yy1F7lmnRnqvgfVgFKAVWg5gAw4+dn4d1z5T/nUDKrCNIt4iZAP B6B9PQeP/ob9ZvbKtIOFh0LyIxG8YYRMz4SOzxNsiDsONTHNPmJZVQkePw== X-Google-Smtp-Source: AGHT+IHy7iVfT6tZX+BpAF5K1JUaCqm8d2quPBk0jS/swjC4BpnaVidVrGgXer5UzwOCTR0i7j3MwA== X-Received: by 2002:a17:902:f64b:b0:1fa:4b9:d00f with SMTP id d9443c01a7336-2039e51b70fmr82846675ad.53.1724603172097; Sun, 25 Aug 2024 09:26:12 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-20385566585sm55804675ad.4.2024.08.25.09.26.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 25 Aug 2024 09:26:11 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------5UOCjJIxrqUu5CqClkESKgVX" Message-ID: <5209fe94-6999-ae56-2b6e-27f8c37c8b1d@gmail.com> Date: Sun, 25 Aug 2024 09:26:12 -0700 MIME-Version: 1.0 Subject: Re: bug#72721: 31.0.50; Visual-wrap-prefix-mode breaks Magit log buffers Content-Language: en-US To: Eli Zaretskii References: <87cym4ry3e.fsf@gautierponsinet.xyz> <49828281-6a20-3791-91bd-9708ec51eb57@gmail.com> <86jzgbwgud.fsf@gnu.org> <36584786-6af4-c59f-bb3e-f3459b2904be@gmail.com> <86r0ajuigi.fsf@gnu.org> <86h6bcubn0.fsf@gnu.org> <86r0adkqlp.fsf@gnu.org> From: Jim Porter In-Reply-To: <86r0adkqlp.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72721 Cc: 72721@debbugs.gnu.org, gautier@gautierponsinet.xyz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------5UOCjJIxrqUu5CqClkESKgVX Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/25/2024 12:29 AM, Eli Zaretskii wrote: > I made the change to use Fget_char_property and installed the > changeset on the master branch. Please note that overlays can be > window-specific, and the changes I installed are supposed to handle > that, but I didn't test that too much. Please test with > window-specific overlays and see if it works correctly; if not, I'd > appreciate a test case for looking into the failure. Thanks for merging. Everything looks correct to me. I've added a few more test cases to exercise window-specific overlays and they all work the way I'd expect. See attached. --------------5UOCjJIxrqUu5CqClkESKgVX Content-Type: text/plain; charset=UTF-8; name="test-cases.el" Content-Disposition: attachment; filename="test-cases.el" Content-Transfer-Encoding: base64 KHByb2duCiAgOzsgU2hvdWxkIGxvb2sgbGlrZToKICA7OyAxMjM0NQogIDs7IDY3OCAgICAg OTAKICAoc3dpdGNoLXRvLWJ1ZmZlciAic2ltcGxlIikKICAoZXJhc2UtYnVmZmVyKQogIChp bnNlcnQgIjEyMzQ1XG42Nzg5MCIpCiAgKHJlZGlzcGxheSkKICAocHV0LXRleHQtcHJvcGVy dHkKICAgNyAxMCAnZGlzcGxheSAnKChtaW4td2lkdGggKDgpKSkpKQoKCihwcm9nbgogIDs7 IFNob3VsZCBsb29rIGxpa2U6CiAgOzsgMTIzNDUKICA7OyA2NyAgODkgIDAKICAoc3dpdGNo LXRvLWJ1ZmZlciAiY29uc2VjdXRpdmUiKQogIChlcmFzZS1idWZmZXIpCiAgKGluc2VydCAi MTIzNDVcbjY3ODkwIikKICAocmVkaXNwbGF5KQogIChwdXQtdGV4dC1wcm9wZXJ0eQogICA3 IDkgJ2Rpc3BsYXkgJygobWluLXdpZHRoICg0KSkpKQogIChwdXQtdGV4dC1wcm9wZXJ0eQog ICA5IDExICdkaXNwbGF5ICcoKG1pbi13aWR0aCAoNCkpKSkpCgoKKHByb2duCiAgOzsgU2hv dWxkIGxvb2sgbGlrZToKICA7OyAxMjM0NQogIDs7IGhpICA4OTAKICAoc3dpdGNoLXRvLWJ1 ZmZlciAibmVzdGVkIikKICAoZXJhc2UtYnVmZmVyKQogIChpbnNlcnQgIjEyMzQ1XG42Nzg5 MCIpCiAgKHJlZGlzcGxheSkKICAocHV0LXRleHQtcHJvcGVydHkKICAgNyA5ICdkaXNwbGF5 CiAgIChwcm9wZXJ0aXplICJoaSIgJ2Rpc3BsYXkgJygobWluLXdpZHRoICg0KSkpKSkpCgoK KHByb2duCiAgOzsgU2hvdWxkIGxvb2sgbGlrZToKICA7OyAxMjM0NSAgICAgICAgIHwKICA7 OyA2NzggICAgIDkwICAgIHxYCiAgKHN3aXRjaC10by1idWZmZXIgIm92ZXJsYXkiKQogIChl cmFzZS1idWZmZXIpCiAgKGluc2VydCAiMTIzNDVcbjY3ODkwIikKICAoc2V0LXdpbmRvdy1t YXJnaW5zIChzZWxlY3RlZC13aW5kb3cpIDAgMSkKICAocmVkaXNwbGF5KQogIChzZXRxIG8g KG1ha2Utb3ZlcmxheSA4IDkpKQogIChvdmVybGF5LXB1dCBvICdiZWZvcmUtc3RyaW5nCiAg ICAgICAgICAgICAgIChwcm9wZXJ0aXplICJvIiAnZGlzcGxheSAnKChtYXJnaW4gcmlnaHQt bWFyZ2luKSAiWCIpKSkKICAocHV0LXRleHQtcHJvcGVydHkKICAgNyAxMCAnZGlzcGxheSAn KChtaW4td2lkdGggKDgpKSkpKQoKCihwcm9nbgogIDs7IFNob3VsZCBsb29rIGxpa2U6CiAg OzsgMTIzNDUKICA7OyA2NzggICAgIDkwCiAgKHN3aXRjaC10by1idWZmZXIgIm92ZXJsYXkt bWluLXdpZHRoIikKICAoZXJhc2UtYnVmZmVyKQogIChpbnNlcnQgIjEyMzQ1XG42Nzg5MCIp CiAgKHNldC13aW5kb3ctbWFyZ2lucyAoc2VsZWN0ZWQtd2luZG93KSAwIDEpCiAgKHJlZGlz cGxheSkKICAoc2V0cSBvIChtYWtlLW92ZXJsYXkgNyAxMCkpCiAgKG92ZXJsYXktcHV0IG8g J2Rpc3BsYXkgJygobWluLXdpZHRoICg4KSkpKSkKCgoocHJvZ24KICA7OyBTaG91bGQgbG9v ayBsaWtlOgogIDs7IDEyMzQ1ICAgICAgICAgfAogIDs7IDY3OCAgICAgOTAgICAgfFgKICAo c3dpdGNoLXRvLWJ1ZmZlciAib3ZlcmxheS1tdWx0aSIpCiAgKGVyYXNlLWJ1ZmZlcikKICAo aW5zZXJ0ICIxMjM0NVxuNjc4OTAiKQogIChzZXQtd2luZG93LW1hcmdpbnMgKHNlbGVjdGVk LXdpbmRvdykgMCAxKQogIChyZWRpc3BsYXkpCiAgKHNldHEgbzEgKG1ha2Utb3ZlcmxheSA3 IDEwKSkKICAob3ZlcmxheS1wdXQgbzEgJ2Rpc3BsYXkgJygobWluLXdpZHRoICg4KSkpKQog IChzZXRxIG8yIChtYWtlLW92ZXJsYXkgOCA5KSkKICAob3ZlcmxheS1wdXQgbzIgJ2JlZm9y ZS1zdHJpbmcKICAgICAgICAgICAgICAgKHByb3BlcnRpemUgIm8iICdkaXNwbGF5ICcoKG1h cmdpbiByaWdodC1tYXJnaW4pICJYIikpKSkKCgoocHJvZ24KICA7OyBTaG91bGQgbG9vayBs aWtlOgogIDs7IDEyMzQ1CiAgOzsgNjc4ICAgICA5MAogIDs7ID09PT09PT09PT09PT09PT09 PT09CiAgOzsgMTIzNDUKICA7OyA2Nzg5MAogIChzd2l0Y2gtdG8tYnVmZmVyICJvdmVybGF5 LXdpbmRvdyIpCiAgKHNwbGl0LXdpbmRvdy1iZWxvdykKICAoZXJhc2UtYnVmZmVyKQogIChp bnNlcnQgIjEyMzQ1XG42Nzg5MCIpCiAgKHJlZGlzcGxheSkKICAoc2V0cSBvIChtYWtlLW92 ZXJsYXkgNyAxMCkpCiAgKG92ZXJsYXktcHV0IG8gJ2Rpc3BsYXkgJygobWluLXdpZHRoICg4 KSkpKQogIChvdmVybGF5LXB1dCBvICd3aW5kb3cgKHNlbGVjdGVkLXdpbmRvdykpKQoKCihw cm9nbgogIDs7IFNob3VsZCBsb29rIGxpa2U6CiAgOzsgMTIzNDUKICA7OyA2NzggICAgIDkw CiAgOzsgPT09PT09PT09PT09PT09PT09PT0KICA7OyAxMjM0NQogIDs7IDY3ICAgODkwCiAg KHN3aXRjaC10by1idWZmZXIgIm92ZXJsYXktd2luZG93LW11bHRpIikKICAoc3BsaXQtd2lu ZG93LWJlbG93KQogIChlcmFzZS1idWZmZXIpCiAgKGluc2VydCAiMTIzNDVcbjY3ODkwIikK ICAocmVkaXNwbGF5KQogIChzZXRxIG8xIChtYWtlLW92ZXJsYXkgNyAxMCkpCiAgKG92ZXJs YXktcHV0IG8xICdkaXNwbGF5ICcoKG1pbi13aWR0aCAoOCkpKSkKICAob3ZlcmxheS1wdXQg bzEgJ3dpbmRvdyAoc2VsZWN0ZWQtd2luZG93KSkKICAoc2V0cSBvMiAobWFrZS1vdmVybGF5 IDcgOSkpCiAgKG92ZXJsYXktcHV0IG8yICdkaXNwbGF5ICcoKG1pbi13aWR0aCAoNSkpKSkK ICAob3ZlcmxheS1wdXQgbzIgJ3dpbmRvdyAoY2FyIChsYXN0ICh3aW5kb3ctbGlzdCkpKSkp Cg== --------------5UOCjJIxrqUu5CqClkESKgVX-- From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 25 13:40:59 2024 Received: (at 72721) by debbugs.gnu.org; 25 Aug 2024 17:40:59 +0000 Received: from localhost ([127.0.0.1]:43245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1siHEZ-0004yc-3g for submit@debbugs.gnu.org; Sun, 25 Aug 2024 13:40:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46216) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1siHEX-0004yK-8Q for 72721@debbugs.gnu.org; Sun, 25 Aug 2024 13:40:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1siHDc-00086y-7S; Sun, 25 Aug 2024 13:40:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=NwrYSJwcMU6eooRKK2xcM3p1JVAJu2qD8KuDAAtkdpM=; b=aXhQeUB5YVMj mVRLFdvuFC9pYG8x2ESgiy8L/S8231EiJx3XITfHdRhnBIj3B8LRAoE6KlRMg9uiQtIS3Yr/fchjb pN1qj6hHlE3ox1iCRgWg0IemrF3mymlZB1BHMIF4h7ZU22sA4XCtg22Y4WtbH2PVBhI4hwg/k09sC KNMjZ06/B9c1xaoRaDJwqu43pmSoDyKvTVA0WltlZIgd3C/dzWuWyoKR3r7ipPeOJ7fwg3kMxeVYB nDCt/5P/0YaBEAOeqLjmXUTs+GM/uJ8lj2C0h6FZkr+U8tuYpDBuGlb2ag7lPKLZ+apMPlcw5HfEF zgRd2CqsKeuk2uDv9A0Wig==; Date: Sun, 25 Aug 2024 20:39:57 +0300 Message-Id: <865xrolcwi.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: <5209fe94-6999-ae56-2b6e-27f8c37c8b1d@gmail.com> (message from Jim Porter on Sun, 25 Aug 2024 09:26:12 -0700) Subject: Re: bug#72721: 31.0.50; Visual-wrap-prefix-mode breaks Magit log buffers References: <87cym4ry3e.fsf@gautierponsinet.xyz> <49828281-6a20-3791-91bd-9708ec51eb57@gmail.com> <86jzgbwgud.fsf@gnu.org> <36584786-6af4-c59f-bb3e-f3459b2904be@gmail.com> <86r0ajuigi.fsf@gnu.org> <86h6bcubn0.fsf@gnu.org> <86r0adkqlp.fsf@gnu.org> <5209fe94-6999-ae56-2b6e-27f8c37c8b1d@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72721 Cc: 72721@debbugs.gnu.org, gautier@gautierponsinet.xyz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 25 Aug 2024 09:26:12 -0700 > Cc: 72721@debbugs.gnu.org, gautier@gautierponsinet.xyz > From: Jim Porter > > Thanks for merging. Everything looks correct to me. I've added a few > more test cases to exercise window-specific overlays and they all work > the way I'd expect. See attached. Thanks. How about adding these to test/manual/redisplay-testsuite.el? From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 25 14:43:41 2024 Received: (at 72721) by debbugs.gnu.org; 25 Aug 2024 18:43:42 +0000 Received: from localhost ([127.0.0.1]:43277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1siIDF-0006r5-FD for submit@debbugs.gnu.org; Sun, 25 Aug 2024 14:43:41 -0400 Received: from mail-pf1-f180.google.com ([209.85.210.180]:54346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1siIDC-0006qq-O3 for 72721@debbugs.gnu.org; Sun, 25 Aug 2024 14:43:39 -0400 Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-7143185edf2so2978396b3a.0 for <72721@debbugs.gnu.org>; Sun, 25 Aug 2024 11:42:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724611303; x=1725216103; darn=debbugs.gnu.org; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=xtrDZpCAF3u/6hkRcuezUyp4jEEMEmyKQvJx1NGu2rQ=; b=JArkuW44bNTrMTl6ugNaAWWVt+19VykgSfuBDPm7WvStKZPmx911IcRyF5kePSAdFh 3GQXYaDYX1SNBGoVuMmCMPBwRqPaOy3i1ZKld8GHDurOoCTswFuUnI/4P7BL4UNUWXSG FeCifbWslGX0WXG+qXGDTOUMGG83J3WXvsj4hoHzn/eA6Kn7cdFpHXUACJOGeNUM+gvR +uyBr0D4OUFf6moqeRNpfF6jLkAHC/YV8oCS3ezDaWvraF6Nv5UmjY48HWe5cSuN7xNd 0f2qQUodt9jnEVS9ykHWdk9kQmdKnuWDajzNtNKSZcnqxSJGDRbz9XE8fjNwXBSZ2fDc Clrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724611303; x=1725216103; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=xtrDZpCAF3u/6hkRcuezUyp4jEEMEmyKQvJx1NGu2rQ=; b=QvvlodMjV6pc3usADtqOhZEgBmZ72vFXLXgwAyO+cLCTsHe2aXzPr4oO1Ef3ecJjBx JsvRhK+78tplNP64RM24Pf7RK6IA/o6RTERsWBRjUflLGd63CACrhUrRHYbvOiI9e928 Lg+7p3NFbpm2M1cnFBj5Nu4pR21u/rO1QqV50SjtXj6aJRaEIdHT0q1cDj8QFSb4wktv aKs3twt0M9wt2jiysBIL90d/ZNJp1WiYjkS2UGa6RzuChTXB/6O+t1ZPQ4cXQjanVOAV V58QbbXobYO9nAsGvYpYtkTTWju/MpRIT1DdrPEDIkf8QMFIb8bsi4gn3vT6CadzlXRH 6Erg== X-Gm-Message-State: AOJu0YxSnnlypA3eFl3SMRuqh7ZyNOq4xxPuGjMaGsldx9U9XkGp60su uIIqtgggQg8ox1gi/r6Wz44hFfVr5ykKCo3wg0rqsXpzex8fGml6 X-Google-Smtp-Source: AGHT+IHxMAZufH2vmLXBvVd/+1irr1MjLNJAR6tyRW0lzEbUWTPsJqwCIvf5vBBakBSyJ1MEyaMyBQ== X-Received: by 2002:aa7:88cf:0:b0:714:147c:1377 with SMTP id d2e1a72fcca58-71445ce3f8dmr11255291b3a.7.1724611302393; Sun, 25 Aug 2024 11:41:42 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-7143432ee26sm5915816b3a.188.2024.08.25.11.41.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 25 Aug 2024 11:41:41 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------HKMr7hlFCq65xFeyd96Q8qYx" Message-ID: <0d872da4-fa50-480f-425d-9918c1d556fc@gmail.com> Date: Sun, 25 Aug 2024 11:41:40 -0700 MIME-Version: 1.0 Subject: Re: bug#72721: 31.0.50; Visual-wrap-prefix-mode breaks Magit log buffers Content-Language: en-US To: Eli Zaretskii References: <87cym4ry3e.fsf@gautierponsinet.xyz> <49828281-6a20-3791-91bd-9708ec51eb57@gmail.com> <86jzgbwgud.fsf@gnu.org> <36584786-6af4-c59f-bb3e-f3459b2904be@gmail.com> <86r0ajuigi.fsf@gnu.org> <86h6bcubn0.fsf@gnu.org> <86r0adkqlp.fsf@gnu.org> <5209fe94-6999-ae56-2b6e-27f8c37c8b1d@gmail.com> <865xrolcwi.fsf@gnu.org> From: Jim Porter In-Reply-To: <865xrolcwi.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72721 Cc: 72721@debbugs.gnu.org, gautier@gautierponsinet.xyz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------HKMr7hlFCq65xFeyd96Q8qYx Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/25/2024 10:39 AM, Eli Zaretskii wrote: >> Date: Sun, 25 Aug 2024 09:26:12 -0700 >> Cc: 72721@debbugs.gnu.org, gautier@gautierponsinet.xyz >> From: Jim Porter >> >> Thanks for merging. Everything looks correct to me. I've added a few >> more test cases to exercise window-specific overlays and they all work >> the way I'd expect. See attached. > > Thanks. How about adding these to test/manual/redisplay-testsuite.el? Do these look ok? It tests everything except window-specific overlays. (I could probably add that too, but I'd have to think of a simple way to explain to the reader how they should verify the expected results.) --------------HKMr7hlFCq65xFeyd96Q8qYx Content-Type: text/plain; charset=UTF-8; name="0001-Add-manual-tests-for-the-min-width-display-property.patch" Content-Disposition: attachment; filename*0="0001-Add-manual-tests-for-the-min-width-display-property.pat"; filename*1="ch" Content-Transfer-Encoding: base64 RnJvbSBlMzZmZTU2ZDFlOTc4M2U3MmQ0YWE3MDMyNDk4NGRjMjEwMTU5MzI0IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgMjUgQXVnIDIwMjQgMTE6Mzc6NDQgLTA3MDAKU3ViamVjdDogW1BB VENIXSBBZGQgbWFudWFsIHRlc3RzIGZvciB0aGUgJ21pbi13aWR0aCcgZGlzcGxheSBwcm9w ZXJ0eQoKKiB0ZXN0L21hbnVhbC9yZWRpc3BsYXktdGVzdHN1aXRlLmVsICh0ZXN0LXJlZGlz cGxheS01KTogQWRkIHNvbWUKbmV3bGluZXMuCih0ZXN0LXJlZGlzcGxheS02KTogTmV3IGZ1 bmN0aW9uLi4uCih0ZXN0LXJlZGlzcGxheSk6IC4uLiBjYWxsIGl0IChidWcjNzI3MjEpLgot LS0KIHRlc3QvbWFudWFsL3JlZGlzcGxheS10ZXN0c3VpdGUuZWwgfCA1NiArKysrKysrKysr KysrKysrKysrKysrKysrKysrKy0KIDEgZmlsZSBjaGFuZ2VkLCA1NSBpbnNlcnRpb25zKCsp LCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvdGVzdC9tYW51YWwvcmVkaXNwbGF5LXRl c3RzdWl0ZS5lbCBiL3Rlc3QvbWFudWFsL3JlZGlzcGxheS10ZXN0c3VpdGUuZWwKaW5kZXgg NmQxMjMyOTk5Y2EuLjBmMTNjM2RhNDE3IDEwMDY0NAotLS0gYS90ZXN0L21hbnVhbC9yZWRp c3BsYXktdGVzdHN1aXRlLmVsCisrKyBiL3Rlc3QvbWFudWFsL3JlZGlzcGxheS10ZXN0c3Vp dGUuZWwKQEAgLTMzMSw3ICszMzEsNjAgQEAgdGVzdC1yZWRpc3BsYXktNQogICAgICAgICAo dGVzdC1pbnNlcnQtb3ZlcmxheSAiICIgJ2Rpc3BsYXkgKGNoYXItdG8tc3RyaW5nICN4M2Zm ZmMpKSkKICAgKGluc2VydCAiXG5cbiIpCiAgIChpbnNlcnQtYnV0dG9uICJUb2dnbGUgYmV0 d2VlbiBvY3RhbCBhbmQgaGV4IGRpc3BsYXkiCi0gICAgICAgICAgICAgICAgICdhY3Rpb24g J3Rlc3QtcmVkaXNwbGF5LTUtdG9nZ2xlKSkKKyAgICAgICAgICAgICAgICAgJ2FjdGlvbiAn dGVzdC1yZWRpc3BsYXktNS10b2dnbGUpCisgIChpbnNlcnQgIlxuXG4iKSkKKworKGRlZnVu IHRlc3QtcmVkaXNwbGF5LTYgKCkKKyAgKGluc2VydCAiVGVzdCA2OiBtaW4td2lkdGggZGlz cGxheSBwcm9wZXJ0eTpcblxuIikKKyAgKGluc2VydCAiICBFeHBlY3RlZDogMTIzICA0NVxu IikKKyAgKGluc2VydCAiICBSZXN1bHRzOiAgIgorICAgICAgICAgIChwcm9wZXJ0aXplICIx MjMiICdkaXNwbGF5ICcoKG1pbi13aWR0aCAoNSkpKSkKKyAgICAgICAgICAiNDUiKQorICAo aW5zZXJ0ICJcblxuIikKKyAgKGluc2VydCAiICBFeHBlY3RlZDogMTIgIDM0ICA1XG4iKQor ICAoaW5zZXJ0ICIgIFJlc3VsdHM6ICAiCisgICAgICAgICAgKHByb3BlcnRpemUgIjEyIiAn ZGlzcGxheSAnKChtaW4td2lkdGggKDQpKSkpCisgICAgICAgICAgKHByb3BlcnRpemUgIjM0 IiAnZGlzcGxheSAnKChtaW4td2lkdGggKDQpKSkpCisgICAgICAgICAgIjUiKQorICAoaW5z ZXJ0ICJcblxuIikKKyAgKGluc2VydCAiICBFeHBlY3RlZDogMWdudSAgNDVcbiIpCisgIChp bnNlcnQgIiAgUmVzdWx0czogICIKKyAgICAgICAgICAiMSIKKyAgICAgICAgICAocHJvcGVy dGl6ZSAiMjMiICdkaXNwbGF5CisgICAgICAgICAgICAgICAgICAgICAgKHByb3BlcnRpemUg ImdudSIgJ2Rpc3BsYXkgJygobWluLXdpZHRoICg1KSkpKSkKKyAgICAgICAgICAiNDUiKQor ICAoaW5zZXJ0ICJcblxuIikKKyAgKGluc2VydCAiICBFeHBlY3RlZDogMTIzICA0NVxuIikK KyAgKGluc2VydCAiICBSZXN1bHRzOiAgIikKKyAgKHRlc3QtaW5zZXJ0LW92ZXJsYXkgIjEy MyIgJ2Rpc3BsYXkgJygobWluLXdpZHRoICg1KSkpKQorICAoaW5zZXJ0ICI0NSIpCisgIChp bnNlcnQgIlxuXG4iKQorICAoaW5zZXJ0ICIgIEV4cGVjdGVkOiAxXzIzIDQ1XG4iKQorICAo aW5zZXJ0ICIgIFJlc3VsdHM6ICAiKQorICAoaW5zZXJ0IChwcm9wZXJ0aXplICIxMjMiICdk aXNwbGF5ICcoKG1pbi13aWR0aCAoNSkpKSkpCisgIChsZXQgKChvdmVybGF5IChtYWtlLW92 ZXJsYXkgKC0gKHBvaW50KSAxKSAoLSAocG9pbnQpIDIpKSkpCisgICAgKG92ZXJsYXktcHV0 IG92ZXJsYXkgJ2JlZm9yZS1zdHJpbmcgIl8iKSkKKyAgKGluc2VydCAiNDUiKQorICAoaW5z ZXJ0ICJcblxuIikKKyAgKGluc2VydCAocHJvcGVydGl6ZSAiXyIgJ2Rpc3BsYXkgJyhsZWZ0 LWZyaW5nZSBsYXJnZS1jaXJjbGUpKQorICAgICAgICAgICIgIEV4cGVjdGVkOiAxMjMgIDQ1 XG4iKQorICAoaW5zZXJ0ICIgIFJlc3VsdHM6ICAiKQorICAoaW5zZXJ0IChwcm9wZXJ0aXpl ICIxMjMiICdkaXNwbGF5ICcoKG1pbi13aWR0aCAoNSkpKSkpCisgIChsZXQgKChvdmVybGF5 IChtYWtlLW92ZXJsYXkgKC0gKHBvaW50KSAyKSAoLSAocG9pbnQpIDEpKSkpCisgICAgKG92 ZXJsYXktcHV0IG92ZXJsYXkgJ2JlZm9yZS1zdHJpbmcKKyAgICAgICAgICAgICAgICAgKHBy b3BlcnRpemUgIl8iICdkaXNwbGF5ICcobGVmdC1mcmluZ2UgbGFyZ2UtY2lyY2xlKSkpKQor ICAoaW5zZXJ0ICI0NSIpCisgIChpbnNlcnQgIlxuXG4iKQorICAoaW5zZXJ0IChwcm9wZXJ0 aXplICJfIiAnZGlzcGxheSAnKGxlZnQtZnJpbmdlIGxhcmdlLWNpcmNsZSkpCisgICAgICAg ICAgIiAgRXhwZWN0ZWQ6IDEyMyAgNDVcbiIpCisgIChpbnNlcnQgIiAgUmVzdWx0czogICIp CisgIChpbnNlcnQgKHByb3BlcnRpemUgIjEyMyIgJ2Rpc3BsYXkgJygobWluLXdpZHRoICg1 KSkpKSkKKyAgKGxldCAoKG92ZXJsYXkxIChtYWtlLW92ZXJsYXkgKC0gKHBvaW50KSAzKSAo cG9pbnQpKSkKKyAgICAgICAgKG92ZXJsYXkyIChtYWtlLW92ZXJsYXkgKC0gKHBvaW50KSAy KSAoLSAocG9pbnQpIDEpKSkpCisgICAgKG92ZXJsYXktcHV0IG92ZXJsYXkxICdkaXNwbGF5 ICcoKG1pbi13aWR0aCAoNSkpKSkKKyAgICAob3ZlcmxheS1wdXQgb3ZlcmxheTIgJ2JlZm9y ZS1zdHJpbmcKKyAgICAgICAgICAgICAgICAgKHByb3BlcnRpemUgIl8iICdkaXNwbGF5ICco bGVmdC1mcmluZ2UgbGFyZ2UtY2lyY2xlKSkpKQorICAoaW5zZXJ0ICI0NSIpKQogCiAoZGVm dW4gdGVzdC1yZWRpc3BsYXkgKCkKICAgKGludGVyYWN0aXZlKQpAQCAtMzQ5LDYgKzQwMiw3 IEBAIHRlc3QtcmVkaXNwbGF5CiAgICAgKHRlc3QtcmVkaXNwbGF5LTMpCiAgICAgKHRlc3Qt cmVkaXNwbGF5LTQpCiAgICAgKHRlc3QtcmVkaXNwbGF5LTUpCisgICAgKHRlc3QtcmVkaXNw bGF5LTYpCiAgICAgKGdvdG8tY2hhciAocG9pbnQtbWluKSkpKQogCiA7OzsgcmVkaXNwbGF5 LXRlc3RzdWl0ZS5lbCBlbmRzIGhlcmUKLS0gCjIuMjUuMQoK --------------HKMr7hlFCq65xFeyd96Q8qYx-- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 29 07:48:17 2024 Received: (at 72721) by debbugs.gnu.org; 29 Aug 2024 11:48:17 +0000 Received: from localhost ([127.0.0.1]:50632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sjddR-0004fN-99 for submit@debbugs.gnu.org; Thu, 29 Aug 2024 07:48:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sjddP-0004f9-VE for 72721@debbugs.gnu.org; Thu, 29 Aug 2024 07:48:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sjdcQ-0004VG-Cd; Thu, 29 Aug 2024 07:47:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jjbuOq0Cc1Si9Tj5gOmkiIFwCtSyv+fqtKonq5EsBFc=; b=OfNkL2VFK8Xe //8LshEPx7194IceHXKcIWzuVG0R5nVcAMvVbzjNy0CvKKDSvt296T6pvzs12HYOuTFliI/1qiY1X ZedaxRCBqLQukg42QYZE7YtWcSYG1Nj5ZTuXhl6cu4268arqAIPtMMcYA4o8uy7i+9lDZmJcXAp5V Vy9AX2UnBss+zMLALECxBHYq+NL4SlcmV8m2rzTTRiI8dZb89z3fJqNe5CXuYoU5g77LtcF1qB6LC 2bQIwF28jylf5fkfM3EmPPw5SVgeQJzO82I43WoKx5wtGBT5JL4HnaYvSR4xdI8sW/sg5W7aNmaIn MYFnhyturqy67s9/6x60rQ==; Date: Thu, 29 Aug 2024 14:47:11 +0300 Message-Id: <86ikvjft4w.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: <0d872da4-fa50-480f-425d-9918c1d556fc@gmail.com> (message from Jim Porter on Sun, 25 Aug 2024 11:41:40 -0700) Subject: Re: bug#72721: 31.0.50; Visual-wrap-prefix-mode breaks Magit log buffers References: <87cym4ry3e.fsf@gautierponsinet.xyz> <49828281-6a20-3791-91bd-9708ec51eb57@gmail.com> <86jzgbwgud.fsf@gnu.org> <36584786-6af4-c59f-bb3e-f3459b2904be@gmail.com> <86r0ajuigi.fsf@gnu.org> <86h6bcubn0.fsf@gnu.org> <86r0adkqlp.fsf@gnu.org> <5209fe94-6999-ae56-2b6e-27f8c37c8b1d@gmail.com> <865xrolcwi.fsf@gnu.org> <0d872da4-fa50-480f-425d-9918c1d556fc@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72721 Cc: 72721@debbugs.gnu.org, gautier@gautierponsinet.xyz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 25 Aug 2024 11:41:40 -0700 > Cc: 72721@debbugs.gnu.org, gautier@gautierponsinet.xyz > From: Jim Porter > > > Thanks. How about adding these to test/manual/redisplay-testsuite.el? > > Do these look ok? It tests everything except window-specific overlays. LGTM, please install. From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 30 01:03:50 2024 Received: (at 72721-done) by debbugs.gnu.org; 30 Aug 2024 05:03:50 +0000 Received: from localhost ([127.0.0.1]:52318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sjtnZ-0003mL-UT for submit@debbugs.gnu.org; Fri, 30 Aug 2024 01:03:50 -0400 Received: from mail-pg1-f178.google.com ([209.85.215.178]:61734) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sjtnX-0003m5-9R for 72721-done@debbugs.gnu.org; Fri, 30 Aug 2024 01:03:48 -0400 Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-7c6b4222fe3so917362a12.3 for <72721-done@debbugs.gnu.org>; Thu, 29 Aug 2024 22:02:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724994105; x=1725598905; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=Ex+pa3BVZXU4LQh2+bdoEvmmXRk1QecRjECl2zSXjko=; b=NGU3vBac8yVq4KqPA5qSIj5VXtLUWwWLDqRmYMve5X22cekuMecRjtOA091Xzta2Ue XxIvIpvZHbaruMCkmsEhiXmcoOKsAMuTARvbQKpvVmdQehHiaQ0dQW3TrDxXaI48fxi4 KWeu2wNRR0Ug88BkfUjZk6v2Dqrsfd9A5iFU9MygKFSWfzpdYP9l839ye8HSfmHK833C 884n4vQeENMqTCefkz1bvWYo0+wWd0Fg9T9EVBUR5Ylth8cUXqknMNzRGCwta5gEZDQE qgoF+Vb3DwsV1RAGeEhy81yrMFR4U9Wx4dZArThVmcp87ykR5SjMeWklZYwRCZw+P+yE iwcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724994105; x=1725598905; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ex+pa3BVZXU4LQh2+bdoEvmmXRk1QecRjECl2zSXjko=; b=mWdK93H9QbWRjDQBZDddCXch1jsTN5pmrkrnPzQLjfg/g/UuoMLz2qyvjWyK45DW4f X/QJHXTjCzij7ntRNCNMPdLWhAlbY9yWkVLkHwWBNWRhJ7tkomhuN+PQFBaEJ+8dTB68 yIq03gAJG7O4MVlum+lEAKz0Z2jiw6ypgFIfClHhZ4DGPT6GXMKrhGwMs2jTsRbm9mwp N7JK7iV0IM5jKj6L/UzjRWkdjxeJNJ+Y6RhWXkirFj2gg054XxFDPcadlufa1X/Ehw/5 uHw6CmhOZcYOsdxhLseGGMFOTnq1UdqSFCnjj0NpDT+BgretUpYTuGB7ny/e0kR0pAc6 jLmA== X-Gm-Message-State: AOJu0Yz8X/oZvfWFS0miK1V3/oLElEQNdGiuVVyXRvYf6qtm/9Kb96U8 p7eZumbqbo7N+/GHKfkOoFc/NgJ/tIrIYVIQqZ1i9qTKL9jRLiMO X-Google-Smtp-Source: AGHT+IG1qwQ0BQ5j2un4lNLVh1jJiDdBgIfL/BquWMh/+t+8b4Cs/lNC4zSH67Tjf2O3U5q/zbAVhA== X-Received: by 2002:a05:6a20:ce49:b0:1ca:dbda:48f7 with SMTP id adf61e73a8af0-1cce0fed288mr4632599637.1.1724994105283; Thu, 29 Aug 2024 22:01:45 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id 98e67ed59e1d1-2d8446c1bf9sm5220885a91.35.2024.08.29.22.01.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Aug 2024 22:01:44 -0700 (PDT) Message-ID: Date: Thu, 29 Aug 2024 22:01:45 -0700 MIME-Version: 1.0 Subject: Re: bug#72721: 31.0.50; Visual-wrap-prefix-mode breaks Magit log buffers Content-Language: en-US To: Eli Zaretskii References: <87cym4ry3e.fsf@gautierponsinet.xyz> <49828281-6a20-3791-91bd-9708ec51eb57@gmail.com> <86jzgbwgud.fsf@gnu.org> <36584786-6af4-c59f-bb3e-f3459b2904be@gmail.com> <86r0ajuigi.fsf@gnu.org> <86h6bcubn0.fsf@gnu.org> <86r0adkqlp.fsf@gnu.org> <5209fe94-6999-ae56-2b6e-27f8c37c8b1d@gmail.com> <865xrolcwi.fsf@gnu.org> <0d872da4-fa50-480f-425d-9918c1d556fc@gmail.com> <86ikvjft4w.fsf@gnu.org> From: Jim Porter In-Reply-To: <86ikvjft4w.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72721-done Cc: 72721-done@debbugs.gnu.org, gautier@gautierponsinet.xyz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 8/29/2024 4:47 AM, Eli Zaretskii wrote: >> Date: Sun, 25 Aug 2024 11:41:40 -0700 >> Cc: 72721@debbugs.gnu.org, gautier@gautierponsinet.xyz >> From: Jim Porter >> >>> Thanks. How about adding these to test/manual/redisplay-testsuite.el? >> >> Do these look ok? It tests everything except window-specific overlays. > > LGTM, please install. Done in 91851fbbf53. I think everything's done now for this bug, so closing this. (If I missed something, just let me know.) From unknown Sun Jun 22 08:05:24 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 27 Sep 2024 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator