Subject: bug#72704: 29.4; repunctuate-sentences ignores NO-QUERY

From: Joseph Turner <[email-masked]>
Date: Sat, 31 Aug 2024 11:50:35 -0400

Eli Zaretskii <[email-masked]> writes:

>> From: Joseph Turner <[email-masked]>
>> Cc: [email-masked], [email-masked], [email-masked],
>> [email-masked]
>> Date: Sat, 31 Aug 2024 08:19:02 -0400
>> 
>> >   Noninteractively, if optional argument NO-QUERY is non-nil, make
>> > changes
>> >   without asking for confirmation.  To achieve the same effect
>> >   interactively, press \\<query-replace-map>\\[automatic] at the
>> > first...
>> 
>> Okay!  With the attached patch, I'm content to close this issue.
>
> One minor nit:
>
>> +Noninteractively, if optional argument NO-QUERY is non-nil, make
>> changes
>> +without asking for confirmation.  You can achieve the same effect
>> +interactively, press \\<query-replace-map>\\[automatic] at the
>> first prompt to skip remaining prompts.
>                   ^^^^^
> Either "by pressing" instead of "press" or use "To achieve the same
> effect", as I proposed originally.
>
> Otherwise, LGTM, thanks.

Good catch, thanks!

Joseph
>From dca1c5a6f3b56f7fe9f35f762732400e4e46c757 Mon Sep 17 00:00:00 2001
From: Joseph Turner <[email-masked]>
Date: Sat, 31 Aug 2024 08:15:53 -0400
Subject: [PATCH] Clarify skipping prompts in repunctuate-sentences docstring

* lisp/textmodes/paragraphs.el (repunctuate-sentences): Update docstring.

bug#72704

Suggested-by: Eli Zaretskii <[email-masked]>
---
 lisp/textmodes/paragraphs.el | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/lisp/textmodes/paragraphs.el b/lisp/textmodes/paragraphs.el
index be741e6517b..58d8d4b5f9c 100644
--- a/lisp/textmodes/paragraphs.el
+++ b/lisp/textmodes/paragraphs.el
@@ -545,9 +545,11 @@ repunctuate-sentences
 It works using `query-replace-regexp'.  In Transient Mark mode,
 if the mark is active, operate on the contents of the region.
 Second and third arg START and END specify the region to operate on.
-If optional argument NO-QUERY is non-nil, make changes without asking
-for confirmation.  You can use `repunctuate-sentences-filter' to add
-filters to skip occurrences of spaces that don't need to be replaced."
+Noninteractively, if optional argument NO-QUERY is non-nil, make changes
+without asking for confirmation.  To achieve the same effect
+interactively, press \\<query-replace-map>\\[automatic] at the first prompt to skip remaining prompts.
+Use `repunctuate-sentences-filter' to add filters to skip occurrences of
+spaces that don't need to be replaced."
   (declare (interactive-args (start (use-region-beginning))
                              (end (use-region-end))))
   (interactive (list nil (use-region-beginning) (use-region-end)))
-- 
2.41.0