GNU bug report logs - #72700
[PATCH] gnu: Remove an unnecessary test timeout for at-spi2-core

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72700 in the body.
You can then email your comments to 72700 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nikola <nikola <at> radojevic.rs>
To: guix-patches <at> gnu.org
Cc: Nikola <nikola <at> radojevic.rs>
Subject: [PATCH] gnu: Remove an unnecessary test timeout for at-spi2-core
Date: Sun, 18 Aug 2024 13:59:45 +0200

aarch64 builds keep failing because of this timeout, so removing this
timeout should help
---
 gnu/packages/gtk.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index 04183fa806..05041b57ab 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -856,6 +856,10 @@ (define-public at-spi2-core
                        (with-directory-excursion (string-append "../at-spi2-core-"
                                                                 #$version "")
                          (invoke "dbus-run-session" "--" "ci/run-registryd-tests.sh")
+                         ;; Remove test timeout which caused failed builds on
+                         ;; aarch64
+                         (substitute* "tests/atspi/meson.build"
+                           ((", timeout: [0-9]+") ""))
                          (substitute* "ci/run-tests.sh"
                            (("ps auxwww") "")   ;avoid a dependency on procps
                            (("meson test -C _build")
-- 
2.45.2

Message #10 received at 72700-done <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 72700-done <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: Remove an unnecessary test timeout for at-spi2-core
Date: Mon, 19 Aug 2024 00:36:59 +0200

[Message part 1 (text/plain, inline)]

Thanks!  Pushed as 58a839273d1e4fac2b3a0ec456aabdf82deaa124.

I tweaked the commit message to fit our norms, which mostly match 
the GNU ‘changelog’ style:

   gnu: at-spi2-core: Remove unnecessary test timeout.
   
   [Free-form blurb goes here, if you want, but more often than 
   not
    future readers are better served by a succinct code comment.]
   
   * gnu/packages/gtk.scm (at-spi2-core)[arguments]: Remove the
   ‘timeout’ argument from the test invocation.

Closing,

T G-R

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.