GNU bug report logs - #72690
[PATCH] gnu: Add checkmake.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#72690: closed ([PATCH] gnu: Add checkmake.)
Date: Wed, 21 Aug 2024 14:01:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 21 Aug 2024 14:58:58 +0100
with message-id <874j7ec6zh.fsf <at> gmail.com>
and subject line [PATCH] gnu: Add checkmake.
has caused the debbugs.gnu.org bug report #72690,
regarding [PATCH] gnu: Add checkmake.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
72690: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=72690
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: gemmaro <gemmaro.dev <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: gemmaro <gemmaro.dev <at> gmail.com>
Subject: [PATCH] gnu: Add checkmake.
Date: Sun, 18 Aug 2024 15:35:42 +0900

* gnu/packages/check.scm (checkmake): New variable.

Change-Id: Ic60c5c6d6cb66ff3a5760e11df741c5a4d7e7a4d
---
 gnu/packages/check.scm | 53 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 53 insertions(+)

diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm
index d76e6f8c95..096264a87a 100644
--- a/gnu/packages/check.scm
+++ b/gnu/packages/check.scm
@@ -51,6 +51,7 @@
 ;;; Copyright © 2024 Giacomo Leidi <goodoldpaul <at> autistici.org>
 ;;; Copyright © 2024 Zheng Junjie <873216071 <at> qq.com>
 ;;; Copyright © 2024 Navid Afkhami <navid.afkhami <at> mdc-berlin.de>
+;;; Copyright © 2024 gemmaro <gemmaro.dev <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -83,10 +84,12 @@ (define-module (gnu packages check)
   #:use-module (gnu packages gnome)
   #:use-module (gnu packages golang)
   #:use-module (gnu packages golang-build)
+  #:use-module (gnu packages golang-check)
   #:use-module (gnu packages golang-xyz)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages guile)
   #:use-module (gnu packages guile-xyz)
+  #:use-module (gnu packages haskell-xyz)
   #:use-module (gnu packages maths)
   #:use-module (gnu packages ncurses)
   #:use-module (gnu packages perl)
@@ -277,6 +280,56 @@ (define-public check-0.12
               (base32
                "0d22h8xshmbpl9hba9ch3xj8vb9ybm5akpsbbh7yj07fic4h2hj6"))))))
 
+(define-public checkmake
+  (package
+    (name "checkmake")
+    (version "0.2.2")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/mrtazz/checkmake")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1ajrgnm5mg4b317brx53b8cpjvdw6vin1rk6yh9vrhrz014ifps2"))
+       (modules '((guix build utils)))
+       (snippet `(begin
+                   (delete-file-recursively "vendor")
+                   (substitute* "Makefile"
+                     (("(VERSION := ).+" _ field)
+                      (string-append field
+                                     ,version)))))))
+    (build-system go-build-system)
+    (arguments
+     (list
+      #:import-path "github.com/mrtazz/checkmake"
+      #:phases #~(modify-phases %standard-phases
+                   (add-after 'install 'install-man
+                     (lambda _
+                       (setenv "BUILDER_NAME" "Guix")
+                       (setenv "BUILDER_EMAIL" "bug-guix <at> gnu.org")
+                       (with-directory-excursion "src/github.com/mrtazz/checkmake"
+                         (for-each (lambda (file)
+                                     (let ((target (basename file ".md")))
+                                       (invoke "make" target)
+                                       (install-file target
+                                                     (string-append #$output
+                                                                    "/share/man/man1"))))
+                                   (find-files "man/man1"))))))))
+    (native-inputs (list pandoc))
+    (propagated-inputs (list go-github-com-stretchr-testify
+                             go-github-com-olekukonko-tablewriter
+                             go-github-com-go-ini-ini
+                             go-github-com-docopt-docopt-go))
+    (home-page "https://github.com/mrtazz/checkmake")
+    (synopsis "Linter and analyzer for @file{Makefile}")
+    (description
+     "@samp{checkmake} is an experimental tool for linting and checking
+Makefiles.  It allows for a set of configurable rules being run
+against a @file{Makefile} or a set of @file{*.mk} files.")
+    (license license:expat)))
+
 ;;; XXX: This project is abandoned upstream, and included in modern catch2
 ;;; releases.  It is still depended by the restinio test suite at this time,
 ;;; so keep it (see: https://github.com/Stiffstream/restinio/issues/181).

base-commit: 6c045f2c9eb7b8efe7c8a1002cda990abaa9be1a
-- 
2.45.2

[Message part 3 (message/rfc822, inline)]

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 72690-done <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add checkmake.
Date: Wed, 21 Aug 2024 14:58:58 +0100

[Message part 4 (text/plain, inline)]

Hi,

Applied and pushed as 7a149c6003d25e8b2794b113d34062be134d7710 to master.

- modifications [4/4]
  - [X] Swap pandoc to go-github-com-go-md2man to generate man pages from Markdown
  - [X] Set all inputs as native
  - [X] Do not install sources
  - [X] Do not set version in snippet as it has no effect, we do not use provided Makefile

--
Oleg

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.