GNU bug report logs - #72674
[PATCH] gnu: guix: Remove unnecessary dependencies.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Subject: bug#72674: closed (Re: [bug#72674] [PATCH] gnu: guix: Remove
 unnecessary dependencies.)
Date: Sat, 31 Aug 2024 17:11:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#72674: [PATCH] gnu: guix: Remove unnecessary dependencies.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 72674 <at> debbugs.gnu.org.

-- 
72674: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=72674
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Janneke Nieuwenhuizen <janneke <at> gnu.org>
Cc: 72674-done <at> debbugs.gnu.org, maxim.cournoyer <at> gmail.com
Subject: Re: [bug#72674] [PATCH] gnu: guix: Remove unnecessary dependencies.
Date: Sat, 31 Aug 2024 19:09:27 +0200

Hi,

Janneke Nieuwenhuizen <janneke <at> gnu.org> skribis:

> Ludovic Courtès writes:
>
>> In principle I agree it would be nice, but there’s no guarantee that
>> ‘%current-system’ will have the “right” value when the manifest is
>> evaluated.
>
> ah.
>
>>> Maybe it's premature; as I'm not even sure if fails to builds natively;
>>> some of its dependencies don't cross-build, but it may just build on the
>>> Hurd?  I haven't built a guix checkout in a childhurd for some time...
>>
>> Yeah.  I’d lean towards keeping things simple for now, and we can always
>> do ‘guix shell -D guix’ on the Hurd… until everything builds fine.  :-)
>>
>> WDYT?
>
> Yes, sure; guess we can manage that :)

Pushed as 9af235335e8f8baf7f434a76570a954999231879.

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: guix-patches <at> gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Janneke Nieuwenhuizen <janneke <at> gnu.org>
Subject: [PATCH] gnu: guix: Remove unnecessary dependencies.
Date: Fri, 16 Aug 2024 19:54:36 +0200

This reverts 0fda0486523d67c2c464386c07a0c2800d8d8c20, instead moving
the dependencies needed for ‘make dist’ to ‘manifest.scm’.

Removing this extra dependencies make it simpler to build the ‘guix’
package in particular on less-capable systems like i586-gnu.

* gnu/packages/package-management.scm (guix)[native-inputs]: Remove
IMAGEMAGICK and PERL.  Use GRAPHVIZ-MINIMAL instead of GRAPHVIZ.
* manifest.scm: Use the full-blown ‘graphviz’ package; add ‘imagemagick’
and ‘perl’.

Reported-by: Janneke Nieuwenhuizen <janneke <at> gnu.org>
Change-Id: Ia9d05c699e3cc2f9a9235a67f8ec840c26b66a82
---
 gnu/packages/package-management.scm |  4 +---
 manifest.scm                        | 16 +++++++++++++++-
 2 files changed, 16 insertions(+), 4 deletions(-)

Hi!

As Janneke noted in <https://issues.guix.gnu.org/72643#7-lineno16>,
the new imagemagick dependency made it harder to get ‘guix’ built on
i586-gnu.  It’s also unnecessary.

WDYT?

Thanks,
Ludo’.

diff --git a/gnu/packages/package-management.scm b/gnu/packages/package-management.scm
index 77bda7f231..6fe0515d00 100644
--- a/gnu/packages/package-management.scm
+++ b/gnu/packages/package-management.scm
@@ -491,10 +491,8 @@ (define-public guix
                        ("automake" ,automake)
                        ("gettext" ,gettext-minimal)
                        ("texinfo" ,texinfo)
-                       ("graphviz" ,graphviz) ;non-minimal for PDF support
+                       ("graphviz" ,graphviz-minimal)
                        ("font-ghostscript" ,font-ghostscript) ;fonts for 'dot'
-                       ("imagemagick" ,imagemagick) ;for 'make dist'
-                       ("perl" ,perl)               ;for 'make dist'
                        ("help2man" ,help2man)
                        ("po4a" ,po4a-minimal)))
       (inputs
diff --git a/manifest.scm b/manifest.scm
index 7e4d82c3a5..27e1d62566 100644
--- a/manifest.scm
+++ b/manifest.scm
@@ -24,11 +24,25 @@
 ;;
 ;;     guix shell --pure -m manifest.scm hello ...
 
+(use-modules (guix packages))
+
 (concatenate-manifests
- (list (package->development-manifest (specification->package "guix"))
+ (list (package->development-manifest
+        (let ((guix (specification->package "guix")))
+          (package/inherit guix
+            ;; Replace with non-minimal Graphviz for PDF support.
+            (native-inputs (modify-inputs (package-native-inputs guix)
+                             (replace "graphviz"
+                               (specification->package "graphviz")))))))
+
        ;; Extra packages used by unit tests.
        (specifications->manifest (list "gnupg"))
 
+       ;; Packages needed for 'make dist' and 'make distcheck'.
+       (specifications->manifest
+        (list "imagemagick"
+              "perl"))
+
        ;; Useful extras for patches submission.
        (specifications->manifest
         (list "b4"

base-commit: 72e586fcae78e467d01e2add09c1db26be6bfa93
-- 
2.45.2

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.