Subject: Re: [bug#72665] [PATCH] Add bitrot-plugins package

From: 宋文武 <[email-masked]>
Date: Tue, 04 Feb 2025 18:26:33 +0800

Apoorv <[email-masked]> writes:

> From: apoorv569 <[email-masked]>
> Date: Fri, 16 Aug 2024 15:36:25 +0530
> Subject: [PATCH 12/13] Add bitrot-plugins package
>
> ---
>  gnu/packages/music.scm | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index d3e247bd10..5b89419b07 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -8549,6 +8549,34 @@ (define-public ykchorus
>  well-known Japanese vintage analog synthesizers (You Know which).")
>       (license license:gpl2))))
>  
> +(define-public bitrot-plugins
> +  (let ((commit "06a72cd6cbe99b469e57a662cfb34e1cfe75e070")
> +        (revision "0"))
> +    (package
> +     (name "bitrot-plugins")
> +     (version (git-version "0.7" revision commit))
> +     (source
> +      (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/grejppi/bitrot")
> +             (recursive? #t)
> +             (commit commit)))

I see there are some packages you sent both use DPF, can we build it as
a shared library and unbundle DPF in each plugin package?

> +       (sha256
> +        (base32 "0gfhy6a1cc8czrw2bq922b87584fbzpvwdzrl0vv3acda03z1f85"))
> +       (file-name (git-file-name name version))))
> +     (build-system waf-build-system)
> +     (arguments
> +      `(#:configure-flags (list "--platform=linux64")

Is this 'platform' argument actually needed?  Not tried, but I think
it's for cross-compile, and when not specified it should default to
current one..

> +        #:phases (modify-phases %standard-phases
> +                                ;; no check target
> +                                (delete 'check))))
> +     (home-page "https://github.com/grejppi/bitrot")
> +     (synopsis "Audio effect plugins (LV2, VST2, LADSPA) for glitch effects")
> +     (description
> +      "Audio effect plugins (LV2, VST2, LADSPA) for glitch effects")

Description should be a full sentence, ends with period.