From unknown Sat Jun 21 12:10:38 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#72642 <72642@debbugs.gnu.org> To: bug#72642 <72642@debbugs.gnu.org> Subject: Status: [PATCH] substitute: Reopen connection upon =?UTF-8?Q?=E2=80=9CError?= in the push =?UTF-8?Q?function=E2=80=9D?= from GnuTLS. Reply-To: bug#72642 <72642@debbugs.gnu.org> Date: Sat, 21 Jun 2025 19:10:38 +0000 retitle 72642 [PATCH] substitute: Reopen connection upon =E2=80=9CError in = the push function=E2=80=9D from GnuTLS. reassign 72642 guix-patches submitter 72642 Ludovic Court=C3=A8s severity 72642 normal tag 72642 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 15 12:19:10 2024 Received: (at submit) by debbugs.gnu.org; 15 Aug 2024 16:19:10 +0000 Received: from localhost ([127.0.0.1]:49576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sedBt-0002Ji-VD for submit@debbugs.gnu.org; Thu, 15 Aug 2024 12:19:10 -0400 Received: from lists.gnu.org ([209.51.188.17]:60906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sedBs-0002Ja-3g for submit@debbugs.gnu.org; Thu, 15 Aug 2024 12:19:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sedBH-0005lO-5P for guix-patches@gnu.org; Thu, 15 Aug 2024 12:18:31 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sedBG-0005UO-T9; Thu, 15 Aug 2024 12:18:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=yiVK7xbBrgMU8PEhQItGNkzOtEIcrx0usFaEuIFJXqA=; b=GLNJ7L4igWoheO qQS/N8CJ2iM5vUD15VRnO+W+jpyZUKwzzNl9WnAzGiWA3gWWZj0iZEsvwbMCGjmmRXJWRujXJtgcp KSz6w9SG/8k5YhhqyWgyvAPaGzeCWQ9fjeO0QGSBttDyVhCJ+uxlEv+CbKqEnbmJmNaSszhIZZmGG ZiVMUSUQYY/4bcFsFRVDv7Vz9+cRA1A2gvW9JwUIIb4WRZGMDxS5X5MYSZmXdQtAySyGbbEbxEoYt zXLXrHorXXdKgpYug4AoOB2x1U0hL3d/uyZoG0lg+xSWcfWB+4jJHY4rKyPiBVDYfxUj/wOmuJt9U Hn7j7z1ftBf/VZOEGn/A==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: guix-patches@gnu.org Subject: [PATCH] =?UTF-8?q?substitute:=20Reopen=20connection=20upon=20?= =?UTF-8?q?=E2=80=9CError=20in=20the=20push=20function=E2=80=9D=20from=20G?= =?UTF-8?q?nuTLS.?= Date: Thu, 15 Aug 2024 18:18:19 +0200 Message-ID: X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This works around an occasional issue where substitution stops abruptly due to “Error in the push function” from GnuTLS, as reported at by Richard Sent. * guix/scripts/substitute.scm (call-with-cached-connection): Add ‘error/push-error’ and ‘error/pull-error’ to the list of gnutls-error values for which the connection is reopened. Change-Id: Icf079dd10b16739f62fee15bc3d90bab77110576 --- guix/scripts/substitute.scm | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) Hi! This is an attempt to work around the dreaded “Error in the push function” coming from GnuTLS and that would cause substitution to fail (“‘guix substitute’ died unexpectedly”). With this patch, a new connection attempt is made. This is not fully satisfactory since we don’t understand yet what causes that error, which is not supposed to happen AIUI. But at least, it should provide more graceful handling. Thoughts? Thanks, Ludo’. diff --git a/guix/scripts/substitute.scm b/guix/scripts/substitute.scm index 8bcbca5e7a..8db730a9c0 100755 --- a/guix/scripts/substitute.scm +++ b/guix/scripts/substitute.scm @@ -43,7 +43,11 @@ (define-module (guix scripts substitute) #:select (uri-abbreviation nar-uri-abbreviation (open-connection-for-uri . guix:open-connection-for-uri))) - #:autoload (gnutls) (error/invalid-session error/again error/interrupted) + #:autoload (gnutls) (error/invalid-session + error/again + error/interrupted + error/push-error + error/pull-error) #:use-module (guix progress) #:use-module ((guix build syscalls) #:select (set-thread-name)) @@ -426,6 +430,11 @@ (define (call-with-cached-connection uri proc) (memq (first args) (list error/invalid-session + ;; "Error in the push function" is + ;; usually a transient error. + error/push-error + error/pull-error + ;; XXX: These two are not properly handled in ;; GnuTLS < 3.7.3, in ;; 'write_to_session_record_port'; see base-commit: 72e586fcae78e467d01e2add09c1db26be6bfa93 -- 2.45.2 From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 31 13:10:50 2024 Received: (at control) by debbugs.gnu.org; 31 Aug 2024 17:10:51 +0000 Received: from localhost ([127.0.0.1]:55996 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1skRcg-0005vf-M2 for submit@debbugs.gnu.org; Sat, 31 Aug 2024 13:10:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41288) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1skRce-0005vN-Sb for control@debbugs.gnu.org; Sat, 31 Aug 2024 13:10:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1skRbc-0003QL-SU for control@debbugs.gnu.org; Sat, 31 Aug 2024 13:09:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:Subject:From:To:Date:in-reply-to: references; bh=7/FEnkLibE81wgiXyNpC/S7wz6yjIjehdlmMgGw1QeE=; b=Nk0kiFgpnoedCS qUiYmPTwSucQASr+pUmDkxZLuO7xaHzEps1tCtydQizijMuEGcXql7ZYZBNRS5BwN1ZGUz/w9PcLU v7z352ElEGmgmxhPFZMQMeuaoZS9fr2XIB670g3+vocptQouksE3pmVr9dKcr4RWWeou/w8Y69brM P/8Q1Qt+MEuq8ORP9ZXIJzRRW1ERK7CoNyE2EUVOI5tNw9ZUQmfXfA2cg0/LSGoOgpWRS9GJ8Xs/e TzI7276QhbO0YVOEwWylruAnOZ6PpPIKMIwZJtP9ANzBFzHlcBxChwSex2IGzc1mdhSrq46b7P9As yPxQds7RxfV1p5O0DWiA==; Date: Sat, 31 Aug 2024 19:09:43 +0200 Message-Id: <87ikvghb54.fsf@gnu.org> To: control@debbugs.gnu.org From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: control message for bug #72642 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 72642 quit From unknown Sat Jun 21 12:10:38 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 29 Sep 2024 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator