Subject: Re: [bug#72632] [PATCH] gnu: Add emacs-tinysegmenter.

From: Liliana Marie Prikler <[email-masked]>
Date: Thu, 15 Aug 2024 07:50:30 +0200

Am Mittwoch, dem 14.08.2024 um 22:05 -0500 schrieb Spencer King:
> * gnu/packages/emacs-xyz.scm (emacs-tinysegmenter): New variable.
> 
> Change-Id: Ibad46e4db2a1d49b4f40c8ea6d2f6f19d271aa29
> ---
>  gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index df66aea507..0c6af181fa 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -143,6 +143,7 @@
>  ;;; Copyright © 2024 Noé Lopez <[email-masked]>
>  ;;; Copyright © 2024 gemmaro <[email-masked]>
>  ;;; Copyright © 2024 Daniel Szmulewicz <[email-masked]>
> +;;; Copyright © 2024 Spencer King <[email-masked]>
>  
>  ;;;
>  ;;; This file is part of GNU Guix.
> @@ -6301,6 +6302,27 @@ (define-public emacs-kanji
>  and limited version of the images provided by the KanjiVG project.")
>        (license license:gpl3+))))
>  
> +(define-public emacs-tinysegmenter
> +  (package
> +    (name "emacs-tinysegmenter")
> +    (version "20141124.1013")
Note: we don't do MELPA versioning.  Use git-version instead.
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/myuhe/tinysegmenter.el")
> +             (commit "872134704bd25c13a4c59552433da4c6881b5230")))
IMHO, commit tags should always be let-bound.  There are a few odd
cases in which they aren't, but these are exceptions, not the rule.
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> "1n8cn6mr26hgmsm2mkbj5gs6dv61d0pap8ija4g0n1vsibfhzd8j"))))
> +    (build-system emacs-build-system)
> +    (home-page "https://github.com/myuhe/tinysegmenter.el")
> +    (synopsis "Super compact Japanese tokenizer in Emacs Lisp")
Avoid marketing terms like "super compact".  "Compact" ought to suffice
if there's a distinction to make.
> +    (description
> +     "This package provides functions for tokenizing Japanese text
> in
> +Emacs buffers.")
> +    (license license:bsd-3)))

Cheers