GNU bug report logs - #72632
[PATCH] gnu: Add emacs-tinysegmenter.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72632 in the body.
You can then email your comments to 72632 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Spencer King <spencer <at> nursiapress.com>
To: guix-patches <at> gnu.org
Cc: Spencer King <spencer <at> nursiapress.com>
Subject: [PATCH] gnu: Add emacs-tinysegmenter.
Date: Wed, 14 Aug 2024 22:05:59 -0500

* gnu/packages/emacs-xyz.scm (emacs-tinysegmenter): New variable.

Change-Id: Ibad46e4db2a1d49b4f40c8ea6d2f6f19d271aa29
---
 gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index df66aea507..0c6af181fa 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -143,6 +143,7 @@
 ;;; Copyright © 2024 Noé Lopez <noelopez <at> free.fr>
 ;;; Copyright © 2024 gemmaro <gemmaro.dev <at> gmail.com>
 ;;; Copyright © 2024 Daniel Szmulewicz <daniel.szmulewicz <at> gmail.com>
+;;; Copyright © 2024 Spencer King <spencer.king <at> nursiapress.com>
 
 ;;;
 ;;; This file is part of GNU Guix.
@@ -6301,6 +6302,27 @@ (define-public emacs-kanji
 and limited version of the images provided by the KanjiVG project.")
       (license license:gpl3+))))
 
+(define-public emacs-tinysegmenter
+  (package
+    (name "emacs-tinysegmenter")
+    (version "20141124.1013")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/myuhe/tinysegmenter.el")
+             (commit "872134704bd25c13a4c59552433da4c6881b5230")))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1n8cn6mr26hgmsm2mkbj5gs6dv61d0pap8ija4g0n1vsibfhzd8j"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/myuhe/tinysegmenter.el")
+    (synopsis "Super compact Japanese tokenizer in Emacs Lisp")
+    (description
+     "This package provides functions for tokenizing Japanese text in
+Emacs buffers.")
+    (license license:bsd-3)))
+
 (define-public emacs-kbd
   ;; Package has no release.  Version is extracted from "Version:" keyword in
   ;; main file.

base-commit: ca5ff8aa8b50ac317003d76cc4ea2a621d5a3819
-- 
2.41.0

Message #8 received at 72632 <at> debbugs.gnu.org (full text, mbox):

From: Spencer King <spencer <at> nursiapress.com>
To: 72632 <at> debbugs.gnu.org
Date: Wed, 14 Aug 2024 22:17:06 -0500

If you are looking to confirm the license it is linked in a source code comment 
in the file tinysegmenter.el.

Message #11 received at 72632 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Spencer King <spencer <at> nursiapress.com>, 72632 <at> debbugs.gnu.org
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#72632] [PATCH] gnu: Add emacs-tinysegmenter.
Date: Thu, 15 Aug 2024 07:50:30 +0200

Am Mittwoch, dem 14.08.2024 um 22:05 -0500 schrieb Spencer King:
> * gnu/packages/emacs-xyz.scm (emacs-tinysegmenter): New variable.
> 
> Change-Id: Ibad46e4db2a1d49b4f40c8ea6d2f6f19d271aa29
> ---
>  gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index df66aea507..0c6af181fa 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -143,6 +143,7 @@
>  ;;; Copyright © 2024 Noé Lopez <noelopez <at> free.fr>
>  ;;; Copyright © 2024 gemmaro <gemmaro.dev <at> gmail.com>
>  ;;; Copyright © 2024 Daniel Szmulewicz <daniel.szmulewicz <at> gmail.com>
> +;;; Copyright © 2024 Spencer King <spencer.king <at> nursiapress.com>
>  
>  ;;;
>  ;;; This file is part of GNU Guix.
> @@ -6301,6 +6302,27 @@ (define-public emacs-kanji
>  and limited version of the images provided by the KanjiVG project.")
>        (license license:gpl3+))))
>  
> +(define-public emacs-tinysegmenter
> +  (package
> +    (name "emacs-tinysegmenter")
> +    (version "20141124.1013")
Note: we don't do MELPA versioning.  Use git-version instead.
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/myuhe/tinysegmenter.el")
> +             (commit "872134704bd25c13a4c59552433da4c6881b5230")))
IMHO, commit tags should always be let-bound.  There are a few odd
cases in which they aren't, but these are exceptions, not the rule.
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> "1n8cn6mr26hgmsm2mkbj5gs6dv61d0pap8ija4g0n1vsibfhzd8j"))))
> +    (build-system emacs-build-system)
> +    (home-page "https://github.com/myuhe/tinysegmenter.el")
> +    (synopsis "Super compact Japanese tokenizer in Emacs Lisp")
Avoid marketing terms like "super compact".  "Compact" ought to suffice
if there's a distinction to make.
> +    (description
> +     "This package provides functions for tokenizing Japanese text
> in
> +Emacs buffers.")
> +    (license license:bsd-3)))

Cheers

Message #16 received at 72632-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Spencer King <spencer <at> nursiapress.com>
Cc: 72632-done <at> debbugs.gnu.org
Subject: Re: [bug#72632] [PATCH] gnu: Add emacs-tinysegmenter.
Date: Tue, 20 Aug 2024 10:26:42 +0200

Hello,

Spencer King <spencer <at> nursiapress.com> writes:

> * gnu/packages/emacs-xyz.scm (emacs-tinysegmenter): New variable.

I applied the patch with the changes suggested by Liliana. Thank you.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.