GNU bug report logs - #72621
[PATCH] gnu: Add clasp.

Previous Next

Package: guix-patches;

Reported by: ashish.is <at> lostca.se

Date: Wed, 14 Aug 2024 12:51:01 UTC

Severity: normal

Tags: patch

Done: Guillaume Le Vaillant <glv <at> posteo.net>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Aleksej <lesikedelweiss <at> disroot.org>
To: 72621 <at> debbugs.gnu.org
Subject: [bug#72621] [PATCH] gnu: Add clasp.
Date: Thu, 15 Aug 2024 14:12:58 +0300

Hi! I've applied your patch, and it seems to have some problems.

1) We already have the package with name "clasp", consider renaming it 
to something like "clasp-cl".

2) The license of clasp should be "lgpl2.1+", not "lgpl2.1".

3) After renaming run "guix lint" on the package, it has quite a lot of 
warnings.

4) I see you use gnu-build-system, and modify it a lot to use ninja. We 
have meson-build-system in GNU Guix, shouldn't it be used instead?

Also I've looked at clasp git repo, they have package definition for GNU 
Guix, maybe you should check it out!

-- 
Best regards,
Lesik Edelweiss
This bug report was last modified 275 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.