GNU bug report logs - #72596
[PATCH] gnu: mrg: Fix the build.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72596 in the body.
You can then email your comments to 72596 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Subject: [PATCH] gnu: mrg: Fix the build.
Date: Tue, 13 Aug 2024 00:45:51 +0300

* gnu/packages/graphics.scm (mrg): Fix the build.
[arguments]: Add "patch-meson-build" phase.
[home-page]: Fix the URL.

Change-Id: If6f1a255e864669a10c646ee0d991e6fabdcb6b9
---
 gnu/packages/graphics.scm | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/graphics.scm b/gnu/packages/graphics.scm
index 8eae1ed89d..1d5fc1e4da 100644
--- a/gnu/packages/graphics.scm
+++ b/gnu/packages/graphics.scm
@@ -162,6 +162,16 @@ (define-public mmm
        (sha256
         (base32 "1xmcv6rwinqsbr863rgl9005h2jlmd7k2qrwsc1h4fb8r61ykpjl"))))
     (build-system meson-build-system)
+    (arguments
+     (list #:phases #~(modify-phases %standard-phases
+                        ;; XXX: Meson build fails due to a misspelling of
+                        ;; "description" keyword in the configuration.  This phase
+                        ;; fixes that.
+                        (add-after 'unpack 'patch-meson-build
+                          (lambda _
+                            (substitute* "meson.build"
+                              (("not stable, Description:")
+                               "not stable, description:")))))))
     (native-inputs
      (list luajit pkg-config))
     (inputs
@@ -169,7 +179,7 @@ (define-public mmm
     (synopsis "Memory Mapped Machine")
     (description "MMM is a shared memory protocol for virtualising access to
 framebuffer graphics, audio output and input event.")
-    (home-page "https://github.com/hodefoting/mrg")
+    (home-page "https://github.com/hodefoting/mmm")
     (license license:isc)))
 
 (define-public directfb

base-commit: 487dd0077fed2ef7a91bd71af0e23421ab715710
-- 
2.45.2

Message #8 received at 72596 <at> debbugs.gnu.org (full text, mbox):

From: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
To: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Cc: 72596 <at> debbugs.gnu.org
Subject: Re: [bug#72596] [PATCH] gnu: mrg: Fix the build.
Date: Sat, 17 Aug 2024 14:05:49 +0800

[Message part 1 (text/plain, inline)]

"Artyom V. Poptsov" <poptsov.artyom <at> gmail.com> writes:

> * gnu/packages/graphics.scm (mrg): Fix the build.
> [arguments]: Add "patch-meson-build" phase.
> [home-page]: Fix the URL.
>
> Change-Id: If6f1a255e864669a10c646ee0d991e6fabdcb6b9
> ---
>  gnu/packages/graphics.scm | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/graphics.scm b/gnu/packages/graphics.scm
> index 8eae1ed89d..1d5fc1e4da 100644
> --- a/gnu/packages/graphics.scm
> +++ b/gnu/packages/graphics.scm
> @@ -162,6 +162,16 @@ (define-public mmm
>         (sha256
>          (base32 "1xmcv6rwinqsbr863rgl9005h2jlmd7k2qrwsc1h4fb8r61ykpjl"))))
>      (build-system meson-build-system)
> +    (arguments
> +     (list #:phases #~(modify-phases %standard-phases
> +                        ;; XXX: Meson build fails due to a misspelling of
> +                        ;; "description" keyword in the configuration.  This phase
> +                        ;; fixes that.
> +                        (add-after 'unpack 'patch-meson-build
> +                          (lambda _
> +                            (substitute* "meson.build"
> +                              (("not stable, Description:")
> +                               "not stable, description:")))))))

see https://github.com/hodefoting/mrg/blob/master/README.md
Microraptor gui is discontinued

maybe we should drop this package.


>      (native-inputs
>       (list luajit pkg-config))
>      (inputs
> @@ -169,7 +179,7 @@ (define-public mmm
>      (synopsis "Memory Mapped Machine")
>      (description "MMM is a shared memory protocol for virtualising access to
>  framebuffer graphics, audio output and input event.")
> -    (home-page "https://github.com/hodefoting/mrg")
> +    (home-page "https://github.com/hodefoting/mmm")

should new patch.

>      (license license:isc)))
>  
>  (define-public directfb
>
> base-commit: 487dd0077fed2ef7a91bd71af0e23421ab715710

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 72596-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Cc: 72596-done <at> debbugs.gnu.org
Subject: Re: [bug#72596] [PATCH] gnu: mrg: Fix the build.
Date: Sat, 31 Aug 2024 18:41:59 +0200

"Artyom V. Poptsov" <poptsov.artyom <at> gmail.com> skribis:

> * gnu/packages/graphics.scm (mrg): Fix the build.
> [arguments]: Add "patch-meson-build" phase.
> [home-page]: Fix the URL.
>
> Change-Id: If6f1a255e864669a10c646ee0d991e6fabdcb6b9

Finally applied, thanks!

Message #16 received at 72596 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
Cc: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>, 72596 <at> debbugs.gnu.org
Subject: Re: [bug#72596] [PATCH] gnu: mrg: Fix the build.
Date: Sat, 31 Aug 2024 18:44:02 +0200

Hi Zheng,

Zheng Junjie <zhengjunjie <at> iscas.ac.cn> skribis:

> "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com> writes:
>
>> * gnu/packages/graphics.scm (mrg): Fix the build.
>> [arguments]: Add "patch-meson-build" phase.
>> [home-page]: Fix the URL.
>>
>> Change-Id: If6f1a255e864669a10c646ee0d991e6fabdcb6b9

[...]

>> +                            (substitute* "meson.build"
>> +                              (("not stable, Description:")
>> +                               "not stable, description:")))))))
>
> see https://github.com/hodefoting/mrg/blob/master/README.md
> Microraptor gui is discontinued
>
> maybe we should drop this package.

[...]

>> +    (home-page "https://github.com/hodefoting/mmm")
>
> should new patch.

I applied the patch anyway because it fixes an immediate issue, and
moving the ‘home-page’ to a separate patch is not worth the trouble and
cognitive overhead.  I hope that makes sense.

If you think there are good reasons to remove the package, maybe submit
a patch doing so?

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.