GNU bug report logs - #72592
[PATCH 0/2] Add mpich-ofi variant for Infiniband support.

Previous Next

Package: guix-patches;

Reported by: Romain GARBAGE <romain.garbage <at> inria.fr>

Date: Mon, 12 Aug 2024 14:42:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72592 in the body.
You can then email your comments to 72592 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#72592; Package guix-patches. (Mon, 12 Aug 2024 14:42:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Romain GARBAGE <romain.garbage <at> inria.fr>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Mon, 12 Aug 2024 14:42:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Romain GARBAGE <romain.garbage <at> inria.fr>
To: guix-patches <at> gnu.org
Cc: ludovic.courtes <at> inria.fr, Romain GARBAGE <romain.garbage <at> inria.fr>
Subject: [PATCH 0/2] Add mpich-ofi variant for Infiniband support.
Date: Mon, 12 Aug 2024 16:33:25 +0200
Hello,

This patch series brings the necessary changes in order to get proper
network performance on Infiniband hardware. 

The first patch adds the necessary providers to the libfabric package
for proper Infiniband support.

Since MPICH cannot be compiled with multiple network drivers, a 
variant using libfabric as a driver is added in the second patch.

This patch has been tested with the current Guix version of MPICH as
well as with the newest version for which an update has been submitted
in the issue #72415.

Romain GARBAGE (2):
  gnu: libfabric: Add support for extra providers.
  gnu: Add mpich-ofi.

 gnu/packages/linux.scm |  6 ++++++
 gnu/packages/mpi.scm   | 25 +++++++++++++++++++++++++
 2 files changed, 31 insertions(+)


base-commit: e928854a0f76cef3b11a06160a16130c59954b76
-- 
2.45.2





Information forwarded to guix-patches <at> gnu.org:
bug#72592; Package guix-patches. (Mon, 12 Aug 2024 14:44:01 GMT) Full text and rfc822 format available.

Message #8 received at 72592 <at> debbugs.gnu.org (full text, mbox):

From: Romain GARBAGE <romain.garbage <at> inria.fr>
To: 72592 <at> debbugs.gnu.org
Cc: ludovic.courtes <at> inria.fr, Romain GARBAGE <romain.garbage <at> inria.fr>
Subject: [PATCH 1/2] gnu: libfabric: Add support for extra providers.
Date: Mon, 12 Aug 2024 16:43:00 +0200
* gnu/packages/linux.scm (libfabric) [arguments]: Add configure flags.

Change-Id: I57e43ffd92e8268112e48928af38b0fecc256a67
---
 gnu/packages/linux.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 8ca1df1185..46b921c596 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -8933,7 +8933,13 @@ (define-public libfabric
                        ((member (package-supported-systems psm))
                         `(("psm" ,psm)))
                        (_ `()))
+              ("psm2" ,psm2)
               ("libnl" ,libnl)))
+    (arguments
+     (list #:configure-flags
+           #~(list "--enable-psm2"
+                   "--enable-efa"
+                   "--enable-verbs")))
     (home-page "https://ofiwg.github.io/libfabric/")
     (synopsis "Open Fabric Interfaces")
     (description

base-commit: e928854a0f76cef3b11a06160a16130c59954b76
-- 
2.45.2





Information forwarded to guix-patches <at> gnu.org:
bug#72592; Package guix-patches. (Mon, 12 Aug 2024 14:45:01 GMT) Full text and rfc822 format available.

Message #11 received at 72592 <at> debbugs.gnu.org (full text, mbox):

From: Romain GARBAGE <romain.garbage <at> inria.fr>
To: 72592 <at> debbugs.gnu.org
Cc: ludovic.courtes <at> inria.fr, Romain GARBAGE <romain.garbage <at> inria.fr>
Subject: [PATCH 2/2] gnu: Add mpich-ofi.
Date: Mon, 12 Aug 2024 16:43:01 +0200
* gnu/packages/mpi.scm (mpich-ofi): New variable.

Change-Id: I577fa8fc15ffe7df82d737721ca5a2e034c1e43a
---
 gnu/packages/mpi.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/mpi.scm b/gnu/packages/mpi.scm
index 4c18da30ef..bf70c46247 100644
--- a/gnu/packages/mpi.scm
+++ b/gnu/packages/mpi.scm
@@ -547,3 +547,28 @@ (define-public mpich
 computing systems (Blue Gene, Cray).  It enables research in MPI through a
 modular framework for other derived implementations.")
     (license license:bsd-2)))
+
+(define-public mpich-ofi
+  (package/inherit mpich
+    (name "mpich-ofi")
+    (inputs (modify-inputs (package-inputs mpich)
+              (delete ucx)
+              (append libfabric)
+              (append rdma-core)
+              (append psm2)))
+    (arguments
+      (substitute-keyword-arguments (package-arguments mpich)
+        ((#:configure-flags flags)
+         #~(list "--disable-silent-rules" ;let's see what's happening
+                 "--enable-debuginfo"
+                 "--with-device=ch4:ofi"
+
+                 (string-append "--with-hwloc-prefix="
+                                #$(this-package-input "hwloc"))
+
+                 (string-append "--with-libfabric="
+                                #$(this-package-input "libfabric"))))
+        ((#:phases phases
+          '%standard-phases)
+         phases)))
+    (synopsis "Implementation of the Message Passing Interface (MPI) for OmniPath")))
-- 
2.45.2





Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Mon, 19 Aug 2024 10:35:01 GMT) Full text and rfc822 format available.

Notification sent to Romain GARBAGE <romain.garbage <at> inria.fr>:
bug acknowledged by developer. (Mon, 19 Aug 2024 10:35:02 GMT) Full text and rfc822 format available.

Message #16 received at 72592-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Romain GARBAGE <romain.garbage <at> inria.fr>
Cc: 72592-done <at> debbugs.gnu.org
Subject: Re: [bug#72592] [PATCH 0/2] Add mpich-ofi variant for Infiniband
 support.
Date: Mon, 19 Aug 2024 12:33:12 +0200
Hi Romain,

Romain GARBAGE <romain.garbage <at> inria.fr> skribis:

> Romain GARBAGE (2):
>   gnu: libfabric: Add support for extra providers.
>   gnu: Add mpich-ofi.

Applied, thanks!

Ludo’.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 16 Sep 2024 11:24:10 GMT) Full text and rfc822 format available.

This bug report was last modified 334 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.