Subject: bug#72575: closed (Re: bug#72575: [PATCH-scratch/igc] Fix gcc-8 compile error)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 11 Aug 2024 13:34:02 +0000

Your bug report

#72575: [PATCH-scratch/igc] Fix gcc-8 compile error

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
72575: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=72575
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#72575: [PATCH-scratch/igc] Fix gcc-8 compile error
From: Pip Cet <[email-masked]>
To: Yikai Zhao <[email-masked]>
Cc: "[email-masked]" <[email-masked]>
Date: Sun, 11 Aug 2024 13:32:27 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

On Sunday, August 11th, 2024 at 13:12, Yikai Zhao <[email-masked]> wrote:
> Tags: patch
>
> This is a patch for scratch/igc branch.
>
> Before this commit, with MPS and X11 enabled, gcc-8 would fail to
> compile complaining "label at end of compound statement"

Thank you! Applied and pushed.

I don't know whether you have signed the copyright paperwork, but this change should be exempt in any case.

Thanks for testing this branch! I hope it works for you and would love to hear about any experiences.

(My apologies if you receive this twice, my mail agent was acting up).

Pip

Subject: [PATCH-scratch/igc] Fix gcc-8 compile error
From: Yikai Zhao <[email-masked]>
To: [email-masked]
Date: Sun, 11 Aug 2024 21:12:24 +0800
List-Id: <debbugs-submit.debbugs.gnu.org>

Tags: patch

This is a patch for scratch/igc branch.

Before this commit, with MPS and X11 enabled, gcc-8 would fail to
compile complaining "label at end of compound statement"

>From dd24e92fab736596c5b65245a083a9c6b8e2edd2 Mon Sep 17 00:00:00 2001
From: Yikai Zhao <[email-masked]>
Date: Sun, 11 Aug 2024 20:53:13 +0800
Subject: [PATCH] ; Fix gcc-8 compile error

Before this commit, with MPS and X11 enabled, gcc-8 would fail to
compile complaining "label at end of compound statement"
---
 src/xfaces.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/xfaces.c b/src/xfaces.c
index 69d4070b603..e3b5e867462 100644
--- a/src/xfaces.c
+++ b/src/xfaces.c
@@ -4642,6 +4642,7 @@ free_realized_face (struct frame *f, struct face *face)
 #ifndef HAVE_MPS
       xfree (face);
 #endif
+      (void)0;  /* prevent the above label being the end of a compound statement */
     }
 }
 
-- 
2.44.2